[PATCH] D50347: Add getBeginLoc API to replace getStartLoc

teemperor resigned from this revision. teemperor added a comment. This revision now requires review to proceed. Woops, I wanted to resign actually (and not accept this). Repository: rC Clang https://reviews.llvm.org/D50347 ___ cfe-commits mailing

[PATCH] D50352: Mark up deprecated methods as such

teemperor added a comment. I don't think Clang/LLVM use `[[deprecated]]` anywhere. Just change the API and people have to migrate their code. Repository: rC Clang https://reviews.llvm.org/D50352 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D50550: [ASTImporter] Added test case for opaque enums

teemperor created this revision. Herald added a subscriber: martong. Herald added a reviewer: a.sidorin. Repository: rC Clang https://reviews.llvm.org/D50550 Files: test/Import/enum/Inputs/S.cpp test/Import/enum/test.cpp Index: test/Import/enum/test.cpp ==

[PATCH] D50550: [ASTImporter] Added test case for opaque enums

teemperor updated this revision to Diff 160057. teemperor added a comment. - Removed broken FileCheck directive https://reviews.llvm.org/D50550 Files: test/Import/enum/Inputs/S.cpp test/Import/enum/test.cpp Index: test/Import/enum/test.cpp =

[PATCH] D50552: [ASTImporter] Added test case for CXXConversionDecl importing

teemperor created this revision. Herald added a subscriber: martong. Herald added a reviewer: a.sidorin. Repository: rC Clang https://reviews.llvm.org/D50552 Files: test/Import/conversion-decl/Inputs/F.cpp test/Import/conversion-decl/test.cpp Index: test/Import/conversion-decl/test.cpp =

[PATCH] D50552: [ASTImporter] Added test case for CXXConversionDecl importing

This revision was automatically updated to reflect the committed changes. Closed by commit rL339505: [ASTImporter] Added test case for CXXConversionDecl importing (authored by teemperor, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D

[PATCH] D50550: [ASTImporter] Added test case for opaque enums

This revision was automatically updated to reflect the committed changes. Closed by commit rL339506: [ASTImporter] Added test case for opaque enums (authored by teemperor, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D50550?vs=160057

[PATCH] D50731: [ASTImporter] Add test for ExprWithCleanups

teemperor created this revision. Herald added a subscriber: martong. Herald added a reviewer: a.sidorin. Repository: rC Clang https://reviews.llvm.org/D50731 Files: test/Import/expr-with-cleanups/Inputs/S.cpp test/Import/expr-with-cleanups/test.cpp Index: test/Import/expr-with-cleanups/t

[PATCH] D50732: [ASTImporter] Add test for CXXDefaultInitExpr

teemperor created this revision. Herald added a subscriber: martong. Herald added a reviewer: a.sidorin. Repository: rC Clang https://reviews.llvm.org/D50732 Files: test/Import/cxx-default-init-expr/Inputs/S.cpp test/Import/cxx-default-init-expr/test.cpp Index: test/Import/cxx-default-in

[PATCH] D50733: [ASTImporter] Add test for ArrayInitLoopExpr

teemperor created this revision. Herald added a subscriber: martong. Herald added a reviewer: a.sidorin. Repository: rC Clang https://reviews.llvm.org/D50733 Files: test/Import/array-init-loop-expr/Inputs/S.cpp test/Import/array-init-loop-expr/test.cpp Index: test/Import/array-init-loop-

[PATCH] D50735: [ASTImporter] Add test for CXXScalarValueInit

teemperor created this revision. Herald added a subscriber: martong. Herald added a reviewer: a.sidorin. Repository: rC Clang https://reviews.llvm.org/D50735 Files: test/Import/cxx-scalar-value-init/Inputs/S.cpp test/Import/cxx-scalar-value-init/test.cpp Index: test/Import/cxx-scalar-val

[PATCH] D50737: [ASTImporter] Add test for CXXNoexceptExpr

teemperor created this revision. Herald added a subscriber: martong. Herald added a reviewer: a.sidorin. Repository: rC Clang https://reviews.llvm.org/D50737 Files: test/Import/cxx-noexcept-expr/Inputs/F.cpp test/Import/cxx-noexcept-expr/test.cpp Index: test/Import/cxx-noexcept-expr/test

[PATCH] D50792: [ASTImporter] Add test for member pointer types.

teemperor created this revision. Herald added a subscriber: martong. Herald added a reviewer: a.sidorin. Repository: rC Clang https://reviews.llvm.org/D50792 Files: test/Import/cxx-member-pointers/Inputs/S.cpp test/Import/cxx-member-pointers/test.cpp Index: test/Import/cxx-member-pointer

[PATCH] D50793: [ASTImporter] Add test for importing CompoundAssignOperators

teemperor created this revision. Herald added a subscriber: martong. Herald added a reviewer: a.sidorin. Repository: rC Clang https://reviews.llvm.org/D50793 Files: test/Import/compound-assign-op/Inputs/F.cpp test/Import/compound-assign-op/test.cpp Index: test/Import/compound-assign-op/t

[PATCH] D50796: [ASTImporter] Add test for IfStmt

teemperor created this revision. Herald added a subscriber: martong. Herald added a reviewer: a.sidorin. Repository: rC Clang https://reviews.llvm.org/D50796 Files: test/Import/if-stmt/Inputs/F.cpp test/Import/if-stmt/test.cpp Index: test/Import/if-stmt/test.cpp =

[PATCH] D50810: [ASTImporter] Add test for DoStmt

teemperor created this revision. Herald added a subscriber: martong. Herald added a reviewer: a.sidorin. Repository: rC Clang https://reviews.llvm.org/D50810 Files: test/Import/do-stmt/Inputs/F.cpp test/Import/do-stmt/test.cpp Index: test/Import/do-stmt/test.cpp =

[PATCH] D50811: [ASTImporter] Add test for WhileStmt

teemperor created this revision. Herald added a subscriber: martong. Herald added a reviewer: a.sidorin. Repository: rC Clang https://reviews.llvm.org/D50811 Files: test/Import/while-stmt/Inputs/F.cpp test/Import/while-stmt/test.cpp Index: test/Import/while-stmt/test.cpp

[PATCH] D50812: [ASTImporter] Add test for ForStmt and ContinueStmt

teemperor created this revision. Herald added a subscriber: martong. Herald added a reviewer: a.sidorin. Repository: rC Clang https://reviews.llvm.org/D50812 Files: test/Import/for-stmt/Inputs/F.cpp test/Import/for-stmt/test.cpp Index: test/Import/for-stmt/test.cpp ==

[PATCH] D50813: [ASTImporter] Add test for IndirectGotoStmt

teemperor created this revision. Herald added a subscriber: martong. Herald added a reviewer: a.sidorin. Repository: rC Clang https://reviews.llvm.org/D50813 Files: test/Import/indirect-goto/Inputs/F.cpp test/Import/indirect-goto/test.cpp Index: test/Import/indirect-goto/test.cpp ===

[PATCH] D50732: [ASTImporter] Add test for CXXDefaultInitExpr

teemperor added a comment. As a side note: It seems this test case actually reveals that we don't import the body of Foo's destructor? test/Import/cxx-default-init-expr/Inputs/S.cpp:1:8: inline function 'Foo::~Foo' is not defined struct Foo { ^ test/Import/cxx-default-init-expr/I

[PATCH] D50796: [ASTImporter] Add test for IfStmt

This revision was automatically updated to reflect the committed changes. Closed by commit rL339825: [ASTImporter] Add test for IfStmt (authored by teemperor, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D50796?vs=160876&id=160930#to

[PATCH] D50731: [ASTImporter] Add test for ExprWithCleanups

This revision was automatically updated to reflect the committed changes. Closed by commit rC339830: [ASTImporter] Add test for ExprWithCleanups (authored by teemperor, committed by ). Repository: rC Clang https://reviews.llvm.org/D50731 Files: test/Import/expr-with-cleanups/Inputs/S.cpp

[PATCH] D50733: [ASTImporter] Add test for ArrayInitLoopExpr

This revision was automatically updated to reflect the committed changes. Closed by commit rL339831: [ASTImporter] Add test for ArrayInitLoopExpr (authored by teemperor, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D50733?vs=160682&i

[PATCH] D50812: [ASTImporter] Add test for ForStmt and ContinueStmt

This revision was automatically updated to reflect the committed changes. Closed by commit rL339837: [ASTImporter] Add test for ForStmt and ContinueStmt (authored by teemperor, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D50812?vs=1

[PATCH] D50735: [ASTImporter] Add test for CXXScalarValueInit

This revision was automatically updated to reflect the committed changes. Closed by commit rL339838: [ASTImporter] Add test for CXXScalarValueInit (authored by teemperor, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D50735?vs=160685&

[PATCH] D50732: [ASTImporter] Add test for CXXDefaultInitExpr

This revision was automatically updated to reflect the committed changes. Closed by commit rL339839: [ASTImporter] Add test for CXXDefaultInitExpr (authored by teemperor, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D50732?vs=160678&

[PATCH] D50813: [ASTImporter] Add test for IndirectGotoStmt

This revision was automatically updated to reflect the committed changes. Closed by commit rC339915: [ASTImporter] Add test for IndirectGotoStmt (authored by teemperor, committed by ). Repository: rC Clang https://reviews.llvm.org/D50813 Files: test/Import/indirect-goto/Inputs/F.cpp test/

[PATCH] D50811: [ASTImporter] Add test for WhileStmt

This revision was automatically updated to reflect the committed changes. Closed by commit rL339916: [ASTImporter] Add test for WhileStmt (authored by teemperor, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D50811?vs=160919&id=161074

[PATCH] D50810: [ASTImporter] Add test for DoStmt

This revision was automatically updated to reflect the committed changes. Closed by commit rL339917: [ASTImporter] Add test for DoStmt (authored by teemperor, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D50810?vs=160918&id=161075#to

[PATCH] D50793: [ASTImporter] Add test for importing CompoundAssignOperators

This revision was automatically updated to reflect the committed changes. Closed by commit rL339918: [ASTImporter] Add test for importing CompoundAssignOperators (authored by teemperor, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D5

[PATCH] D50792: [ASTImporter] Add test for member pointer types.

This revision was automatically updated to reflect the committed changes. Closed by commit rL339919: [ASTImporter] Add test for member pointer types. (authored by teemperor, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D50792?vs=1608

[PATCH] D50928: [ASTImporter] Test for importing condition variable from a ForStmt

teemperor created this revision. Herald added a subscriber: martong. Herald added a reviewer: a.sidorin. Repository: rC Clang https://reviews.llvm.org/D50928 Files: test/Import/for-stmt/Inputs/F.cpp test/Import/for-stmt/test.cpp Index: test/Import/for-stmt/test.cpp ==

[PATCH] D50932: [ASTImporter] Add test for C++ casts and fix broken const_cast importing.

teemperor created this revision. Herald added a subscriber: martong. Herald added a reviewer: a.sidorin. Repository: rC Clang https://reviews.llvm.org/D50932 Files: lib/AST/ASTImporter.cpp test/Import/cxx-casts/Inputs/F.cpp test/Import/cxx-casts/test.cpp tools/clang-import-test/clang-i

[PATCH] D50928: [ASTImporter] Test for importing condition variable from a ForStmt

This revision was automatically updated to reflect the committed changes. Closed by commit rC340180: [ASTImporter] Test for importing condition variable from a ForStmt (authored by teemperor, committed by ). Changed prior to commit: https://reviews.llvm.org/D50928?vs=161342&id=161493#toc Repos

[PATCH] D50932: [ASTImporter] Add test for C++ casts and fix broken const_cast importing.

teemperor updated this revision to Diff 161496. teemperor added a comment. - Added comment why we enable RTTI. https://reviews.llvm.org/D50932 Files: lib/AST/ASTImporter.cpp test/Import/cxx-casts/Inputs/F.cpp test/Import/cxx-casts/test.cpp tools/clang-import-test/clang-import-test.cpp

[PATCH] D50932: [ASTImporter] Add test for C++ casts and fix broken const_cast importing.

This revision was automatically updated to reflect the committed changes. Closed by commit rL340182: [ASTImporter] Add test for C++ casts and fix broken const_cast importing. (authored by teemperor, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://review

[PATCH] D50978: [ASTImporter] Add test for C++'s try/catch statements.

teemperor created this revision. Herald added subscribers: cfe-commits, martong. Herald added a reviewer: a.sidorin. Also enable exceptions in clang-import-test so that we can parse the test files. Repository: rC Clang https://reviews.llvm.org/D50978 Files: test/Import/cxx-try-catch/Inputs

[PATCH] D51001: [ASTImporter] Add test for CXXForRangeStmt

teemperor created this revision. Herald added subscribers: cfe-commits, martong. Herald added a reviewer: a.sidorin. Repository: rC Clang https://reviews.llvm.org/D51001 Files: test/Import/cxx-for-range/Inputs/F.cpp test/Import/cxx-for-range/test.cpp Index: test/Import/cxx-for-range/test

[PATCH] D50978: [ASTImporter] Add test for C++'s try/catch statements.

teemperor updated this revision to Diff 161580. teemperor added a comment. - Clarified that the Exception options in LangOpts are not related to the dynamic_cast support by moving them above the comment (Thanks Aleksei!) https://reviews.llvm.org/D50978 Files: test/Import/cxx-try-catch/Inputs

[PATCH] D50978: [ASTImporter] Add test for C++'s try/catch statements.

This revision was automatically updated to reflect the committed changes. Closed by commit rC340220: [ASTImporter] Add test for C++'s try/catch statements. (authored by teemperor, committed by ). Repository: rC Clang https://reviews.llvm.org/D50978 Files: test/Import/cxx-try-catch/Inputs/F.

[PATCH] D51001: [ASTImporter] Add test for CXXForRangeStmt

This revision was automatically updated to reflect the committed changes. Closed by commit rC340297: [ASTImporter] Add test for CXXForRangeStmt (authored by teemperor, committed by ). Repository: rC Clang https://reviews.llvm.org/D51001 Files: test/Import/cxx-for-range/Inputs/F.cpp test/I

[PATCH] D50737: [ASTImporter] Add test for CXXNoexceptExpr

teemperor added inline comments. Comment at: test/Import/cxx-noexcept-expr/test.cpp:1 +// RUN: clang-import-test -dump-ast -import %S/Inputs/F.cpp -expression %s | FileCheck %s + hiraditya wrote: > Can we add a line/comment to explain what this test does? Same f

[PATCH] D50737: [ASTImporter] Add test for CXXNoexceptExpr

This revision was automatically updated to reflect the committed changes. Closed by commit rC340304: [ASTImporter] Add test for CXXNoexceptExpr (authored by teemperor, committed by ). Repository: rC Clang https://reviews.llvm.org/D50737 Files: test/Import/cxx-noexcept-expr/Inputs/F.cpp te

[PATCH] D51056: [ASTImporter] Add test for SwitchStmt

teemperor created this revision. Herald added subscribers: cfe-commits, martong. Herald added a reviewer: a.sidorin. Repository: rC Clang https://reviews.llvm.org/D51056 Files: test/Import/switch-stmt/Inputs/F.cpp test/Import/switch-stmt/test.cpp Index: test/Import/switch-stmt/test.cpp =

[PATCH] D51110: [ASTImporter] Remove duplicated and dead CXXNamedCastExpr handling code.

teemperor added a comment. See http://lab.llvm.org:8080/coverage/coverage-reports/clang/coverage/Users/buildslave/jenkins/workspace/clang-stage2-coverage-R/llvm/tools/clang/lib/AST/ASTImporter.cpp.html#L6044 for the test coverage entry. Repository: rC Clang https://reviews.llvm.org/D51110

[PATCH] D51110: [ASTImporter] Remove duplicated and dead CXXNamedCastExpr handling code.

teemperor created this revision. Herald added subscribers: cfe-commits, martong. Herald added a reviewer: a.sidorin. `CXXNamedCastExpr` importing is already handled in the respective `VisitCXXNamedCastExpr` method. So this code here can never be reached under normal circumstances and we might as

[PATCH] D51115: [ASTImporter] Actually test ArrayInitLoopExpr in the array-init-loop-expr test.

teemperor created this revision. Herald added subscribers: cfe-commits, martong. Herald added a reviewer: a.sidorin. The `array-init-loop-expr` test is currently not testing the importing of ArrayInitLoopExprs. This is because we import the `S` struct into the `test.cpp` context and only do a co

[PATCH] D51121: [ASTImporter] Add test for ObjCAtTryStmt/ObjCAtCatchStmt/ObjCAtThrowStmt

teemperor created this revision. Herald added subscribers: cfe-commits, martong. Herald added a reviewer: a.sidorin. Repository: rC Clang https://reviews.llvm.org/D51121 Files: test/Import/objc-try-catch/Inputs/F.m test/Import/objc-try-catch/test.m Index: test/Import/objc-try-catch/test.

[PATCH] D51121: [ASTImporter] Add test for ObjCAtTryStmt/ObjCAtCatchStmt/ObjCAtThrowStmt

teemperor added a comment. Turns out, the clang-import-test actually allows passing clang args via `-Xcc`, so I probably will revert the lang options changes I did in the previous commits. Repository: rC Clang https://reviews.llvm.org/D51121 __

[PATCH] D51123: [ASTImporter] Add test for ObjCAutoreleasePoolStmt

teemperor created this revision. Herald added subscribers: cfe-commits, martong. Herald added a reviewer: a.sidorin. Repository: rC Clang https://reviews.llvm.org/D51123 Files: test/Import/objc-autoreleasepool/Inputs/F.m test/Import/objc-autoreleasepool/test.m Index: test/Import/objc-aut

[PATCH] D51121: [ASTImporter] Add test for ObjCAtTryStmt/ObjCAtCatchStmt/ObjCAtThrowStmt

teemperor added inline comments. Comment at: test/Import/objc-try-catch/Inputs/F.m:9 +Exception *e; +@throw e; + } We usually should create a expression here, but the ObjCMessageExpr isn't implemented yet, so this bit weird code has to do the job. Rep

[PATCH] D51123: [ASTImporter] Add test for ObjCAutoreleasePoolStmt

This revision was automatically updated to reflect the committed changes. Closed by commit rC340463: [ASTImporter] Add test for ObjCAutoreleasePoolStmt (authored by teemperor, committed by ). Repository: rC Clang https://reviews.llvm.org/D51123 Files: test/Import/objc-autoreleasepool/Inputs

[PATCH] D51056: [ASTImporter] Add test for SwitchStmt

This revision was automatically updated to reflect the committed changes. Closed by commit rL340464: [ASTImporter] Add test for SwitchStmt (authored by teemperor, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D51056?vs=161798&id=16208

[PATCH] D51059: [ASTImporter] Add test for ObjCTypeParamDecl

This revision was automatically updated to reflect the committed changes. Closed by commit rC340465: [ASTImporter] Add test for ObjCTypeParamDecl (authored by teemperor, committed by ). Repository: rC Clang https://reviews.llvm.org/D51059 Files: test/Import/objc-param-decl/Inputs/S.m test

[PATCH] D51110: [ASTImporter] Remove duplicated and dead CXXNamedCastExpr handling code.

This revision was automatically updated to reflect the committed changes. Closed by commit rC340466: [ASTImporter] Remove duplicated and dead CXXNamedCastExpr handling code. (authored by teemperor, committed by ). Changed prior to commit: https://reviews.llvm.org/D51110?vs=161994&id=162084#toc

[PATCH] D51115: [ASTImporter] Actually test ArrayInitLoopExpr in the array-init-loop-expr test.

This revision was automatically updated to reflect the committed changes. Closed by commit rL340467: [ASTImporter] Actually test ArrayInitLoopExpr in the array-init-loop-expr test. (authored by teemperor, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://

[PATCH] D51121: [ASTImporter] Add test for ObjCAtTryStmt/ObjCAtCatchStmt/ObjCAtThrowStmt

This revision was automatically updated to reflect the committed changes. Closed by commit rC340468: [ASTImporter] Add test for ObjCAtTryStmt/ObjCAtCatchStmt/ObjCAtThrowStmt (authored by teemperor, committed by ). Repository: rC Clang https://reviews.llvm.org/D51121 Files: test/Import/objc

[PATCH] D51142: [ASTImporter] Add test for PackExpansionExpr

teemperor created this revision. Herald added subscribers: cfe-commits, martong. Herald added a reviewer: a.sidorin. Repository: rC Clang https://reviews.llvm.org/D51142 Files: test/Import/pack-expansion-expr/Inputs/F.cpp test/Import/pack-expansion-expr/test.cpp Index: test/Import/pack-e

[PATCH] D47164: Add missing include for cstdint to Visibility.h

teemperor created this revision. We use uint8_t in this header, so we need to include cstdint. Repository: rC Clang https://reviews.llvm.org/D47164 Files: include/clang/Basic/Visibility.h Index: include/clang/Basic/Visibility.h

[PATCH] D47164: Add missing include for cstdint to Visibility.h

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL332913: Add missing include for cstdint to Visibility.h (authored by teemperor, committed by ). Herald added a subscriber:

[PATCH] D47247: Fix unaligned memory access when reading INPUT_FILE_OFFSETS data

teemperor created this revision. teemperor added reviewers: rsmith, v.g.vassilev. The blob data is unaligned, so we also should read it as such. Should fix the random failures with the sanitizer builds. Repository: rC Clang https://reviews.llvm.org/D47247 Files: lib/Serialization/ASTReade

[PATCH] D47247: Fix unaligned memory access when reading INPUT_FILE_OFFSETS data

This revision was automatically updated to reflect the committed changes. Closed by commit rL333069: Fix unaligned memory access when reading INPUT_FILE_OFFSETS data (authored by teemperor, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.or

[PATCH] D47277: [modules] Mark __wmmintrin_pclmul.h/__wmmintrin_aes.h as textual

teemperor created this revision. teemperor added reviewers: rsmith, slydiman. Since clang r332929 these two headers throw errors when included from somewhere else than their wrapper header. It seems marking them as textual is the best way to fix the builds. Fixes this new module build error:

[PATCH] D47277: [modules] Mark __wmmintrin_pclmul.h/__wmmintrin_aes.h as textual

teemperor edited reviewers, added: v.g.vassilev; removed: slydiman. teemperor added a comment. (Wrong Vassil, sorry) https://reviews.llvm.org/D47277 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listin

[PATCH] D47277: [modules] Mark __wmmintrin_pclmul.h/__wmmintrin_aes.h as textual

This revision was automatically updated to reflect the committed changes. Closed by commit rL333123: [modules] Mark __wmmintrin_pclmul.h/__wmmintrin_aes.h as textual (authored by teemperor, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.o

[PATCH] D51178: [ASTImporter] Add test for importing anonymous namespaces.

teemperor created this revision. Herald added subscribers: cfe-commits, martong. Herald added a reviewer: a.sidorin. Repository: rC Clang https://reviews.llvm.org/D51178 Files: test/Import/cxx-anon-namespace/Inputs/F.cpp test/Import/cxx-anon-namespace/test.cpp Index: test/Import/cxx-anon

[PATCH] D51142: [ASTImporter] Add test for PackExpansionExpr

This revision was automatically updated to reflect the committed changes. Closed by commit rL340627: [ASTImporter] Add test for PackExpansionExpr (authored by teemperor, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D51142?vs=162104&i

[PATCH] D43871: [modules] No longer include stdlib.h from mm_malloc.h.

teemperor updated this revision to Diff 162902. teemperor added a comment. - Now using UpdateExceptionSpec. - Added a comment to the SemaExceptionSpec.cpp code why we are permitting this. https://reviews.llvm.org/D43871 Files: lib/Headers/mm_malloc.h lib/Sema/SemaExceptionSpec.cpp test/CX

[PATCH] D43871: [modules] No longer include stdlib.h from mm_malloc.h.

teemperor marked 3 inline comments as done. teemperor added inline comments. Comment at: test/CXX/except/except.spec/libc-empty-except.cpp:6 +#include "libc-empty-except.h" + +void f() { bruno wrote: > In a testcase like this but using the actual real headers, if

[PATCH] D43871: [modules] No longer include stdlib.h from mm_malloc.h.

teemperor updated this revision to Diff 162940. teemperor marked an inline comment as done. teemperor added a comment. - Reverted unintended change to test case that slipped into the latest diff. https://reviews.llvm.org/D43871 Files: lib/Headers/mm_malloc.h lib/Sema/SemaExceptionSpec.cpp

[PATCH] D43871: [modules] No longer include stdlib.h from mm_malloc.h.

teemperor updated this revision to Diff 164885. teemperor marked 3 inline comments as done. teemperor added a comment. - Removed comment about redeclaring free in the test. That's wasn't correctly formulated and is anyway no longer true now that the test case including this file got bigger. - Fi

[PATCH] D43871: [modules] No longer include stdlib.h from mm_malloc.h.

teemperor planned changes to this revision. teemperor marked an inline comment as done. teemperor added a comment. (Just marking this as "Plan changes" because otherwise it's just stuck in my "Waiting on review" queue). https://reviews.llvm.org/D43871

[PATCH] D34022: Repair 2010-05-31-palignr.c test

teemperor created this revision. This test was silently failing since a long time because it failed to include stdlib.h (as it's running in a freestanding environment). However, because we used just `not clang_cc1` instead of the verify mode, this regression was never noticed and the test was j

[PATCH] D33366: Fix that global delete operator get's assigned to a submodule.

teemperor updated this revision to Diff 101877. teemperor added a comment. - Just unconditionally calling `setHidden` now. IIRC I had to put the conditions for the module builds because setLocalOwningModule did trigger some tests/asserts, otherwise but the setHidden works fine like this. htt

[PATCH] D34182: [analyzer] Performance optimizations for the CloneChecker

teemperor created this revision. Herald added a subscriber: xazax.hun. This patch aims at optimizing the CloneChecker for larger programs. Before this patch we took around 102 seconds to analyze sqlite3 with a complexity value of 50. After this patch we now take 2.1 seconds to analyze sqlite3.

[PATCH] D34182: [analyzer] Performance optimizations for the CloneChecker

teemperor added inline comments. Comment at: include/clang/Analysis/CloneDetection.h:263 +public: + void constrain(std::vector &Sequences); +}; v.g.vassilev wrote: > Could we typedef `std::vector` into > `CloneDetector::CloneGroups`? Yes, I'll do this in anothe

[PATCH] D32341: Fix a bug that warnings generated with -M or -MM flags

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, good job! (Sorry for the delay, I think I got interrupted here by the GSoC start...) https://reviews.llvm.org/D32341 ___ cfe-commits

[PATCH] D32646: Fix a bug that -Wmissing-braces fires on system headers

teemperor added a comment. Everything beside this last test case seems to be handled. And from what I remember there was a longer discussion how to properly handle this case and so this review got stuck. Can we add this last test case with a FIXME and then get this merged? https://reviews.llv

[PATCH] D31320: [analyzer] Teach CloneDetection about Qt Meta-Object Compiler

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. Sorry for the delay, we got stuck because hard coding a certain file pattern into the clang source code doesn't seem to be a optimal solution (e.g. every user that has a differ

[PATCH] D34182: [analyzer] Performance optimizations for the CloneChecker

teemperor updated this revision to Diff 102700. teemperor marked an inline comment as done. teemperor added a comment. - made saveHash static. https://reviews.llvm.org/D34182 Files: include/clang/Analysis/CloneDetection.h lib/Analysis/CloneDetection.cpp lib/StaticAnalyzer/Checkers/CloneCh

[PATCH] D31320: [analyzer] Teach CloneDetection about Qt Meta-Object Compiler

teemperor added a comment. See my inline comments about technical changes, but otherwise this looks ready to land. Please update and I'll give green light ASAP. Thanks! Comment at: lib/Analysis/CloneDetection.cpp:375 +const Decl *D = S.getContainingDecl(); +const Sourc

[PATCH] D31320: [analyzer] Teach CloneDetection about Qt Meta-Object Compiler

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. Please check the last inline comment and then feel free to commit it with the suggested fix. And I wanted to wait for review on the other performance patches, so you can push this now.

[PATCH] D31320: [analyzer] Teach CloneDetection about Qt Meta-Object Compiler

teemperor accepted this revision. teemperor added a comment. LGTM, thanks for the patch! Repository: rL LLVM https://reviews.llvm.org/D31320 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[PATCH] D33383: [GSoC] Flag value completion for clang

teemperor accepted this revision. teemperor added a comment. LGTM. https://reviews.llvm.org/D33383 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D31320: [analyzer] Teach CloneDetection about Qt Meta-Object Compiler

teemperor added inline comments. Comment at: cfe/trunk/include/clang/Analysis/CloneDetection.h:324 +struct AutoGeneratedCloneConstraint { + StringRef IgnoredFilesPattern; xiangzhai wrote: > v.g.vassilev wrote: > > Shouldn't the name be more generic. What this

[PATCH] D34353: [analyzer] Teach CloneDetection about Qt Meta-Object Compiler to filter auto generated files

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rL LLVM https://reviews.llvm.org/D34353 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.l

[PATCH] D34439: Add GCC's noexcept-type alias for c++1z-compat-mangling

teemperor created this revision. GCC has named this `-Wnoexcept-type`, so let's add an alias to stay compatible with the GCC flags. https://reviews.llvm.org/D34439 Files: include/clang/Basic/DiagnosticGroups.td test/SemaCXX/cxx1z-noexcept-function-type.cpp Index: test/SemaCXX/cxx1z-noexc

[PATCH] D34439: Add GCC's noexcept-type alias for c++1z-compat-mangling

teemperor added a comment. @ahatanak I think we can leave the more expressive clang name for this warning and just add the bit cryptic GCC name for compability. But I don't have a strong opinion on this. https://reviews.llvm.org/D34439 ___ cfe-com

[PATCH] D34607: [Bash-autocompletion] Check clang version in Bash

teemperor accepted this revision. teemperor added a comment. Works as intended, good job! https://reviews.llvm.org/D34607 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43809: Add possibility to specify output stream for CompilerInstance

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. See the inline comments. Please run clang-format over this patch after addressing them (there are a few indentation issues). Comment at: include/clang/Fronte

[PATCH] D43809: Add possibility to specify output stream for CompilerInstance

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM! Repository: rC Clang https://reviews.llvm.org/D43809 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org

[PATCH] D43871: [modules] No longer include stdlib.h from mm_malloc.h.

teemperor created this revision. teemperor added reviewers: rsmith, v.g.vassilev, chandlerc. The GNU C library includes headers from the `_Builtin_intrinsics` module. As the `_Builtin_intrinsics` module via the `mm_malloc.h` header also includes the `stdlib.h` header from libc, we get a cyclic d

[PATCH] D39342: [Bash-autocompletion] Pass all flags in shell command-line to Clang

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. As this will land in clang 7, can you add a note to the release notes that this breaks backwards compatibility for this interface (can be another commit)? Also, we should point out that

[PATCH] D44191: Add Clang ReleaseNotes that --autocomplete breaks backward compatibily

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D44191 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinf

[PATCH] D48062: Fix that AlignedAllocation.h doesn't compile because of VersionTuple

teemperor created this revision. https://reviews.llvm.org/rL334399 put VersionTuple in the llvm namespace, but this header still assumes it's in the clang namespace. This leads to compilation failures with enabled modules when building Clang. Repository: rC Clang https://reviews.llvm.org/D48

[PATCH] D48062: Fix that AlignedAllocation.h doesn't compile because of VersionTuple

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rC334471: Fix that AlignedAllocation.h doesn't compile because of VersionTuple (authored by teemperor, committed by ). Repo

[PATCH] D53639: [autocompletion] Handle the space before pressing tab

teemperor requested changes to this revision. teemperor added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Driver/Driver.cpp:1514 + // which should end up in a file completion. + bool HasSpace = false; + if (PassedFlags.endswith(",")) -

[PATCH] D53639: [autocompletion] Handle the space before pressing tab

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D53639 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinf

[PATCH] D56651: [ASTImporter] Fix importing OperatorDelete from CXXConstructorDecl

teemperor created this revision. teemperor added reviewers: shafik, martong, a_sidorin. Herald added subscribers: cfe-commits, rnkovacs. Herald added a reviewer: a.sidorin. Shafik found out that importing a CXXConstructorDecl will create a translation unit that causes Clang's CodeGen to crash. Th

[PATCH] D56651: [ASTImporter] Fix importing OperatorDelete from CXXConstructorDecl

teemperor added a comment. Didn't really upstream any non-trivial ASTImporter patches yet, so please point out any style errors. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56651/new/ https://reviews.llvm.org/D56651 _

  1   2   3   4   >