[PATCH] D95745: Support unwinding from inline assembly

cynecx added a comment. I would be great if someone with commit rights could push this through since I don't have commit rights :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95745/new/ https://reviews.llvm.org/D95745 __

[PATCH] D95745: Support unwinding from inline assembly

cynecx added a comment. @Amanieu Thanks for the review and commit! :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95745/new/ https://reviews.llvm.org/D95745 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D95745: Support unwinding from inline assembly

cynecx added a comment. Hmm, there is build-failure when buildbot is running extended tests (MachineVerifier): https://lab.llvm.org/buildbot/#/builders/16/builds/10825 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95745/new/ https://reviews.llvm.o

[PATCH] D95745: Support unwinding from inline assembly

cynecx added a comment. Something unrelated might be wrong with the test because I can reproduce the MachineVerifier issue (liveins + non-entry/landingpad) on llvm-stable (11.1) and even without the inline-asm call (replaced by a normal invoke to the target). Repository: rG LLVM Github Mono

[PATCH] D95745: Support unwinding from inline assembly

cynecx added a comment. Okay. This is a known issue https://bugs.llvm.org/show_bug.cgi?id=39439. I'll upload a new patch which includes`-verify-machineinstrs=0` as a temporary workaround. (See the sjlj-eh.ll test) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D95745: Support unwinding from inline assembly

cynecx added a comment. https://reviews.llvm.org/D102433 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95745/new/ https://reviews.llvm.org/D95745 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D95745: Support unwinding from inline assembly

cynecx created this revision. cynecx added reviewers: LLVM, clang. cynecx added projects: LLVM, clang. Herald added a reviewer: deadalnix. Herald added subscribers: dexonsmith, hiraditya. cynecx requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, aheejin. I have

[PATCH] D95745: Support unwinding from inline assembly

cynecx added a comment. Tests are missing right now. But I'd like to get some feedback first whether this approach goes in the right direction. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95745/new/ https://reviews.llvm.org/D95745 _

[PATCH] D96052: [clang] add new unwind inline asm clobber which lowers to throwable inline assembly

cynecx created this revision. cynecx requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D96052 Files: clang/lib/Basic/TargetInfo.cpp clang/lib/CodeGen/CGStmt.cpp clang/lib/

[PATCH] D96053: [clang] add new unwind inline asm clobber which lowers to throwable inline assembly

cynecx created this revision. cynecx requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D96053 Files: clang/lib/Basic/TargetInfo.cpp clang/lib/CodeGen/CGStmt.cpp clang/lib/

[PATCH] D96054: Support unwinding from inline assembly

cynecx created this revision. cynecx requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D96054 Files: clang/lib/Basic/TargetInfo.cpp clang/lib/CodeGen/CGStmt.cpp clang/lib/

[PATCH] D95745: Support unwinding from inline assembly

cynecx updated this revision to Diff 321479. cynecx added a comment. clang-format changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95745/new/ https://reviews.llvm.org/D95745 Files: clang/lib/Basic/TargetInfo.cpp clang/lib/CodeGen/CGStmt.c

[PATCH] D95745: Support unwinding from inline assembly

cynecx updated this revision to Diff 325323. cynecx edited the summary of this revision. cynecx added a comment. Herald added a subscriber: pengfei. Added tests and updated splitted patchset. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95745/new/

[PATCH] D95745: Support unwinding from inline assembly

cynecx added a comment. @rnk This is ready for a proper review :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95745/new/ https://reviews.llvm.org/D95745 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D95745: Support unwinding from inline assembly

cynecx updated this revision to Diff 325328. cynecx added a comment. clang-format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95745/new/ https://reviews.llvm.org/D95745 Files: clang/lib/Basic/TargetInfo.cpp clang/lib/CodeGen/CGStmt.cpp clang/lib/Sema/SemaStmtAsm.cpp clang/tes

[PATCH] D95745: Support unwinding from inline assembly

cynecx added a comment. Weekly ping :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95745/new/ https://reviews.llvm.org/D95745 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[PATCH] D95745: Support unwinding from inline assembly

cynecx added a comment. Weekly ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95745/new/ https://reviews.llvm.org/D95745 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25051: Fix PR 10758: Infinite recursion when dealing with copy-initialization

cynecx added a comment. Would it be possible to land this patch? I would really like to see this fixed. Repository: rL LLVM https://reviews.llvm.org/D25051 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mail

[PATCH] D25051: Fix PR 10758: Infinite recursion when dealing with copy-initialization

cynecx added a comment. Gentle ping. Repository: rL LLVM https://reviews.llvm.org/D25051 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D95745: Support unwinding from inline assembly

cynecx updated this revision to Diff 343853. cynecx marked 4 inline comments as done. cynecx added a comment. Address review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95745/new/ https://reviews.llvm.org/D95745 Files: clang/include/clang/Basi

[PATCH] D95745: Support unwinding from inline assembly

cynecx added inline comments. Comment at: llvm/lib/CodeGen/GlobalISel/IRTranslator.cpp:2446 +if (!IA->canThrow()) { + // Fast path without emitting EH_LABELs. + Amanieu wrote: > Is this fast path actually useful? The frontend will almost never emit an >

[PATCH] D95745: Support unwinding from inline assembly

cynecx added a comment. Sorry about the delay. I've updated and rebased the patchset (which also includes tests for different exception models like seh/sjlj). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95745/new/ https://reviews.llvm.org/D95745

[PATCH] D95745: Support unwinding from inline assembly

cynecx updated this revision to Diff 343924. cynecx added a comment. Fix assertion and clang-format patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95745/new/ https://reviews.llvm.org/D95745 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Basic/TargetInfo.cpp

[PATCH] D95745: Support unwinding from inline assembly

cynecx updated this revision to Diff 343932. cynecx added a comment. actually run clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95745/new/ https://reviews.llvm.org/D95745 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td cla

[PATCH] D95745: Support unwinding from inline assembly

cynecx added a comment. Weekly Ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95745/new/ https://reviews.llvm.org/D95745 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits