Author: paulhoad
Date: Tue Jan 15 14:06:49 2019
New Revision: 351261
URL: http://llvm.org/viewvc/llvm-project?rev=351261&view=rev
Log:
[clang-tidy] add options documentation to readability-identifier-naming checker
Summary:
The documentation for this clang-checker did not explain what the options
Author: paulhoad
Date: Thu Feb 28 12:00:48 2019
New Revision: 355132
URL: http://llvm.org/viewvc/llvm-project?rev=355132&view=rev
Log:
[clang-tidy] add OverrideMacro to modernize-use-override check
Summary:
The usefulness of **modernize-use-override** can be reduced if you have to live
in an env
Author: paulhoad
Date: Fri Mar 1 01:09:54 2019
New Revision: 355182
URL: http://llvm.org/viewvc/llvm-project?rev=355182&view=rev
Log:
[clang-format] [NFC] clang-format the Format library
Previously revisions commited non-clang-formatted changes to the Format
library, this means submitting any r
Author: paulhoad
Date: Sat Mar 2 01:08:51 2019
New Revision: 355266
URL: http://llvm.org/viewvc/llvm-project?rev=355266&view=rev
Log:
[clang-format] clang-format off/on not respected when using C Style comments
Summary:
If the clang-format on/off is in a /* comment */ then the sorting of headers
Author: paulhoad
Date: Tue Mar 5 14:20:25 2019
New Revision: 355450
URL: http://llvm.org/viewvc/llvm-project?rev=355450&view=rev
Log:
[clang-format] broken after lambda with return type template with boolean
literal
Summary:
A Lamdba with a return type template with a boolean literal (true,fals
Author: paulhoad
Date: Wed Mar 13 01:07:46 2019
New Revision: 356029
URL: http://llvm.org/viewvc/llvm-project?rev=356029&view=rev
Log:
[clang-format] [PR25010] AllowShortIfStatementsOnASingleLine not working if an
"else" statement is present
Summary:
Addressing: PR25010 - https://bugs.llvm.org/s
Author: paulhoad
Date: Wed Mar 13 01:07:46 2019
New Revision: 356029
URL: http://llvm.org/viewvc/llvm-project?rev=356029&view=rev
Log:
[clang-format] [PR25010] AllowShortIfStatementsOnASingleLine not working if an
"else" statement is present
Summary:
Addressing: PR25010 - https://bugs.llvm.org/s
Author: paulhoad
Date: Wed Mar 13 01:15:03 2019
New Revision: 356030
URL: http://llvm.org/viewvc/llvm-project?rev=356030&view=rev
Log:
Revert "[clang-format] [PR25010] AllowShortIfStatementsOnASingleLine not
working if an "else" statement is present"
This reverts commit b358cbb9b78389e20f7be36e1
Author: paulhoad
Date: Wed Mar 13 01:15:03 2019
New Revision: 356030
URL: http://llvm.org/viewvc/llvm-project?rev=356030&view=rev
Log:
Revert "[clang-format] [PR25010] AllowShortIfStatementsOnASingleLine not
working if an "else" statement is present"
This reverts commit b358cbb9b78389e20f7be36e1
Author: paulhoad
Date: Wed Mar 13 01:26:39 2019
New Revision: 356031
URL: http://llvm.org/viewvc/llvm-project?rev=356031&view=rev
Log:
[clang-format] [PR25010] AllowShortIfStatementsOnASingleLine not working if an
"else" statement is present
Summary:
Addressing: PR25010 - https://bugs.llvm.org/s
Author: paulhoad
Date: Wed Mar 20 10:10:23 2019
New Revision: 356575
URL: http://llvm.org/viewvc/llvm-project?rev=356575&view=rev
Log:
[clang-format] structured binding in range for detected as Objective C
Summary:
Sometime after 6.0.0 and the current trunk 9.0.0 the following code would be
cons
Author: paulhoad
Date: Wed Mar 20 13:49:43 2019
New Revision: 356613
URL: http://llvm.org/viewvc/llvm-project?rev=356613&view=rev
Log:
[clang-format] BeforeHash added to IndentPPDirectives
Summary:
The option BeforeHash added to IndentPPDirectives.
Fixes Bug 36019. https://bugs.llvm.org/show_bug.
Author: paulhoad
Date: Wed Mar 20 14:02:12 2019
New Revision: 356615
URL: http://llvm.org/viewvc/llvm-project?rev=356615&view=rev
Log:
[clang-format][NFC] fix release notes build issue
build issue from r356613
Modified:
cfe/trunk/docs/ReleaseNotes.rst
Modified: cfe/trunk/docs/ReleaseNotes.r
Author: paulhoad
Date: Thu Mar 21 06:09:22 2019
New Revision: 356662
URL: http://llvm.org/viewvc/llvm-project?rev=356662&view=rev
Log:
[clang-format] Add basic support for formatting C# files
Summary:
This revision adds basic support for formatting C# files with clang-format, I
know the barrier
Author: paulhoad
Date: Fri Mar 22 15:47:34 2019
New Revision: 356821
URL: http://llvm.org/viewvc/llvm-project?rev=356821&view=rev
Log:
[clang-format][NFC] correct the release notes
Move the clang-format notes to the correct section
Modified:
cfe/trunk/docs/ReleaseNotes.rst
Modified: cfe/tru
Author: paulhoad
Date: Sat Mar 23 07:24:30 2019
New Revision: 356833
URL: http://llvm.org/viewvc/llvm-project?rev=356833&view=rev
Log:
[clang-format] correctly format protobuf fields named "enum".
Summary: Similar to TypeScript, "enum" is not a reserved word.
Reviewers: krasimir, MyDeveloperDay
Author: paulhoad
Date: Sat Mar 23 07:37:58 2019
New Revision: 356834
URL: http://llvm.org/viewvc/llvm-project?rev=356834&view=rev
Log:
Clang-format: add finer-grained options for putting all arguments on one line
Summary:
Add two new options,
AllowAllArgumentsOnNextLine and
AllowAllConstructorIni
Author: paulhoad
Date: Sat Mar 23 07:43:41 2019
New Revision: 356835
URL: http://llvm.org/viewvc/llvm-project?rev=356835&view=rev
Log:
[clang-format] Keep protobuf "package" statement on one line
Summary:
Top-level "package" and "import" statements should generally be kept on one
line, for all la
Author: paulhoad
Date: Sat Mar 30 06:05:40 2019
New Revision: 357345
URL: http://llvm.org/viewvc/llvm-project?rev=357345&view=rev
Log:
[clang-format] [PR41187] moves Java import statements to the wrong location if
code contains statements that start with the word import
Summary:
Import sorting o
Author: paulhoad
Date: Sat Apr 6 03:13:04 2019
New Revision: 357837
URL: http://llvm.org/viewvc/llvm-project?rev=357837&view=rev
Log:
[clang-format] BreakAfterReturnType ignored on functions with numeric template
parameters
Summary:
Addresses PR40696 - https://bugs.llvm.org/show_bug.cgi?id=4069
Author: paulhoad
Date: Mon Apr 15 00:47:15 2019
New Revision: 358375
URL: http://llvm.org/viewvc/llvm-project?rev=358375&view=rev
Log:
[clang-format] [PR41170] Break after return type ignored with certain comments
positions
Summary:
Addresses https://bugs.llvm.org/show_bug.cgi?id=41170
The Alwa
Author: paulhoad
Date: Fri Feb 8 09:00:01 2019
New Revision: 353535
URL: http://llvm.org/viewvc/llvm-project?rev=353535&view=rev
Log:
[clang-tidy] Add options to bugprone-argument-comment to add missing argument
comments to literals
bugprone-argument-comment only supports identifying those comm
Author: paulhoad
Date: Thu Sep 12 03:07:14 2019
New Revision: 371719
URL: http://llvm.org/viewvc/llvm-project?rev=371719&view=rev
Log:
[clang-format] Add new style option IndentGotoLabels
Summary:
This option determines whether goto labels are indented according to scope.
Setting this option to
Author: paulhoad
Date: Thu Sep 12 03:18:53 2019
New Revision: 371720
URL: http://llvm.org/viewvc/llvm-project?rev=371720&view=rev
Log:
[clang-format] [PR43100] clang-format C# support does not add a space between
"using" and paren
Summary:
Addresses https://bugs.llvm.org/show_bug.cgi?id=43100
Author: paulhoad
Date: Wed Sep 18 11:57:09 2019
New Revision: 372246
URL: http://llvm.org/viewvc/llvm-project?rev=372246&view=rev
Log:
[clang-format][PR41964] Fix crash with SIGFPE when TabWidth is set to 0 and
line starts with tab
Summary:
clang-format 8.0 crashes with SIGFPE (floating point ex
Author: paulhoad
Date: Wed Sep 18 12:11:40 2019
New Revision: 372249
URL: http://llvm.org/viewvc/llvm-project?rev=372249&view=rev
Log:
[clang-format][PR41899] PointerAlignment: Left leads to useless space in lambda
intializer expression
Summary:
https://bugs.llvm.org/show_bug.cgi?id=41899
```au
Author: paulhoad
Date: Sun Sep 22 05:00:34 2019
New Revision: 372497
URL: http://llvm.org/viewvc/llvm-project?rev=372497&view=rev
Log:
Clang-format: Add Whitesmiths indentation style
Summary:
This patch adds support for the Whitesmiths indentation style to clang-format.
It’s an update to a patch
Author: paulhoad
Date: Mon Sep 23 23:35:37 2019
New Revision: 372689
URL: http://llvm.org/viewvc/llvm-project?rev=372689&view=rev
Log:
[clang-format] NFC clang-format the clang-format unit tests
Summary:
It is annoying that the clang-format tests aren't themselves clang-formatted,
if you use a f
Author: paulhoad
Date: Tue Sep 24 07:00:06 2019
New Revision: 372760
URL: http://llvm.org/viewvc/llvm-project?rev=372760&view=rev
Log:
[clang-format] [PR36858] Add missing .hh and .cs extensions from python support
utilities
Summary: https://bugs.llvm.org/show_bug.cgi?id=36858 identifies .hh as
Author: paulhoad
Date: Wed Sep 25 13:33:01 2019
New Revision: 372919
URL: http://llvm.org/viewvc/llvm-project?rev=372919&view=rev
Log:
[clang-format] Modified SortIncludes and IncludeCategories to priority for
sorting #includes within the Group Category.
Summary:
This new Style rule is made as a
Author: paulhoad
Date: Sun Sep 29 06:45:38 2019
New Revision: 373165
URL: http://llvm.org/viewvc/llvm-project?rev=373165&view=rev
Log:
[clang-format] Reference qualifiers in member templates causing extra
indentation.
Summary:
The following code
```
struct f {
template
void bar() && noexce
Author: paulhoad
Date: Tue Oct 1 13:20:22 2019
New Revision: 373388
URL: http://llvm.org/viewvc/llvm-project?rev=373388&view=rev
Log:
[clang-format] [PR43372] - clang-format shows replacements in DOS files when no
replacement is needed
Summary:
This is a patch to fix PR43372 (https://bugs.llvm.
Author: paulhoad
Date: Thu Oct 3 11:42:31 2019
New Revision: 373647
URL: http://llvm.org/viewvc/llvm-project?rev=373647&view=rev
Log:
[clang-format] Add ability to wrap braces after multi-line control statements
Summary:
Change the BraceWrappingFlags' AfterControlStatement from a bool to an enum
Author: paulhoad
Date: Fri Oct 4 00:56:49 2019
New Revision: 373707
URL: http://llvm.org/viewvc/llvm-project?rev=373707&view=rev
Log:
[clang-format] [PR4] Fix C# breaking before function name when using
Attributes
Summary:
This is a fix for https://bugs.llvm.org/show_bug.cgi?id=4
This
Author: paulhoad
Date: Fri Oct 4 01:10:22 2019
New Revision: 373709
URL: http://llvm.org/viewvc/llvm-project?rev=373709&view=rev
Log:
[clang-format] [PR43338] C# clang format has space issues betweern C# only
keywords
Summary:
When formatting C# there can be issues with a lack of spaces between
Author: paulhoad
Date: Fri Oct 4 06:24:15 2019
New Revision: 373746
URL: http://llvm.org/viewvc/llvm-project?rev=373746&view=rev
Log:
[clang-format] [PR42417] clang-format inserts a space after '->' for
operator->() overloading
Summary:
https://bugs.llvm.org/show_bug.cgi?id=42417
This revision
Author: paulhoad
Date: Fri Oct 4 07:16:59 2019
New Revision: 373750
URL: http://llvm.org/viewvc/llvm-project?rev=373750&view=rev
Log:
[clang-format] [PR43531] clang-format damages "alternative representations" for
operators
Summary:
https://bugs.llvm.org/show_bug.cgi?id=43531
Fix for clang-for
Author: paulhoad
Date: Fri Oct 4 07:25:20 2019
New Revision: 373751
URL: http://llvm.org/viewvc/llvm-project?rev=373751&view=rev
Log:
[clang-format] C++11 braced lists should respect the SpacesInParentheses setting
Summary:
According to the clang-format documentation, "Fundamentally, C++11 brace
Author: paulhoad
Date: Sat Oct 5 02:55:23 2019
New Revision: 373821
URL: http://llvm.org/viewvc/llvm-project?rev=373821&view=rev
Log:
[clang-format] SpacesInSquareBrackets should affect lambdas with parameters too
Summary:
This patch makes the `SpacesInSquareBrackets` setting also apply to C++ l
Author: paulhoad
Date: Sun Oct 6 02:37:58 2019
New Revision: 373844
URL: http://llvm.org/viewvc/llvm-project?rev=373844&view=rev
Log:
[clang-format][docs] Fix the Google C++ and Chromium style guide URLs
Summary: The Google C++ and Chromium style guides are broken in the
clang-format docs. This
Author: paulhoad
Date: Mon Oct 7 09:53:35 2019
New Revision: 373921
URL: http://llvm.org/viewvc/llvm-project?rev=373921&view=rev
Log:
[clang-format] [NFC] Ensure clang-format is itself clang-formatted.
Summary:
Before making a proposed change, ensure ClangFormat.cpp is fully
clang-formatted,
n
Author: paulhoad
Date: Mon Oct 7 10:03:44 2019
New Revision: 373922
URL: http://llvm.org/viewvc/llvm-project?rev=373922&view=rev
Log:
[clang-format] [PR27004] omits leading space for noexcept when formatting
operator delete()
Summary:
clang-format is incorrectly thinking the parameter parens ar
Author: paulhoad
Date: Thu Oct 10 10:54:47 2019
New Revision: 374399
URL: http://llvm.org/viewvc/llvm-project?rev=374399&view=rev
Log:
[clang-format] throws an incorrect assertion in consumeToken() formatting the
MSVC stl
Summary:
An incorrect assertion is thrown when clang-formatting MSVC's STL
Author: paulhoad
Date: Sat Oct 12 08:36:05 2019
New Revision: 374663
URL: http://llvm.org/viewvc/llvm-project?rev=374663&view=rev
Log:
[clang-format] Proposal for clang-format to give compiler style warnings
Summary:
Related somewhat to {D29039}
On seeing a quote on twitter by @invalidop
> If i
Author: paulhoad
Date: Sun Oct 13 07:51:45 2019
New Revision: 374720
URL: http://llvm.org/viewvc/llvm-project?rev=374720&view=rev
Log:
[clang-format] Proposal for clang-format to give compiler style warnings
relanding {D68554} with fixed lit tests, checked on Windows and MacOS
Added:
cfe/tru
MyDeveloperDay updated this revision to Diff 34741.
MyDeveloperDay added a comment.
Handle subsequent catch statements
http://reviews.llvm.org/D12492
Files:
docs/ClangFormatStyleOptions.rst
include/clang/Format/Format.h
lib/Format/Format.cpp
lib/Format/UnwrappedLineParser.cpp
unittest
MyDeveloperDay added a subscriber: MyDeveloperDay.
MyDeveloperDay added a comment.
This looks like a good small change.
What is interesting to me is that even the twiki page about template is
inconsistent in its style (https://en.wikipedia.org/wiki/Template_(C%2B%2B)),
so its not like there is
MyDeveloperDay added a comment.
Oh and we might want to run clang-format by the guys at http://cppreference.com
seems they don't like the space either! just saying
http://reviews.llvm.org/D12921
___
cfe-commits mailing list
cfe-commits@lists.
MyDeveloperDay updated this revision to Diff 34971.
MyDeveloperDay added a comment.
full file diff
http://reviews.llvm.org/D12492
Files:
docs/ClangFormatStyleOptions.rst
include/clang/Format/Format.h
lib/Format/Format.cpp
lib/Format/UnwrappedLineParser.cpp
tools/CMakeLists.txt
unitt
MyDeveloperDay added inline comments.
Comment at: docs/ClangFormatStyleOptions.rst:247
@@ -246,1 +246,3 @@
+**AlwaysBreakBeforeElse** (``bool``)
+ If ``true``, always break before ``else``.
djasper wrote:
> Hm, I think these should be grouped in some way and in
MyDeveloperDay added a comment.
> The point here that it this space is utterly irrelevant
So I totally take the point but if it doesn't matter then why does clang-format
automatically add one to my "template<>" why not simply leave it alone?
> We never intended clang-format to provide control
MyDeveloperDay added a comment.
@djasper I'm more than happy with that, just ping me if you need me the rework
the change afterwards to fit
http://reviews.llvm.org/D12492
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org
MyDeveloperDay added a comment.
I tried downloaded the diff and tried this, I met a couple of issues with
applying the patch due to line endings in .cs file and csproj (but that could
be my fault) - (I was using 2013 to build clang library and clang format)
I also had to up the version because
MyDeveloperDay added a comment.
Actually the 2010 failure may be my fault, I only have Visual C# installed for
VS2010 and not the C++ compilers, as such it doesn't seem to understand C/C++
as the content type
if (!textBuffer.ContentType.IsOfType("C/C++"))
is failing because the ContentType is
MyDeveloperDay added a comment.
Having installed the VS2010 C++ compilers the format on save does work BUT...
you have to disable and enable the setting in tools->options->LLVM/Clang first,
its as if the setting is NOT read on startup
http://reviews.llvm.org/D12407
_
MyDeveloperDay added a comment.
I went back and retested VS2010, VS2013 and VS2015. so in all cases I
1. start Visual studio
2. open a .h file (with incorrect style) - (via the recent file menu)
3. make a minor edit of whitespace
4. hit save file
In allcases it does NOT reformat the file
Now do
MyDeveloperDay added a comment.
After a little digging, the problem is based on the fact that the extension
doesn't load until we use it, so the nBeforeSave won't fire, so after doing
Ctrl-R,Ctrl-F once it will work
This exact same problem is mentioned here
http://schmalls.com/2015/01/19/adven
MyDeveloperDay added a comment.
I don't have permission to commit
This looks good though.
http://reviews.llvm.org/D12492
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
MyDeveloperDay created this revision.
MyDeveloperDay added reviewers: nikola, djasper, poiru, klimek.
MyDeveloperDay added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
Implementation of Jarkko Hietaniemi original AlwaysBreakBeforeElse to avoid
cuddled braces on an "else" statemen
MyDeveloperDay added a subscriber: MyDeveloperDay.
MyDeveloperDay added a comment.
This is definitely a nice to have, it would be nice in the future to have an
option that only reformatted the changed lines only, nice idea though
http://reviews.llvm.org/D12407
___
MyDeveloperDay retitled this revision from "[Clang-Format] Add
AlwaysBreakBeforeElse Style to avoid cuddled else" to "[Clang-Format] Add
AlwaysBreakBeforeElse and AlwaysBreakBeforeCatch Style to avoid cuddled
else/catch".
MyDeveloperDay updated the summary for this revision.
MyDeveloperDay updat
https://github.com/phoad107185 approved this pull request.
https://github.com/llvm/llvm-project/pull/97938
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
phoad107185 wrote:
> > I struggle with changes that encourage people to not be fully
> > clang-formatted, I would prefer to ask why we need this feature, can we
> > have some examples of where this would be used?
>
> This makes it so only one line isn't formatted instead of the current
> solu
63 matches
Mail list logo
