It's two weeks later and I'm still seeing this warning. Any news?
On Fri, Aug 3, 2018 at 9:29 AM Dávid Bolvanský
wrote:
> Such filename fix could be part of https://reviews.llvm.org/D50246
>
> pi 3. 8. 2018 o 15:17 Nico Weber napísal(a):
>
>> I'm getting this warning from the mac linker after t
Author: nico
Date: Fri Aug 17 10:19:06 2018
New Revision: 340048
URL: http://llvm.org/viewvc/llvm-project?rev=340048&view=rev
Log:
Make __shiftleft128 / __shiftright128 real compiler built-ins.
r337619 added __shiftleft128 / __shiftright128 as functions in intrin.h.
Microsoft's STL plans on using
Should this maybe not be emitted when compiling e.g. .ii files
(preprocessed output)? I just got this when I built a standalone .ii file
with some bug repro after I deleted all -I and -isysroot flags and whatnot,
since they aren't needed for preprocessed files.
On Tue, Jun 19, 2018 at 6:52 PM Alex
Also, the diag text should probably say "pass '-stdlib=libc++' " not "pass
'-std=libc++' "?
On Sat, Aug 18, 2018 at 11:06 PM Nico Weber wrote:
> Should this maybe not be emitted when compiling e.g. .ii files
> (preprocessed output)? I just got this when I built a standalone .ii file
> with some
Author: nico
Date: Tue Aug 21 15:19:55 2018
New Revision: 340348
URL: http://llvm.org/viewvc/llvm-project?rev=340348&view=rev
Log:
Eliminate instances of `EmitScalarExpr(E->getArg(n))` in EmitX86BuiltinExpr().
EmitX86BuiltinExpr() emits all args into Ops at the beginning, so don't do that
work ag
Author: nico
Date: Wed Aug 22 16:53:39 2018
New Revision: 340498
URL: http://llvm.org/viewvc/llvm-project?rev=340498&view=rev
Log:
win: Omit ".exe" from clang and clang-cl driver-level diagnostics.
Like https://reviews.llvm.org/D51133 but for clang.
https://reviews.llvm.org/D51134
Modified:
Author: nico
Date: Wed May 9 05:38:51 2018
New Revision: 331871
URL: http://llvm.org/viewvc/llvm-project?rev=331871&view=rev
Log:
Remove unused lit setting, see https://reviews.llvm.org/D46619
Modified:
cfe/trunk/test/lit.site.cfg.py.in
Modified: cfe/trunk/test/lit.site.cfg.py.in
URL:
http
Author: nico
Date: Tue May 15 09:37:00 2018
New Revision: 332370
URL: http://llvm.org/viewvc/llvm-project?rev=332370&view=rev
Log:
update two comments as suggested on https://reviews.llvm.org/D46843
Modified:
cfe/trunk/tools/clang-fuzzer/CMakeLists.txt
cfe/trunk/tools/clang-fuzzer/proto-t
Author: nico
Date: Thu May 17 08:26:37 2018
New Revision: 332614
URL: http://llvm.org/viewvc/llvm-project?rev=332614&view=rev
Log:
Fix __uuidof handling on non-type template parameter in C++17
Clang used to pass the base lvalue of a non-type template parameter
to the template instantiation phase
You might've forgotten to svn add the test :-)
On Thu, May 17, 2018, 2:16 PM Reid Kleckner via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rnk
> Date: Thu May 17 11:12:18 2018
> New Revision: 332639
>
> URL: http://llvm.org/viewvc/llvm-project?rev=332639&view=rev
> Log:
> Fix a man
I think this code is probably dead since the stem is "ld.lld" for lld, not
"lld".
On Sat, Feb 11, 2017 at 7:22 PM, Davide Italiano via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Sat, Feb 11, 2017 at 4:19 PM, Rui Ueyama wrote:
> > On Sat, Feb 11, 2017 at 3:44 PM, Davide Italiano via cf
Author: nico
Date: Sun May 20 16:02:20 2018
New Revision: 332822
URL: http://llvm.org/viewvc/llvm-project?rev=332822&view=rev
Log:
Revert 332750, clang part (see comment on D46910).
Modified:
cfe/trunk/lib/Frontend/CompilerInvocation.cpp
Modified: cfe/trunk/lib/Frontend/CompilerInvocation.cp
Author: nico
Date: Tue May 29 07:48:30 2018
New Revision: 333423
URL: http://llvm.org/viewvc/llvm-project?rev=333423&view=rev
Log:
add test for r332053
Modified:
cfe/trunk/test/Driver/cl-options.c
Modified: cfe/trunk/test/Driver/cl-options.c
URL:
http://llvm.org/viewvc/llvm-project/cfe/trun
(Added a test for this in r333423)
On Thu, May 10, 2018 at 6:24 PM, Reid Kleckner via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rnk
> Date: Thu May 10 15:24:00 2018
> New Revision: 332053
>
> URL: http://llvm.org/viewvc/llvm-project?rev=332053&view=rev
> Log:
> [clang-cl] Make -f
But GetExecutablePath isn't called if -no-canonical-prefixes is passed, is
it? (See the first link I pasted above)
On Tue, May 29, 2018, 5:28 PM Takuto Ikuta via Phabricator via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> takuto.ikuta added a comment.
>
> On windows, argv0 is changed to ab
Author: nico
Date: Mon Sep 25 15:42:49 2017
New Revision: 314172
URL: http://llvm.org/viewvc/llvm-project?rev=314172&view=rev
Log:
clang-format/java: Always put space after `assert` keyword.
Previously, it was missing if the expression after the assert started with a (.
Modified:
cfe/trunk/l
Another bit of feedback: The Microsoft SDK has pragma adjustment headers
that are used like so:
#include
// Define structs with alignment 1 here
#include
This warning fires on that. I haven't seen these headers in active use
recently, but I remember seeing them quite a bit maybe 10 years ago. (
Author: nico
Date: Tue Sep 26 11:38:56 2017
New Revision: 314232
URL: http://llvm.org/viewvc/llvm-project?rev=314232&view=rev
Log:
Delete trailing whitespace.
Modified:
cfe/trunk/lib/Lex/PPMacroExpansion.cpp
Modified: cfe/trunk/lib/Lex/PPMacroExpansion.cpp
URL:
http://llvm.org/viewvc/llvm-p
Author: nico
Date: Wed Sep 27 10:57:50 2017
New Revision: 314325
URL: http://llvm.org/viewvc/llvm-project?rev=314325&view=rev
Log:
clang-format/java: Unbreak genenrics formatting after r299952.
https://reviews.llvm.org/rL299952 merged '>>>' tokens into a single
JavaRightLogicalShift token. This b
Author: nico
Date: Thu Sep 28 08:44:46 2017
New Revision: 314424
URL: http://llvm.org/viewvc/llvm-project?rev=314424&view=rev
Log:
Fix -Wcast-qual warning after r314336.
Modified:
cfe/trunk/lib/AST/ExternalASTMerger.cpp
Modified: cfe/trunk/lib/AST/ExternalASTMerger.cpp
URL:
http://llvm.org/
Author: nico
Date: Thu Sep 28 09:16:39 2017
New Revision: 314427
URL: http://llvm.org/viewvc/llvm-project?rev=314427&view=rev
Log:
Consolidate std::move() detection code. No behavior change.
Modified:
cfe/trunk/include/clang/AST/Expr.h
cfe/trunk/lib/Analysis/Consumed.cpp
cfe/trunk/lib
Hi Erich,
this breaks existing code. NaCl does this:
#include
struct r_debug _r_debug __attribute__((nocommon, section(".r_debug")));
(There's a lengthy-ish comment for why in
https://cs.chromium.org/chromium/src/native_client/src/trusted/service_runtime/linux/nacl_bootstrap.c?q=nacl_bootstrap.
For why, here's the comment from the code I linked to:
/*
* GDB looks for this symbol name when it cannot find PT_DYNAMIC->DT_DEBUG.
* We don't have a PT_DYNAMIC, so it will find this. Now all we have to do
* is arrange for this space to be filled in with the dynamic linker's
* _r_debug conte
All I know about this code that it used to build (and still builds with
gcc) and now it doesn't, sorry :-) What that code does seems somewhat
questionable, but also somewhat useful, and it feels like the behavior
change from this change here for that code might have been unintentional.
Your sugges
That does the trick. Thanks for the quick help, everyone!
On Wed, Oct 4, 2017 at 6:18 PM, Keane, Erich wrote:
> Elizabeth gave me a patch, submitted it with a test in r314939
>
>
>
> *From:* Andrews, Elizabeth
> *Sent:* Wednesday, October 4, 2017 1:54 PM
> *To:* Friedman, Eli ; Keane, Erich <
>
Huh, I consider clang not warning on this a feature, not a bug. Why are we
trying to match what gcc does here?
Say you have code like this:
int64_t aligned_start = 0;
int64_t aligned_size = 0;
CalculateVMAlignedBoundaries(region.offset,
region.size,
Author: nico
Date: Tue Oct 17 14:14:02 2017
New Revision: 316032
URL: http://llvm.org/viewvc/llvm-project?rev=316032&view=rev
Log:
Fix PR34981, a crash-on-invalid merging dllimport to an invalid redecl.
This is basically like r288207, just the other way round.
Modified:
cfe/trunk/lib/Sema/Se
Author: nico
Date: Mon Oct 23 08:54:44 2017
New Revision: 316335
URL: http://llvm.org/viewvc/llvm-project?rev=316335&view=rev
Log:
clang-cl: Expose --version.
This is for consistency with lld-link, see https://reviews.llvm.org/D38972
Also give --version a help text so it shows up in --help / /? o
This is fine, but a few years ago we agreed that we shouldn't repeat method
names in doxygen. So an Even Better Fix would've been to just remove
everything up to (and including) the ' - ' :-) Just FYI, no need to follow
this up with the deletion.
On Tue, Oct 24, 2017 at 3:34 PM, Erich Keane via cf
Author: nico
Date: Mon Aug 27 07:23:50 2018
New Revision: 340743
URL: http://llvm.org/viewvc/llvm-project?rev=340743&view=rev
Log:
fix comment typo
Modified:
cfe/trunk/lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedPointee.cpp
Modified:
cfe/trunk/lib/StaticAnalyzer/Checkers/U
Author: nico
Date: Thu Aug 30 15:10:13 2018
New Revision: 341130
URL: http://llvm.org/viewvc/llvm-project?rev=341130&view=rev
Log:
Remove LIT_SITE_CFG_IN_FOOTER, clang-tools-extra
It's always replaced with the same (short) static string, so just put that
there directly.
No intended behavior chan
Author: nico
Date: Thu Aug 30 15:11:16 2018
New Revision: 341132
URL: http://llvm.org/viewvc/llvm-project?rev=341132&view=rev
Log:
Remove LIT_SITE_CFG_IN_FOOTER, clang
It's always replaced with the same (short) static string, so just put that
there directly.
No intended behavior change.
https://
Author: nico
Date: Tue Sep 4 11:00:14 2018
New Revision: 341390
URL: http://llvm.org/viewvc/llvm-project?rev=341390&view=rev
Log:
clang-cl: Pass /Brepro to linker if it was passed to the compiler
Differential Revision: https://reviews.llvm.org/D51635
Modified:
cfe/trunk/lib/Driver/ToolChain
On Wed, Sep 5, 2018 at 9:25 PM Alex L wrote:
> Sorry for the late response,
>
> On Sat, 18 Aug 2018 at 20:10, Nico Weber wrote:
>
>> Also, the diag text should probably say "pass '-stdlib=libc++' " not
>> "pass '-std=libc++' "?
>>
>
> Good catch, thanks! I'll commit a fixup for it.
>
>
>>
>> On
Relanded with a fix attempt at 341654.
On Thu, Sep 6, 2018 at 12:31 PM A Bergen via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: sudofortune
> Date: Thu Sep 6 09:29:40 2018
> New Revision: 341560
>
> URL: http://llvm.org/viewvc/llvm-project?rev=341560&view=rev
> Log:
> Reverting r
Author: nico
Date: Fri Sep 7 05:47:02 2018
New Revision: 341654
URL: http://llvm.org/viewvc/llvm-project?rev=341654&view=rev
Log:
Reland r341390 clang-cl: Pass /Brepro to linker if it was passed to the compiler
The test was missing '--' on mac as pointed out by -Wslash-u-filename:
:5:69: note:
Author: nico
Date: Sat Sep 8 13:58:39 2018
New Revision: 341755
URL: http://llvm.org/viewvc/llvm-project?rev=341755&view=rev
Log:
ms: Insert $$Z in mangling between directly consecutive parameter packs.
Fixes PR38783.
Differential Revision: https://reviews.llvm.org/D51784
Modified:
cfe/trun
On Mon, Sep 10, 2018 at 10:33 AM Hans Wennborg via Phabricator via
cfe-commits wrote:
> hans added a comment.
>
> In https://reviews.llvm.org/D51806#1228893, @aganea wrote:
>
> > @hans Just an after thought: maybe we should prevent usage of `-march=`
> and `/arch:` at the same time. What do you t
Author: nico
Date: Thu Jul 19 11:59:38 2018
New Revision: 337480
URL: http://llvm.org/viewvc/llvm-project?rev=337480&view=rev
Log:
fix typo in comment
Modified:
cfe/trunk/lib/CodeGen/MicrosoftCXXABI.cpp
Modified: cfe/trunk/lib/CodeGen/MicrosoftCXXABI.cpp
URL:
http://llvm.org/viewvc/llvm-pro
Author: nico
Date: Fri Jul 20 14:02:09 2018
New Revision: 337619
URL: http://llvm.org/viewvc/llvm-project?rev=337619&view=rev
Log:
[ms] Add __shiftleft128 / __shiftright128 intrinsics
Carefully match the pattern matched by ISel so that this produces shld / shrd
(unless Subtarget->isSHLDSlow() is
Author: nico
Date: Fri Jul 20 14:06:41 2018
New Revision: 337620
URL: http://llvm.org/viewvc/llvm-project?rev=337620&view=rev
Log:
fix typo
Modified:
cfe/trunk/docs/ReleaseNotes.rst
Modified: cfe/trunk/docs/ReleaseNotes.rst
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/docs/ReleaseNote
Fixed in 337620, thanks!
On Wed, Jul 18, 2018 at 3:55 PM Kim Gräsman via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> This is lovely! Found a bit inline...
>
> On Wed, Jul 18, 2018, 14:00 Nico Weber via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>&
This has a false positive on ffmpeg:
../../third_party/ffmpeg/libavcodec/options.c:273:64: error: 'size'
argument to memset is '0'; did you mean to transpose the last two
arguments? [-Werror,-Wmemset-transposed-args]
alloc_and_copy_or_fail(intra_matrix, 64 * sizeof(int16_t), 0);
With:
#define al
Author: nico
Date: Mon Jul 23 13:04:00 2018
New Revision: 337732
URL: http://llvm.org/viewvc/llvm-project?rev=337732&view=rev
Log:
[ms] Fix mangling of vector types in QMM_Result contexts.
If QMM_Result is set (which it is for return types, RTTI descriptors, and
exception type descriptors), tag t
I thought about adding -fblocks when that thread happened, but since
there's no runtime for them that just works exposing it doesn't seem very
helpful. Maybe we should instead change the warning text to not suggest
-fblocks when building on a non-mac target?
On Mon, Jul 23, 2018 at 5:29 PM Reid Kl
Author: nico
Date: Wed Aug 1 04:56:20 2018
New Revision: 338520
URL: http://llvm.org/viewvc/llvm-project?rev=338520&view=rev
Log:
wrap to 80 cols, no behavior change
Modified:
cfe/trunk/lib/AST/MicrosoftMangle.cpp
Modified: cfe/trunk/lib/AST/MicrosoftMangle.cpp
URL:
http://llvm.org/viewvc/
Can't you omit '-o -' now too?
On Wed, Aug 1, 2018 at 5:21 PM Roman Lebedev via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: lebedevri
> Date: Wed Aug 1 14:20:58 2018
> New Revision: 338640
>
> URL: http://llvm.org/viewvc/llvm-project?rev=338640&view=rev
> Log:
> [NFC][CodeGenCXX]
This causes a warning:
gen/clang/include/clang/Sema/AttrParsedAttrImpl.inc:1050:12: warning:
expression result unused [-Wunused-value]
return S, false;
^
On Fri, Aug 3, 2018 at 9:01 AM Erich Keane via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: erichkeane
> Date: Fr
I'm getting this warning from the mac linker after this commit:
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool:
warning same member name (libclangDriver.RISCV.o) in output file used for
input files: obj/clang/lib/Driver/ToolChains/Arch/libclangDriver
Author: nico
Date: Tue Feb 6 11:17:41 2018
New Revision: 324385
URL: http://llvm.org/viewvc/llvm-project?rev=324385&view=rev
Log:
Fix building libc++ with the macOS 10.13 SDK with -mmacosx-version-min=10.12 or
lower.
The 10.13 SDK always defines utimensat() (with an availability(macosx=10.13)
Author: nico
Date: Tue Feb 13 13:31:47 2018
New Revision: 325052
URL: http://llvm.org/viewvc/llvm-project?rev=325052&view=rev
Log:
Teach Wreturn-type, Wunreachable-code, and alpha.deadcode.UnreachableCode to
treat __assume(0) like __builtin_unreachable.
Fixes PR29134.
https://reviews.llvm.org/D4
Out of interest, do you know why the non-experimental version doesn't have
to_string()? What are folks supposed to use instead?
On Mon, Feb 5, 2018 at 6:43 PM, Marshall Clow via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: marshall
> Date: Mon Feb 5 15:43:34 2018
> New Revision: 32
I have a small personal project where I used to use this. I tried switching
to instead, but that apparently requires -std=c++17. With that,
things build fine with my locally-built clang, but latest Xcode clang
doesn't accept that flag yet. So I tried -std=c++1z, but latest Xcode (9.2)
doesn't even
Was this reviewed somewhere?
Please make it so that this emits a warning. We want clang-cl to warn on
invalid code (and in system headers warnings are suppressed).
On Wed, May 24, 2017 at 3:31 PM, Erich Keane via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: erichkeane
> Date: Wed M
Reviewed here: https://reviews.llvm.org/D33505
Still, please make this warn.
On Wed, May 24, 2017 at 3:42 PM, Nico Weber wrote:
> Was this reviewed somewhere?
>
> Please make it so that this emits a warning. We want clang-cl to warn on
> invalid code (and in system headers warnings are suppress
In addition to this making clang-cl silently accept invalid code, it also
breaks existing valid code, building chromium now fails. Let's revert and
come up with something better asynchronously.
FAILED:
obj/third_party/WebKit/Source/core/dom/dom/CustomElementRegistry.obj
E:\b\c\goma_client/gomacc.e
On Thu, May 25, 2017 at 12:18 PM, Keane, Erich
wrote:
> How does chromium compiler in CL? It seems that it would have a similar
> problem here…
>
That's a good question! It looks like iso646.h is included, and in MSVC
that contains something like `#define and &&`. But clang's
lib/Headers/iso646
Among the goals of the clang-cl project are a) being able to parse MS
system headers b) helper users to write standards-compliant C++ (in
particular, if your code builds with clang-cl without warnings, it'd be
good if it also built with regular clang then).
The regular change plus header change pl
Author: nico
Date: Wed Feb 28 11:28:47 2018
New Revision: 326355
URL: http://llvm.org/viewvc/llvm-project?rev=326355&view=rev
Log:
Fix gcc -Wreturn-type warnings after r326307.
Modified:
cfe/trunk/lib/CodeGen/CGBlocks.cpp
Modified: cfe/trunk/lib/CodeGen/CGBlocks.cpp
URL:
http://llvm.org/vie
Author: nico
Date: Wed Feb 28 11:49:07 2018
New Revision: 326357
URL: http://llvm.org/viewvc/llvm-project?rev=326357&view=rev
Log:
[clang-cl] Implement /X
/X makes cl stop looking in %INCLUDE%. Implement this for clang-cl.
As it turns out, the return in ToolChains/MSVC.cpp, AddClangSystemInclude
Author: nico
Date: Wed Feb 28 12:58:06 2018
New Revision: 326370
URL: http://llvm.org/viewvc/llvm-project?rev=326370&view=rev
Log:
Attempt to fix cl-include.c on Windows.
Modified:
cfe/trunk/test/Driver/cl-include.c
Modified: cfe/trunk/test/Driver/cl-include.c
URL:
http://llvm.org/viewvc/ll
Should we also mention /p:CLToolExe for just swapping out the compiler
without using a full toolset?
Also, should we include some notes on cmake usage? I.e. -G "Visual Studio
14 2015" -T "LLVM-vs2014" for the MSVS generator,
and -DCMAKE_C_COMPILER=/path/to/llvm/bin/clang-cl.exe
-DCMAKE_CXX_COMPILE
Should we key the default off the triple? (I thought that what was the
patch did, but I misread.) I.e. with an MSVC triple, default to emitting
codeview?
On Mon, Feb 26, 2018 at 5:55 PM, Reid Kleckner via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rnk
> Date: Mon Feb 26 14:55:33 2
The 't' was there because __builtin_va_start and __va_start had them, but
those do in fact have custom sema checking so copying that was in fact
incorrect. Thanks for fixing my bugs!
On Fri, Mar 2, 2018 at 4:41 PM, Reid Kleckner via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rnk
>
Is it easy to mention variables first in the diag? That's probably the most
common subject for this attribute. (If it's not easy, nevermind --
definitely a polish thing.)
On Sat, Mar 3, 2018, 4:04 PM Aaron Ballman via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: aaronballman
> Date:
Awesome, thanks!
On Sun, Mar 4, 2018, 11:26 AM Aaron Ballman via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: aaronballman
> Date: Sun Mar 4 08:24:10 2018
> New Revision: 326676
>
> URL: http://llvm.org/viewvc/llvm-project?rev=326676&view=rev
> Log:
> Amend r326665 to print out the
Author: nico
Date: Tue Mar 6 18:22:41 2018
New Revision: 326862
URL: http://llvm.org/viewvc/llvm-project?rev=326862&view=rev
Log:
Revert r326602, it caused PR36620.
Removed:
cfe/trunk/test/Sema/attr-ownership.cpp
Modified:
cfe/trunk/include/clang/AST/Attr.h
cfe/trunk/include/clang/Ba
Test? (Also below)
On Tue, Mar 6, 2018 at 8:27 PM, Petr Hosek via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: phosek
> Date: Tue Mar 6 17:27:03 2018
> New Revision: 326860
>
> URL: http://llvm.org/viewvc/llvm-project?rev=326860&view=rev
> Log:
> [Driver] Automatically disable inco
Author: nico
Date: Tue Mar 6 19:00:25 2018
New Revision: 326869
URL: http://llvm.org/viewvc/llvm-project?rev=326869&view=rev
Log:
Revert 326766 too, after r326862 the test fails and I don't know how to fix.
Modified:
cfe/trunk/lib/AST/ExprConstant.cpp
cfe/trunk/test/CodeGenCXX/alloc-size
Apologies, I had to revert the change that touched alloc-size.cpp before
this change in r326862. After that revert, your new test here failed, and
since I didn't understand how to make it passed, I reverted your change
in 326869 too. It should hopefully be easy for you to reland it.
On Tue, Mar 6,
Hi Erik,
before this change, ___Z10blocksNRVOv_block_invoke demangled to 'invocation
function for block in blocksNRVO()', now it's no longer demangled. Was that
an intentional change?
On Tue, Mar 6, 2018 at 9:21 AM, Erik Pilkington via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: e
Thanks for the quick fix!
On Tue, Mar 6, 2018 at 11:32 PM, Erik Pilkington
wrote:
> No, that was a mistake, fixed in r326871. Thanks for pointing this out!
> Erik
>
>
> On 2018-03-06 11:10 PM, Nico Weber wrote:
>
> Hi Erik,
>
> before this change, ___Z10blocksNRVOv_block_invoke demangled to
> 'i
On Wed, Mar 7, 2018 at 1:55 PM, Reid Kleckner via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rnk
> Date: Wed Mar 7 10:55:10 2018
> New Revision: 326926
>
> URL: http://llvm.org/viewvc/llvm-project?rev=326926&view=rev
> Log:
> Push a function scope when parsing function bodies with
On Sat, Feb 24, 2018 at 7:17 PM, Marshall Clow
wrote:
> On Thu, Feb 22, 2018 at 7:58 AM, Nico Weber wrote:
>
>> I have a small personal project where I used to use this. I tried
>> switching to instead, but that apparently requires -std=c++17.
>> With that, things build fine with my locally-bui
(I had to revert this since it caused
https://bugs.llvm.org/show_bug.cgi?id=36620)
On Fri, Mar 2, 2018 at 2:03 PM, Joel E. Denny via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: jdenny
> Date: Fri Mar 2 11:03:22 2018
> New Revision: 326602
>
> URL: http://llvm.org/viewvc/llvm-proje
Author: nico
Date: Wed Mar 7 15:15:20 2018
New Revision: 326960
URL: http://llvm.org/viewvc/llvm-project?rev=326960&view=rev
Log:
[ms] Emit vtordisp initializers in a deterministic order.
No effective behavior change, just for cleanliness.
Analysis and typing by me, actual patch mostly by Reid.
Looks like this broke the Windows bot:
http://lab.llvm.org:8011/builders/clang-x64-ninja-win7/builds/9365 Can you
fix or revert, please?
On Fri, Mar 9, 2018 at 2:06 AM, Saleem Abdulrasool via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: compnerd
> Date: Thu Mar 8 23:06:42 2018
> Ne
Awesome, thanks!
On Sun, Mar 18, 2018, 3:05 PM Reid Kleckner wrote:
> Yes: https://reviews.llvm.org/D7775
>
> This side is very mechanical, so I did not send it for review.
>
>
> On Sun, Mar 18, 2018, 3:54 AM Nico Weber wrote:
>
>> Was this discussed or reviewed somewhere? (It looks like a good
Author: nico
Date: Fri Jun 1 07:59:57 2018
New Revision: 333761
URL: http://llvm.org/viewvc/llvm-project?rev=333761&view=rev
Log:
clang-cl: Expose -no-canonical-prefixes
-no-canonical-prefixes is a weird flag: In gcc, it controls whether realpath()
is called on the path of the driver binary. It'
Author: nico
Date: Fri Jun 1 08:02:43 2018
New Revision: 333762
URL: http://llvm.org/viewvc/llvm-project?rev=333762&view=rev
Log:
Remove redundant -fno-coverage-mapping added in r333761 (already added in
r333423)
Modified:
cfe/trunk/test/Driver/cl-options.c
Modified: cfe/trunk/test/Driver/
All chromium bots build with asserts on and we definitely don't want shared
libs :-) Having the people who care about this build config make sure it
keeps working seems like a good approach to me.
On Mon, Jun 4, 2018 at 8:15 AM, David Zarzycki via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
Sure, the bots could do that, the more general point was that many
(probably most) people who want to enable asserts don't want to use shared
libs. I believe that only a few people use that config, so turning things
around why should everyone building with asserts have to pay the cost of
supporting
(Cost as in "shared library buildsof clang are ~35% slower than regular
clang" last we checked.)
On Mon, Jun 4, 2018 at 2:14 PM, Nico Weber wrote:
> Sure, the bots could do that, the more general point was that many
> (probably most) people who want to enable asserts don't want to use shared
> l
Author: nico
Date: Mon Jun 18 11:50:35 2018
New Revision: 334972
URL: http://llvm.org/viewvc/llvm-project?rev=334972&view=rev
Log:
Don't let test/Driver/no-canonical-prefixes.c form a symlink cycle the second
time it runs.
The test makes %t.fake a symlink to %t.real by running `ln -sf %t.real
%t
Author: nico
Date: Tue Jun 19 16:19:34 2018
New Revision: 335082
URL: http://llvm.org/viewvc/llvm-project?rev=335082&view=rev
Log:
clang-cl: Emit narrowing diag for initializer lists if -fmsc-version is at
least 1900 (i.e. MSVC2015).
Diagnostics for narrowing conversions in initializer lists are
Author: nico
Date: Wed Jun 20 08:57:38 2018
New Revision: 335139
URL: http://llvm.org/viewvc/llvm-project?rev=335139&view=rev
Log:
Simplify. No behavior change.
Modified:
cfe/trunk/lib/Sema/SemaInit.cpp
Modified: cfe/trunk/lib/Sema/SemaInit.cpp
URL:
http://llvm.org/viewvc/llvm-project/cfe/t
Why not enable it by default, or put it in -Wall at least? We don't like
off-by-default warnings :-)
On Fri, Jun 22, 2018 at 2:09 PM Bruno Cardoso Lopes via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: bruno
> Date: Fri Jun 22 11:05:17 2018
> New Revision: 335375
>
> URL: http://llv
$ bin/clang -target wasm32-unknown-unknown -fuse-ld=wasm-ld -o test.wasm
test.cc
clang: error: invalid linker name in argument '-fuse-ld=wasm-ld'
This here http://llvm-cs.pcc.me.uk/tools/clang/lib/Driver/ToolChain.cpp#453
makes clang look for "ld.wasm-ld", but the wasm lld symlink is called
"wasm-
Could you update the demangler too?
On Thu, Oct 25, 2018 at 6:53 PM Richard Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rsmith
> Date: Thu Oct 25 15:51:16 2018
> New Revision: 345330
>
> URL: http://llvm.org/viewvc/llvm-project?rev=345330&view=rev
> Log:
> Add MS ABI mang
Here's some user feedback on this new feature.
It looks like the warning is only suppressed if `init` has a definition in
the @interface block. In the 4 cases where we saw this warning fire after
r349841, it still fires after this change because in all 4 cases a class
marked init as unavailable in
Author: nico
Date: Mon Jan 14 04:41:13 2019
New Revision: 351061
URL: http://llvm.org/viewvc/llvm-project?rev=351061&view=rev
Log:
clang-cl: Align help texts for /O1 and O2
Makes it a bit easier to see what exactly the difference is.
Also use "same as" instead of "equivalent to", because that's
Author: nico
Date: Mon Jan 14 04:42:35 2019
New Revision: 351062
URL: http://llvm.org/viewvc/llvm-project?rev=351062&view=rev
Log:
clang-cl: Fix help text for /O: '/O2y-' means '/O2 /Oy-', not '/O2 /y-'
Differential Revision: https://reviews.llvm.org/D56489
Modified:
cfe/trunk/include/clang/
The tests probably shouldn't run when LLVM_ENABLE_PIC=OFF is set, since
they all fail there (due to lib/libclang.so not existing).
On Thu, Oct 11, 2018 at 7:59 AM Michal Gorny via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: mgorny
> Date: Thu Oct 11 04:58:14 2018
> New Revision: 34
As long as check-all passes with LLVM_ENABLE_PIC=OFF I'm happy :-) (Note
it's .dylib on macOS and .dll on Windows, and by default
setting LLVM_ENABLE_PIC=OFF causes a static library to be created instead
on non-win).
On Tue, Jan 15, 2019 at 1:16 PM Michał Górny wrote:
> On Tue, 2019-01-15 at 13:
(Follow-up: Michał landed a fix in r351304. Thanks!)
On Tue, Jan 15, 2019 at 1:21 PM Nico Weber wrote:
> As long as check-all passes with LLVM_ENABLE_PIC=OFF I'm happy :-) (Note
> it's .dylib on macOS and .dll on Windows, and by default
> setting LLVM_ENABLE_PIC=OFF causes a static library to be
For the archives, here's said patch: https://reviews.llvm.org/D56816
(Thanks!)
On Wed, Jan 16, 2019 at 5:26 PM Alex L wrote:
> Hi,
>
> We are planning to fix this issue by not checking if the method is
> defined. I will post a patch this week.
>
> Cheers,
> Alex
>
> On Fri, 11 Jan 2019 at 10:26
(-old cfe-commits, +new cfe-commits)
On Fri, Jan 18, 2019 at 8:21 AM Nico Weber wrote:
> I found this comment useful, but from your reply it sounds like it's no
> longer true:
>
> - // We must indicate which VFTable is larger to support linking
> between
> - // translation unit
Please don't do changes like this. They have marginal utility and make
blame output more annoying to work with.
On Fri, Jan 18, 2019 at 5:18 PM Stephen Kelly via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: steveire
> Date: Fri Jan 18 14:14:59 2019
> New Revision: 351603
>
> URL: ht
(To be clear, your 3 others around the same time are all fine! I mean just
bracing tweaks.)
On Mon, Jan 21, 2019 at 9:03 PM Nico Weber wrote:
> Please don't do changes like this. They have marginal utility and make
> blame output more annoying to work with.
>
> On Fri, Jan 18, 2019 at 5:18 PM St
I don't have a reduced test case yet, but this seems to cause clang to
sometimes claim that an included file isn't found even if it's there, at
least on macOS: https://bugs.chromium.org/p/chromium/issues/detail?id=924225
On Mon, Nov 19, 2018 at 8:40 AM Sam McCall via cfe-commits <
cfe-commits@list
1 - 100 of 1693 matches
Mail list logo
