[PATCH] D59838: gn build: Add build files for clang-include-fixer and find-all-symbols

mbonadei accepted this revision. mbonadei added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59838/new/ https://reviews.llvm.org/D59838 ___ cfe-commits mailing list cfe-comm

[PATCH] D59899: gn build: Add some build files for clangd

mbonadei accepted this revision. mbonadei added a comment. This revision is now accepted and ready to land. Sorry for the delay, LGTM % 2 small comments. Comment at: llvm/utils/gn/secondary/clang-tools-extra/clang-apply-replacements/BUILD.gn:2 static_library("clang-apply-repl

[PATCH] D59955: gn build: Add check-clang-tools to run clang-tools-extra lit tests

mbonadei accepted this revision. mbonadei added a comment. This revision is now accepted and ready to land. Really nice work! LGTM (also patched locally and tested). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59955/new/ https://reviews.llvm.org/D59955

[PATCH] D60038: gn build: Add build files for most clang-tools-extra unit tests

mbonadei accepted this revision. mbonadei added a comment. This revision is now accepted and ready to land. LGTM, just a small style comment. Comment at: llvm/utils/gn/secondary/clang-tools-extra/unittests/clang-apply-replacements/BUILD.gn:3 + +unittest("ClangApplyReplacements

[PATCH] D60124: gn build: Add build files for non-framework xpc clangd bits

mbonadei accepted this revision. mbonadei added a comment. This revision is now accepted and ready to land. LGTM, just a couple of comments. Comment at: llvm/utils/gn/secondary/clang-tools-extra/clangd/xpc/BUILD.gn:17 + configs += [ "//llvm/utils/gn/build:clang_code" ] + deps

[PATCH] D60130: gn build: Add build files for clangd xpc framework code

mbonadei accepted this revision. mbonadei added a comment. This revision is now accepted and ready to land. Really nice work and thanks for the thread on gn-dev about create_bundle! LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60130/new/ https://reviews.llvm.org/D60130 __

[PATCH] D65462: gn build: Fix check-clang-tools after r362702.

mbonadei added a comment. LGTM. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65462/new/ https://reviews.llvm.org/D65462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

[PATCH] D63929: [clang-tidy] - Introduce abseil-prefixed-thread-annotations check.

mbonadei created this revision. Herald added subscribers: llvm-commits, cfe-commits, xazax.hun, mgorny. Herald added projects: clang, LLVM. The new clang-tidy check "abseil-prefixed-thread-annotations" checks for usages of deprecated Abseil thread annotation macros and migrates them to the new m