Author: logan
Date: Fri Feb 23 23:57:32 2018
New Revision: 326027
URL: http://llvm.org/viewvc/llvm-project?rev=326027&view=rev
Log:
Cleanup __config indention NFC
This commit indents each level by two space characters, e.g.
#if defined(CONDITION)
# define _LIBCPP_NAME VALUE
#else
# define _LI
Author: logan
Date: Mon Oct 3 06:08:17 2016
New Revision: 283100
URL: http://llvm.org/viewvc/llvm-project?rev=283100&view=rev
Log:
[CMake] Fix libc++abi standalone cmake build.
The cmake files install directory has been changed to
${prefix}/lib/cmake/llvm since r259821. Searching cmake modules
logan closed this revision.
logan added a comment.
Thanks for reviewing. Committed as rL283100.
https://reviews.llvm.org/D24081
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
logan added a comment.
Ping. Any further comments? Or, should we duplicate `` in multiple
repositories?
https://reviews.llvm.org/D24084
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
Author: logan
Date: Mon Oct 3 11:00:22 2016
New Revision: 283118
URL: http://llvm.org/viewvc/llvm-project?rev=283118&view=rev
Log:
[lit] Allow more file extensions for test cases.
This commit splits the file extensions before determining the test
format. This allows libc++abi to add assembly-ba
logan closed this revision.
logan added a comment.
Thanks for reviewing. Committed as rL283118 with the suggested change
regarding to `is_sh_test` assertion.
https://reviews.llvm.org/D24087
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
h
logan added a comment.
Ping? Any other comments?
https://reviews.llvm.org/D24082
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
logan added inline comments.
> mclow.lists wrote in cxa_personality.cpp:363
> It's not clear to me how this accomplishes what you want.
> You're looking for `00/10/90`, right? Why not just check for that?
>
> Why are you anding with 0x0f ?
> Before, this would pass only a single value - `DW_EH_
Author: logan
Date: Wed Aug 31 10:16:40 2016
New Revision: 280251
URL: http://llvm.org/viewvc/llvm-project?rev=280251&view=rev
Log:
Wrap LIBCXXABI_USE_LLVM_UNWINDER with defined().
This commit fixes -Wundef by replacing:
#if !LIBCXXABI_USE_LLVM_UNWINDER
with:
#if !defined(LIBCXXABI_USE
logan created this revision.
logan added reviewers: mclow.lists, rengolin, EricWF.
logan added a subscriber: cfe-commits.
This commit replaces print statement with lit_config.note(). This fixes
python3 support for check-libcxxabi.
https://reviews.llvm.org/D24080
Files:
test/lit.cfg
Index: te
logan created this revision.
logan added reviewers: mclow.lists, rengolin.
logan added a subscriber: cfe-commits.
Herald added subscribers: samparker, rengolin, aemerson.
GCC 4.7 or newer emits 0x90 (indirect | pcrel) as the ttype encoding.
This would hit an assertion in cxa_personality.cpp. This
logan created this revision.
logan added reviewers: mclow.lists, rengolin, EricWF.
logan added a subscriber: cfe-commits.
Herald added a subscriber: aemerson.
This commit fixes __aeabi_idiv() link error when we are building
libc++abi with compiler-rt.
When compiler-rt is enabled, the option `--rt
logan created this revision.
logan added reviewers: mclow.lists, rengolin, EricWF.
logan added a subscriber: cfe-commits.
Herald added subscribers: samparker, rengolin, aemerson.
This commit fixes libc++abi build when LLVM unwinder (libunwind_llvm) is
not enabled.
This commit fixes the problem by
logan created this revision.
logan added reviewers: mclow.lists, rengolin, EricWF, danalbert, thakis.
logan added a subscriber: cfe-commits.
This commit refines the code for libunwind lookup.
First, this commit will always search for libunwind no matter LLVM
unwinder is enabled or not. We have t
logan created this revision.
logan added reviewers: mclow.lists, rengolin, EricWF.
logan added a subscriber: cfe-commits.
The cmake files install directory has been changed to
${prefix}/lib/cmake/llvm since r259821. Searching cmake modules in
${prefix}/share/llvm/cmake will result in fatal errors
logan added a comment.
Yes. This is what we have today.
We can either (1) specify the path to libunwind or (2) manually download
`unwind.h` header from libunwind project and place it to `include` directory.
https://reviews.llvm.org/D24084
___
cfe
logan created this revision.
logan added reviewers: mclow.lists, EricWF.
logan added a subscriber: cfe-commits.
This commit splits the file extensions before determining the test
format. This allows libc++abi to add assembly-based test cases.
https://reviews.llvm.org/D24087
Files:
test/libcxx
logan added a comment.
In https://reviews.llvm.org/D24084#530433, @rengolin wrote:
> That is a horrible dependency... I never hit it because I always test libc++
> with libunwind.
I think the best solution is to move/merge `libunwind/include/unwind.h` to/with
`clang/lib/Headers/unwind.h`. An
logan accepted this revision.
logan added a comment.
This revision is now accepted and ready to land.
Sorry for the late reply. Thanks for your work. Yes, this is correct.
However, it seems that this differential can be closed since it has been
committed as https://reviews.llvm.org/rL271737.
logan added a comment.
In https://reviews.llvm.org/D24084#532724, @asl wrote:
> I totally agree with Renato. What part of libc++abi requires exactly
> libunwind's unwind.h, what is the dependency?
To be specific, we need:
- Structure Definition: `_Unwind_Control_Block` (missing from ``
bundl
Author: logan
Date: Fri Sep 2 08:56:05 2016
New Revision: 280484
URL: http://llvm.org/viewvc/llvm-project?rev=280484&view=rev
Log:
[lit] Replace print with lit_config.note().
This commit replaces print statement with lit_config.note(). This fixes
python3 support for check-libcxxabi.
Modified:
logan added a comment.
Thanks. Committed as https://reviews.llvm.org/rL280484.
https://reviews.llvm.org/D24080
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
logan added inline comments.
Comment at: test/libcxx/test/format.py:69
@@ +68,3 @@
+name_root, name_ext = os.path.splitext(name)
+is_sh_test = name_root.endswith('.sh')
+is_pass_test = name_root.endswith('.pass')
EricWF wrote:
> Since we on
logan added a comment.
Hi @rengolin and @EricWF,
After tracing the commit log of clang, it seems that `--rtlib=` is ignored
intentionally when `-nodefaultlibs` is present. (see also:
https://reviews.llvm.org/rL254535)
And, unfortunately, we don't have a command line option to ask clang to lin
logan added inline comments.
Comment at: src/cxa_personality.cpp:363
+ "Unexpected TTypeEncoding");
(void)ttypeEncoding;
mclow.lists wrote:
> logan wrote:
> > mclow.lists wrote:
> > > It's not clear to me how this accomplishes what you want.
> >
logan updated this revision to Diff 76394.
logan added a comment.
Refine assertions to address the comments from mclow.lists.
https://reviews.llvm.org/D24085
Files:
src/cxa_personality.cpp
test/lit.cfg
test/lit.site.cfg.in
test/native/arm-linux-eabi/lit.local.cfg
test/native/arm-linux
logan added a comment.
Hi @EricWF and @mclow.lists:
Do you have any comments?
https://reviews.llvm.org/D24082
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
logan added a comment.
Hi @EricWF:
Thanks for your comment.
However, I think `OFF` is a better default for ARM (just like other platforms.)
I usually use `libc++abi` without `libunwind` since `libgcc` is quite stable
and usually linked by default. Besides, it is much more tricky to get the
logan added a comment.
Hi @EricWF:
Would you mind if I commit this patch as-is? I believe `OFF` will is the
better default value for ARM as well. Thanks.
Logan
https://reviews.llvm.org/D24082
___
cfe-commits mailing list
cfe-commits@lists.llvm.
Author: logan
Date: Sun Nov 13 08:42:15 2016
New Revision: 286759
URL: http://llvm.org/viewvc/llvm-project?rev=286759&view=rev
Log:
[CMake] Fix libc++abi arm build w/o libunwind.
This commit fixes libc++abi build when LLVM unwinder (libunwind_llvm) is
not enabled.
This commit fixes the problem b
logan closed this revision.
logan added a comment.
Thanks. Committed as https://reviews.llvm.org/rL286759.
https://reviews.llvm.org/D24082
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
Author: logan
Date: Sun Nov 13 08:44:41 2016
New Revision: 286760
URL: http://llvm.org/viewvc/llvm-project?rev=286760&view=rev
Log:
arm: Fix ttype encoding assertion failure.
GCC 4.7 or newer emits 0x90 (indirect | pcrel) as the ttype encoding.
This would hit an assertion in cxa_personality.cpp.
logan closed this revision.
logan added a comment.
Thanks for reviewing. Committed as https://reviews.llvm.org/rL286760.
https://reviews.llvm.org/D24085
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
logan added a comment.
In general, it looks good to me if the comments are addressed.
Sorry for not replying responsively. Not sure why I missed the follow-up
e-mails after @rengolin's reply.
Comment at: lib/Headers/unwind.h:61
@@ +60,3 @@
+#define _UNWIND_ARM_EHABI 0
+#endif
logan added inline comments.
Comment at: lib/Headers/unwind.h:61
@@ +60,3 @@
+#define _UNWIND_ARM_EHABI 0
+#endif
+
compnerd wrote:
> logan wrote:
> > Since this is `unwind.h`, I feel that we can get a step further and use
> > `__ARM_EABI_UNWINDER__` to get more
logan added inline comments.
Comment at: lib/Headers/unwind.h:61
@@ +60,3 @@
+#define _UNWIND_ARM_EHABI 0
+#endif
+
compnerd wrote:
> logan wrote:
> > compnerd wrote:
> > > logan wrote:
> > > > Since this is `unwind.h`, I feel that we can get a step further and us
logan added inline comments.
Comment at: lib/Headers/unwind.h:61
@@ +60,3 @@
+#define _UNWIND_ARM_EHABI 0
+#endif
+
logan wrote:
> compnerd wrote:
> > logan wrote:
> > > compnerd wrote:
> > > > logan wrote:
> > > > > Since this is `unwind.h`, I feel that we can ge
logan added inline comments.
Comment at: lib/Headers/unwind.h:61
@@ +60,3 @@
+#define _UNWIND_ARM_EHABI 0
+#endif
+
compnerd wrote:
> logan wrote:
> > logan wrote:
> > > compnerd wrote:
> > > > logan wrote:
> > > > > compnerd wrote:
> > > > > > logan wrote:
> > >
logan accepted this revision.
logan added a comment.
LGTM. It is good to go now.
@timonvo, do you have commit access? Or, do you need some assistance?
http://reviews.llvm.org/D15883
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://l
Author: logan
Date: Sun Feb 28 09:01:42 2016
New Revision: 262178
URL: http://llvm.org/viewvc/llvm-project?rev=262178&view=rev
Log:
Add ARM EHABI-related constants to unwind.h.
Adds a number of constants, defined in the ARM EHABI spec, to the Clang
lib/Headers/unwind.h header. This is prerequisit
logan added a comment.
Hi @timonvo,
I have committed this change as http://reviews.llvm.org/rL262178. Thanks for
your work.
Let's move forward to http://reviews.llvm.org/D15781.
http://reviews.llvm.org/D15883
___
cfe-commits mailing list
cfe-com
logan added a subscriber: logan.
logan added a comment.
The simple replacement from `throw()` to `_NOEXCEPT` looks fine.
But, why are you adding adding some copy constructors and assignment operators?
May you briefly explain the reason?
Besides, I have some concern with the `= default` specifi
logan created this revision.
logan added reviewers: rengolin, danalbert, kevin.qin, echristo, srhines.
logan added a subscriber: cfe-commits.
Herald added subscribers: rengolin, aemerson.
This commit adds SHF_ALLOC and SHF_EXECINSTR section flags to
.text.__cxa_end_cleanup section. This fixes a l
logan added a comment.
@echristo: IMO, I prefer not to add such comment for two reasons:
1. It will obscure the main idea of this piece of code.
2. It is common to specify the section flags (compilers will emit these flags
by default as well), so it is unlikely to be removed in the future.
Bes
Author: logan
Date: Tue Dec 22 08:38:30 2015
New Revision: 256241
URL: http://llvm.org/viewvc/llvm-project?rev=256241&view=rev
Log:
Fix ARM __cxa_end_cleanup() and gc-sections.
This commit adds SHF_ALLOC and SHF_EXECINSTR section flags to
`.text.__cxa_end_cleanup` section. This fixes a link erro
logan closed this revision.
logan added a comment.
Thanks! Committed as http://reviews.llvm.org/rL256241.
http://reviews.llvm.org/D15613
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
46 matches
Mail list logo
