Re: [PATCH] D25932: Unconditionally pass `-lto_library` to the linker on Darwin

2016-11-22 Thread Jack Howarth via cfe-commits
I would also note that llvm 3.9.x and 4.0svn also require use of their own llvm-ar and llvm-ranlib for archiving under -flto as well (beyond using the matching libLTO.dylib). On Tue, Nov 22, 2016 at 12:59 AM, Mehdi Amini wrote: > Double-checked on the latest binary release on llvm.org, it ships w

[PATCH] D25932: Unconditionally pass `-lto_library` to the linker on Darwin

2016-10-27 Thread Jack Howarth via cfe-commits
jwhowarth reopened this revision. jwhowarth added a comment. This approach doesn't work if the user installs clang in a buried subdirectory such as /sw/opt/llvm-4.0 but accesses the compilers via a /sw/bin/clang-4.0 symlink pointing at /sw/opt/llvm-4.0/bin/clang-4.0... $ /sw/bin/clang-4.0 -flto

[PATCH] D25932: Unconditionally pass `-lto_library` to the linker on Darwin

2016-10-27 Thread Jack Howarth via cfe-commits
jwhowarth added a comment. Opened https://llvm.org/bugs/show_bug.cgi?id=30811 since the inability for symlinks to be handled in locating libLTO.dylib defeats the purpose of this commit. Repository: rL LLVM https://reviews.llvm.org/D25932 ___ cf

[PATCH] D25932: Unconditionally pass `-lto_library` to the linker on Darwin

2016-10-27 Thread Jack Howarth via cfe-commits
jwhowarth added a comment. In https://reviews.llvm.org/D25932#581167, @mehdi_amini wrote: > I just verified that I reproduce with -flto and an previous clang version. This issue will only be triggered if you build with "-DCMAKE_INSTALL_PREFIX:PATH=/sw/opt/llvm-4.0" to place llvm in a buried s

Re: [PATCH] D13802: [OPENMP] Make -fopenmp to turn on OpenMP support by default.

2015-10-28 Thread Jack Howarth via cfe-commits
jhowarth added a subscriber: jhowarth. jhowarth added a comment. The proposed patches here to change the default behavior of -fopenmp from -fopenmp=libgomp to -fopenmp=libomp seem to only handle the configure-based build. The following change required to switch over the crake-based build to def

Re: [PATCH] D13802: [OPENMP] Make -fopenmp to turn on OpenMP support by default.

2015-10-28 Thread Jack Howarth via cfe-commits
jhowarth added a comment. The CMakeLists.txt change cited is in top-level of the clang sources and not in the llvm top-level. http://reviews.llvm.org/D13802 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailm

Re: r258307 - [OPENMP 4.0] Fix for codegen of 'cancel' directive within 'sections' directive.

2016-01-27 Thread Jack Howarth via cfe-commits
Tested the attached patch which contains a back port of the net changes from both r258307 and Author: abataev Date: Fri Jan 22 02:56:50 2016 New Revision: 258495 URL: http://llvm.org/viewvc/llvm-project?rev=258495&view=rev Log: [OPENMP] Generalize codegen for 'sections'-based directive. If 'secti