[PATCH] D140828: [C++] Implement "Deducing this" (P0847R7)

2023-07-29 Thread Hristo Hristov via Phabricator via cfe-commits
Zingam added a comment. Is this going to land soon? There is a libc++ paper I'm interested in that relies on "deducing this" and I wonder if I should wait for "this" first before I start working on it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D140828: [C++] Implement "Deducing this" (P0847R7)

2023-08-03 Thread Hristo Hristov via Phabricator via cfe-commits
Zingam added a comment. In D140828#4544438 , @cor3ntin wrote: > In D140828#4544433 , @Zingam wrote: > >> Is this going to land soon? There is a libc++ paper I'm interested in that >> relies on "deducing this" and

[PATCH] D24886: Add [[clang::suppress(rule, ...)]] attribute

2017-10-29 Thread Hristo Hristov via Phabricator via cfe-commits
roccoor added a comment. Microsoft supports: [[gsl::suppress(bounds.3)]] Clang requires: [[gsl::suppress("bounds.3")]] Why is this inconsistency? Here is an example from CppCoreGuidelines [[suppress(bounds)]] char* raw_find(char* p, int n, char x)// find x in p[0]..p[n - 1] {

[PATCH] D151627: [clang][c++20][NFC] `ComparisonCategoryType` - updated comment, removed `std:*_equality`

2023-05-28 Thread Hristo Hristov via Phabricator via cfe-commits
H-G-Hristov created this revision. Herald added a project: All. H-G-Hristov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. `weak_equality` and `strong_equality` are removed from the standard: - https://wg21.link/P1959R0 - https://eel.is/c

[PATCH] D125171: [clang-format] Add a new clang-format option AlwaysBreakBeforeFunctionParameters

2023-05-28 Thread Hristo Hristov via Phabricator via cfe-commits
H-G-Hristov added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:25716 + "int param2,\n" + "int param3);\n", + Style); Does this work with `BAS_BlockIndent`? I don't see any related tests. Re

[PATCH] D151627: [clang][c++20][NFC] `ComparisonCategoryType` - updated comment, removed `std:*_equality`

2023-05-28 Thread Hristo Hristov via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGfb250b8295b9: [clang][c++20][NFC] `ComparisonCategoryType` - updated comment, removed `stdā€¦ (authored by Zingam). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D150321: [clang] Document extensions from later standards

2023-05-11 Thread Hristo Hristov via Phabricator via cfe-commits
H-G-Hristov added inline comments. Comment at: clang/docs/LanguageExtensions.rst:1398 +``static operator()`` __cpp_static_call_operator C++23 C++03 +Strucuted bindings __cpp_structured_bindingsC++17 C++03 +template te