haampie wrote:
Users of `GCC_INSTALL_PREFIX` typically have GCC installed in a unique,
non-standard prefix, where clang's default search just worked.
Now those users have to generate config files for post-install, AND figure out
how to make clang behave correctly when building runtimes. That's
haampie wrote:
I disagree, `--gcc-install-dir` is sure an improvement over `--gcc-toolchain`,
but they're both weaker than the compile time option `GCC_INSTALL_PREFIX`
because of runtimes.
You're looking to remove `GCC_INSTALL_PREFIX`, then give a clear alternative
that's equivalent. The curr
haampie wrote:
@yxsamliu can you land this? I cannot
https://github.com/llvm/llvm-project/pull/133263
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/haampie edited
https://github.com/llvm/llvm-project/pull/133263
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/haampie edited
https://github.com/llvm/llvm-project/pull/133263
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/haampie edited
https://github.com/llvm/llvm-project/pull/133263
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
haampie wrote:
I believe Spack sets either `HIP_PATH` or `ROCM_PATH` for clang which is
considered before the auto-detection removed in this PR.
https://github.com/llvm/llvm-project/pull/133263
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
h
https://github.com/haampie created
https://github.com/llvm/llvm-project/pull/133263
There is special logic to detect the hip runtime when llvm is installed
with Spack. It works by matching the install prefix of llvm against
`llvm-amdgpu-*` followed by effectively globbing for
```
/../hip-x.y.z-
