[PATCH] D93600: When querying drivers by binary, look in PATH too

rapgenic created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. rapgenic requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Sometimes compile_commands.json databases are created without an absolute path for the driver

[PATCH] D93600: [clangd] When querying drivers by binary, look in PATH too

rapgenic added a comment. Just wanted to say that this is my first patch submission to the LLVM/clangd project, so please call me out on any mistake! The arc tool caught me by surprise by opening the revision before I could double check it, hence the rename and edits... Repository: rG LLVM

[PATCH] D93600: [clangd] When querying drivers by binary, look in PATH too

rapgenic updated this revision to Diff 313259. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93600/new/ https://reviews.llvm.org/D93600 Files: clang-tools-extra/clangd/QueryDriverDatabase.cpp clang-tools-extra/clangd/test/system-include-extractor.test Index: clang-tools-extra/clang

[PATCH] D93600: [clangd] When querying drivers by binary, look in PATH too

rapgenic marked 3 inline comments as done. rapgenic added a comment. I think I have fixed what you asked! About the test, I thought it would be reasonable to test the three cases separately, however I cannot get it to work with a single test file (I think it's some problem with the generated fi

[PATCH] D93600: [clangd] When querying drivers by binary, look in PATH too

rapgenic updated this revision to Diff 313528. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93600/new/ https://reviews.llvm.org/D93600 Files: clang-tools-extra/clangd/QueryDriverDatabase.cpp clang-tools-extra/clangd/test/system-include-extractor.test Index: clang-tools-extra/clang

[PATCH] D93600: [clangd] When querying drivers by binary, look in PATH too

rapgenic marked 3 inline comments as done. rapgenic added a comment. Done! My email is: Giulio Girardi Thank you for your help! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93600/new/ https://reviews.llvm.org/D93600 ___ cfe-commits mailin

[PATCH] D93763: [clangd] Add a flag to disable the documentLinks LSP request

rapgenic created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. rapgenic requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. On some editors (namely VSCode) documentLinks are rendered with an unde

[PATCH] D93763: [clangd] Add a flag to disable the documentLinks LSP request

rapgenic updated this revision to Diff 313667. rapgenic added a comment. Fix formatting CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93763/new/ https://reviews.llvm.org/D93763 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp clang-tools-extra/clangd/ClangdLSPServer.h clang-to

[PATCH] D93763: [clangd] Add a flag to disable the documentLinks LSP request

rapgenic marked 4 inline comments as done. rapgenic added a comment. > In the future it may make sense to have other documentLinks too. (e.g. > imagine a comment Configures the Frobnicator - we should linkify Frobnicator > to point to a class, once documentLink supports target ranges). So we sho

[PATCH] D93763: [clangd] Add a flag to disable the documentLinks LSP request

rapgenic updated this revision to Diff 314718. rapgenic marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93763/new/ https://reviews.llvm.org/D93763 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp clang-tools-extra/clangd/ClangdLSPServer.h clang-to