eugenis accepted this revision.
eugenis added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D26764
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
eugenis accepted this revision.
eugenis added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D26796
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
eugenis added inline comments.
Comment at: lib/Driver/ToolChains/Linux.cpp:867
getTriple().getArch() == llvm::Triple::aarch64_be;
+ const bool IsArmArch = getTriple().getArch() == llvm::Triple::arm;
SanitizerMask Res = ToolChain::getSupportedSanitize
eugenis added a comment.
I think it should also include armeb and thumbeb for completeness.
Repository:
rL LLVM
https://reviews.llvm.org/D31760
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
eugenis accepted this revision.
eugenis added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rL LLVM
https://reviews.llvm.org/D31760
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
eugenis created this revision.
The linux part is a bit ahead of time - the instrumentation code where this
matters have not landed yet. But when it does, this would be the right
condition, and for now ELF instrumentation simply ignores this setting.
Repository:
rL LLVM
https://reviews.llvm.
eugenis added a comment.
From a quick look at the code, it seems like -fno-data-sections on COFF would
suppress GC of globals the same as on ELF. Is that true?
Repository:
rL LLVM
https://reviews.llvm.org/D32064
___
cfe-commits mailing list
cfe-
eugenis updated this revision to Diff 95254.
eugenis retitled this revision from "[asan] Disable ASan global-GC depending on
the target and CGOpts" to "[asan] Disable ASan global-GC depending on the
target and compiler flags".
Repository:
rL LLVM
https://reviews.llvm.org/D32064
Files:
lib/
eugenis added a comment.
Looks fine.
https://reviews.llvm.org/D32043
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
eugenis added inline comments.
Comment at: lib/Driver/SanitizerArgs.cpp:636
+ case llvm::Triple::COFF:
+return DataSections;
+ case llvm::Triple::ELF:
rnk wrote:
> We can return true for COFF here. By adding a comdat during asan
> instrumentation, we effec
eugenis added a comment.
Ping.
I don't really have a preference.
Repository:
rL LLVM
https://reviews.llvm.org/D32064
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
eugenis added a comment.
A test would be nice.
Repository:
rL LLVM
https://reviews.llvm.org/D29077
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
eugenis accepted this revision.
eugenis added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rL LLVM
https://reviews.llvm.org/D29077
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
eugenis added a comment.
I think this is the right move together with https://reviews.llvm.org/D26796.
Android build system will need to support both names for some time, depending
on the toolchain version - looks doable. Technically, it can stick with the old
name forever.
https://reviews.llv
eugenis closed this revision.
eugenis added a comment.
Committed in r286613
Repository:
rL LLVM
https://reviews.llvm.org/D25928
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
eugenis added a comment.
The ultimate solution would be a function attribute - if we want this thing to
work correctly with LTO. But it sounds a bit like overkill, plus none of the
settings it depends on (integrated-as, data-sections) work with LTO anway: the
former is ignored and the second do
eugenis updated this revision to Diff 96227.
eugenis added a comment.
Reverted back to using pass constructor argument.
Repository:
rL LLVM
https://reviews.llvm.org/D32064
Files:
lib/CodeGen/BackendUtil.cpp
Index: lib/CodeGen/BackendUtil.cpp
==
eugenis added a comment.
what kind of test?
Repository:
rL LLVM
https://reviews.llvm.org/D32064
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
eugenis updated this revision to Diff 96263.
Repository:
rL LLVM
https://reviews.llvm.org/D32064
Files:
lib/CodeGen/BackendUtil.cpp
test/CodeGen/asan-globals-gc.cpp
Index: test/CodeGen/asan-globals-gc.cpp
===
--- /dev/null
+
eugenis added a comment.
PTAL
Repository:
rL LLVM
https://reviews.llvm.org/D32064
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
eugenis added a comment.
We definitely want different blacklists for ASan and MSan.
https://reviews.llvm.org/D32043
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
eugenis created this revision.
This change restores pre-r301225 behavior, where linker GC compatible global
instrumentation was used on COFF targets disregarding -f(no-)data-sections
and/or
/Gw flags.
Repository:
rL LLVM
https://reviews.llvm.org/D32514
Files:
lib/CodeGen/BackendUtil.cpp
eugenis added a comment.
Apparently the ODR detector in Asan on Windows has issues with full
data-sections. This way we can have limited GC for user globals.
Repository:
rL LLVM
https://reviews.llvm.org/D32514
___
cfe-commits mailing list
cfe-co
eugenis added a comment.
r301374
Repository:
rL LLVM
https://reviews.llvm.org/D32514
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
24 matches
Mail list logo
