[PATCH] D105049: [NFC] Remove extra semicolons in clang/lib/APINotes/APINotesFormat.h

etcwilde created this revision. etcwilde added a reviewer: compnerd. etcwilde added a project: clang. etcwilde requested review of this revision. Herald added a subscriber: cfe-commits. There are some trailing semicolons on namespaces in clang/lib/APINotes/APINotesFormat.h. These result in warnin

[PATCH] D112890: headers: optionalise some generated resource headers

etcwilde added a comment. This makes sense to me. It doesn't make sense to spend the time generating files that will never get used, nor spend the space for storing them. `riscv_vector.h` in particular is quite large, coming in at just under 10M, and there are two of them showing up in my build

[PATCH] D112890: headers: optionalise some generated resource headers

etcwilde added a comment. Right, the header is only necessary when you're targeting riscv, so if compiling for riscv isn't supported by the compiler noted in the `LLVM_TARGETS_TO_BUILD`, you don't need it and can't use it anyway. This is separate from the host platform that the compiler is runni

[PATCH] D105049: [NFC] Remove extra semicolons in clang/lib/APINotes/APINotesFormat.h

This revision was automatically updated to reflect the committed changes. Closed by commit rGe4ad1f976d12: [NFC] Remove extra semicolons in clang/lib/APINotes/APINotesFormat.h (authored by etcwilde). Herald added a project: All. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D154664: [NFC] Add some missing header includes

etcwilde created this revision. etcwilde added reviewers: compnerd, mib. etcwilde added projects: clang, LLVM. Herald added a project: All. etcwilde requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits. Fixing local build failures due to missing header includes.

[PATCH] D154664: [NFC] Add some missing header includes

etcwilde updated this revision to Diff 537916. etcwilde added a comment. Grabbed the right patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154664/new/ https://reviews.llvm.org/D154664 Files: llvm/include/llvm/Support/Format.h llvm/include/

[PATCH] D154664: [NFC] Add some missing header includes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0f9f95146a7f: [NFC] Add optional include to Format.h (authored by etcwilde). Changed prior to commit: https://reviews.llvm.org/D154664?vs=537916&i

[PATCH] D155413: [NFC] Add `push_back` to `llvm::Function`

etcwilde created this revision. etcwilde added reviewers: compnerd, vporpo. etcwilde added a project: LLVM. Herald added a project: All. etcwilde requested review of this revision. Herald added a project: clang. Herald added subscribers: llvm-commits, cfe-commits. Appending a basic block to a func

[PATCH] D155413: [NFC] Add `push_back` to `llvm::Function`

etcwilde updated this revision to Diff 540850. etcwilde added a comment. Fixing `push_back` formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155413/new/ https://reviews.llvm.org/D155413 Files: clang/lib/CodeGen/CGStmt.cpp clang/lib/Co

[PATCH] D155413: [NFC] Add `push_back` to `llvm::Function`

etcwilde added a comment. Failure was a formatting issue in `clang/lib/Analysis/UnsafeBufferUsage.cpp`. I just fixed that in d7b45945fbb7c4ac27c456dd7c2ff8bb40fcf8f8 . I don't know how to re-trigger the tests though. Repositor