[PATCH] D36790: [ObjC] Messages to 'self' in class methods should use class method dispatch to avoid multiple method ambiguities

doug.gregor added a comment. Yes, I think it's reasonable to treat instancetype as an inherited requirement. I guess the only exception would be if we had some notion of final classes or methods in Objective-C, in which case they'd be able to return a concrete type. Repository: rL LLVM http

[PATCH] D57076: [ObjC generics] Fix applying `__kindof` to the type parameter.

doug.gregor accepted this revision. doug.gregor added a comment. This revision is now accepted and ready to land. One minor request about regarding a dyn_cast, but this looks like the right approach. Thank you! Comment at: clang/lib/AST/Type.cpp:1293 + +const auto *newAttr

[PATCH] D37089: [Sema] Error out early for tags defined inside an enumeration.

doug.gregor accepted this revision. doug.gregor added a comment. This revision is now accepted and ready to land. Looks good to me; sorry for the delay. https://reviews.llvm.org/D37089 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://l

[PATCH] D44670: [CXX] Templates specialization visibility can be wrong

doug.gregor added inline comments. Comment at: lib/AST/Decl.cpp:1078 +for (const auto *RD : + spec->getSpecializedTemplate()->getTemplatedDecl()->redecls()) { + auto Vis = getVisibilityOf(RD, kind); Do we want to look at *all* redeclarations, or

[PATCH] D44670: [CXX] Templates specialization visibility can be wrong

doug.gregor accepted this revision. doug.gregor added a comment. This revision is now accepted and ready to land. LGTM, thanks Repository: rC Clang https://reviews.llvm.org/D44670 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lis

[PATCH] D84005: Introduce ns_error_domain attribute.

doug.gregor added a comment. In D84005#2171982 , @MForster wrote: > @milseman, @doug.gregor, could you please help with the open questions on > this review? > > Specifically: > > - Is `ns_error_domain` ever needed for something other than an enum? No, i

[PATCH] D130205: [Darwin toolchain] Tune the logic for finding arclite.

doug.gregor created this revision. doug.gregor added a reviewer: arphaman. doug.gregor added a project: clang. Herald added a project: All. doug.gregor requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. The heuristic used to determine where the arclite libraries are

[PATCH] D36530: [Parse] Document PrintStats, SkipFunctionBodies

doug.gregor added a comment. LGTM, thank you! Repository: rL LLVM https://reviews.llvm.org/D36530 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D87534: Sema: introduce `__attribute__((__swift_name__))`

doug.gregor added a comment. Thank you for doing this! Comment at: clang/include/clang/Basic/Attr.td:2173 + SubjectList<[Enum, EnumConstant, Field, Function, GlobalVar, Struct, TypedefName, + ObjCInterface, ObjCClassMethod, ObjCInstanceMethod, ObjCPrope

[PATCH] D92495: [clang] Add a new nullability annotation for swift async: _Nullable_result

doug.gregor accepted this revision. doug.gregor added a comment. This revision is now accepted and ready to land. This looks great to me, thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92495/new/ https://reviews.llvm.org/D92495 ___

[PATCH] D92495: [clang] Add a new nullability annotation for swift async: _Nullable_result

doug.gregor added inline comments. Comment at: clang/test/SemaObjC/nullable-result.m:6 +@class NSError; + +@interface SomeClass Can you add a `__has_attribute` check for `_Nullable_result`? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92495/new/ https

[PATCH] D92355: [clang] add a `swift_async_name` attribute

doug.gregor accepted this revision. doug.gregor added a comment. Thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92355/new/ https://reviews.llvm.org/D92355 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D92742: [clang] Add support for attribute 'swift_async'

doug.gregor accepted this revision. doug.gregor added a comment. This revision is now accepted and ready to land. This looks good. I went ahead and tested it as part of adoption in Swift's Clang importer, over at https://github.com/apple/swift/pull/34985 CHANGES SINCE LAST ACTION https://revi

[PATCH] D69420: [clang][clang-scan-deps] Add support for extracting full module dependencies.

doug.gregor added a comment. It looks like Inputs/modules_cdb.json missing from this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69420/new/ https://reviews.llvm.org/D69420 ___ cfe-commits mail

[PATCH] D69420: [clang][clang-scan-deps] Add support for extracting full module dependencies.

doug.gregor added a comment. In D69420#1757664 , @Bigcheese wrote: > It was already there from a previous commit. I see it in tree currently. Oh, sorry. I missed it in my cherry-picking and GitHub search failed to find it. Repository: rG LLVM Github

[PATCH] D28349: [Frontend] The macro that describes the Objective-C bool type should be defined in C as well

doug.gregor added a comment. The "!LangOpts.CPlusPlus" doesn't make sense to me. You're presumably defining this macro in C because the Objective-C runtime is usable from C, but that same logic applies to C++ code. It seems like we should be defining this macro unconditionally. Repository:

[PATCH] D31378: [PCH] Attach instance's dependency collectors to PCH external AST sources.

doug.gregor accepted this revision. doug.gregor added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D31378 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/lis

[PATCH] D34741: [ASTReader] Treat multiple defns of ObjC protocols the same as interfaces.

doug.gregor accepted this revision. doug.gregor added a comment. This revision is now accepted and ready to land. Looks great! https://reviews.llvm.org/D34741 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mail

[PATCH] D35923: Fix PR32332 - PCM nondeterminism with builtins caused by global module index

doug.gregor added a comment. I am *very* concerned about this. The optimization that avoids doing lookups within module files where we "know" we won't find anything was very important at the time it was introduced, so I'd like to understand better why it didn't make a significant difference in

[PATCH] D27580: [modules] Add optional out-param to ASTReader::ReadAST for imported submodules.

doug.gregor accepted this revision. doug.gregor added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D27580 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/lis

[PATCH] D109451: Summary: Introduce a new frontend flag `-fswift-async-fp={auto|always|never}` that controls how code generation sets the Swift extended async frame info bit. There are three possibili

doug.gregor accepted this revision. doug.gregor added a comment. This revision is now accepted and ready to land. Looks great, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109451/new/ https://reviews.llvm.org/D109451 __