[clang] [Clang][Driver] Warn about `-c/-S` with `-fsyntax-only` (PR #98607)

2024-07-22 Thread Dmitry Chestnykh via cfe-commits
https://github.com/chestnykh closed https://github.com/llvm/llvm-project/pull/98607 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][Clang] Remove unused arg (PR #101650)

2024-08-02 Thread Dmitry Chestnykh via cfe-commits
https://github.com/chestnykh created https://github.com/llvm/llvm-project/pull/101650 `BuiltinID` is not used inside `CheckBuiltinTargetInSupported` >From 0f724e3aacde40f5d3d06c3e1082667dec36656b Mon Sep 17 00:00:00 2001 From: Dmitry Chestnykh Date: Fri, 2 Aug 2024 13:44:00 +0300 Subject: [PAT

[clang] [NFC][Clang] Remove unused arg (PR #101650)

2024-08-02 Thread Dmitry Chestnykh via cfe-commits
https://github.com/chestnykh updated https://github.com/llvm/llvm-project/pull/101650 >From 0f724e3aacde40f5d3d06c3e1082667dec36656b Mon Sep 17 00:00:00 2001 From: Dmitry Chestnykh Date: Fri, 2 Aug 2024 13:44:00 +0300 Subject: [PATCH 1/2] [NFC][Clang] Remove unused arg BuiltinID is not used in

[clang] [NFC][Clang] Remove unused arg (PR #101650)

2024-08-02 Thread Dmitry Chestnykh via cfe-commits
https://github.com/chestnykh closed https://github.com/llvm/llvm-project/pull/101650 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Adjust `exit()` builtin impl (PR #101689)

2024-08-02 Thread Dmitry Chestnykh via cfe-commits
https://github.com/chestnykh created https://github.com/llvm/llvm-project/pull/101689 - `_Exit` is an alias to `_exit` and `_exit` is declared in unistd.h header, so don't mix `_Exit` and `exit`. Only `exit` decl placed in stdlib.h. - Add `__builtin_` variants for exit functions like GC does >

[clang] [Clang] Adjust `exit()` builtin impl (PR #101689)

2024-08-02 Thread Dmitry Chestnykh via cfe-commits
https://github.com/chestnykh updated https://github.com/llvm/llvm-project/pull/101689 >From ee010a25b0df1371647285af8faaffe694a02d28 Mon Sep 17 00:00:00 2001 From: Dmitry Chestnykh Date: Fri, 2 Aug 2024 18:28:38 +0300 Subject: [PATCH] [Clang] Adjust `exit()` builtin impl - `_Exit` is an alias

[clang] [Clang] Adjust `exit()` builtin impl (PR #101689)

2024-08-02 Thread Dmitry Chestnykh via cfe-commits
https://github.com/chestnykh edited https://github.com/llvm/llvm-project/pull/101689 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Adjust `exit()` builtin impl (PR #101689)

2024-08-03 Thread Dmitry Chestnykh via cfe-commits
chestnykh wrote: > In #74803, the question of "why" came up and was never answered. Okay, i can remove `let AddBuiltinPrefixedAlias = 1;`, but IMO that the rest of changes makes sense. What do you think? https://github.com/llvm/llvm-project/pull/101689

[libunwind] [Libunwind] Don't XFAIL tests with msan (PR #120013)

2024-12-16 Thread Dmitry Chestnykh via cfe-commits
https://github.com/chestnykh converted_to_draft https://github.com/llvm/llvm-project/pull/120013 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [Libunwind] Try to fix msan failures (PR #120013)

2024-12-16 Thread Dmitry Chestnykh via cfe-commits
https://github.com/chestnykh edited https://github.com/llvm/llvm-project/pull/120013 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [Libunwind] Don't XFAIL tests with msan (PR #120013)

2024-12-15 Thread Dmitry Chestnykh via cfe-commits
https://github.com/chestnykh created https://github.com/llvm/llvm-project/pull/120013 None >From 95d35c8d4f95d2a08845d8951eb0ea7e0d97ec97 Mon Sep 17 00:00:00 2001 From: Dmitry Chestnykh Date: Sun, 15 Dec 2024 21:18:23 +0300 Subject: [PATCH] [Libunwind] Don't XFAIL tests with msan --- libunwi

[libunwind] [Libunwind] Don't XFAIL tests with msan (PR #120013)

2024-12-15 Thread Dmitry Chestnykh via cfe-commits
chestnykh wrote: @ldionne i run these tests locally with msan (x86-64) and have no errors. Could you please tell on what architecture(s) the tests was failing? https://github.com/llvm/llvm-project/pull/120013 ___ cfe-commits mailing list cfe-commits

[libunwind] [Libunwind] Don't XFAIL tests with msan (PR #120013)

2024-12-16 Thread Dmitry Chestnykh via cfe-commits
https://github.com/chestnykh updated https://github.com/llvm/llvm-project/pull/120013 >From 9422b097ff80f5501dcf4fa3d41176b9439ab3f6 Mon Sep 17 00:00:00 2001 From: Dmitry Chestnykh Date: Sun, 15 Dec 2024 21:18:23 +0300 Subject: [PATCH] [Libunwind] Don't XFAIL tests with msan --- libunwind/tes

[libunwind] [Libunwind] Don't XFAIL tests with msan (PR #120013)

2024-12-16 Thread Dmitry Chestnykh via cfe-commits
chestnykh wrote: All CI failures look unrelated https://github.com/llvm/llvm-project/pull/120013 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [Libunwind] Try to fix msan failures (PR #120013)

2024-12-16 Thread Dmitry Chestnykh via cfe-commits
chestnykh wrote: Maybe load order breaks something: With `-lunwind` passed explicitly: ``` linux-vdso.so.1 (0x700799647000) libunwind.so.1 => /usr/lib/libunwind.so.1 (0x7007995fe000) libatomic.so.1 => /usr/lib/libatomic.so.1 (0x7007995f3000) libc++.so.1

[libunwind] [Libunwind] Try to fix msan failures (PR #120013)

2024-12-16 Thread Dmitry Chestnykh via cfe-commits
https://github.com/chestnykh updated https://github.com/llvm/llvm-project/pull/120013 >From 9422b097ff80f5501dcf4fa3d41176b9439ab3f6 Mon Sep 17 00:00:00 2001 From: Dmitry Chestnykh Date: Sun, 15 Dec 2024 21:18:23 +0300 Subject: [PATCH 1/2] [Libunwind] Don't XFAIL tests with msan --- libunwind

[libunwind] [Libunwind] Try to fix msan failures (PR #120013)

2024-12-16 Thread Dmitry Chestnykh via cfe-commits
https://github.com/chestnykh updated https://github.com/llvm/llvm-project/pull/120013 >From 9422b097ff80f5501dcf4fa3d41176b9439ab3f6 Mon Sep 17 00:00:00 2001 From: Dmitry Chestnykh Date: Sun, 15 Dec 2024 21:18:23 +0300 Subject: [PATCH 1/3] [Libunwind] Don't XFAIL tests with msan --- libunwind

[libunwind] [Libunwind] Try to fix msan failures (PR #120013)

2024-12-17 Thread Dmitry Chestnykh via cfe-commits
chestnykh wrote: I've debugged msan errors. On CI there were stack overflows caused by 'wrong' msan reports and circular calls libunwind -> libmsan -> libunwind. For example: ``` #4234 0x55587eb2 in __msan_warning_with_origin_noreturn () at /home/dima/work/llvm-project/compiler-rt/lib/

[libunwind] [Libunwind] Try to fix msan failures (PR #120013)

2024-12-17 Thread Dmitry Chestnykh via cfe-commits
https://github.com/chestnykh updated https://github.com/llvm/llvm-project/pull/120013 >From 9422b097ff80f5501dcf4fa3d41176b9439ab3f6 Mon Sep 17 00:00:00 2001 From: Dmitry Chestnykh Date: Sun, 15 Dec 2024 21:18:23 +0300 Subject: [PATCH 1/4] [Libunwind] Don't XFAIL tests with msan --- libunwind

[libunwind] [Libunwind] Try to fix msan failures (PR #120013)

2024-12-17 Thread Dmitry Chestnykh via cfe-commits
https://github.com/chestnykh ready_for_review https://github.com/llvm/llvm-project/pull/120013 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [Libunwind] Try to fix msan failures (PR #120013)

2024-12-17 Thread Dmitry Chestnykh via cfe-commits
https://github.com/chestnykh deleted https://github.com/llvm/llvm-project/pull/120013 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [Libunwind] Try to fix msan failures (PR #120013)

2024-12-17 Thread Dmitry Chestnykh via cfe-commits
@@ -133,6 +133,10 @@ _LIBUNWIND_EXPORT _Unwind_Reason_Code _Unwind_Backtrace(_Unwind_Trace_Fn callback, void *ref) { unw_cursor_t cursor; unw_context_t uc; +#if __has_feature(memory_sanitizer) + __builtin_memset(&cursor, 0, sizeof(cursor)); chestnykh wrote

[libunwind] [Libunwind] Try to fix msan failures (PR #120013)

2024-12-17 Thread Dmitry Chestnykh via cfe-commits
https://github.com/chestnykh closed https://github.com/llvm/llvm-project/pull/120013 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Process warnings conditionally (PR #120591)

2024-12-19 Thread Dmitry Chestnykh via cfe-commits
https://github.com/chestnykh created https://github.com/llvm/llvm-project/pull/120591 There are a few functions that emit warnings related to positional arguments in format strings. These functions use `getLocationOfByte()` which has O(n) complexity and may lead to silent hang of compilation i

[clang] [Clang][Sema] Process warnings conditionally (PR #120591)

2024-12-19 Thread Dmitry Chestnykh via cfe-commits
https://github.com/chestnykh edited https://github.com/llvm/llvm-project/pull/120591 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Process warnings conditionally (PR #120591)

2024-12-19 Thread Dmitry Chestnykh via cfe-commits
https://github.com/chestnykh updated https://github.com/llvm/llvm-project/pull/120591 >From 5b61245bbdc9d1874684f29bba880f6b5a4cfe82 Mon Sep 17 00:00:00 2001 From: Dmitry Chestnykh Date: Thu, 19 Dec 2024 18:35:35 +0300 Subject: [PATCH 1/2] [Clang][Sema] Process warnings conditionally There are

[clang] [Clang][Sema] Process warnings conditionally (PR #120591)

2024-12-22 Thread Dmitry Chestnykh via cfe-commits
https://github.com/chestnykh updated https://github.com/llvm/llvm-project/pull/120591 >From 9a0d5d44f70477403a33d2feb3f5518b0d078a66 Mon Sep 17 00:00:00 2001 From: Dmitry Chestnykh Date: Thu, 19 Dec 2024 18:35:35 +0300 Subject: [PATCH 1/2] [Clang][Sema] Process warnings conditionally There are

[clang] [Clang][Sema] Process warnings conditionally (PR #120591)

2024-12-23 Thread Dmitry Chestnykh via cfe-commits
https://github.com/chestnykh updated https://github.com/llvm/llvm-project/pull/120591 >From 9a0d5d44f70477403a33d2feb3f5518b0d078a66 Mon Sep 17 00:00:00 2001 From: Dmitry Chestnykh Date: Thu, 19 Dec 2024 18:35:35 +0300 Subject: [PATCH 1/3] [Clang][Sema] Process warnings conditionally There are

[clang] [Clang][Sema] Process warnings conditionally (PR #120591)

2024-12-23 Thread Dmitry Chestnykh via cfe-commits
@@ -6591,27 +6591,36 @@ void CheckFormatHandler::HandleNonStandardConversionSpecifier( void CheckFormatHandler::HandlePosition(const char *startPos, unsigned posLen) { - EmitFormatDiagnostic(S.PDiag(diag::warn_format_non_standard_posit

[clang] [Clang][Sema] Process warnings conditionally (PR #120591)

2024-12-23 Thread Dmitry Chestnykh via cfe-commits
@@ -6591,27 +6591,36 @@ void CheckFormatHandler::HandleNonStandardConversionSpecifier( void CheckFormatHandler::HandlePosition(const char *startPos, unsigned posLen) { - EmitFormatDiagnostic(S.PDiag(diag::warn_format_non_standard_posit

[clang] [Clang][Sema] Process warnings conditionally (PR #120591)

2024-12-23 Thread Dmitry Chestnykh via cfe-commits
@@ -6591,27 +6591,36 @@ void CheckFormatHandler::HandleNonStandardConversionSpecifier( void CheckFormatHandler::HandlePosition(const char *startPos, unsigned posLen) { - EmitFormatDiagnostic(S.PDiag(diag::warn_format_non_standard_posit

[clang] [Clang][Sema] Process warnings conditionally (PR #120591)

2024-12-23 Thread Dmitry Chestnykh via cfe-commits
https://github.com/chestnykh closed https://github.com/llvm/llvm-project/pull/120591 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [sanitizer][CFI] Add support to build CFI with sanitize-coverage (PR #131296)

2025-04-05 Thread Dmitry Chestnykh via cfe-commits
chestnykh wrote: @Mephistophiles do you have commit access or you need someone to push on your behalf? https://github.com/llvm/llvm-project/pull/131296 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/list

[clang] [sanitizer][CFI] Add support to build CFI with sanitize-coverage (PR #131296)

2025-04-05 Thread Dmitry Chestnykh via cfe-commits
https://github.com/chestnykh closed https://github.com/llvm/llvm-project/pull/131296 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [sanitizer][CFI] Add support to build CFI with sanitize-coverage (PR #131296)

2025-04-02 Thread Dmitry Chestnykh via cfe-commits
https://github.com/chestnykh approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/131296 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits