Re: [clang] d9b9621 - Reland D73534: [DebugInfo] Enable the debug entry values feature by default

2020-03-23 Thread Djordje via cfe-commits
(+ CCing some debug info folks as well) Hi David, OK, I agree, my apologize. The patch enables the whole feature by default and removes the experimental option that has been used during the implementation. We tested the code (and the assertions regarding the feature itself) by using the experi

Re: [clang] d9b9621 - Reland D73534: [DebugInfo] Enable the debug entry values feature by default

2020-03-23 Thread Djordje via cfe-commits
Hi David, Thanks for the heads-up! On 23.3.20. 11:02, David Stenberg wrote: > Hi! > > On Mon, 2020-03-23 at 08:56 +0100, Djordje wrote: >> (+ CCing some debug info folks as well) >> >> Hi David, >> >> OK, I agree, my apologize. >> >> The patch enables the whole feature by default and removes the

Re: [clang] d9b9621 - Reland D73534: [DebugInfo] Enable the debug entry values feature by default

2020-03-24 Thread Djordje via cfe-commits
Hi David, On 23.3.20. 18:51, David Blaikie wrote: > On Mon, Mar 23, 2020 at 12:56 AM Djordje > wrote: > > (+ CCing some debug info folks as well) > > Hi David, > > OK, I agree, my apologize. > > The patch enables the whole feature by default an