DanielCChen wrote:
@mjklemm This PR caused some regressions of C-interop test cases in our local
test run. The test cases typically have a Fortran main (compiled with Flang)
that calls a C function (compiled with clang). The linking is by `flang-new`.
The error looks like:
```
ld.lld: error: d
DanielCChen wrote:
I see. So Fortran and C interoperability of F2003/F2008 is not supported yet in
Flang? Those ~100ish regression test cases we have were passing before this PR
though.
Unfortunately, those test cases are not made public available yet. I think I
can copy the source code of on
DanielCChen wrote:
Thanks for the initial analysis. I will take a closer look of the failure and
prepare a reproducer and post it here.
https://github.com/llvm/llvm-project/pull/73124
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lis
DanielCChen wrote:
The test cases actually have C main indeed and call to Fortran procedures as
opposed to what I thought (the other way around). Adding `-fno-fortran-main`
fixed all of them!
May be I missed it when reading through the comments of this PR, why there is a
definition of `main()`
DanielCChen wrote:
Ok. I see. The Fortran `main` is actually coming out of internal compiler
generated code rather than user code.
It seems users who have Fortran-C-interop code will need to toggle the
`-fno-fortran-main` option ON and OFF depends on who the `main` is.
I think there are some r
@@ -163,6 +163,40 @@ forward compiler options to the frontend driver,
`flang-new -fc1`.
You can read more on the design of `clangDriver` in Clang's [Driver Design &
Internals](https://clang.llvm.org/docs/DriverInternals.html).
+## Linker Driver
+When used as a linker, Flang's
DanielCChen wrote:
Thanks @banach-space for the pointer!
https://github.com/llvm/llvm-project/pull/73124
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DanielCChen edited
https://github.com/llvm/llvm-project/pull/75816
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
DanielCChen wrote:
The changes look good to me. I will wait a day to see if other reviewers have
any more comments before approving it.
https://github.com/llvm/llvm-project/pull/73254
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lis
@@ -163,6 +163,40 @@ forward compiler options to the frontend driver,
`flang-new -fc1`.
You can read more on the design of `clangDriver` in Clang's [Driver Design &
Internals](https://clang.llvm.org/docs/DriverInternals.html).
+## Linker Driver
+When used as a linker, Flang's
https://github.com/DanielCChen approved this pull request.
Thanks for working on this. We have quite some Fortran C-interop test cases are
affected by the "duplicate main" error.
https://github.com/llvm/llvm-project/pull/89938
___
cfe-commits mailing
DanielCChen wrote:
We have downstream code that used `getDeclaration` and not we have changed to
`getOrInsertDeclaration` for all places.
My understanding from reading the thread is that `getOrInsertDelcaration1 will
stay and a new `findDeclaration` will be added temporarily and it will
eventu
DanielCChen wrote:
> `test_demangle` should definitely **not** be updated when renaming functions.
Could you please explain a bit more since this is new to me? Thanks in advance!
https://github.com/llvm/llvm-project/pull/111752
___
cfe-commits mailing
DanielCChen wrote:
> > > `test_demangle` should definitely **not** be updated when renaming
> > > functions.
> >
> >
> > Could you please explain a bit more since this is new to me? Thanks in
> > advance!
>
> The use of LLVM symbols in this file is incidental -- it's just a data set of
> ma
DanielCChen wrote:
I see. I don't have strong preference although it would be nice to use some
function that exists.
https://github.com/llvm/llvm-project/pull/111752
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-
DanielCChen wrote:
@jurahul
It seems this PR is missing a test file
`libcxxabi/test/test_demangle.pass.cpp`.
It has a line of
```
{"_ZN4llvm9Intrinsic14getDeclarationEPNS_6ModuleENS0_2IDEPPKNS_4TypeEj",
"llvm::Intrinsic::getDeclaration(llvm::Module*, llvm::Intrinsic::ID, llvm::Type
const**,
https://github.com/DanielCChen edited
https://github.com/llvm/llvm-project/pull/113504
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -178,7 +192,12 @@ static constexpr TypePattern SameType{AnyType,
KindCode::same};
// universal extension feature.
static constexpr TypePattern OperandReal{RealType, KindCode::operand};
static constexpr TypePattern OperandInt{IntType, KindCode::operand};
+static constexpr Ty
@@ -135,8 +141,12 @@ static constexpr TypePattern SubscriptInt{IntType,
KindCode::subscript};
// Match any kind of some intrinsic or derived types
static constexpr TypePattern AnyInt{IntType, KindCode::any};
+static constexpr TypePattern AnyUnsigned{UnsignedType, KindCode::an
https://github.com/DanielCChen approved this pull request.
LGTM.
https://github.com/llvm/llvm-project/pull/113215
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
DanielCChen wrote:
Seems a place that needs to add UNSIGNED type case
```
llvm-project/flang/lib/Semantics/resolve-names.cpp:7597:16: error: enumeration
value 'Unsigned' not handled in switch [-Werror,-Wswitch]
switch (type.category()) {
~^~
llvm-project/flang/lib/Semanti
https://github.com/DanielCChen approved this pull request.
LGTM.
Thanks for reverting it.
https://github.com/llvm/llvm-project/pull/117444
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
https://github.com/DanielCChen closed
https://github.com/llvm/llvm-project/pull/117342
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DanielCChen created
https://github.com/llvm/llvm-project/pull/117342
AIX BuildBot failed due to https://github.com/llvm/llvm-project/pull/116556 as
AIX linker does not support version script.
This PR is to fix the failure
This PR is on behalf of gniko...@ca.ibm.com
>From c
https://github.com/DanielCChen updated
https://github.com/llvm/llvm-project/pull/131041
>From 660ec19fc5f59aa7c08331b5066388f3f5af14b9 Mon Sep 17 00:00:00 2001
From: Daniel Chen
Date: Wed, 12 Mar 2025 18:23:14 -0400
Subject: [PATCH 1/4] [flang-rt] Pass the whole path of libflang_rt.runtime.a
t
DanielCChen wrote:
@Meinersbur and all other reviewers,
In the attempt to make building the path of flant-rt more general as well as
customizable in response to the review comment, I made the following change in
this latest commit (sorry about a couple of more commits that fixed some typos).
https://github.com/DanielCChen updated
https://github.com/llvm/llvm-project/pull/131041
>From 660ec19fc5f59aa7c08331b5066388f3f5af14b9 Mon Sep 17 00:00:00 2001
From: Daniel Chen
Date: Wed, 12 Mar 2025 18:23:14 -0400
Subject: [PATCH 1/5] [flang-rt] Pass the whole path of libflang_rt.runtime.a
t
https://github.com/DanielCChen updated
https://github.com/llvm/llvm-project/pull/131041
>From 660ec19fc5f59aa7c08331b5066388f3f5af14b9 Mon Sep 17 00:00:00 2001
From: Daniel Chen
Date: Wed, 12 Mar 2025 18:23:14 -0400
Subject: [PATCH 1/6] [flang-rt] Pass the whole path of libflang_rt.runtime.a
t
https://github.com/DanielCChen updated
https://github.com/llvm/llvm-project/pull/131041
>From 660ec19fc5f59aa7c08331b5066388f3f5af14b9 Mon Sep 17 00:00:00 2001
From: Daniel Chen
Date: Wed, 12 Mar 2025 18:23:14 -0400
Subject: [PATCH 1/7] [flang-rt] Pass the whole path of libflang_rt.runtime.a
t
https://github.com/DanielCChen updated
https://github.com/llvm/llvm-project/pull/131041
>From 9d3e16f3e7c5adf4b5e0c1c6ba861d9e0ffea23b Mon Sep 17 00:00:00 2001
From: Daniel Chen
Date: Wed, 12 Mar 2025 18:23:14 -0400
Subject: [PATCH 1/7] [flang-rt] Pass the whole path of libflang_rt.runtime.a
t
DanielCChen wrote:
The intention is to make this PR for flang-rt only. As discussed with
@daltenty, I remove the NFC-change of adding an overriding `getCompilerRT` in
`AIX.cpp` as it actually breaches into clang space.
https://github.com/llvm/llvm-project/pull/131041
__
https://github.com/DanielCChen edited
https://github.com/llvm/llvm-project/pull/131041
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -223,6 +223,13 @@ endif()
# This can be used to detect whether we're in the runtimes build.
set(LLVM_RUNTIMES_BUILD ON)
+if (LLVM_ENABLE_PER_TARGET_RUNTIME_DIR AND UNIX AND ${CMAKE_SYSTEM_NAME}
MATCHES "AIX")
+ # Set LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=OFF as AIX doesn't s
DanielCChen wrote:
I will revert this commit first.
https://github.com/llvm/llvm-project/pull/131200
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -223,6 +223,13 @@ endif()
# This can be used to detect whether we're in the runtimes build.
set(LLVM_RUNTIMES_BUILD ON)
+if (LLVM_ENABLE_PER_TARGET_RUNTIME_DIR AND UNIX AND ${CMAKE_SYSTEM_NAME}
MATCHES "AIX")
+ # Set LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=OFF as AIX doesn't s
https://github.com/DanielCChen updated
https://github.com/llvm/llvm-project/pull/132821
>From be03d5cf608498b11dd274ee6294a0c4e83d4c5e Mon Sep 17 00:00:00 2001
From: Daniel Chen
Date: Mon, 24 Mar 2025 15:45:33 -0400
Subject: [PATCH] [Driver] Enable LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=ON on AIX.
https://github.com/DanielCChen updated
https://github.com/llvm/llvm-project/pull/131041
>From c394e25b3af722d76338bf7ab02d87de2a23074b Mon Sep 17 00:00:00 2001
From: Daniel Chen
Date: Wed, 12 Mar 2025 18:23:14 -0400
Subject: [PATCH 01/11] [flang-rt] Pass the whole path of libflang_rt.runtime.a
https://github.com/DanielCChen edited
https://github.com/llvm/llvm-project/pull/131041
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DanielCChen created
https://github.com/llvm/llvm-project/pull/131822
This is to support statical linking to shared `flang-rt` on AIX.
Users should be able to do `flang -static t.f`. The `a.out` generated should
not have dependencies on the shared libraries.
>From 491e6d0cdf
https://github.com/DanielCChen updated
https://github.com/llvm/llvm-project/pull/131200
>From 95377273d069e76023edf7ecc2df473e4e2f4aaa Mon Sep 17 00:00:00 2001
From: Daniel Chen
Date: Thu, 13 Mar 2025 15:52:23 -0400
Subject: [PATCH 01/10] [compiler-rt] Disable
LLVM_ENABLE_PER_TARGET_RUNTIME_DI
https://github.com/DanielCChen updated
https://github.com/llvm/llvm-project/pull/131041
>From 9d3e16f3e7c5adf4b5e0c1c6ba861d9e0ffea23b Mon Sep 17 00:00:00 2001
From: Daniel Chen
Date: Wed, 12 Mar 2025 18:23:14 -0400
Subject: [PATCH 1/8] [flang-rt] Pass the whole path of libflang_rt.runtime.a
t
DanielCChen wrote:
I am working on a patch that re-uses `compilerRT` code as much as possible.
https://github.com/llvm/llvm-project/pull/131041
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
@@ -1187,16 +1187,19 @@ endif()
# Build with _XOPEN_SOURCE on AIX, as stray macros in _ALL_SOURCE mode tend to
# break things. In this case we need to enable the large-file API as well.
if (UNIX AND ${CMAKE_SYSTEM_NAME} MATCHES "AIX")
- add_compile_definitions(_XOPEN_S
@@ -101,3 +102,19 @@ bool PPCLinuxToolChain::SupportIEEEFloat128(
return GlibcSupportsFloat128((Twine(D.DyldPrefix) + Linker).str()) &&
!(D.CCCIsCXX() && HasUnsupportedCXXLib);
}
+
+void PPCLinuxToolChain::addFortranRuntimeLibs(
+const ArgList &Args, llvm::opt::A
https://github.com/DanielCChen updated
https://github.com/llvm/llvm-project/pull/131041
>From 9d3e16f3e7c5adf4b5e0c1c6ba861d9e0ffea23b Mon Sep 17 00:00:00 2001
From: Daniel Chen
Date: Wed, 12 Mar 2025 18:23:14 -0400
Subject: [PATCH 01/11] [flang-rt] Pass the whole path of libflang_rt.runtime.a
https://github.com/DanielCChen updated
https://github.com/llvm/llvm-project/pull/131041
>From 9d3e16f3e7c5adf4b5e0c1c6ba861d9e0ffea23b Mon Sep 17 00:00:00 2001
From: Daniel Chen
Date: Wed, 12 Mar 2025 18:23:14 -0400
Subject: [PATCH 1/9] [flang-rt] Pass the whole path of libflang_rt.runtime.a
t
https://github.com/DanielCChen edited
https://github.com/llvm/llvm-project/pull/131200
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DanielCChen edited
https://github.com/llvm/llvm-project/pull/131041
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DanielCChen updated
https://github.com/llvm/llvm-project/pull/131041
>From 9d3e16f3e7c5adf4b5e0c1c6ba861d9e0ffea23b Mon Sep 17 00:00:00 2001
From: Daniel Chen
Date: Wed, 12 Mar 2025 18:23:14 -0400
Subject: [PATCH 01/10] [flang-rt] Pass the whole path of libflang_rt.runtime.a
DanielCChen wrote:
Sorry that I missed a couple of things. I will bring this back after I hash
them out.
https://github.com/llvm/llvm-project/pull/134297
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/li
@@ -223,6 +223,13 @@ endif()
# This can be used to detect whether we're in the runtimes build.
set(LLVM_RUNTIMES_BUILD ON)
+if (LLVM_ENABLE_PER_TARGET_RUNTIME_DIR AND UNIX AND ${CMAKE_SYSTEM_NAME}
MATCHES "AIX")
+ # Set LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=OFF as AIX doesn't s
DanielCChen wrote:
> May I ask not to merge this yet? I have a question above, but I will not be
> at work until next Thursday to discuss this in a timely manner.
@vzakhari Sure, I will wait until you come back.
https://github.com/llvm/llvm-project/pull/134362
___
https://github.com/DanielCChen created
https://github.com/llvm/llvm-project/pull/134520
`addArchSpecificRPath` shoudl immediately return for AIX as AIX doesn't support
`rpath` option.
`getArchSpecificLibPaths` also needs to get the triple without the OS version
on AIX.
>From a3583c59f7797a40a
https://github.com/DanielCChen edited
https://github.com/llvm/llvm-project/pull/134520
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -109,7 +109,7 @@ if(LLVM_ENABLE_PER_TARGET_RUNTIME_DIR AND NOT APPLE)
extend_path(default_install_path "${COMPILER_RT_INSTALL_PATH}" lib)
set(COMPILER_RT_INSTALL_LIBRARY_DIR "${default_install_path}" CACHE PATH
"Path where built compiler-rt libraries should be instal
DanielCChen wrote:
> I think this should also impact the set of headers being searched. On
> per-target runtimes, I think we look for libc++ headers under
> `include/c++/v1/` in addition to `include/c++/v1` (since that's where
> `__config_site` ends up)? I'm not super familiar with that config
DanielCChen wrote:
@Meinersbur @MaskRay and all other reviewers,
PR #132821 enables `LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=ON` on AIX. As a result,
I no longer need to "force" AIX to use `os_dirname` for flang-rt.
The change in this PR is intact because I re-used the same code to handle the
op
https://github.com/DanielCChen edited
https://github.com/llvm/llvm-project/pull/131041
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
DanielCChen wrote:
@ldionne I have checked that on AIX, clang uses the configuration from the
system include as `-internal-isystem /opt/IBM/openxlCSDK/include/c++/v1`. There
is already a test in `aix-toolchain-include.cpp` for that.
https://github.com/llvm/llvm-project/pull/132821
https://github.com/DanielCChen updated
https://github.com/llvm/llvm-project/pull/134362
>From cd100a70479adbb4619d685e345485eea99987c5 Mon Sep 17 00:00:00 2001
From: Daniel Chen
Date: Fri, 4 Apr 2025 06:10:56 -0400
Subject: [PATCH 1/4] [driver] Generalize adding the path of
libflang_rt.runtime
https://github.com/DanielCChen edited
https://github.com/llvm/llvm-project/pull/134362
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DanielCChen updated
https://github.com/llvm/llvm-project/pull/134362
>From 7db1cca2ad76b249d1fa2b76e6c488aa41cb3582 Mon Sep 17 00:00:00 2001
From: Daniel Chen
Date: Fri, 4 Apr 2025 06:10:56 -0400
Subject: [PATCH 1/7] [driver] Generalize adding the path of
libflang_rt.runtime
@@ -2,22 +2,33 @@
! invocation. These libraries are added on top of other standard runtime
! libraries that the Clang driver will include.
-! RUN: %flang -### --target=ppc64le-linux-gnu %S/Inputs/hello.f90 2>&1 |
FileCheck %s --check-prefixes=CHECK,UNIX,UNIX-F128NONE
-! RUN:
https://github.com/DanielCChen updated
https://github.com/llvm/llvm-project/pull/134362
>From cd100a70479adbb4619d685e345485eea99987c5 Mon Sep 17 00:00:00 2001
From: Daniel Chen
Date: Fri, 4 Apr 2025 06:10:56 -0400
Subject: [PATCH 1/7] [driver] Generalize adding the path of
libflang_rt.runtime
@@ -850,6 +852,21 @@ void ToolChain::addFortranRuntimeLibraryPath(const
llvm::opt::ArgList &Args,
CmdArgs.push_back(Args.MakeArgString("-L" + DefaultLibPath));
}
+void ToolChain::addFlangRTLibPath(const ArgList &Args,
+ llvm::opt::ArgStrin
@@ -7,35 +7,106 @@
!! LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=ON, use
!! resource_dir_with_per_target_subdir as inputs.
-! Check powerpc64-ibm-aix 64-bit linking to static flang-rt
+! Check powerpc64-ibm-aix 64-bit linking to static flang-rt by default
! RUN: %flang %s -### 2>&1
@@ -7,35 +7,106 @@
!! LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=ON, use
!! resource_dir_with_per_target_subdir as inputs.
-! Check powerpc64-ibm-aix 64-bit linking to static flang-rt
+! Check powerpc64-ibm-aix 64-bit linking to static flang-rt by default
! RUN: %flang %s -### 2>&1
https://github.com/DanielCChen updated
https://github.com/llvm/llvm-project/pull/134362
>From cd100a70479adbb4619d685e345485eea99987c5 Mon Sep 17 00:00:00 2001
From: Daniel Chen
Date: Fri, 4 Apr 2025 06:10:56 -0400
Subject: [PATCH 1/6] [driver] Generalize adding the path of
libflang_rt.runtime
https://github.com/DanielCChen edited
https://github.com/llvm/llvm-project/pull/134362
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DanielCChen edited
https://github.com/llvm/llvm-project/pull/134362
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
DanielCChen wrote:
Hello reviewers,
I have rebased the PR to pull the change of enabling `PER_TARGET_RUNTIME_DIR`
on AIX in.
I also added a couple of LIT tests to test the flang-rt path on both AIX and
LoP.
Thanks for your time reviewing the PR!
https://github.com/llvm/llvm-project/pull/13104
@@ -127,9 +127,19 @@ void aix::Linker::ConstructJob(Compilation &C, const
JobAction &JA,
}
// Force static linking when "-static" is present.
- if (Args.hasArg(options::OPT_static))
+ if (Args.hasArg(options::OPT_static)) {
CmdArgs.push_back("-bnso");
+if (D.
DanielCChen wrote:
Note that the reason `aio.exp` is not needed is because flang-rt currently
doesn't do asynchronous I/O. Once it is enabled using POSIX `aio_*` system
calls, it will need to export those calls.
https://github.com/llvm/llvm-project/pull/131822
DanielCChen wrote:
> Wouldn't it be more maintainable to just force the value to OFF for AIX where
> the `option()` is defined?
Unfortunately, the cmake command line option `-D
LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=ON` overrides the `option()` in the cmake
file.
https://github.com/llvm/llvm-pro
https://github.com/DanielCChen updated
https://github.com/llvm/llvm-project/pull/131041
>From 660ec19fc5f59aa7c08331b5066388f3f5af14b9 Mon Sep 17 00:00:00 2001
From: Daniel Chen
Date: Wed, 12 Mar 2025 18:23:14 -0400
Subject: [PATCH 1/2] [flang-rt] Pass the whole path of libflang_rt.runtime.a
t
https://github.com/DanielCChen updated
https://github.com/llvm/llvm-project/pull/131041
>From 660ec19fc5f59aa7c08331b5066388f3f5af14b9 Mon Sep 17 00:00:00 2001
From: Daniel Chen
Date: Wed, 12 Mar 2025 18:23:14 -0400
Subject: [PATCH 1/3] [flang-rt] Pass the whole path of libflang_rt.runtime.a
t
DanielCChen wrote:
> > > Wouldn't it be more maintainable to just force the value to OFF for AIX
> > > where the `option()` is defined?
> >
> >
> > Unfortunately, the cmake command line option
> > `-DLLVM_ENABLE_PER_TARGET_RUNTIME_DIR=ON` overrides the `option()` in the
> > cmake file.
>
>
https://github.com/DanielCChen updated
https://github.com/llvm/llvm-project/pull/131200
>From 1283ba24387e01aafcfc99e5db3f16c91deb5ac0 Mon Sep 17 00:00:00 2001
From: Daniel Chen
Date: Thu, 13 Mar 2025 15:52:23 -0400
Subject: [PATCH 1/6] [compiler-rt] Disable
LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=
https://github.com/DanielCChen updated
https://github.com/llvm/llvm-project/pull/131200
>From 1283ba24387e01aafcfc99e5db3f16c91deb5ac0 Mon Sep 17 00:00:00 2001
From: Daniel Chen
Date: Thu, 13 Mar 2025 15:52:23 -0400
Subject: [PATCH 1/5] [compiler-rt] Disable
LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=
https://github.com/DanielCChen updated
https://github.com/llvm/llvm-project/pull/131200
>From 1283ba24387e01aafcfc99e5db3f16c91deb5ac0 Mon Sep 17 00:00:00 2001
From: Daniel Chen
Date: Thu, 13 Mar 2025 15:52:23 -0400
Subject: [PATCH 1/2] [compiler-rt] Disable
LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=
https://github.com/DanielCChen updated
https://github.com/llvm/llvm-project/pull/131200
>From 1283ba24387e01aafcfc99e5db3f16c91deb5ac0 Mon Sep 17 00:00:00 2001
From: Daniel Chen
Date: Thu, 13 Mar 2025 15:52:23 -0400
Subject: [PATCH] [compiler-rt] Disable LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=ON
o
https://github.com/DanielCChen updated
https://github.com/llvm/llvm-project/pull/131200
>From 1283ba24387e01aafcfc99e5db3f16c91deb5ac0 Mon Sep 17 00:00:00 2001
From: Daniel Chen
Date: Thu, 13 Mar 2025 15:52:23 -0400
Subject: [PATCH 1/3] [compiler-rt] Disable
LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=
https://github.com/DanielCChen updated
https://github.com/llvm/llvm-project/pull/131200
>From 1283ba24387e01aafcfc99e5db3f16c91deb5ac0 Mon Sep 17 00:00:00 2001
From: Daniel Chen
Date: Thu, 13 Mar 2025 15:52:23 -0400
Subject: [PATCH 1/4] [compiler-rt] Disable
LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=
DanielCChen wrote:
@arichardson I found the way to override the cache file. Thanks for the
suggestion!
https://github.com/llvm/llvm-project/pull/131200
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/list
DanielCChen wrote:
> Approach look OK to me.
>
> Could you add test(s) along the lines of
> [aix-rlib.c](https://github.com/llvm/llvm-project/blob/main/clang/test/Driver/aix-rtlib.c).
> If we make further changes, knowing what is expected on AIX/PPCLunux would
> be very helpful.
>
> A review
https://github.com/DanielCChen updated
https://github.com/llvm/llvm-project/pull/131200
>From 1283ba24387e01aafcfc99e5db3f16c91deb5ac0 Mon Sep 17 00:00:00 2001
From: Daniel Chen
Date: Thu, 13 Mar 2025 15:52:23 -0400
Subject: [PATCH 1/7] [compiler-rt] Disable
LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=
https://github.com/DanielCChen updated
https://github.com/llvm/llvm-project/pull/131200
>From 1283ba24387e01aafcfc99e5db3f16c91deb5ac0 Mon Sep 17 00:00:00 2001
From: Daniel Chen
Date: Thu, 13 Mar 2025 15:52:23 -0400
Subject: [PATCH 1/9] [compiler-rt] Disable
LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=
https://github.com/DanielCChen updated
https://github.com/llvm/llvm-project/pull/131200
>From 1283ba24387e01aafcfc99e5db3f16c91deb5ac0 Mon Sep 17 00:00:00 2001
From: Daniel Chen
Date: Thu, 13 Mar 2025 15:52:23 -0400
Subject: [PATCH 1/8] [compiler-rt] Disable
LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=
DanielCChen wrote:
> I would generally prefer if we could avoid having driver behavior depend on
> the existance of files, but the linker would also pick an existing file as
> well.
Agreed. The `if (static exists) - else if (shared exists)` logic in this PR is
temporary until we have the comp
https://github.com/DanielCChen updated
https://github.com/llvm/llvm-project/pull/134362
>From cd100a70479adbb4619d685e345485eea99987c5 Mon Sep 17 00:00:00 2001
From: Daniel Chen
Date: Fri, 4 Apr 2025 06:10:56 -0400
Subject: [PATCH 1/5] [driver] Generalize adding the path of
libflang_rt.runtime
@@ -6880,6 +6880,13 @@ let Flags = [TargetSpecific] in {
defm android_pad_segment : BooleanFFlag<"android-pad-segment">, Group;
} // let Flags = [TargetSpecific]
+def shared_libflangrt : Flag<["-"], "shared-libflangrt">,
+ HelpText<"Dynamically link the shared flang-rt">, Gro
@@ -6880,6 +6880,13 @@ let Flags = [TargetSpecific] in {
defm android_pad_segment : BooleanFFlag<"android-pad-segment">, Group;
} // let Flags = [TargetSpecific]
+def shared_libflangrt : Flag<["-"], "shared-libflangrt">,
+ HelpText<"Dynamically link the shared flang-rt">, Gro
https://github.com/DanielCChen updated
https://github.com/llvm/llvm-project/pull/134362
>From cd100a70479adbb4619d685e345485eea99987c5 Mon Sep 17 00:00:00 2001
From: Daniel Chen
Date: Fri, 4 Apr 2025 06:10:56 -0400
Subject: [PATCH 1/2] [driver] Generalize adding the path of
libflang_rt.runtime
DanielCChen wrote:
> Can you please explain why you want to link the static library by default?
> For example, Clang has these options
> https://clang.llvm.org/docs/ClangCommandLineReference.html#cmdoption-clang-static-libgcc
> that allow users to force the static linking, and, I think, by def
@@ -7,35 +7,100 @@
!! LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=ON, use
!! resource_dir_with_per_target_subdir as inputs.
-! Check powerpc64-ibm-aix 64-bit linking to static flang-rt
-! RUN: %flang %s -### 2>&1 \
+! Check powerpc64-ibm-aix 64-bit linking to static flang-rt by defaul
@@ -7,35 +7,100 @@
!! LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=ON, use
!! resource_dir_with_per_target_subdir as inputs.
-! Check powerpc64-ibm-aix 64-bit linking to static flang-rt
-! RUN: %flang %s -### 2>&1 \
+! Check powerpc64-ibm-aix 64-bit linking to static flang-rt by defaul
https://github.com/DanielCChen updated
https://github.com/llvm/llvm-project/pull/134362
>From 7db1cca2ad76b249d1fa2b76e6c488aa41cb3582 Mon Sep 17 00:00:00 2001
From: Daniel Chen
Date: Fri, 4 Apr 2025 06:10:56 -0400
Subject: [PATCH 1/8] [driver] Generalize adding the path of
libflang_rt.runtime
@@ -7,35 +7,100 @@
!! LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=ON, use
!! resource_dir_with_per_target_subdir as inputs.
-! Check powerpc64-ibm-aix 64-bit linking to static flang-rt
-! RUN: %flang %s -### 2>&1 \
+! Check powerpc64-ibm-aix 64-bit linking to static flang-rt by defaul
https://github.com/DanielCChen updated
https://github.com/llvm/llvm-project/pull/134362
>From 7db1cca2ad76b249d1fa2b76e6c488aa41cb3582 Mon Sep 17 00:00:00 2001
From: Daniel Chen
Date: Fri, 4 Apr 2025 06:10:56 -0400
Subject: [PATCH 1/9] [driver] Generalize adding the path of
libflang_rt.runtime
@@ -744,9 +744,12 @@ std::string ToolChain::buildCompilerRTBasename(const
llvm::opt::ArgList &Args,
Suffix = IsITANMSVCWindows ? ".lib" : ".a";
break;
case ToolChain::FT_Shared:
-Suffix = TT.isOSWindows()
- ? (TT.isWindowsGNUEnvironment() ? ".dll.
1 - 100 of 181 matches
Mail list logo
