augfab marked 5 inline comments as done.
augfab added a comment.
All comments were addressed, marking them as Done.
I don't have commit access, here's my name and email: Augustin Fabre
.
Thanks!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143560/new/
https://reviews.llvm.org/D14356
augfab created this revision.
augfab added reviewers: sammccall, phst, djasper.
augfab added a project: clang-format.
Herald added a project: All.
augfab requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Emacs trunk complained about:
Warni
augfab added inline comments.
Comment at: clang/tools/clang-format/clang-format.el:70
(cl-case (xml-node-name node)
-('replacement
+((replacement quote)
(let* ((offset (xml-get-attribute-or-nil node 'offset))
phst
augfab updated this revision to Diff 495815.
augfab edited the summary of this revision.
augfab added a comment.
Applied suggestions.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143560/new/
https://reviews.llvm.org/D143560
Files:
clang/tools/clang-format/clang-format.el
Index: cl
augfab added a comment.
Hi @phst , is anything left for me to do before this patch is merged?
This is my first patch to LLVM so I'm not too familiar with the process.
Thanks for your help 🙂
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143560/new/
https://reviews.llvm.org/D143560
_
