[PATCH] D146924: [clang] Add support for dollar sign in ud_suffix of numeric constants

annara created this revision. Herald added a project: All. annara requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D146924 Files: clang/lib/Lex/Lexer.cpp clang/test/CXX/lex

[PATCH] D146924: [clang] Add support for dollar sign in ud_suffix of numeric constants

annara added a comment. After a second look at the standard, you are right. It's not in the range of any of the universal-character-names. That being said, it is allowed as an identifier by default in clang (as @tahonermann) mentioned. It also works in current versions of clang if you use the UCN

[PATCH] D146924: [clang] Add support for dollar sign in ud_suffix of numeric constants

annara added a comment. Thanks for all the input! I'll work on @cor3ntin points and take a look at the crash Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146924/new/ https://reviews.llvm.org/D146924 __