LLVM build fix for VS2017 RC (19.00.24215.1)

Hi, I just downloaded VS2017 RC on a clean Win10 machine, checked out LLVM & clang and tried to build clang. The following code in \tools\clang\utils\TableGen\ClangDiagnosticsEmitter.cpp failed to compile: RecordSet DiagsInPedanticSet; RecordSet GroupsInPedanticSet; InferPedantic inf

RE: [cfe-dev] Testcase for LLVM PR9350

Hi, This is a (tested!) patch to add checks that both pre-increment and pre-decrement don’t overflow, for both char and short integer types (since they’re both narrower than int), as per the problem fixed in PR9350. Thanks, Andrew R From: Friedman, Eli [mailto:efrie...@codeaurora.org]

[clang] [llvm] [llvm] properly guard dump methods in Support lib classes (PR #139938)

https://github.com/andrurogerz created https://github.com/llvm/llvm-project/pull/139938 ## Purpose Add proper preprocessor guards for all `dump()` methods in the LLVM support library. This change ensures these methods are not part of the public ABI for release builds. ## Overview * Annotates

[clang] [llvm] [llvm] properly guard dump methods in Support lib classes (PR #139938)

https://github.com/andrurogerz ready_for_review https://github.com/llvm/llvm-project/pull/139938 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [llvm] properly guard dump methods in Support lib classes (PR #139938)

andrurogerz wrote: > This approach causes issues when LLVM is built in release mode (with > -DNDEBUG) and external projects build against it in debug mode (with > -UNDEBUG). I appreciate that it does what the comment says should be done, > but I think what the comment says is wrong. Specifical

[clang] [llvm] [llvm] properly guard dump methods in Support lib classes (PR #139938)

andrurogerz wrote: Ok, this link error makes sense when building an external project in debug mode against an llvm release build. I didn't realize that was a thing, but it makes sense so my mistake. The issue is that we must only guard `dump` methods (that have definitions outside of the head

[clang] [llvm] [llvm] properly guard dump methods in Support lib classes (PR #139938)

andrurogerz wrote: @hvdijk thank you for the clear repro steps; I was able to reproduce the issue locally and verify that #140574 fixes it. It is a partial revert of only the `ScaledNumber` source changes; the rest of the changes in this PR do not appear to have the same issue. https://githu

[clang] [llvm] [llvm] minor fixes for clang-cl Windows DLL build (PR #144386)

https://github.com/andrurogerz created https://github.com/llvm/llvm-project/pull/144386 ## Purpose This patch makes a minor changes to LLVM and Clang so that LLVM can be built as a Windows DLL with `clang-cl`. These changes were not required for building a Windows DLL with MSVC. ## Backgroun

[clang] [llvm] [llvm] minor fixes for clang-cl Windows DLL build (PR #144386)

https://github.com/andrurogerz ready_for_review https://github.com/llvm/llvm-project/pull/144386 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [llvm] minor fixes for clang-cl Windows DLL build (PR #144386)

andrurogerz wrote: > I think that the clang semantics are technically correct Yes, agreed. And in case it wasn't clear, this is `clang` behavior and is not specific to `clang-cl`. https://github.com/llvm/llvm-project/pull/144386 ___ cfe-commits mail

[clang] [flang] [llvm] [llvm] annotate remaining LLVM interfaces for DLL export (PR #144746)

https://github.com/andrurogerz edited https://github.com/llvm/llvm-project/pull/144746 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [llvm] [llvm] annotate remaining LLVM interfaces for DLL export (PR #144746)

andrurogerz wrote: @compnerd, @vgvassilev other than the annotations for llvm-c and Demangle libraries, which require new annotation macros, this is the bulk of the remaining annotation code-mod. Please review at your convenience, thanks! https://github.com/llvm/llvm-project/pull/144746 __

[clang] [flang] [llvm] [llvm] annotate remaining LLVM interfaces for DLL export (PR #144746)

https://github.com/andrurogerz ready_for_review https://github.com/llvm/llvm-project/pull/144746 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [llvm] [llvm] annotate remaining LLVM interfaces for DLL export (PR #144746)

https://github.com/andrurogerz created https://github.com/llvm/llvm-project/pull/144746 ## Purpose This patch is one in a series of code-mods that annotate LLVM’s public interface for export. This patch annotates the remaining LLVM interface that was missed in, or modified since, previous pat

[clang] [flang] [llvm] [llvm] fix extern cl::opt definitions for DLL export (PR #145374)

https://github.com/andrurogerz created https://github.com/llvm/llvm-project/pull/145374 ## Purpose This patch is one in a series of code-mods that annotate LLVM’s public interface for export. This patch ensures a few `cl::opt` declarations are properly annotated with `LLVM_ABI`. The annotation

[clang] [flang] [llvm] [llvm] fix extern cl::opt definitions for DLL export (PR #145374)

https://github.com/andrurogerz updated https://github.com/llvm/llvm-project/pull/145374 >From 8f95bca7eecfefca8849b8dc630aefd6c43967e6 Mon Sep 17 00:00:00 2001 From: Andrew Rogers Date: Mon, 23 Jun 2025 10:47:54 -0700 Subject: [PATCH] [llvm] fix extern cl::opt definitions for DLL export --- c

[clang] [flang] [llvm] [llvm] fix extern cl::opt definitions for DLL export (PR #145374)

andrurogerz wrote: @compnerd, @vgvassilev another hopefully quick one, thanks! https://github.com/llvm/llvm-project/pull/145374 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Triple: Forward declare Twine and remove include (PR #145685)

@@ -349,7 +350,12 @@ class Triple { /// triple fields unknown. Triple() = default; + LLVM_ABI explicit Triple(std::string &&Str); + LLVM_ABI explicit Triple(StringRef Str) : Triple(Str.str()) {} LLVM_ABI explicit Triple(const Twine &Str); + LLVM_ABI explicit Triple(c