[PATCH] D69651: [CMake] Add cross Windows to ARM Linux toolchain CMake cache file.

2019-11-01 Thread Andrei Lebedev via Phabricator via cfe-commits
andreil99 accepted this revision. andreil99 added a comment. This revision is now accepted and ready to land. Thanks, Vlad! Looks good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69651/new/ https://reviews.llvm.org/D69651

[PATCH] D70499: [clang] Fix the path to CrossWinToARMLinux.cmake CMake cache

2019-11-20 Thread Andrei Lebedev via Phabricator via cfe-commits
andreil99 accepted this revision. andreil99 added a comment. This revision is now accepted and ready to land. Thanks for catching and fixing this, Sergej! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70499/new/ https://reviews.llvm.org/D70499 _

[PATCH] D71625: [CMake] Added remote test execution support into CrossWinToARMLinux CMake cache file.

2019-12-20 Thread Andrei Lebedev via Phabricator via cfe-commits
andreil99 accepted this revision. andreil99 added a comment. This revision is now accepted and ready to land. Thanks, Vlad! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71625/new/ https://reviews.llvm.org/D71625

[PATCH] D94169: [clang][driver] Restore the original help text for `-I`

2021-01-07 Thread Andrei Lebedev via Phabricator via cfe-commits
andreil99 requested changes to this revision. andreil99 added a comment. This revision now requires changes to proceed. I'm fine with having this text in the ClangCommandLineReference.rst only, and removing it from `clang -help`. However, reverting the patch would not do, as ClangCommandLineRefe

[PATCH] D94169: [clang][driver] Restore the original help text for `-I`

2021-01-07 Thread Andrei Lebedev via Phabricator via cfe-commits
andreil99 added a comment. Post commit review is a normal practice in the LLVM community. This is not an excuse to revert somebody's patch per se, unless there are other serious reasons for the revert. The text does not describe “clang internals”, it describes the semantic of that flag with re

[PATCH] D94169: [clang][driver] Restore the original help text for `-I`

2021-01-12 Thread Andrei Lebedev via Phabricator via cfe-commits
andreil99 accepted this revision. andreil99 added a comment. This revision is now accepted and ready to land. Thanks for suggesting `DocBrief`, Richard! Looks good to me with a nit. Comment at: clang/include/clang/Driver/Options.td:652 Flags<[CC1Option,CC1AsOption]>, Meta