It was approved by Reid.
This patch had two parts, he did not stamp the change in Clang, but he did
stamp the change for LLVM.
https://reviews.llvm.org/D27762
I assumed that this means a green light to commit.
Did I misinterpret the rules?
Thanks,
Amjad
From: David Blaikie [mailto:dblai...@gmai
Thanks Ranjeet,
Indeed I was planning to update the patches to top of trunk and reload them, so
if you can save me this trouble I would appreciate that.
Once we upload the updated patches I would like to ping the community and ask
for feedback.
Thanks,
Amjad
> -Original Message-
> From:
Sorry for that, I broke a LIT test that I added few days ago.
The LIT test need to be fixed and I already fixed it in r268063.
Let's wait till r268063 run bots and see that everything will pass.
Thanks,
Amjad
From: peter_coo...@apple.com [mailto:peter_coo...@apple.com]
Sent: Friday, April 29, 201
I could not reproduce the issue.
This error appeared before and it always meant that LLVM and Clang were not
aligned.
You need both revisions to work correctly: (LLVM) 268054, (Clang) 268055
Please, let me know if you can reproduce the issue locally using these versions.
Regards,
Amjad
> -O
I believe it is safe to disable the assertion.
I added this assertion...I am trying to figure out why we are hitting it.
I am not convinced that we should do a total revert.
Regards,
Amjad
From: Alexey Samsonov [mailto:vonos...@gmail.com]
Sent: Thursday, March 24, 2016 22:27
To: Aboud, Amjad
Cc
Hi Alexey,
It will help to have a reproducer that fail without assertions.
If I remove the assertion, the test failed in clang self-build will pass.
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap/builds/11281
Thanks,
Amjad
From: Alexey Samsonov [mailto:vonos...@gmail.com]
Sen
Hi Samuel,
I noticed that the two tests you added in the below commit have a minor issue.
"target_codegen_registration_naming.cpp" is failing on my local machine (Win32).
"target_codegen_registration.cpp" is not failing, but it contain "CHECK..."
lines with wrong syntax that make FileCheck ignore
