[clang] [Clang] Consider preferred_type in bitfield warnings (#116760) (PR #116785)

Endilll wrote: Looking at diagnostics in the test you add, I wonder why don't we issue them, and especially the fixit, when we parse bit-field declaration. Why waiting until assignment happens? https://github.com/llvm/llvm-project/pull/116785 ___ cfe

[clang] [Clang] Consider preferred_type in bitfield warnings (#116760) (PR #116785)

ojhunt wrote: > Looking at diagnostics in the test you add, I wonder why don't we issue them, > and especially the fixit, when we parse bit-field declaration. Why waiting > until assignment happens? Yeah, it's super frustrating to me that we do that - I did _consider_ making them early but I

[clang] [clang] Add test for CWG794 "Base-derived conversion in member type of pointer-to-member conversion" (PR #121660)

https://github.com/Endilll created https://github.com/llvm/llvm-project/pull/121660 This patch adds a test for [CWG794](https://cplusplus.github.io/CWG/issues/794.html), which is an NB comment closed as NAD. Author was asked to bring a paper to Evolution, which never happened. So we test for

[clang] [clang] Add test for CWG794 "Base-derived conversion in member type of pointer-to-member conversion" (PR #121660)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Vlad Serebrennikov (Endilll) Changes This patch adds a test for [CWG794](https://cplusplus.github.io/CWG/issues/794.html), which is an NB comment closed as NAD. Author was asked to bring a paper to Evolution, which never happened. So we

[clang] [Clang] Consider preferred_type in bitfield warnings (#116760) (PR #116785)

Endilll wrote: > and I thought making just preferred_type warnings early would be especially > insane :D I don't necessarily agree. `preferred_type` is a relatively new thing, so we can try doing something new here. > [edit: I just realized even that might need to be an option because I can

[clang] [clang-format] Add `TT_CompoundRequirementLBrace` for better annotation (PR #121539)

owenca wrote: > This is a good fix but I think it might not be addressing the whole issue. > This isn't a problem with just _compound-requirement_, it's the case for > _simple-requirement_s too. This patch fixes compound requirements as mentioned in the commit message and reported in the GitH

[clang] [Clang][Headers] Workaround for UCRT's `` in `` (PR #121650)

https://github.com/frederick-vs-ja created https://github.com/llvm/llvm-project/pull/121650 This patch uses `__builtin_bit_cast` as workaround to make MS UCRT's non-conforming functions `` usable for ``. Fixes #45552. >From 0366072ca42ec9773897daabf7946eb37c631623 Mon Sep 17 00:00:00 2001 Fro

[clang] [Clang][Headers] Workaround for UCRT's `` in `` (PR #121650)

llvmbot wrote: @llvm/pr-subscribers-backend-x86 @llvm/pr-subscribers-clang Author: A. Jiang (frederick-vs-ja) Changes This patch uses `__builtin_bit_cast` as workaround to make MS UCRT's non-conforming functions `` usable for ``. Fixes #45552. --- Patch is 21.02 Ki

[clang] [Clang] Consider preferred_type in bitfield warnings (#116760) (PR #116785)

ojhunt wrote: > > and I thought making just preferred_type warnings early would be especially > > insane :D > > I don't necessarily agree. `preferred_type` is a relatively new thing, so we > can try doing something new here. > Yeah, but the implementation is essentially identical, so I would

[clang] [clang-format][NFC] Add missing config tests for List of Strings (PR #121451)

owenca wrote: > these tests are so inconsistent but I guess it's not that critical See the added commit message. https://github.com/llvm/llvm-project/pull/121451 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[clang] [clang-format][NFC] Add missing config tests for List of Strings (PR #121451)

https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/121451 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Consider preferred_type in bitfield warnings (#116760) (PR #116785)

ojhunt wrote: > (while too lazy to godbolt right now) Given I basically wrote the entire example, I thought I would just do the godbolting, and lo ```cpp enum class Enum { A, B, C, D }; struct S { Enum e: 1; // I'm a rockstar developer and "know" that I'll only ever assign A or B here };

[clang] [llvm] [llvm][NFC] Rework Timer.cpp globals to ensure valid lifetimes (PR #121663)

https://github.com/macurtis-amd created https://github.com/llvm/llvm-project/pull/121663 This is intended to help with flang `-ftime-report` support: - #107270. With this change, I was able to cherry-pick #107270, uncomment `llvm::TimePassesIsEnabled = true;` and compile with `-ftime-report`.

[clang] [llvm] [llvm][NFC] Rework Timer.cpp globals to ensure valid lifetimes (PR #121663)

llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: None (macurtis-amd) Changes This is intended to help with flang `-ftime-report` support: - #107270. With this change, I was able to cherry-pick #107270, uncomment `llvm::TimePassesIsEnabled = true;` and compile with `-ftime-report`

[clang] [clang-tools-extra] [libcxx] [llvm] [libc++] implement views::concat (PR #120920)

https://github.com/changkhothuychung updated https://github.com/llvm/llvm-project/pull/120920 error: too big or took too long to generate ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[clang] [Clang][Headers] Workaround for UCRT's `` in `` (PR #121650)

@@ -28,6 +28,30 @@ #define _TG_ATTRSp __attribute__((__overloadable__)) #define _TG_ATTRS __attribute__((__overloadable__, __always_inline__)) +// https://github.com/llvm/llvm-project/issues/45552 +// workaround for MS UCRT's +#if defined(_VCRUNTIME_H) && defined(_C_COMPLEX_T

[clang] [Clang] Consider preferred_type in bitfield warnings (#116760) (PR #116785)

https://github.com/ojhunt updated https://github.com/llvm/llvm-project/pull/116785 >From 5f260726253e78a00d2dff02c22837ce02b49075 Mon Sep 17 00:00:00 2001 From: Oliver Hunt Date: Tue, 19 Nov 2024 11:55:11 +0100 Subject: [PATCH 1/5] [Clang] Consider preferred_type in bitfield warnings (#116760)

[clang] [Clang] Consider preferred_type in bitfield warnings (#116760) (PR #116785)

https://github.com/ojhunt updated https://github.com/llvm/llvm-project/pull/116785 >From 5f260726253e78a00d2dff02c22837ce02b49075 Mon Sep 17 00:00:00 2001 From: Oliver Hunt Date: Tue, 19 Nov 2024 11:55:11 +0100 Subject: [PATCH 1/6] [Clang] Consider preferred_type in bitfield warnings (#116760)

[clang] [clang] Add test for CWG170 "Pointer-to-member conversions" (PR #121667)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Vlad Serebrennikov (Endilll) Changes This patch adds test for [CWG170](https://cplusplus.github.io/CWG/issues/170.html). The resolution adds explicit undefined behavior, so I think the best we can do is to put the test into constexpr eva

[clang] [clang] Add test for CWG170 "Pointer-to-member conversions" (PR #121667)

https://github.com/Endilll created https://github.com/llvm/llvm-project/pull/121667 This patch adds test for [CWG170](https://cplusplus.github.io/CWG/issues/170.html). The resolution adds explicit undefined behavior, so I think the best we can do is to put the test into constexpr evaluator. C

[clang] [clang] Add test for CWG190 "Layout-compatible POD-struct types" (PR #121668)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Vlad Serebrennikov (Endilll) Changes This patch adds test for [CWG190](https://cplusplus.github.io/CWG/issues/190.html), leveraging `__is_layout_compatible` intrinsic added for C++20 `std::is_layout_compatible`. I conservatively set the

[clang] [clang] Add test for CWG190 "Layout-compatible POD-struct types" (PR #121668)

https://github.com/Endilll created https://github.com/llvm/llvm-project/pull/121668 This patch adds test for [CWG190](https://cplusplus.github.io/CWG/issues/190.html), leveraging `__is_layout_compatible` intrinsic added for C++20 `std::is_layout_compatible`. I conservatively set the status to

[clang] [clang-format][NFC] Add missing config tests for List of Strings (PR #121451)

https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/121451 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 66f16e6 - [clang-format][NFC] Add missing config tests for List of Strings (#121451)

Author: Owen Pan Date: 2025-01-04T16:14:25-08:00 New Revision: 66f16e682f84551552099a45e608fa260b14e3ab URL: https://github.com/llvm/llvm-project/commit/66f16e682f84551552099a45e608fa260b14e3ab DIFF: https://github.com/llvm/llvm-project/commit/66f16e682f84551552099a45e608fa260b14e3ab.diff LOG:

[clang] [clang-format][NFC] Replace SmallVectorImpl with ArrayRef (PR #121621)

https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/121621 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Restrict use of scalar types in vector builtins (PR #119423)

@@ -68,15 +66,18 @@ void test_builtin_elementwise_add_sat(float f1, float f2, double d1, double d2, long long int i2, si8 vi1, si8 vi2, unsigned u1, unsigned u2, u4 vu1, u4 vu2,

[clang] [Clang][Headers] Workaround for UCRT's `` in `` (PR #121650)

https://github.com/frederick-vs-ja edited https://github.com/llvm/llvm-project/pull/121650 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][ASTMatcher] Add a matcher for the name of a DependentScopeDeclRefExpr (PR #121656)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Amr Hesham (AmrDeveloper) Changes Add the `hasDependentName` matcher to match the name of `DependentScopeDeclRefExpr` Example: `dependentScopeDeclRefExpr(hasDependentName("name"))` Fixes: #121610 --- Full diff: https://github.com/llvm/l

[clang] [Clang][ASTMatcher] Add a matcher for the name of a DependentScopeDeclRefExpr (PR #121656)

https://github.com/AmrDeveloper created https://github.com/llvm/llvm-project/pull/121656 Add the `hasDependentName` matcher to match the name of `DependentScopeDeclRefExpr` Example: `dependentScopeDeclRefExpr(hasDependentName("name"))` Fixes: #121610 >From 4cd48886384570e0e5bb0b712f4fd45f8de

[clang] 7a76110 - [HLSL][SPIR-V] implement SV_GroupID semantic lowering (#121521)

Author: Zhengxing li Date: 2025-01-04T14:02:39-08:00 New Revision: 7a761100960c0c9e2b2fa8a9ee233b137270bd73 URL: https://github.com/llvm/llvm-project/commit/7a761100960c0c9e2b2fa8a9ee233b137270bd73 DIFF: https://github.com/llvm/llvm-project/commit/7a761100960c0c9e2b2fa8a9ee233b137270bd73.diff

[clang] [llvm] [HLSL][SPIR-V] implement SV_GroupID semantic lowering (PR #121521)

https://github.com/lizhengxing closed https://github.com/llvm/llvm-project/pull/121521 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Add an off-by-default warning to complain about MSVC bitfield padding (PR #117428)

https://github.com/ojhunt updated https://github.com/llvm/llvm-project/pull/117428 >From 3e25d7ef2e223942298078dace8979905956d05c Mon Sep 17 00:00:00 2001 From: Oliver Hunt Date: Fri, 22 Nov 2024 17:53:24 +0100 Subject: [PATCH 1/7] Add an off-by-default warning to complain about MSVC bitfield

[clang] [Clang] Add GCC's __builtin_stack_address() to Clang. (PR #121332)

https://github.com/aalhwc edited https://github.com/llvm/llvm-project/pull/121332 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Add bugprone-undefined-sprintf-overlap (PR #114244)

https://github.com/ccotter updated https://github.com/llvm/llvm-project/pull/114244 >From fd914cc82688b122654d2d7ada72007541b197c0 Mon Sep 17 00:00:00 2001 From: Chris Cotter Date: Wed, 30 Oct 2024 10:54:49 -0400 Subject: [PATCH 1/6] Add bugprone-sprintf-overlap --- .../bugprone/BugproneTidyM

[clang-tools-extra] Add bugprone-undefined-sprintf-overlap (PR #114244)

https://github.com/ccotter updated https://github.com/llvm/llvm-project/pull/114244 >From fd914cc82688b122654d2d7ada72007541b197c0 Mon Sep 17 00:00:00 2001 From: Chris Cotter Date: Wed, 30 Oct 2024 10:54:49 -0400 Subject: [PATCH 1/8] Add bugprone-sprintf-overlap --- .../bugprone/BugproneTidyM

[clang] [libcxx] [Clang] Implement CWG2369 "Ordering between constraints and substitution" (PR #102857)

zyn0217 wrote: Thanks so much for the review! I'll keep an eye on that PR, and there’s some post-work to do: 1. Cleanup 2. Adaptation for lambdas https://github.com/llvm/llvm-project/pull/102857 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] 96eced6 - [Clang] Implement CWG2369 "Ordering between constraints and substitution" (#102857)

Author: Younan Zhang Date: 2025-01-05T10:50:52+08:00 New Revision: 96eced624e0f120155256033fdcb8342e7e58d6e URL: https://github.com/llvm/llvm-project/commit/96eced624e0f120155256033fdcb8342e7e58d6e DIFF: https://github.com/llvm/llvm-project/commit/96eced624e0f120155256033fdcb8342e7e58d6e.diff

[clang-tools-extra] Add bugprone-undefined-sprintf-overlap (PR #114244)

ccotter wrote: > 1. How common is this bug? In one of our internal codebases, a sample of about 1500 files found just over 2% of the files had this bug. As we migrated platforms/standard libraries, the behavior which was previously correct (by chance) changed to be incorrect. > 2. What happen

[clang] [libcxx] [Clang] Implement CWG2369 "Ordering between constraints and substitution" (PR #102857)

https://github.com/zyn0217 closed https://github.com/llvm/llvm-project/pull/102857 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Add bugprone-undefined-sprintf-overlap (PR #114244)

@@ -0,0 +1,23 @@ +.. title:: clang-tidy - bugprone-undefined-sprintf-overlap + +bugprone-undefined-sprintf-overlap ccotter wrote: I like this better. I'll change this. https://github.com/llvm/llvm-project/pull/114244 _

[clang-tools-extra] Add bugprone-undefined-sprintf-overlap (PR #114244)

ccotter wrote: Thanks both @nicovank @5chmidti for the overlapping reviews. I got sidetracked, but am coming back to hopefully finish this up. Re: supporting more use cases, I found nearly all bugs in our codebase were of the simple form `sprintf(a, "", ..., a, ...)` with a simple DeclRefExpr.

[clang] 04610b9 - [clang-format][NFC] Replace SmallVectorImpl with ArrayRef (#121621)

Author: Owen Pan Date: 2025-01-04T16:19:46-08:00 New Revision: 04610b901f41c4abec169b9a38f1b0a2fde976c1 URL: https://github.com/llvm/llvm-project/commit/04610b901f41c4abec169b9a38f1b0a2fde976c1 DIFF: https://github.com/llvm/llvm-project/commit/04610b901f41c4abec169b9a38f1b0a2fde976c1.diff LOG:

[clang] 44b83e8 - [clang-format] Add TT_AfterPPDirective for better annotation (#121622)

Author: Owen Pan Date: 2025-01-04T16:22:54-08:00 New Revision: 44b83e81b5a48d543bf718907f00a21179ec03a4 URL: https://github.com/llvm/llvm-project/commit/44b83e81b5a48d543bf718907f00a21179ec03a4 DIFF: https://github.com/llvm/llvm-project/commit/44b83e81b5a48d543bf718907f00a21179ec03a4.diff LOG:

[clang] [clang] Add test for CWG190 "Layout-compatible POD-struct types" (PR #121668)

https://github.com/cor3ntin approved this pull request. saying clang 19 is very weird as this probably always worked, but lgtm otherwise https://github.com/llvm/llvm-project/pull/121668 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[clang] c1ea05e - [clang-format] Don't break short macro call followed by l_paren (#121626)

Author: Owen Pan Date: 2025-01-04T16:24:41-08:00 New Revision: c1ea05eaf0fbe4b539952689dbf9f0df716c72e7 URL: https://github.com/llvm/llvm-project/commit/c1ea05eaf0fbe4b539952689dbf9f0df716c72e7 DIFF: https://github.com/llvm/llvm-project/commit/c1ea05eaf0fbe4b539952689dbf9f0df716c72e7.diff LOG:

[clang] [clang-format] Don't break short macro call followed by l_paren (PR #121626)

https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/121626 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Add TT_AfterPPDirective for better annotation (PR #121622)

https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/121622 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [emacs][clang-format] Add elisp API for clang-format on git diffs (PR #112792)

goldsteinn wrote: ping @ideasman42 or @lukel97 https://github.com/llvm/llvm-project/pull/112792 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Add `TT_CompoundRequirementLBrace` for better annotation (PR #121539)

https://github.com/rymiel approved this pull request. #121675 https://github.com/llvm/llvm-project/pull/121539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Bulk port 64-bit x86 builtins to TableGen (PR #121043)

https://github.com/chandlerc edited https://github.com/llvm/llvm-project/pull/121043 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] a774adb - Bulk port 64-bit x86 builtins to TableGen (#121043)

Author: Chandler Carruth Date: 2025-01-04T17:52:19-08:00 New Revision: a774adb017256ceae85ec92ce5148ed47e517540 URL: https://github.com/llvm/llvm-project/commit/a774adb017256ceae85ec92ce5148ed47e517540 DIFF: https://github.com/llvm/llvm-project/commit/a774adb017256ceae85ec92ce5148ed47e517540.di

[clang] Bulk port 64-bit x86 builtins to TableGen (PR #121043)

https://github.com/chandlerc closed https://github.com/llvm/llvm-project/pull/121043 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][ASTMatcher] Add a matcher for the name of a DependentScopeDeclRefExpr (PR #121656)

@@ -3449,6 +3449,19 @@ Narrowing Matchers +MatcherDependentScopeDeclRefExpr>hasDependentNamestd::string N +Matches the dependent name of a dependent scope decl ref expr. HighCom

[clang] [Clang][ASTMatcher] Add a matcher for the name of a DependentScopeDeclRefExpr (PR #121656)

@@ -1116,6 +1116,8 @@ AST Matchers - Add ``dependentTemplateSpecializationType`` matcher to match a dependent template specialization type. +- Add ``hasDependentName`` matcher to match the dependent name of a dependent scope decl ref expr. HighCommander4 wr

[clang] [Clang][ASTMatcher] Add a matcher for the name of a DependentScopeDeclRefExpr (PR #121656)

@@ -2235,6 +2235,21 @@ TEST_P(ASTMatchersTest, ArgumentCountIs_CXXConstructExpr) { Constructor1Arg)); } +TEST_P(ASTMatchersTest, hasDependentName_DependentScopeDeclRefExpr) { HighCommander4 wrote: nit: looking at other tests in this file, th

[clang] [Clang][ASTMatcher] Add a matcher for the name of a DependentScopeDeclRefExpr (PR #121656)

@@ -3257,6 +3257,17 @@ AST_MATCHER_P(CXXDependentScopeMemberExpr, memberHasSameNameAsBoundNode, }); } +/// Matches the dependent name of a dependent scope decl ref expr HighCommander4 wrote: likewise here, "of a DependentScopeDeclRefExpr" https://gith

[clang] [Clang][ASTMatcher] Add a matcher for the name of a DependentScopeDeclRefExpr (PR #121656)

@@ -2235,6 +2235,21 @@ TEST_P(ASTMatchersTest, ArgumentCountIs_CXXConstructExpr) { Constructor1Arg)); } +TEST_P(ASTMatchersTest, hasDependentName_DependentScopeDeclRefExpr) { + if (!GetParam().isCXX() || GetParam().hasDelayedTemplateParsing()) { +// FIXM

[clang] [Clang][ASTMatcher] Add a matcher for the name of a DependentScopeDeclRefExpr (PR #121656)

https://github.com/HighCommander4 requested changes to this pull request. Thanks for implementing this! The patch looks pretty good, I just have some minor comments and a suggestion for a new test case. https://github.com/llvm/llvm-project/pull/121656 __

[clang] [Clang][ASTMatcher] Add a matcher for the name of a DependentScopeDeclRefExpr (PR #121656)

https://github.com/HighCommander4 edited https://github.com/llvm/llvm-project/pull/121656 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Add GCC's __builtin_stack_address() to Clang. (PR #121332)

https://github.com/aalhwc updated https://github.com/llvm/llvm-project/pull/121332 >From f247c1ab9fa89ca09476ed0a398a4c4385e75193 Mon Sep 17 00:00:00 2001 From: aalhwc Date: Mon, 30 Dec 2024 05:03:59 -0500 Subject: [PATCH 1/2] [Clang] Add GCC's __builtin_stack_address() to Clang (#82632). Thi

[clang] Mechanically port bulk of x86 builtins to TableGen (PR #120831)

https://github.com/chandlerc closed https://github.com/llvm/llvm-project/pull/120831 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Mechanically port bulk of x86 builtins to TableGen (PR #120831)

chandlerc wrote: Thanks, merging! I've put the script here for posterity: https://gist.github.com/chandlerc/de807ea073beac351f87c660e1d4b7a0 https://github.com/llvm/llvm-project/pull/120831 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[clang] Mechanically port bulk of x86 builtins to TableGen (PR #120831)

https://github.com/chandlerc edited https://github.com/llvm/llvm-project/pull/120831 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Bulk port 64-bit x86 builtins to TableGen (PR #121043)

https://github.com/chandlerc updated https://github.com/llvm/llvm-project/pull/121043 >From 3314a7d9b2ab582769ce4b4438d24d31c280d9f8 Mon Sep 17 00:00:00 2001 From: Chandler Carruth Date: Tue, 24 Dec 2024 08:41:49 + Subject: [PATCH] Bulk port 64-bit x86 builtins to TableGen This PR follows

[clang] Mechanically port bulk of x86 builtins to TableGen (PR #120831)

@@ -108,9 +109,15 @@ class PrototypeParser { } else if (T.consume_back("&")) { ParseType(T); Type += "&"; +} else if (T.consume_front("long long")) { chandlerc wrote: Sure, I use the Fish shell and have a bunch of command line tools that he

[clang] Bulk port 64-bit x86 builtins to TableGen (PR #121043)

chandlerc wrote: Updated to rebase on top-of-tree with #120831 merged. Re-ran all the scripts to verify things. Using a variation on the command from my [comment](https://github.com/llvm/llvm-project/pull/120831#discussion_r1903059479) on the other PR: ```fish diff -u (rg '^TARGET' BuiltinsX

[clang] [clang] Canonicalize absolute paths in dependency file (PR #117458)

xtexChooser wrote: Ahhh wait, if the original path is also printed, Make may see them as broken. I don't know what to do now, oops. https://github.com/llvm/llvm-project/pull/117458 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[clang] da2a9ed - [clang] Update C++ DR status page (#121642)

Author: Vlad Serebrennikov Date: 2025-01-04T18:53:01+04:00 New Revision: da2a9ede81a88bea0bba28a543441197772e4727 URL: https://github.com/llvm/llvm-project/commit/da2a9ede81a88bea0bba28a543441197772e4727 DIFF: https://github.com/llvm/llvm-project/commit/da2a9ede81a88bea0bba28a543441197772e4727.

[clang] [clang] Update C++ DR status page (PR #121642)

https://github.com/Endilll closed https://github.com/llvm/llvm-project/pull/121642 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 0093450 - [clang-format] Add `TT_CompoundRequirementLBrace` for better annotation (#121539)

Author: Owen Pan Date: 2025-01-04T20:51:00-08:00 New Revision: 00934505d44e28f3c1d5739d6369648e87f10cf5 URL: https://github.com/llvm/llvm-project/commit/00934505d44e28f3c1d5739d6369648e87f10cf5 DIFF: https://github.com/llvm/llvm-project/commit/00934505d44e28f3c1d5739d6369648e87f10cf5.diff LOG:

[clang] [libcxx] [Clang] Implement CWG2369 "Ordering between constraints and substitution" (PR #102857)

llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `sanitizer-x86_64-linux-fast` running on `sanitizer-buildbot4` while building `clang` at step 2 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/169/builds/7054 Here is the relevant piece o

[clang] [clang-format] Add `TT_CompoundRequirementLBrace` for better annotation (PR #121539)

https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/121539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [emacs][clang-format] Add elisp API for clang-format on git diffs (PR #112792)

ideasman42 wrote: Checking again and am still considering this patch too spesific/incomplete, checking vc's diff calls to git - they are considerably more involved than in this PR, meaning this PR will likely require follow up commits to fix problems _(see `vc-diff-internal`, inlined below for

[clang] [libclang] Add API to query more information about base classes. (PR #120300)

trelau wrote: For what it's worth, to get around my issue in https://github.com/llvm/llvm-project/issues/121502 I followed your same pattern here and added a ```get_methods()``` function to Python (and a new libclang function ```clang_visitCXXMethods```) to access the class methods. Looking a

[clang] 267ab1c - [clang] Add test for CWG190 "Layout-compatible POD-struct types" (#121668)

Author: Vlad Serebrennikov Date: 2025-01-05T10:29:31+04:00 New Revision: 267ab1cf574bd51d67f3f88c1c4f28a44fca2c8a URL: https://github.com/llvm/llvm-project/commit/267ab1cf574bd51d67f3f88c1c4f28a44fca2c8a DIFF: https://github.com/llvm/llvm-project/commit/267ab1cf574bd51d67f3f88c1c4f28a44fca2c8a.

[clang] [clang] Add test for CWG190 "Layout-compatible POD-struct types" (PR #121668)

https://github.com/Endilll closed https://github.com/llvm/llvm-project/pull/121668 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Mechanically port bulk of x86 builtins to TableGen (PR #120831)

@@ -108,9 +109,15 @@ class PrototypeParser { } else if (T.consume_back("&")) { ParseType(T); Type += "&"; +} else if (T.consume_front("long long")) { chandlerc wrote: Ok, PR updated with an explicit opt-in for OpenCL `long` type support. S

[clang] Bulk port 64-bit x86 builtins to TableGen (PR #121043)

https://github.com/phoebewang approved this pull request. LGTM, thanks! https://github.com/llvm/llvm-project/pull/121043 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Mechanically port bulk of x86 builtins to TableGen (PR #120831)

@@ -108,9 +109,15 @@ class PrototypeParser { } else if (T.consume_back("&")) { ParseType(T); Type += "&"; +} else if (T.consume_front("long long")) { phoebewang wrote: Thanks for the information! https://github.com/llvm/llvm-project/pull/1

[clang] [clang] Update C++ DR status page (PR #121642)

https://github.com/Endilll created https://github.com/llvm/llvm-project/pull/121642 This patch brings our C++ DR status page up to date with WG21 updates. [CWG1223](https://cplusplus.github.io/CWG/issues/1223.html) "Syntactic disambiguation and _trailing-return-types_" is resolved by [P2915R0

[clang] [clang] Update C++ DR status page (PR #121642)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Vlad Serebrennikov (Endilll) Changes This patch brings our C++ DR status page up to date with WG21 updates. [CWG1223](https://cplusplus.github.io/CWG/issues/1223.html) "Syntactic disambiguation and _trailing-return-types_" is resolved by

[clang] [clang] Update C++ DR status page (PR #121642)

https://github.com/Endilll edited https://github.com/llvm/llvm-project/pull/121642 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Revert "[clang] Canonicalize absolute paths in dependency file" (PR #121638)

https://github.com/xtexChooser updated https://github.com/llvm/llvm-project/pull/121638 >From 2f8c1bc688475ac74ec2af8f954918102d2f612a Mon Sep 17 00:00:00 2001 From: xtex Date: Sat, 4 Jan 2025 19:19:47 +0800 Subject: [PATCH] Revert "[clang] Canonicalize absolute paths in dependency file (#1174

[clang] Revert "[clang] Canonicalize absolute paths in dependency file" (PR #121638)

xtexChooser wrote: ( a fix for clang-format was applied manually despite git-revert https://github.com/llvm/llvm-project/pull/121638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AMDGPU][True16][MC] true16 for v_alignbyte_b32 (PR #119750)

@@ -2353,8 +2353,8 @@ def int_amdgcn_writelane : [IntrNoMem, IntrConvergent, IntrWillReturn, IntrNoCallback, IntrNoFree] >; -def int_amdgcn_alignbyte : ClangBuiltin<"__builtin_amdgcn_alignbyte">, - DefaultAttrsIntrinsic<[llvm_i32_ty], [llvm_i32_ty, llvm_i32_ty, llvm_i32_ty]

[clang] [libcxx] [Clang] Implement CWG2369 "Ordering between constraints and substitution" (PR #102857)

https://github.com/cor3ntin approved this pull request. So, I'll will approve that we need to land the issue resolution in Clang 20, but we need to make sure we cleanup `getTemplateInstantiationArgs` soon :) Thanks for working through this non-trivial PR! https://github.com/llvm/llvm-project/p

[clang] [clang] Update C++ DR status page (PR #121642)

https://github.com/cor3ntin approved this pull request. https://github.com/llvm/llvm-project/pull/121642 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [compiler-rt] [clang-tidy] add `ctime` and `localtime` to `clang-tidy` (PR #110366)

https://github.com/zimirza updated https://github.com/llvm/llvm-project/pull/110366 From 24d7d3997bacf06a9add1ab3193d8d0adf2032ee Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=D0=97=D0=B8=D1=88=D0=B0=D0=BD=20=D0=9C=D0=B8=D1=80=D0=B7?= =?UTF-8?q?=D0=B0?= Date: Thu, 26 Dec 2024 08:29:03 +0500 Subjec

[clang] [clang-tools-extra] [compiler-rt] [clang-tidy] add `ctime` and `localtime` to `clang-tidy` (PR #110366)

https://github.com/zimirza updated https://github.com/llvm/llvm-project/pull/110366 From 193e93c52e6a523366470aa45088b434eb5628ef Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=D0=97=D0=B8=D1=88=D0=B0=D0=BD=20=D0=9C=D0=B8=D1=80=D0=B7?= =?UTF-8?q?=D0=B0?= Date: Thu, 26 Dec 2024 08:29:03 +0500 Subjec

[clang] Mechanically port bulk of x86 builtins to TableGen (PR #120831)

llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-debian-cpp20` running on `clang-debian-cpp20` while building `clang` at step 6 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/108/builds/7722 Here is the r

[clang] Mechanically port bulk of x86 builtins to TableGen (PR #120831)

chandlerc wrote: > LLVM Buildbot has detected a new failure on builder `clang-debian-cpp20` > running on `clang-debian-cpp20` while building `clang` at step 6 > "test-build-unified-tree-check-all". > > Full details are available at: > https://lab.llvm.org/buildbot/#/builders/108/builds/7722 >

[clang] Revert "[clang] Canonicalize absolute paths in dependency file" (PR #121638)

https://github.com/xtexChooser created https://github.com/llvm/llvm-project/pull/121638 Reverts llvm/llvm-project#117458 https://github.com/llvm/llvm-project/pull/117458#issuecomment-2568804774 >From fba92539ccef36eeac3eb3258af172911835e710 Mon Sep 17 00:00:00 2001 From: xtex Date: Sat, 4 Jan

[clang] Revert "[clang] Canonicalize absolute paths in dependency file" (PR #121638)

llvmbot wrote: @llvm/pr-subscribers-clang Author: xtex (xtexChooser) Changes Reverts llvm/llvm-project#117458 https://github.com/llvm/llvm-project/pull/117458#issuecomment-2568804774 --- Full diff: https://github.com/llvm/llvm-project/pull/121638.diff 5 Files Affected: - (modified) cl

[clang] Revert "[clang] Canonicalize absolute paths in dependency file" (PR #121638)

xtexChooser wrote: @kadircet https://github.com/llvm/llvm-project/pull/121638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Revert "[clang] Canonicalize absolute paths in dependency file" (PR #121638)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 95db1116c5718004e0bd7c3b79d39987fdbbff32 fba92539ccef36eeac3eb3258af172911835e710 --e

[clang] Revert "[clang] Canonicalize absolute paths in dependency file" (PR #121638)

https://github.com/xtexChooser edited https://github.com/llvm/llvm-project/pull/121638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [compiler-rt] [clang-tidy] add `ctime` and `localtime` to `clang-tidy` (PR #110366)

https://github.com/zimirza updated https://github.com/llvm/llvm-project/pull/110366 From 193e93c52e6a523366470aa45088b434eb5628ef Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=D0=97=D0=B8=D1=88=D0=B0=D0=BD=20=D0=9C=D0=B8=D1=80=D0=B7?= =?UTF-8?q?=D0=B0?= Date: Thu, 26 Dec 2024 08:29:03 +0500 Subjec

[clang] [clang-tools-extra] [compiler-rt] [clang-tidy] add `ctime` and `localtime` to `clang-tidy` (PR #110366)

=?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw==?=, =?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw==?=, =?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw==?=, =?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw==?=, =?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw==?=, =?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw==?=, =?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw==?=, =?utf

[clang] [clang-tools-extra] [compiler-rt] [clang-tidy] add `ctime` and `localtime` to `clang-tidy` (PR #110366)

=?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw==?=, =?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw==?=, =?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw==?=, =?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw==?=, =?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw==?=, =?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw==?=, =?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw==?=, =?utf

[clang] [clang-tools-extra] [compiler-rt] [clang-tidy] add `ctime` and `localtime` to `clang-tidy` (PR #110366)

=?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=, =?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=, =?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=, =?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=, =?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=, =?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=, =?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=, =?utf-8?b?0J

  1   2   >