[clang] [clang-cl][flang][dxc] Fix opts exposed to clang-cl/dxc by mistake (PR #118640)

2024-12-09 Thread Haohai Wen via cfe-commits
https://github.com/HaohaiWen approved this pull request. LGTM for -Xlinker. https://github.com/llvm/llvm-project/pull/118640 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lld] [lldb] [llvm] Rework the `Option` library to reduce dynamic relocations (PR #119198)

2024-12-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-llvm-binary-utilities @llvm/pr-subscribers-lld @llvm/pr-subscribers-clang Author: Chandler Carruth (chandlerc) Changes Apologies for the large change, I looked for ways to break this up and all of the ones I saw added real complexity. This change focuse

[clang] [lld] [lldb] [llvm] Rework the `Option` library to reduce dynamic relocations (PR #119198)

2024-12-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Chandler Carruth (chandlerc) Changes Apologies for the large change, I looked for ways to break this up and all of the ones I saw added real complexity. This change focuses on the option's prefixed names and the array of prefixes.

[clang] [clang-cl][flang][dxc] Fix opts exposed to clang-cl/dxc by mistake (PR #118640)

2024-12-09 Thread Haohai Wen via cfe-commits
HaohaiWen wrote: @MaskRay, may need to merge https://github.com/llvm/llvm-project/blob/main/clang/test/Driver/fprofile-sample-use.c to clang/test/Driver/unknown-arg-drivermodes.test https://github.com/llvm/llvm-project/pull/118640 ___ cfe-commits mai

[clang] [clang] Fix a dangling reference in clang/utils/TableGen/ClangDiagnosticsEmitter.cpp (PR #119197)

2024-12-09 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff f9d6d46a8edfac7421a4b010eb216f793669bef1 85f1d54459125568bfbe2088827040c3b05a7804 --e

[clang] 99f6ca9 - [AArch64] Implement intrinsics for SME FP8 FMOPA (#118115)

2024-12-09 Thread via cfe-commits
Author: SpencerAbson Date: 2024-12-09T11:13:08Z New Revision: 99f6ca9b7bb7d794db9ac8ff519b4e60766f6a4b URL: https://github.com/llvm/llvm-project/commit/99f6ca9b7bb7d794db9ac8ff519b4e60766f6a4b DIFF: https://github.com/llvm/llvm-project/commit/99f6ca9b7bb7d794db9ac8ff519b4e60766f6a4b.diff LOG:

[clang] [llvm] [AArch64] Implement intrinsics for SME FP8 FMOPA (PR #118115)

2024-12-09 Thread via cfe-commits
https://github.com/SpencerAbson closed https://github.com/llvm/llvm-project/pull/118115 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Switch builtin strings to use string tables (PR #118734)

2024-12-09 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-arm64-windows-msvc` running on `linaro-armv8-windows-msvc-04` while building `clang` at step 5 "ninja check 1". Full details are available at: https://lab.llvm.org/buildbot/#/builders/161/builds/3580 Here is the relev

[clang] [llvm] Add processor aliases back to -print-supported-cpus and -mcpu=help (PR #118581)

2024-12-09 Thread Jonathan Thackray via cfe-commits
https://github.com/jthackray approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/118581 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][bytecode] Handle __builtin_wcslen (PR #119187)

2024-12-09 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/119187 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 00b50c9 - [clang][bytecode] Handle __builtin_wcslen (#119187)

2024-12-09 Thread via cfe-commits
Author: Timm Baeder Date: 2024-12-09T12:34:25+01:00 New Revision: 00b50c917bf5e5abaded4f314b767b086069d1ee URL: https://github.com/llvm/llvm-project/commit/00b50c917bf5e5abaded4f314b767b086069d1ee DIFF: https://github.com/llvm/llvm-project/commit/00b50c917bf5e5abaded4f314b767b086069d1ee.diff L

[clang] [Clang] allow [[msvc::constexpr]] usage outside the std namespace (PR #119153)

2024-12-09 Thread Richard Dzenis via cfe-commits
RIscRIpt wrote: > allow [[msvc::constexpr]] usage outside the std namespace By the way, to be precisely correct, these changes actually allow usage of "placement new" in `[[msvc::constexpr]]` context outside of the std namespace. https://github.com/llvm/llvm-project/pull/119153 _

[clang] [lld] [lldb] [llvm] Rework the `Option` library to reduce dynamic relocations (PR #119198)

2024-12-09 Thread David Spickett via cfe-commits
DavidSpickett wrote: > The relevant binaries build, but check-lldb currently hits unrelated errors > for me blocking any progress in checking those changes. `ninja check-lldb` passes on AArch64 Linux, and given the changes, it's unlikely to fail on other platforms. https://github.com/llvm/llv

[clang] [clang][CodeGen] `sret` args should always point to the `alloca` AS, so use that (PR #114062)

2024-12-09 Thread Alex Voicu via cfe-commits
@@ -105,6 +105,11 @@ void AMDGPUABIInfo::computeInfo(CGFunctionInfo &FI) const { if (!getCXXABI().classifyReturnType(FI)) FI.getReturnInfo() = classifyReturnType(FI.getReturnType()); + // srets / indirect returns are unconditionally in the alloca AS. + if (FI.getReturn

[clang] [lld] [lldb] [llvm] Rework the `Option` library to reduce dynamic relocations (PR #119198)

2024-12-09 Thread David Spickett via cfe-commits
DavidSpickett wrote: If you look for: ``` FAILED: tools/clang/tools/extra/clangd/CMakeFiles/obj.clangDaemon.dir/CompileCommands.cpp.o ``` In the build log that's the failure reason. All of the tests that reported JSON passed, that's why you have green test reports but failed builds. I wi

[clang] [Clang] allow [[msvc::constexpr]] usage outside the std namespace (PR #119153)

2024-12-09 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/119153 >From f19ea82bbe5c00af6a6e261f989c9a89ef4c78ca Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Mon, 9 Dec 2024 01:46:46 +0200 Subject: [PATCH 1/2] [Clang] allow [[msvc::constexpr]] usage outside the std nam

[clang] [analyzer] Handle [[assume(cond)]] as __builtin_assume(cond) (PR #116462)

2024-12-09 Thread Vinay Deshmukh via cfe-commits
https://github.com/vinay-deshmukh updated https://github.com/llvm/llvm-project/pull/116462 >From daddb9e13db6ca8373dc7298d17aa36a03014aeb Mon Sep 17 00:00:00 2001 From: Vinay Deshmukh <32487576+vinay-deshm...@users.noreply.github.com> Date: Fri, 15 Nov 2024 07:37:17 -0500 Subject: [PATCH 1/9] [a

[clang] [Clang] allow usage of placement new operator in [[msvc::constexpr]] context outside of the std namespace (PR #119153)

2024-12-09 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk edited https://github.com/llvm/llvm-project/pull/119153 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] allow usage of placement new operator in [[msvc::constexpr]] context outside of the std namespace (PR #119153)

2024-12-09 Thread Oleksandr T. via cfe-commits
a-tarasyuk wrote: @RIscRIpt I've added tests. https://github.com/llvm/llvm-project/pull/119153 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] allow usage of placement new operator in [[msvc::constexpr]] context outside of the std namespace (PR #119153)

2024-12-09 Thread Richard Dzenis via cfe-commits
https://github.com/RIscRIpt approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/119153 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix cast for injected types in case name lookup for dependent bases (PR #119024)

2024-12-09 Thread Vladislav Belov via cfe-commits
vbe-sc wrote: @glandium, this is the fix for your example. Please, feel free to contact if you have any more troubles with this patch https://github.com/llvm/llvm-project/pull/119024 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[libclc] [libclc] Move several integer functions to CLC library (PR #116786)

2024-12-09 Thread Fraser Cormack via cfe-commits
@@ -0,0 +1,21 @@ +#ifndef __CLC_INTEGER_CLC_CLZ_H__ +#define __CLC_INTEGER_CLC_CLZ_H__ + +#if defined(CLC_CLSPV) || defined(CLC_SPIRV) +// clspv and spir-v targets provide their own OpenCL-compatible clz +#define __clc_clz clz frasercrmck wrote: > > In this conte

[clang] [llvm] [AArch64] Implement FP8 SVE Intrinsics for narrowing conversions (PR #118124)

2024-12-09 Thread Momchil Velikov via cfe-commits
@@ -10753,10 +10758,45 @@ class sve2_fp8_down_cvt_single opc, string mnemonic, let Inst{5} = 0b0; let Inst{4-0} = Zd; let Uses = [FPMR, FPCR]; + + let mayLoad = 1; + let mayStore = 0; } -multiclass sve2_fp8_down_cvt_single opc, string mnemonic, RegisterOperand src

[clang] Switch builtin strings to use string tables (PR #118734)

2024-12-09 Thread Ulrich Weigand via cfe-commits
uweigand wrote: The s390x failure is just an unstable test that occasionally fails - that woudn't be a reason to revert. Cannot say about the arm64-windows failure. https://github.com/llvm/llvm-project/pull/118734 ___ cfe-commits mailing list cfe-com

[clang] [Clang][Xtensa] Add Xtensa target. (PR #118008)

2024-12-09 Thread Aaron Ballman via cfe-commits
@@ -2742,3 +2742,275 @@ // RISCV64-LINUX: #define __unix__ 1 // RISCV64-LINUX: #define linux 1 // RISCV64-LINUX: #define unix 1 + +// RUN: %clang_cc1 -E -dM -ffreestanding -fgnuc-version=4.2.1 -triple=xtensa < /dev/null \ +// RUN: | FileCheck -match-full-lines -check-prefix

[clang] Switch builtin strings to use string tables (PR #118734)

2024-12-09 Thread Chandler Carruth via cfe-commits
chandlerc wrote: The arm64-windows failures are from `DirectoryWatcherTest` that seems exceedingly unlikely to be related. I think the only real failures here are the originally discussed ones on the one windows build bot. All the other windows bots seems to be OK here. https://github.com/llv

[clang] [Clang][Xtensa] Add Xtensa target. (PR #118008)

2024-12-09 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman commented: I don't know that we need reaffirmation; the target is already in the backend, so unless there's a call to remove the target, I think Clang's fine to expose it. That said, if there are signs that the target is only sporadically maintained, reaffirmin

[clang] [Clang][Xtensa] Add Xtensa target. (PR #118008)

2024-12-09 Thread Aaron Ballman via cfe-commits
@@ -9727,6 +9727,51 @@ static TypedefDecl *CreateHexagonBuiltinVaListDecl(const ASTContext *Context) { return Context->buildImplicitTypedef(VaListTagArrayType, "__builtin_va_list"); } +static TypedefDecl * +CreateXtensaABIBuiltinVaListDecl(const ASTContext *Context) { + /

[clang] [Clang][Xtensa] Add Xtensa target. (PR #118008)

2024-12-09 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/118008 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AArch64] Implement FP8 SVE Intrinsics for narrowing conversions (PR #118124)

2024-12-09 Thread Momchil Velikov via cfe-commits
@@ -0,0 +1,101 @@ +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --version 5 +// RUN: %clang_cc1-triple aarch64-none-linux-gnu -target-feature +sve -target-feature +sve2 -target-feature +fp8 -disable-O0-optnone -Werror -Wall -em

[clang] [llvm] [RISCV] Add stack clash protection (PR #117612)

2024-12-09 Thread Raphael Moreira Zinsly via cfe-commits
@@ -0,0 +1,208 @@ +; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py +; RUN: llc -mtriple=riscv64 -mattr=+m,+v -O2 < %s \ +; RUN: | FileCheck %s -check-prefix=RV64I rzinsly wrote: @lenary hi, is there anything else I should change?

[clang] [llvm] [WebAssembly] Add `-i128:128` to the `datalayout` string. (PR #119204)

2024-12-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Dan Gohman (sunfishcode) Changes Clang [defaults to aligning `__int128_t` to 16 bytes], while LLVM `datalayout` strings [default to aligning `i128` to 8 bytes]. Wasm is currently using the defaults for both, so it's inconsistent. Fix this

[clang] [llvm] [WebAssembly] Add `-i128:128` to the `datalayout` string. (PR #119204)

2024-12-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-llvm-ir @llvm/pr-subscribers-backend-webassembly Author: Dan Gohman (sunfishcode) Changes Clang [defaults to aligning `__int128_t` to 16 bytes], while LLVM `datalayout` strings [default to aligning `i128` to 8 bytes]. Wasm is currently using the defaul

[clang] [llvm] [WebAssembly] Add `-i128:128` to the `datalayout` string. (PR #119204)

2024-12-09 Thread Dan Gohman via cfe-commits
https://github.com/sunfishcode created https://github.com/llvm/llvm-project/pull/119204 Clang [defaults to aligning `__int128_t` to 16 bytes], while LLVM `datalayout` strings [default to aligning `i128` to 8 bytes]. Wasm is currently using the defaults for both, so it's inconsistent. Fix this

[clang] [llvm] [WebAssembly] Add `-i128:128` to the `datalayout` string. (PR #119204)

2024-12-09 Thread Dan Gohman via cfe-commits
https://github.com/sunfishcode edited https://github.com/llvm/llvm-project/pull/119204 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [lld] [lldb] [llvm] Rework the `Option` library to reduce dynamic relocations (PR #119198)

2024-12-09 Thread Chandler Carruth via cfe-commits
chandlerc wrote: > If you look for: > > ``` > FAILED: > �[0mtools/clang/tools/extra/clangd/CMakeFiles/obj.clangDaemon.dir/CompileCommands.cpp.o > > ``` > > In the build log that's the failure reason. NP, and thanks. Sorry I missed that set of tests. Pushed a fix that makes `check-clang-too

[clang] [llvm] [AArch64] Implement FP8 SVE Intrinsics for narrowing conversions (PR #118124)

2024-12-09 Thread Momchil Velikov via cfe-commits
@@ -0,0 +1,33 @@ +// REQUIRES: aarch64-registered-target + +// RUN: %clang_cc1 -triple aarch64-none-linux-gnu -target-feature +sve -target-feature +bf16 -verify -emit-llvm %s momchil-velikov wrote: This feature is needed by `svcreate2` and `svundef_bf16`. What p

[clang] [clang][bytecode] Handle __builtin_wcslen (PR #119187)

2024-12-09 Thread Timm Baeder via cfe-commits
@@ -256,15 +256,28 @@ static bool interp__builtin_strlen(InterpState &S, CodePtr OpPC, return false; assert(StrPtr.getFieldDesc()->isPrimitiveArray()); - + unsigned ElemSize = StrPtr.getFieldDesc()->getElemSize(); size_t Len = 0; for (size_t I = StrPtr.getIndex()

[clang-tools-extra] [clang-tidy] Filter out googletest TUs in bugprone-unchecked-optional-access (PR #115051)

2024-12-09 Thread Yitzhak Mandelbaum via cfe-commits
ymand wrote: > I am still confused why your team did not just disable this rule for test > folder? It is normal cases that source code and test code have different > quality metrics. Our codebase doesn't use test folders. We have no foolproof way of distinguishing code from test based on the

[clang] [C++20][Modules] Load function body from the module that gives canonical decl (PR #111992)

2024-12-09 Thread Ilya Biryukov via cfe-commits
ilya-biryukov wrote: We have some testing results in and it's causing a large-scale breakage. I **think** it's all coming from 2 root causes, but it's hard to know for sure because there are many thousands of broken targets. The two problems I see are: - invalid `no matching constructor for in

[clang] [clang][bytecode] Handle __builtin_strncmp (PR #119208)

2024-12-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/119208.diff 2 Files Affected: - (modified) clang/lib/AST/ByteCode/InterpBuiltin.cpp (+18-2) - (modified) clang/test/AST/ByteCode/builtin-functions

[clang] [llvm] [AArch64] Implement intrinsics for SME FP8 FMLAL/FMLALL (single) (PR #118869)

2024-12-09 Thread via cfe-commits
https://github.com/SpencerAbson converted_to_draft https://github.com/llvm/llvm-project/pull/118869 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [nfc][clang-offload-bundler] Don't leak on exit(1) (PR #119178)

2024-12-09 Thread Nikita Popov via cfe-commits
https://github.com/nikic approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/119178 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Switch builtin strings to use string tables (PR #118734)

2024-12-09 Thread via cfe-commits
zmodem wrote: > Not sure what to do debug this... @zmodem maybe has some idea? Sorry, I don't have a lot to add. Things look good on my end so far (local builds and https://lab.llvm.org/buildbot/#/builders/63 + https://lab.llvm.org/buildbot/#/builders/107). Besides the particular MSVC version

[clang] 411df3b - [clang-format] Make command lines of dump_format_[style|help].py consistent

2024-12-09 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2024-12-09T00:56:24-08:00 New Revision: 411df3bb4941318a02a59b4cd7a898d4f9b788a3 URL: https://github.com/llvm/llvm-project/commit/411df3bb4941318a02a59b4cd7a898d4f9b788a3 DIFF: https://github.com/llvm/llvm-project/commit/411df3bb4941318a02a59b4cd7a898d4f9b788a3.diff LOG:

[clang] Switch builtin strings to use string tables (PR #118734)

2024-12-09 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-s390x-linux` running on `systemz-1` while building `clang` at step 5 "ninja check 1". Full details are available at: https://lab.llvm.org/buildbot/#/builders/42/builds/2256 Here is the relevant piece of the build log f

[clang] [flang] [clang][driver] When -fveclib=ArmPL flag is in use, always link against libamath (PR #116432)

2024-12-09 Thread Paul Osmialowski via cfe-commits
@@ -490,6 +490,35 @@ void tools::AddLinkerInputs(const ToolChain &TC, const InputInfoList &Inputs, else A.renderAsInput(Args, CmdArgs); } + if (const Arg *A = Args.getLastArg(options::OPT_fveclib)) { +const llvm::Triple &Triple = TC.getTriple(); +StringRef

[clang-tools-extra] [clang-tidy] Fix crash in modernize-use-designated-initializers check (PR #113688)

2024-12-09 Thread Remi Mommsen via cfe-commits
mommsen wrote: Will this fix be added to an upcoming patch release for 19.1? We suffer from this issue using version 19.1.5. https://github.com/llvm/llvm-project/pull/113688 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[clang] [clang] Fix cast for injected types in case name lookup for dependent bases (PR #119024)

2024-12-09 Thread via cfe-commits
https://github.com/cor3ntin closed https://github.com/llvm/llvm-project/pull/119024 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 01710aa - [clang] Fix cast for injected types in case name lookup for dependent bases (#119024)

2024-12-09 Thread via cfe-commits
Author: Vladislav Belov Date: 2024-12-09T10:28:26+01:00 New Revision: 01710aa345f2fb26e2312dd1c62bd0044fc75bed URL: https://github.com/llvm/llvm-project/commit/01710aa345f2fb26e2312dd1c62bd0044fc75bed DIFF: https://github.com/llvm/llvm-project/commit/01710aa345f2fb26e2312dd1c62bd0044fc75bed.dif

[libclc] [llvm] [polly] [llvm] Move sub-project lead maintainers into their own Maintainers.md files (PR #118309)

2024-12-09 Thread Tobias Grosser via cfe-commits
tobiasgrosser wrote: Sure, this works for me. Thank you @Meinersbur for all your work here. I am happy to help out if this is useful. https://github.com/llvm/llvm-project/pull/118309 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[clang-tools-extra] [clang-tidy] Create a check for signed and unsigned integers comparison (PR #113144)

2024-12-09 Thread via cfe-commits
qt-tatiana wrote: Hi all, Sorry for silly question, but what is next? if I already have 2 approvals, should I squash all fix-ups and merge? (Btw, I don't have write permisions, not sure if I can land anything by myself) https://github.com/llvm/llvm-project/pull/113144

[clang] [Clang] allow [[msvc::constexpr]] usage outside the std namespace (PR #119153)

2024-12-09 Thread Richard Dzenis via cfe-commits
RIscRIpt wrote: Instead of adding this new test, could you please modify behavior of existing test: [`clang/test/SemaCXX/ms-constexpr-new.cpp`](https://github.com/llvm/llvm-project/pull/71300/files#diff-b0e33c7c54dd10b988b2badcc60be091e69ff3aeaf86c95cb2bb9bec1

[clang] [clang-cl][flang][dxc] Fix opts exposed to clang-cl/dxc by mistake (PR #118640)

2024-12-09 Thread Mészáros Gergely via cfe-commits
Maetveis wrote: @HaohaiWen can you review and approve if it looks good now for clang-cl? I'll try pinging discord and waiting a little bit for HLSL people before merging. Gentle ping @bob80905. https://github.com/llvm/llvm-project/pull/118640 ___ cf

[clang] [Clang] allow [[msvc::constexpr]] usage outside the std namespace (PR #119153)

2024-12-09 Thread Richard Dzenis via cfe-commits
https://github.com/RIscRIpt requested changes to this pull request. https://github.com/llvm/llvm-project/pull/119153 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][bytecode] Handle __builtin_wcslen (PR #119187)

2024-12-09 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/119187 >From d5c3e403c6cc30c897e7b8ada981a0d311ea187c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Sun, 8 Dec 2024 19:12:54 +0100 Subject: [PATCH] [clang][bytecode] Handle __builtin_wcslen Handl

[clang] [Clang] allow [[msvc::constexpr]] usage outside the std namespace (PR #119153)

2024-12-09 Thread Richard Dzenis via cfe-commits
RIscRIpt wrote: I don't think so. Ah, I forgot I previously added `clang/test/AST/ms-constexpr.cpp`, so having your new `ms-constexpr-new.cpp` makes sense (sorry for confusion). But I still would like to see a test in `clang/test/SemaCXX/ms-constexpr-new.cpp

[clang] [Clang] allow [[msvc::constexpr]] usage outside the std namespace (PR #119153)

2024-12-09 Thread Oleksandr T. via cfe-commits
a-tarasyuk wrote: Thanks for the review., would adding an AST dump at the Sema level be considered appropriate? https://github.com/llvm/llvm-project/pull/119153 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [llvm] [AArch64] Add intrinsics for SME FP8 FDOT LANE instructions (PR #118492)

2024-12-09 Thread Jonathan Thackray via cfe-commits
https://github.com/jthackray updated https://github.com/llvm/llvm-project/pull/118492 >From 609cf3fbdb28c155f4b8c787c1e2cb791c8a292f Mon Sep 17 00:00:00 2001 From: Jonathan Thackray Date: Fri, 29 Nov 2024 11:27:03 + Subject: [PATCH 1/8] [AArch64] Add intrinsics for SME FP8 FDOT LANE instru

[clang] [flang] [Flang][LoongArch] Enable clang command-line options in flang. (PR #118244)

2024-12-09 Thread via cfe-commits
https://github.com/zhaoqi5 closed https://github.com/llvm/llvm-project/pull/118244 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 669f704 - [Flang][LoongArch] Enable clang command-line options in flang. (#118244)

2024-12-09 Thread via cfe-commits
Author: Zhaoxin Yang Date: 2024-12-09T19:59:39+08:00 New Revision: 669f704d0dc833fc3cd844a8d8c1e0ed34d43a5b URL: https://github.com/llvm/llvm-project/commit/669f704d0dc833fc3cd844a8d8c1e0ed34d43a5b DIFF: https://github.com/llvm/llvm-project/commit/669f704d0dc833fc3cd844a8d8c1e0ed34d43a5b.diff

[clang] [Clang] allow usage of placement new operator in [[msvc::constexpr]] context outside of the std namespace (PR #119153)

2024-12-09 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/119153 >From f19ea82bbe5c00af6a6e261f989c9a89ef4c78ca Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Mon, 9 Dec 2024 01:46:46 +0200 Subject: [PATCH 1/3] [Clang] allow [[msvc::constexpr]] usage outside the std nam

[clang-tools-extra] [clangd] Handle DeducedTemplateSpecializationType in HeuristicResolver (PR #119107)

2024-12-09 Thread Haojian Wu via cfe-commits
https://github.com/hokein approved this pull request. https://github.com/llvm/llvm-project/pull/119107 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [nfc][clang-offload-bundler] Don't leak on exit(1) (PR #119178)

2024-12-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Vitaly Buka (vitalybuka) Changes `exit(1)` Don't calls C++ destructors, however calls `at_exit()` handlers, including lsan. Usually lsan can see pointers of local allocations on stack or in registers, but those can be discarded by noreturn

[clang] [nfc][clang-offload-bundler] Don't leak on exit(1) (PR #119178)

2024-12-09 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka created https://github.com/llvm/llvm-project/pull/119178 `exit(1)` Don't calls C++ destructors, however calls `at_exit()` handlers, including lsan. Usually lsan can see pointers of local allocations on stack or in registers, but those can be discarded by noreturn `

[clang] [clang-cl][flang][dxc] Fix opts exposed to clang-cl/dxc by mistake (PR #118640)

2024-12-09 Thread Mészáros Gergely via cfe-commits
https://github.com/Maetveis updated https://github.com/llvm/llvm-project/pull/118640 From c2efb475c557dd4ad1018e261a9659b1c4f16b83 Mon Sep 17 00:00:00 2001 From: Gergely Meszaros Date: Wed, 4 Dec 2024 05:44:19 -0800 Subject: [PATCH 1/3] [clang-cl][flang][dxc] Fix opts exposed to clang-cl/dxc b

[clang] [nfc][clang-offload-bundler] Don't leak on exit(1) (PR #119178)

2024-12-09 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka edited https://github.com/llvm/llvm-project/pull/119178 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Do not show `aParam` parameter hint for argument spelled `param` (PR #119162)

2024-12-09 Thread Haojian Wu via cfe-commits
https://github.com/hokein commented: I have mixed feelings about this. The change is small, but it seems tied to a particular coding style, and the implementation appears to be "optimized" specifically for that style, which isn’t we do generally. https://github.com/llvm/llvm-project/pull/11916

[clang] [clang-cl][flang][dxc] Fix opts exposed to clang-cl/dxc by mistake (PR #118640)

2024-12-09 Thread Mészáros Gergely via cfe-commits
Maetveis wrote: > Can we keep this flag for CL in this PR and open an issue to discuss whether > it should be disabled for CL? Sure, see latest commit and https://github.com/llvm/llvm-project/issues/119179. https://github.com/llvm/llvm-project/pull/118640 __

[clang] [LoongArch] Add FreeBSD targets (PR #119191)

2024-12-09 Thread via cfe-commits
https://github.com/hitmoon created https://github.com/llvm/llvm-project/pull/119191 Add support for freebsd on loongarch >From f56241d879e8da925c31d6605092cce5c4d8c8c9 Mon Sep 17 00:00:00 2001 From: xiaoqiang zhao Date: Mon, 9 Dec 2024 14:26:37 +0800 Subject: [PATCH] [LoongArch] Add FreeBSD ta

[clang] [llvm] [clang] Implement pragma clang section on COFF targets (PR #112714)

2024-12-09 Thread David Spickett via cfe-commits
DavidSpickett wrote: My comments have been addressed. https://github.com/llvm/llvm-project/pull/112714 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang] Implement pragma clang section on COFF targets (PR #112714)

2024-12-09 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 026af9e972469c878e51f1215659b7264da0136d e01f6fb36734b214e23cbbe66818b3269d21a591 --e

[clang] [Serialization] Migrate away from PointerUnion::{is,get} (NFC) (PR #118948)

2024-12-09 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 approved this pull request. Thanks https://github.com/llvm/llvm-project/pull/118948 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [LoongArch] Add FreeBSD targets (PR #119191)

2024-12-09 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] [LoongArch] Add FreeBSD targets (PR #119191)

2024-12-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (hitmoon) Changes Add support for freebsd on loongarch --- Full diff: https://github.com/llvm/llvm-project/pull/119191.diff 4 Files Affected: - (modified) clang/lib/Basic/Targets.cpp (+6) - (modified) clang/lib/Basic/Targets/OSTar

[clang] [clang][bytecode] Handle __builtin_wcslen (PR #119187)

2024-12-09 Thread via cfe-commits
https://github.com/cor3ntin edited https://github.com/llvm/llvm-project/pull/119187 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][bytecode] Handle __builtin_wcslen (PR #119187)

2024-12-09 Thread via cfe-commits
@@ -256,15 +256,28 @@ static bool interp__builtin_strlen(InterpState &S, CodePtr OpPC, return false; assert(StrPtr.getFieldDesc()->isPrimitiveArray()); - + unsigned ElemSize = StrPtr.getFieldDesc()->getElemSize(); size_t Len = 0; for (size_t I = StrPtr.getIndex()

[clang] Fix a bug with the hasAncestor AST matcher when a node has several parents without pointer identity (PR #118511)

2024-12-09 Thread Loïc Joly via cfe-commits
loic-joly-sonarsource wrote: Hi there. I do not have commit access, but this PR had one approval. Could someone with commit access merge it? https://github.com/llvm/llvm-project/pull/118511 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[clang] 6d759f8 - [Clang] Deleting an incomplete enum type is not an error (#119077)

2024-12-09 Thread via cfe-commits
Author: cor3ntin Date: 2024-12-09T10:20:16+01:00 New Revision: 6d759f83eb779cfdec02c1fe33344f3215bbdab1 URL: https://github.com/llvm/llvm-project/commit/6d759f83eb779cfdec02c1fe33344f3215bbdab1 DIFF: https://github.com/llvm/llvm-project/commit/6d759f83eb779cfdec02c1fe33344f3215bbdab1.diff LOG:

[clang] [Clang] Deleting an incomplete enum type is not an error (PR #119077)

2024-12-09 Thread via cfe-commits
https://github.com/cor3ntin closed https://github.com/llvm/llvm-project/pull/119077 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] allow [[msvc::constexpr]] usage outside the std namespace (PR #119153)

2024-12-09 Thread via cfe-commits
https://github.com/cor3ntin commented: LGTM https://github.com/llvm/llvm-project/pull/119153 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][bytecode] Handle __builtin_wcslen (PR #119187)

2024-12-09 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/119187 Handle different char widths in builtin_strlen. >From 1048d45d72c8b44211e245228e97b83b36b1c1b0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Sun, 8 Dec 2024 19:12:54 +0100 Subject: [PATCH]

[clang] [clang][bytecode] Handle __builtin_wcslen (PR #119187)

2024-12-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes Handle different char widths in builtin_strlen. --- Full diff: https://github.com/llvm/llvm-project/pull/119187.diff 2 Files Affected: - (modified) clang/lib/AST/ByteCode/InterpBuiltin.cpp (+18-3) - (modi

[clang] [clang][bytecode] Handle __builtin_wcslen (PR #119187)

2024-12-09 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. LGTM modulo comment https://github.com/llvm/llvm-project/pull/119187 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Switch builtin strings to use string tables (PR #118734)

2024-12-09 Thread Chandler Carruth via cfe-commits
chandlerc wrote: (FYI, I'm about to drop offline -- Hans, if you think it makes sense to revert temporarily, please feel free to do so. I don't have a good sense of whether the fallout here is enough to warrant that.) https://github.com/llvm/llvm-project/pull/118734 ___

[clang] [Clang] allow [[msvc::constexpr]] usage outside the std namespace (PR #119153)

2024-12-09 Thread Richard Dzenis via cfe-commits
https://github.com/RIscRIpt edited https://github.com/llvm/llvm-project/pull/119153 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix a dangling reference in clang/utils/TableGen/ClangDiagnosticsEmitter.cpp (PR #119197)

2024-12-09 Thread Haojian Wu via cfe-commits
https://github.com/hokein edited https://github.com/llvm/llvm-project/pull/119197 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix a dangling reference in clang/utils/TableGen/ClangDiagnosticsEmitter.cpp (PR #119197)

2024-12-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Haojian Wu (hokein) Changes `DiagsInGroup` is a `map`, we store a dangling string_view in the key. --- Full diff: https://github.com/llvm/llvm-project/pull/119197.diff 1 Files Affected: - (modified) clang/utils/Ta

[clang] [clang] Fix a dangling reference in clang/utils/TableGen/ClangDiagnosticsEmitter.cpp (PR #119197)

2024-12-09 Thread Haojian Wu via cfe-commits
https://github.com/hokein created https://github.com/llvm/llvm-project/pull/119197 `DiagsInGroup` is a `map`, we store a dangling string_view in the key. >From 85f1d54459125568bfbe2088827040c3b05a7804 Mon Sep 17 00:00:00 2001 From: Haojian Wu Date: Mon, 9 Dec 2024 11:48:59 +0100 Subject: [PAT

[clang] [clang][bytecode] Reject memcpy sizes with element size remainder (PR #119209)

2024-12-09 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/119209 None >From 0778f47716355e0916727c0bdb098e1f61b99bd9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Mon, 9 Dec 2024 14:23:51 +0100 Subject: [PATCH] [clang][bytecode] Reject memcpy sizes with

[clang] 4f08fa1 - [clang] Fix -Wunused-variable in InterpBuiltin.cpp (NFC)

2024-12-09 Thread Jie Fu via cfe-commits
Author: Jie Fu Date: 2024-12-09T21:23:08+08:00 New Revision: 4f08fa1a77b7357b4f1455b386ab8ca835e92558 URL: https://github.com/llvm/llvm-project/commit/4f08fa1a77b7357b4f1455b386ab8ca835e92558 DIFF: https://github.com/llvm/llvm-project/commit/4f08fa1a77b7357b4f1455b386ab8ca835e92558.diff LOG: [

[clang] [clang][bytecode] Handle __builtin_strncmp (PR #119208)

2024-12-09 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/119208 None >From 9dea6213fc6590b24278dbf8b65e23e97a0810f4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Mon, 9 Dec 2024 14:13:00 +0100 Subject: [PATCH] [clang][bytecode] Handle __builtin_strncmp

[clang] [clang][bytecode] Reject memcpy sizes with element size remainder (PR #119209)

2024-12-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/119209.diff 2 Files Affected: - (modified) clang/lib/AST/ByteCode/InterpBuiltin.cpp (+15) - (modified) clang/test/AST/ByteCode/builtin-functions.c

[clang] [llvm] Add processor aliases back to -print-supported-cpus and -mcpu=help (PR #118581)

2024-12-09 Thread Tomas Matheson via cfe-commits
https://github.com/tmatheson-arm approved this pull request. I'm surprised how complicated this was to do, but LGTM. https://github.com/llvm/llvm-project/pull/118581 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[clang] Fix lld link issue for OHOS (PR #118192)

2024-12-09 Thread Peng Huang via cfe-commits
phuang wrote: > LGTM Could you please help merge the PR? I don't see how to do it from my side. Thanks. https://github.com/llvm/llvm-project/pull/118192 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[clang] [clang][bytecode] Handle __builtin_strncmp (PR #119208)

2024-12-09 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/119208 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [llvm] [polly] [llvm] Move sub-project lead maintainers into their own Maintainers.md files (PR #118309)

2024-12-09 Thread Michael Kruse via cfe-commits
Meinersbur wrote: @tobiasgrosser and me already had talked about this at an LLVM conference. I didn't push the maintainer change yet because I am myself somewhat slow with reviews, but I think it makes sense. https://github.com/llvm/llvm-project/pull/118309

[clang] [clang] Fix a dangling reference in clang/utils/TableGen/ClangDiagnosticsEmitter.cpp (PR #119197)

2024-12-09 Thread Ilya Biryukov via cfe-commits
@@ -1908,7 +1908,7 @@ void clang::EmitClangDiagDocs(const RecordKeeper &Records, raw_ostream &OS) { for (const Record *G : DiagGroups) { bool IsRemarkGroup = isRemarkGroup(G, DiagsInGroup); auto &GroupInfo = -DiagsInGroup[std::string(G->getValueAsString("Grou

[libclc] [llvm] [llvm] Move sub-project lead maintainers into their own Maintainers.md files (PR #118309)

2024-12-09 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/118309 >From 64bfb1cd1bb7aa9e1597c0212dba7067c9f75d9f Mon Sep 17 00:00:00 2001 From: David Spickett Date: Mon, 2 Dec 2024 15:22:50 + Subject: [PATCH] [libclc] Add Maintainers.md for libclc --- libclc/Mainta

[clang] [Clang] Fix handling of immediate escalation for inherited constructors (PR #112860)

2024-12-09 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 54c6a592a078d0a2d484f8a64ac0f1ed47f79e35 ca10f9df93b987c6684cd2d211e6262258f3b2ae --e

  1   2   3   4   5   >