wangpc-pp wrote:
> Lets revert #90299 to recover bots before the weekend.
>
Many thanks for reverting it and fixing one of the failures!
https://github.com/llvm/llvm-project/pull/83774
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://l
wangpc-pp wrote:
> This change is also causing a failure on our internal Windows builder, and a
> public Windows bot:
> https://lab.llvm.org/buildbot/#/builders/119/builds/17634
> ```
> 88.872 [191/66/4550] Linking CXX executable bin\clang-repl.exe
> FAILED: bin/clang-repl.exe
> cmd.exe /C "cd
@@ -27,6 +27,9 @@ namespace llvm {
}
}
+// Prefix for __builtin_verbose_trap.
delcypher wrote:
@ahatanak Does this comment need updating? The prefix isn’t just for
__builtin_verbose_trap anymore.
https://github.com/llvm/llvm-project/pull/79230
___
@@ -27,6 +27,9 @@ namespace llvm {
}
}
+// Prefix for __builtin_verbose_trap.
+#define CLANG_VERBOSE_TRAP_PREFIX "__llvm_verbose_trap"
delcypher wrote:
@ahatanak Nit: Why does the macro name mention `CLANG` but the string mentions
`llvm` instead of Clang?
https://github.com/PiotrZSL approved this pull request.
LGTM.
https://github.com/llvm/llvm-project/pull/90279
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ivanmurashko created
https://github.com/llvm/llvm-project/pull/90319
There were two diffs that introduced some options useful when you build modules
externally and cannot rely on file modification time as the key for detecting
input file changes:
- [D67249](https://reviews.l
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Ivan Murashko (ivanmurashko)
Changes
There were two diffs that introduced some options useful when you build modules
externally and cannot rely on file modification time as the key for detecting
input file changes:
- [D67249](https://revi
https://github.com/tmatheson-arm edited
https://github.com/llvm/llvm-project/pull/90320
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -160,3 +160,22 @@ namespace GH88929 {
using E = P...[0]; // expected-error {{unknown type name 'P'}} \
// expected-error {{expected ';' after alias
declaration}}
}
+
+namespace GH88925 {
+template struct S {};
+
+template struct sequence {};
+
+
https://github.com/kovdan01 created
https://github.com/llvm/llvm-project/pull/90329
After #84384, `Qualifiers::Mask` becomes 64-bit. So, operations like `Mask &=
~U32` where `U32` is `unsigned` produce undesirable results since higher 32
bits of `Mask` become zeroed while they should be preser
https://github.com/kovdan01 ready_for_review
https://github.com/llvm/llvm-project/pull/90329
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Daniil Kovalev (kovdan01)
Changes
After #84384, `Qualifiers::Mask` becomes 64-bit. So, operations like
`Mask &= ~U32` where `U32` is `unsigned` produce undesirable results since
higher 32 bits of `Mask` become zeroed while they should be
https://github.com/cor3ntin approved this pull request.
https://github.com/llvm/llvm-project/pull/90308
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
SimplyDanny wrote:
> Do we add `improvement` documentation for checks that landed in the same
> release cycle?
I don't think that's needed.
https://github.com/llvm/llvm-project/pull/90273
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https:
https://github.com/SimplyDanny approved this pull request.
https://github.com/llvm/llvm-project/pull/90273
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Danny Mösch
Date: 2024-04-27T11:31:08+02:00
New Revision: b2c9f7d3188e41163574a83a835437955cf4b80f
URL:
https://github.com/llvm/llvm-project/commit/b2c9f7d3188e41163574a83a835437955cf4b80f
DIFF:
https://github.com/llvm/llvm-project/commit/b2c9f7d3188e41163574a83a835437955cf4b80f.diff
L
https://github.com/SimplyDanny closed
https://github.com/llvm/llvm-project/pull/90173
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/SimplyDanny created
https://github.com/llvm/llvm-project/pull/90334
None
From 35eed2c0faf74b241ee5e765dbc9f7ca115b9fba Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Danny=20M=C3=B6sch?=
Date: Sat, 27 Apr 2024 11:38:20 +0200
Subject: [PATCH] [NFC] Use const& avoiding copies
---
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Danny Mösch (SimplyDanny)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/90334.diff
1 Files Affected:
- (modified) clang/lib/Frontend/InterfaceStubFunctionsConsumer.cpp (+1-1)
``diff
diff --git a/clang/lib/
https://github.com/koachan created
https://github.com/llvm/llvm-project/pull/90338
Make sure that empty structs are treated as if it has a size of one bit in
function parameters and return types so that it occupies a full argument and/or
return register slot.
This fixes crashes and miscompila
llvmbot wrote:
@llvm/pr-subscribers-backend-sparc
@llvm/pr-subscribers-clang-codegen
Author: Koakuma (koachan)
Changes
Make sure that empty structs are treated as if it has a size of one bit in
function parameters and return types so that it occupies a full argument and/or
return registe
https://github.com/yronglin updated
https://github.com/llvm/llvm-project/pull/89942
>From 8c5f1d0f92d77bffec88759c19133a0bac130f32 Mon Sep 17 00:00:00 2001
From: yronglin
Date: Wed, 24 Apr 2024 23:36:10 +0800
Subject: [PATCH 1/7] [Clang] Implement P2748R5 "Disallow Binding a Returned
Glvalue t
https://github.com/phoebewang updated
https://github.com/llvm/llvm-project/pull/88245
>From 569c7dfee58f7e4357d8af45b52a3135cb4e2e65 Mon Sep 17 00:00:00 2001
From: Phoebe Wang
Date: Wed, 10 Apr 2024 15:38:49 +0800
Subject: [PATCH 1/3] "Reland "[Win32][ELF] Make CodeView a DebugInfoFormat
only
https://github.com/phoebewang updated
https://github.com/llvm/llvm-project/pull/88245
>From 569c7dfee58f7e4357d8af45b52a3135cb4e2e65 Mon Sep 17 00:00:00 2001
From: Phoebe Wang
Date: Wed, 10 Apr 2024 15:38:49 +0800
Subject: [PATCH 1/3] "Reland "[Win32][ELF] Make CodeView a DebugInfoFormat
only
https://github.com/phoebewang updated
https://github.com/llvm/llvm-project/pull/88245
>From 569c7dfee58f7e4357d8af45b52a3135cb4e2e65 Mon Sep 17 00:00:00 2001
From: Phoebe Wang
Date: Wed, 10 Apr 2024 15:38:49 +0800
Subject: [PATCH 1/3] "Reland "[Win32][ELF] Make CodeView a DebugInfoFormat
only
https://github.com/phoebewang updated
https://github.com/llvm/llvm-project/pull/88245
>From 569c7dfee58f7e4357d8af45b52a3135cb4e2e65 Mon Sep 17 00:00:00 2001
From: Phoebe Wang
Date: Wed, 10 Apr 2024 15:38:49 +0800
Subject: [PATCH 1/3] "Reland "[Win32][ELF] Make CodeView a DebugInfoFormat
only
https://github.com/ivanmurashko updated
https://github.com/llvm/llvm-project/pull/90319
>From ee4153f6b828c40a56b5b35d6e42cd193a1b5c31 Mon Sep 17 00:00:00 2001
From: Ivan Murashko
Date: Fri, 26 Apr 2024 22:45:26 +0100
Subject: [PATCH] [Modules] Process include files changes with
-fmodules-vali
https://github.com/phoebewang updated
https://github.com/llvm/llvm-project/pull/88245
>From 569c7dfee58f7e4357d8af45b52a3135cb4e2e65 Mon Sep 17 00:00:00 2001
From: Phoebe Wang
Date: Wed, 10 Apr 2024 15:38:49 +0800
Subject: [PATCH 1/3] "Reland "[Win32][ELF] Make CodeView a DebugInfoFormat
only
https://github.com/phoebewang updated
https://github.com/llvm/llvm-project/pull/88245
>From 569c7dfee58f7e4357d8af45b52a3135cb4e2e65 Mon Sep 17 00:00:00 2001
From: Phoebe Wang
Date: Wed, 10 Apr 2024 15:38:49 +0800
Subject: [PATCH 1/3] "Reland "[Win32][ELF] Make CodeView a DebugInfoFormat
only
phoebewang wrote:
> For driver tests we prefer specifying a concrete target triple than making a
> test dependent on the default target triple (controlled by `REQUIES:
> coff-supported-target` in this case).
>
> A concrete target triple (e.g. x86_64-windows) loses coverage for
> aarch64-windo
https://github.com/ivanmurashko updated
https://github.com/llvm/llvm-project/pull/90319
>From ee4153f6b828c40a56b5b35d6e42cd193a1b5c31 Mon Sep 17 00:00:00 2001
From: Ivan Murashko
Date: Fri, 26 Apr 2024 22:45:26 +0100
Subject: [PATCH] [Modules] Process include files changes with
-fmodules-vali
@@ -124,3 +124,40 @@ void test(int *List, int Length) {
#pragma unroll
/* expected-error {{expected statement}} */ }
+
+using size_t = unsigned long long;
+
+template
yronglin wrote:
Agree!
https://github.com/llvm/llvm-project/pull/90240
___
@@ -109,16 +109,20 @@ static Attr *handleLoopHintAttr(Sema &S, Stmt *St, const
ParsedAttr &A,
SetHints(LoopHintAttr::Unroll, LoopHintAttr::Disable);
} else if (PragmaName == "unroll") {
// #pragma unroll N
-if (ValueExpr && !ValueExpr->isValueDependent()) {
-
@@ -109,16 +109,20 @@ static Attr *handleLoopHintAttr(Sema &S, Stmt *St, const
ParsedAttr &A,
SetHints(LoopHintAttr::Unroll, LoopHintAttr::Disable);
} else if (PragmaName == "unroll") {
// #pragma unroll N
-if (ValueExpr && !ValueExpr->isValueDependent()) {
-
https://github.com/ivanmurashko updated
https://github.com/llvm/llvm-project/pull/90319
>From e8e9502f117d5559c4da225b0e24fe6db9c27751 Mon Sep 17 00:00:00 2001
From: Ivan Murashko
Date: Fri, 26 Apr 2024 22:45:26 +0100
Subject: [PATCH] [Modules] Process include files changes with
-fmodules-vali
yronglin wrote:
I have question, for the case `#pragma unroll {0|1}`, which AST attribute node
make sense?
1.
```
LoopHintAttr 0x14b0bae08 Implicit unroll Unroll Disable
```
or
2.
```
LoopHintAttr 0x15780a408 Implicit unroll UnrollCount
Numeric
```
Do we need accurate AST or real semantics
https://github.com/ivanmurashko edited
https://github.com/llvm/llvm-project/pull/90319
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
komalverma04 wrote:
@5chmidti Please take a look at it.
Thank You
https://github.com/llvm/llvm-project/pull/89553
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HerrCai0907 approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/90279
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HerrCai0907 approved this pull request.
LGTM in code. I am not a native English speaker so I can't review the
documentation very well.
https://github.com/llvm/llvm-project/pull/86448
___
cfe-commits mailing list
cfe-commits@lists.ll
https://github.com/HerrCai0907 approved this pull request.
https://github.com/llvm/llvm-project/pull/88636
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/yronglin updated
https://github.com/llvm/llvm-project/pull/90240
>From 131783211a23d007b5b6f1d5691306df4dec716b Mon Sep 17 00:00:00 2001
From: yronglin
Date: Sat, 27 Apr 2024 01:38:34 +0800
Subject: [PATCH 1/3] [Clang] Fix incorrect handling of #pragma {GCC} unroll N
in depe
https://github.com/yronglin updated
https://github.com/llvm/llvm-project/pull/90240
>From 131783211a23d007b5b6f1d5691306df4dec716b Mon Sep 17 00:00:00 2001
From: yronglin
Date: Sat, 27 Apr 2024 01:38:34 +0800
Subject: [PATCH 1/4] [Clang] Fix incorrect handling of #pragma {GCC} unroll N
in depe
@@ -124,3 +124,40 @@ void test(int *List, int Length) {
#pragma unroll
/* expected-error {{expected statement}} */ }
+
+using size_t = unsigned long long;
+
+template
yronglin wrote:
I've keep test case in this file, because clang currently has this issue
h
https://github.com/yronglin updated
https://github.com/llvm/llvm-project/pull/90240
>From 131783211a23d007b5b6f1d5691306df4dec716b Mon Sep 17 00:00:00 2001
From: yronglin
Date: Sat, 27 Apr 2024 01:38:34 +0800
Subject: [PATCH 1/5] [Clang] Fix incorrect handling of #pragma {GCC} unroll N
in depe
https://github.com/yronglin edited
https://github.com/llvm/llvm-project/pull/90240
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
brandtbucher wrote:
Yep. I also updated the docs with the new register-passing order.
https://github.com/llvm/llvm-project/pull/88333
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Endilll created
https://github.com/llvm/llvm-project/pull/90352
Currently we're using official publication of CWG issue list available at
https://www.open-std.org/jtc1/sc22/wg21/docs/cwg_index.html. Unfortunately,
it's not updated as frequently as we sometimes need. For inst
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Vlad Serebrennikov (Endilll)
Changes
Currently we're using official publication of CWG issue list available at
https://www.open-std.org/jtc1/sc22/wg21/docs/cwg_index.html. Unfortunately,
it's not updated as frequently as we sometimes need
https://github.com/MitalAshok created
https://github.com/llvm/llvm-project/pull/90353
Fixes #27059
Dependent function parameters, template parameters and exception declarations
that have qualified function types now error instead of silently decaying into
an invalid pointer type.
Also fix __
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Mital Ashok (MitalAshok)
Changes
Fixes #27059
Dependent function parameters, template parameters and exception declarations
that have qualified function types now error instead of silently decaying into
an invalid pointer type.
Also fix
@@ -269,6 +269,10 @@ Changes in existing checks
don't remove parentheses used in ``sizeof`` calls when they have array index
accesses as arguments.
+- Improved :doc:`modernize-use-nullptr
+ ` check to include support for
+ ``C23``, which also has introduced the ``nullptr
Author: Björn Svensson
Date: 2024-04-27T20:50:04+02:00
New Revision: 803cbcbc4029fc65188f6c1083a230341279b2d2
URL:
https://github.com/llvm/llvm-project/commit/803cbcbc4029fc65188f6c1083a230341279b2d2
DIFF:
https://github.com/llvm/llvm-project/commit/803cbcbc4029fc65188f6c1083a230341279b2d2.diff
https://github.com/PiotrZSL closed
https://github.com/llvm/llvm-project/pull/89990
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Piotr Zegar
Date: 2024-04-27T18:51:00Z
New Revision: 0336328e970e7e809d52a33a704bb7c05f6e170e
URL:
https://github.com/llvm/llvm-project/commit/0336328e970e7e809d52a33a704bb7c05f6e170e
DIFF:
https://github.com/llvm/llvm-project/commit/0336328e970e7e809d52a33a704bb7c05f6e170e.diff
LOG: [
https://github.com/lelandjansen closed
https://github.com/llvm/llvm-project/pull/88810
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -3893,9 +3893,12 @@ namespace {
}
void VisitCXXBindTemporaryExpr(const CXXBindTemporaryExpr *E) {
- if (E->getTemporary()->getDestructor()->isTrivial()) {
-Inherited::VisitStmt(E);
-return;
+ if (const CXXDestructorDecl *DtorDecl =
+
https://github.com/PiotrZSL edited
https://github.com/llvm/llvm-project/pull/89490
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/PiotrZSL commented:
One issue, looks like only stdout is buffered, and when clang-tidy output:
"26035 warnings generated.
Suppressed 26030 warnings (26030 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use
-system-headers to display er
@@ -488,70 +493,72 @@ def main():
# Build up a big regexy filter from all command line arguments.
file_name_re = re.compile("|".join(args.files))
+files = {f for f in files if file_name_re.search(f)}
-return_code = 0
+returncode = 0
try:
-# S
https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/90301
>From 0e9d10029e6d498d3bc5a319ac0945cf23db230d Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Fri, 26 Apr 2024 17:01:35 -0700
Subject: [PATCH 1/2] Fix a crash introduced by 3d5e9ab by adding a nullptr
check.
--
rniwa wrote:
> Hey, do you think a regression test would be valuable?
Oh, that's a very good point. Added one.
https://github.com/llvm/llvm-project/pull/90301
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailm
https://github.com/tcreech-intel updated
https://github.com/llvm/llvm-project/pull/88438
>From fe3404cbdf78b434f16f8351dc242175b4543112 Mon Sep 17 00:00:00 2001
From: Tim Creech
Date: Thu, 11 Apr 2024 16:03:52 -0400
Subject: [PATCH 1/4] Improve documented sampling profiler steps to best known
@@ -2547,22 +2547,40 @@ usual build cycle when using sample profilers for
optimization:
used in the first step. The only requirement is that you build the code
with the same debug info options and ``-fprofile-sample-use``.
+ On Linux:
+
.. code-block:: console
@@ -54,7 +54,7 @@ class UncountedCallArgsChecker
bool shouldVisitImplicitCode() const { return false; }
bool TraverseDecl(Decl *D) {
-if (isa(D) && isRefType(safeGetName(D)))
+if (D && isa(D) && isRefType(safeGetName(D)))
return true;
Author: Owen Pan
Date: 2024-04-27T15:14:20-07:00
New Revision: b4af01bada0c945906d85c364e12aceaf98b0fae
URL:
https://github.com/llvm/llvm-project/commit/b4af01bada0c945906d85c364e12aceaf98b0fae
DIFF:
https://github.com/llvm/llvm-project/commit/b4af01bada0c945906d85c364e12aceaf98b0fae.diff
LOG:
https://github.com/owenca created
https://github.com/llvm/llvm-project/pull/90363
None
>From 70e5f7df8711ac22450a441efe91ed7fa6e339f0 Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Sat, 27 Apr 2024 15:16:43 -0700
Subject: [PATCH] [clang-format][NFC] Return early in isWordLike() for
non-Verilog
llvmbot wrote:
@llvm/pr-subscribers-clang-format
Author: Owen Pan (owenca)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/90363.diff
2 Files Affected:
- (modified) clang/lib/Format/FormatToken.h (+6-2)
- (modified) clang/lib/Format/TokenAnnotator.cpp (+8-5)
`
Author: Tom Stellard
Date: 2024-04-27T15:32:58-07:00
New Revision: 53ff002c6f7ec64a75ab0990b1314cc6b4bb67cf
URL:
https://github.com/llvm/llvm-project/commit/53ff002c6f7ec64a75ab0990b1314cc6b4bb67cf
DIFF:
https://github.com/llvm/llvm-project/commit/53ff002c6f7ec64a75ab0990b1314cc6b4bb67cf.diff
https://github.com/tstellar closed
https://github.com/llvm/llvm-project/pull/90139
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tstellar milestoned
https://github.com/llvm/llvm-project/pull/90139
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tstellar wrote:
/cherry-pick 53ff002c6f7ec64a75ab0990b1314cc6b4bb67cf
https://github.com/llvm/llvm-project/pull/90139
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
Failed to cherry-pick: 53ff002c6f7ec64a75ab0990b1314cc6b4bb67cf
https://github.com/llvm/llvm-project/actions/runs/8863031679
Please manually backport the fix and push it to your github fork. Once this is
done, please create a [pull
request](https://github.com/llvm/llvm-projec
whentojump wrote:
/cherry-pick c1b6cca1214e7a9c14a30b81585dd8b81baeaa77
https://github.com/llvm/llvm-project/pull/89564
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/whentojump milestoned
https://github.com/llvm/llvm-project/pull/89564
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
/pull-request llvm/llvm-project#90369
https://github.com/llvm/llvm-project/pull/89564
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
HighCommander4 wrote:
@twmht To my knowledge, clang and clangd have only ever supported the
`@file.rsp` response file syntax.
The commands in the linked thread use the `--options-file file.rsp` syntax,
which clang and clangd do not support.
https://github.com/clangd/vscode-clangd/issues/592 i
https://github.com/igorkudrin created
https://github.com/llvm/llvm-project/pull/90370
The only reason for the removed condition was that there was a dependency for
`CTTestTidyModule` on the `clang-tidy-headers` target, which was only created
under the same `NOT LLVM_INSTALL_TOOLCHAIN_ONLY` con
llvmbot wrote:
@llvm/pr-subscribers-clang-tidy
Author: Igor Kudrin (igorkudrin)
Changes
The only reason for the removed condition was that there was a dependency for
`CTTestTidyModule` on the `clang-tidy-headers` target, which was only created
under the same `NOT LLVM_INSTALL_TOOLCHAIN_O
https://github.com/ChuanqiXu9 approved this pull request.
I have no idea why it was. But the current change looks pretty fine to me.
https://github.com/llvm/llvm-project/pull/90298
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.l
https://github.com/ChuanqiXu9 approved this pull request.
Feel not bad.
https://github.com/llvm/llvm-project/pull/90310
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
offsetof wrote:
Yes, that would be great, thank you.
https://github.com/llvm/llvm-project/pull/89484
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dwblaikie wrote:
C doesn't have an odr, does it?
https://github.com/llvm/llvm-project/pull/90298
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vtjnash wrote:
I think out of tree builds of clang-tidy (back in the svn days, when people did
partial checkouts of individual projects) probably needed this to be able to
correctly correctly find the right headers. Maybe standalone builds aren't
permitted anymore? I think I mentioned this a b
https://github.com/lipracer approved this pull request.
https://github.com/llvm/llvm-project/pull/90334
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
igorkudrin wrote:
> I think out of tree builds of clang-tidy (back in the svn days, when people
> did partial checkouts of individual projects) probably needed this to be able
> to correctly correctly find the right headers. Maybe standalone builds aren't
> permitted anymore? I think I mention
https://github.com/nicovank updated
https://github.com/llvm/llvm-project/pull/89490
>From 85700b3488ceb65adc73469c82137c1c3429b3f4 Mon Sep 17 00:00:00 2001
From: Nicolas van Kempen
Date: Sat, 20 Apr 2024 02:58:25 +
Subject: [PATCH] [run-clang-tidy.py] Refactor, add progress indicator, add
nicovank wrote:
Reproduced the buffering issue on my setup, but flushing didn't fix the problem.
I could also reproduce with the current version of this script, which does also
flush after writing.
Python defaults input/output streams to buffered mode when it detects a pipe,
and I don't think f
@@ -530,43 +527,43 @@ Now the linkage name of ``NS::foo()`` will be
``_ZN2NS3fooEv``.
Module Initializers
~~~
-All the importable module units are required to emit an initializer function.
-The initializer function should contain calls to importing modules fir
https://github.com/ChuanqiXu9 edited
https://github.com/llvm/llvm-project/pull/90237
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -312,75 +300,76 @@ So all of the following name is not valid by default:
__test
// and so on ...
-If you still want to use the reserved module names for any reason, use
-``-Wno-reserved-module-identifier`` to suppress the warning.
+Using a reserved module name is st
@@ -633,36 +630,37 @@ example:
// module M's interface, so is discarded
int c = use_h(); // OK
-In the above example, the function definition of ``N::g`` is elided from the
Reduced
-BMI of ``M.cppm``. Then the use of ``use_g`` in
@@ -530,43 +527,43 @@ Now the linkage name of ``NS::foo()`` will be
``_ZN2NS3fooEv``.
Module Initializers
~~~
-All the importable module units are required to emit an initializer function.
-The initializer function should contain calls to importing modules fir
@@ -8,109 +8,91 @@ Standard C++ Modules
Introduction
-The term ``modules`` has a lot of meanings. For the users of Clang, modules may
-refer to ``Objective-C Modules``, ``Clang C++ Modules`` (or ``Clang Header
Modules``,
-etc.) or ``Standard C++ Modules``. The im
@@ -400,24 +389,27 @@ And the compilation process for module units are like:
mod1.cppm -> clang++ mod1.cppm ... -> mod1.pcm --,--> clang++
mod1.pcm ... -> mod1.o -+
src2.cpp +> clang++
src2.cpp ---> sr
@@ -216,51 +198,56 @@ We explain the options in the following sections.
How to enable standard C++ modules
~~
-Currently, standard C++ modules are enabled automatically
-if the language standard is ``-std=c++20`` or newer.
+Standard C++ modules
@@ -8,109 +8,91 @@ Standard C++ Modules
Introduction
-The term ``modules`` has a lot of meanings. For the users of Clang, modules may
-refer to ``Objective-C Modules``, ``Clang C++ Modules`` (or ``Clang Header
Modules``,
-etc.) or ``Standard C++ Modules``. The im
@@ -925,45 +923,41 @@ In that case, you need to convert your source files (.cpp
files) to module imple
// Following off should be unchanged.
...
-The module implementation unit will import the primary module implicitly.
-We don't include any headers in the module implemen
@@ -312,75 +300,76 @@ So all of the following name is not valid by default:
__test
// and so on ...
-If you still want to use the reserved module names for any reason, use
-``-Wno-reserved-module-identifier`` to suppress the warning.
+Using a reserved module name is st
@@ -8,79 +8,60 @@ Standard C++ Modules
Introduction
-The term ``modules`` has a lot of meanings. For the users of Clang, modules may
-refer to ``Objective-C Modules``, ``Clang C++ Modules`` (or ``Clang Header
Modules``,
-etc.) or ``Standard C++ Modules``. The imp
1 - 100 of 128 matches
Mail list logo