[PATCH] D148467: [clang-format] Add a new AfterCSharpProperty to BraceWrapping

MyDeveloperDay added a comment. Just an update on this, it works well but some of the cases are not tolerant to comments, I'm working my way through those issues CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148467/new/ https://reviews.llvm.org/D148467

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

alexander-shaposhnikov updated this revision to Diff 518990. alexander-shaposhnikov added a comment. Simplify code a little bit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146178/new/ https://reviews.llvm.org/D146178 Files: clang/include/clan

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

alexander-shaposhnikov added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:133 } +Response HandlePartialClassTemplateSpec( HandlePartialClassTemplateSpec is from Erich's diff (https://reviews.llvm.org/D147722) Comm

[PATCH] D146054: [RISCV] Add --print-supported-extensions and -march=help support

kito-cheng accepted this revision. kito-cheng added a comment. LGTM, consider about the GNU compatibility, I would that has -march=help form for that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146054/new/ https://reviews.llvm.org/D146054

[PATCH] D148088: [RFC][clangd] Move preamble index task to a seperate task

kadircet added a comment. Thanks for the patch, this is a topic we've discussed a couple times in the past as well as it has far reaching implications. I believe we're actually in a much better situation nowadays. To summarise some concerns (thanks to @sammccall for useful discussion); Feature

[PATCH] D146054: [RISCV] Add --print-supported-extensions and -march=help support

craig.topper added a comment. In D146054#4314766 , @kito-cheng wrote: > LGTM, consider about the GNU compatibility, I would that has -march=help form > for that. Are you saying gcc supports march=help? Is that recent? Repository: rG LLVM Github Mon

[PATCH] D146757: [Driver] Enable defining multilib print options independently of flags

michaelplatings updated this revision to Diff 518997. michaelplatings added a comment. Chagne code to allow defining multilib flags verbatim Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146757/new/ https://reviews.llvm.org/D146757 Files: clang/

[PATCH] D142932: Multilib YAML parsing

michaelplatings updated this revision to Diff 518999. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142932/new/ https://reviews.llvm.org/D142932 Files: clang/include/clang/Driver/Multilib.h clang/lib/Dri

[PATCH] D142933: Add -print-multi-selection-flags-experimental option

michaelplatings updated this revision to Diff 519000. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142933/new/ https://reviews.llvm.org/D142933 Files: clang/include/clang/Driver/Options.td clang/include

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

michaelplatings updated this revision to Diff 519001. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142986/new/ https://reviews.llvm.org/D142986 Files: clang/lib/Driver/ToolChains/Arch/ARM.cpp clang/lib/

[PATCH] D143059: [Driver] Enable selecting multiple multilibs

michaelplatings updated this revision to Diff 519002. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143059/new/ https://reviews.llvm.org/D143059 Files: clang/include/clang/Driver/Multilib.h clang/include

[PATCH] D143075: BareMetal ToolChain multilib layering

michaelplatings updated this revision to Diff 519003. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143075/new/ https://reviews.llvm.org/D143075 Files: clang/lib/Driver/ToolChains/BareMetal.cpp clang/lib

[PATCH] D143587: [Docs] Multilib design

michaelplatings updated this revision to Diff 519004. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143587/new/ https://reviews.llvm.org/D143587 Files: clang/docs/Multilib.rst clang/docs/index.rst Index

[PATCH] D146757: [Driver] Enable defining multilib flags verbatim

michaelplatings updated this revision to Diff 519005. michaelplatings added a comment. Re-run arc diff with clang-format in PATH Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146757/new/ https://reviews.llvm.org/D146757 Files: clang/include/clan

[PATCH] D149643: [clang-format] Correctly limit formatted ranges when specifying qualifier alignment

cogilvie updated this revision to Diff 519007. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149643/new/ https://reviews.llvm.org/D149643 Files: clang/lib/Format/QualifierAlignmentFixer.cpp clang/unittests/Format/QualifierFixerTest.cpp Index: clang/unittests/Format/QualifierFixerTe

[PATCH] D149643: [clang-format] Correctly limit formatted ranges when specifying qualifier alignment

cogilvie updated this revision to Diff 519008. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149643/new/ https://reviews.llvm.org/D149643 Files: clang/lib/Format/QualifierAlignmentFixer.cpp clang/unittests/Format/QualifierFixerTest.cpp Index: clang/unittests/Format/QualifierFixerTe

[clang] c68e92d - Fix MSVC "not all control paths return a value" warning. NFC.

Author: Simon Pilgrim Date: 2023-05-03T10:23:41+01:00 New Revision: c68e92d941723702810093161be4834f3ca68372 URL: https://github.com/llvm/llvm-project/commit/c68e92d941723702810093161be4834f3ca68372 DIFF: https://github.com/llvm/llvm-project/commit/c68e92d941723702810093161be4834f3ca68372.diff

[PATCH] D149733: [clang][USR] Prevent crashes on incomplete FunctionDecls

kadircet created this revision. kadircet added reviewers: aaron.ballman, ilya-biryukov. Herald added a subscriber: arphaman. Herald added a project: All. kadircet requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits. FunctionDec

[PATCH] D146634: [clang][USR] Prevent crashes when parameter lists have nulls

kadircet abandoned this revision. kadircet added a comment. in favor of D149733 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146634/new/ https://reviews.llvm.org/D146634 _

[PATCH] D149733: [clang][USR] Prevent crashes on incomplete FunctionDecls

ilya-biryukov added a subscriber: erichkeane. ilya-biryukov added a comment. It's true that `FunctionType` having a null type does break a lot of even its own methods, e.g. even something as simple as `isVariadic` will dereference a null pointer as it uses `getType()->getAs()`. I am not entirel

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

sberg added a comment. Since this commit (plus its follow-up https://github.com/llvm/llvm-project/commit/ce861ec782ae3f41807b61e855512aaccf3c2149 "[Clang][Sema] Add a temporary workaround in SemaConcept.cpp", to avoid `clang/lib/AST/ExprConstant.cpp:15332: bool clang::Expr::EvaluateAsConstantE

[PATCH] D149733: [clang][USR] Prevent crashes on incomplete FunctionDecls

kadircet added a comment. FWIW, https://github.com/llvm/llvm-project/blob/main/clang/lib/AST/Decl.cpp#L2987 is the assertion that suggests "null type is fine for functiondecls", but as pointed out pretty much all of the methods assume it's non-null && most of the users also don't check for val

[PATCH] D148066: [RISCV] Add Smaia and Ssaia extensions support

asb added a comment. Just noting for posterity that we discussed this at last week's RISC-V sync-up call and I think the tentative conclusion (there weren't particularly strong views) was that experiments CSRs should really be gated by -menable-experimental-extensions, with the CSR names gated

[PATCH] D148088: [RFC][clangd] Move preamble index task to a seperate task

kuganv added a comment. Thanks @kadircet , @sammccall and @ilya-biryukov for the super detailed explanation. As mentioned, we will test clangd with an ASAN build to test. I also would like to get your feedback on the implementation. After we claim the AST as per @sammccall's patch into LiveAST

[PATCH] D149640: [clang][dataflow] Change PruneTriviallyFalseEdges for building CFG

mboehme added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/TransferTest.cpp:2690 +// `after_loop` is pruned by PruneTriviallyFalseEdges, so we only should +// have `in_loop`. +ASSERT_TRUE(Results.empty()); This comm

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

sberg added a comment. In D146178#4314999 , @sberg wrote: > Since this commit... ah, already taken care of with https://github.com/llvm/llvm-project/commit/3e850a6eea5277082a0b7b701754c86530d25c40 "Revert '[Clang][Sema] Fix comparison of constraint exp

[PATCH] D149737: [clang][ExtractAPI] Add semicolon to function declaration fragments

chaitanyav created this revision. chaitanyav added a reviewer: dang. Herald added a reviewer: ributzka. Herald added a project: All. chaitanyav requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add missing semicolon at the end of function dec

[PATCH] D149640: [clang][dataflow] Change PruneTriviallyFalseEdges for building CFG

kinu updated this revision to Diff 519029. kinu added a comment. Updated the stale comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149640/new/ https://reviews.llvm.org/D149640 Files: clang/lib/Analysis/FlowSensitive/ControlFlowContext.cpp

[PATCH] D149640: [clang][dataflow] Change PruneTriviallyFalseEdges for building CFG

kinu marked an inline comment as done. kinu added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/TransferTest.cpp:2690 +// `after_loop` is pruned by PruneTriviallyFalseEdges, so we only should +// have `in_loop`. +ASSERT_TRUE(Results.

[PATCH] D149013: [clang][Interp] Check pointers when accessing base class

aaron.ballman added subscribers: hubert.reinterpretcast, rsmith. aaron.ballman added inline comments. Comment at: clang/test/AST/Interp/records.cpp:509-512 + constexpr A *a2 = &b + 1; // expected-error {{must be initialized by a constant expression}} \ +

[PATCH] D149149: [clang][Interp] Check one-past-the-end pointers in GetPtrField

aaron.ballman added inline comments. Comment at: clang/test/AST/Interp/records.cpp:500 namespace PointerArith { struct A {}; shafik wrote: > aaron.ballman wrote: > > Neat! For the tests in this namespace, Clang and ICC agree, GCC and MSVC > > agree, and us

[PATCH] D149695: MS inline asm: remove obsolete code adding AOK_SizeDirective (e.g. dword ptr)

hans added a comment. > The AOK_SizeDirective part from 5b37c181291210bedfbb7a6af5d51229f3652ef0 > (2014-08) seems unneeded nowadays (the root cause has likely been fixed > elsewhere). Would it be possible to confirm when/if the size directive here became unnecessary? Repository: rG LLVM Git

[PATCH] D146764: [clang] Make predefined expressions string literals under -fms-extensions

aaron.ballman added a comment. In D146764#4313905 , @aeubanks wrote: > added the warning, not sure if this needs more tests for testing the > interaction between `-pedantic`, `-Wmicrosoft`, > `-Wmicrosoft-init-from-predefined` or if that's already assum

[PATCH] D149650: Give NullabilityKind a printing operator<

sammccall added a reviewer: aaron.ballman. sammccall added a comment. In D149650#4312389 , @aaron.ballman wrote: > I guess I'm not seeing much motivation for this change. We already have > `clang::getNullabilitySpelling()` and `const StreamingDiagnostic

cfe-commits@lists.llvm.org

massberg updated this revision to Diff 519042. massberg marked an inline comment as done. massberg added a comment. Fixed typo, added release note and updated cxx_status.html. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148924/new/ https://review

[PATCH] D149650: Give NullabilityKind a printing operator<

sammccall updated this revision to Diff 519046. sammccall added a comment. Make diagnostic-printing use the (other) existing function, come out neutral! (This adds quotes to some diagnostic, but their omission seems to be an error) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[clang] 22e2db6 - [clang] Reject flexible array member in a union in C++

Author: Mariya Podchishchaeva Date: 2023-05-03T08:54:35-04:00 New Revision: 22e2db6010b029ebd4c6d3d1fd30224d8b3109ef URL: https://github.com/llvm/llvm-project/commit/22e2db6010b029ebd4c6d3d1fd30224d8b3109ef DIFF: https://github.com/llvm/llvm-project/commit/22e2db6010b029ebd4c6d3d1fd30224d8b3109

[PATCH] D147626: [clang] Reject flexible array member in a union in C++

This revision was automatically updated to reflect the committed changes. Closed by commit rG22e2db6010b0: [clang] Reject flexible array member in a union in C++ (authored by Fznamznon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147626/new/ http

[PATCH] D148370: [Clang][Flang][OpenMP] Add loadOffloadInfoMetadata and createOffloadEntriesAndInfoMetadata into OMPIRBuilder's finalize and initialize

agozillon updated this revision to Diff 519048. agozillon added a comment. - Move hostIRFilePath initialize invocation to ModuleTranslation.cpp to respect TargetOp patch - Apply reviewer feedback - Tidy up missed style guidelines i sillily forgot about Repository: rG LLVM Github Monorepo CHA

[PATCH] D148370: [Clang][Flang][OpenMP] Add loadOffloadInfoMetadata and createOffloadEntriesAndInfoMetadata into OMPIRBuilder's finalize and initialize

agozillon updated this revision to Diff 519050. agozillon marked an inline comment as done. agozillon added a comment. - Remove unneccessary OMPIRBuilder scope as well Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148370/new/ https://reviews.llvm.o

[PATCH] D148370: [Clang][Flang][OpenMP] Add loadOffloadInfoMetadata and createOffloadEntriesAndInfoMetadata into OMPIRBuilder's finalize and initialize

agozillon added a comment. Updated to fix the style issues that were present and pointed out by @jdoerfert thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148370/new/ https://reviews.llvm.org/D148370 _

[PATCH] D149744: [clang][dataflow][NFC] Eliminate unnecessary helper `stripReference()`.

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. `QualType::getNonReferenceType()` does the same

[clang] 7178ee1 - Revert "[clang] Reject flexible array member in a union in C++"

Author: Mariya Podchishchaeva Date: 2023-05-03T09:25:03-04:00 New Revision: 7178ee190235bd5b6cc7c71d3ccc061d4b12656b URL: https://github.com/llvm/llvm-project/commit/7178ee190235bd5b6cc7c71d3ccc061d4b12656b DIFF: https://github.com/llvm/llvm-project/commit/7178ee190235bd5b6cc7c71d3ccc061d4b1265

[PATCH] D147626: [clang] Reject flexible array member in a union in C++

Fznamznon added a comment. I've got an error from buildbot on Windows: C:\Program Files (x86)\Windows Kits\10\include\10.0.19041.0\um\winioctl.h:13404:51: error: flexible array member 'Lev1Depends' in a union is not allowed STORAGE_QUERY_DEPENDENT_VOLUME_LEV1_ENTRY Lev1Depends[];

[PATCH] D149666: [OpenMP][OMPIRBuilder] Migrate MapCombinedInfoTy from Clang to OpenMPIRBuilder

TIFitis updated this revision to Diff 519054. TIFitis added a comment. Changed name from llvm::OpenMPIRBuilder::MapCombinedInfoTy to llvm::OpenMPIRBuilder::MapInfosTy, and changed to struct instead of class. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D149573: [Clang][C++23] Implement core language changes from P1467R9 extended floating-point types and standard names and introduce Bfloat16 arithmetic type.

erichkeane added a comment. Others definitely need to review this, but i'm about happy with it. Comment at: clang/include/clang/Basic/LangOptions.def:468 +LANGOPT(ExperimentalNewItaniumMangling, 1, 0, "experimental new Itanium mangling") + codemzs wrote: > e

[PATCH] D149666: [OpenMP][OMPIRBuilder] Migrate MapCombinedInfoTy from Clang to OpenMPIRBuilder

TIFitis marked 2 inline comments as done. TIFitis added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:6848 + class MapCombinedInfoTy : public llvm::OpenMPIRBuilder::MapCombinedInfoTy { + public: MapExprsArrayTy Exprs; jdoerfert wrote:

[PATCH] D149694: [Clang] Update warning on some designator initializer cases involving unions

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. I think this looks right, and is consistent with guidance from the bug report. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149694/new/ https://reviews.llvm.org/D149694

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

erichkeane added a comment. Missing context in the diff, but the changes since commit are all sensible to me. If this fixes everything we know about, I'm OK with it. Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:344 Innermost->as

[PATCH] D133863: [RISCV] Add MC support of RISCV zcmt Extension

This revision was automatically updated to reflect the committed changes. Closed by commit rG9f0d725744aa: [RISCV] Add MC support of RISCV zcmt Extension (authored by VincentWu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133863/new/ https://revi

[clang] 9f0d725 - [RISCV] Add MC support of RISCV zcmt Extension

Author: WuXinlong Date: 2023-05-03T22:06:37+08:00 New Revision: 9f0d725744aa2f36395fdccd85a2f21b960ff661 URL: https://github.com/llvm/llvm-project/commit/9f0d725744aa2f36395fdccd85a2f21b960ff661 DIFF: https://github.com/llvm/llvm-project/commit/9f0d725744aa2f36395fdccd85a2f21b960ff661.diff LOG

[PATCH] D147875: [clang][Diagnostics] Show line numbers when printing code snippets

PiotrZSL added a comment. Clang-tidy related changes looks fine. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147875/new/ https://reviews.llvm.org/D147875 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[PATCH] D149733: [clang][USR] Prevent crashes on incomplete FunctionDecls

erichkeane added a comment. Hmm... So I don't see us being able to change how we create `FunctionDecl`s, the way we are doing it with a 'build up to the final thing' is about all we can do. However, it should never escape its 'creation' functions without its type set. IF I were to design this

[PATCH] D149110: [HIP] Detect HIP for Ubuntu, Mint, Gentoo, etc.

yaxunl accepted this revision. yaxunl added a comment. LGTM. Thanks. I can help commit this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149110/new/ https://reviews.llvm.org/D149110 ___ cfe-commi

[PATCH] D149460: [analyzer] ArrayBoundCheckerV2: suppress false positives from ctype macros

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149460/new/ https://reviews.llvm.org/D149460 __

[PATCH] D149259: [analyzer][NFC] Use std::optional instead of custom "empty" state

donat.nagy added a comment. @steakhal Could you review this change when you have some time for it? I'm planning to stabilize and de-alpha this checker with a series of incremental changes; and it'd be good have this commit and the unrelated tweak https://reviews.llvm.org/D149460 merged before I

[PATCH] D149733: [clang][USR] Prevent crashes on incomplete FunctionDecls

kadircet added a comment. In D149733#4315360 , @erichkeane wrote: > I don't recall the case of a Null type being valid for functions (perhaps > Aaron does? Or perhaps its an error condition?). But otherwise, I would > expect `FunctionDecl` to have a

[PATCH] D143624: Inlining: Run the legacy AlwaysInliner before the regular inliner.

dmgreen added a comment. It looks like there is quite a lot more optimization that happens to the function being always-inlined (__SSAT) before this change. Through multiple rounds of instcombine, almost to the end of the pass pipeline. The new version runs a lot less before inlining, only runn

[PATCH] D143624: Inlining: Run the legacy AlwaysInliner before the regular inliner.

nikic added a comment. In D143624#4315468 , @dmgreen wrote: > It looks like there is quite a lot more optimization that happens to the > function being always-inlined (__SSAT) before this change. Through multiple > rounds of instcombine, almost to the e

[PATCH] D143624: Inlining: Run the legacy AlwaysInliner before the regular inliner.

mtrofin added a comment. In D143624#4315508 , @nikic wrote: > In D143624#4315468 , @dmgreen wrote: > >> It looks like there is quite a lot more optimization that happens to the >> function being always-inlined (_

[PATCH] D145441: [AMDGPU] Define data layout entries for buffers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf9c1ede2543b: [AMDGPU] Define data layout entries for buffers (authored by krzysz00). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D148381: [WIP][Clang] Add element_count attribute

kees added a comment. This is great! It passes my own testing for the sanitizer too. I'm looking forward to __bdos support. :) FWIW, similar progress is being made on the GCC side: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108896 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D149737: [clang][ExtractAPI] Add semicolon to function declaration fragments

chaitanyav added a comment. @dang @ributzka I missed adding semicolons to function declaration fragments in this commit https://github.com/llvm/llvm-project/commit/afce10c5b60fada1db369d3770f4389da7ef30ef . Please review this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D148822: [clang][BFloat] Avoid redefining bfloat16_t in arm_neon.h

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdb492316399a: [clang][BFloat] Avoid redefining bfloat16_t in arm_neon.h (authored by dim). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] db49231 - [clang][BFloat] Avoid redefining bfloat16_t in arm_neon.h

Author: Dimitry Andric Date: 2023-05-03T17:54:58+02:00 New Revision: db492316399a0edc26788265c7fce78c63a0f838 URL: https://github.com/llvm/llvm-project/commit/db492316399a0edc26788265c7fce78c63a0f838 DIFF: https://github.com/llvm/llvm-project/commit/db492316399a0edc26788265c7fce78c63a0f838.diff

[PATCH] D148767: Restore CodeGen/LowLevelType from `Support`

jobnoorman added a comment. Hi, this seems to have broken my bolt+debug+shared build. I don't think there are build bots for this configuration but you can reproduce it like this: cmake -G Ninja -DCMAKE_BUILD_TYPE="Debug" \ -DLLVM_ENABLE_PROJECTS="clang;lld;bolt" \

[PATCH] D149259: [analyzer][NFC] Use std::optional instead of custom "empty" state

steakhal added a comment. In D149259#4315393 , @donat.nagy wrote: > @steakhal Could you review this change when you have some time for it? I didn't forget about this one. It's in progress, but it's difficult to squeeze this in. The ETA is probably tomo

[PATCH] D145441: [AMDGPU] Define data layout entries for buffers

jplehr added a comment. Hey Krzysztof, I believe this broke the openmp offload buildbot https://lab.llvm.org/buildbot/#/builders/193/builds/30576 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145441/new/ https://reviews.llvm.org/D145441 _

[PATCH] D149758: Revert "[AMDGPU] Define data layout entries for buffers"

krzysz00 created this revision. Herald added subscribers: kosarev, jeroen.dobbelaere, foad, wenlei, okura, kuter, kerbowa, arphaman, zzheng, hiraditya, tpr, dstuttard, yaxunl, jvesely, kzhuravl, arsenm, MatzeB. Herald added a project: All. krzysz00 requested review of this revision. Herald added

[PATCH] D149758: Revert "[AMDGPU] Define data layout entries for buffers"

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3f2fbe92d0f4: Revert "[AMDGPU] Define data layout entries for buff

[PATCH] D148800: [C2x] Update 'nullptr' implementation based on CD comments

aaron.ballman updated this revision to Diff 519102. aaron.ballman added a comment. Updated based on review feedback: - Changed CK_Noop to CK_NullToPointer to model the same as in C++ - Added codegen tests - Added a constant expression test - Fixed some comments in the test file CHANGES SINCE LA

[PATCH] D141714: Fix ast print of variables with attributes

giulianobelinassi added a comment. Hi. See inline answers. I will send the new version in a few minutes. Comment at: clang/lib/AST/DeclPrinter.cpp:52-58 +enum AttrPrintLoc { + SIDE_NONE = 0, + SIDE_LEFT = 1, + SIDE_MIDDLE = 2, + SIDE_RIGHT = 4, + SI

[PATCH] D148767: Restore CodeGen/LowLevelType from `Support`

vzakhari added a comment. In D148767#4315667 , @jobnoorman wrote: > Hi, this seems to have broken my bolt+debug+shared build. I don't think there > are build bots for this configuration but you can reproduce it like this: Same with flang+debug+shared b

[PATCH] D149553: [clang] Use -std=c++23 instead of -std=c++2b

Mordante marked 3 inline comments as done. Mordante added a comment. In D149553#4313211 , @aaron.ballman wrote: > In D149553#4312788 , @Mordante > wrote: > >> In D149553#4310478

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

zahiraam updated this revision to Diff 519121. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146148/new/ https://reviews.llvm.org/D146148 Files: clang/docs/LanguageExtensions.rst clang/include/clang/Basic/Attr.td clang/include/clang/Basic/DiagnosticSemaKinds.td clang/include/clan

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

zahiraam added a comment. (Sorry for taking so long to get to it!) Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146148/new/ https://reviews.llvm.org/D146148 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

alexander-shaposhnikov added a comment. @erichkeane - thanks, then I'm going to give it another try. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146178/new/ https://reviews.llvm.org/D146178 ___ cfe-com

[PATCH] D141714: Fix ast print of variables with attributes

giulianobelinassi updated this revision to Diff 519131. giulianobelinassi added a comment. Incorporate some of Aron suggestions: - Replace isDeclspecAttribute with isStandardAttributeSyntax - Avoid multiple calls to getAsFunction - Use AttrPrintLoc:: instead of referencing the value directly - Al

[PATCH] D149553: [clang] Use -std=c++23 instead of -std=c++2b

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! I did not spot any other concerns beyond the macro value one. Thank you for working on this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149553/new/ https://reviews.llvm.

[clang] 8c22cbe - [analyzer] ArrayBoundCheckerV2: suppress false positives from ctype macros

Author: Donát Nagy Date: 2023-05-03T18:52:27+02:00 New Revision: 8c22cbea87beb74da3dc5891c40cdf574cd5fe56 URL: https://github.com/llvm/llvm-project/commit/8c22cbea87beb74da3dc5891c40cdf574cd5fe56 DIFF: https://github.com/llvm/llvm-project/commit/8c22cbea87beb74da3dc5891c40cdf574cd5fe56.diff LO

[PATCH] D149713: [Sema] Avoid emitting warnings for constant destruction.

rsmith added a comment. I think this would be an interesting test: struct S { /*not constexpr*/ S(); constexpr ~S() {} }; S s; // no warning struct T { /*not constexpr*/ T(); constexpr ~T() { if (b) {} } bool b; }; T t; // expected-warning {{exit-time destructor

[PATCH] D149460: [analyzer] ArrayBoundCheckerV2: suppress false positives from ctype macros

This revision was automatically updated to reflect the committed changes. Closed by commit rG8c22cbea87be: [analyzer] ArrayBoundCheckerV2: suppress false positives from ctype macros (authored by donat.nagy). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D149713: [Sema] Avoid emitting warnings for constant destruction.

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM with the extra test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149713/new/ https://reviews.llvm.org/D149713 ___

[PATCH] D149733: [clang][USR] Prevent crashes on incomplete FunctionDecls

aaron.ballman added subscribers: v.g.vassilev, junaire, rsmith. aaron.ballman added a comment. Adding in some of the clang-repl folks because they are likely to run into this as well, and adding Richard in case he has more historical context. What I understand of the historical context here is t

[PATCH] D149695: MS inline asm: remove obsolete code adding AOK_SizeDirective (e.g. dword ptr)

MaskRay added a comment. In D149695#4315194 , @hans wrote: >> The AOK_SizeDirective part from 5b37c181291210bedfbb7a6af5d51229f3652ef0 >> (2014-08) seems unneeded nowadays (the root cause has likely been fixed >> elsewhere). > > Would it be possible to co

[PATCH] D147626: [clang] Reject flexible array member in a union in C++

aaron.ballman added a comment. In D147626#4315283 , @Fznamznon wrote: > I've got an error from buildbot on Windows: > > C:\Program Files (x86)\Windows > Kits\10\include\10.0.19041.0\um\winioctl.h:13404:51: error: flexible array > member 'Lev1Depends'

[PATCH] D149643: [clang-format] Correctly limit formatted ranges when specifying qualifier alignment

MyDeveloperDay added a comment. Thanks for the patch...this tells me people are starting to use this feature in anger!! i.e. your formatting via git-clang-format (which is brave!) ;-) which means you have the code modifying features perhaps on my default... LGTM, if you will need someone to lan

[PATCH] D149647: [NFC][Clang]Fix static analyzer tool remarks about large copies by value

MyDeveloperDay added a comment. Can you link to the Coverity issue so we can see what it was complaining about? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149647/new/ https://reviews.llvm.org/D149647

[PATCH] D149650: Give NullabilityKind a printing operator<

aaron.ballman added a comment. In D149650#4315211 , @sammccall wrote: > In D149650#4312389 , @aaron.ballman > wrote: > >> I guess I'm not seeing much motivation for this change. We already have >> `clang::getNul

[PATCH] D149647: [NFC][Clang]Fix static analyzer tool remarks about large copies by value

erichkeane added a comment. In D149647#4316134 , @MyDeveloperDay wrote: > Can you link to the Coverity issue so we can see what it was complaining > about? Unfortunately this is from an internal-run of Coverity that Intel is running. I'd be shocked i

[PATCH] D149259: [analyzer][NFC] Use std::optional instead of custom "empty" state

donat.nagy added a comment. > It's gonna be bumpy. Yup :) but it's not impossible... > Also, note that this is in production here, so it will take me time to verify > the patches. So, I'd probably prefer to have a patch stack, and do the > evaluation for some selected patches - basically bundl

[PATCH] D149149: [clang][Interp] Check one-past-the-end pointers in GetPtrField

shafik added a subscriber: rsmith. shafik added inline comments. Comment at: clang/test/AST/Interp/records.cpp:509 constexpr A *a2 = &b + 1; // expected-error {{must be initialized by a constant expression}} \ // expected-note {{cannot access ba

[PATCH] D147626: [clang] Reject flexible array member in a union in C++

efriedma added a comment. > If there's not indications of this being disruptive on non-MSVC-compatible > targets, then we may still be able to get away with rejecting the extension > there. If we need to have the codepath anyway, there isn't much harm in allowing it on all targets, I think. T

[PATCH] D148800: [C2x] Update 'nullptr' implementation based on CD comments

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148800/new/ https://reviews.llvm.org/D148800 ___ cfe-commits mailing list cfe-commi

[PATCH] D147626: [clang] Reject flexible array member in a union in C++

aaron.ballman added a comment. In D147626#4316190 , @efriedma wrote: >> If there's not indications of this being disruptive on non-MSVC-compatible >> targets, then we may still be able to get away with rejecting the extension >> there. > > If we need to

[PATCH] D149647: [NFC][Clang]Fix static analyzer tool remarks about large copies by value

Manna added a comment. Thanks @erichkeane for response. @MyDeveloperDay, Our internal Coverity link won't work without login. This is what Coverity was complaining about. Big parameter passed by value Copying large values is inefficient, consider passing by reference; Low, medium, and high siz

[PATCH] D149193: [Driver] Add -dumpdir and change -gsplit-dwarf .dwo names for linking

dblaikie added a comment. I guess my main question is: What's the motivation for implementing this? Do you have a need/use for this? (it doesn't seem to be motivated by GCC compatibility - as discussed, looks like we're diverging in a bunch of ways from their behavior and the argument made that

[PATCH] D149647: [NFC][Clang]Fix static analyzer tool remarks about large copies by value

MyDeveloperDay added a comment. ok! I'm not a massive lambda expert, but aren't we passing by const reference e.g. `const FormatStyle &Style`, can someone give me a lession as to why it thinks its by value? maybe I'm looking at the wrong "pass by" Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D148665: Change -fsanitize=function to place two words before the function entry

peter.smith added a comment. My apologies for not responding. If I've got this right there are 4 related patches: D148573 (approved) D148785 Use type hashes rather than RTTI D148827 support C

[PATCH] D149647: [NFC][Clang]Fix static analyzer tool remarks about large copies by value

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/Format.cpp:3486-3489 + Expanded.InsertBraces = true; + Passes.emplace_back([&](const Environment &Env) { +return BracesInserter(Env, Expanded).process(/*SkipAnnotation=*/true); }); ---

  1   2   >