[clang] ffe7950 - Reland "[analyzer] Deprecate `-analyzer-store region` flag"

Author: Balazs Benics Date: 2022-06-14T09:20:41+02:00 New Revision: ffe7950ebc62380c3afc7c71f454a1db3f6f5c76 URL: https://github.com/llvm/llvm-project/commit/ffe7950ebc62380c3afc7c71f454a1db3f6f5c76 DIFF: https://github.com/llvm/llvm-project/commit/ffe7950ebc62380c3afc7c71f454a1db3f6f5c76.diff

[PATCH] D126215: [analyzer] Deprecate `-analyzer-store region` flag

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGffe7950ebc62: Reland "[analyzer] Deprecate `-analyzer-store region

[PATCH] D127403: [clangd] Implement semantic token modifier "definition"

ckandeler updated this revision to Diff 436678. ckandeler added a comment. Objective-C improvements. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127403/new/ https://reviews.llvm.org/D127403 Files: clang-tools-extra/clangd/SemanticHighlighting.

[PATCH] D127599: [clang] small speed improvement of Sema::AddArgumentDependentLookupCandidates

whisperity added a comment. The context of the diff is missing. Please re-run the diff making with `-U999`. Comment at: clang/include/clang/Sema/Lookup.h:817 + bool empty(void) { return Decls.empty(); } + using iterator = `(void)`? LLVM is

[PATCH] D127649: [analyzer][NFC][test] Add new RUN line with support-symbolic-integer-casts=true to expr-inspection.cpp

steakhal added inline comments. Comment at: clang/test/Analysis/expr-inspection.cpp:11-13 void clang_analyzer_denote(int x, const char *str); +void clang_analyzer_denote(unsigned x, const char *str); void clang_analyzer_express(int x); Repository: rG LLVM

[PATCH] D127646: [analyzer][NFC][test] Add new RUN lint with support-symbolic-integer-casts=true to svalbuilder-rearrange-comparisons.c

steakhal accepted this revision. steakhal added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/Analysis/svalbuilder-rearrange-comparisons.cpp:16-17 + +template +void clang_analyzer_eval(T x); +template Repository:

[clang] 24bd47d - [analyzer][NFC] Inline AnalyzerOptions::getUserMode()

Author: Balazs Benics Date: 2022-06-14T09:42:58+02:00 New Revision: 24bd47dc172f5dc81de7baac880c55b1e615fa70 URL: https://github.com/llvm/llvm-project/commit/24bd47dc172f5dc81de7baac880c55b1e615fa70 DIFF: https://github.com/llvm/llvm-project/commit/24bd47dc172f5dc81de7baac880c55b1e615fa70.diff

[PATCH] D127486: [analyzer][NFC] Inline AnalyzerOptions::getUserMode()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG24bd47dc172f: [analyzer][NFC] Inline AnalyzerOptions::getUserMode() (authored by steakhal). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D123064: [Clang][C++23] P2071 Named universal character escapes

cor3ntin updated this revision to Diff 436682. cor3ntin marked 12 inline comments as done. cor3ntin added a comment. Regenerate UnicodeNameToCodepointGenerated.cpp to fix the formatting of its header. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D12

[PATCH] D123064: [Clang][C++23] P2071 Named universal character escapes

cor3ntin marked an inline comment as done. cor3ntin added inline comments. Comment at: clang/lib/Lex/Lexer.cpp:3237-3239 + if (C != '{') { +if (Diagnose) + Diag(StartPtr, diag::warn_ucn_escape_incomplete); aaron.ballman wrote: > Is this a case where we

[PATCH] D126291: [flang][Driver] Update link job on windows

rovka updated this revision to Diff 436687. rovka added a comment. Clarified test checks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126291/new/ https://reviews.llvm.org/D126291 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp clang/lib/Driver/ToolChains/CommonArgs.h clang/li

[PATCH] D127638: [clang][sema] Provide better diagnostic for missing template parameters

tbaeder updated this revision to Diff 436690. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127638/new/ https://reviews.llvm.org/D127638 Files: clang/lib/Sema/SemaCXXScopeSpec.cpp clang/test/SemaCXX/nested-name-spec.cpp Index: clang/test/SemaCXX/nested-name-spec.cpp ===

[PATCH] D126291: [flang][Driver] Update link job on windows

mmuetzel added inline comments. Comment at: flang/test/Driver/linker-flags.f90:51 +! MSVC-NOT: libcmt +! MSVC-NOT: oldnames +! MSVC-SAME: "[[object_file]]" Lines 50-51 seem to be duplicates of lines 44-45. Is this intentional? CHANGES SINCE LAST ACTION https:

[PATCH] D126291: [flang][Driver] Update link job on windows

rovka added inline comments. Comment at: flang/test/Driver/linker-flags.f90:51 +! MSVC-NOT: libcmt +! MSVC-NOT: oldnames +! MSVC-SAME: "[[object_file]]" mmuetzel wrote: > Lines 50-51 seem to be duplicates of lines 44-45. Is this intentional? Yes, I don't want tho

[clang] 9da697e - Reland "[analyzer] Deprecate the unused 'analyzer-opt-analyze-nested-blocks' cc1 flag"

Author: Balazs Benics Date: 2022-06-14T10:22:37+02:00 New Revision: 9da697e1bcefda6a75cd63a10679efe51333d7f9 URL: https://github.com/llvm/llvm-project/commit/9da697e1bcefda6a75cd63a10679efe51333d7f9 DIFF: https://github.com/llvm/llvm-project/commit/9da697e1bcefda6a75cd63a10679efe51333d7f9.diff

[PATCH] D127460: Rename GCCBuiltin into ClangBuiltin

GuillaumeGomez added a comment. @efriedma It was falling the tests because of that, which is why I updated it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127460/new/ https://reviews.llvm.org/D127460 _

[PATCH] D123064: [Clang][C++23] P2071 Named universal character escapes

cor3ntin updated this revision to Diff 436703. cor3ntin added a comment. Fix more style issue (variable casing) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123064/new/ https://reviews.llvm.org/D123064 Files: clang/include/clang/Basic/Diagnosti

[PATCH] D127460: Rename GCCBuiltin into ClangBuiltin

RKSimon added inline comments. Comment at: llvm/lib/IR/Function.cpp:1430 +// This defines the "Intrinsic::getIntrinsicForClangBuiltin()" method. #define GET_LLVM_INTRINSIC_FOR_GCC_BUILTIN #include "llvm/IR/IntrinsicImpl.inc" Should this be updated to use GET_LL

[PATCH] D127306: [analyzer] Treat system globals as mutable if they are not const

steakhal updated this revision to Diff 436707. steakhal marked an inline comment as done. steakhal added a comment. - Modify the `GenericTaintChecker::isStdin()` to look through //derived symbols//, to mitigate the effect of invalidations. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D127306: [analyzer] Treat system globals as mutable if they are not const

steakhal requested review of this revision. steakhal added a comment. Please check this again @martong @xazax.hun. I'll also conduct a measurement, investigating what report changes we experience with this change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D125931: [clang][dataflow] Add support for correlated branches to optional model

sgatev updated this revision to Diff 436710. sgatev marked 4 inline comments as done. sgatev added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125931/new/ https://reviews.llvm.org/D125931 Files: clang/include/clan

[PATCH] D127379: [Lex] Keep track of skipped preprocessor blocks and advance the lexer directly if they are revisited

tschuett added a comment. Do you believe an entry in the ReleaseNotes would get this achievement more visibility? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127379/new/ https://reviews.llvm.org/D127379 _

[PATCH] D111548: [Clang] Add the `annotate_type` attribute

mboehme updated this revision to Diff 436713. mboehme added a comment. Change attribute documentation so it's not specific to C++. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111548/new/ https://reviews.llvm.org/D111548 Files: clang/docs/Relea

[PATCH] D126291: [flang][Driver] Update link job on windows

awarzynski added inline comments. Comment at: flang/test/Driver/linker-flags.f90:51 +! MSVC-NOT: libcmt +! MSVC-NOT: oldnames +! MSVC-SAME: "[[object_file]]" rovka wrote: > mmuetzel wrote: > > Lines 50-51 seem to be duplicates of lines 44-45. Is this intentional?

[PATCH] D125291: Introduce @llvm.threadlocal.address intrinsic to access TLS variable

nikic added a comment. In D125291#3548671 , @jyknight wrote: > Anyhow -- I think the prototype I'm fiddling with is also along the path to > the ideal long-term state, but pushing it beyond a prototype seems like it'll > be a pain in the ass due to the

[PATCH] D125931: [clang][dataflow] Add support for correlated branches to optional model

sgatev added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:174 +/// property of the optional value `OptionalVal`. +void setHasValue(StructValue &OptionalVal, BoolValue &HasValueVal) { + OptionalVal.setProperty("has_value",

[PATCH] D127730: Reland "[CodeGen] Keep track info of lazy-emitted symbols in ModuleBuilder"

junaire created this revision. Herald added a project: All. junaire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This reverts commits: d3ddc251acae631bf5ab4da13878f7e8b5b5a451

[PATCH] D126291: [flang][Driver] Update link job on windows

rovka added inline comments. Comment at: flang/test/Driver/linker-flags.f90:51 +! MSVC-NOT: libcmt +! MSVC-NOT: oldnames +! MSVC-SAME: "[[object_file]]" awarzynski wrote: > rovka wrote: > > mmuetzel wrote: > > > Lines 50-51 seem to be duplicates of lines 44-45. I

[PATCH] D126291: [flang][Driver] Update link job on windows

rovka updated this revision to Diff 436722. rovka added a comment. - Use --implicit-not-check <3 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126291/new/ https://reviews.llvm.org/D126291 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp clang/lib/Driver/ToolChains/CommonArgs.h c

[PATCH] D127732: [analyzer][NFC] Remove unused ExprEngine::evalBinOp functions

steakhal created this revision. steakhal added a reviewer: martong. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a project: All. steakhal

[PATCH] D126127: [analyzer][NFC] Relocate unary transfer functions

steakhal updated this revision to Diff 436725. steakhal added a comment. rebase; ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126127/new/ https://reviews.llvm.org/D126127 Files: clang/include/clang/StaticAnalyzer/Core/PathSensitive/SValBui

[PATCH] D127734: [analyzer][NFC] Substitute the SVal::evalMinus and evalComplement functions

steakhal created this revision. steakhal added a reviewer: martong. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a project: All. steakhal

[PATCH] D126891: [clang-tidy] The check should ignore final classes

steakhal added a comment. ping again; @whisperity Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126891/new/ https://reviews.llvm.org/D126891 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[clang] 781ee53 - Reland "[CodeGen] Keep track info of lazy-emitted symbols in ModuleBuilder"

Author: Jun Zhang Date: 2022-06-14T18:36:03+08:00 New Revision: 781ee538da1855876b085989a37ec959e3f2ecd1 URL: https://github.com/llvm/llvm-project/commit/781ee538da1855876b085989a37ec959e3f2ecd1 DIFF: https://github.com/llvm/llvm-project/commit/781ee538da1855876b085989a37ec959e3f2ecd1.diff LOG

[PATCH] D127730: Reland "[CodeGen] Keep track info of lazy-emitted symbols in ModuleBuilder"

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG781ee538da18: Reland "[CodeGen] Keep track info of lazy-emitted symbols in ModuleBuilder" (authored by junaire). Reposito

[PATCH] D126308: cmake: use llvm dir variables for clang/utils/hmaptool

dyung added a comment. Hi @mizvekov, this change seems to have broken the location of the hmaptool when using the Visual Studio builder on Windows. After your commit, 7 clang tests fail because hmaptool cannot be found at the expected location. For example, the test clang/test/Preprocessor/head

[PATCH] D124762: [WinEHPrepare] Avoid truncation of EH funclets with GNUstep ObjC runtime

sgraenitz updated this revision to Diff 436730. sgraenitz added a comment. Update LLVM CodeGen test for mainline opaque pointers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124762/new/ https://reviews.llvm.org/D124762 Files: clang/lib/CodeGen/

[PATCH] D127638: [clang][sema] Provide better diagnostic for missing template parameters

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thanks for the fix! Please add a release note when you land the changes. :-) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127638/new/ https://reviews.llvm.org/D1

[PATCH] D127518: [Diagnostics] Fix inconsistent shift-overflow warnings in C++20

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:11423-11425 + // Don't warn in C++2A mode (and newer), as signed left shifts + // always wrap and never overflow. + if (S.getLangOpts().CPlusPlus20) I think this should also be checki

[clang] d9b8d13 - [NFC][Alignment] Use MaybeAlign in CGCleanup/CGExpr

Author: Guillaume Chatelet Date: 2022-06-14T10:56:36Z New Revision: d9b8d13f8b58086e2c8d5c59be6f79222a07931e URL: https://github.com/llvm/llvm-project/commit/d9b8d13f8b58086e2c8d5c59be6f79222a07931e DIFF: https://github.com/llvm/llvm-project/commit/d9b8d13f8b58086e2c8d5c59be6f79222a07931e.diff

[PATCH] D111548: [Clang] Add the `annotate_type` attribute

mboehme updated this revision to Diff 436732. mboehme marked 2 inline comments as done. mboehme added a comment. Instead of allowing all type attributes on the decl-specifier-seq, allow only `annotate_type` for now. The more general change will be done in https://reviews.llvm.org/D126061. Reposi

[PATCH] D112916: [clang-tidy] Confusable identifiers detection

aaron.ballman added a comment. In D112916#3554181 , @tstellar wrote: > In D112916#3554158 , @Mordante > wrote: > >> In D112916#3113140 , @tstellar >> wrote: >> >>> The L

[PATCH] D111548: [Clang] Add the `annotate_type` attribute

mboehme marked an inline comment as done. mboehme added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:6501 + +The attribute does not have any effect on the semantics of C++ code, neither +type checking rules, nor runtime semantics. In particular:

[PATCH] D127460: Rename GCCBuiltin into ClangBuiltin

GuillaumeGomez added inline comments. Comment at: llvm/lib/IR/Function.cpp:1430 +// This defines the "Intrinsic::getIntrinsicForClangBuiltin()" method. #define GET_LLVM_INTRINSIC_FOR_GCC_BUILTIN #include "llvm/IR/IntrinsicImpl.inc" RKSimon wrote: > Should this

[PATCH] D127379: [Lex] Keep track of skipped preprocessor blocks and advance the lexer directly if they are revisited

tambre added a comment. In D127379#3581009 , @tschuett wrote: > Do you believe an entry in the ReleaseNotes would get this achievement more > visibility? I second that this would be worthy of a release note. Seems like quite a big improvement. I wonde

[PATCH] D125931: [clang][dataflow] Add support for correlated branches to optional model

ymandel added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:174 +/// property of the optional value `OptionalVal`. +void setHasValue(StructValue &OptionalVal, BoolValue &HasValueVal) { + OptionalVal.setProperty("has_value"

[clang] de6ba97 - [analyzer][Casting] Support isa, cast, dyn_cast of SVals

Author: Balazs Benics Date: 2022-06-14T13:43:04+02:00 New Revision: de6ba9704d0b4fa047a030b5bf369e425b937198 URL: https://github.com/llvm/llvm-project/commit/de6ba9704d0b4fa047a030b5bf369e425b937198 DIFF: https://github.com/llvm/llvm-project/commit/de6ba9704d0b4fa047a030b5bf369e425b937198.diff

[PATCH] D125709: [analyzer][Casting] Support isa, cast, dyn_cast of SVals

This revision was automatically updated to reflect the committed changes. Closed by commit rGde6ba9704d0b: [analyzer][Casting] Support isa, cast, dyn_cast of SVals (authored by steakhal). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125709/new/ htt

[clang] 44f0a26 - Revert "Reland "[CodeGen] Keep track info of lazy-emitted symbols in ModuleBuilder""

Author: Jun Zhang Date: 2022-06-14T19:53:17+08:00 New Revision: 44f0a2658d22ffc12bac6ca2c8f4a3d98603ea3a URL: https://github.com/llvm/llvm-project/commit/44f0a2658d22ffc12bac6ca2c8f4a3d98603ea3a DIFF: https://github.com/llvm/llvm-project/commit/44f0a2658d22ffc12bac6ca2c8f4a3d98603ea3a.diff LOG

[PATCH] D126479: [Clang] Allow 'Complex float __attribute__((mode(HC)))'

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/TargetInfo.h:223-224 unsigned HasAlignMac68kSupport : 1; - unsigned RealTypeUsesObjCFPRet : 3; + unsigned RealTypeUsesObjCFPRet : (1 << (int)FloatModeKind::Float) | +

[PATCH] D127641: [clang-cl][MSVC] Add default /Zc conformance arguments

hans added inline comments. Comment at: clang/test/Driver/cl-zc.cpp:98 // thread safe statics are off for versions < 19. // RUN: %clang_cl /c -### -fms-compatibility-version=18 -- %s 2>&1 | FileCheck -check-prefix=NoThreadSafeStatics %s // RUN: %clang_cl /Zc:threadSafeInit /Z

[PATCH] D126061: [clang] Reject non-declaration C++11 attributes on declarations

aaron.ballman accepted this revision. aaron.ballman added a comment. Only thing left for me are the nits I pointed out in the last review, otherwise I think this is all set. Giving my LG because I don't think we need another round of review for those nits unless you want it C

[PATCH] D126682: [Interpreter][ClangRepl] Implement undo command

v.g.vassilev added reviewers: sgraenitz, lhames, rjmccall. v.g.vassilev added a comment. Herald added a subscriber: StephenFan. I think we are in a good shape to broaden the list of reviewers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126682/new

[PATCH] D126620: [clang] AST/Print: honor AlwaysIncludeTypeForTemplateArgument policy

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. Let's move forward with this and rely on eventual post-commit review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126620/new/ http

[PATCH] D112916: [clang-tidy] Confusable identifiers detection

serge-sans-paille updated this revision to Diff 436739. serge-sans-paille marked an inline comment as done. serge-sans-paille added a comment. Take into account @aaron.ballman review CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112916/new/ https://reviews.llvm.org/D112916 Files: cla

[PATCH] D125669: Adding support for target in_reduction

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:5035-5039 +llvm::APInt TrueOrFalse(32, +S.hasClausesOfKind() ? 0 : 1); +IntegerLiteral IfCond(getContext(), TrueOrFalse, + getContext().getI

[PATCH] D127518: [Diagnostics] Fix inconsistent shift-overflow warnings in C++20

xgupta updated this revision to Diff 436746. xgupta added a comment. . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127518/new/ https://reviews.llvm.org/D127518 Files: clang/lib/Sema/SemaExpr.cpp clang/test/CXX/expr/expr.const/p2-0x.cpp clang/test/SemaCXX/constant-expression-cxx

[PATCH] D111548: [Clang] Add the `annotate_type` attribute

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for this! I did find one small formatting issue in the release notes, but you can fix that up when landing. Comment at: clang/docs/ReleaseNotes

[PATCH] D126291: [flang][Driver] Update link job on windows

awarzynski added inline comments. Comment at: flang/test/Driver/linker-flags.f90:51 +! MSVC-NOT: libcmt +! MSVC-NOT: oldnames +! MSVC-SAME: "[[object_file]]" rovka wrote: > awarzynski wrote: > > rovka wrote: > > > mmuetzel wrote: > > > > Lines 50-51 seem to be du

[PATCH] D125094: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7625e01d6616: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records (authored by pratlucas). Repository: rG LLVM Github Monorep

[clang] 7625e01 - [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records

Author: Lucas Prates Date: 2022-06-14T13:37:51+01:00 New Revision: 7625e01d661644a560884057755d48a0da8b77b4 URL: https://github.com/llvm/llvm-project/commit/7625e01d661644a560884057755d48a0da8b77b4 DIFF: https://github.com/llvm/llvm-project/commit/7625e01d661644a560884057755d48a0da8b77b4.diff

[PATCH] D127201: [clang] Add tests for statement expression in initializers

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! (The precommit CI failures appear to be unrelated to the changes in this patch.) Thanks for the additional test coverage! Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D126183: Implement soft reset of the diagnostics engine.

tapaswenipathak updated this revision to Diff 436750. tapaswenipathak edited the summary of this revision. tapaswenipathak added a comment. Addresses review comment by @v.g.vassilev. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126183/new/ https:/

[PATCH] D126061: [clang] Reject non-declaration C++11 attributes on declarations

mboehme marked 11 inline comments as done. mboehme added a comment. In D126061#3581350 , @aaron.ballman wrote: > Only thing left for me are the nits I pointed out in the last review, > otherwise I think this is all set. Thanks for the quick turnaround!

[clang] 6a6484c - [OpenMP] Fix offload packager not writing to temps correctly

Author: Joseph Huber Date: 2022-06-14T09:16:28-04:00 New Revision: 6a6484c666ed037f20126c4275e70b02807e09f8 URL: https://github.com/llvm/llvm-project/commit/6a6484c666ed037f20126c4275e70b02807e09f8 DIFF: https://github.com/llvm/llvm-project/commit/6a6484c666ed037f20126c4275e70b02807e09f8.diff

[PATCH] D127673: [OpenMP] Fix offload packager not writing to temps correctly

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6a6484c666ed: [OpenMP] Fix offload packager not writing to temps correctly (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D111548: [Clang] Add the `annotate_type` attribute

mboehme updated this revision to Diff 436764. mboehme marked an inline comment as done. mboehme added a comment. Fixed syntax error in ReleaseNotes.rst. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111548/new/ https://reviews.llvm.org/D111548 Fil

[PATCH] D111548: [Clang] Add the `annotate_type` attribute

mboehme marked an inline comment as done. mboehme added inline comments. Comment at: clang/docs/ReleaseNotes.rst:349 +- Added the `clang::annotate_type` attribute, which can be used to add + annotations to types (see documentation for details). aaron.ballman w

[PATCH] D126534: [analyzer] Deadstore static analysis: Fix false positive on C++17 assignments

frederic-tingaud-sonarsource updated this revision to Diff 436766. frederic-tingaud-sonarsource added a comment. Update diagnostic location to highlight the whole content of the initialization. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126534/new/ https://reviews.llvm.org/D126534 F

[PATCH] D125094: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records

RKSimon added a comment. @pratlucas I'm seeing errors on my EXPENSIVE_CHECKS builds - please can you take a look? Command Output (stdout): -- $ ":" "RUN: at line 1" $ "e:\llvm\ninja\bin\llc.exe" "-mtriple" "thumb-arm-none-eabi" "-filetype" "asm" "-o" "-" "E:\llvm\llvm-project\llvm\test\

[PATCH] D127742: [analyzer][NFC] Prefer using isa<> instead getAs<> in conditions

steakhal created this revision. steakhal added reviewers: martong, NoQ. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a project: All. steak

[PATCH] D125094: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records

pratlucas added a comment. The newly added `frame-chain.ll` test uncovered an issue with an invalid use of the tMOVr instruction, which is only available from V6 onwards. The failure was captured by a buildbot with expensive checks enabled. The issue is unrelated to the codegen changes from this

[PATCH] D125094: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records

RKSimon added a comment. Cheers! Are you looking at a fix or please can you raise a ticket? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125094/new/ https://reviews.llvm.org/D125094 ___ cfe-commits mail

[PATCH] D127518: [Diagnostics] Fix inconsistent shift-overflow warnings in C++20

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land.

[PATCH] D127518: [Diagnostics] Fix inconsistent shift-overflow warnings in C++20

aaron.ballman added a comment. LGTM! Please add a release note about the issue that was fixed when landing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127518/new/ https://reviews.llvm.org/D127518 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D125094: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records

pratlucas added a comment. @RKSimon I was writting my comment above just before I saw your message, lucky they went in in the correct order :) I'm tracking down the source of the invalid `tMOVr` and I'll raise a ticket with the details. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D125749: [analyzer][NFC] Introduce SVal::isa

steakhal abandoned this revision. steakhal added a comment. We don't have the consensus to make me confident in landing this change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125749/new/ https://reviews.llvm.org/D125749 ___

[PATCH] D127454: [OpenMP] Initial parsing and sema for 'parallel masked' construct

ABataev added inline comments. Comment at: clang/include/clang-c/Index.h:2641 */ - CXCursor_TranslationUnit = 300, + CXCursor_TranslationUnit = 350, Does this change affect anything else in the compiler? Comment at: clang/include/clang/

[PATCH] D127460: Rename GCCBuiltin into ClangBuiltin

GuillaumeGomez updated this revision to Diff 436774. GuillaumeGomez added a comment. Update #define as well Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127460/new/ https://reviews.llvm.org/D127460 Files: clang/lib/CodeGen/CGBuiltin.cpp llvm/

Re: [clang] d4bcb45 - [MC][re-land] Omit DWARF unwind info if compact unwind is present where eligible

Ack. The only change in this case was moving llvm/test/MC/MachO/emit-dwarf-unwind.s to llvm/test/MC/MachO/AArch64/emit-dwarf-unwind.s. Will include it in the commit message in the future. From: David Blaikie Sent: Monday, June 13, 2022 5:01 PM To: Jez Ng ; Jez N

[PATCH] D127460: Rename GCCBuiltin into ClangBuiltin

GuillaumeGomez added a comment. I applied the changes suggested by @RKSimon and @efriedma. Comment at: llvm/include/llvm/ADT/Triple.h:1031 /// @} /// @name Static helpers for IDs. /// @{ ldionne wrote: > Comment applies to `test_demangle.pass.cpp` (it'

[PATCH] D126061: [clang] Reject non-declaration C++11 attributes on declarations

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Comment at: clang/include/clang/Basic/AttributeCommonInfo.h:153 // FIXME: Use a better mechanism to determine this. +// We use this in `isCXX11Attribute` below, so it _should_ only return +/

[PATCH] D127460: Rename GCCBuiltin into ClangBuiltin

RKSimon added inline comments. Comment at: llvm/utils/TableGen/IntrinsicEmitter.cpp:883 void IntrinsicEmitter::EmitIntrinsicToBuiltinMap( const CodeGenIntrinsicTable &Ints, bool IsGCC, raw_ostream &OS) { + StringRef CompilerName = (IsGCC ? "Clang" : "MS");

[PATCH] D127460: Rename GCCBuiltin into ClangBuiltin

GuillaumeGomez updated this revision to Diff 436778. GuillaumeGomez added a comment. Rename `IsGCC` function parameter into `IsClang` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127460/new/ https://reviews.llvm.org/D127460 Files: clang/lib/Cod

[PATCH] D127460: Rename GCCBuiltin into ClangBuiltin

GuillaumeGomez added a comment. Applied @RKSimon's suggestion. Comment at: llvm/utils/TableGen/IntrinsicEmitter.cpp:883 void IntrinsicEmitter::EmitIntrinsicToBuiltinMap( const CodeGenIntrinsicTable &Ints, bool IsGCC, raw_ostream &OS) { + StringRef CompilerName = (IsGCC ?

[PATCH] D126984: [clang] Add support for optimize function attribute

aaron.ballman added a comment. In D126984#3579842 , @jdoerfert wrote: > In D126984#3571573 , @aeubanks > wrote: > >> IIRC in the past there was a strong preference to not have the pass manager >> support this so

[clang] 48e1829 - [Diagnostics] Fix inconsistent shift-overflow warnings in C++20

Author: Shivam Gupta Date: 2022-06-14T20:19:46+05:30 New Revision: 48e1829874df15fd57e731d4824604f28e177585 URL: https://github.com/llvm/llvm-project/commit/48e1829874df15fd57e731d4824604f28e177585 DIFF: https://github.com/llvm/llvm-project/commit/48e1829874df15fd57e731d4824604f28e177585.diff

[PATCH] D127518: [Diagnostics] Fix inconsistent shift-overflow warnings in C++20

xgupta closed this revision. xgupta added a comment. In D127518#3581620 , @aaron.ballman wrote: > LGTM! Please add a release note about the issue that was fixed when landing. Done, Thank you for reviewing. Committed in https://reviews.llvm.org/rG48e18

[PATCH] D127544: Add no_sanitize('hwaddress') (and 'memtag', but that's a no-op).

aaron.ballman added a comment. Thank you for this, can you also add a release note for the fix? Comment at: clang/lib/Sema/SemaDeclAttr.cpp:8849 break; - // HLSL attributes: Spurious whitespace change? Comment at: clang/test/CodeGen

[PATCH] D127745: [clang][dataflow] Rename `getPointeeLoc` to `getReferencePointeeLoc` and `getPointerPointeeLoc` respectively for ReferenceValue and PointerValue.

wyt created this revision. Herald added subscribers: tschuett, steakhal, xazax.hun. Herald added a project: All. wyt requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We distinguish between getting pointee location for `ReferenceValue` and `

[PATCH] D127746: [clang][dataflow] Convert `PointeeLoc` of PointerValue from reference to pointer. This allows PointeeLoc to be empty in the case of `nullptr`

wyt created this revision. Herald added subscribers: tschuett, steakhal, xazax.hun. Herald added a project: All. wyt requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Depends On D127745 Repository: rG LL

[clang] 6117784 - [NFC] Remove unused function parameter

Author: Serge Pavlov Date: 2022-06-14T22:00:59+07:00 New Revision: 6117784c5f2b70d0adb71afb50903f2dc457996a URL: https://github.com/llvm/llvm-project/commit/6117784c5f2b70d0adb71afb50903f2dc457996a DIFF: https://github.com/llvm/llvm-project/commit/6117784c5f2b70d0adb71afb50903f2dc457996a.diff

[PATCH] D127748: Adds a warning for aligned new in MSVC before C++17

luken-google created this revision. Herald added a project: All. luken-google requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. MSVC requires C++17 to support aligned new and defining the macro __cpp_aligned_new. Clang does not, which could r

[PATCH] D127683: Adds a warning for aligned new in MSVC before C++17

luken-google abandoned this revision. luken-google added a comment. Mistakenly updated change here: https://reviews.llvm.org/D127748 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127683/new/ https://reviews.llvm.org/D127683 ___

[PATCH] D127306: [analyzer] Treat system globals as mutable if they are not const

martong added a comment. In D127306#3580981 , @steakhal wrote: > - Modify the `GenericTaintChecker::isStdin()` to look through //derived > symbols//, to mitigate the effect of invalidations. So, the taint property is still not propagated by the engine a

[PATCH] D127749: [clangd] Wire up compilation for style blocks

kadircet created this revision. kadircet added a reviewer: adamcz. Herald added subscribers: usaxena95, arphaman. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repos

[PATCH] D126984: [clang] Add support for optimize function attribute

xbolva00 added a comment. In D126984#3581708 , @aaron.ballman wrote: > In D126984#3579842 , @jdoerfert > wrote: > >> In D126984#3571573 , @aeubanks >> wrote: >> >>> IIR

[PATCH] D127749: [clangd] Wire up compilation for style blocks

adamcz accepted this revision. adamcz added a comment. This revision is now accepted and ready to land. Wait, what? How? Whaaat? How did that happen? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127749/new/ https://reviews.llvm.org/D12774

[PATCH] D126479: [Clang] Allow 'Complex float __attribute__((mode(HC)))'

tahonermann added inline comments. Comment at: clang/include/clang/Basic/TargetInfo.h:223-224 unsigned HasAlignMac68kSupport : 1; - unsigned RealTypeUsesObjCFPRet : 3; + unsigned RealTypeUsesObjCFPRet : (1 << (int)FloatModeKind::Float) | + (

[PATCH] D125723: [MSVC] Add support for MSVC pragma optimize

xbolva00 added a comment. In D125723#3547789 , @rnk wrote: > I think it's fine to implement this, but I wanted to share some of the > motivation for the current state of things. In our experience, the majority > of uses of pragma optimize were to work a

  1   2   3   >