[PATCH] D124570: Revert "[analyzer][NFC] Refactor GenericTaintChecker to use CallDescriptionMap"

steakhal added a comment. In D124570#3480996 , @t-rasmud wrote: > Abandoning this patch because it was a downstream problem and I incorrectly > diagnosed it on the open source branch. Oh, I see. Yeey, so it's still an NFC :D Repository: rG LLVM Gith

[PATCH] D119544: Deferred Concept Instantiation Implementation

ChuanqiXu added a comment. Oh, I'm busy with coroutines these days. Thanks for reminding me for this. LGTM to me basically. Only comments for style left. Comment at: clang/lib/Sema/SemaConcept.cpp:70 +assert((!LHS.isInvalid() && !RHS.isInvalid()) && "not good expressions?"

[clang] db1cec3 - [X86] Fix CodeGen Module Flag for -mibt-seal

Author: Joao Moreira Date: 2022-04-29T15:37:28+08:00 New Revision: db1cec371c00722ce42683e0dc8a2021186332c5 URL: https://github.com/llvm/llvm-project/commit/db1cec371c00722ce42683e0dc8a2021186332c5 DIFF: https://github.com/llvm/llvm-project/commit/db1cec371c00722ce42683e0dc8a2021186332c5.diff

[PATCH] D118052: [X86] Fix CodeGen Module Flag for -mibt-seal

This revision was automatically updated to reflect the committed changes. Closed by commit rGdb1cec371c00: [X86] Fix CodeGen Module Flag for -mibt-seal (authored by joaomoreira, committed by pengfei). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118

[PATCH] D118052: [X86] Fix CodeGen Module Flag for -mibt-seal

pengfei added a comment. In D118052#3480564 , @joaomoreira wrote: > I think there are no more untied knots... @pengfei, do you think this is > ready to merge? If yes, can you please merge it? tks! Sure. Repository: rG LLVM Github Monorepo CHANGES

[clang] 4e545bd - [SimplifyCFG] Thread branches on same condition in more cases (PR54980)

Author: Nikita Popov Date: 2022-04-29T09:44:05+02:00 New Revision: 4e545bdb355a470d601e9bb7f7b2693c99e61a3e URL: https://github.com/llvm/llvm-project/commit/4e545bdb355a470d601e9bb7f7b2693c99e61a3e DIFF: https://github.com/llvm/llvm-project/commit/4e545bdb355a470d601e9bb7f7b2693c99e61a3e.diff

[PATCH] D124159: [SimplifyCFG] Thread branches on same condition in more cases (PR54980)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4e545bdb355a: [SimplifyCFG] Thread branches on same condition in more cases (PR54980) (authored by nikic). Herald added a project: clang. Herald adde

[PATCH] D124621: CPP-2461 [Analyzer] Fix assumptions about const field with member-initializer

mantognini created this revision. Herald added subscribers: manas, steakhal, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: All. mantognini added reviewers: dcoughlin, NoQ, r.stahl, xazax.hun. manto

[PATCH] D124658: CSA Normalize SymIntExpr so the RHS is positive when possible

tomasz-kaminski-sonarsource created this revision. tomasz-kaminski-sonarsource added reviewers: vsavchenko, NoQ, steakhal. Herald added a subscriber: martong. Herald added a project: All. tomasz-kaminski-sonarsource requested review of this revision. Herald added a project: clang. Herald added a su

[PATCH] D124658: CSA Normalize SymIntExpr so the RHS is positive when possible

tomasz-kaminski-sonarsource added a comment. Without the changes, out of the following unsatisfiable conditions: A) `(l - 1000) > 0` B) `l > 1000` C) `l > 1000L` D) `(l + 0L) > 1000` CSA was considering A and B to satisable. The `l` is `(long)(x + 1 - 10U)` and `x` is in range `[10, 100]` so no o

[PATCH] D124638: [clang] Track how headers get included generally during lookup time

jansvoboda11 requested changes to this revision. jansvoboda11 added a comment. This revision now requires changes to proceed. Can you describe how come the check is not reliable without this patch? It might be worth fixing the underlying reason for the unreliability first. Com

[PATCH] D124638: [clang] Track how headers get included generally during lookup time

tschuett added inline comments. Comment at: clang/lib/Lex/HeaderSearch.cpp:1036 + +// This file is a system header or C++ unfriendly if the dir is. HFI.DirInfo = CurDir->getDirCharacteristic(); Why did the comment move? Repository: rG LLVM Github Mon

[PATCH] D124659: [analyzer][docs] Document alpha.security.cert.pos.34c limitations

steakhal created this revision. steakhal added reviewers: martong, NoQ. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a project: All. steakhal requested review of this revisio

[PATCH] D124659: [analyzer][docs] Document alpha.security.cert.pos.34c limitations

steakhal added a comment. PS: the html docs compile and look great. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124659/new/ https://reviews.llvm.org/D124659 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D124621: CPP-2461 [Analyzer] Fix assumptions about const field with member-initializer

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. LGTM In D124621#3481906 , @mantognini wrote: > One thing I'm not sure about and couldn't easily find in the doc is how to > reference in the com

[PATCH] D124621: CPP-2461 [Analyzer] Fix assumptions about const field with member-initializer

steakhal added a comment. Noq wrote https://github.com/llvm/llvm-project/issues/47878#issuecomment-981036634 > Aha, uhm, yeah, i see. The static analyzer indeed thinks that a combination > of "const" and a field initializer causes the field to forever stay that way. > **We'll need to undo this

[PATCH] D103096: [analyzer] Implement cast for ranges of symbolic integers

martong added a comment. Giving it some more thought, the `SymCastMap = Map` should be keyed as well with an equivalence class : `SymCastMap = Map`. This is the only way to use the equivalence info correctly when we process the casts. Comment at: clang/lib/StaticAnalyzer/Cor

[PATCH] D124613: In MSVC compatibility mode, friend function declarations behave as function declarations

frederic-tingaud-sonarsource added a comment. @rnk I don't have the rights to merge. Could you do it when you have the time? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124613/new/ https://reviews.llvm.org/D124613 ___

[PATCH] D124659: [analyzer][docs] Document alpha.security.cert.pos.34c limitations

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124659/new/ https://reviews.llvm.org/D124659

[PATCH] D124164: [include-cleaner] Include-cleaner library structure, and simplistic AST walking.

sammccall marked 2 inline comments as done. sammccall added inline comments. Comment at: clang-tools-extra/include-cleaner/lib/WalkAST.cpp:18 +class ASTWalker : public RecursiveASTVisitor { + DeclCallback Callback; + CJ-Johnson wrote: > Apologies for my ignoranc

[clang] 41ac245 - [include-cleaner] Include-cleaner library structure, and simplistic AST walking.

Author: Sam McCall Date: 2022-04-29T11:04:11+02:00 New Revision: 41ac245c10fc256c96c45cb874918a3bd5665369 URL: https://github.com/llvm/llvm-project/commit/41ac245c10fc256c96c45cb874918a3bd5665369 DIFF: https://github.com/llvm/llvm-project/commit/41ac245c10fc256c96c45cb874918a3bd5665369.diff LO

[PATCH] D124164: [include-cleaner] Include-cleaner library structure, and simplistic AST walking.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rG41ac245c10fc: [include-cleaner] Include-cleaner library structure, and simplistic AST walking. (authored

[PATCH] D121838: Generalize "check-all" umbrella targets, use for check-clang-tools

sammccall updated this revision to Diff 425995. sammccall added a comment. re-trigger CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121838/new/ https://reviews.llvm.org/D121838 Files: clang-tools-extra/CMakeLists.txt clang-tools-extra/test/

[PATCH] D103096: [analyzer] Implement cast for ranges of symbolic integers

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1289-1291 + auto It = llvm::find_if(*CM, [MinBitWidth](CastMap::value_type &Item) { +return Item.first >= MinBitWidth; + }); There might be a pro

[PATCH] D123763: [randstruct] Enforce using a designated init for a randomized struct

stuij added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:2171 if (Field == FieldEnd) { // We've run out of fields. We're done. @void Unfortunately this end of fields check will break the non-designated initializer check below. I GDB'ed

[PATCH] D124666: In MSVC compatibility mode, handle unqualified templated base class initialization

frederic-tingaud-sonarsource created this revision. frederic-tingaud-sonarsource added a reviewer: rnk. Herald added a project: All. frederic-tingaud-sonarsource requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Before C++20, MSVC was support

[PATCH] D124556: [NFC] Prevent shadowing a variable declared in `if`

ken-matsui added a comment. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124556/new/ https://reviews.llvm.org/D124556 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D124667: [flang][driver] Add support for consuming LLVM IR/BC files

awarzynski created this revision. awarzynski added reviewers: rovka, kiranchandramohan, Leporacanthicus, unterumarmung, ekieri. Herald added a subscriber: mgorny. Herald added a reviewer: sscalpone. Herald added projects: Flang, All. awarzynski requested review of this revision. Herald added subsc

[PATCH] D124164: [include-cleaner] Include-cleaner library structure, and simplistic AST walking.

RKSimon added a comment. @sammccall It looks like this is causing a link error on some PPC builds: https://lab.llvm.org/buildbot/#/builders/57/builds/17387 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124164/new/ https://reviews.llvm.org/D124164

[clang-tools-extra] 97b6c92 - [include-cleaner] Add missing deps from unittests

Author: Sam McCall Date: 2022-04-29T13:08:28+02:00 New Revision: 97b6c92dcd56937bc27de7c4c08381fc71c402e7 URL: https://github.com/llvm/llvm-project/commit/97b6c92dcd56937bc27de7c4c08381fc71c402e7 DIFF: https://github.com/llvm/llvm-project/commit/97b6c92dcd56937bc27de7c4c08381fc71c402e7.diff LO

[PATCH] D124164: [include-cleaner] Include-cleaner library structure, and simplistic AST walking.

sammccall added a comment. In D124164#3482261 , @RKSimon wrote: > @sammccall It looks like this is causing a link error on some PPC builds: > https://lab.llvm.org/buildbot/#/builders/57/builds/17387 Thanks, added missing deps in 97b6c92dcd56937bc27de7c4

[PATCH] D123544: [randstruct] Automatically randomize a structure of function pointers

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123544/new/ https://reviews.llvm.org/D123544 _

[PATCH] D124658: [analyzer] Canonicalize SymIntExpr so the RHS is positive when possible

steakhal added a comment. It looks good at first glance. For the review, it would be nice to see which `clang_analyzer_dumps` and `reachables` change with the patch. Could you mark the ones which have different results depending on whether you apply your fix or not? E.g put a `no-warning` where

[PATCH] D122895: [C89/C2x] Improve diagnostics around strict prototypes in C

aaron.ballman added a comment. In D122895#3481564 , @manojgupta wrote: > Some of our users are not very happy with the churn probably caused by this > change where the declaration has the "void" argument but the later definition > does not have explici

[PATCH] D124666: In MSVC compatibility mode, handle unqualified templated base class initialization

frederic-tingaud-sonarsource updated this revision to Diff 426021. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124666/new/ https://reviews.llvm.org/D124666 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Sema/SemaDeclCXX.cpp clang/test/SemaTemplate/ms-unqualifie

[PATCH] D124669: [flang][driver] Add support for -save-temps

awarzynski created this revision. awarzynski added reviewers: rovka, kiranchandramohan, Leporacanthicus, unterumarmung, ekieri, schweitz, jeanPerier, peixin, shraiysh. Herald added a reviewer: sscalpone. Herald added projects: Flang, All. awarzynski requested review of this revision. Herald added

[PATCH] D124666: In MSVC compatibility mode, handle unqualified templated base class initialization

frederic-tingaud-sonarsource updated this revision to Diff 426022. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124666/new/ https://reviews.llvm.org/D124666 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Sema/SemaDeclCXX.cpp clang/test/SemaTemplate/ms-unqualifie

[PATCH] D124634: ExtractAPI: Use %clang_cc1 and -verify in enum.c

dang accepted this revision. dang added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124634/new/ https://reviews.llvm.org/D124634 ___ cf

[PATCH] D123924: [clang-apply-replacements] Added an option to ignore insert conflict.

aaron.ballman added a comment. I don't know enough about this code base to feel comfortable signing off on it, but the changes look reasonable to me FWIW. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123924/new/ https://reviews.llvm.org/D123924 ___

[PATCH] D124434: [Clang][Test] Run tests in C++14 mode explicitly.

aaron.ballman added a comment. In D124434#3480915 , @dblaikie wrote: > I guess coming back to your other point about restructing the way all this > testing works (be a pity to gate the default change on this work as it sounds > like a big project) - yea

[PATCH] D124658: [analyzer] Canonicalize SymIntExpr so the RHS is positive when possible

martong added a comment. > This avoid producing very large RHS in case when the symbol is cased to > unsigned number, and as consequence makes the value more robust in presence > of cast. Could you please elaborate on this? I understand that you'd like to simplify certain binary operations by

[PATCH] D124534: Add a diagnostic for line directive of a gnu extension

aaron.ballman added a comment. In D124534#3481264 , @ken-matsui wrote: > Hi, @aaron.ballman > > Thanks for your kind reviews! > I’ve updated the code, but is this what you’d expected? It looks like the precommit CI pipeline can't test your patch -- I th

[PATCH] D123460: [OpenMP] Make generating offloading entries more generic

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG643c9b22ef52: [OpenMP] Make generating offloading entries more generic (authored by jhuber6). Changed prior to commit: https://reviews.llvm.org/D1

[clang] 643c9b2 - [OpenMP] Make generating offloading entries more generic

Author: Joseph Huber Date: 2022-04-29T09:14:31-04:00 New Revision: 643c9b22ef527be8532d7b75ccf64180fa060339 URL: https://github.com/llvm/llvm-project/commit/643c9b22ef527be8532d7b75ccf64180fa060339 DIFF: https://github.com/llvm/llvm-project/commit/643c9b22ef527be8532d7b75ccf64180fa060339.diff

[clang] ca6bbe0 - [OpenMP] Make clang argument handling for the new driver more generic

Author: Joseph Huber Date: 2022-04-29T09:14:35-04:00 New Revision: ca6bbe008512c9dc6a1ac242466a9d42288daff8 URL: https://github.com/llvm/llvm-project/commit/ca6bbe008512c9dc6a1ac242466a9d42288daff8 DIFF: https://github.com/llvm/llvm-project/commit/ca6bbe008512c9dc6a1ac242466a9d42288daff8.diff

[clang] 4e2b5a6 - [Clang] Make enabling the new driver more generic

Author: Joseph Huber Date: 2022-04-29T09:14:39-04:00 New Revision: 4e2b5a6693e299fcb8671d4dbb69c993d181b29f URL: https://github.com/llvm/llvm-project/commit/4e2b5a6693e299fcb8671d4dbb69c993d181b29f DIFF: https://github.com/llvm/llvm-project/commit/4e2b5a6693e299fcb8671d4dbb69c993d181b29f.diff

[PATCH] D123313: [OpenMP] Make clang argument handling for the new driver more generic

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGca6bbe008512: [OpenMP] Make clang argument handling for the new driver more generic (authored by jhuber6). Repository: rG LLVM Github Monorepo CH

[clang] c5e5b54 - [CUDA] Add driver support for compiling CUDA with the new driver

Author: Joseph Huber Date: 2022-04-29T09:14:44-04:00 New Revision: c5e5b54350fecd4b44c60eb4e982c13de5307aee URL: https://github.com/llvm/llvm-project/commit/c5e5b54350fecd4b44c60eb4e982c13de5307aee DIFF: https://github.com/llvm/llvm-project/commit/c5e5b54350fecd4b44c60eb4e982c13de5307aee.diff

[PATCH] D123325: [Clang] Make enabling the new driver more generic

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4e2b5a6693e2: [Clang] Make enabling the new driver more generic (authored by jhuber6). Changed prior to commit: https://reviews.llvm.org/D123325?v

[PATCH] D120272: [CUDA] Add driver support for compiling CUDA with the new driver

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc5e5b54350fe: [CUDA] Add driver support for compiling CUDA with the new driver (authored by jhuber6). Changed prior to commit: https://reviews.llv

[PATCH] D123773: [clang][analyzer][ctu] Make CTU a two phase analysis

martong updated this revision to Diff 426037. martong added a comment. - Add more explanatory comments to the values of ctu-phase1-inlining - Fix typo in comments in ctu-on-demand-parsing tests - Remove stale comment, config options are desribed elsewhere Repository: rG LLVM Github Monorepo C

[PATCH] D111548: [Clang] Add the `annotate_type` attribute

mboehme added inline comments. Comment at: clang/test/SemaCXX/annotate-type.cpp:2 +// RUN: %clang_cc1 %s -std=c++17 -fsyntax-only -verify + +struct S1 { aaron.ballman wrote: > mboehme wrote: > > aaron.ballman wrote: > > > mboehme wrote: > > > > aaron.ballman wrot

[PATCH] D116280: [clang] adds unary type trait checks as compiler built-ins

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM modulo whatever changes are needed based on feedback from the original review (I noticed Richard has some suggestions there which may impact this review). Repository: rG

[clang] 23c10e8 - [clang] Eliminate TypeProcessingState::trivial.

Author: Martin Boehme Date: 2022-04-29T15:34:30+02:00 New Revision: 23c10e8d0f97dc38c9f620541c7f3ffd04bef905 URL: https://github.com/llvm/llvm-project/commit/23c10e8d0f97dc38c9f620541c7f3ffd04bef905 DIFF: https://github.com/llvm/llvm-project/commit/23c10e8d0f97dc38c9f620541c7f3ffd04bef905.diff

[PATCH] D123783: [clang] Eliminate TypeProcessingState::trivial.

This revision was automatically updated to reflect the committed changes. mboehme marked an inline comment as done. Closed by commit rG23c10e8d0f97: [clang] Eliminate TypeProcessingState::trivial. (authored by mboehme). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D124556: [NFC] Prevent shadowing a variable declared in `if`

hubert.reinterpretcast added a comment. In D124556#3482224 , @ken-matsui wrote: > Thank you! Thanks in turn. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124556/new/ https://reviews.llvm.org/D124556 __

[PATCH] D85528: [analyzer] Fix cast evaluation on scoped enums in ExprEngine

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. LGTM! Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85528/new/ https://reviews.llvm.org/D85528 ___ cfe-commits mailing list cfe-

[clang] 9e7c996 - Additionally set f32 mode with denormal-fp-math

Author: David Candler Date: 2022-04-29T15:06:32+01:00 New Revision: 9e7c9967c3fd573ef53b145e24e6a1e6ba930c82 URL: https://github.com/llvm/llvm-project/commit/9e7c9967c3fd573ef53b145e24e6a1e6ba930c82 DIFF: https://github.com/llvm/llvm-project/commit/9e7c9967c3fd573ef53b145e24e6a1e6ba930c82.diff

[PATCH] D122589: Additionally set f32 mode with denormal-fp-math

This revision was automatically updated to reflect the committed changes. Closed by commit rG9e7c9967c3fd: Additionally set f32 mode with denormal-fp-math (authored by dcandler). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122589/new/ https://revi

[PATCH] D124658: [analyzer] Canonicalize SymIntExpr so the RHS is positive when possible

tomasz-kaminski-sonarsource marked 2 inline comments as done. tomasz-kaminski-sonarsource added a comment. > Could you please elaborate on this? I understand that you'd like to simplify > certain binary operations by merging the RHS and the operand, however, I > don't see what are the empirical

[PATCH] D124220: [OpenMP] Add options to only compile the host or device when offloading

jhuber6 updated this revision to Diff 426049. jhuber6 added a comment. Rebase after landing the cuda support for the new driver. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124220/new/ https://reviews.llvm.org/D124220 Files: clang/include/clan

[PATCH] D120273: [OpenMP] Allow CUDA to be linked with OpenMP using the new driver

jhuber6 updated this revision to Diff 426050. jhuber6 added a comment. Adding test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120273/new/ https://reviews.llvm.org/D120273 Files: clang/test/Driver/linker-wrapper.c clang/tools/clang-linker-wr

[PATCH] D123471: [CUDA] Create offloading entries when using the new driver

jhuber6 updated this revision to Diff 426051. jhuber6 added a comment. Herald added a subscriber: mattd. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123471/new/ https://reviews.llvm.org/D123471 Files: clang/include/clang/Basic/LangOptio

[PATCH] D124650: [clang-tidy] Simplify boolean expressions by DeMorgan's theorem

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:139 +- Expanded :doc:`readability-simplify-boolean-expr + ` to simplify expressions Please use alphabetical order for such entries. Repository: rG LLVM Github Monore

[PATCH] D120273: [OpenMP] Allow CUDA to be linked with OpenMP using the new driver

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120273/new/ https://reviews.llvm.org/D120273 ___

[PATCH] D122895: [C89/C2x] Improve diagnostics around strict prototypes in C

tahonermann added a comment. > I think it's debatable whether this is a bug or not For C99 through C17, I kind of agree, but for C2x (where the warning is still issued with `-Wstrict-prototypes`), my understanding is that `void foo(void)` and `void foo()` are equivalent; there is no unprototype

[PATCH] D124500: [clang-tidy] Support expressions of literals in modernize-macro-to-enum

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/IntegralLiteralExpressionMatcher.cpp:25 + + // not a hexadecimal floating-point literal + if (Token.getLength() > 2 && Begin[0] == '0' && std::toupper(Begin[1]) == 'X') (S

[PATCH] D122895: [C89/C2x] Improve diagnostics around strict prototypes in C

aaron.ballman added a comment. In D122895#3482555 , @tahonermann wrote: >> I think it's debatable whether this is a bug or not > > For C99 through C17, I kind of agree, but for C2x (where the warning is still > issued with `-Wstrict-prototypes`), my und

[PATCH] D124658: [analyzer] Canonicalize SymIntExpr so the RHS is positive when possible

tomasz-kaminski-sonarsource updated this revision to Diff 426056. tomasz-kaminski-sonarsource added a comment. Uploading updated diff with suggested fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124658/new/ https://reviews.llvm.org/D124658

[PATCH] D119544: Deferred Concept Instantiation Implementation

erichkeane marked 11 inline comments as done. erichkeane added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:70 +assert((!LHS.isInvalid() && !RHS.isInvalid()) && "not good expressions?"); +assert(LHS.isUsable() && RHS.isUsable() && "Side not usable?"); +

[PATCH] D124674: [analyzer] Indicate if a parent state is infeasible

martong created this revision. martong added reviewers: NoQ, steakhal, ASDenysPetrov, Szelethus, xazax.hun. Herald added subscribers: manas, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. Herald added a project: All. martong requested review of thi

[PATCH] D119544: Deferred Concept Instantiation Implementation

erichkeane updated this revision to Diff 426060. erichkeane marked 3 inline comments as done. erichkeane added a comment. Make all the changes that @ChuanqiXu suggested. Thank you again so much for your help during this! I intend to commit this my Monday-AM unless someone comments differently.

[PATCH] D124674: [analyzer] Indicate if a parent state is infeasible

martong added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/ConstraintManager.h:96-97 - -// If StTrue is infeasible, asserting the falseness of Cond is unnecessary -// because the existing constraints already establish this. -if (

[clang] 47d6625 - [OpenMP] Add options to only compile the host or device when offloading

Author: Joseph Huber Date: 2022-04-29T11:22:21-04:00 New Revision: 47d66255701a5cfeab6c05e3642a2cccf7a4c09f URL: https://github.com/llvm/llvm-project/commit/47d66255701a5cfeab6c05e3642a2cccf7a4c09f DIFF: https://github.com/llvm/llvm-project/commit/47d66255701a5cfeab6c05e3642a2cccf7a4c09f.diff

[PATCH] D124220: [OpenMP] Add options to only compile the host or device when offloading

This revision was automatically updated to reflect the committed changes. Closed by commit rG47d66255701a: [OpenMP] Add options to only compile the host or device when offloading (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D12

[PATCH] D124510: [RISCV] Precommit test for D124509

khchen accepted this revision. khchen added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124510/new/ https://reviews.llvm.org/D124510 __

[PATCH] D122895: [C89/C2x] Improve diagnostics around strict prototypes in C

manojgupta added a comment. Is disabling the pedantic warning an option for your users? Disabling it wholesale is not an option since they actually want this warning (the older version). But we agreed to disable it specifically for the code where the warning was getting fired. One instance i

[clang] d9c64d3 - [OpenMP] Allow CUDA to be linked with OpenMP using the new driver

Author: Joseph Huber Date: 2022-04-29T11:38:40-04:00 New Revision: d9c64d33b98be695fc78a65624242033058ed117 URL: https://github.com/llvm/llvm-project/commit/d9c64d33b98be695fc78a65624242033058ed117 DIFF: https://github.com/llvm/llvm-project/commit/d9c64d33b98be695fc78a65624242033058ed117.diff

[PATCH] D120273: [OpenMP] Allow CUDA to be linked with OpenMP using the new driver

This revision was automatically updated to reflect the committed changes. Closed by commit rGd9c64d33b98b: [OpenMP] Allow CUDA to be linked with OpenMP using the new driver (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120273/n

[PATCH] D124462: [Analyzer] Fix clang::ento::taint::dumpTaint definition

mantognini added a comment. In D124462#3480348 , @aaron.ballman wrote: > In D124462#3480219 , @steakhal > wrote: > >> Thanks for the stats. >> @aaron.ballman WDYT, where should we put the `LLVM_DUMP_METHOD` ? >

[PATCH] D124679: [clangd] More precisely enable clang warnings through ClangTidy options

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added projects: clang, clang-tools-ex

[PATCH] D124621: CPP-2461 [Analyzer] Fix assumptions about const field with member-initializer

mantognini updated this revision to Diff 426077. mantognini added a comment. Update commit message and add FIXMEs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124621/new/ https://reviews.llvm.org/D124621 Files: clang/lib/StaticAnalyzer/Core/Reg

[PATCH] D124674: [analyzer] Indicate if a parent state is infeasible

steakhal added a comment. Finally, we have this! Can we have this https://godbolt.org/z/oferc6P5Y in addition to the one you proposed? I find it more readable. What performance hit will we suffer from this change? Please do a differential analysis. Comment at: clang/include

[PATCH] D124621: CPP-2461 [Analyzer] Fix assumptions about const field with member-initializer

mantognini marked 2 inline comments as done. mantognini added a comment. In D124621#3481973 , @steakhal wrote: > LGTM > > In D124621#3481906 , @mantognini > wrote: > >> One thing I'm not sure about and couldn't e

[PATCH] D124679: [clangd] More precisely enable clang warnings through ClangTidy options

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Comment at: clang-tools-extra/clangd/ParsedAST.cpp:240 +// Note that unlike -Wunused, clang-diagnostics-unused does not imply +// subcategories like clang-d

[PATCH] D124534: Add a diagnostic for line directive of a gnu extension

ken-matsui added inline comments. Comment at: clang/lib/Lex/PPDirectives.cpp:1356 + +PP.Diag(FlagTok, diag::ext_pp_gnu_line_directive); } else if (FlagVal == 2) { aaron.ballman wrote: > I speculate that this change is wrong. > > The goal here is to diagno

[PATCH] D124462: [Analyzer] Fix clang::ento::taint::dumpTaint definition

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. In D124462#3482728 , @mantognini wrote: > In D124462#3480348 , @aaron.ballman > wrote: > >> In D124462#

[PATCH] D124621: [Analyzer] Fix assumptions about const field with member-initializer

steakhal accepted this revision. steakhal added a comment. In D124621#3482782 , @mantognini wrote: > In D124621#3481973 , @steakhal > wrote: > >> BTW have you measured the observable impact of this patch on larg

[clang] 813e521 - [AMDGPU] Add gfx11 subtarget ELF definition

Author: Joe Nash Date: 2022-04-29T12:27:17-04:00 New Revision: 813e521e55b11165138b071f446eda94b14570dc URL: https://github.com/llvm/llvm-project/commit/813e521e55b11165138b071f446eda94b14570dc DIFF: https://github.com/llvm/llvm-project/commit/813e521e55b11165138b071f446eda94b14570dc.diff LOG:

[PATCH] D124536: [AMDGPU] Add gfx11 subtarget ELF definition

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG813e521e55b1: [AMDGPU] Add gfx11 subtarget ELF definition (authored by Joe_Nash). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D122895: [C89/C2x] Improve diagnostics around strict prototypes in C

aaron.ballman added a comment. In D122895#3482707 , @manojgupta wrote: > Is disabling the pedantic warning an option for your users? > > Disabling it wholesale is not an option since they actually want this warning > (the older version). But we agree

[clang] 9c8a883 - [Clang][Docs] Add new offloading flags to the clang documentation

Author: Joseph Huber Date: 2022-04-29T13:07:11-04:00 New Revision: 9c8a88382d86c731db3c5c92d8ecd6ef296329ab URL: https://github.com/llvm/llvm-project/commit/9c8a88382d86c731db3c5c92d8ecd6ef296329ab DIFF: https://github.com/llvm/llvm-project/commit/9c8a88382d86c731db3c5c92d8ecd6ef296329ab.diff

[PATCH] D124650: [clang-tidy] Simplify boolean expressions by DeMorgan's theorem

LegalizeAdulthood updated this revision to Diff 426111. LegalizeAdulthood added a comment. Sort changes by check name in docs CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124650/new/ https://reviews.llvm.org/D124650 Files: clang-tools-extra/clang-tidy/readability/SimplifyBooleanExpr

[clang] ef87865 - Silence -Wstrict-prototype diagnostics in C2x mode

Author: Aaron Ballman Date: 2022-04-29T13:37:33-04:00 New Revision: ef87865b98fa25af1d2c045bab1268b2a1503374 URL: https://github.com/llvm/llvm-project/commit/ef87865b98fa25af1d2c045bab1268b2a1503374 DIFF: https://github.com/llvm/llvm-project/commit/ef87865b98fa25af1d2c045bab1268b2a1503374.diff

[PATCH] D122895: [C89/C2x] Improve diagnostics around strict prototypes in C

aaron.ballman added a comment. In D122895#3482575 , @aaron.ballman wrote: > In D122895#3482555 , @tahonermann > wrote: > >>> I think it's debatable whether this is a bug or not >> >> For C99 through C17, I kind

[PATCH] D124500: [clang-tidy] Support expressions of literals in modernize-macro-to-enum

LegalizeAdulthood marked 2 inline comments as done. LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/IntegralLiteralExpressionMatcher.cpp:32-33 + // not a decimal floating-point literal + return std::none_of( + Begin, End, [](cha

[PATCH] D124211: Add __builtin_call_kcfi_unchecked

samitolvanen updated this revision to Diff 426116. samitolvanen marked 2 inline comments as done. samitolvanen added a comment. - Renamed the builtin. - Addressed Nick's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124211/new/ https://re

[PATCH] D124688: [clangd] parse all make_unique-like functions in preamble

upsj created this revision. upsj added a reviewer: nridge. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: All. upsj requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. I am wo

[clang] 6f79700 - [randstruct] Automatically randomize a structure of function pointers

Author: Bill Wendling Date: 2022-04-29T11:05:09-07:00 New Revision: 6f79700830292d86afec5f3cf5143b00e6f3f1fd URL: https://github.com/llvm/llvm-project/commit/6f79700830292d86afec5f3cf5143b00e6f3f1fd DIFF: https://github.com/llvm/llvm-project/commit/6f79700830292d86afec5f3cf5143b00e6f3f1fd.diff

[PATCH] D123544: [randstruct] Automatically randomize a structure of function pointers

This revision was automatically updated to reflect the committed changes. Closed by commit rG6f7970083029: [randstruct] Automatically randomize a structure of function pointers (authored by void). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123544/

  1   2   >