[PATCH] D120456: bump __cpp_concepts and __cpp_constexpr in accordance with P2493R0

MarcusBoay created this revision. MarcusBoay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D120456 Files: clang/lib/Frontend/InitPreprocessor.cpp clang/test/Lexer/cxx-fe

[PATCH] D120334: [NFC][Lexer] Make Lexer::LangOpts const reference

nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land. Looks reasonable to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120334/new/ https://reviews.llvm.org/D120334 __

[clang] 7fd60ee - [analyzer] Fix -Wunused-lambda-capture in -DLLVM_ENABLE_ASSERTIONS=off builds

Author: Fangrui Song Date: 2022-02-24T00:13:13-08:00 New Revision: 7fd60ee6e0a87957a718297a4a42d9881fc561e3 URL: https://github.com/llvm/llvm-project/commit/7fd60ee6e0a87957a718297a4a42d9881fc561e3 DIFF: https://github.com/llvm/llvm-project/commit/7fd60ee6e0a87957a718297a4a42d9881fc561e3.diff

[PATCH] D118987: [analyzer] Add failing test case demonstrating buggy taint propagation

MaskRay added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp:782 +if (PropDstArgs.contains(I)) { + LLVM_DEBUG(llvm::dbgs() << "PreCall<"; Call.dump(llvm::dbgs()); + llvm::dbgs() There wa

[PATCH] D120227: [RISCV] Add policy operand for masked vid and viota IR intrinsics.

rogfer01 accepted this revision. rogfer01 added a comment. This revision is now accepted and ready to land. LGTM. Thanks @khchen ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120227/new/ https://reviews.llvm.org/D120227 _

[PATCH] D120228: [RISCV] Add policy operand for masked compare and vmsbf/vmsif/vmsof IR intrinsics.

rogfer01 accepted this revision. rogfer01 added a comment. This revision is now accepted and ready to land. LGTM. Thanks @khchen ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120228/new/ https://reviews.llvm.org/D120228 _

[PATCH] D120334: [NFC][Lexer] Make Lexer::LangOpts const reference

jansvoboda11 accepted this revision. jansvoboda11 added a comment. LGTM too if the performance remains the same as with the original revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120334/new/ https://reviews.llvm.org/D120334 _

[PATCH] D120445: [clang-format] Treat && followed by noexcept operator as a binary operator inside template arguments

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM, but please rebase so that CI runs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120445/new/ https://reviews.llvm.org/D120445 ___

[clang] 69350e5 - [C++20][Modules][3/8] Initial handling for module partitions.

Author: Iain Sandoe Date: 2022-02-24T09:01:09Z New Revision: 69350e569dc47f871590243b5e46a68520640dcd URL: https://github.com/llvm/llvm-project/commit/69350e569dc47f871590243b5e46a68520640dcd DIFF: https://github.com/llvm/llvm-project/commit/69350e569dc47f871590243b5e46a68520640dcd.diff LOG: [

[PATCH] D118586: [C++20][Modules][3/8] Initial handling for module partitions.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. iains marked an inline comment as done. Closed by commit rG69350e569dc4: [C++20][Modules][3/8] Initial handling for module partitions. (authored by iains). Repository:

[PATCH] D118352: [clang][ABI] New c++20 modules mangling scheme

ChuanqiXu added a comment. @urnathan FWIW, D114714 is landed~ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118352/new/ https://reviews.llvm.org/D118352 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[clang] dbc4d28 - [clang-format] Do not insert space after new/delete keywords in C function declarations

Author: Luis Penagos Date: 2022-02-24T10:06:40+01:00 New Revision: dbc4d281bd6954362ccfc0747893ceaae842671b URL: https://github.com/llvm/llvm-project/commit/dbc4d281bd6954362ccfc0747893ceaae842671b DIFF: https://github.com/llvm/llvm-project/commit/dbc4d281bd6954362ccfc0747893ceaae842671b.diff

[PATCH] D120374: [clang-format] Do not insert space after new/delete keywords in C function declarations

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdbc4d281bd69: [clang-format] Do not insert space after new/delete keywords in C function… (authored by penagos, committed by curdeius). Repository:

[PATCH] D118050: [analyzer] Different address spaces cannot overlap

vabridgers added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp:726-727 + LhsLoc.getType(Ctx).isNull() ? 0 : Ctx.getTypeSize(LhsLoc.getType(Ctx)); + if (RhsBitwidth && LhsBitwidth && + (LhsLoc.getSubKind() == RhsLoc.getSubKind())) { +

[clang] 46f6c83 - [clang-format] Fix QualifierOrder breaking the code with requires clause.

Author: Marek Kurdej Date: 2022-02-24T10:16:10+01:00 New Revision: 46f6c834d9f95d99e0a85aa0c6dc07419aa6dee2 URL: https://github.com/llvm/llvm-project/commit/46f6c834d9f95d99e0a85aa0c6dc07419aa6dee2 DIFF: https://github.com/llvm/llvm-project/commit/46f6c834d9f95d99e0a85aa0c6dc07419aa6dee2.diff

[PATCH] D120309: [clang-format] Fix QualifierOrder breaking the code with requires clause.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG46f6c834d9f9: [clang-format] Fix QualifierOrder breaking the code with requires clause. (authored by curdeius). Repository: rG LLVM Github Monorep

[PATCH] D120140: [clang-format] Avoid inserting space after C++ casts.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbfb4afee74c8: [clang-format] Avoid inserting space after C++ casts. (authored by curdeius). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[clang] bfb4afe - [clang-format] Avoid inserting space after C++ casts.

Author: Marek Kurdej Date: 2022-02-24T10:21:02+01:00 New Revision: bfb4afee74c8d6e3b1d020564bfe163073f07a04 URL: https://github.com/llvm/llvm-project/commit/bfb4afee74c8d6e3b1d020564bfe163073f07a04 DIFF: https://github.com/llvm/llvm-project/commit/bfb4afee74c8d6e3b1d020564bfe163073f07a04.diff

[PATCH] D119816: Fix not working attribute no_sanitize bounds that affects linux kernel

ztong0001 updated this revision to Diff 411040. ztong0001 edited the summary of this revision. ztong0001 added a comment. update patch and description as suggested by Marco Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119816/new/ https://reviews.l

[PATCH] D120361: [clang-format] Extract doc for entire configuration structs

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120361/new/ https://reviews.llvm.org/D120361 __

[PATCH] D117090: [clang-tidy] Fix `readability-non-const-parameter` for parameter referenced by an lvalue

njames93 added a comment. Before landing make sure this is rebased against trunk, just so the pre-merge bot can run and verify there are no issues. It looks like this patch is based off a few commits that don't appear on trunk. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117090/new/

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

krasimir added a comment. @achieveartificialintelligence any progress with the problematic IR? Have you been able to reproduce using nikic's reduced example? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93298/new/ https://reviews.llvm.org/D93298

[PATCH] D120463: [clang][modules] NFC: Simplify and clarify test

jansvoboda11 created this revision. jansvoboda11 added reviewers: ilyakuteev, Bigcheese, dexonsmith. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch simplifies a test that checks only used module map files are repor

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

achieveartificialintelligence added a comment. In D93298#3342452 , @krasimir wrote: > @achieveartificialintelligence any progress with the problematic IR? Have you > been able to reproduce using nikic's reduced example? Sorry, I don't have a solution rig

[PATCH] D120464: [clang][modules] Report module maps affecting `no_undeclared_includes` modules

jansvoboda11 created this revision. jansvoboda11 added reviewers: ilyakuteev, Bigcheese, dexonsmith. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Since D106876 , PCM files don't report modul

[PATCH] D120465: [clang][deps] Generate necessary "-fmodule-map-file=" arguments, disable implicit module maps

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Since D113473 , we don't report any module map files vi

[PATCH] D118915: [clang][deps] Generate '-fmodule-file=' only for direct dependencies

jansvoboda11 updated this revision to Diff 411044. jansvoboda11 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118915/new/ https://reviews.llvm.org/D118915 Files: clang/include/clang/Tooling/DependencyScanning/DependencySc

[PATCH] D116015: [PowerPC] Add generic fnmsub intrinsic

qiucf updated this revision to Diff 411046. qiucf marked an inline comment as done. qiucf edited the summary of this revision. qiucf added a comment. Replace existing `ppc.fnmsub` and `ppc.fnmsubs`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1160

[PATCH] D118370: [clang-tidy] bugprone-signal-handler: Message improvement and code refactoring.

balazske updated this revision to Diff 411047. balazske added a comment. Applied review comments, fixed the failing tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118370/new/ https://reviews.llvm.org/D118370 Files: clang-tools-extra/clang-

[clang] fb3a2d4 - [Sema] Silence unused variable warning in Release builds. NFC.

Author: Benjamin Kramer Date: 2022-02-24T11:00:52+01:00 New Revision: fb3a2d45cd79d3573dafcb7d26df355266b0228c URL: https://github.com/llvm/llvm-project/commit/fb3a2d45cd79d3573dafcb7d26df355266b0228c DIFF: https://github.com/llvm/llvm-project/commit/fb3a2d45cd79d3573dafcb7d26df355266b0228c.dif

[PATCH] D120254: [OpenCL] Align subgroup builtin guards

dyung added a comment. Hi, our internal release build bots are showing failures in two clang-tidy tests that I bisected back to your commit, clang-tidy/checkers/altera-id-dependent-backward-branch.cpp and clang-tidy/checkers/altera-single-work-item-barrier.cpp. After this change, both are exhi

[PATCH] D120254: [OpenCL] Align subgroup builtin guards

svenvh added a comment. In D120254#3342551 , @dyung wrote: > Hi, our internal release build bots are showing failures in two clang-tidy > tests that I bisected back to your commit, > clang-tidy/checkers/altera-id-dependent-backward-branch.cpp and > cla

[PATCH] D120254: [OpenCL] Align subgroup builtin guards

dyung added a comment. In D120254#3342570 , @svenvh wrote: > In D120254#3342551 , @dyung wrote: > >> Hi, our internal release build bots are showing failures in two clang-tidy >> tests that I bisected back to you

[PATCH] D120254: [OpenCL] Align subgroup builtin guards

dyung added a comment. If it helps, this is the cmake command I am using to build using gcc on linux: CMake command: -G Ninja -DLLVM_INCLUDE_EXAMPLES=OFF -DLLVM_VERSION_SUFFIX= -DLLVM_BUILD_RUNTIME=ON -DLLVM_TOOL_LLD_BUILD=OFF "-DLLVM_LIT_ARGS=--verbose -j80 --no-progress-bar --max-tests 10"

[PATCH] D120246: [flang][driver] Add support for `--target`/`--triple`

MatsPetersson added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120246/new/ https://reviews.llvm.org/D120246 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D118987: [analyzer] Add failing test case demonstrating buggy taint propagation

steakhal marked an inline comment as done. steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp:782 +if (PropDstArgs.contains(I)) { + LLVM_DEBUG(llvm::dbgs() << "PreCall<"; Call.dump(llvm::dbgs()); +

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

krasimir added a comment. In D93298#3342480 , @achieveartificialintelligence wrote: > In D93298#3342452 , @krasimir wrote: > >> @achieveartificialintelligence any progress with the problematic IR? Have >> you been

[clang] a8b4b91 - [NFC][clang] Simplify `isOneOf` function

Author: Shao-Ce SUN Date: 2022-02-24T19:12:34+08:00 New Revision: a8b4b9104c8f7ab5edb8651a900e61279e8bf931 URL: https://github.com/llvm/llvm-project/commit/a8b4b9104c8f7ab5edb8651a900e61279e8bf931 DIFF: https://github.com/llvm/llvm-project/commit/a8b4b9104c8f7ab5edb8651a900e61279e8bf931.diff L

[PATCH] D117740: [NFC][clang] Simplify `isOneOf` function

This revision was automatically updated to reflect the committed changes. Closed by commit rGa8b4b9104c8f: [NFC][clang] Simplify `isOneOf` function (authored by achieveartificialintelligence). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117740/new/

[PATCH] D120468: [clang][NFC] Move all avr CodeGen tests to avr specific directory

benshi001 created this revision. benshi001 added reviewers: MaskRay, dylanmckay, aykevl. Herald added a subscriber: Jim. benshi001 requested review of this revision. Herald added subscribers: cfe-commits, jacquesguan. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://re

[PATCH] D120468: [clang][NFC] Move all avr CodeGen tests to avr specific directory

benshi001 added a comment. There are also other AVR tests in the folder clang/test/CodeGen/avr, so it would be better to put them together. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120468/new/ https://reviews.llvm.org/D120468 ___

[PATCH] D118333: [RISCV] Use computeTargetABI from llc as well as clang

asb accepted this revision. asb added a comment. This revision is now accepted and ready to land. In D118333#3329422 , @asb wrote: > Thanks, I've put this on the agenda for the RISC-V LLVM sync call today. I > think this is more attractive than the previ

[PATCH] D120470: [clang-tidy] Update tests to include opencl-c-base.h

svenvh created this revision. svenvh added a reviewer: dyung. Herald added subscribers: Naghasan, ldrumm, xazax.hun, Anastasia, yaxunl. svenvh requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. After D120254

[PATCH] D120254: [OpenCL] Align subgroup builtin guards

svenvh added a comment. Thanks, I could reproduce the problem with your cmake line. I have uploaded a fix for review in https://reviews.llvm.org/D120470 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120254/new/ https://reviews.llvm.org/D120254 _

[clang] 88182e2 - [OpenCL] opencl-c.h: remove arg names for image builtins

Author: Sven van Haastregt Date: 2022-02-24T11:52:32Z New Revision: 88182e2dfde295a8f6adc9e6148410e86c71680d URL: https://github.com/llvm/llvm-project/commit/88182e2dfde295a8f6adc9e6148410e86c71680d DIFF: https://github.com/llvm/llvm-project/commit/88182e2dfde295a8f6adc9e6148410e86c71680d.diff

[PATCH] D109239: Add support for floating-option `-ffp-eval-method` and for new `pragma clang fp eval-method`

zahiraam added a comment. In D109239#3341696 , @thakis wrote: > Actually, I did it myself in 34285bcd5ac260246c9d59708a63ea3d5972f75c > @thakis Thanks! CHANGES SINCE LAST ACTION h

[PATCH] D120474: [clang][deps] Remove '-fmodules-cache-path=' arguments

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. With explicit modules build, the '-fmodules-cache-path=' argument is unused. This patch r

[PATCH] D120475: [clang][AVR] Implement standard calling convention for AVR and AVRTiny

benshi001 created this revision. benshi001 added reviewers: aykevl, dylanmckay. Herald added a subscriber: Jim. benshi001 requested review of this revision. Herald added subscribers: cfe-commits, jacquesguan. Herald added a project: clang. The standard calling convention of AVR is documented at ht

[PATCH] D120475: [clang][AVR] Implement standard calling convention for AVR and AVRTiny

benshi001 updated this revision to Diff 411090. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120475/new/ https://reviews.llvm.org/D120475 Files: clang/lib/Basic/Targets/AVR.cpp clang/lib/Basic/Targets/AVR.h clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGen/avr/argument.c Inde

[PATCH] D120475: [clang][AVR] Implement standard calling convention for AVR and AVRTiny

benshi001 updated this revision to Diff 411094. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120475/new/ https://reviews.llvm.org/D120475 Files: clang/lib/Basic/Targets/AVR.cpp clang/lib/Basic/Targets/AVR.h clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGen/avr/argument.c Inde

[PATCH] D119670: [clang] Warn on unqualified calls to std::move and std::forward

cor3ntin updated this revision to Diff 411100. cor3ntin marked an inline comment as done. cor3ntin added a comment. - Adds more tests for calls inside std, inline namespaces and adl lookup - use llvm::find - rename the warning flag to unqualified-std-cast-call to leave room for future extensions

[PATCH] D119670: [clang] Warn on unqualified calls to std::move and std::forward

cor3ntin updated this revision to Diff 411101. cor3ntin added a comment. Fix comment to address Christopher's feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119670/new/ https://reviews.llvm.org/D119670 Files: clang/include/clang/Basic/Di

[PATCH] D119670: [clang] Warn on unqualified calls to std::move and std::forward

cor3ntin added inline comments. Comment at: clang/test/SemaCXX/warn-self-move.cpp:20-21 using std::move; - x = move(x); // expected-warning{{explicitly moving}} + x = move(x); // expected-warning{{explicitly moving}} \ + expected-warning {{unqualified call

[PATCH] D120398: [format] follow up: Use unsigned char as the base of all enums in FormatStyle

kwk updated this revision to Diff 411105. kwk added a comment. Rebased on upstream/main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120398/new/ https://reviews.llvm.org/D120398 Files: clang/include/clang/Format/Format.h Index: clang/include/

[PATCH] D120470: [clang-tidy] Update tests to include opencl-c-base.h

svenvh updated this revision to Diff 411106. svenvh edited the summary of this revision. svenvh added reviewers: Anastasia, ffrankies. svenvh added a comment. After a bit of digging I realized we don't need the explicit include at all anymore. CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D120468: [clang][NFC] Move all avr CodeGen tests to avr specific directory

benshi001 updated this revision to Diff 411107. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120468/new/ https://reviews.llvm.org/D120468 Files: clang/test/CodeGen/address-space-avr.c clang/test/CodeGen/alias-avr.c clang/test/CodeGen/avr-buil

[PATCH] D119670: [clang] Warn on unqualified calls to std::move and std::forward

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. See the suggestions, our comments are supposed to be full sentences terminated with a full-stop. Otherwise nothing actionable. Comment at: clang/lib/Sema/SemaExpr.cp

[PATCH] D119670: [clang] Warn on unqualified calls to std::move and std::forward

cor3ntin updated this revision to Diff 41. cor3ntin added a comment. Fix comments punctuation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119670/new/ https://reviews.llvm.org/D119670 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D119670: [clang] Warn on unqualified calls to std::move and std::forward

cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:6441 + // Only warn for some functions deemed more frequent or problematic + static constexpr llvm::StringRef SpecialFunctions[] = {"move", "forward"}; + auto it = llvm::find(SpecialFunctions, D->getName()

[PATCH] D119670: [clang] Warn on unqualified calls to std::move and std::forward

erichkeane added a comment. I understand you still don't have commit-rights. If you'd like, I can push this in a little bit. Just let me know the name/email you'd like me to use. Comment at: clang/lib/Sema/SemaExpr.cpp:6441 + // Only warn for some functions deemed more freq

[PATCH] D119670: [clang] Warn on unqualified calls to std::move and std::forward

cor3ntin added a comment. In D119670#3343076 , @erichkeane wrote: > I understand you still don't have commit-rights. If you'd like, I can push > this in a little bit. Just let me know the name/email you'd like me to use. I guess i should ask for thos

[PATCH] D119670: [clang] Warn on unqualified calls to std::move and std::forward

cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:6441 + // Only warn for some functions deemed more frequent or problematic + static constexpr llvm::StringRef SpecialFunctions[] = {"move", "forward"}; + auto it = llvm::find(SpecialFunctions, D->getName()

[PATCH] D120454: clang/www: Add links to tracking issues for C++20 features

Quuxplusone added inline comments. Comment at: clang/www/cxx_status.html:106 +automatically fetch status information from the issue in the tracker. For Example: +No + HTML nit: t

[PATCH] D120484: More explicit message when failing to find a mandatory cfi ressource file

serge-sans-paille created this revision. serge-sans-paille added a reviewer: thakis. serge-sans-paille requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Compiler-rt doesn't provide support file for cfi on s390x ad ppc64le (at least). When tr

[PATCH] D114235: [clang] Extend ParsedAttr to allow custom handling for type attributes

mboehme added a comment. In D114235#3340412 , @erichkeane wrote: > In D114235#3340369 , @mboehme wrote: > >> In D114235#3244054 , >> @aaron.ballman wrote: >> >>> so ther

[clang] 28cdcf8 - [OpenCL] Handle TypeExtensions in OpenCLBuiltinFileEmitter

Author: Sven van Haastregt Date: 2022-02-24T15:17:24Z New Revision: 28cdcf8e3c8e6c51d42051b54f67c6920b5d8cf3 URL: https://github.com/llvm/llvm-project/commit/28cdcf8e3c8e6c51d42051b54f67c6920b5d8cf3 DIFF: https://github.com/llvm/llvm-project/commit/28cdcf8e3c8e6c51d42051b54f67c6920b5d8cf3.diff

[PATCH] D120262: [OpenCL] Handle TypeExtensions in OpenCLBuiltinFileEmitter

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG28cdcf8e3c8e: [OpenCL] Handle TypeExtensions in OpenCLBuiltinFileEmitter (authored by svenvh). Changed prior to commit: https://reviews.llvm.org/D

[PATCH] D114235: [clang] Extend ParsedAttr to allow custom handling for type attributes

erichkeane added a comment. > For my purposes, it would be fine, and maybe even desirable, for the proposed > annotate_type to have the same limitations as _Nonnull. > > Are you saying that a) this would not be acceptable for a more > general-purpose attribute such as a putative annotate_type, o

[clang] 70b1f6d - [clang] Warn on unqualified calls to std::move and std::forward

Author: Corentin Jabot Date: 2022-02-24T07:23:39-08:00 New Revision: 70b1f6de539867353940d3dcb8b25786d5082d63 URL: https://github.com/llvm/llvm-project/commit/70b1f6de539867353940d3dcb8b25786d5082d63 DIFF: https://github.com/llvm/llvm-project/commit/70b1f6de539867353940d3dcb8b25786d5082d63.diff

[PATCH] D119670: [clang] Warn on unqualified calls to std::move and std::forward

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG70b1f6de5398: [clang] Warn on unqualified calls to std::move and std::forward (authored by cor3ntin, committed by erichkeane). Repository: rG LLVM

[PATCH] D120310: [clang][analyzer] Add modeling of 'errno' (work-in-progress).

balazske updated this revision to Diff 411131. balazske added a comment. Improved the tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120310/new/ https://reviews.llvm.org/D120310 Files: clang/include/clang/StaticAnalyzer/Checkers/Checkers.t

[PATCH] D120489: [analyzer][NFCi] Does some changes to detect Uninitialized read by the char array manipulation functions

phyBrackets created this revision. Herald added subscribers: ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. phyBrackets requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commit

[PATCH] D120310: [clang][analyzer] Add modeling of 'errno' (work-in-progress).

balazske marked 4 inline comments as done. balazske added inline comments. Comment at: clang/test/Analysis/global-region-invalidation.c:6 // Note, we do need to include headers here, since the analyzer checks if the function declaration is located in a system header. +#include

[clang] 7aef8b3 - [OpenMP] Make section variable external to prevent collisions

Author: Joseph Huber Date: 2022-02-24T10:57:09-05:00 New Revision: 7aef8b3754a28e0856a8300980786a45bf7b4cd4 URL: https://github.com/llvm/llvm-project/commit/7aef8b3754a28e0856a8300980786a45bf7b4cd4 DIFF: https://github.com/llvm/llvm-project/commit/7aef8b3754a28e0856a8300980786a45bf7b4cd4.diff

[clang] 0039249 - Remove useless RUN lines in the middle of the file and pipe to FileCheck; NFC

Author: Aaron Ballman Date: 2022-02-24T11:01:33-05:00 New Revision: 003924963f95c746ab72cc8ea0201c855f5264fb URL: https://github.com/llvm/llvm-project/commit/003924963f95c746ab72cc8ea0201c855f5264fb DIFF: https://github.com/llvm/llvm-project/commit/003924963f95c746ab72cc8ea0201c855f5264fb.diff

[PATCH] D120489: [analyzer][NFCi] Done some changes to detect Uninitialized read by the char array manipulation functions

steakhal added a comment. I'm looking forward to this check. Comment at: clang/test/Analysis/bstring.c:300-311 void mempcpy14() { int src[] = {1, 2, 3, 4}; int dst[5] = {0}; int *p; - p = mempcpy(dst, src, 4 * sizeof(int)); + p = mempcpy(dst, src, 4 * sizeof(int))

[PATCH] D113743: [RFC][clang][DebugInfo] Allow function-local statics and types to be scoped within a lexical block

krisb updated this revision to Diff 411137. krisb added a comment. Rebase on top of 'main'. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113743/new/ https://reviews.llvm.org/D113743 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/lib/CodeGen/C

[PATCH] D120470: [clang-tidy] Update tests to include opencl-c-base.h

svenvh added a comment. Since this is a simple test update I'll commit this now (before code review), to get affected CI back to green. Please let me know if there are any post-commit concerns. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120470/

[clang-tools-extra] ba18c36 - [clang-tidy] Remove opencl-c.h inclusion from tests

Author: Sven van Haastregt Date: 2022-02-24T16:28:52Z New Revision: ba18c360b2f3c25fe9091c7a7931eded374b3cf6 URL: https://github.com/llvm/llvm-project/commit/ba18c360b2f3c25fe9091c7a7931eded374b3cf6 DIFF: https://github.com/llvm/llvm-project/commit/ba18c360b2f3c25fe9091c7a7931eded374b3cf6.diff

[PATCH] D120470: [clang-tidy] Update tests to include opencl-c-base.h

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGba18c360b2f3: [clang-tidy] Remove opencl-c.h inclusion from tests (authored by svenvh). Repository: rG LLVM Github Mono

[clang] baa0f22 - [clang][dataflow] Update StructValue child when assigning a value

Author: Stanislav Gatev Date: 2022-02-24T16:41:48Z New Revision: baa0f221d6df2fcce10c54751cc42284e2656c31 URL: https://github.com/llvm/llvm-project/commit/baa0f221d6df2fcce10c54751cc42284e2656c31 DIFF: https://github.com/llvm/llvm-project/commit/baa0f221d6df2fcce10c54751cc42284e2656c31.diff LO

[PATCH] D120414: [clang][dataflow] Update StructValue child when assigning a value

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbaa0f221d6df: [clang][dataflow] Update StructValue child when assigning a value (authored by sgatev). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D120426: [Sema] Mark the referenced destructor during transformation of a `CXXBindTemporaryExpr`

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120426/new/ https://reviews.llvm.org/D120426 ___

[PATCH] D120456: [clang] Bump __cpp_concepts and __cpp_constexpr in accordance with P2493R0

cor3ntin added a comment. Thanks for the patch. However, wg21.link/P0848 need to be fully implemented before we can update `__cpp_concepts`. Could you only modify `__cpp_constexpr` ? Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120456/new

[PATCH] D120310: [clang][analyzer] Add modeling of 'errno'.

balazske updated this revision to Diff 411149. balazske marked 3 inline comments as done. balazske edited the summary of this revision. balazske added a comment. Changed name of the checker to `ErrnoModeling`, other small cleanup. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D120132: [HIP] Fix HIP include path

yaxunl updated this revision to Diff 411150. yaxunl edited the summary of this revision. yaxunl added a reviewer: linjamaki. yaxunl added a comment. Herald added subscribers: mstorsjo, emaste. add HIP include path after adding other system include paths CHANGES SINCE LAST ACTION https://review

[PATCH] D119816: [SanitizerBounds] Add support for NoSanitizeBounds function

melver requested changes to this revision. melver added a comment. This revision now requires changes to proceed. Thanks - this looks good so far. Comment at: clang/test/CodeGen/sanitize-coverage.c:56 // BOUNDS-NOT: call void @__ubsan_handle_out_of_bounds + // BOUNDS-NOT: c

[PATCH] D120495: [clang][dataflow] Add transfer functions for structured bindings

sgatev created this revision. sgatev added reviewers: ymandel, xazax.hun, gribozavr2. Herald added subscribers: tschuett, steakhal, rnkovacs. sgatev requested review of this revision. Herald added a project: clang. This is part of the implementation of the dataflow analysis framework. See "[RFC] A

[PATCH] D113743: [RFC][clang][DebugInfo] Allow function-local statics and types to be scoped within a lexical block

dblaikie added a subscriber: shafik. dblaikie added a comment. In D113743#3177437 , @krisb wrote: > In D113743#3175301 , @dblaikie > wrote: > >> Not super surprising that lldb might not be able to deal with DWARF

[PATCH] D120498: [AST] Test RecursiveASTVisitor's current traversal of templates.

sammccall created this revision. sammccall added reviewers: hokein, nridge. Herald added subscribers: usaxena95, kadircet, mgorny. sammccall requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Herald added a project: clang. There are several logical inconsisten

[PATCH] D120499: [NVPTX] Fix nvvm.match.sync*.i64 intrinsics return type (i64 -> i32)

krisb created this revision. krisb added a reviewer: tra. Herald added subscribers: asavonic, hiraditya. krisb requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, jdoerfert. Herald added projects: clang, LLVM. NVVM IR specification defines them with i32 return t

[PATCH] D118259: [AArch64] Adjust aarch64-neon-intrinsics-constrained test and un-XFAIL

john.brawn added a comment. In D118259#3275297 , @fhahn wrote: > Does this clang test actually need to check the generated assembly? Shouldn't > it be enough to check that the correct intrinsics are generated? I could remove the CHECK-ASM checks, but th

[PATCH] D119147: [AIX][clang][driver] Check the command string to the linker for exportlist opts

DiggerLin marked 6 inline comments as done. DiggerLin added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:80 +static bool hasExportListLinkerOpts(const ArgStringList &CmdArgs) { + for (size_t i = 0; i < CmdArgs.size(); ++i) { +llvm::StringRef ArgString(Cmd

[clang] ecff9b6 - [analyzer] Just use default capture after 7fd60ee6e0a87957a718297a4a42d9881fc561e3

Author: Fangrui Song Date: 2022-02-24T10:06:11-08:00 New Revision: ecff9b65b54c7a4bd79ca2af157c81595678f0ee URL: https://github.com/llvm/llvm-project/commit/ecff9b65b54c7a4bd79ca2af157c81595678f0ee DIFF: https://github.com/llvm/llvm-project/commit/ecff9b65b54c7a4bd79ca2af157c81595678f0ee.diff

[PATCH] D119147: [AIX][clang][driver] Check the command string to the linker for exportlist opts

MaskRay added inline comments. Comment at: clang/test/Driver/aix-ld.c:609 +// Check powerpc-ibm-aix7.1.0.0, 32-bit. -shared (with exp option strings in other opt). +// RUN: %clangxx -x c++ -no-canonical-prefixes %s 2>&1 -### \ +// RUN:-resource-dir=%S/Inputs/resource_dir

[PATCH] D120468: [clang][NFC] Move all avr CodeGen tests to avr specific directory

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120468/new/ https://reviews.llvm.org/D120468

[PATCH] D119147: [AIX][clang][driver] Check the command string to the linker for exportlist opts

DiggerLin updated this revision to Diff 411172. DiggerLin marked 3 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119147/new/ https://reviews.llvm.org/D119147 Files: clang/include/clang/Driver/Job.h clang/lib/Driver/Job.c

[PATCH] D120503: [clang-format] Handle trailing comment for InsertBraces

owenpan created this revision. owenpan added reviewers: curdeius, HazardyKnusperkeks, MyDeveloperDay. owenpan added a project: clang-format. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo http

[PATCH] D113107: Support of expression granularity for _Float16.

zahiraam updated this revision to Diff 411177. zahiraam set the repository for this revision to rG LLVM Github Monorepo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113107/new/ https://reviews.llvm.org/D113107 Files: clang/docs/LanguageExtension

[PATCH] D120504: [AST] RAV doesn't traverse explicitly instantiated function bodies by default

sammccall created this revision. sammccall added reviewers: hokein, davidxl. Herald added subscribers: wenlei, usaxena95, kadircet, arphaman. sammccall requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits. This is consistent wit

  1   2   >