[PATCH] D120258: [clangd] Add inlay hints for auto-typed parameters with one instantiation.

nridge added a comment. Thanks, this is a nice extension of D119537 . I don't have a good sense for how common the "multiple instantiations, same type" scenario is; perhaps @Trass3r has an opinion on that. Comment at: clang-tools-extra/clangd

[PATCH] D120251: [clang][driver][wasm] Fix libstdc++ target-dependent include dir

tbaeder added a comment. @sbc100 Do you think we should add `/backward` as well? `Gnu.cpp` does that it seems: https://github.com/llvm/llvm-project/blob/main/clang/lib/Driver/ToolChains/Gnu.cpp#L2959-L2960 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

MaskRay created this revision. MaskRay added reviewers: foutrelis, sylvestre.ledru, thesamesam, tstellar. Herald added a subscriber: mgorny. MaskRay requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Default the option introd

[PATCH] D88425: Skip -fPIE for AMDGPU and HIP toolchain

MaskRay added a comment. I plan to default CMake `CLANG_DEFAULT_PIE_ON_LINUX` to on in D120305 and hip-fpie-option.hip will fail. Do you mind investigating the issue? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D77440: [Hexagon] Update include paths for linux/musl

MaskRay added a comment. I plan to default CMake `CLANG_DEFAULT_PIE_ON_LINUX` to on in D120305 and `hexagon-toolchain-linux.c` will fail. Do you mind investigating the issue? Also, see D119309 for tips improving driver tests

[PATCH] D97625: fix check-clang-tools tests that fail due to Windows CRLF line endings

dmgreen added a comment. Hello. I noticed this was applied to the base /test directory in the llvm repo: https://github.com/llvm/llvm-project/tree/main/test Was it intended be in clang-tools-extra: https://github.com/llvm/llvm-project/tree/main/clang-tools-extra/test? I'm not sure it will do mu

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

MaskRay added a subscriber: atanasyan. MaskRay added a comment. @atanasyan A few mips test/Driver tests will fail. Wonder if you have time making them more portable... Otherwise I'll just add `UNSUPPORTED: default-pie-on-linux` to them. Failed Tests (6): Clang :: Driver/hip-fpie-option.hi

[PATCH] D120306: [clangd] IncludeCleaner: Add support for IWYU pragma private

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM

[PATCH] D120306: [clangd] IncludeCleaner: Add support for IWYU pragma private

kbobyrev planned changes to this revision. kbobyrev added a comment. The patch is working but I didn't add tests yet. Also, I think I should move the suffix mapping to `CanonicalIncludes` structure rather than `Headers`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D120258: [clangd] Add inlay hints for auto-typed parameters with one instantiation.

nridge added inline comments. Comment at: clang-tools-extra/clangd/InlayHints.cpp:323 + "Instantiated function has fewer (non-pack) parameters?"); +return InstantiatedFunction->getParamDecl(ParamIdx); + } Here's a test case which slips past these c

[PATCH] D116153: [ARM][AArch64] Add missing v8.x checks

SjoerdMeijer accepted this revision. SjoerdMeijer added a comment. This revision is now accepted and ready to land. Thanks, looks good! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116153/new/ https://reviews.llvm.org/D116153

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

sylvestre.ledru added inline comments. Comment at: clang/docs/ReleaseNotes.rst:177 +* CMake ``-DCLANG_DEFAULT_PIE_ON_LINUX=ON`` is now the default. + This matches GCC installations on many Linux distros. it would be nice to explain what "pie" it is doing :)

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

atanasyan added a comment. In D120305#3337019 , @MaskRay wrote: > @atanasyan A few mips test/Driver tests will fail. Wonder if you have time > making them more portable... Otherwise I'll just add `UNSUPPORTED: > default-pie-on-linux` to them. > > Fail

[PATCH] D120307: [X86] Add helper macros for ternary intrinsics

pengfei created this revision. pengfei added reviewers: RKSimon, craig.topper, LuoYuanke, spatel. pengfei requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D120307 Files: clan

[clang] 48dc980 - [Format] Remove unused LineContainsContinuedForLoopSection. NFC

Author: Sam McCall Date: 2022-02-22T09:59:02+01:00 New Revision: 48dc980847b25384511276e37c02c7edcf9e3d3a URL: https://github.com/llvm/llvm-project/commit/48dc980847b25384511276e37c02c7edcf9e3d3a DIFF: https://github.com/llvm/llvm-project/commit/48dc980847b25384511276e37c02c7edcf9e3d3a.diff LO

[PATCH] D120282: [Format] Remove unused LineContainsContinuedForLoopSection. NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG48dc980847b2: [Format] Remove unused LineContainsContinuedForLoopSection. NFC (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D120246: [flang][driver] Add support for `--target`/`--triple`

awarzynski updated this revision to Diff 410469. awarzynski added a comment. Add TargetOptions.h (that I forgot to add earlier) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120246/new/ https://reviews.llvm.org/D120246 Files: clang/include/clang

[PATCH] D120309: [clang-format] Fix QualifierOrder breaking the code with requires clause.

curdeius created this revision. curdeius added reviewers: MyDeveloperDay, HazardyKnusperkeks, owenpan. curdeius requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://github.com/llvm/llvm-project/issues/53962. Given the config: B

[PATCH] D120310: [clang][analyzer] Add modeling of 'errno' (work-in-progress).

balazske created this revision. Herald added subscribers: steakhal, ASDenysPetrov, martong, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun, mgorny. Herald added a reviewer: Szelethus. balazske requested review of this revision. Herald a

[clang] 650aec6 - [ARM][AArch64] Add missing v8.x checks

Author: tyb0807 Date: 2022-02-22T09:07:59Z New Revision: 650aec687eb54aeeb3cef4a41f2dbaa49ef3e358 URL: https://github.com/llvm/llvm-project/commit/650aec687eb54aeeb3cef4a41f2dbaa49ef3e358 DIFF: https://github.com/llvm/llvm-project/commit/650aec687eb54aeeb3cef4a41f2dbaa49ef3e358.diff LOG: [ARM]

[PATCH] D116153: [ARM][AArch64] Add missing v8.x checks

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG650aec687eb5: [ARM][AArch64] Add missing v8.x checks (authored by tyb0807). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D119077: clangd SemanticHighlighting: added support for highlighting overloaded operators

nridge added a comment. Still haven't had a chance to take a super detailed look, but a few high-level thoughts: 1. The AST nodes that reference operator names should store source ranges associated with the operator names, such that we shouldn't need to do token-by-token manipulation. For exam

[PATCH] D120310: [clang][analyzer] Add modeling of 'errno' (work-in-progress).

balazske added reviewers: NoQ, steakhal, martong. balazske added a comment. Herald added subscribers: ormris, rnkovacs. Documentation not added yet. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120310/new/ https://reviews.llvm.org/D120310 ___

[PATCH] D116015: [PowerPC] Add generic fnmsub intrinsic

qiucf added a comment. In D116015#3326148 , @shchenz wrote: >> hiding the semantics from the optimizer is sometimes a good thing and >> sometimes a bad thing). > > Agree. Imagining a case when the neg and fma (from fnmsub) can both be CSE-ed > with anot

[PATCH] D120258: [clangd] Add inlay hints for auto-typed parameters with one instantiation.

sammccall marked 4 inline comments as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/AST.cpp:572 +#define TEMPLATE_TYPE(SomeTemplateDecl) \ + if (auto *STD = llvm::dyn_cast(TD)) { \ +f

[PATCH] D120258: [clangd] Add inlay hints for auto-typed parameters with one instantiation.

sammccall updated this revision to Diff 410482. sammccall marked 3 inline comments as done. sammccall added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120258/new/ https://reviews.llvm.org/D120258 Files: clang-tools

[PATCH] D120306: [clangd] IncludeCleaner: Add support for IWYU pragma private

sammccall added a comment. What's the policy this patch intends to implement? I'm a little concerned by building up maps of filenames with segment limits - it looks like some kind of heuristic/partial matching. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D91164: [clang-tidy] Improve C++ support in bugprone-signal-handler.

balazske abandoned this revision. balazske added a comment. Herald added subscribers: carlosgalvezp, steakhal. Newer revision: D118996 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91164/new/ https://reviews.llvm.

[PATCH] D120254: [OpenCL] Align subgroup builtin guards

azabaznov accepted this revision. azabaznov added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Comment at: clang/lib/Headers/opencl-c-base.h:85 +// Internal feature macro to provide subgroup builtins. +#define __opencl_subgroup_builtins 1 +#endif --

[clang] c9cc803 - [C++20][Modules][2/8] Add enumerations for partition modules and stream them.

Author: Iain Sandoe Date: 2022-02-22T10:08:15Z New Revision: c9cc8035eb4fbf5d20a73ec7e0870e6195012a71 URL: https://github.com/llvm/llvm-project/commit/c9cc8035eb4fbf5d20a73ec7e0870e6195012a71 DIFF: https://github.com/llvm/llvm-project/commit/c9cc8035eb4fbf5d20a73ec7e0870e6195012a71.diff LOG: [

[PATCH] D114714: [C++20][Modules][2/8] Add enumerations for partition modules and stream them.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc9cc8035eb4f: [C++20][Modules][2/8] Add enumerations for partition modules and stream them. (authored by iains). Repository: rG LLVM Github Monore

[PATCH] D120313: [clang][www] Port make_cxx_dr_status script to Python3

tbaeder created this revision. tbaeder added reviewers: rsmith, aaron.ballman. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. And run it to re-generate the cxx_dr_status.html Repository: rG LLVM Github Monorepo https://reviews

[clang] e7e17b3 - [OpenCL] opencl-c.h: use uint/ulong consistently

Author: Sven van Haastregt Date: 2022-02-22T10:15:40Z New Revision: e7e17b30d02d4f0035fef92850d529f16849c6f0 URL: https://github.com/llvm/llvm-project/commit/e7e17b30d02d4f0035fef92850d529f16849c6f0 DIFF: https://github.com/llvm/llvm-project/commit/e7e17b30d02d4f0035fef92850d529f16849c6f0.diff

[PATCH] D120032: [OpenCL] opencl-c.h: use uint/ulong consistently

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe7e17b30d02d: [OpenCL] opencl-c.h: use uint/ulong consistently (authored by svenvh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D120258: [clangd] Add inlay hints for auto-typed parameters with one instantiation.

Trass3r added a comment. > I don't have a good sense for how common the "multiple instantiations, same > type" scenario is; perhaps @Trass3r has an opinion on that. Hmm you said the function needs to be defined in the cpp file, right? Then I guess lambdas are indeed the main use-case. I've seen

[PATCH] D118757: [AArch64] Remove unused feature flags from AArch64TargetInfo

vhscampos accepted this revision. vhscampos added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118757/new/ https://reviews.llvm.org/D118757 _

[PATCH] D120306: [clangd] IncludeCleaner: Add support for IWYU pragma private

kbobyrev added a comment. In D120306#3337212 , @sammccall wrote: > What's the policy this patch intends to implement? > > I'm a little concerned by building up maps of filenames with segment limits - > it looks like some kind of heuristic/partial matchin

[PATCH] D120306: [clangd] IncludeCleaner: Add support for IWYU pragma private

kbobyrev updated this revision to Diff 410490. kbobyrev added a comment. Move suffix map to CanonicalIncludes (where it logically belongs), remove component limit there. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120306/new/ https://reviews.llvm

[PATCH] D120134: [analyzer] refactor makeIntValWithPtrWidth, remove getZeroWithPtrWidth (NFC)

vabridgers updated this revision to Diff 410493. vabridgers added a comment. Update per @steakhal comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120134/new/ https://reviews.llvm.org/D120134 Files: clang/include/clang/StaticAnalyzer/Core/

[PATCH] D120134: [analyzer] refactor makeIntValWithPtrWidth, remove getZeroWithPtrWidth (NFC)

vabridgers marked 2 inline comments as done. vabridgers added a comment. I believe the comments have been addressed. Thank you - Vince Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120134/new/ https://reviews.llvm.org/D120134 _

[PATCH] D120315: [clang-format] fix preprocessor nesting after https://github.com/llvm/llvm-project/commit/529aa4b011c4ae808d658022ef643c44dd9b2c9c

krasimir created this revision. krasimir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In https://github.com/llvm/llvm-project/commit/529aa4b011c4ae808d658022ef643c44dd9b2c9c by setting the identifier info to nullptr, we started to subtl

[PATCH] D120307: [X86] Add helper macros for ternary intrinsics

RKSimon added a comment. Are similar macros used by any other compilers at all? Comment at: clang/lib/Headers/avx512fintrin.h:5932 -#define _mm512_ternarylogic_epi32(A, B, C, imm) \ - ((__m512i)__builtin_ia32_pternlogd512_mask((__v16si)(__m512i)(A), \ -

[PATCH] D118586: [C++20][Modules][3/8] Initial handling for module partitions.

iains updated this revision to Diff 410498. iains added a comment. rebased, update testcases to use split-file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118586/new/ https://reviews.llvm.org/D118586 Files: clang/include/clang/AST/Decl.h cl

[PATCH] D118586: [C++20][Modules][3/8] Initial handling for module partitions.

iains marked an inline comment as done. iains added inline comments. Comment at: clang/test/Modules/cxx20-multiple-partitions.cpp:48 +#else +#error "no TU set" +#endif jansvoboda11 wrote: > Instead of splitting the file with preprocessor, you could use the > `sp

[PATCH] D120306: [clangd] IncludeCleaner: Add support for IWYU pragma private

sammccall added a comment. In D120306#3337288 , @kbobyrev wrote: > In D120306#3337212 , @sammccall > wrote: > >> What's the policy this patch intends to implement? >> >> I'm a little concerned by building up maps

[PATCH] D119816: Fix not working attribute no_sanitize bounds that affects linux kernel

melver added a comment. Adding a new IR attribute comes with a whole slew of other required changes. Please see https://reviews.llvm.org/D102772 for an example. In addition, please update the patch description to explain what the problem is exactly (remove the old kernel-specific problem, becau

[PATCH] D112916: Confusable identifiers detection

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/ConfusableTable/build_confusable_table.cpp:22 + SmallVector Lines; + Content.split(Lines, '\n', -1, false); + We're testing this functionality in our downstream and noticed that

[PATCH] D113319: [clang-format] Improve require and concept handling

krasimir added a comment. It appears that after this patch clang-format started breaking up `requires` in javascript, e.g.: // before function f() { var requires = {}; } // after function f() { var requires = {}; } Could we restrict the requires logic only to (obj)

[PATCH] D120205: Restore documentation for __builtin_assume

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thanks for catching this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120205/new/ https://reviews.llvm.org/D120205 __

[PATCH] D120306: [clangd] IncludeCleaner: Add support for IWYU pragma private

kbobyrev added a comment. In D120306#3337374 , @sammccall wrote: > In D120306#3337288 , @kbobyrev > wrote: > >> In D120306#3337212 , @sammccall >> wrote: >> >>> What's t

[PATCH] D120134: [analyzer] refactor makeIntValWithPtrWidth, remove getZeroWithPtrWidth (NFC)

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. Thanks for the patch. LGTM on my part. @NoQ WDYT? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120134/new/ https://reviews.llvm.org/D120134

[PATCH] D118587: [C++20][Modules][4/8] Handle generation of partition implementation CMIs.

iains updated this revision to Diff 410514. iains added a comment. rebased, revised testcases to use split-file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118587/new/ https://reviews.llvm.org/D118587 Files: clang/include/clang/Sema/Sema.h

[PATCH] D120315: [clang-format] fix preprocessor nesting after https://github.com/llvm/llvm-project/commit/529aa4b011c4ae808d658022ef643c44dd9b2c9c

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:22727 guessLanguage("foo.h", "#define FOO(...) auto bar = [] __VA_ARGS__;")); + // Only only one of the two preprocessor regions has ObjC-like code. + EXPECT_EQ(FormatStyle::LK_ObjC,

[PATCH] D120315: [clang-format] fix preprocessor nesting after https://github.com/llvm/llvm-project/commit/529aa4b011c4ae808d658022ef643c44dd9b2c9c

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/FormatToken.h:1077 + // For internal use by clang-format. + IdentifierInfo *kw_clang_format_internal_ident_after_define; + I'd be ok with just `kw_internal_ident_after_define` Repository: r

[PATCH] D120290: [Clang][OpenMP] Add the codegen support for `atomic compare capture`

ABataev added inline comments. Comment at: clang/include/clang/AST/StmtOpenMP.h:2835-2847 bool IsXLHSInRHSPart = false; /// Used for 'atomic update' or 'atomic capture' constructs. They may /// have atomic expressions of forms /// \code /// v = x; ; /// ; v = x;

[PATCH] D120315: [clang-format] fix preprocessor nesting after https://github.com/llvm/llvm-project/commit/529aa4b011c4ae808d658022ef643c44dd9b2c9c

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. Just a few nits, but LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120315/new/ https://reviews.llvm.org/D120315 __

[PATCH] D119599: [clang-format] Add option to align compound assignments like `+=`

MyDeveloperDay added a comment. Could you mark the comments as done (if they are done) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119599/new/ https://reviews.llvm.org/D119599 ___ cfe-commits mailing l

[PATCH] D118050: [analyzer] Different address spaces cannot overlap

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. Besides a couple of nits, it's ready for landing. Thanks for the hard work @vabridgers! Comment at: clang/lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp:726-727 + Lhs

[PATCH] D119599: [clang-format] Add option to align compound assignments like `+=`

MyDeveloperDay added subscribers: njames93, grimar. MyDeveloperDay added a comment. Does the YAML changes need unit tests in (llvm/unittests/Support) ? also we should pull in a reviewer from llvm/Support (maybe @njames93, @grimar ) who have made YAML specific changes in this header. Repositor

[PATCH] D119599: [clang-format] Add option to align compound assignments like `+=`

MyDeveloperDay added inline comments. Comment at: clang/docs/tools/dump_format_style.py:121 def __str__(self): -return '\n'.join(map(str, self.values)) +return self.comment + '\n' + '\n'.join(map(str, self.values)) Can this change be separate? why is

[PATCH] D120306: [clangd] IncludeCleaner: Add support for IWYU pragma private

sammccall added a comment. In D120306#3337490 , @kbobyrev wrote: > In D120306#3337374 , @sammccall > wrote: > >> In D120306#3337288 , @kbobyrev >> wrote: >> >>> In D1203

[PATCH] D120315: [clang-format] Fix preprocessor nesting after commit 529aa4b011c4ae808d658022ef643c44dd9b2c9c

curdeius accepted this revision. curdeius added a comment. LGTM with other comments addressed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120315/new/ https://reviews.llvm.org/D120315 ___ cfe-commits m

[PATCH] D118900: [ASTMatchers] Expand isInline matcher to VarDecl

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118900/new/ https://reviews.llvm.org/D118900

[PATCH] D119599: [clang-format] Add option to align compound assignments like `+=`

curdeius added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:406 + + Options for aligning stuff. Stuff? Comment at: clang/docs/ClangFormatStyleOptions.rst:482-483 + + * ``bool AlignCompound`` Only for ``AlignConsecutiv

[PATCH] D120313: [clang][www] Port make_cxx_dr_status script to Python3

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/www/cxx_dr_status.html:15003 + \ No newline at end of file It doesn't matter overly much, but it might be reasonable t

[PATCH] D113319: [clang-format] Improve require and concept handling

krasimir added a comment. It appears that this causes a regression by adding a space in-between pointer dereferences `*p` -> `* p` in some cases, e.g. formatting this with llvm style: // before void f() { while (p < a && *p == 'a') p++; } // after void f() { while (p < a

[PATCH] D120307: [X86] Add helper macros for ternary intrinsics

pengfei updated this revision to Diff 410520. pengfei marked 2 inline comments as done. pengfei added a comment. In D120307#3337352 , @RKSimon wrote: > Are similar macros used by any other compilers at all? Not so far. GCC folks agreed to add them. I'll

[PATCH] D120315: [clang-format] Fix preprocessor nesting after commit 529aa4b011c4ae808d658022ef643c44dd9b2c9c

krasimir updated this revision to Diff 410521. krasimir marked an inline comment as done. krasimir added a comment. - address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120315/new/ https://reviews.llvm.org/D120315 Files: clang

[clang] c9592ae - [clang-format] Fix preprocessor nesting after commit 529aa4b011c4ae808d658022ef643c44dd9b2c9c

Author: Krasimir Georgiev Date: 2022-02-22T15:43:18+01:00 New Revision: c9592ae49b8c486754a745e0c7b1a30b92a12e8b URL: https://github.com/llvm/llvm-project/commit/c9592ae49b8c486754a745e0c7b1a30b92a12e8b DIFF: https://github.com/llvm/llvm-project/commit/c9592ae49b8c486754a745e0c7b1a30b92a12e8b.d

[PATCH] D120315: [clang-format] Fix preprocessor nesting after commit 529aa4b011c4ae808d658022ef643c44dd9b2c9c

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc9592ae49b8c: [clang-format] Fix preprocessor nesting after commit… (authored by krasimir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D120323: [clang][SVE] Add support for arithmetic operators on SVE types

DavidTruby created this revision. Herald added subscribers: ctetreau, psnobl, tschuett. Herald added a reviewer: efriedma. DavidTruby requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch implements support for the +, -, *, / and % ope

[clang] 02571f8 - [clang][www] Port make_cxx_dr_status script to Python3

Author: Timm Bäder Date: 2022-02-22T15:47:43+01:00 New Revision: 02571f86bb01bbea171072996533d7a6e63bba54 URL: https://github.com/llvm/llvm-project/commit/02571f86bb01bbea171072996533d7a6e63bba54 DIFF: https://github.com/llvm/llvm-project/commit/02571f86bb01bbea171072996533d7a6e63bba54.diff LO

[PATCH] D120324: [clang-format] Avoid parsing "requires" as a keyword in non-C++-like languages.

curdeius created this revision. curdeius added reviewers: MyDeveloperDay, HazardyKnusperkeks, owenpan, krasimir. curdeius requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes the issue raised post-review in D113319

[PATCH] D120313: [clang][www] Port make_cxx_dr_status script to Python3

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG02571f86bb01: [clang][www] Port make_cxx_dr_status script to Python3 (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org/D120

[PATCH] D113319: [clang-format] Improve require and concept handling

curdeius added a comment. In D113319#3337485 , @krasimir wrote: > It appears that after this patch clang-format started breaking up `requires` > in javascript, e.g.: > > // before > function f() { > var requires = {}; > } > // after > funct

[PATCH] D118588: [C++20][Modules]5/8] Diagnose wrong import/export for partition CMIs.

iains updated this revision to Diff 410527. iains added a comment. rebased, revised testcases to use split-file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118588/new/ https://reviews.llvm.org/D118588 Files: clang/include/clang/Basic/Diagnost

[PATCH] D120325: [analyzer] Don't crash if the analyzer-constraint is set to Z3, but llvm is not built with it

Szelethus created this revision. Szelethus added reviewers: NoQ, dkrupp, steakhal, martong, balazske. Szelethus added a project: clang. Herald added subscribers: ASDenysPetrov, gamesh411, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Szelethus requested r

[PATCH] D118589: [C++20][Modules][6/8] Record direct module imports.

iains updated this revision to Diff 410528. iains added a comment. rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118589/new/ https://reviews.llvm.org/D118589 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/SemaModule.cpp Index

[PATCH] D120266: [clang][CodeGen] Avoid emitting ifuncs with undefined resolvers

erichkeane added a comment. So to clarify: The purpose of this patch is to change the call to an 'ifunc' (named FOO.ifunc) to an llvm::Function with the same name? And this later gets replaced by the cpu-dispatch version in the other translation unit? (or, is a linker failure?). Repository:

[PATCH] D113319: [clang-format] Improve require and concept handling

M=0 C=0 T=Unknown S=1 F=0 B=0 BK=0 P=0 Name=eof L=0 PPK=2 FakeLParens= FakeRParens=0 II=0x0 Text='' while (p < q && *p) ; whereas it was (correctly) a unary operator: clang-format-main-20220222-e0219872--style=file --debug-only=format-token-annotator test.c

[PATCH] D120324: [clang-format] Avoid parsing "requires" as a keyword in non-C++-like languages.

krasimir accepted this revision. krasimir added a comment. This revision is now accepted and ready to land. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120324/new/ https://reviews.llvm.org/D120324 _

[PATCH] D119199: replace clang LLVM_ENABLE_PLUGINS -> CLANG_PLUGIN_SUPPORT in tests

vtjnash added a comment. Is that a bug in clang or in MSVC2019? We expected that CLANG_PLUGIN_SUPPORT=ON can expose problems with the Windows linker, and we add new tests here for verifying that configuration is functioning as expected. You might need to disable CLANG_PLUGIN_SUPPORT on that tar

[clang] f8cedc6 - [clang] Never wrap a nullptr in CXXNewExpr::getArraySize()

Author: Timm Bäder Date: 2022-02-22T16:27:32+01:00 New Revision: f8cedc642d9b85720cb7175ef25ddde90a3fbca2 URL: https://github.com/llvm/llvm-project/commit/f8cedc642d9b85720cb7175ef25ddde90a3fbca2 DIFF: https://github.com/llvm/llvm-project/commit/f8cedc642d9b85720cb7175ef25ddde90a3fbca2.diff LO

[PATCH] D119525: [clang] Fix crash when array size is missing in initializer

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. tbaeder marked an inline comment as done. Closed by commit rGf8cedc642d9b: [clang] Never wrap a nullptr in CXXNewExpr::getArraySize() (authored by tbaeder). Repository

[clang] 535a230 - Fix docs build after f8cedc642d9b85720cb7175ef25ddde90a3fbca2

Author: Timm Bäder Date: 2022-02-22T16:35:35+01:00 New Revision: 535a23053bbb0945b7ed0925cbc7d6d7227487f7 URL: https://github.com/llvm/llvm-project/commit/535a23053bbb0945b7ed0925cbc7d6d7227487f7 DIFF: https://github.com/llvm/llvm-project/commit/535a23053bbb0945b7ed0925cbc7d6d7227487f7.diff LO

[PATCH] D120251: [clang][driver][wasm] Fix libstdc++ target-dependent include dir

sbc100 added a comment. In D120251#3336981 , @tbaeder wrote: > @sbc100 Do you think we should add `/backward` as well? `Gnu.cpp` does that > it seems: > https://github.com/llvm/llvm-project/blob/main/clang/lib/Driver/ToolChains/Gnu.cpp#L2959-L2960 I do

[PATCH] D104931: [AArch64] Wire up ILP32 ABI support in Clang

Amanieu added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104931/new/ https://reviews.llvm.org/D104931 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[clang] fee4a97 - [clang-format] Use FormatToken::is* functions without passing through `Tok`. NFC.

Author: Marek Kurdej Date: 2022-02-22T16:41:15+01:00 New Revision: fee4a9712f58caa9f1c3fc6c76ac46c5407475b6 URL: https://github.com/llvm/llvm-project/commit/fee4a9712f58caa9f1c3fc6c76ac46c5407475b6 DIFF: https://github.com/llvm/llvm-project/commit/fee4a9712f58caa9f1c3fc6c76ac46c5407475b6.diff

[PATCH] D119128: [analyzer] Fix taint propagation by remembering to the location context

Szelethus added a comment. Can we reopen this if the code is not upstream at this time? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119128/new/ https://reviews.llvm.org/D119128 ___ cfe-commits mailing

[clang] 071f870 - [clang-format] Avoid parsing "requires" as a keyword in non-C++-like languages.

Author: Marek Kurdej Date: 2022-02-22T16:55:38+01:00 New Revision: 071f870e7ff0a3d04f0d93852ff7c29b59111f78 URL: https://github.com/llvm/llvm-project/commit/071f870e7ff0a3d04f0d93852ff7c29b59111f78 DIFF: https://github.com/llvm/llvm-project/commit/071f870e7ff0a3d04f0d93852ff7c29b59111f78.diff

[PATCH] D120324: [clang-format] Avoid parsing "requires" as a keyword in non-C++-like languages.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG071f870e7ff0: [clang-format] Avoid parsing "requires" as a keyword in non-C++-like languages. (authored by curdeius). Repository: rG LLVM Github

[PATCH] D120310: [clang][analyzer] Add modeling of 'errno' (work-in-progress).

steakhal added a comment. Good start! However, I'm not a big fan of coupling the testing checker with the actual modeling checker. IMO we should have a distinct checker, similarly to `TaintTester`. That way you could do even fancier things like: define `mylib_may_fail()`, bifurcate and return `

[PATCH] D118875: [compiler-rt][builtins] build the macOS compiler-rt built-ins with Mac Catalyst support

thakis added a comment. Is landing this blocked on anything? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118875/new/ https://reviews.llvm.org/D118875 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[PATCH] D118598: [C++20][Modules][7/8] Find the primary interface name for a module.

iains updated this revision to Diff 410539. iains added a comment. rebased, addressed review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118598/new/ https://reviews.llvm.org/D118598 Files: clang/include/clang/Basic/Module.h clang/li

[PATCH] D119199: replace clang LLVM_ENABLE_PLUGINS -> CLANG_PLUGIN_SUPPORT in tests

cristian.adam added a comment. In D119199#3337699 , @vtjnash wrote: > Is that a bug in clang or in MSVC2019? We expected that > CLANG_PLUGIN_SUPPORT=ON can expose problems with the Windows linker, and we > add new tests here for verifying that configura

[PATCH] D118757: [AArch64] Remove unused feature flags from AArch64TargetInfo

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8e10448cbbd9: [AArch64] Remove unused feature flags from AArch64TargetInfo (authored by tyb0807). Repository: rG LLVM Github Monorepo CHANGES SIN

[clang] 8e10448 - [AArch64] Remove unused feature flags from AArch64TargetInfo

Author: tyb0807 Date: 2022-02-22T16:13:44Z New Revision: 8e10448cbbd98e2496f8bc8985b6ee499b7ffcdd URL: https://github.com/llvm/llvm-project/commit/8e10448cbbd98e2496f8bc8985b6ee499b7ffcdd DIFF: https://github.com/llvm/llvm-project/commit/8e10448cbbd98e2496f8bc8985b6ee499b7ffcdd.diff LOG: [AArc

[PATCH] D119720: [ARM] Pass for Cortex-A57 and Cortex-A72 Fused AES Erratum

lenary added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119720/new/ https://reviews.llvm.org/D119720 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[clang] 79c9072 - Restore documentation for __builtin_assume

Author: serge-sans-paille Date: 2022-02-22T17:19:11+01:00 New Revision: 79c9072dc009693477242bc1347a2a6c3e419423 URL: https://github.com/llvm/llvm-project/commit/79c9072dc009693477242bc1347a2a6c3e419423 DIFF: https://github.com/llvm/llvm-project/commit/79c9072dc009693477242bc1347a2a6c3e419423.d

[PATCH] D120205: Restore documentation for __builtin_assume

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG79c9072dc009: Restore documentation for __builtin_assume (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

  1   2   3   >