[PATCH] D119004: [NFC][analyzer] Allow CallDescriptions to be matched with CallExprs

steakhal added a comment. In D119004#3299971 , @NoQ wrote: > The original `lookup()` isn't exactly precise either, it's just slightly more > precise as it has better access to path-sensitive information such as current > values of function pointers, but

[PATCH] D119094: [clang] Don't emit redundant warnings for 'return;'

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Makes sense to me, thanks! Comment at: clang/lib/Sema/SemaStmt.cpp:4102 +if (FD->isInvalidDecl()) { + // Don't redundantly warn about "return;" if the return t

[PATCH] D118104: Make run-clang-tidy.py print the configured checks correctly

JesApp added a comment. I'm not so much opposed to writing a test case for the one change I made (especially after @salman-javed-nz suggestion) as I am opposed to learning the build system. I've tried to set for a few minutes and oh man, that's a lot of targets... So yeah, If someone could mer

[clang] 65adf7c - [NFC][Analyzer] Use range based for loop.

Author: Jun Zhang Date: 2022-02-07T15:45:58+08:00 New Revision: 65adf7c2117ab2b2ff72a8c761164fb2c1b686c0 URL: https://github.com/llvm/llvm-project/commit/65adf7c2117ab2b2ff72a8c761164fb2c1b686c0 DIFF: https://github.com/llvm/llvm-project/commit/65adf7c2117ab2b2ff72a8c761164fb2c1b686c0.diff LOG

[PATCH] D119103: [NFC][Analyzer] Use range based for loop.

This revision was automatically updated to reflect the committed changes. Closed by commit rG65adf7c2117a: [NFC][Analyzer] Use range based for loop. (authored by junaire). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119103/new/ https://reviews.llv

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

JonasToth added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/CMakeLists.txt:33 LINK_LIBS + clangAnalysis clangTidy njames93 wrote: > Will this work under clangd as I don't think that links in the clangAnalysis > libraries @s

[clang] 1cee960 - [SYCL] Disallow explicit casts between mismatching address spaces

Author: Mariya Podchishchaeva Date: 2022-02-07T11:57:30+03:00 New Revision: 1cee9608982a866688434223bee44c878ea489b1 URL: https://github.com/llvm/llvm-project/commit/1cee9608982a866688434223bee44c878ea489b1 DIFF: https://github.com/llvm/llvm-project/commit/1cee9608982a866688434223bee44c878ea489

[PATCH] D118935: [SYCL] Disallow explicit casts between mismatching address spaces

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1cee9608982a: [SYCL] Disallow explicit casts between mismatching address spaces (authored by Fznamznon). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D119071: [Driver][OpenBSD] -r: imply -nostdlib like GCC

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119071/new/ https://reviews.llvm.org/D119071 __

[clang] 1831cbd - [Driver][OpenBSD] -r: imply -nostdlib like GCC

Author: Brad Smith Date: 2022-02-07T04:07:30-05:00 New Revision: 1831cbd9d4174a93d4017e510ecf0f840af5f7d6 URL: https://github.com/llvm/llvm-project/commit/1831cbd9d4174a93d4017e510ecf0f840af5f7d6 DIFF: https://github.com/llvm/llvm-project/commit/1831cbd9d4174a93d4017e510ecf0f840af5f7d6.diff LO

[PATCH] D119071: [Driver][OpenBSD] -r: imply -nostdlib like GCC

This revision was automatically updated to reflect the committed changes. Closed by commit rG1831cbd9d417: [Driver][OpenBSD] -r: imply -nostdlib like GCC (authored by brad). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119071/new/ https://reviews.l

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

sammccall added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/CMakeLists.txt:33 LINK_LIBS + clangAnalysis clangTidy JonasToth wrote: > njames93 wrote: > > Will this work under clangd as I don't think that links in the > > cla

[PATCH] D119077: clangd SemanticHighlighting: added support for highlighting overloaded operators

nridge added a comment. Thanks for the patch! Could you add some tests to clang-tools-extra/clangd/unittests/SemanticHighlightingTests.cpp as well? I wrote a bit about how the tests work on Discord, copying for convenience: > In SemanticHighlightingTests.cpp, we have code inputs which are anno

[PATCH] D114533: LLVM IR should allow bitcast between address spaces with the same size.

skc7 updated this revision to Diff 406351. skc7 added a comment. Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114533/new/ https://reviews.llvm.org/D114533 Files: clang/lib/CodeGen/CGAtomic.cpp llvm/docs/LangRef.rst llvm/include/llvm/Analysis/InstSimplifyFolder.h llvm/in

[PATCH] D104044: [clang-format] Fix the issue that empty lines being removed at the beginning of namespace

pem added a comment. I am looking forward for this // EmptyLineInsertion// feature. In D104044#2813515 , @MyDeveloperDay wrote: > Do we need a set options for when we want to insert/retain/add a newline > after various constructs? frankly I've been mul

[PATCH] D119077: clangd SemanticHighlighting: added support for highlighting overloaded operators

nridge added a comment. I haven't looked at the patch in detail, but one high level question: have you considered the possibility of adding these highlightings during the findExplicitReferences

[PATCH] D113874: [clang] Propagate requires-clause from constructor template to implicit deduction guide

nridge added reviewers: kadircet, sammccall. nridge added a comment. Adding some potential reviewers. I'm open to testing this some way other than through clangd, but note that, while the issue is not in AST serialization code, it only trips an assertion after a serialization round-trip. Repo

[PATCH] D117500: [clang] Mention MS on-demand TLS initialization in release notes

hans closed this revision. hans added a comment. Oh, right. And since the change landed before the branch, this should go on the 14.x release branch. Landed here: https://github.com/llvm/llvm-project/commit/20ea9e379984f240d7135843baae6999abf3bf2b Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D119116: [clangd] Pull AST printer helpers to Clang

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added projects: clang, clang-tools-extra. This will be ne

[PATCH] D118976: clangd: Set a diagnostic on a code action resulting from a tweak

ckandeler updated this revision to Diff 406359. ckandeler added a comment. Fixed Lint complaints Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118976/new/ https://reviews.llvm.org/D118976 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp Ind

[PATCH] D119117: [clang-format] Fix formatting of the array form of delete.

curdeius created this revision. curdeius added reviewers: MyDeveloperDay, HazardyKnusperkeks, owenpan. curdeius requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://github.com/llvm/llvm-project/issues/53576. There was an inconsist

[PATCH] D119008: Add Cortex-X1C to Clang LLVM 14 release notes

amilendra added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119008/new/ https://reviews.llvm.org/D119008 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D119117: [clang-format] Fix formatting of the array form of delete.

curdeius updated this revision to Diff 406363. curdeius added a comment. Revert unrelated changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119117/new/ https://reviews.llvm.org/D119117 Files: clang/lib/Format/TokenAnnotator.cpp clang/unit

[PATCH] D119116: [clangd] Pull AST printer helpers to Clang

kbobyrev updated this revision to Diff 406367. kbobyrev added a comment. Fix the build Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119116/new/ https://reviews.llvm.org/D119116 Files: clang-tools-extra/clangd/AST.cpp clang-tools-extra/clangd/

[PATCH] D119011: [clang] Cache OpenCL types

svenvh accepted this revision. svenvh added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119011/new/ https://reviews.llvm.org/D119011 __

[PATCH] D118985: [flang][driver] Add support for `-emit-mlir`

awarzynski added inline comments. Comment at: flang/include/flang/Frontend/FrontendActions.h:150 +//===--===// +class CodeGenAction : public FrontendAction { + schweitz wrote: > This appears in a

[clang] c15782b - [OpenCL] opencl-c.h: make attribute order consistent; NFC

Author: Sven van Haastregt Date: 2022-02-07T10:54:55Z New Revision: c15782bcf5c900fc43fd545c9572f77ef92c5f5e URL: https://github.com/llvm/llvm-project/commit/c15782bcf5c900fc43fd545c9572f77ef92c5f5e DIFF: https://github.com/llvm/llvm-project/commit/c15782bcf5c900fc43fd545c9572f77ef92c5f5e.diff

[PATCH] D114439: [Annotation] Allow parameter pack expansions and initializer lists in annotate attribute

steffenlarsen updated this revision to Diff 406373. steffenlarsen added a comment. Added a check to prevent duplicate "empty" constructors, i.e. if there are only optional arguments such as a single variadic argument. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114439/new/ https://re

[PATCH] D119124: Removing unnecessary condition

harishch4 created this revision. harishch4 added a reviewer: llvm-commits. harishch4 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix to https://github.com/llvm/llvm-project/issues/53545 Repository: rG LLVM Github Monorepo https://r

[PATCH] D118985: [flang][driver] Add support for `-emit-mlir`

awarzynski updated this revision to Diff 406377. awarzynski added a comment. Removed trailing "_" from member variable names, added a comment, updated CMake dependencies (needed after https://reviews.llvm.org/D118966) @schweitz, thank you for reviewing! If there are no new comments, I'll merge

[PATCH] D116160: [AArch64] ACLE feature macro for Armv8.8-A MOPS

tyb0807 abandoned this revision. tyb0807 added a comment. This is superseded by https://reviews.llvm.org/D118199. Comments have been addressed in the new patch. I should have commandeered this patch instead (did not know about this, sorry...). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D119012: [flang][driver] Add support for the `-emit-llvm` option

awarzynski updated this revision to Diff 406380. awarzynski added a comment. Rebase, remove trailing "_" from member variable names Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119012/new/ https://reviews.llvm.org/D119012 Files: clang/include/c

[PATCH] D119012: [flang][driver] Add support for the `-emit-llvm` option

awarzynski added a comment. This has been extracted from `fir-dev`. Original PR: https://github.com/flang-compiler/f18-llvm-project/pull/1113 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119012/new/ https://reviews.llvm.org/D119012 _

[PATCH] D119012: [flang][driver] Add support for the `-emit-llvm` option

rovka added inline comments. Comment at: flang/include/flang/Frontend/FrontendOptions.h:37 + /// Emit a .llvm file + EmitLLVM, Shouldn't this be .ll? Comment at: flang/lib/Frontend/FrontendActions.cpp:421 + // Set-up the MLIR pass manager

[PATCH] D118985: [flang][driver] Add support for `-emit-mlir`

kiranchandramohan added a comment. Few Nits/questions. Comment at: flang/lib/Frontend/FrontendActions.cpp:69 + + // Create a LoweringBridge + auto &defKinds = ci.invocation().semanticsContext().defaultKinds(); Nit: Can we remove the three autos below? =

[PATCH] D113874: [clang] Propagate requires-clause from constructor template to implicit deduction guide

kadircet added a comment. As for testing strategy, after this change the AST should look different. You can probably modify `clang/test/SemaTemplate/deduction-guide.cpp` to check for existence of requires clauses in the implicitly generated function templates for guides. Repository: rG LLVM

[clang-tools-extra] c63522e - [clang-tidy] Add new check 'shared-ptr-array-mismatch'.

Author: Balázs Kéri Date: 2022-02-07T12:57:58+01:00 New Revision: c63522e6ba7782c335043893ae7cbd37eca24fe5 URL: https://github.com/llvm/llvm-project/commit/c63522e6ba7782c335043893ae7cbd37eca24fe5 DIFF: https://github.com/llvm/llvm-project/commit/c63522e6ba7782c335043893ae7cbd37eca24fe5.diff L

[PATCH] D117306: [clang-tidy] Add new check 'shared-ptr-array-mismatch'.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc63522e6ba77: [clang-tidy] Add new check 'shared-ptr-array-mismatch'. (authored by balazske). Changed prior to commit: https://reviews.llvm.org/D1

[PATCH] D118471: [clang][Lexer] Make raw and normal lexer behave the same for line comments

kadircet added inline comments. Comment at: clang/unittests/Lex/LexerTest.cpp:654 + while (!L.LexFromRawLexer(T)) { +ASSERT_TRUE(!ToksView.empty()); +EXPECT_EQ(T.getKind(), ToksView.front().getKind()); probinson wrote: > @kadircet @sammccall It turns o

[PATCH] D118985: [flang][driver] Add support for `-emit-mlir`

awarzynski added inline comments. Comment at: flang/lib/Frontend/FrontendActions.cpp:69 + + // Create a LoweringBridge + auto &defKinds = ci.invocation().semanticsContext().defaultKinds(); kiranchandramohan wrote: > Nit: Can we remove the three autos below? Sur

[PATCH] D119130: [clangd] NFC: Move stdlibg headers handling to Clang

sammccall added a comment. The moved *.inc files are generated, the generator needs to be moved (and updated?) too I think. Is having clangd continue to include the .inc files textually intended to stay that way, or is it a FIXME? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D118985: [flang][driver] Add support for `-emit-mlir`

awarzynski updated this revision to Diff 406398. awarzynski added a comment. Remove `auto`, update comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118985/new/ https://reviews.llvm.org/D118985 Files: clang/include/clang/Driver/Options.td

[PATCH] D119130: [clangd] NFC: Move stdlibg headers handling to Clang

sammccall added a comment. This looks sensible to me, but as I wrote this code we should maybe get a second look (@kadircet?) that it makes sense to lift to clang::tooling. Some positive experience: we've used it successfully in an internal clang-tidy check. Comment at: clan

[PATCH] D119130: [clangd] NFC: Move stdlibg headers handling to Clang

kbobyrev updated this revision to Diff 406401. kbobyrev added a comment. Move include-mapping generators to clang and re-generate the files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119130/new/ https://reviews.llvm.org/D119130 Files: clang-

[PATCH] D118976: clangd: Set a diagnostic on a code action resulting from a tweak

ckandeler added a comment. It'd be great if you could merge this, as I don't have the necessary privileges. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118976/new/ https://reviews.llvm.org/D118976 ___

[clang] f597870 - [clang][Lexer] Fix tests after ff77071a4d67

Author: Kadir Cetinkaya Date: 2022-02-07T14:06:32+01:00 New Revision: f59787084e09aeb787cb3be3103b2419ccd14163 URL: https://github.com/llvm/llvm-project/commit/f59787084e09aeb787cb3be3103b2419ccd14163 DIFF: https://github.com/llvm/llvm-project/commit/f59787084e09aeb787cb3be3103b2419ccd14163.dif

[PATCH] D118044: [ARM] Undeprecate complex IT blocks

dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land. Thanks for the updates. LGTM. Comment at: llvm/test/CodeGen/ARM/ifcvt-branch-weight.ll:21 -; CHECK: bb.2.bb2: +; CHECK: bb.1.bb: ; CHECK: successors: %bb.4(0x4000),

[PATCH] D118755: [clangd] Crash in __memcmp_avx2_movbe

ivanmurashko updated this revision to Diff 406411. ivanmurashko added a comment. There are some changes: - unit test for HeaderIncludes was added - lit test for clangd was removed - Solution uses std::list instead of copying by value Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D118755: [clangd] Crash in __memcmp_avx2_movbe

ivanmurashko added inline comments. Comment at: clang/include/clang/Tooling/Inclusions/HeaderIncludes.h:100 // and "x" will be treated as the same header when deleting #includes. llvm::StringMap> ExistingIncludes; sammccall wrote: > An alternative would b

[PATCH] D118755: [clangd] Crash in __memcmp_avx2_movbe

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks, looks good! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118755/new/ https://reviews.llvm.org/D118755 __

[PATCH] D119130: [clangd] NFC: Move stdlibg headers handling to Clang

kadircet added a comment. Regarding the include mapping generator, I think it would've been better if we had some sort of list directly from libc++ (as this is now being part of clang rather than just clangd), but having the current symbol mapping available for other tools too is definitely a u

[PATCH] D118755: [clangd] Crash in __memcmp_avx2_movbe

sammccall added inline comments. Comment at: clang/include/clang/Tooling/Inclusions/HeaderIncludes.h:101 // and "x" will be treated as the same header when deleting #includes. - llvm::StringMap> ExistingIncludes; + llvm::StringMap> ExistingIncludes; May be

[PATCH] D119124: Removing unnecessary condition

harishch4 updated this revision to Diff 406412. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119124/new/ https://reviews.llvm.org/D119124 Files: clang/lib/Frontend/CompilerInstance.cpp Index: clang/lib/Frontend/CompilerInstance.cpp ===

[PATCH] D118924: [clang-format] Fix formatting of macro definitions with a leading comment.

curdeius updated this revision to Diff 406413. curdeius added a comment. Add tests, update in loop. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118924/new/ https://reviews.llvm.org/D118924 Files: clang/lib/Format/UnwrappedLineParser.cpp clan

[PATCH] D118924: [clang-format] Fix formatting of macro definitions with a leading comment.

curdeius updated this revision to Diff 406415. curdeius marked 2 inline comments as done. curdeius added a comment. Don't use `|=`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118924/new/ https://reviews.llvm.org/D118924 Files: clang/lib/Forma

[PATCH] D114439: [Annotation] Allow parameter pack expansions and initializer lists in annotate attribute

aaron.ballman added inline comments. Comment at: clang/include/clang/Sema/ParsedAttr.h:52-57 + /// The number of non-fake arguments specified in the attribute definition. + unsigned NumArgMembers : 4; /// True if the parsing does not match the semantic content. unsigned H

[clang-tools-extra] 29fc5e0 - [clang-tidy] Fixed a compile warning (NFC).

Author: Balázs Kéri Date: 2022-02-07T14:56:27+01:00 New Revision: 29fc5e0245cb360387cb8daac52c13dbc390fafd URL: https://github.com/llvm/llvm-project/commit/29fc5e0245cb360387cb8daac52c13dbc390fafd DIFF: https://github.com/llvm/llvm-project/commit/29fc5e0245cb360387cb8daac52c13dbc390fafd.diff L

[PATCH] D118755: [clangd] Crash in __memcmp_avx2_movbe

ivanmurashko updated this revision to Diff 406420. ivanmurashko edited the summary of this revision. ivanmurashko added a comment. Comment about std::list was added Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118755/new/ https://reviews.llvm.org/

[PATCH] D118755: [clangd] Crash in __memcmp_avx2_movbe

ivanmurashko updated this revision to Diff 406421. ivanmurashko added a comment. comment update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118755/new/ https://reviews.llvm.org/D118755 Files: clang/include/clang/Tooling/Inclusions/HeaderInclud

[PATCH] D119067: [clang-format] Fix DefinitionBlockSeparator extra empty lines

ksyx marked an inline comment as done. ksyx added inline comments. Comment at: clang/unittests/Format/DefinitionBlockSeparatorTest.cpp:305 " int r = j / k;\n" + " if (struct S = getS()) {\n" + "// if condition

[PATCH] D119012: [flang][driver] Add support for the `-emit-llvm` option

awarzynski added inline comments. Comment at: flang/lib/Frontend/FrontendActions.cpp:421 + // Set-up the MLIR pass manager + fir::setTargetTriple(*mlirModule_, "native"); + auto &defKinds = ci.invocation().semanticsContext().defaultKinds(); rovka wrote: > Nit:

[PATCH] D118350: [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct member is passed to a function

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:5212-5215 + const Expr *AArg = Arg->IgnoreParens(); + if (const auto *ICE = dyn_cast(AArg)) { +AArg = ICE->getSubExpr(); +if (const auto *ME = dyn_cast(AArg)) { I don't see

[PATCH] D119077: clangd SemanticHighlighting: added support for highlighting overloaded operators

iannisdezwart updated this revision to Diff 406422. iannisdezwart added a comment. Two changes: 1. Added tests for overloaded operators into SemanticHighlightingTests. 2. Fixed the way tokens are expanded. Previously `operator<<` would be split into two highlighting tokens: `operator` and `<<`.

[PATCH] D119012: [flang][driver] Add support for the `-emit-llvm` option

awarzynski updated this revision to Diff 406425. awarzynski marked 2 inline comments as done. awarzynski added a comment. Update comments + add an `assert` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119012/new/ https://reviews.llvm.org/D119012

[clang] d7ddad4 - Reformat CastExpr unittest suite; NFC

Author: Kim Gräsman Date: 2022-02-07T09:21:41-05:00 New Revision: d7ddad408f5b64df39a39f4af3a631275961b975 URL: https://github.com/llvm/llvm-project/commit/d7ddad408f5b64df39a39f4af3a631275961b975 DIFF: https://github.com/llvm/llvm-project/commit/d7ddad408f5b64df39a39f4af3a631275961b975.diff L

[PATCH] D118924: [clang-format] Fix formatting of macro definitions with a leading comment.

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:3609 +// on line. +FirstNonCommentOnLine |= IsFirstOnLine(*FormatTok); + } else { There it is again. ;) The if is the same as above, isn't it? R

[clang] a70549a - [clang-format] Fix DefSeparator empty line issues

Author: ksyx Date: 2022-02-07T14:23:21Z New Revision: a70549ae43dfa551f3eacdfa7a7f2c0df073be8e URL: https://github.com/llvm/llvm-project/commit/a70549ae43dfa551f3eacdfa7a7f2c0df073be8e DIFF: https://github.com/llvm/llvm-project/commit/a70549ae43dfa551f3eacdfa7a7f2c0df073be8e.diff LOG: [clang-f

[PATCH] D117390: [AST] Reformat CastExpr unittest suite

aaron.ballman closed this revision. aaron.ballman added a comment. In D117390#3290715 , @kimgr wrote: > @aaron.ballman Thanks! Please use Kim Gräsman and kim.grasman at gmail.com. You're welcome. I've pushed on your behalf in d7ddad408f5b64df39a39f4af3a

[PATCH] D119067: [clang-format] Fix DefinitionBlockSeparator extra empty lines

This revision was automatically updated to reflect the committed changes. Closed by commit rGa70549ae43df: [clang-format] Fix DefSeparator empty line issues (authored by ksyx). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119067/new/ https://review

[PATCH] D119012: [flang][driver] Add support for the `-emit-llvm` option

awarzynski updated this revision to Diff 406428. awarzynski added a comment. Remove the calls to `setTargetTriple` and `setKindMapping`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119012/new/ https://reviews.llvm.org/D119012 Files: clang/incl

[PATCH] D119077: clangd SemanticHighlighting: added support for highlighting overloaded operators

iannisdezwart accepted this revision. iannisdezwart added a comment. This revision is now accepted and ready to land. In D119077#3300271 , @nridge wrote: > I haven't looked at the patch in detail, but one high level question: have > you considered the po

[PATCH] D118605: [OpenCL] Add support of language builtins for OpenCL C 3.0

azabaznov updated this revision to Diff 406434. azabaznov added a comment. Check only against specific language option, remove unused LanguageIDs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118605/new/ https://reviews.llvm.org/D118605 Files: c

[PATCH] D118605: [OpenCL] Add support of language builtins for OpenCL C 3.0

azabaznov marked 4 inline comments as done. azabaznov added inline comments. Comment at: clang/lib/Basic/Builtins.cpp:79 + bool OclBlocksUnsupported = + (LangOpts.getOpenCLCompatibleVersion() < 200 || !LangOpts.Blocks) && + (BuiltinInfo.Langs & OCL_BLOCKS); ---

[PATCH] D118924: [clang-format] Fix formatting of macro definitions with a leading comment.

curdeius updated this revision to Diff 406437. curdeius marked an inline comment as done. curdeius added a comment. Clean up. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118924/new/ https://reviews.llvm.org/D118924 Files: clang/lib/Format/Unwr

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

cor3ntin created this revision. cor3ntin requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Implement P2036R3. Captured variables by copy (explicitely or not), are deduced correctly at the point we

[PATCH] D118924: [clang-format] Fix formatting of macro definitions with a leading comment.

curdeius added a comment. @HazardyKnusperkeks, sorry for that. Should be better now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118924/new/ https://reviews.llvm.org/D118924 ___ cfe-commits mailing lis

[PATCH] D118104: Make run-clang-tidy.py print the configured checks correctly

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D118104#3297315 , @LegalizeAdulthood wrote: > In D118104#3296467 , > @salman-javed-nz wrot

[PATCH] D117569: Constexpr not supported with __declspec(dllimport).

zahiraam updated this revision to Diff 406443. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117569/new/ https://reviews.llvm.org/D117569 Files: clang/lib/AST/ExprConstant.cpp clang/test/CodeGenCXX/PR19955.cpp clang/test/CodeGenCXX/dllimport.cpp clang/test/SemaCXX/PR19955.cpp c

[PATCH] D118880: [analyzer] Improve NoOwnershipChangeVisitor's understanding of deallocators

steakhal added a comment. I like it. nits here and there; Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/CallDescription.h:102 + /// Returns true if the CallEvent is a call to a function that matches + /// the CallDescription. CallExpr

[PATCH] D113319: [clang-format] Improve require and concept handling

HazardyKnusperkeks updated this revision to Diff 406444. HazardyKnusperkeks added a comment. Small fix in the test. For this change it is not relevant, but for the next one. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113319/new/ https://reviews.llvm.org/D113319 Files: clang/docs/C

[PATCH] D119138: [clang-format] Further improve support for requires expressions

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: MyDeveloperDay, curdeius, owenpan. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Detect req

[PATCH] D116597: [analyzer] Don't track function calls as control dependencies

steakhal added a comment. Looks great! Thanks for your hard work on this topic @Szelethus. Comment at: clang/lib/Analysis/CFG.cpp:5908-5909 +void CFG::dump(bool ShowColors) const { dump(LangOptions{}, ShowColors); } + /// print - A simple pretty printer of a CFG that outputs

[PATCH] D113369: [clang-format] Extend SpaceBeforeParens for requires

HazardyKnusperkeks updated this revision to Diff 406450. HazardyKnusperkeks marked 4 inline comments as done. HazardyKnusperkeks added a reviewer: curdeius. HazardyKnusperkeks removed a subscriber: curdeius. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. - Reb

[PATCH] D113369: [clang-format] Extend SpaceBeforeParens for requires

HazardyKnusperkeks requested review of this revision. HazardyKnusperkeks added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:3756 + * ``bool AfterRequiresClause`` If ``true``, put space between requires keyword in a requires clause and +opening parenth

[PATCH] D119077: clangd SemanticHighlighting: added support for highlighting overloaded operators

iannisdezwart updated this revision to Diff 406452. iannisdezwart added a comment. Fixed formatting & reverted a deleted FIXME comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119077/new/ https://reviews.llvm.org/D119077 Files: clang-tools-extra/clangd/SemanticHighlighting.cpp

[PATCH] D113369: [clang-format] Extend SpaceBeforeParens for requires

Quuxplusone added inline comments. Comment at: clang/include/clang/Format/Format.h:3371 +/// If ``true``, put space between requires keyword in a requires clause and +/// opening parentheses, if there is one. +/// \code HazardyKnusperkeks wrote: > Qu

[PATCH] D118044: [ARM] Undeprecate complex IT blocks

MarkMurrayARM marked 2 inline comments as done. MarkMurrayARM added inline comments. Comment at: llvm/test/CodeGen/ARM/ifcvt-branch-weight.ll:21 -; CHECK: bb.2.bb2: +; CHECK: bb.1.bb: ; CHECK: successors: %bb.4(0x4000), %bb.3(0x4000) dmgreen wrote: > I

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/ConstCorrectnessCheck.cpp:102-105 + // There have been crashes on 'Variable == nullptr', even though the matcher + // is not conditional. This comes probably from 'findAll'-matching. +

[PATCH] D119144: [tests][Driver] Pass an empty sysroot for `DEFAULT_SYSROOT` builds

carlocab created this revision. carlocab added a reviewer: abidh. carlocab added a project: clang. Herald added a subscriber: ki.stfu. carlocab requested review of this revision. Herald added a subscriber: cfe-commits. The `baremetal-sysroot` test fails when the toolchain is configured with `DEFAU

[PATCH] D118876: [HIPSPV] Fix literals are mapped to Generic address space

yaxunl added a comment. It has been cherry-picked to 14.x by 02d5b112 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118876/new/ https://reviews.llvm.org/D118876 ___

[PATCH] D117795: [AArch64] Add some missing strict FP vector lowering

dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land. Thanks for the changes. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117795/new/ https://reviews.llvm.org/D117795 ___ cfe-commits

[clang] cdc0573 - [MatrixBuilder] Remove unnecessary IRBuilder template (NFC)

Author: Nikita Popov Date: 2022-02-07T16:42:38+01:00 New Revision: cdc0573f753e639ed78f2a3645179ac2d2718fd0 URL: https://github.com/llvm/llvm-project/commit/cdc0573f753e639ed78f2a3645179ac2d2718fd0 DIFF: https://github.com/llvm/llvm-project/commit/cdc0573f753e639ed78f2a3645179ac2d2718fd0.diff

[PATCH] D118690: [analyzer] Prevent misuses of -analyze-function

steakhal updated this revision to Diff 406463. steakhal added a comment. - pin target triple to (possibly) resolve the build bot failure - add obj-c test case CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118690/new/ https://reviews.llvm.org/D118690 Files: clang/lib/StaticAnalyzer/Fr

[clang] 807e2f1 - Revert "Remove -Wweak-template-vtables"

Author: Hans Wennborg Date: 2022-02-07T16:52:23+01:00 New Revision: 807e2f12fab52c6abf3e89c02eec0f585b3b8f22 URL: https://github.com/llvm/llvm-project/commit/807e2f12fab52c6abf3e89c02eec0f585b3b8f22 DIFF: https://github.com/llvm/llvm-project/commit/807e2f12fab52c6abf3e89c02eec0f585b3b8f22.diff

[PATCH] D114439: [Annotation] Allow parameter pack expansions and initializer lists in annotate attribute

steffenlarsen updated this revision to Diff 406468. steffenlarsen added a comment. Recent changes: - Replaces `isExprArg` with `isArgMemberExprHolder` which returns true if the "argument member" can hold one or more expressions. - Renames `checkStringLiteralExpr` to `checkASCIIStringLiteralExpr`

[PATCH] D117391: [AST] Ignore implicit nodes in CastExpr::getConversionFunction

aaron.ballman added a comment. In D117391#3299483 , @kimgr wrote: > I have now convinced myself that including `FullExpr` in > `skipImplicitTemporary` gives an improvement in `consteval` diagnostics. But > I'm still not sure why. Motivating example, der

[clang] c45a99f - [MatrixBuilder] Require explicit element type in CreateColumnMajorLoad()

Author: Nikita Popov Date: 2022-02-07T16:57:33+01:00 New Revision: c45a99f36b6e87440765572bd38cbd515c60173a URL: https://github.com/llvm/llvm-project/commit/c45a99f36b6e87440765572bd38cbd515c60173a DIFF: https://github.com/llvm/llvm-project/commit/c45a99f36b6e87440765572bd38cbd515c60173a.diff

[PATCH] D119094: [clang] Don't emit redundant warnings for 'return;'

Quuxplusone planned changes to this revision. Quuxplusone added a comment. Unfortunately some existing tests fail: https://reviews.llvm.org/harbormaster/unit/view/2282838/ I haven't yet figured out why consteval functions are considered to have `FD->isInvalidDecl()`. There's also an Objective-C

[PATCH] D119138: [clang-format] Further improve support for requires expressions

curdeius added a comment. Some nits. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1541-1542 +case tok::kw_requires: { + bool Return = parseRequires(); + if (Return) +return; Comment at: clang/lib/Format/Unwrappe

[PATCH] D114439: [Annotation] Allow parameter pack expansions and initializer lists in annotate attribute

steffenlarsen added inline comments. Comment at: clang/include/clang/Sema/ParsedAttr.h:113 } + // Check if argument at index I is an expression argument + virtual bool isExprArg(size_t N) const { return false; } aaron.ballman wrote: > I don't think this API

  1   2   3   >