[PATCH] D87587: [clang-format][PR47290] Add ShortNamespaceLines format option

HazardyKnusperkeks added a comment. In D87587#2597241 , @kuzkry wrote: > Thank you for delivering it, @HazardyKnusperkeks. > > One thing concerns me though. I'm not an author of changes done in > clang/docs/ClangFormatStyleOptions.rst in lines 2372, 3069-

[PATCH] D97362: [clang][parser] Allow attributes in explicit template instantiations

tbaeder added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:1618 + +if (Tok && (*Tok).is(tok::l_square)) { + Diag(Attrs.Range.getBegin(), diag::err_attributes_not_allowed) << Attrs.Range; aaron.ballman wrote: > This will incorrectly classif

[PATCH] D97916: [Driver][RISCV] Support parsing multi-lib config from GCC.

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/RISCV.cpp:727 +{ + /* Default code model is small(medlow). */ + StringRef CodeModel; `//` Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:1595 +return GCCPath.st

[PATCH] D96586: [analyzer][CTU][NFC] Add an extra regression test

steakhal added a comment. In D96586#2601856 , @NoQ wrote: >> `-analyzer-opt-analyze-headers` > > I'm actually shocked that we provide such option at all. And that it's the > first option in the list in `scan-build --help`. And that I haven't noticed > it

[PATCH] D97916: [Driver][RISCV] Support parsing multi-lib config from GCC.

kito-cheng added inline comments. Comment at: clang/test/Driver/riscv64-toolchain.c:158 +// RUN: %clang %s \ +// RUN: -target riscv64-unknown-elf \ +// RUN: --gcc-toolchain=%S/Inputs/multilib_riscv64_elf_sdk \ MaskRay wrote: > Hmm. I happened to have posted

[PATCH] D97894: [Driver] Drop $sysroot/usr special case from Gentoo gcc-config detection

mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. Well, I think this was mostly 'just in case' condition, so I guess it's fine. Let's just wait for @manojgupta to give it some more testing. Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D97916: [Driver][RISCV] Support parsing multi-lib config from GCC.

kito-cheng updated this revision to Diff 328062. kito-cheng added a comment. Address MaskRay's comment and apply clang-format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97916/new/ https://reviews.llvm.org/D97916 Files: clang/include/clang/Ba

[PATCH] D97916: [Driver][RISCV] Support parsing multi-lib config from GCC.

kito-cheng marked 3 inline comments as done. kito-cheng added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/RISCV.cpp:727 +{ + /* Default code model is small(medlow). */ + StringRef CodeModel; MaskRay wrote: > `//` Thanks, I guess some time my

[PATCH] D97058: [OpenCL] Refactor diagnostic for OpenCL extension/feature

azabaznov added inline comments. Comment at: clang/lib/Sema/Sema.cpp:364 for (auto &I : Atomic64BitTypes) setOpenCLExtensionForType(I, "cl_khr_int64_base_atomics cl_khr_int64_extended_atomics"); Anastasia wrote: > I think this should

[PATCH] D92808: [ObjC][ARC] Use operand bundle 'clang.arc.attachedcall' instead of explicitly emitting retainRV or claimRV calls in the IR

hans added a comment. In D92808#2601408 , @fhahn wrote: > In D92808#2600245 , @hans wrote: > >> Reverted in >> https://github.com/llvm/llvm-project/commit/0a5dd067181dac2a8882a139ea3bd19bdea5fa44 >> until this can

[PATCH] D94500: [clang-format] Rework Whitesmiths mode to use line-level values in UnwrappedLineParser

HazardyKnusperkeks added a comment. Could you please rebase your patch an reupload the diff, it doesn't apply anymore. (And doing it by hand is too much work for me.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94500/new/ https://reviews.llvm.or

[PATCH] D97548: [clangd] Introduce client state invalidation

kadircet updated this revision to Diff 328067. kadircet marked an inline comment as done. kadircet added a comment. - Rename method and update comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97548/new/ https://reviews.llvm.org/D97548 Files:

[PATCH] D96760: [clang-format] Suppress diagnostics on second parse

HazardyKnusperkeks updated this revision to Diff 328075. HazardyKnusperkeks added a comment. Rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96760/new/ https://reviews.llvm.org/D96760 Files: clang/include/clang/Format/Format.h clang/lib

[PATCH] D97803: [clangd] Overload bundles are only deprecated if each overloads is.

kbobyrev added a comment. So, if my understanding is correct, this will make the whole bundle non-deprecated if at least one overload is not deprecated? This is probably an improvement over the existing behaviour. However, do we maybe want to split the bundles into deprecated and non-deprecated

[PATCH] D97555: [clangd] Add diagnostic augmentation hook to Modules

kadircet added inline comments. Comment at: clang-tools-extra/clangd/Module.h:97 + /// Called by auxilary threads as diagnostics encountered to generate fixes. + /// So this can be called concurrently from multiple threads. If a module sammccall wrote: > This

[PATCH] D97688: clang-format: use `pb` as a canonical raw string delimiter for google style

krasimir updated this revision to Diff 328079. krasimir added a comment. Update tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97688/new/ https://reviews.llvm.org/D97688 Files: clang/unittests/Format/FormatTestRawStrings.cpp Index: clang/

[PATCH] D97688: clang-format: use `pb` as a canonical raw string delimiter for google style

krasimir updated this revision to Diff 328081. krasimir added a comment. Collect commits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97688/new/ https://reviews.llvm.org/D97688 Files: clang/lib/Format/ContinuationIndenter.cpp clang/lib/Format

[PATCH] D97901: [SystemZ] Test for infinity in testFPKind().

thopre added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:7229 + case Builtin::BI__builtin_isfinite: +Invert = true; +LLVM_FALLTHROUGH; jonpa wrote: > What are these variants all about...? > They were introduced in https://r

[PATCH] D97548: [clangd] Introduce client state invalidation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1d7b328198a7: [clangd] Introduce client state invalidation (authored by kadircet). Changed prior to commit: https://reviews.llvm.org/D97548?vs=328

[clang-tools-extra] 1d7b328 - [clangd] Introduce client state invalidation

Author: Kadir Cetinkaya Date: 2021-03-04T11:15:10+01:00 New Revision: 1d7b328198a7dd1e26ffd76256a3427134d39951 URL: https://github.com/llvm/llvm-project/commit/1d7b328198a7dd1e26ffd76256a3427134d39951 DIFF: https://github.com/llvm/llvm-project/commit/1d7b328198a7dd1e26ffd76256a3427134d39951.dif

[PATCH] D97927: [clang-format] Rename case sorting

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: kentsommer, curdeius, MyDeveloperDay, PragmaNull. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-comm

[PATCH] D97119: [flang][driver] Add options for -std=f2018

bryanpkc added a comment. I agree with @richard.barton.arm that we could add `-std=` now, even if only for a subset of possible language standards. I expect that standard conformance checks would be quite pervasive, and it would be better to design the infrastructure for such checks earlier rat

[PATCH] D96245: [clangd] Propagate CodeActions in addition to Fixes for diagnostics

kadircet added a comment. In D96245#2602293 , @sammccall wrote: > Will the fixes/actions this enables really be available synchronously? The fixes stay as is today, but the action might be just a command that needs to be invoked by the client (so it is s

[PATCH] D88905: [Clang] Allow "ext_vector_type" applied to Booleans

simoll added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88905/new/ https://reviews.llvm.org/D88905 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

bader updated this revision to Diff 328100. bader marked 4 inline comments as done. bader added a comment. Apply suggestions from Aaron. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89909/new/ https://reviews.llvm.org/D89909 Files: clang/includ

[PATCH] D97869: [OpenCL][Draft] Add OpenCL builtin test generator

Anastasia added a comment. > `` > > float test6092_cos(float arg1) { > return cos(arg1); > } > double test6093_cos(double arg1) { > return cos(arg1); > } > half test6094_cos(half arg1) { > return cos(arg1); > } > float2 test6095_cos(float2 arg1) { > return cos(arg1);

[PATCH] D96090: [analyzer] Replace StoreManager::CastRetrievedVal with SValBuilder::evalCast

ASDenysPetrov updated this revision to Diff 328105. ASDenysPetrov added a comment. Rebased on main. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96090/new/ https://reviews.llvm.org/D96090 Files: clang/include/clang/StaticAnalyzer/Core/PathSensitive/SValBuilder.h clang/include/clan

[PATCH] D97277: [analyzer] Eliminate dispatchCast, evalCastFromNonLoc and evalCastFromLoc functions from SValBuilder

ASDenysPetrov updated this revision to Diff 328106. ASDenysPetrov added a comment. Rebased on main. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97277/new/ https://reviews.llvm.org/D97277 Files: clang/include/clang/StaticAnalyzer/Core/PathSensitive/SValBuilder.h clang/lib/StaticAn

[PATCH] D97296: [analyzer] Add a new parameter ProgramStateRef to SValBuilder::evalCast function

ASDenysPetrov updated this revision to Diff 328107. ASDenysPetrov added a comment. Rebased on main. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97296/new/ https://reviews.llvm.org/D97296 Files: clang/include/clang/StaticAnalyzer/Core/PathSensitive/Environment.h clang/include/clan

[PATCH] D97388: [analyzer] Replace StoreManager::evalIntegralCast with SValBuilder::evalCast

ASDenysPetrov updated this revision to Diff 328108. ASDenysPetrov added a comment. Rebased on main. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97388/new/ https://reviews.llvm.org/D97388 Files: clang/include/clang/StaticAnalyzer/Core/PathSensitive/SValBuilder.h clang/lib/StaticAn

[PATCH] D97874: [analyzer] Improve SVal cast from integer to bool using known RangeSet

ASDenysPetrov updated this revision to Diff 328109. ASDenysPetrov added a comment. Rebased on main. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97874/new/ https://reviews.llvm.org/D97874 Files: clang/include/clang/StaticAnalyzer/Core/PathSensitive/ConstraintManager.h clang/lib/St

[PATCH] D97834: [WebAssembly] Disable uses of __clang_call_terminate

aheejin updated this revision to Diff 328116. aheejin added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97834/new/ https://reviews.llvm.org/D97834 Files: clang/lib/CodeGen/CGException.cpp clang/lib/CodeGen/Itanium

[PATCH] D97901: [SystemZ] Test for infinity in testFPKind().

uweigand added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:7229 + case Builtin::BI__builtin_isfinite: +Invert = true; +LLVM_FALLTHROUGH; thopre wrote: > jonpa wrote: > > What are these variants all about...? > > > They were

[PATCH] D97930: [OpenCL] Fix builtins that require multiple extensions

svenvh created this revision. svenvh added a reviewer: Anastasia. svenvh added a project: clang. Herald added a subscriber: yaxunl. svenvh requested review of this revision. Herald added a subscriber: cfe-commits. Builtins that require multiple extensions, such as certain `write_imagef` forms, wer

[PATCH] D94640: adds more checks to -Wfree-nonheap-object

Ka-Ka added a comment. This patch seems to introduce warnings for the case #include #include void foo(void* ptr) { free((void*)(intptr_t) ptr); } something that gcc don't warn for (see https://godbolt.org/z/1WT9c6 ). As intptr_t is suppose to be used to pass pointers in I think its a bit

[PATCH] D97901: [SystemZ] Test for infinity in testFPKind().

thopre added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:7229 + case Builtin::BI__builtin_isfinite: +Invert = true; +LLVM_FALLTHROUGH; uweigand wrote: > thopre wrote: > > jonpa wrote: > > > What are these variants all about.

[PATCH] D97512: [clang] removes check against integral-to-pointer conversion...

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! I think we can resolve the question of which way to ignore implicit nodes and make any necessary changes post-commit. Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] b7aeece - Revert "Stop traping on sNaN in __builtin_isinf"

Author: Thomas Preud'homme Date: 2021-03-04T12:07:35Z New Revision: b7aeece47ce58fc44d699979f1ce80ab42837fd6 URL: https://github.com/llvm/llvm-project/commit/b7aeece47ce58fc44d699979f1ce80ab42837fd6 DIFF: https://github.com/llvm/llvm-project/commit/b7aeece47ce58fc44d699979f1ce80ab42837fd6.diff

[PATCH] D94640: adds more checks to -Wfree-nonheap-object

lebedev.ri added a comment. > <...> Is the patch still not reverted? That should have happened almost a week ago. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94640/new/ https://reviews.llvm.org/D94640 ___

[PATCH] D97869: [OpenCL][Draft] Add OpenCL builtin test generator

svenvh added a comment. In D97869#2602943 , @Anastasia wrote: > I was just thinking if we could combine the calls into one function to > minimize the number of lines to parse? Perhaps this will make the Tablegen > generator too complex? That will increa

[PATCH] D94640: adds more checks to -Wfree-nonheap-object

aaron.ballman added a comment. In D94640#2603054 , @lebedev.ri wrote: >> <...> > > Is the patch still not reverted? > That should have happened almost a week ago. FWIW, the fix for the issue was just approved. Repository: rG LLVM Github Monorepo CHAN

[clang] 6d6e713 - Revert "Add __builtin_isnan(__fp16) testcase"

Author: Thomas Preud'homme Date: 2021-03-04T12:18:03Z New Revision: 6d6e7132f9c7bb1fc7b6771ae90ccf8810e9f22e URL: https://github.com/llvm/llvm-project/commit/6d6e7132f9c7bb1fc7b6771ae90ccf8810e9f22e DIFF: https://github.com/llvm/llvm-project/commit/6d6e7132f9c7bb1fc7b6771ae90ccf8810e9f22e.diff

[PATCH] D97927: [clang-format] Rename case sorting

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM. It's indeed more logical this way. Hopefully the original author will confirm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97927/new/

[PATCH] D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics.

craig.topper added inline comments. Comment at: clang/utils/TableGen/RISCVVEmitter.cpp:58-62 + bool IsPointer = false; + // IsConstant indices are "int", but have the constant expression. + bool IsImmediate = false; + // const qualifier. + bool IsConstant = false; --

[PATCH] D81678: Introduce noundef attribute at call sites for stricter poison analysis

guiand updated this revision to Diff 328055. guiand added a comment. Reupload patch to trigger build Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81678/new/ https://reviews.llvm.org/D81678 Files: clang/include/clang/Basic/CodeGenOptions.def c

[PATCH] D81678: Introduce noundef attribute at call sites for stricter poison analysis

guiand updated this revision to Diff 328060. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81678/new/ https://reviews.llvm.org/D81678 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Driver/Options.td clang/lib/CodeGen/C

[clang-tools-extra] 3ea0e11 - [clang-tidy][NFC] Update docs for bugprone-use-after-move

Author: martinboehme Date: 2021-03-04T13:22:19+01:00 New Revision: 3ea0e119b9fce4c4754313d03824c9c4bcddad66 URL: https://github.com/llvm/llvm-project/commit/3ea0e119b9fce4c4754313d03824c9c4bcddad66 DIFF: https://github.com/llvm/llvm-project/commit/3ea0e119b9fce4c4754313d03824c9c4bcddad66.diff

[PATCH] D94640: adds more checks to -Wfree-nonheap-object

Ka-Ka added a comment. Thanks for the information. I found the review now in https://reviews.llvm.org/D97512 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94640/new/ https://reviews.llvm.org/D94640 ___

[PATCH] D96245: [clangd] Propagate CodeActions in addition to Fixes for diagnostics

njames93 added a comment. One little curveball I'm still kind of hoping we can integrate clang-format into our codeAction workflow, in the hopes of addressing https://github.com/clangd/clangd/issues/429. While we compute the edits eagerly we don't actually send them until the client request for

[PATCH] D97935: [clangd] Add config support for ResourceDir

kadircet created this revision. kadircet added a reviewer: hokein. Herald added subscribers: usaxena95, arphaman. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https:/

[PATCH] D96245: [clangd] Propagate CodeActions in addition to Fixes for diagnostics

sammccall added a comment. In D96245#2602896 , @kadircet wrote: > Agreed, I was going this way because currently there was no way to provide a > code action to clangd::diagnostic apart from storing it in the fixes map > while generating it. I suppose it

[PATCH] D97777: Add __builtin_isnan(__fp16) testcase

thopre updated this revision to Diff 328130. thopre added a comment. Adapt to revert of __builtin_isinf Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D9/new/ https://reviews.llvm.org/D9 Files: clang/test/CodeGen/strictfp_builtins.c Inde

[PATCH] D97936: [analyzer][docs][NFC] Fix typo in checkers.rst

steakhal created this revision. steakhal added reviewers: NoQ, vsavchenko, martong, ASDenysPetrov, Szelethus. Herald added subscribers: Charusso, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. steakhal requested review of this revision.

[clang] 52bfe66 - Add __builtin_isnan(__fp16) testcase

Author: Thomas Preud'homme Date: 2021-03-04T13:03:48Z New Revision: 52bfe6605ab735bfe353682a5ced78aee6bacdbd URL: https://github.com/llvm/llvm-project/commit/52bfe6605ab735bfe353682a5ced78aee6bacdbd DIFF: https://github.com/llvm/llvm-project/commit/52bfe6605ab735bfe353682a5ced78aee6bacdbd.diff

[PATCH] D97777: Add __builtin_isnan(__fp16) testcase

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG52bfe6605ab7: Add __builtin_isnan(__fp16) testcase (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D97850: Fix PCM read from ModuleCache for ext4 filesystem

teemperor added a comment. If I understand this correctly, then the inode caching logic in FileManager isn't just breaking PCMs but all file operations: TEST_F(FileManagerTest, InodeReuse) { { std::ofstream myfile; myfile.open("a.cpp"); myfile << "content\n"; } ll

[PATCH] D97896: [Clang][RISCV][RFC] Add byval parameter attribute?

asb added a comment. I think I may have had the impression from some previous discussions that byval may have limited positive impact, and that letting Clang add the copies to the IR might in some cases help optimisations (that may not be written to reason about byval). You've got a good exampl

[PATCH] D97805: [clang-query] Add option to enable only displaying main file matches

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a typo fix. Comment at: clang-tools-extra/clang-query/Query.cpp:56 +"include-headers " +"Match nodes include

[PATCH] D97121: [clang-tidy] Add a single fix mode to clang-tidy

njames93 updated this revision to Diff 328134. njames93 added a comment. Rename mode to self contained diags. Added support for modernize-loop-convert. Currently transforming a loop will prevent any nested loops being transformed if they are affected by the first transformation. This is counter

[PATCH] D93594: [X86] Pass to transform amx intrinsics to scalar operation.

LuoYuanke added inline comments. Comment at: llvm/lib/Target/X86/X86LowerAMXIntrinsics.cpp:82 + DTU.applyUpdatesPermissive({ + {DominatorTree::Delete, Preheader, Tmp}, + {DominatorTree::Insert, Header, Body}, pengfei wrote: > Do we need to remove the s

[PATCH] D97805: [clang-query] Add option to enable only displaying main file matches

njames93 updated this revision to Diff 328135. njames93 added a comment. Fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97805/new/ https://reviews.llvm.org/D97805 Files: clang-tools-extra/clang-query/Query.cpp clang-tools-extra/clang-q

[PATCH] D97869: [OpenCL][Draft] Add OpenCL builtin test generator

azabaznov added a comment. That's awesome! I'm thinking of how can you track correctness of generated built-ins according to spec.  Perhaps you can compare the number of distinct declarations for each  built-in in the spec and in tablegen and diagnose if they are not equal. This is a very stra

[clang] ab971c2 - [flang][driver] Add options for -fdefault* and -flarge-sizes

Author: Arnamoy Bhattacharyya Date: 2021-03-04T13:29:07Z New Revision: ab971c29a56a4c24359b499d05c30c8c9fc4dea3 URL: https://github.com/llvm/llvm-project/commit/ab971c29a56a4c24359b499d05c30c8c9fc4dea3 DIFF: https://github.com/llvm/llvm-project/commit/ab971c29a56a4c24359b499d05c30c8c9fc4dea3.di

[PATCH] D96344: [flang][driver] Add options for -fdefault* and -flarge-sizes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGab971c29a56a: [flang][driver] Add options for -fdefault* and -flarge-sizes (authored by arnamoy10, committed by awarzynski). Changed prior to commit

[PATCH] D97889: [clang-tidy] Fix assert in modernize-loop-convert

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/LoopConvertCheck.cpp:316-317 return nullptr; + if (!Member->getMemberDecl()->getDeclName().isIdentifier()) +return nullptr; StringRef Name = Member->getMemberDecl()->getName(); --

[PATCH] D97940: [clang-tidy] Extend LoopConvert on array with `!=` comparison

njames93 created this revision. njames93 added reviewers: aaron.ballman, alexfh. Herald added a subscriber: xazax.hun. njames93 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Enables transforming loops of the form: for (int i = 0; I !=

[PATCH] D97889: [clang-tidy] Fix assert in modernize-loop-convert

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/LoopConvertCheck.cpp:316-317 return nullptr; + if (!Member->getMemberDecl()->getDeclName().isIdentifier()) +return nullptr; StringRef Name = Member->getMemberDecl()->getName(); ---

[PATCH] D97941: [Reland] "Do not apply calling conventions to MSVC entry points"

eandrews created this revision. eandrews added reviewers: rnk, akhuang, dmajor. Herald added a subscriber: mstorsjo. eandrews requested review of this revision. This patch is a second attempt at fixing a link error for MSVC entry points when calling conventions are specified using a flag. Callin

[clang] fe5c2c3 - Revert "[Coverage] Emit gap region between statements if first statements contains terminate statements."

Author: Nico Weber Date: 2021-03-04T08:53:30-05:00 New Revision: fe5c2c3ca682b140dd5e640e75948363b6b25ef9 URL: https://github.com/llvm/llvm-project/commit/fe5c2c3ca682b140dd5e640e75948363b6b25ef9 DIFF: https://github.com/llvm/llvm-project/commit/fe5c2c3ca682b140dd5e640e75948363b6b25ef9.diff LO

[PATCH] D96760: [clang-format] Suppress diagnostics on second parse

njames93 added a comment. LGTM, but see what @MyDeveloperDay has to say. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96760/new/ https://reviews.llvm.org/D96760 ___ cfe-commits mailing list cfe-commits@

[PATCH] D97101: [Coverage] Emit gap region between statements if first statements contains terminate statements.

thakis added a comment. This broke ContinuousSyncMode/basic.c in check-profile on macOS (see e.g. end of https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8853690069583264896/+/steps/package_clang/0/stdout?format=raw), so I reverted it for now. It repros on my lapt

[PATCH] D97936: [analyzer][docs][NFC] Fix typo in checkers.rst

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. Neat! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97936/new/ https://reviews.llvm.org/D97936 __

[PATCH] D97849: [AST][PCH][ASTImporter] Fix UB caused by uninited SwitchStmt member

martong updated this revision to Diff 328149. martong added a comment. Herald added a reviewer: Szelethus. Add a test case which fails if lit --vg is used. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97849/new/ https://reviews.llvm.org/D97849 Fi

[clang] 2e90fc2 - [AST][PCH][ASTImporter] Fix UB caused by uninited SwitchStmt member

Author: Gabor Marton Date: 2021-03-04T15:10:04+01:00 New Revision: 2e90fc2c407bb9a85e14fa2c75533a984e5a765a URL: https://github.com/llvm/llvm-project/commit/2e90fc2c407bb9a85e14fa2c75533a984e5a765a DIFF: https://github.com/llvm/llvm-project/commit/2e90fc2c407bb9a85e14fa2c75533a984e5a765a.diff

[PATCH] D97849: [AST][PCH][ASTImporter] Fix UB caused by uninited SwitchStmt member

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2e90fc2c407b: [AST][PCH][ASTImporter] Fix UB caused by uninited SwitchStmt member (authored by martong). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D97849: [AST][PCH][ASTImporter] Fix UB caused by uninited SwitchStmt member

martong added a comment. Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97849/new/ https://reviews.llvm.org/D97849 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[PATCH] D93031: Enable fexec-charset option

abhina.sreeskantharajan updated this revision to Diff 328151. abhina.sreeskantharajan added a comment. Addressing some more comments. Updating the argument parsing, lit tests, some more renaming. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93031/

[PATCH] D93031: Enable fexec-charset option

abhina.sreeskantharajan marked 4 inline comments as done. abhina.sreeskantharajan added inline comments. Comment at: clang/include/clang/Lex/Preprocessor.h:145 ModuleLoader &TheModuleLoader; + LiteralConverter LT; rsmith wrote: > Please give this a lo

[PATCH] D97889: [clang-tidy] Fix assert in modernize-loop-convert

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/LoopConvertCheck.cpp:316-317 return nullptr; + if (!Member->getMemberDecl()->getDeclName().isIdentifier()) +return nullptr; StringRef Name = Member->getMemberDecl()->getName(); ---

[PATCH] D97945: [OPENMP]Fix PR48759: "fatal error" when compile with preprocessed file.

ABataev created this revision. ABataev added reviewers: jdoerfert, mibintc. Herald added subscribers: guansong, yaxunl. ABataev requested review of this revision. Herald added a subscriber: sstefan1. Herald added a project: clang. If the file in line directive does not exist on the system we need,

[PATCH] D97849: [AST][PCH][ASTImporter] Fix UB caused by uninited SwitchStmt member

teemperor added a comment. Sorry for the delay. Yes, I meant the `--vg` flag which is I think the only valid way to test this from your description. That it can't be deterministically tested without this (or in configurations that don't run valgrind) is fine IMHO. Repository: rG LLVM Github

[PATCH] D97945: [OPENMP]Fix PR48759: "fatal error" when compile with preprocessed file.

mibintc accepted this revision. mibintc added a comment. This revision is now accepted and ready to land. Thanks @ABataev ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97945/new/ https://reviews.llvm.org/D97945 __

[PATCH] D97950: [clangd] Rename Module -> FeatureModule to avoid confusion. NFC

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman, mgorny. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. As pointed out in D96244

[PATCH] D97950: [clangd] Rename Module -> FeatureModule to avoid confusion. NFC

sammccall added a comment. I know we talked about names a bunch and i'm being a bit intransigent here. Happy to go with Component if you think it's a better name, but wanted to see how this looks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97950

[clang] 711179b - [OPENMP]Fix PR48759: "fatal error" when compile with preprocessed file.

Author: Alexey Bataev Date: 2021-03-04T07:26:57-08:00 New Revision: 711179b5816a65eccad22a7111494d609b899fb2 URL: https://github.com/llvm/llvm-project/commit/711179b5816a65eccad22a7111494d609b899fb2 DIFF: https://github.com/llvm/llvm-project/commit/711179b5816a65eccad22a7111494d609b899fb2.diff

[PATCH] D97945: [OPENMP]Fix PR48759: "fatal error" when compile with preprocessed file.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG711179b5816a: [OPENMP]Fix PR48759: "fatal error" when compile with preprocessed file. (authored by ABataev). Repository: rG LLVM Github Monorepo

[PATCH] D97125: Stop traping on sNaN in __builtin_isinf

thopre updated this revision to Diff 328170. thopre added a comment. Fix isfinite logic Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97125/new/ https://reviews.llvm.org/D97125 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/test/CodeGen/X86/stri

[PATCH] D97889: [clang-tidy] Fix assert in modernize-loop-convert

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/LoopConvertCheck.cpp:316-317 return nullptr; + if (!Member->getMemberDecl()->getDeclName().isIdentifier()) +return nullptr; StringRef Name = Member->getMemberDecl()->getName(); --

[PATCH] D97125: Stop traping on sNaN in __builtin_isinf

thopre updated this revision to Diff 328171. thopre added a comment. Add isfinite testcases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97125/new/ https://reviews.llvm.org/D97125 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/test/CodeGen/X86/

[PATCH] D97901: [SystemZ] Test for infinity in testFPKind().

thopre added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:7229 + case Builtin::BI__builtin_isfinite: +Invert = true; +LLVM_FALLTHROUGH; thopre wrote: > uweigand wrote: > > thopre wrote: > > > jonpa wrote: > > > > What are the

[PATCH] D97940: [clang-tidy] Extend LoopConvert on array with `!=` comparison

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97940/new/ https://reviews.llvm.org/D97940 __

[PATCH] D97951: [Sema] Fix diagnostics for one-byte length modifier

AntonBikineev created this revision. AntonBikineev added a reviewer: jordan_rose. AntonBikineev added a project: clang. AntonBikineev requested review of this revision. In case a char-literal of type int (C/ObjectiveC) corresponds to a format specifier with the %hh length modifier, don't treat the

[PATCH] D97955: [clang-tidy] Refactor loop-convert to bring most of the checking into matchers

njames93 created this revision. njames93 added reviewers: aaron.ballman, alexfh. Herald added a subscriber: xazax.hun. njames93 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Move all checking on the for loop declaration into the matchers.

[PATCH] D97927: [clang-format] Rename case sorting

PragmaNull accepted this revision. PragmaNull added a comment. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97927/new/ https://reviews.llvm.org/D97927 ___ cfe-commits mailing list cfe-commits

[PATCH] D96760: [clang-format] Suppress diagnostics on second parse

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96760/new/ https://reviews.llvm.org/D96760 _

[PATCH] D97959: [HIP] do not use -mconstructor-aliases for device

yaxunl created this revision. yaxunl added a reviewer: tra. Herald added a subscriber: tpr. yaxunl requested review of this revision. Like nvptx and some other targets, -mconstructor-aliases does not work well with amdgpu, therefore we disable it in the same approach. https://reviews.llvm.org/D

[PATCH] D97960: [clang-tidy] bugprone-signal-handler improvements: display call chain

balazske created this revision. Herald added subscribers: martong, gamesh411, Szelethus, dkrupp, xazax.hun, whisperity. balazske requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add a new feature to display the call chain if an unsafe funct

[PATCH] D97125: Stop traping on sNaN in __builtin_isinf

thopre requested review of this revision. thopre added a comment. Requesting review since the logic has changed. This time I've also tested isfinite against glibc's result. All looks good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97125/new/ h

[PATCH] D95244: [clang][AST] Handle overload callee type in CallExpr::getCallReturnType.

balazske added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95244/new/ https://reviews.llvm.org/D95244 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D97963: [ASTMatchers][Dynamic] Provide Fallback and suggestions for typos.

njames93 created this revision. njames93 added reviewers: aaron.ballman, klimek, steveire. Herald added a subscriber: mgorny. njames93 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. If there is a typo in parsing and we can see a close matc

  1   2   >