[PATCH] D71300: [clangd] Deduplicate refs from index for cross-file rename.

hokein added a comment. thanks for the fast review. Comment at: clang-tools-extra/clangd/unittests/RenameTests.cpp:34 +// Covnert a Range to a Ref. +std::pair toRef(const clangd::Range &Range, + llvm::StringRef Path) { --

[PATCH] D71300: [clangd] Deduplicate refs from index for cross-file rename.

hokein updated this revision to Diff 233262. hokein marked an inline comment as done. hokein added a comment. address review comment -- simplify the unittest code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71300/new/ https://reviews.llvm.org/D7

[PATCH] D71300: [clangd] Deduplicate refs from index for cross-file rename.

merge_guards_bot added a comment. Build result: pass - 60688 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D71284: [clangd] Consider () part of the FunctionDecl, not the FunctionTypeLoc

kadircet accepted this revision. kadircet added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/Selection.cpp:578 // Returns the range of tokens that this node will claim directly, and // is not available to the node'

Re: [clang] bc24014 - [c++20] Implement P1185R2 (as modified by P2002R0).

Hi Richard, ARM bots are broken after this commit, logs are available here: http://lab.llvm.org:8011/builders/clang-cmake-armv7-quick/builds/12109/steps/ninja%20check%201/logs/FAIL%3A%20Clang%3A%3Acxx2a-three-way-comparison.cpp Thanks, Yvan On Wed, 11 Dec 2019 at 02:24, Richard Smith via cfe-co

[PATCH] D71300: [clangd] Deduplicate refs from index for cross-file rename.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71300/new/ https://reviews.llvm.org/D71300

[PATCH] D71329: [CodeComplete] Fix a crash in preferred type and signature help

ilya-biryukov created this revision. ilya-biryukov added a reviewer: kadircet. Herald added a project: clang. sammccall accepted this revision. This revision is now accepted and ready to land. Null type pointers could be dereferenced in some cases. Repository: rG LLVM Github Monorepo https://

[PATCH] D71248: [clangd] Introduce paragraph, the first part of new rendering structs

sammccall added a comment. Main thing here is I'm fairly sure that code blocks shouldn't be chunks in a paragraph (or I'm misunderstanding what a paragraph is) Comment at: clang-tools-extra/clangd/FormattedString.cpp:95 +// Concatanates whitespace blocks into a single ` `. +st

[PATCH] D71329: [CodeComplete] Fix a crash in preferred type and signature help

ilya-biryukov updated this revision to Diff 233268. ilya-biryukov added a comment. - Rename the test, tweak assert comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71329/new/ https://reviews.llvm.org/D71329 Files: clang/lib/Parse/ParseExprC

[clang] f7c8ace - [CodeComplete] Fix a crash in preferred type and signature help

Author: Ilya Biryukov Date: 2019-12-11T09:43:28+01:00 New Revision: f7c8ace4a52acecff7cd6ab61cbeaf677da1dd86 URL: https://github.com/llvm/llvm-project/commit/f7c8ace4a52acecff7cd6ab61cbeaf677da1dd86 DIFF: https://github.com/llvm/llvm-project/commit/f7c8ace4a52acecff7cd6ab61cbeaf677da1dd86.diff

[PATCH] D71329: [CodeComplete] Fix a crash in preferred type and signature help

This revision was automatically updated to reflect the committed changes. Closed by commit rGf7c8ace4a52a: [CodeComplete] Fix a crash in preferred type and signature help (authored by ilya-biryukov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7132

[PATCH] D69778: Make -fmodules-codegen and -fmodules-debuginfo work also with precompiled headers

llunak added a comment. In D69778#1776472 , @dblaikie wrote: > I guess one aspect is that -building-pch-with-obj seems like it duplicates > the fmodules-codegen concept (both basically are a flag passed during pcm/pch > build time that says "I promise to

[PATCH] D71329: [CodeComplete] Fix a crash in preferred type and signature help

merge_guards_bot added a comment. Build result: pass - 60699 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D71193: [clang] Turn -fno-builtin flag into an IR Attribute

gchatelet updated this revision to Diff 233272. gchatelet marked 3 inline comments as done. gchatelet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71193/new/ https://reviews.llvm.org/D71193 Files: clang/lib/C

[clang] 21bc895 - [DWARF5][SplitDwarf] Set default state for -fsplit-dwarf-inlining to be false.

Author: Alexey Lapshin Date: 2019-12-11T12:18:46+03:00 New Revision: 21bc8958668a4dc21de8328ef856ddcf38a97da7 URL: https://github.com/llvm/llvm-project/commit/21bc8958668a4dc21de8328ef856ddcf38a97da7 DIFF: https://github.com/llvm/llvm-project/commit/21bc8958668a4dc21de8328ef856ddcf38a97da7.diff

[PATCH] D71304: [DWARF5][SplitDwarf] Set default state for -fsplit-dwarf-inlining to be false.

This revision was automatically updated to reflect the committed changes. Closed by commit rG21bc8958668a: [DWARF5][SplitDwarf] Set default state for -fsplit-dwarf-inlining to be false. (authored by avl). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM

[PATCH] D71065: [ARM][MVE] Add intrinsics for immediate shifts.

dmgreen accepted this revision. dmgreen added a comment. One of the advantages to smaller patches I guess :) It's probably difficult to tell if this will cause problems again without trying it and see if any of the buildbots complain. Lets give it a try and see. Just keep an eye on them, we ann

[PATCH] D71300: [clangd] Deduplicate refs from index for cross-file rename.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf0004aad5565: [clangd] Deduplicate refs from index for cross-file rename. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71300/new/ htt

[clang-tools-extra] f0004aa - [clangd] Deduplicate refs from index for cross-file rename.

Author: Haojian Wu Date: 2019-12-11T10:52:13+01:00 New Revision: f0004aad5565d4b76d41a03549c5a80efc4212c7 URL: https://github.com/llvm/llvm-project/commit/f0004aad5565d4b76d41a03549c5a80efc4212c7 DIFF: https://github.com/llvm/llvm-project/commit/f0004aad5565d4b76d41a03549c5a80efc4212c7.diff LO

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

ABataev added a comment. In D71241#1778963 , @jdoerfert wrote: > In D71241#1778736 , @ABataev wrote: > > > In D71241#1778717 , @jdoerfert > > wrote: > > > > > >> There is no

[PATCH] D68213: [LTO] Support for embedding bitcode section during LTO

zapster marked an inline comment as done. zapster added inline comments. Comment at: llvm/lib/LTO/LTOBackend.cpp:335 + .Case("bitcode", EmbedBitcodeKind::Embed_Bitcode) + .Case("marker", EmbedBitcodeKind::Embed_Marker) +

[PATCH] D68213: [LTO] Support for embedding bitcode section during LTO

zapster updated this revision to Diff 233282. zapster edited the summary of this revision. zapster added a comment. Made `-lto-embed-bitcode` a boolean option. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68213/new/ https://reviews.llvm.org/D68213 Files: clang/lib/CodeGen/BackendUti

[clang] bd0f271 - [ARM][MVE] Add intrinsics for immediate shifts. (reland)

Author: Simon Tatham Date: 2019-12-11T10:10:09Z New Revision: bd0f271c9e55ab69b45258e4922869099ed18307 URL: https://github.com/llvm/llvm-project/commit/bd0f271c9e55ab69b45258e4922869099ed18307 DIFF: https://github.com/llvm/llvm-project/commit/bd0f271c9e55ab69b45258e4922869099ed18307.diff LOG:

[PATCH] D71065: [ARM][MVE] Add intrinsics for immediate shifts.

This revision was automatically updated to reflect the committed changes. Closed by commit rGbd0f271c9e55: [ARM][MVE] Add intrinsics for immediate shifts. (reland) (authored by simon_tatham). Changed prior to commit: https://reviews.llvm.org/D71065?vs=233025&id=233287#toc Repository: rG LLVM

[PATCH] D71133: [OpenCL] Add ExtVectorElementExpr constant evaluation (PR42387)

svenvh marked an inline comment as done. svenvh added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:7057 + +if (Val.isVector()) { + SmallVector Indices; Anastasia wrote: > can Val not be vector at this point? Yes, for example when evaluatin

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

JonChesterfield added a comment. Lowering in sema or in codegen seems a standard phase ordering choice. There will be pros and cons to both. I think prior art leans towards sema. Variants are loosely equivalent to tag dispatching or constexpr if, both handled before lowering the AST to IR. Wri

[PATCH] D71197: llvm premerge: clang format test

goncharov added a comment. Unit tests: fail - 60594 tests passed, 30 failed and 726 were skipped. failed: libc++.std/input_output/filesystems/class_directory_entry/directory_entry_cons/path.pass.cpp failed: libc++.std/input_output/filesystems/class_directory_entry/directory_entry_mods/assig

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

ABataev added a comment. In D71241#1779168 , @JonChesterfield wrote: > Lowering in sema or in codegen seems a standard phase ordering choice. There > will be pros and cons to both. > > I think prior art leans towards sema. Variants are loosely equivalent

[PATCH] D71197: llvm premerge: clang format test

goncharov added a comment. {icon times-circle color=red} Unit tests: fail.60594 tests passed, 30 failed and 726 were skipped. failed: libc++.std/input_output/filesystems/class_directory_entry/directory_entry_cons/path.pass.cpp failed: libc++.std/input_output/filesystems/class_directory_ent

[PATCH] D71197: llvm premerge: clang format test

goncharov added a comment. {icon times-circle color=red} Unit tests: fail. 60594 tests passed, 30 failed and 726 were skipped. failed: libc++.std/input_output/filesystems/class_directory_entry/directory_entry_cons/path.pass.cpp failed: libc++.std/input_output/filesystems/class_directory_en

[PATCH] D70524: Support DebugInfo generation for auto return type for C++ functions.

awpandey updated this revision to Diff 233289. awpandey added a comment. @dblaikie . I have removed the redundant test case. What else should I do in this patch? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70524/new/ https://reviews.llvm.org/D70524 Files: clang/lib/CodeGen/CGDebug

[clang] 0216854 - [Clang] Pragma vectorize_width() implies vectorize(enable)

Author: Sjoerd Meijer Date: 2019-12-11T10:37:40Z New Revision: 021685491727e023aeae9ca272a2d6cd727e20e4 URL: https://github.com/llvm/llvm-project/commit/021685491727e023aeae9ca272a2d6cd727e20e4 DIFF: https://github.com/llvm/llvm-project/commit/021685491727e023aeae9ca272a2d6cd727e20e4.diff LOG:

[PATCH] D69628: [Clang] Pragma vectorize_width() implies vectorize(enable), take 3

This revision was automatically updated to reflect the committed changes. Closed by commit rG021685491727: [Clang] Pragma vectorize_width() implies vectorize(enable) (authored by SjoerdMeijer). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D71335: [ARM][MVE] Factor out an IntrinsicMX multiclass.

simon_tatham created this revision. simon_tatham added reviewers: MarkMurrayARM, miyuki. Herald added subscribers: cfe-commits, dmgreen, kristof.beyls. Herald added a project: clang. The ACLE intrinsics for MVE contain a lot of pairs of functions with `_m` and `_x` in the name, wrapping a predicat

[PATCH] D71335: [ARM][MVE] Factor out an IntrinsicMX multiclass.

simon_tatham updated this revision to Diff 233297. simon_tatham added a comment. Refactored further to remove the `PredicatedImmediateVectorShift` multiclass completely: the amount of useful content remaining in it now doesn't seem to justify its existence. Repository: rG LLVM Github Monorepo

[PATCH] D71000: [AArch64][SVE] Implement intrinsics for non-temporal loads & stores

kmclaughlin updated this revision to Diff 233298. kmclaughlin marked an inline comment as done. kmclaughlin added a comment. - Changed 'Offset' value used by getMaskedLoad & getMaskedStore to scalar type CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71000/new/ https://reviews.llvm.org/D

[PATCH] D71339: [VE,#2] Clang toolchain for SX-Aurora

simoll created this revision. Herald added subscribers: llvm-commits, cfe-commits, tschuett, jdoerfert, jfb, dexonsmith, fedor.sergeev, hiraditya, krytarowski, mgorny. Herald added projects: clang, LLVM. This is patch #2 in the patch series for the VE backend for NEC-SX Aurora. This patch builds

[PATCH] D71286: [SYCL] Add support for auxiliary triple specification to Frontend

bader updated this revision to Diff 233303. bader added a comment. Added LIT test. If it's okay, I'll add similar test for OpenMP device compiler to clang/test/OpenMP directory. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71286/new/ https://rev

[PATCH] D71340: [VE,#3] Runtime libraries

simoll created this revision. Herald added subscribers: llvm-commits, openmp-commits, libcxx-commits, Sanitizers, cfe-commits, jdoerfert, s.egerton, jfb, dexonsmith, christof, simoncook, fedor.sergeev, aheejin, hiraditya, krytarowski, mgorny. Herald added a reviewer: jdoerfert. Herald added proje

[PATCH] D71335: [ARM][MVE] Factor out an IntrinsicMX multiclass.

miyuki accepted this revision. miyuki added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71335/new/ https://reviews.llvm.org/D71335 ___

[PATCH] D71247: [clangd] Rename constructors and destructors in cross-file case

kbobyrev planned changes to this revision. kbobyrev added a comment. Need to address the comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71247/new/ https://reviews.llvm.org/D71247 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D71000: [AArch64][SVE] Implement intrinsics for non-temporal loads & stores

This revision was automatically updated to reflect the committed changes. Closed by commit rG3f5bf35f868d: [AArch64][SVE] Implement intrinsics for non-temporal loads & stores (authored by kmclaughlin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71

[PATCH] D71286: [SYCL] Add support for auxiliary triple specification to Frontend

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71286/new/ https://reviews.llvm.org/D71286 ___

[PATCH] D71335: [ARM][MVE] Factor out an IntrinsicMX multiclass.

MarkMurrayARM accepted this revision. MarkMurrayARM added a comment. *LIKE* Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71335/new/ https://reviews.llvm.org/D71335 ___ cfe-commits mailing list cfe-com

[PATCH] D71286: [SYCL] Add support for auxiliary triple specification to Frontend

merge_guards_bot added a comment. Build result: pass - 60675 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt , CMakeCache.txt

[clang-tools-extra] 170ee64 - [clang-tidy] Link shared library clangTidyOpenMPModule to library LLVMFrontendOpenMP

Author: Adam Balogh Date: 2019-12-11T12:37:22+01:00 New Revision: 170ee645f4d147103f93927c37a304c759c669dd URL: https://github.com/llvm/llvm-project/commit/170ee645f4d147103f93927c37a304c759c669dd DIFF: https://github.com/llvm/llvm-project/commit/170ee645f4d147103f93927c37a304c759c669dd.diff L

[PATCH] D71197: llvm premerge: clang format test

goncharov updated this revision to Diff 233310. goncharov added a comment. trigger the build Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71197/new/ https://reviews.llvm.org/D71197 Files: clang/tools/clang-check/ClangCheck.cpp clang/tools/cla

[clang] d290424 - [ARM][MVE] Factor out an IntrinsicMX multiclass.

Author: Simon Tatham Date: 2019-12-11T12:07:26Z New Revision: d290424731ede31fd5fd75b929df8fe0adb547c7 URL: https://github.com/llvm/llvm-project/commit/d290424731ede31fd5fd75b929df8fe0adb547c7 DIFF: https://github.com/llvm/llvm-project/commit/d290424731ede31fd5fd75b929df8fe0adb547c7.diff LOG:

[PATCH] D71335: [ARM][MVE] Factor out an IntrinsicMX multiclass.

This revision was automatically updated to reflect the committed changes. Closed by commit rGd290424731ed: [ARM][MVE] Factor out an IntrinsicMX multiclass. (authored by simon_tatham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71335/new/ https://

[PATCH] D71345: [clangd] Fall back to selecting token-before-cursor if token-after-cursor fails.

sammccall created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. sammccall planned changes to this revision. sammccall added a comment. This needs tests, but wanted to share the ideas. The prob

[PATCH] D71345: [clangd] Fall back to selecting token-before-cursor if token-after-cursor fails.

sammccall planned changes to this revision. sammccall added a comment. This needs tests, but wanted to share the ideas. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71345/new/ https://reviews.llvm.org/D71345

[PATCH] D71284: [clangd] Consider () part of the FunctionDecl, not the FunctionTypeLoc

sammccall added a comment. D71345 is a different approach that would solve this problem and others (at higher cost). I don't think we should land both, so let's park this until we decide on the fate of that patch. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D71208: CodeGen: Allow annotations on globals in non-zero address space

This revision was automatically updated to reflect the committed changes. Closed by commit rGf21c081b78ec: CodeGen: Allow annotations on globals in non-zero address space (authored by nhaehnle). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71208/new

[PATCH] D71339: [VE,#2] Clang toolchain for SX-Aurora

simoll added a comment. To clarify: this patch is not intended to be committed as-is but gives an overview of the required changes. It's the a patch of a series for the VE backend and includes all the earlier patches. Repository: rG LLVM Github Mono

[PATCH] D71340: [VE,#3] Runtime libraries

simoll added a comment. To clarify: this patch is not intended to be committed as-is but gives an overview of the required changes. It's the a patch of a series for the VE backend and includes all the earlier patches. Repository: rG LLVM Github Mono

[clang] cb30ad7 - [SYCL] Add support for auxiliary triple specification to Frontend

Author: Alexey Bader Date: 2019-12-11T12:40:43+03:00 New Revision: cb30ad728f0b791c72a6a1399f36ebc60ad5 URL: https://github.com/llvm/llvm-project/commit/cb30ad728f0b791c72a6a1399f36ebc60ad5 DIFF: https://github.com/llvm/llvm-project/commit/cb30ad728f0b791c72a6a1399f36ebc60ad5.diff

[PATCH] D71286: [SYCL] Add support for auxiliary triple specification to Frontend

This revision was automatically updated to reflect the committed changes. Closed by commit rGcb30ad728f0b: [SYCL] Add support for auxiliary triple specification to Frontend (authored by bader). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71286/new/

[PATCH] D69979: clang: Guess at some platform FTZ/DAZ default settings

spatel added inline comments. Comment at: clang/test/Driver/default-denormal-fp-math.c:7 +// crtfastmath enables ftz and daz +// RUN: %clang -### -target x86_64-unknown-linux-gnu -ffast-math --sysroot=%S/Inputs/basic_linux_tree -c %s -v 2>&1 | FileCheck -check-prefix=CHECK-ZERO

[PATCH] D71197: llvm premerge: clang format test

merge_guards_bot added a comment. Build result: pass - 60624 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D71197: llvm premerge: clang format test

merge_guards_bot added a comment. Build result: pass - 60624 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D71347: Add TimeTraceScope constructor without detail arg to simplify code where no detail required

russell.gallop created this revision. russell.gallop added a reviewer: anton-afanasyev. Herald added subscribers: cfe-commits, arphaman, hiraditya. Herald added projects: clang, LLVM. Also don't write out detail when it is empty, which reduces size of generated traces. Repository: rG LLVM Git

[PATCH] D71320: [IR] Split out target specific intrinsic enums into separate headers

efriedma added inline comments. Comment at: llvm/include/llvm/Analysis/TargetTransformInfo.h:759 Type *Ty) const; - int getIntImmCost(Intrinsic::ID IID, unsigned Idx, const APInt &Imm, -Type *Ty) const; + int getIntImmCostIntrin(Intrinsi

[PATCH] D71320: [IR] Split out target specific intrinsic enums into separate headers

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Amazing! Comment at: llvm/utils/TableGen/IntrinsicEmitter.cpp:161 if (Ints[i].EnumName.size() < 40) - OS << std::string(40-Ints[i].EnumName.size(), ' '); + O

[PATCH] D71320: [IR] Split out target specific intrinsic enums into separate headers

rnk marked an inline comment as done. rnk added inline comments. Comment at: llvm/include/llvm/Analysis/TargetTransformInfo.h:759 Type *Ty) const; - int getIntImmCost(Intrinsic::ID IID, unsigned Idx, const APInt &Imm, -Type *Ty) const; +

[PATCH] D71320: [IR] Split out target specific intrinsic enums into separate headers

rnk created this revision. rnk added reviewers: efriedma, echristo. Herald added subscribers: cfe-commits, luismarques, apazos, sameer.abuasal, pzheng, s.egerton, lenary, dmgreen, Petar.Avramovic, jsji, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, atanasyan, edward-jones, zzheng, M

[PATCH] D71341: [VE,#4] Target vector intrinsics

simoll added a comment. In D71341#1779419 , @nhaehnle wrote: > As a general rule, I think it would be preferable for patches such as this > one to be split up further, especially when they touch common code. For > example, why does a patch by the name "T

[PATCH] D71340: [VE,#3] Runtime libraries

Hahnfeld added a comment. In D71340#1779446 , @simoll wrote: > To clarify: this patch is not intended to be committed as-is but gives an > overview of the required changes. It's the a patch of a series for the VE > backend

[PATCH] D71320: [IR] Split out target specific intrinsic enums into separate headers

echristo accepted this revision. echristo added a comment. SGTM and thank you :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71320/new/ https://reviews.llvm.org/D71320 ___ cfe-commits mailing list cf

[PATCH] D71341: [VE,#4] Target vector intrinsics

nhaehnle added a comment. As a general rule, I think it would be preferable for patches such as this one to be split up further, especially when they touch common code. For example, why does a patch by the name "Target vector intrinsics" contain a change to SjLjEHPrepare? Repository: rG LL

[PATCH] D71341: [VE,#4] Target vector intrinsics

simoll created this revision. Herald added subscribers: llvm-commits, openmp-commits, libcxx-commits, Sanitizers, cfe-commits, jdoerfert, s.egerton, jfb, arphaman, dexonsmith, christof, simoncook, fedor.sergeev, aheejin, hiraditya, krytarowski, mgorny, dschuff, qcolombet. Herald added a reviewer

Re: [clang] 9c39663 - Only Remove implicit conversion for the target that support fp16

Hi, This is a missing fix for https://reviews.llvm.org/rGcefac9dfaac9c806433ad88cca85bd2f3ba1edad Jim Roman Lebedev 於 2019年12月10日 週二 下午7:16寫道： > Is there a test missing? > > On Tue, Dec 10, 2019 at 2:11 PM Jim Lin via cfe-commits > wrote: > > > > > > Author: Jim Lin > > Date: 2019-12-10T19:1

[PATCH] D71347: Add TimeTraceScope constructor without detail arg to simplify code where no detail required

anton-afanasyev accepted this revision. anton-afanasyev added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71347/new/ https://reviews.llvm.org/D71347 _

[clang] 6e9c589 - [Analyzer] Iterator Modeling: Print Container Data and Iterator Positions when printing the Program State

Author: Adam Balogh Date: 2019-12-11T14:20:17+01:00 New Revision: 6e9c58946bfe8eed7308a3b57611e225ad67 URL: https://github.com/llvm/llvm-project/commit/6e9c58946bfe8eed7308a3b57611e225ad67 DIFF: https://github.com/llvm/llvm-project/commit/6e9c58946bfe8eed7308a3b57611e225ad67.diff L

[PATCH] D70912: [Analyzer] Iterator Modeling: Print Container Data and Iterator Positions when printing the Program State

baloghadamsoftware closed this revision. baloghadamsoftware added a comment. Closed by commit: https://reviews.llvm.org/rG6e9c58946eee CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70912/new/ https://reviews.llvm.org/D70912 ___ cfe-commits

[PATCH] D71340: [VE,#3] Runtime libraries

simoll updated this revision to Diff 233328. simoll added a comment. Trimmed down to library changes only. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71340/new/ https://reviews.llvm.org/D71340 Files: compiler-rt/cmake/Modules/CompilerRTUtils.

[PATCH] D70613: Add method to ignore invisible AST nodes

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70613/new/ https://reviews.llvm.org/D70613 _

[clang] bb9254c - Removing an unused selection field from a diagnostic; NFC.

Author: Aaron Ballman Date: 2019-12-11T08:48:55-05:00 New Revision: bb9254c00757ec376cde435676d27b14ee0c582f URL: https://github.com/llvm/llvm-project/commit/bb9254c00757ec376cde435676d27b14ee0c582f DIFF: https://github.com/llvm/llvm-project/commit/bb9254c00757ec376cde435676d27b14ee0c582f.diff

[PATCH] D71339: [VE,#2] Clang toolchain for SX-Aurora

simoll updated this revision to Diff 26. simoll added a comment. Trimmed to Clang changes only Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71339/new/ https://reviews.llvm.org/D71339 Files: clang/lib/Basic/CMakeLists.txt clang/lib/Basic/T

[PATCH] D71272: [OpenCL] Pretty print __private addr space

bader added a subscriber: AlexeySotkin. bader added a comment. LGTM, but I'd like someone who works on OpenCL front-end to approve. +@AlexeySotkin CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71272/new/ https://reviews.llvm.org/D71272 ___

[PATCH] D70568: [Support] Possibly use exception handler in the Crash Recovery Context in the same way as global exceptions

hans added inline comments. Comment at: clang/lib/Lex/Pragma.cpp:1108 DebugOverflowStack(); -} else if (II->isStr("handle_crash")) { - llvm::CrashRecoveryContext *CRC =llvm::CrashRecoveryContext::GetCurrent(); This was added in http://llvm.org/r1

[clang] 855d21a - [Analyzer] Iterator Checkers: Replace `UnknownVal` in comparison result by a conjured value

Author: Adam Balogh Date: 2019-12-11T15:24:06+01:00 New Revision: 855d21a03ae841b7c6c980e92f67bd5b65287fa6 URL: https://github.com/llvm/llvm-project/commit/855d21a03ae841b7c6c980e92f67bd5b65287fa6 DIFF: https://github.com/llvm/llvm-project/commit/855d21a03ae841b7c6c980e92f67bd5b65287fa6.diff L

[PATCH] D70244: [Analyzer] Iterator Checkers: Replace `UnknownVal` in comparison result by a conjured value

This revision was automatically updated to reflect the committed changes. Closed by commit rG855d21a03ae8: [Analyzer] Iterator Checkers: Replace `UnknownVal` in comparison result by a… (authored by baloghadamsoftware). Changed prior to commit: https://reviews.llvm.org/D70244?vs=229313&id=233347

[clang] df494f7 - [Support] Add TimeTraceScope constructor without detail arg

Author: Russell Gallop Date: 2019-12-11T14:32:21Z New Revision: df494f7512b0ecebdf3d7be97695a1b6278c0336 URL: https://github.com/llvm/llvm-project/commit/df494f7512b0ecebdf3d7be97695a1b6278c0336 DIFF: https://github.com/llvm/llvm-project/commit/df494f7512b0ecebdf3d7be97695a1b6278c0336.diff LOG

[PATCH] D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation

hans marked an inline comment as done. hans added a comment. I'm basically happy with this, just some minor comments. Comment at: clang/lib/Driver/Job.cpp:376 + CrashReportInfo *CrashInfo) const { + OS << " Running the following in ExecuteCC1Tool():\n"; +

[PATCH] D71347: Add TimeTraceScope constructor without detail arg to simplify code where no detail required

This revision was automatically updated to reflect the committed changes. Closed by commit rGdf494f7512b0: [Support] Add TimeTraceScope constructor without detail arg (authored by russell.gallop). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71347/n

[PATCH] D71197: llvm premerge: clang format test

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 60624 tests passed, 0 failed and 726 were skipped. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by running `git-clang-format HEAD^` or apply this patch

[PATCH] D71356: [Tooling/Syntax] Helpers to find spelled tokens touching a location.

sammccall created this revision. sammccall added reviewers: ilya-biryukov, kbobyrev. Herald added a project: clang. Herald added a subscriber: cfe-commits. Useful when positions are used to target nodes, with before/after ambiguity. Repository: rG LLVM Github Monorepo https://reviews.llvm.org

[PATCH] D70401: [WIP][RISCV] Implement ilp32e ABI

lenary added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:1525 unsigned TwoXLenInBytes = (2 * XLen) / 8; if (!IsFixed && ArgFlags.getOrigAlign() == TwoXLenInBytes && DL.getTypeAllocSize(OrigTy) == TwoXLenInBytes) { shiva02

[PATCH] D71062: [ARM][MVE] Add vector reduction intrinsics with two vector operands

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 60714 tests passed, 0 failed and 726 were skipped. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by running `git-clang-format HEAD^` or apply this patch

[PATCH] D71356: [Tooling/Syntax] Helpers to find spelled tokens touching a location.

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 60699 tests passed, 0 failed and 726 were skipped. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by running `git-clang-format HEAD^` or apply this patch

[PATCH] D71356: [Tooling/Syntax] Helpers to find spelled tokens touching a location.

kbobyrev added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Tokens.h:320 +const syntax::Token * +spelledIdentifierTouching(SourceLocation Loc, + const syntax::TokenBuffer &Tokens); Maybe `llvm::Optional<>` here? =

[PATCH] D71239: [clang-format] Fix ObjC keywords following try/catch getting split.

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1849 + } while (FormatTok->is(tok::comment)); +} if (!(FormatTok->isOneOf(tok::kw_catch, Keywords.kw___except, Bigcheese wrote: > MyDeveloperDay wrote: > > ca

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

ABataev added a comment. Here is the example that does not work with the proposed solution but works with the existing one: static void cpu() { asm("nop"); } #pragma omp declare variant(cpu) match(device = {kind(cpu)}) static __attribute__((used)) void wrong_asm() { asm ("xxx"); }

[PATCH] D71345: [clangd] Fall back to selecting token-before-cursor if token-after-cursor fails.

sammccall updated this revision to Diff 233364. sammccall added a comment. Make tweaktests do the fallback dance so that they test how the feature actually works. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71345/new/ https://reviews.llvm.org/D7

[PATCH] D71345: [clangd] Fall back to selecting token-before-cursor if token-after-cursor fails.

merge_guards_bot added a comment. {icon check-circle color=green} clang-format: pass. Build artifacts : console-log.txt , CMakeCache.txt <

[PATCH] D71197: llvm premerge: clang format test

goncharov updated this revision to Diff 233370. goncharov added a comment. wrong imports order Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71197/new/ https://reviews.llvm.org/D71197 Files: clang/tools/clang-check/ClangCheck.cpp clang/tools/c

[PATCH] D71213: [Alignment][NFC] CreateMemSet use MaybeAlign

foad added a comment. @gchatelet in general would it be possible to make changes like this in a backwards-compatible way, or in two stages without a "flag day" change? We have out-of-tree users of CreateMemSet and it's awkward to change them all at exactly the same time as we merge in this chan

[PATCH] D71197: llvm premerge: clang format test

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 60624 tests passed, 0 failed and 726 were skipped. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by running `git-clang-format HEAD^` or apply this patch

[PATCH] D70973: [OPENMP50]Treat context selectors as expressions, not just strings.

ABataev updated this revision to Diff 233372. ABataev added a comment. Rebase + moved function for best variant to FunctionDecl. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70973/new/ https://reviews.llvm.org/D70973 Files: clang/include/clang/

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

mibintc added a comment. In D62731#1778597 , @michele.scandale wrote: > >> I've noticed you removed the change for `CompilerInvocation.cpp` about the > >> initialization of the codegen option `NoTrappingMath`. Was that an > >> accident? Thanks again M

  1   2   3   >