[PATCH] D69928: [clangd] Set RetainCommentsFromSystemHeaders to true

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM, thanks! Do you need someone to land this? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69928/new/ https://reviews.llvm.org/D

[PATCH] D69933: [ASTImporter] Limit imports of structs

jarin created this revision. jarin added a reviewer: martong. jarin added projects: LLDB, clang. Herald added subscribers: cfe-commits, teemperor, rnkovacs. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. jarin edited the summary of this revision. This is a work in progress pa

[PATCH] D69928: [clangd] Set RetainCommentsFromSystemHeaders to true

lh123 added a comment. In D69928#1736569 , @ilya-biryukov wrote: > LGTM, thanks! > Do you need someone to land this? Yes, I can‘t commit it. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69928/new/ https

[clang] 96065cf - [Syntax] Silence "unused function" warning in no-assert builds. NFC

Author: Ilya Biryukov Date: 2019-11-07T09:37:25+01:00 New Revision: 96065cf79ff76d5fd4fdaeb2fb2650074b3e0e51 URL: https://github.com/llvm/llvm-project/commit/96065cf79ff76d5fd4fdaeb2fb2650074b3e0e51 DIFF: https://github.com/llvm/llvm-project/commit/96065cf79ff76d5fd4fdaeb2fb2650074b3e0e51.diff

Re: [PATCH] D69897: Add #pragma clang loop aligned

On Wed, Nov 6, 2019 at 10:43 PM Hal Finkel via Phabricator < revi...@reviews.llvm.org> wrote: > hfinkel added inline comments. > > > > Comment at: clang/docs/LanguageExtensions.rst:3135 > + > +This predicates all the array references inside the loop to be aligned. > The aligned ac

[PATCH] D69662: [Checkers] Avoid using evalCall in StreamChecker.

balazske added a comment. I removed the previous comment because I realized that `StdCLibraryFunctionsChecker` does not use `evalCall` for fread (returns false because "non-pure" evaluation). Anyway the checks that do not use BindExpr (all except the open functions) could be moved into a PreCa

[clang-tools-extra] 0019684 - [clangd] Set RetainCommentsFromSystemHeaders to true

Author: Ilya Biryukov Date: 2019-11-07T09:54:20+01:00 New Revision: 0019684900491f517f3b08b4fa92740b69a8cc0f URL: https://github.com/llvm/llvm-project/commit/0019684900491f517f3b08b4fa92740b69a8cc0f DIFF: https://github.com/llvm/llvm-project/commit/0019684900491f517f3b08b4fa92740b69a8cc0f.diff

[PATCH] D69813: [analyzer] CERTStrChecker: Model gets()

aaron.ballman added a comment. In D69813#1736045 , @Charusso wrote: > In D69813#1735988 , @aaron.ballman > wrote: > > > I'm not @NoQ, but I do agree that there should be a separate check per rule > > in terms of t

[PATCH] D69928: [clangd] Set RetainCommentsFromSystemHeaders to true

This revision was automatically updated to reflect the committed changes. Closed by commit rG001968490049: [clangd] Set RetainCommentsFromSystemHeaders to true (authored by ilya-biryukov). Changed prior to commit: https://reviews.llvm.org/D69928?vs=228173&id=228186#toc Repository: rG LLVM Gi

[PATCH] D68568: [clang-format] Make '.clang-format' variants finding a loop

This revision was automatically updated to reflect the committed changes. Closed by commit rG86825dbe3306: [clang-format] Make '.clang-format' variants finding a loop (NFC) (authored by wanders). Changed prior to commit: https://reviews.llvm.org/D68568?vs=223488&id=228187#toc Repository: rG

[clang] 86825db - [clang-format] Make '.clang-format' variants finding a loop (NFC)

Author: Anders Waldenborg Date: 2019-11-07T10:00:04+01:00 New Revision: 86825dbe3306d296094432feb4a7af7d385d6b1d URL: https://github.com/llvm/llvm-project/commit/86825dbe3306d296094432feb4a7af7d385d6b1d DIFF: https://github.com/llvm/llvm-project/commit/86825dbe3306d296094432feb4a7af7d385d6b1d.d

[clang-tools-extra] dec8d8d - [clangd] Add unit tests for comments in system headers

Author: Ilya Biryukov Date: 2019-11-07T10:24:27+01:00 New Revision: dec8d8d3f205268712a928d106ff2e6f799f7a9b URL: https://github.com/llvm/llvm-project/commit/dec8d8d3f205268712a928d106ff2e6f799f7a9b DIFF: https://github.com/llvm/llvm-project/commit/dec8d8d3f205268712a928d106ff2e6f799f7a9b.diff

[PATCH] D69934: [clangd] Implement rename by using SelectionTree and findExplicitReferences.

hokein created this revision. hokein added a reviewer: ilya-biryukov. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. With the new implemenation, we will have better coverage of various AST nodes, and fix some known/potential bugs. Aslo ad

[clang] 5b9a072 - Revert a5c8ec4 "[CGDebugInfo] Emit subprograms for decls when AT_tail_call is understood"

Author: Hans Wennborg Date: 2019-11-07T10:30:07+01:00 New Revision: 5b9a072c39c0c34a290abd19e4aca8208a9afae6 URL: https://github.com/llvm/llvm-project/commit/5b9a072c39c0c34a290abd19e4aca8208a9afae6 DIFF: https://github.com/llvm/llvm-project/commit/5b9a072c39c0c34a290abd19e4aca8208a9afae6.diff

[clang] 118f783 - [clang-rename] Respect the traversal scope when traversing the entire AST.

Author: Haojian Wu Date: 2019-11-07T10:43:54+01:00 New Revision: 118f7836a65e864ef3c7e015d58ca370fee65e89 URL: https://github.com/llvm/llvm-project/commit/118f7836a65e864ef3c7e015d58ca370fee65e89 DIFF: https://github.com/llvm/llvm-project/commit/118f7836a65e864ef3c7e015d58ca370fee65e89.diff LO

[PATCH] D69813: [analyzer] CERTStrChecker: Model gets()

Charusso added a comment. In D69813#1736611 , @aaron.ballman wrote: > Would it make sense to use `cert.str.31.c` to remove the random dash? Would > this also help the user to do something like `cert.str.*.cpp`? if they want > just the CERT C++ STR rules

[PATCH] D69892: [clang-rename] Respect the traversal scope when traversing the entire AST.

This revision was automatically updated to reflect the committed changes. Closed by commit rG118f7836a65e: [clang-rename] Respect the traversal scope when traversing the entire AST. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[clang-tools-extra] c5e4cf4 - [clangd] NFC, hide the internal-only utility function lex.

Author: Haojian Wu Date: 2019-11-07T10:58:09+01:00 New Revision: c5e4cf40ac459aae996180089a9831959ceb3d05 URL: https://github.com/llvm/llvm-project/commit/c5e4cf40ac459aae996180089a9831959ceb3d05 DIFF: https://github.com/llvm/llvm-project/commit/c5e4cf40ac459aae996180089a9831959ceb3d05.diff LO

[PATCH] D69813: [analyzer] CERTStrChecker: Model gets()

aaron.ballman added a comment. In D69813#1736667 , @Charusso wrote: > In D69813#1736611 , @aaron.ballman > wrote: > > > Would it make sense to use `cert.str.31.c` to remove the random dash? Would > > this also hel

[PATCH] D68912: Adds -Wrange-loop-analysis to -Wall

aaron.ballman accepted this revision. aaron.ballman added a comment. I spot-checked the list and definitely saw some true positives in there. I did not exhaustively check the list, however. The timing numbers look reasonable enough as well. Unless someone finds an issue with the fp rate that I'v

[PATCH] D63960: [C++20] Add consteval-specific semantic for functions

Tyker updated this revision to Diff 228197. Tyker added a comment. minor fixes improved tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63960/new/ https://reviews.llvm.org/D63960 Files: clang/include/clang/AST/CXXRecordDeclDefinitionBits.def clang/include/clang/AST/DeclCXX.h

[PATCH] D68923: Don't warn about missing declarations for partial template specializations

aaron.ballman added a comment. I think this change is reasonable, but I'd like @rsmith to agree before you commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68923/new/ https://reviews.llvm.org/D68923

[PATCH] D69935: [DeclCXX] Remove unknown external linkage specifications

ekatz created this revision. ekatz added reviewers: SouraVX, aprantl, dblaikie, JDevlieghere, uabelho, rsmith. ekatz added a project: clang. Herald added a subscriber: cfe-commits. Partial revert of r372681 "Support for DWARF-5 C++ language tags". The change introduced new external linkage langu

[PATCH] D69934: [clangd] Implement rename by using SelectionTree and findExplicitReferences.

ilya-biryukov added a comment. It's a bit unclear how we manage to still rename overrides. Is this handled by the USR-generating functions? Could we factor out the part that collects `NamedDecl`s and use those instead of the USRs instead? Comment at: clang-tools-extra/clangd/

[PATCH] D69937: [clangd] Use name of Macro to compute its SymbolID.

usaxena95 created this revision. usaxena95 added a reviewer: hokein. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. We use the name from the IdentifierInfo of the Macro to compute its SymbolID. It is better to just take t

[PATCH] D60455: [SYCL] Implement SYCL device code outlining

bader added a comment. Hi @aaron.ballman, Thanks a lot for the comments and sorry for the long delay. We've been working on complete implementation of the SYCL 1.2.1 specification. Now I have more time to work on contributing the implementation to LLVM project. I re-based the patch and started

[PATCH] D69938: [OpenCL] Use __generic addr space when generating internal representation of lambda

Anastasia created this revision. Anastasia added a reviewer: rjmccall. Herald added subscribers: ebevhan, yaxunl. Since lambdas are represented by callable objects, we need to adjust addr space of implicit obj parameter. This patch suggests to use `__generic` for OpenCL mode. Then any lambda va

[PATCH] D69883: [OpenCL] Add math and common builtin functions

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! I guess we need to think about testing quite soon. :) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69883/new/ https://reviews.llvm.org/D6

[PATCH] D69937: [clangd] Use name of Macro to compute its SymbolID.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. there are some unrelated changes in this patch (probably trigger by your editor setting?), though they are trivial, I would avoid these changes in a same patch. Comment at:

[PATCH] D69901: [OpenCL] Add integer functions to builtin functions

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69901/new/ https://reviews.llvm.org/D69901 ___

[PATCH] D69908: [OpenCL] Add geometric and relational builtin functions

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69908/new/ https://reviews.llvm.org/D69908 ___

[PATCH] D69263: [clangd] Implement cross-file rename.

hokein added inline comments. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:764 + /*WantFormat=*/true, + [this](PathRef File) { return DraftMgr.getDraft(File); }, + [File, Params, Reply = std::move(Reply), ilya-biryukov wrote: > We shoul

[PATCH] D69263: [clangd] Implement cross-file rename.

hokein updated this revision to Diff 228213. hokein marked 5 inline comments as done. hokein added a comment. Herald added a subscriber: javed.absar. - get dirty buffer in clangdServer layer; - save a snpatshot for all dirty buffer; Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D69878: Consoldiate internal denormal flushing controls

Anastasia added a comment. > Stop emitting the denorms-are-zero attribute for the OpenCL flag. It > has no in-tree users. The meaning would also be target dependent, such > as the AMDGPU choice to treat this as only meaning allow flushing of > f32 and not f16 or f64. The naming is also potentia

[PATCH] D69810: [OpenCL] Fix address space for base method call (PR43145)

Anastasia added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:4091 +V = Builder.CreatePointerBitCastOrAddrSpaceCast( +V, IRFuncTy->getParamType(FirstIRArg)); + else svenvh wrote: > @Anastasia pointed out that the A

[PATCH] D69598: Work on cleaning up denormal mode handling

spatel accepted this revision. spatel added a comment. This revision is now accepted and ready to land. LGTM - see inline for some leftover naming diffs. Comment at: clang/lib/CodeGen/CGCall.cpp:1744-1745 FuncAttrs.addAttribute("null-pointer-is-valid", "true"); -if (

[PATCH] D69937: [clangd] Use name of Macro to compute its SymbolID.

usaxena95 updated this revision to Diff 228220. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69937/new/ https://reviews.llvm.org/D69937 Files: clang-tools-extra/clangd/AST.cpp clang-tools-extra/c

[clang] 6fc73f6 - [OpenCL] Add math and common builtin functions

Author: Sven van Haastregt Date: 2019-11-07T13:16:04Z New Revision: 6fc73f63660b1fbe3a1af7b3f14d6fe441e0e938 URL: https://github.com/llvm/llvm-project/commit/6fc73f63660b1fbe3a1af7b3f14d6fe441e0e938 DIFF: https://github.com/llvm/llvm-project/commit/6fc73f63660b1fbe3a1af7b3f14d6fe441e0e938.diff

[PATCH] D69883: [OpenCL] Add math and common builtin functions

This revision was automatically updated to reflect the committed changes. Closed by commit rG6fc73f63660b: [OpenCL] Add math and common builtin functions (authored by svenvh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69883/new/ https://reviews.

[PATCH] D69625: [libTooling] Support implicit coercions in Stencil's `access` combinator.

ymandel added a comment. In D69625#1730324 , @gribozavr2 wrote: > > Are you suggesting we remove text and selection entirely? > > Yes! Sounds good. I'll do that in a separate patch. I think we can abandon this one. Repository: rG LLVM Github Monorepo

[PATCH] D68391: [RISCV] Improve sysroot computation if no GCC install detected

lenary accepted this revision. lenary added a comment. This revision is now accepted and ready to land. Thanks for the rebase. It looks good, let's get it committed! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68391/new/ https://reviews.llvm.org/D68391 _

[clang] 10e0d64 - CodeGen: set correct result for atomic compound expressions

Author: Tim Northover Date: 2019-11-07T13:36:44Z New Revision: 10e0d64337d64ebdb658bf9108bd9bb48fb5390c URL: https://github.com/llvm/llvm-project/commit/10e0d64337d64ebdb658bf9108bd9bb48fb5390c DIFF: https://github.com/llvm/llvm-project/commit/10e0d64337d64ebdb658bf9108bd9bb48fb5390c.diff LOG:

[PATCH] D67436: CodeGen: set correct result for atomic compound expressions

t.p.northover closed this revision. t.p.northover added a comment. Thanks JF. To github.com:llvm/llvm-project.git 0ec6a4882ee..10e0d64337d master -> master > Separately, does this do floating-point add / sub properly? We added them too > C++20. It looks like that already works because it d

[PATCH] D69922: [OpenMP] Use the OpenMP-IR-Builder

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:3489 + !OMPRegionInfo->hasCancel())) { +OMPBuilder->CreateBarrier({CGF.Builder.saveIP()}, Kind, ForceSimpleCall, + EmitChecks); `

[PATCH] D69937: [clangd] Use name of Macro to compute its SymbolID.

ilya-biryukov added a comment. Does that mean we identify each macro merely by its name? It's not uncommon to have multiple `#define` for the same name, meaning completely different things. If find references shows all of those, it's not very useful... Repository: rG LLVM Github Monorepo CH

[PATCH] D69937: [clangd] Use name of Macro to compute its SymbolID.

hokein added a comment. In D69937#1736980 , @ilya-biryukov wrote: > Does that mean we identify each macro merely by its name? > It's not uncommon to have multiple `#define` for the same name, meaning > completely different things. > > If find references

[PATCH] D69937: [clangd] Use name of Macro to compute its SymbolID.

usaxena95 added a comment. We actually use both the name and the **source location** of the macro to calculate its ID. I see that the subject of the patch might suggest otherwise. This is a trivial change which just changes the params of the function so that users don't have to carry the Identi

[clang] 0e70c35 - [OpenCL] Add integer builtin functions

Author: Sven van Haastregt Date: 2019-11-07T14:59:33Z New Revision: 0e70c350943f1a927f481529717c4f98a465777b URL: https://github.com/llvm/llvm-project/commit/0e70c350943f1a927f481529717c4f98a465777b DIFF: https://github.com/llvm/llvm-project/commit/0e70c350943f1a927f481529717c4f98a465777b.diff

[PATCH] D69937: [clangd] Use name of Macro to compute its SymbolID.

ilya-biryukov added a comment. Sorry for not reading through and assuming the wrong thing from the title. Thanks for the explanation! LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69937/new/ https://reviews.llvm.org/D69937 __

[PATCH] D69901: [OpenCL] Add integer functions to builtin functions

This revision was automatically updated to reflect the committed changes. Closed by commit rG0e70c350943f: [OpenCL] Add integer builtin functions (authored by svenvh). Changed prior to commit: https://reviews.llvm.org/D69901?vs=228079&id=228238#toc Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D69908: [OpenCL] Add geometric and relational builtin functions

This revision was automatically updated to reflect the committed changes. Closed by commit rG3d30f2cff7a4: [OpenCL] Add geometric and relational builtin functions (authored by svenvh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69908/new/ https:/

[PATCH] D69204: [OpenMP 5.0] - Extend defaultmap

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:620 + SourceLocation Loc) { +auto &DefaultmapInfo = getTopOfStack().DefaultmapMap[DMVC]; +DefaultmapInfo.ImplicitBehavior = DMIB; `auto` -> to real type ===

[clang] de61aa3 - [RISCV] Improve sysroot computation if no GCC install detected

Author: Edward Jones Date: 2019-11-07T15:17:40Z New Revision: de61aa3118b9bac85c468ea7ec40604a086744f5 URL: https://github.com/llvm/llvm-project/commit/de61aa3118b9bac85c468ea7ec40604a086744f5 DIFF: https://github.com/llvm/llvm-project/commit/de61aa3118b9bac85c468ea7ec40604a086744f5.diff LOG:

[clang] af57dbf - Add support for options -frounding-math, ftrapping-math, -ffp-model=, and -ffp-exception-behavior=

Author: Melanie Blower Date: 2019-11-07T07:22:45-08:00 New Revision: af57dbf12e54f3a8ff48534bf1078f4de104c1cd URL: https://github.com/llvm/llvm-project/commit/af57dbf12e54f3a8ff48534bf1078f4de104c1cd DIFF: https://github.com/llvm/llvm-project/commit/af57dbf12e54f3a8ff48534bf1078f4de104c1cd.diff

[PATCH] D69948: [Checkers] Added support for freopen to StreamChecker.

balazske created this revision. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp. Herald added a project: clang. Extend StreamChecker with a new evaluation function for API call 'freopen'. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D69948 Files: clang/l

[PATCH] D68391: [RISCV] Improve sysroot computation if no GCC install detected

This revision was automatically updated to reflect the committed changes. Closed by commit rGde61aa3118b9: [RISCV] Improve sysroot computation if no GCC install detected (authored by edward-jones). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68391/

[PATCH] D69922: [OpenMP] Use the OpenMP-IR-Builder

jdoerfert marked 2 inline comments as done. jdoerfert added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:3489 + !OMPRegionInfo->hasCancel())) { +OMPBuilder->CreateBarrier({CGF.Builder.saveIP()}, Kind, ForceSimpleCall, +

[PATCH] D69934: [clangd] Implement rename by using SelectionTree and findExplicitReferences.

hokein updated this revision to Diff 228243. hokein marked 11 inline comments as done. hokein added a comment. simplify the testcases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69934/new/ https://reviews.llvm.org/D69934 Files: clang-tools-ex

[PATCH] D69922: [OpenMP] Use the OpenMP-IR-Builder

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:3489 + !OMPRegionInfo->hasCancel())) { +OMPBuilder->CreateBarrier({CGF.Builder.saveIP()}, Kind, ForceSimpleCall, + EmitChecks); j

[PATCH] D69934: [clangd] Implement rename by using SelectionTree and findExplicitReferences.

hokein added a comment. In D69934#1736729 , @ilya-biryukov wrote: > It's a bit unclear how we manage to still rename overrides. Is this handled > by the USR-generating functions? > Could we factor out the part that collects `NamedDecl`s and use those >

[clang] 7adab77 - [Sema] Suppress -Wchar-subscripts if the index is a literal char

Author: Edward Jones Date: 2019-11-07T15:45:44Z New Revision: 7adab7719e55e1b29bfd521dcc73f202139e8f41 URL: https://github.com/llvm/llvm-project/commit/7adab7719e55e1b29bfd521dcc73f202139e8f41 DIFF: https://github.com/llvm/llvm-project/commit/7adab7719e55e1b29bfd521dcc73f202139e8f41.diff LOG:

[PATCH] D58896: Suppress -Wchar-subscripts if the index is a literal char

This revision was automatically updated to reflect the committed changes. Closed by commit rG7adab7719e55: [Sema] Suppress -Wchar-subscripts if the index is a literal char (authored by edward-jones). Herald added a subscriber: simoncook. Changed prior to commit: https://reviews.llvm.org/D58896?

[PATCH] D58896: Suppress -Wchar-subscripts if the index is a literal char

sberg added a comment. But how about literals like `'\x80'` where the promoted value depends on whether plain `char` is signed or unsigned? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58896/new/ https://reviews.llvm.org/D58896 ___

[PATCH] D69923: [OPENMP][DOCS] Update OpenMP status (NFC)

dreachem added a comment. I don't believe I have commit permissions on this. @ABataev, can you commit this? Thanks. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69923/new/ https://reviews.llvm.org/D69923 ___ cfe-co

[PATCH] D69822: [clang] Add new -fdebug-default-version flag.

cmtice updated this revision to Diff 228250. cmtice added a comment. Fix small typo in comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69822/new/ https://reviews.llvm.org/D69822 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Clang.cpp clang/lib/D

[clang] bcf754a - [OPENMP][DOCS] Update OpenMP status (NFC)

Author: Alexey Bataev Date: 2019-11-07T11:07:56-05:00 New Revision: bcf754a3212c12ecc896bac66c599d571eca57d9 URL: https://github.com/llvm/llvm-project/commit/bcf754a3212c12ecc896bac66c599d571eca57d9 DIFF: https://github.com/llvm/llvm-project/commit/bcf754a3212c12ecc896bac66c599d571eca57d9.diff

[PATCH] D69923: [OPENMP][DOCS] Update OpenMP status (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rGbcf754a3212c: [OPENMP][DOCS] Update OpenMP status (NFC) (authored by ABataev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69923/new/ https://reviews.llvm

[PATCH] D69950: Reapply "Fix crash on switch conditions of non-integer types in templates"

eandrews created this revision. eandrews added reviewers: rnk, gribozavr, gribozavr2, Szelethus, erichkeane, riccibruno. This patch reapplies D61027 . When D61027 was previously committed (76945821b9cad3), buildbots failed due t

[PATCH] D69922: [OpenMP] Use the OpenMP-IR-Builder

jdoerfert marked an inline comment as done. jdoerfert added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:3489 + !OMPRegionInfo->hasCancel())) { +OMPBuilder->CreateBarrier({CGF.Builder.saveIP()}, Kind, ForceSimpleCall, +

[PATCH] D69948: [Checkers] Added support for freopen to StreamChecker.

baloghadamsoftware added a comment. Thank you for working on this. Please add comments to the code and maybe also to the tests. I could not find anything in the standards about `freopen()` with null-pointer for the stream parameter. Comment at: clang/lib/StaticAnalyzer/Checke

[PATCH] D69951: [clang-format] NFC allow Format.h to be clang-formatted but still maintain the same doc layout in ClangFormatStyleOptions.rst

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: mitchell-stellar, klimek, sammccall, owenpan. MyDeveloperDay added projects: clang, clang-format. Format.h is used to generate ClangFormatStyleOptions.rst, the layout of the comments is critical to the rst file. Accidentally cl

[PATCH] D68407: [WIP][RISCV] Use compiler-rt if no GCC installation detected

edward-jones added a comment. In D68407#1732685 , @lenary wrote: > This patch is looking much better, thanks for updating it. > > Please may you clarify what RISC-V gcc does for `-lgcc`, `-lgcc_s`, > `-lgcc_eh`? Is it different to what gcc does on other t

[PATCH] D69938: [OpenCL] Use __generic addr space when generating internal representation of lambda

rjmccall added a comment. It does make logical sense to be able to qualify the call operator of a lambda. The lambda always starts as a temporary, so presumably we want the default address space qualifier on lambdas to be compatible with the address space of temporaries. However, that's proba

[PATCH] D69810: [OpenCL] Fix address space for base method call (PR43145)

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:4091 +V = Builder.CreatePointerBitCastOrAddrSpaceCast( +V, IRFuncTy->getParamType(FirstIRArg)); + else Anastasia wrote: > svenvh wrote: > > @Anastasia po

[PATCH] D58896: Suppress -Wchar-subscripts if the index is a literal char

xbolva00 added a comment. Well, i am not sure if one twitter report is good motivation to criple warning. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58896/new/ https://reviews.llvm.org/D58896 ___ cf

[PATCH] D53482: Add clang-format stability check with FormatTests

aardappel added a comment. @MyDeveloperDay thanks for your thoughts.. while `-stable` would be helpful once you know you have the issue (or to permanently turn on in a git pre-submit), it does not help developers that don't even know this is a thing, and waste a bunch of time figuring out what

[PATCH] D69590: [RISCV] Fix ILP32D lowering for double+double/double+int return types

lenary added a comment. In D69590#1728628 , @asb wrote: > Thanks James - won't this still leave problems for structs that need > flattening? The tests in clang/test/CodeGen/riscv32-ilp32d-abi.c already include lots of cases that include flattening. I

[PATCH] D69263: [clangd] Implement cross-file rename.

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:342 + // A snapshot of all file dirty buffers. + llvm::StringMap SnapShot = WorkScheduler.getAllFileContents(); auto Action = [File = File.str(), NewName = NewName.str(), Pos, WantForm

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

jdoerfert updated this revision to Diff 228259. jdoerfert added a comment. Improve type generation & handling, provide examples for function types and more attributes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69785/new/ https://reviews.llvm.org

[PATCH] D53482: Add clang-format stability check with FormatTests

MyDeveloperDay added a comment. In D53482#1737203 , @aardappel wrote: > @MyDeveloperDay thanks for your thoughts.. while `-stable` would be helpful > once you know you have the issue (or to permanently turn on in a git > pre-submit), it does not help dev

[PATCH] D69853: [OpenMP][NFCI] Introduce llvm/IR/OpenMPConstants.h

jdoerfert added a comment. Are there blocking issues on this one or can we go ahead and adjust minor details as we go? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69853/new/ https://reviews.llvm.org/D69853 ___

[PATCH] D69952: [OPENMP50]Generalize handling of context matching/scoring.

ABataev created this revision. ABataev added a reviewer: jdoerfert. Herald added a subscriber: guansong. Herald added a project: clang. Untie context matching/scoring from the attribute for declare variant directive to simplify future uses in other context-dependent directives. Repository: rG

[PATCH] D69922: [OpenMP] Use the OpenMP-IR-Builder

jdoerfert updated this revision to Diff 228264. jdoerfert added a comment. Make the command line option shorter (mentioning openmp once should suffice) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69922/new/ https://reviews.llvm.org/D69922 Files:

[PATCH] D54214: [RISCV] Set triple based on -march flag

simoncook updated this revision to Diff 228261. simoncook added a comment. Rebase. @lenary Following the discussion regarding D69383 , I think it's best for now to keep the logic just keeping `-march` directly, rather than using `getRISCVArch`. I think in the c

[PATCH] D68997: Allow searching for prebuilt implicit modules.

arames updated this revision to Diff 228267. arames added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68997/new/ https://reviews.llvm.org/D68997 Files: clang/docs/Modules.rst clang/include/clang/Driver/Options.td clang/i

[PATCH] D58896: Suppress -Wchar-subscripts if the index is a literal char

edward-jones added a comment. In D58896#1737113 , @sberg wrote: > But how about literals like `'\x80'` where the promoted value depends on > whether plain `char` is signed or unsigned? If 'char' is signed and index into an array then this will typically

[PATCH] D69204: [OpenMP 5.0] - Extend defaultmap

cchen marked an inline comment as done. cchen added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:16411-16420 +bool isDefaultmapModifier = (M == OMPC_DEFAULTMAP_MODIFIER_alloc) || +(M == OMPC_DEFAULTMAP_MODIFIER_to) || +

[PATCH] D69853: [OpenMP][NFCI] Introduce llvm/IR/OpenMPConstants.h

ABataev added a comment. In D69853#1737218 , @jdoerfert wrote: > Are there blocking issues on this one or can we go ahead and adjust minor > details as we go? I still think it would be good to separate patches into the LLVM part and into the clang par

[PATCH] D68407: [WIP][RISCV] Use compiler-rt if no GCC installation detected

edward-jones updated this revision to Diff 228268. edward-jones added a comment. I've changed this to always return `ToolChain::UNW_None` from `RISCVToolChain::GetUnwindLibType` now. As a consequence we get the original behaviour of only `-lgcc` being added to the link command. CHANGES SINCE L

[PATCH] D54214: [RISCV] Set triple based on -march flag

lenary accepted this revision. lenary added a comment. This revision is now accepted and ready to land. In D54214#1737255 , @simoncook wrote: > Rebase. > > @lenary Following the discussion regarding D69383 > , I think it's

[PATCH] D69204: [OpenMP 5.0] - Extend defaultmap

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:16411-16420 +bool isDefaultmapModifier = (M == OMPC_DEFAULTMAP_MODIFIER_alloc) || +(M == OMPC_DEFAULTMAP_MODIFIER_to) || +(M == OMPC_DEFAUL

[PATCH] D69922: [OpenMP] Use the OpenMP-IR-Builder

ABataev added inline comments. Comment at: clang/include/clang/Driver/Options.td:1643-1644 HelpText<"Emit OpenMP code only for SIMD-based constructs.">; +def fopenmp_enable_irbuilder : Flag<["-"], "fopenmp-enable-irbuilder">, Group, Flags<[CC1Option, NoArgumentUnused, HelpHid

[PATCH] D69922: [OpenMP] Use the OpenMP-IR-Builder

jdoerfert updated this revision to Diff 228270. jdoerfert added a comment. Update test attributes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69922/new/ https://reviews.llvm.org/D69922 Files: clang/include/clang/Basic/LangOptions.def clang/i

[clang] f37b5c8 - [RISCV] Fix up tests on Windows after new usage of sys::path::append

Author: Reid Kleckner Date: 2019-11-07T09:53:56-08:00 New Revision: f37b5c800e150ad915c4e0571edd2c92c0160d89 URL: https://github.com/llvm/llvm-project/commit/f37b5c800e150ad915c4e0571edd2c92c0160d89 DIFF: https://github.com/llvm/llvm-project/commit/f37b5c800e150ad915c4e0571edd2c92c0160d89.diff

[PATCH] D68391: [RISCV] Improve sysroot computation if no GCC install detected

thakis added a comment. The test seems to fail on Windows, could you take a look and revert if it takes a while to fix? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68391/new/ https://reviews.llvm.org/D68391 ___

[PATCH] D69922: [OpenMP] Use the OpenMP-IR-Builder

jdoerfert marked an inline comment as done. jdoerfert added inline comments. Comment at: clang/include/clang/Driver/Options.td:1643-1644 HelpText<"Emit OpenMP code only for SIMD-based constructs.">; +def fopenmp_enable_irbuilder : Flag<["-"], "fopenmp-enable-irbuilder">, Grou

[PATCH] D68391: [RISCV] Improve sysroot computation if no GCC install detected

thakis added a comment. nvm, rnk just got to it in https://github.com/llvm/llvm-project/commit/f37b5c800e150ad915c4e0571edd2c92c0160d89 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68391/new/ https://reviews.llvm.org/D68391 ___

[PATCH] D68391: [RISCV] Improve sysroot computation if no GCC install detected

thakis added a comment. Sorry, meant to also paste a link to a failing build: http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/builds/11994/steps/stage%201%20check/logs/stdio Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68391/new/ https:/

[PATCH] D69922: [OpenMP] Use the OpenMP-IR-Builder

ABataev added inline comments. Comment at: clang/include/clang/Driver/Options.td:1643-1644 HelpText<"Emit OpenMP code only for SIMD-based constructs.">; +def fopenmp_enable_irbuilder : Flag<["-"], "fopenmp-enable-irbuilder">, Group, Flags<[CC1Option, NoArgumentUnused, HelpHid

[PATCH] D69853: [OpenMP][NFCI] Introduce llvm/IR/OpenMPConstants.h

jdoerfert marked 2 inline comments as done. jdoerfert added a comment. In D69853#1737264 , @ABataev wrote: > In D69853#1737218 , @jdoerfert wrote: > > > Are there blocking issues on this one or can we go ahead and

  1   2   3   >