r363916 - [Testing] Dumping the graph requires assertions be enabled

Author: davezarzycki Date: Thu Jun 20 02:58:58 2019 New Revision: 363916 URL: http://llvm.org/viewvc/llvm-project?rev=363916&view=rev Log: [Testing] Dumping the graph requires assertions be enabled Modified: cfe/trunk/test/Analysis/exploded-graph-rewriter/escapes.c Modified: cfe/trunk/test/A

r363917 - [clang][ASTMatchers] Add definition for cxxDeductionGuideDecl introduced in rL363855

Author: kadircet Date: Thu Jun 20 03:13:58 2019 New Revision: 363917 URL: http://llvm.org/viewvc/llvm-project?rev=363917&view=rev Log: [clang][ASTMatchers] Add definition for cxxDeductionGuideDecl introduced in rL363855 Modified: cfe/trunk/lib/ASTMatchers/ASTMatchersInternal.cpp Modified: c

r363919 - [clang] Fixing windows buildbot after D61552

Author: tyker Date: Thu Jun 20 03:27:14 2019 New Revision: 363919 URL: http://llvm.org/viewvc/llvm-project?rev=363919&view=rev Log: [clang] Fixing windows buildbot after D61552 Summary: original review : https://reviews.llvm.org/D61552 build bot faillure : http://lab.llvm.org:8011/builders/llvm

r363920 - Revert "[clang] Fixing windows buildbot after D61552"

Author: tyker Date: Thu Jun 20 03:34:02 2019 New Revision: 363920 URL: http://llvm.org/viewvc/llvm-project?rev=363920&view=rev Log: Revert "[clang] Fixing windows buildbot after D61552" This reverts commit 5d5d2ca69e2b29b36db1a7dd1993ead7b7d2680f. has already been fixed by c230eea2f349533468e146

[PATCH] D62688: [Analyzer] Iterator Checkers - Model `empty()` method of containers

sanaanajjar231288 added a comment. In D62688#1549574 , @Szelethus wrote: > Hmm, an idea just popped into my head. I'm not sure whether we have a single > checker that does so much complicated (and totally awesome) modeling as > `IteratorChecker`. What d

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

phosek added a comment. Would it be possible to land this change? Do you need help with landing it? We've been waiting for this for a long time and we would like to start using it now that it has been accepted. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D28462/new/ https://reviews.l

[PATCH] D59474: [OpenMP 5.0] Codegen support for user-defined mappers

lildmh updated this revision to Diff 205785. lildmh marked 9 inline comments as done. lildmh added a comment. Address Alexey's comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59474/new/ https://reviews.llvm.org/D59474 Files: include/clang/AST/GlobalDecl.h lib/AST/ASTContext.

[PATCH] D59474: [OpenMP 5.0] Codegen support for user-defined mappers

lildmh added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:8739 +/// // For each component specified by this mapper: +/// if (currentComponent.hasMapper()) +/// (*currentComponent.Mapper())(rt_mapper_handle, arg_base, arg_begin, ABata

[PATCH] D63600: [test][Driver] Fix Clang :: Driver/cl-response-file.c

ro created this revision. ro added a reviewer: rsmith. Herald added a subscriber: fedor.sergeev. Herald added a project: clang. `Clang :: Driver/cl-response-file.c` currently FAILs on Solaris: Command Output (stderr): -- /vol/llvm/src/clang/dist/test/Driver/cl-response-file.c:10:11: error:

[PATCH] D63561: [OpenCL] Improve diagnostic for placement new

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63561/new/ https://reviews.llvm.org/D63561 ___

[PATCH] D63602: [Sanitizers] Don't use clang_rt.sancov_{begin, end} on Solaris

ro created this revision. ro added a reviewer: alekseyshl. Herald added a subscriber: fedor.sergeev. Herald added a project: clang. As explained in https://reviews.llvm.org/D63601, there's no point using `clang_rt.sancov_{begin,end}` on Solaris any longer. This companion patch to the above remov

[PATCH] D63108: [OpenMP] Add support for handling declare target to clause when unified memory is required

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:2566-2569 + if (*Res == OMPDeclareTargetDeclAttr::MT_Link) +OS << CGM.getMangledName(GlobalDecl(VD)) << "_decl_tgt_link_ptr"; + else +OS << CGM.getMangledName(GlobalDecl(VD)) << "

[PATCH] D63603: [ASTImporter] Propagate error from ImportDeclContext

martong created this revision. martong added a reviewer: a_sidorin. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp, rnkovacs. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: clang. martong added a parent revision: D62373: [ASTImporte

[PATCH] D62373: [ASTImporter] Store import errors for Decls

martong updated this revision to Diff 205811. martong marked 3 inline comments as done. martong added a comment. - Test error values are set for AST nodes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62373/new/ https://reviews.llvm.org/D62373 Fil

[PATCH] D62373: [ASTImporter] Store import errors for Decls

martong updated this revision to Diff 205814. martong marked an inline comment as done. martong added a comment. - Remove unrelated change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62373/new/ https://reviews.llvm.org/D62373 Files: clang/incl

[PATCH] D62373: [ASTImporter] Store import errors for Decls

martong marked 3 inline comments as done. martong added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:5109 } else { // ODR violation. // FIXME HandleNameConflict + return make_error(ImportError::NameConflict); a_sidorin wrote: > Is t

[PATCH] D60455: [SYCL] Implement SYCL device code outlining

Fznamznon updated this revision to Diff 205813. Fznamznon added a comment. Updated `sycl_kernel` attribute documentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60455/new/ https://reviews.llvm.org/D60455 Files: clang/include/clang/Basic/A

r363932 - Add test cases for explicit casts when dumping the AST to JSON; NFC.

Author: aaronballman Date: Thu Jun 20 08:04:24 2019 New Revision: 363932 URL: http://llvm.org/viewvc/llvm-project?rev=363932&view=rev Log: Add test cases for explicit casts when dumping the AST to JSON; NFC. Added: cfe/trunk/test/AST/multistep-explicit-cast-json.c cfe/trunk/test/AST/multi

[PATCH] D63578: AMDGPU: Add DS GWS sema builtins

rampitec accepted this revision. rampitec added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63578/new/ https://reviews.llvm.org/D63578 ___ cfe-commits mailing list cfe-commi

r363935 - Removing a helper function that was trivial to inline into its only use; NFC.

Author: aaronballman Date: Thu Jun 20 08:10:45 2019 New Revision: 363935 URL: http://llvm.org/viewvc/llvm-project?rev=363935&view=rev Log: Removing a helper function that was trivial to inline into its only use; NFC. Modified: cfe/trunk/include/clang/AST/TextNodeDumper.h cfe/trunk/lib/AST

[PATCH] D63579: [clang-scan-deps] print the dependencies to stdout and remove the need to use -MD options in the CDB

aganea added inline comments. Comment at: clang/tools/clang-scan-deps/ClangScanDeps.cpp:32 +class DependencyCollectorFactory { +public: Do you envision future uses for this factory? Comment at: clang/tools/clang-scan-deps/ClangScanDeps.cpp:50

r363939 - AIX system headers need stdint.h and inttypes.h to be re-enterable

Author: xingxue Date: Thu Jun 20 08:36:32 2019 New Revision: 363939 URL: http://llvm.org/viewvc/llvm-project?rev=363939&view=rev Log: AIX system headers need stdint.h and inttypes.h to be re-enterable Summary: AIX system headers need stdint.h and inttypes.h to be re-enterable when macro _STD_TYP

[PATCH] D59253: [AIX][libcxx] AIX system headers need stdint.h and inttypes.h to be re-enterable when macro _STD_TYPES_T is defined

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL363939: AIX system headers need stdint.h and inttypes.h to be re-enterable (authored by xingxue, committed by ). Changed

[PATCH] D63108: [OpenMP] Add support for handling declare target to clause when unified memory is required

gtbercea updated this revision to Diff 205825. gtbercea added a comment. - Address comments. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63108/new/ https://reviews.llvm.org/D63108 Files: lib/CodeGen/CGDeclCXX.cpp lib/CodeGen/CGExpr.cpp lib/CodeGen/CGOpen

[PATCH] D53157: Teach the IRBuilder about constrained fadd and friends

kpn added a comment. I found out that some compilers, including SAS/C, will warn about enum overlaps like the one here under discussion. So I now believe John is correct and that eliminating that overlap is the right thing to do. Over the weekend I'll be thinking about whether or not to try and

[PATCH] D60455: [SYCL] Implement SYCL device code outlining

Fznamznon updated this revision to Diff 205831. Fznamznon added a comment. Fixed a couple coding style issues, renamed markDevice function with markSYCLDevice. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60455/new/ https://reviews.llvm.org/D6045

[PATCH] D63607: [DO NOT SUBMIT] [clang][driver] Prototype --driver-mode=fortran support for new flang

peterwaller-arm created this revision. Herald added subscribers: cfe-commits, kadircet, ilya-biryukov, mgorny. Herald added a project: clang. This is an early prototype, not intended for full review until after the general approach is agreed. The purpose is to stimulate discussion on the overall a

[PATCH] D61879: WIP: Prototype of DSE optimizations for -ftrivial-auto-var-init

jfb added a comment. Hello! I'm still interested in this, have you been able to make any progress? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61879/new/ https://reviews.llvm.org/D61879 ___ cfe-commi

[PATCH] D63361: Pretend NRVO variables are references so they can be found by debug info

rnk accepted this revision. rnk added a comment. lgtm, thanks! Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:908 --EI; llvm::Value *Addr = Builder.CreateStructGEP(nullptr, &*EI, Idx); Addr = Builder.CreateAlignedLoad(Addr, getPointerAlign(), "agg.result"); --

[PATCH] D63108: [OpenMP] Add support for handling declare target to clause when unified memory is required

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:9227-9229 + } else if ((*Res == OMPDeclareTargetDeclAttr::MT_Link) || + (*Res == OMPDeclareTargetDeclAttr::MT_To && + HasRequiresUnifiedSharedMemory)) { Use `asse

r363943 - Dump more information about expressions involving temporaries when dumping the AST to JSON.

Author: aaronballman Date: Thu Jun 20 09:22:35 2019 New Revision: 363943 URL: http://llvm.org/viewvc/llvm-project?rev=363943&view=rev Log: Dump more information about expressions involving temporaries when dumping the AST to JSON. Added: cfe/trunk/test/AST/ast-dump-temporaries-json.cpp Modif

[PATCH] D62156: [Sema][PR41730] Diagnose addr space mismatch while constructing objects

This revision was automatically updated to reflect the committed changes. Closed by commit rL363944: [Sema] Diagnose addr space mismatch while constructing objects (authored by stulova, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

r363944 - [Sema] Diagnose addr space mismatch while constructing objects

Author: stulova Date: Thu Jun 20 09:23:28 2019 New Revision: 363944 URL: http://llvm.org/viewvc/llvm-project?rev=363944&view=rev Log: [Sema] Diagnose addr space mismatch while constructing objects If we construct an object in some arbitrary non-default addr space it should fail unless either: - T

[PATCH] D63108: [OpenMP] Add support for handling declare target to clause when unified memory is required

gtbercea updated this revision to Diff 205839. gtbercea added a comment. - Address comments. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63108/new/ https://reviews.llvm.org/D63108 Files: lib/CodeGen/CGDeclCXX.cpp lib/CodeGen/CGExpr.cpp lib/CodeGen/CGOpen

[PATCH] D63108: [OpenMP] Add support for handling declare target to clause when unified memory is required

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63108/new/ https://reviews.llvm.org/D63108 ___ cfe-commits ma

[PATCH] D62738: [HIP] Support device_shadow variable

yaxunl marked an inline comment as done. yaxunl added a comment. In D62738#1538900 , @tra wrote: > So, the only thing this patch appears to do is make everything with this > attribute uninitialized on device side and give protected visibility. > If I und

[PATCH] D62738: [HIP] Support device_shadow variable

yaxunl added a comment. > The problem is that we do not see generic usage of > Although there is no texture specific handling on the compiler side, there > is texture specific handling of symbols Please ignore this comment. It is some old comment submitted by accident. CHANGES SINCE LAST ACT

[PATCH] D62156: [Sema][PR41730] Diagnose addr space mismatch while constructing objects

Anastasia marked 2 inline comments as done. Anastasia added inline comments. Comment at: test/SemaCXX/address-space-ctor.cpp:11 +//expected-note@-6{{candidate constructor (the implicit move constructor) not viable: no known conversion from 'int' to 'MyType &&' for 1st argument}}

[PATCH] D62574: Initial draft of target-configurable address spaces.

Anastasia added a comment. In D62574#1534159 , @ebevhan wrote: > >> I'll have to see if that's possible without breaking a few more > >> interfaces, since you can throw around Qualifiers and check for > >> compatibility without an ASTContext today. > >>

[PATCH] D63498: [RISC-V] Add -msave-restore and -mno-save-restore to clang driver

lenary updated this revision to Diff 205846. lenary added a comment. - Add CHECK lines for warnings Hopefully these will work regardless of race conditions in the merging of stdout and stderr. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63498/new

[PATCH] D63607: [DO NOT SUBMIT] [clang][driver] Prototype --driver-mode=fortran support for new flang

peterwaller-arm added a comment. Note: In case you see this early, the email isn't yet sent to the list. I'll link it here when it is, likely tomorrow. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63607/new/ https://reviews.llvm.org/D63607 __

r363948 - [clang-ifs] Clang Interface Stubs, first version (second landing attempt).

Author: zer0 Date: Thu Jun 20 09:59:48 2019 New Revision: 363948 URL: http://llvm.org/viewvc/llvm-project?rev=363948&view=rev Log: [clang-ifs] Clang Interface Stubs, first version (second landing attempt). This change reverts r363649; effectively re-landing r363626. At this point clang::Index::Co

[PATCH] D60974: Clang IFSO driver action.

plotfi added a comment. This was re-landed in r363948 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60974/new/ https://reviews.llvm.org/D60974 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D63613: [clang-tidy] Fail gracefully upon empty database fields

serge-sans-paille created this revision. serge-sans-paille added a reviewer: alexfh. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. fix https://bugs.llvm.org/show_bug.cgi?id=42281 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D63613 Files: c

r363952 - Store a pointer to the return value in a static alloca and let the debugger use that

Author: akhuang Date: Thu Jun 20 10:15:21 2019 New Revision: 363952 URL: http://llvm.org/viewvc/llvm-project?rev=363952&view=rev Log: Store a pointer to the return value in a static alloca and let the debugger use that as the variable address for NRVO variables. Subscribers: hiraditya, cfe-commi

Re: [PATCH] D61879: WIP: Prototype of DSE optimizations for -ftrivial-auto-var-init

Not much, but it's not abandoned. I was interrupted by other stuff. Also I am concerned by the fact that zero initialization without any new optimization is cheaper than pattern even with patches in progress. On Thu, Jun 20, 2019 at 9:05 AM JF Bastien via Phabricator < revi...@reviews.llvm.org> wr

[PATCH] D63361: Pretend NRVO variables are references so they can be found by debug info

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL363952: Store a pointer to the return value in a static alloca and let the debugger use… (authored by akhuang, committed b

[PATCH] D63376: [clang] Small improvments after Adding APValue to ConstantExpr

rsmith added inline comments. Comment at: clang/include/clang/Sema/Sema.h:10298 + bool AllowFold = true, + bool StoreResult = true); ExprResult VerifyIntegerConstantExpression(Expr *E, llvm

r363959 - [OpenMP] Add support for handling declare target to clause when unified memory is required

Author: gbercea Date: Thu Jun 20 11:04:47 2019 New Revision: 363959 URL: http://llvm.org/viewvc/llvm-project?rev=363959&view=rev Log: [OpenMP] Add support for handling declare target to clause when unified memory is required Summary: This patch adds support for the handling of the variables unde

[PATCH] D63108: [OpenMP] Add support for handling declare target to clause when unified memory is required

This revision was automatically updated to reflect the committed changes. Closed by commit rL363959: [OpenMP] Add support for handling declare target to clause when unified memory… (authored by gbercea, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Reposit

r363961 - [X86] Make _mm_mask_cvtps_ph, _mm_maskz_cvtps_ph, _mm256_mask_cvtps_ph, and _mm256_maskz_cvtps_ph aliases for their corresponding cvt_roundps_ph intrinsic.

Author: ctopper Date: Thu Jun 20 11:24:29 2019 New Revision: 363961 URL: http://llvm.org/viewvc/llvm-project?rev=363961&view=rev Log: [X86] Make _mm_mask_cvtps_ph, _mm_maskz_cvtps_ph, _mm256_mask_cvtps_ph, and _mm256_maskz_cvtps_ph aliases for their corresponding cvt_roundps_ph intrinsic. These

r363963 - [NFC] Fix for InterfaceStubs tests (adding REQUIRES: x86-registered-target).

Author: zer0 Date: Thu Jun 20 11:28:21 2019 New Revision: 363963 URL: http://llvm.org/viewvc/llvm-project?rev=363963&view=rev Log: [NFC] Fix for InterfaceStubs tests (adding REQUIRES: x86-registered-target). clang-hexagon-elf bot was failing with: 'No available targets are compatible with triple

[PATCH] D63616: Implement `-fsanitize-coverage-whitelist` and `-fsanitize-coverage-blacklist` for clang

tuktuk created this revision. tuktuk added reviewers: kcc, morehouse. tuktuk added projects: clang, Sanitizers. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added a project: LLVM. This commit adds two command-line options to clang. These options let the user decide which

[PATCH] D63616: Implement `-fsanitize-coverage-whitelist` and `-fsanitize-coverage-blacklist` for clang

lebedev.ri added a comment. Test coverage missing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63616/new/ https://reviews.llvm.org/D63616 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[PATCH] D59963: [clang-tidy] Add a module for the Linux kernel.

tmroeder marked an inline comment as done. tmroeder added inline comments. Comment at: clang-tools-extra/test/clang-tidy/linuxkernel-must-check-errs.c:6 +// Prototypes of the error functions. +void * __must_check ERR_PTR(long error); +long __must_check PTR_ERR(const void *ptr);

[PATCH] D60225: [clang-format] [PR19056] Add support for indenting class members and methods one level under the modifiers

3nids added a comment. Hi, may I ask why this is abandoned? We are eagerly waiting on this to move to clang-format. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60225/new/ https://reviews.llvm.org/D60225 ___ cfe-com

r363966 - Print additional information about @encode expressions when dumping the AST to JSON.

Author: aaronballman Date: Thu Jun 20 12:11:35 2019 New Revision: 363966 URL: http://llvm.org/viewvc/llvm-project?rev=363966&view=rev Log: Print additional information about @encode expressions when dumping the AST to JSON. Modified: cfe/trunk/include/clang/AST/JSONNodeDumper.h cfe/trunk

[PATCH] D63617: [COFF, ARM64] Fix encoding of __debugbreak

TomTan created this revision. TomTan added reviewers: efriedma, rnk. Herald added subscribers: cfe-commits, kristof.beyls, javed.absar. Herald added a project: clang. On Windows ARM64, intrinsic `__debugbreak` should be compiled into `brk #0xF000` which is different from llvm intrinsic `debugtrap

r363969 - [clang][NewPM] Move EntryExitInstrumenterPass to the start of the pipeline

Author: leonardchan Date: Thu Jun 20 12:35:25 2019 New Revision: 363969 URL: http://llvm.org/viewvc/llvm-project?rev=363969&view=rev Log: [clang][NewPM] Move EntryExitInstrumenterPass to the start of the pipeline This fixes CodeGen/x86_64-instrument-functions.c when running under the new pass man

[PATCH] D63577: [clang][NewPM] Move EntryExitInstrumenterPass to the start of the pipeline

This revision was automatically updated to reflect the committed changes. Closed by commit rL363969: [clang][NewPM] Move EntryExitInstrumenterPass to the start of the pipeline (authored by leonardchan, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

r363971 - [clang][NewPM] Do not eliminate available_externally durng `-O2 -flto` runs

Author: leonardchan Date: Thu Jun 20 12:44:51 2019 New Revision: 363971 URL: http://llvm.org/viewvc/llvm-project?rev=363971&view=rev Log: [clang][NewPM] Do not eliminate available_externally durng `-O2 -flto` runs This fixes CodeGen/available-externally-suppress.c when the new pass manager is tur

[PATCH] D63613: [clang-tidy] Fail gracefully upon empty database fields

jkorous accepted this revision. jkorous added a comment. This revision is now accepted and ready to land. Herald added a subscriber: dexonsmith. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63613/new/ https://reviews.llvm.org/D63613 __

[PATCH] D63580: [clang][NewPM] Do not eliminate available_externally durng `-O2 -flto` runs

This revision was automatically updated to reflect the committed changes. leonardchan marked an inline comment as done. Closed by commit rG97dc622ab3f7: [clang][NewPM] Do not eliminate available_externally durng `-O2 -flto` runs (authored by leonardchan). Changed prior to commit: https://review

r363972 - Fix crash and rejects-valid when a later template parameter or default

Author: rsmith Date: Thu Jun 20 12:49:13 2019 New Revision: 363972 URL: http://llvm.org/viewvc/llvm-project?rev=363972&view=rev Log: Fix crash and rejects-valid when a later template parameter or default template argument contains a backreference to a dependently-typed earlier parameter. In a cas

Re: [PATCH] D59963: [clang-tidy] Add a module for the Linux kernel.

Sounds like a good start. On Thu, Jun 20, 2019 at 11:55 AM Tom Roeder via Phabricator wrote: > > tmroeder marked an inline comment as done. > tmroeder added inline comments. > > > > Comment at: clang-tools-extra/test/clang-tidy/linuxkernel-must-check-errs.c:6 > +// Prototypes of

[PATCH] D63621: [git-clang-format] recognize hxx as a C++ file

vmiklos created this revision. vmiklos added reviewers: jbcoe, djasper. Herald added subscribers: cfe-commits, kadircet, ilya-biryukov. Herald added a project: clang. clangd, clang-tidy, etc does that already, no reason why git-clang-format should skip hxx files. Repository: rC Clang https:/

r363973 - Fix passing structs and AVX vectors through sysv_abi

Author: rnk Date: Thu Jun 20 13:07:20 2019 New Revision: 363973 URL: http://llvm.org/viewvc/llvm-project?rev=363973&view=rev Log: Fix passing structs and AVX vectors through sysv_abi Do this the same way we did it for ms_abi in r324594. Fixes PR36806. Added: cfe/trunk/test/CodeGen/sysv_abi.

[PATCH] D63579: [clang-scan-deps] print the dependencies to stdout and remove the need to use -MD options in the CDB

arphaman added inline comments. Comment at: clang/tools/clang-scan-deps/ClangScanDeps.cpp:32 +class DependencyCollectorFactory { +public: aganea wrote: > Do you envision future uses for this factory? Most likely, yes. I don't want to lock-in into creating the

[PATCH] D63579: [clang-scan-deps] print the dependencies to stdout and remove the need to use -MD options in the CDB

arphaman updated this revision to Diff 205886. arphaman marked 3 inline comments as done. arphaman added a comment. removed the lock CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63579/new/ https://reviews.llvm.org/D63579 Files: clang/include/clang/Frontend/Utils.h clang/lib/Fronte

[PATCH] D63617: [COFF, ARM64] Fix encoding of __debugbreak

rnk added a comment. I think it would be preferable to make `llvm.debugtrap` emit `brk #0xF000` on aarch64-windows-*, so other frontends (Rust etc) get the right behavior by default. Right now, AArch64 doesn't do anything special for DEBUGTRAP, so we get the default behavior of `llvm.trap`. Is

r363975 - [clang-tidy] Fail gracefully upon empty database fields

Author: serge_sans_paille Date: Thu Jun 20 13:25:59 2019 New Revision: 363975 URL: http://llvm.org/viewvc/llvm-project?rev=363975&view=rev Log: [clang-tidy] Fail gracefully upon empty database fields Fix bz#42281 Differential Revision: https://reviews.llvm.org/D63613 Modified: cfe/trunk/lib

[clang-tools-extra] r363975 - [clang-tidy] Fail gracefully upon empty database fields

Author: serge_sans_paille Date: Thu Jun 20 13:25:59 2019 New Revision: 363975 URL: http://llvm.org/viewvc/llvm-project?rev=363975&view=rev Log: [clang-tidy] Fail gracefully upon empty database fields Fix bz#42281 Differential Revision: https://reviews.llvm.org/D63613 Added: clang-tools-extr

[PATCH] D63613: [clang-tidy] Fail gracefully upon empty database fields

This revision was automatically updated to reflect the committed changes. Closed by commit rL363975: [clang-tidy] Fail gracefully upon empty database fields (authored by serge_sans_paille, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to comm

[PATCH] D63613: [clang-tidy] Fail gracefully upon empty database fields

serge-sans-paille added a comment. Thanks @jkorous for the fast review o/ Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63613/new/ https://reviews.llvm.org/D63613 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D63451: P0840R2: support for [[no_unique_address]] attribute

rsmith added inline comments. Comment at: lib/CodeGen/CGExprAgg.cpp:1850 +AggValueSlot::Overlap_t +CodeGenFunction::overlapForFieldInit(const FieldDecl *FD) { + if (!FD->hasAttr() || !FD->getType()->isRecordType()) rsmith wrote: > rjmccall wrote: > > `getOverlap

[PATCH] D63451: P0840R2: support for [[no_unique_address]] attribute

rsmith updated this revision to Diff 205892. rsmith marked 4 inline comments as done. rsmith added a comment. - Use custom code to specify CXXABI requirements on attributes. - Remove dead code that would have handled [[no_unique_address]] in C. - Extend documentation to include an example and to m

[PATCH] D63617: [COFF, ARM64] Fix encoding of __debugbreak

TomTan added a comment. In D63617#1552561 , @rnk wrote: > I think it would be preferable to make `llvm.debugtrap` emit `brk #0xF000` on > aarch64-windows-*, so other frontends (Rust etc) get the right behavior by > default. Right now, AArch64 doesn't do

[PATCH] D63451: P0840R2: support for [[no_unique_address]] attribute

rjmccall accepted this revision. rjmccall added inline comments. Comment at: include/clang/Basic/Attr.td:326 + // const llvm::Triple &T = Target.getTriple(); + code CustomCode = [{}]; } Thanks! Comment at: lib/CodeGen/CGExprAgg.cpp:1850 +A

[PATCH] D63451: P0840R2: support for [[no_unique_address]] attribute

rsmith added a comment. In D63451#1549563 , @rjmccall wrote: > Can this attribute not be applied to a base class, or to a type? The standard attribute forbids that right now. We could add a custom attribute that permits it, but we're required to diagnos

r363976 - P0840R2: support for [[no_unique_address]] attribute

Author: rsmith Date: Thu Jun 20 13:44:45 2019 New Revision: 363976 URL: http://llvm.org/viewvc/llvm-project?rev=363976&view=rev Log: P0840R2: support for [[no_unique_address]] attribute Summary: Add support for the C++2a [[no_unique_address]] attribute for targets using the Itanium C++ ABI. Thi

[PATCH] D63617: [COFF, ARM64] Fix encoding of __debugbreak

rnk added a comment. Even if `BRK #0xF000` is a Windows convention, it's still possible for ISel to select different instructions for different OSs, and I'd prefer to implement it that way. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63617/new/ https://review

[PATCH] D63451: P0840R2: support for [[no_unique_address]] attribute

This revision was automatically updated to reflect the committed changes. Closed by commit rL363976: P0840R2: support for [[no_unique_address]] attribute (authored by rsmith, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINC

[PATCH] D63579: [clang-scan-deps] print the dependencies to stdout and remove the need to use -MD options in the CDB

aganea added inline comments. Comment at: clang/tools/clang-scan-deps/ClangScanDeps.cpp:32 +class DependencyCollectorFactory { +public: arphaman wrote: > aganea wrote: > > Do you envision future uses for this factory? > Most likely, yes. > > I don't want to lo

r363980 - Rename CodeGenFunction::overlapFor* to getOverlapFor*.

Author: rsmith Date: Thu Jun 20 13:56:20 2019 New Revision: 363980 URL: http://llvm.org/viewvc/llvm-project?rev=363980&view=rev Log: Rename CodeGenFunction::overlapFor* to getOverlapFor*. Modified: cfe/trunk/lib/CodeGen/CGClass.cpp cfe/trunk/lib/CodeGen/CGDecl.cpp cfe/trunk/lib/CodeGe

[PATCH] D63451: P0840R2: support for [[no_unique_address]] attribute

rsmith marked an inline comment as done. rsmith added inline comments. Comment at: lib/CodeGen/CGExprAgg.cpp:1850 +AggValueSlot::Overlap_t +CodeGenFunction::overlapForFieldInit(const FieldDecl *FD) { + if (!FD->hasAttr() || !FD->getType()->isRecordType()) rjmcca

[PATCH] D63623: Add a check on expected return values of posix functions (except posix_openpt) in Android module.

jcai19 created this revision. Herald added subscribers: cfe-commits, mgorny, srhines. Herald added a project: clang. Checks if any calls to posix functions (except posix_openpt) expect negative return values. These functions return either 0 on success or an errno on failure, which is positive on

[PATCH] D63161: Devirtualize destructor of final class.

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Thanks! Minor comment then feel free to commit. Comment at: lib/CodeGen/CGExprCXX.cpp:1877 + DevirtualizedDtor->getParent(); + if (getCXXRecord(Base) ==

[PATCH] D63161: Devirtualize destructor of final class.

rsmith added inline comments. Comment at: test/CodeGenCXX/devirtualize-dtor-final.cpp:20 + void evil(D *p) { +// CHECK-NOT: call void@_ZN5Test11DD1Ev +delete p; Missing space after `void` here Repository: rC Clang CHANGES SINCE LAST ACTION https:/

[PATCH] D63623: [clang-tidy] Add a check on expected return values of posix functions (except posix_openpt) in Android module.

lebedev.ri added a comment. Why is this in android module? Is that android-specific behavior, or posix? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63623/new/ https://reviews.llvm.org/D63623 ___ cfe-

[PATCH] D63603: [ASTImporter] Propagate error from ImportDeclContext

jkorous added a comment. I don't have the insight to LGTM the whole change - just a nit about implementation detail. Comment at: clang/lib/AST/ASTImporter.cpp:1724 + }; + DefinitionCompleter CompleterRAII(To); You might consider using just a lambda with `l

[PATCH] D63451: P0840R2: support for [[no_unique_address]] attribute

rjmccall added a comment. In D63451#1552609 , @rsmith wrote: > In D63451#1549563 , @rjmccall wrote: > > > Can this attribute not be applied to a base class, or to a type? > > > The standard attribute forbids that ri

[PATCH] D63623: [clang-tidy] Add a check on expected return values of posix functions (except posix_openpt) in Android module.

george.burgess.iv added a comment. just a few drive-by nits/comments from me. as usual, not super familiar with clang-tidy, so i won't be able to stamp this. thanks! Comment at: clang-tools-extra/clang-tidy/android/PosixReturnCheck.cpp:23 + binaryOperator( + has

[PATCH] D63623: [clang-tidy] Add a check on expected return values of posix functions (except posix_openpt) in Android module.

jcai19 added a comment. In D63623#1552679 , @lebedev.ri wrote: > Why is this in android module? > Is that android-specific behavior, or posix? I implemented it for Andriod as requested, but it would be completely fine to move it if it is better to plac

[PATCH] D63600: [test][Driver] Fix Clang :: Driver/cl-response-file.c

jkorous accepted this revision. jkorous added a comment. This revision is now accepted and ready to land. Herald added a subscriber: dexonsmith. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63600/new/ https://reviews.llvm.org/D63600 _

r363985 - [test][Driver] Fix Clang :: Driver/cl-response-file.c

Author: ro Date: Thu Jun 20 14:33:09 2019 New Revision: 363985 URL: http://llvm.org/viewvc/llvm-project?rev=363985&view=rev Log: [test][Driver] Fix Clang :: Driver/cl-response-file.c Clang :: Driver/cl-response-file.c currently FAILs on Solaris: Command Output (stderr): -- /vol/llvm/src/cl

[PATCH] D63625: [CodeGen][test] Use -fno-discard-value-names for better test support

rupprecht created this revision. rupprecht added reviewers: rnk, akhuang, aprantl. Herald added a project: clang. Herald added a subscriber: cfe-commits. Depending on how clang is built, it may discard the IR names and use names like `%2` instead of `%result.ptr`, causing tests that rely on the I

[PATCH] D63600: [test][Driver] Fix Clang :: Driver/cl-response-file.c

This revision was automatically updated to reflect the committed changes. Closed by commit rL363985: [test][Driver] Fix Clang :: Driver/cl-response-file.c (authored by ro, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://rev

r363986 - AMDGPU: Add DS GWS sema builtins

Author: arsenm Date: Thu Jun 20 14:33:57 2019 New Revision: 363986 URL: http://llvm.org/viewvc/llvm-project?rev=363986&view=rev Log: AMDGPU: Add DS GWS sema builtins Modified: cfe/trunk/include/clang/Basic/BuiltinsAMDGPU.def cfe/trunk/test/CodeGenOpenCL/builtins-amdgcn-ci.cl cfe/trunk

[PATCH] D63625: [CodeGen][test] Use -fno-discard-value-names for better test support

lebedev.ri added a comment. In D63625#1552756 , @akhuang wrote: > Looks good, alternatively I think we can just change `%result.ptr` into a > variable match? Why isn't this using FileCheck variable matching in the first place? That's the least fragile

[PATCH] D63625: [CodeGen][test] Use -fno-discard-value-names for better test support

akhuang added a comment. Looks good, alternatively I think we can just change `%result.ptr` into a variable match? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63625/new/ https://reviews.llvm.org/D63625

  1   2   >