[PATCH] D40381: Parse concept definition

saar.raz added a comment. @rsmith? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D40381/new/ https://reviews.llvm.org/D40381 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailm

r360559 - [c++20] P1064R0: Allow virtual function calls in constant expression

Author: rsmith Date: Mon May 13 00:42:10 2019 New Revision: 360559 URL: http://llvm.org/viewvc/llvm-project?rev=360559&view=rev Log: [c++20] P1064R0: Allow virtual function calls in constant expression evaluation. Modified: cfe/trunk/include/clang/AST/DeclCXX.h cfe/trunk/include/clang/Bas

[PATCH] D60953: [clangd] Respect clang-tidy suppression comments

sammccall added a comment. Thanks, this looks nice. Main ideas here: - it'd be nice to get rid of the subclassing in the diag consumer if we can - i'm not sure the logic around LastErrorWasIgnored is completely accurate - can we add a unit test for this? The existing clang-tidy diag tests are in

r360560 - PR41854: Don't assert when constant-evaluating a member function call on an invalid designator.

Author: rsmith Date: Mon May 13 00:51:29 2019 New Revision: 360560 URL: http://llvm.org/viewvc/llvm-project?rev=360560&view=rev Log: PR41854: Don't assert when constant-evaluating a member function call on an invalid designator. Modified: cfe/trunk/lib/AST/ExprConstant.cpp cfe/trunk/test

r360563 - PR41845: Detect and reject mismatched inner/outer pack expansion sizes

Author: rsmith Date: Mon May 13 01:31:14 2019 New Revision: 360563 URL: http://llvm.org/viewvc/llvm-project?rev=360563&view=rev Log: PR41845: Detect and reject mismatched inner/outer pack expansion sizes in fold expressions rather than crashing. Modified: cfe/trunk/include/clang/AST/ExprCXX.h

[PATCH] D58033: Add option for emitting dbg info for call site parameters

djtodoro updated this revision to Diff 199213. djtodoro edited the summary of this revision. djtodoro added a comment. -Add an input in test/CodeGenCXX/dbg-info-all-calls-described.cpp -Rename the option CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58033/new/ https://reviews.llvm.org/D

[PATCH] D58035: [clang/DIVar] Emit flag for params that have unchanged values

djtodoro updated this revision to Diff 199214. djtodoro added a comment. -Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58035/new/ https://reviews.llvm.org/D58035 Files: lib/CodeGen/CGDebugInfo.cpp lib/CodeGen/CGDebugInfo.h Index: lib/CodeGen/CGDebugInfo.h

[PATCH] D61841: [clangd] Respect WarningsAsErrors configuration for clang-tidy

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/ClangdUnit.cpp:346 + std::string CheckName = CTContext->getCheckName(Info.getID()); + if (!CheckName.empty() && WarningAsErrorFilter->contains(CheckName)) { +Level = DiagnosticsEngine::Err

[PATCH] D61790: [C++20] add consteval specifier

martong resigned from this revision. martong added a comment. Herald added a subscriber: rnkovacs. ASTImporter.cpp looks good to me. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61790/new/ https://reviews.llvm.org/D61790 __

[PATCH] D61786: [ASTImporter] Separate unittest files

martong marked 8 inline comments as done. martong added a comment. Thanks for the review Alexei! Comment at: clang/unittests/AST/ASTImporterGenericRedeclTest.cpp:20 + +// FIXME put these structs and the tests rely on them into their own separate +// test file!

[PATCH] D61786: [ASTImporter] Separate unittest files

martong updated this revision to Diff 199225. martong marked 2 inline comments as done. martong added a comment. - Address Alexei's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61786/new/ https://reviews.llvm.org/D61786 Files: clang/un

r360572 - [ASTImporter] Separate unittest files

Author: martong Date: Mon May 13 03:06:25 2019 New Revision: 360572 URL: http://llvm.org/viewvc/llvm-project?rev=360572&view=rev Log: [ASTImporter] Separate unittest files Summary: Move generic redecl chain tests and visibility tests into their own separate test files. Reviewers: a_sidorin, a.si

[PATCH] D61786: [ASTImporter] Separate unittest files

This revision was automatically updated to reflect the committed changes. Closed by commit rC360572: [ASTImporter] Separate unittest files (authored by martong, committed by ). Changed prior to commit: https://reviews.llvm.org/D61786?vs=199225&id=199226#toc Repository: rC Clang CHANGES SINC

[PATCH] D61849: Do not list enabled checks when -quiet is given to clang-tidy.

svenpanne created this revision. svenpanne added a reviewer: alexfh. Herald added a project: clang. Herald added a subscriber: cfe-commits. When clang-tidy is given the -quiet flag, do not output the potentially hundreds of enabled check names at the beginning. Repository: rCTE Clang Tools Ex

[PATCH] D61850: Removed superfluous and slightly annoying newlines in run-clang-tidy's output.

svenpanne created this revision. svenpanne added a reviewer: alexfh. Herald added a project: clang. Herald added a subscriber: cfe-commits. The output of clang-tidy itself already has enough newlines, so the resulting output is more in line with the usual compiler output. Repository: rCTE Cla

[PATCH] D59885: [Lex] Allow to consume tokens while preprocessing

ilya-biryukov marked 2 inline comments as done. ilya-biryukov added a comment. I'll try to explore bringing the overhead down. The fact that `CachingLex` is happening at `LexLevel==1` might help, thanks for pointing that out! Comment at: clang/lib/Lex/PPCaching.cpp:64 ExitC

[PATCH] D60748: Fix i386 struct and union parameter alignment

wxiao3 updated this revision to Diff 199232. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60748/new/ https://reviews.llvm.org/D60748 Files: lib/CodeGen/TargetInfo.cpp test/CodeGen/x86_32-align-linux.c test/CodeGen/x86_32-arguments-linux.c Index: test/CodeGen/x86_32-arguments-linu

[PATCH] D60748: Fix i386 struct and union parameter alignment

wxiao3 updated this revision to Diff 199231. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60748/new/ https://reviews.llvm.org/D60748 Files: lib/CodeGen/TargetInfo.cpp test/CodeGen/vector.c test/CodeGen/x86_32-arguments-darwin.c test/CodeGen/x86_32-arguments-linux.c test/CodeGe

[PATCH] D59744: Fix i386 ABI "__m64" type bug

wxiao3 updated this revision to Diff 199233. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59744/new/ https://reviews.llvm.org/D59744 Files: lib/CodeGen/TargetInfo.cpp test/CodeGen/vector.c test/CodeGen/x86_32-arguments-darwin.c test/CodeGen/x86_32-arguments-linux.c test/CodeGe

[PATCH] D59744: Fix i386 ABI "__m64" type bug

wxiao3 marked an inline comment as done. wxiao3 added inline comments. Comment at: lib/CodeGen/TargetInfo.cpp:919 /// IsX86_MMXType - Return true if this is an MMX type. bool IsX86_MMXType(llvm::Type *IRType) { - // Return true if the type is an MMX type <2 x i32>, <4 x i16>,

[PATCH] D60748: Fix i386 struct and union parameter alignment

wxiao3 added a comment. Any other comments? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60748/new/ https://reviews.llvm.org/D60748 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

[PATCH] D60748: Fix i386 struct and union parameter alignment

dim added subscribers: emaste, dim. dim added a comment. Please also exclude FreeBSD from these changes, since we care a lot about backwards compatibility, and specifically about alignment requirements. (We have run into many issues in our ports collection where upstream assumes everything is

[PATCH] D60748: Fix i386 struct and union parameter alignment

dim added a comment. In fact, it is probably better to turn the OS check around, e.g. *only* increase the alignment for Linux, and nowhere else. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60748/new/ https://reviews.llvm.org/D60748 ___ c

[PATCH] D61851: [clang-tidy] New option for misc-throw-by-value-catch-by-reference

baloghadamsoftware created this revision. baloghadamsoftware added reviewers: alexfh, aaron.ballman, lebedev.ri. baloghadamsoftware added a project: clang-tools-extra. Herald added subscribers: gamesh411, Szelethus, rnkovacs. Herald added a project: clang. Catching trivial objects by value is not

[PATCH] D61497: [clangd] Introduce a structured hover response

kadircet marked 16 inline comments as done. kadircet added a comment. Thanks for also taking a look at the implementation, it is not complete yet. I am rather waiting for a green light on struct itself, so that I can write tests. Comment at: clang-tools-extra/clangd/XRefs.cpp:

[PATCH] D61497: [clangd] Introduce a structured hover response

kadircet updated this revision to Diff 199257. kadircet marked 2 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61497/new/ https://reviews.llvm.org/D61497 Files: clang-tools-ex

r360580 - Revert r360559 "[c++20] P1064R0: Allow virtual function calls in constant expression evaluation."

Author: hans Date: Mon May 13 06:19:09 2019 New Revision: 360580 URL: http://llvm.org/viewvc/llvm-project?rev=360580&view=rev Log: Revert r360559 "[c++20] P1064R0: Allow virtual function calls in constant expression evaluation." This caused Chromium builds to hit the new "can't handle virtual ca

Re: r360559 - [c++20] P1064R0: Allow virtual function calls in constant expression

This caused asserts in Chromium, so I've reverted in r360580. There's a repro at https://bugs.chromium.org/p/chromium/issues/detail?id=962458#c1, and I'm working on a reduced version. From: Richard Smith via cfe-commits Date: Mon, May 13, 2019 at 9:39 AM To: > Author: rsmith > Date: Mon May 13

[PATCH] D53866: [Preamble] Stop circular inclusion of main file when building preamble

ilya-biryukov added a comment. I guess using `Edit Related Object -> Edit Commits` should do the trick. I'm not sure what the "Lean Into Action" is either. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53866/new/ https://reviews.llvm.org/D53866 ___

[PATCH] D53023: Prototype OpenCL BIFs using Tablegen

AlexeySotkin added a comment. LGTM! @joey, any idea when it will be landed? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53023/new/ https://reviews.llvm.org/D53023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D53023: Prototype OpenCL BIFs using Tablegen

svenvh added a comment. In D53023#1499942 , @AlexeySotkin wrote: > LGTM! @joey, any idea when it will be landed? This work is being continued in https://reviews.llvm.org/D60763 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53023/new/ https://

r360539 - make -ftime-trace also print template arguments

Author: llunak Date: Sun May 12 03:39:21 2019 New Revision: 360539 URL: http://llvm.org/viewvc/llvm-project?rev=360539&view=rev Log: make -ftime-trace also print template arguments Without this, I get e.g. 'PerformPendingInstantiations' -> 'std::fill', now I get 'std::fill'. Differential Revisio

[PATCH] D61634: [clang/llvm] Allow efficient implementation of libc's memory functions in C/C++

gchatelet added a comment. In D61634#1498376 , @efriedma wrote: > I still think there are really two things you're trying to accomplish here, > which should be handled separately. > > 1. Add a function attribute that works like -fno-builtin-memcpy current

[PATCH] D61765: [OpenMP][Clang][BugFix] Split declares and math functions inclusion.

jdoerfert added a comment. Two small changes and then it is fine with me. @tra ? 1. we need to use ifdef to not define clock 2. Can you switch the include order in `test/Headers/nvptx_device_math_functions.cpp`? P.S. I'm currently at the OpenMP standard meeting to get the OpenMP variants fixed

Re: r360452 - Replace 'REQUIRES: nozlib' with '!zlib' because we don't need two ways

What's the practical difference between "UNSUPPORTED: foo" and "REQUIRES: !foo"? (I see some of the fixes you've made go one way, some the other way) On Fri, May 10, 2019 at 11:30 AM Paul Robinson via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: probinson > Date: Fri May 10 11:32:53

Re: r360559 - [c++20] P1064R0: Allow virtual function calls in constant expression

Here's a creduced repro: -- class a {}; class b : virtual a { virtual bool c(const void *, int); }; class C : b { public: bool c(const void *, int); }; int d; bool e() { C f; if (f.c(&d, d)) ; } -- $ clang.bad -cc1 -triple x86_64-unknown-linux-gnu -fsyntax-only -std=c++14 a.cc The as

[PATCH] D61724: [clangd] Use AsyncTaskRunner in BackgroundIndex instead of std::thread

umanwizard added inline comments. Comment at: clang-tools-extra/trunk/clangd/index/Background.cpp:164 stop(); - for (auto &Thread : ThreadPool) -Thread.join(); + ThreadPool.wait(); } This is already called in `~AsyncTaskRunner`. Repository: rL LLVM

[PATCH] D61724: [clangd] Use AsyncTaskRunner in BackgroundIndex instead of std::thread

umanwizard added a comment. Ignore me. I didn't read the previous discussion before commenting. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61724/new/ https://reviews.llvm.org/D61724 ___ cfe-commits mailing list cfe

[PATCH] D61804: Support building shared and static libraries simultaneously

tstellar added a comment. Not sure if this would be relevant for your use case, but it would be really nice to have a libCLANG.so with all the C++ symbols, like we do for llvm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61804/new/ https://revie

[PATCH] D57858: [analyzer] Add a new frontend flag to display all checker options

dkrupp added a comment. In D57858#1499414 , @Szelethus wrote: > In D57858#1498640 , @NoQ wrote: > > > So, like, the global picture is as follows. In our case the Driver (i.e., > > --analyze) is not much more user f

[PATCH] D61804: Support building shared and static libraries simultaneously

beanz added a comment. In D61804#1499275 , @winksaville wrote: > When you say you don't think the build system should do this, what do you > mean? `llvm_add_library` supports both, because there are places where we consciously choose to build both. Tha

[PATCH] D60543: [clang] Update isDerivedFrom to support Objective-C classes 🔍

aaron.ballman added a comment. In D60543#1497576 , @stephanemoore wrote: > I did some digging and I believe there are two approaches that we can take to > extend `isDerivedFrom` to support Objective-C classes. > > **Option 1: Match on Common Ancestor Dec

[PATCH] D60543: [clang] Update isDerivedFrom to support Objective-C classes 🔍

aaron.ballman added reviewers: klimek, alexfh. aaron.ballman added a comment. Adding some more AST matcher reviewers to see if there are other options that we've not considered. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60543/new/ https://revi

[PATCH] D61858: Make `__is_base_of` more friendly with unions

mclow.lists created this revision. mclow.lists added reviewers: rsmith, t.p.northover, EricWF, ldionne. mclow.lists added a project: clang. Herald added a subscriber: dexonsmith. Unions are never base classes, and never have base classes. It doesn't matter if they are complete or not. See http://l

[PATCH] D61438: [ASTImporter] Use llvm::Expected and Error in the importer API

martong added a comment. @aprantl Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61438/new/ https://reviews.llvm.org/D61438 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D61858: Make `__is_base_of` more friendly with unions

mclow.lists added a comment. Note: There are tabs in `clang/test/SemaCXX/type-traits.cpp` that I didn't remove because it would have cluttered up the diff. I can de-tabify the file when it is committed if people want. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61858/new/ https://rev

[PATCH] D59798: [analyzer] Add analyzer option to limit the number of imported TUs

gamesh411 updated this revision to Diff 199277. gamesh411 added a comment. Apply review suggestions by Xazax Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59798/new/ https://reviews.llvm.org/D59798 Files: include/clang/CrossTU/CrossTranslationUnit.h include/

[PATCH] D59798: [analyzer] Add analyzer option to limit the number of imported TUs

gamesh411 marked an inline comment as done. gamesh411 added a comment. I could greatly simplify the API of getCrossTUDefinition by injecting the threshold value in the constructor. A minor drawback with this approach is that testing code is a bit more complicated, as I had to patch the CompilerI

[PATCH] D59798: [analyzer] Add analyzer option to limit the number of imported TUs

gamesh411 updated this revision to Diff 199278. gamesh411 added a comment. Revert unnecessary clang-formating of AnalysisConsumer.cpp Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59798/new/ https://reviews.llvm.org/D59798 Files: include/clang/CrossTU/CrossTra

[PATCH] D60974: Clang IFSO driver action.

plotfi added a comment. @compnerd Any other test cases you'd like before the first drop? @jakehehrlich @rupprecht Do things here look good to you guys? Both formats are marked experimental, I plan to work on a merge action next. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D61861: DeleteNullPointerCheck now deletes until the end brace of the condition

J-Camilleri created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Bug Fix for #35811 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D61861 Files: clang-tools-extra/clang-tidy/readability/DeleteNullPointerCheck.cpp clang-tools-extra/te

[PATCH] D59465: [analyzer] Add a test plugin for checker option handling

Szelethus added a comment. Ping^2 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59465/new/ https://reviews.llvm.org/D59465 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D59464: [analyzer] Add an example plugin for checker dependency handling

Szelethus added a comment. Ping^3 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59464/new/ https://reviews.llvm.org/D59464 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D58035: [clang/DIVar] Emit flag for params that have unchanged values

aprantl added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:3885 + if (ArgNo) { +auto *PD = dyn_cast(VD); +ParmCache[PD].reset(D); A `dyn_cast` followed by an unconditional use seems strange. I would expect either a `cast` or an `if (PD)` che

[PATCH] D61865: [clangd] improve help message for limit-results

umanwizard created this revision. umanwizard added a reviewer: clang-tools-extra. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Make it clear that the default is 100. Repository: rCTE Clang Tools Extra https://revie

[PATCH] D61765: [OpenMP][Clang][BugFix] Split declares and math functions inclusion.

tra added a comment. In D61765#1499957 , @jdoerfert wrote: > Two small changes and then it is fine with me. @tra ? LGTM in general. I would still like to confirm that the changes work with libc++. Repository: rC Clang CHANGES SINCE LAST ACTION ht

Re: r360559 - [c++20] P1064R0: Allow virtual function calls in constant expression

Thanks for the revert and the reduced test case. On Mon, 13 May 2019, 07:50 Hans Wennborg via cfe-commits, < cfe-commits@lists.llvm.org> wrote: > Here's a creduced repro: > > -- > class a {}; > class b : virtual a { > virtual bool c(const void *, int); > }; > class C : b { > public: > bool c(

[PATCH] D58920: [Modules][PR39287] Consolidate multiple std's

modocache added a comment. Thanks @rsmith for the guidance here! I appreciate it very much. One snag I ran into after following your suggestion, though, is that when I modify `ASTDeclReader::findExisting` to return Sema's existing implicit std namespace, I run into an assertion later on, when t

r360607 - [clang][ASTContext] Call setAttached for comments attached to a declaration

Author: jkorous Date: Mon May 13 10:52:09 2019 New Revision: 360607 URL: http://llvm.org/viewvc/llvm-project?rev=360607&view=rev Log: [clang][ASTContext] Call setAttached for comments attached to a declaration This is a bug affecting performance when compiling with -Wdocumentation. In Sema::ActO

[PATCH] D61851: [clang-tidy] New option for misc-throw-by-value-catch-by-reference

torbjoernk added inline comments. Comment at: docs/clang-tidy/checks/misc-throw-by-value-catch-by-reference.rst:35-46 +.. option:: WarnOnLargeObject + + Also warns for any large trivial object caught by value. Catching a large + object by value is not dangerous but affects t

[PATCH] D61858: Make `__is_base_of` more friendly with unions

ldionne added a comment. Shouldn't we also add unit tests for PR41843 in libc++? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61858/new/ https://reviews.llvm.org/D61858 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D61861: DeleteNullPointerCheck now deletes until the end brace of the condition

madsravn added a comment. Besides my one comment this looks good to me. Comment at: clang-tools-extra/test/clang-tidy/readability-delete-null-pointer.cpp:9 // #1 - if (p) { // #2 + if (p /**/) { // #2 delete p; Would you mind creating a new test inst

[PATCH] D61749: [clang-tidy] initial version of readability-static-const-method

JonasToth added inline comments. Comment at: clang-tools-extra/test/clang-tidy/readability-static-const-method.cpp:209 +void KeepLambdas() { + auto F = +[]() { return 0; }; + auto F2 = []() { return 0; }; mgehre wrote: > JonasToth wrote: > > Does it pass here?

[PATCH] D61849: Do not list enabled checks when -quiet is given to run-clang-tidy.

JonasToth accepted this revision. JonasToth added a comment. This revision is now accepted and ready to land. LGTM Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61849/new/ https://reviews.llvm.org/D61849 __

[PATCH] D61850: Removed superfluous and slightly annoying newlines in run-clang-tidy's output.

JonasToth added a comment. I agree with the direction, please ensure that e.g. clang-analyzer-* output looks proper as well and `-quiet` does, too. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61850/new/ https://reviews.llvm.org/D61850

[PATCH] D61765: [OpenMP][Clang][BugFix] Split declares and math functions inclusion.

gtbercea added a comment. In D61765#1500233 , @tra wrote: > In D61765#1499957 , @jdoerfert wrote: > > > Two small changes and then it is fine with me. @tra ? > > > LGTM in general. I would still like to confirm that

[PATCH] D61438: [ASTImporter] Use llvm::Expected and Error in the importer API

aprantl added inline comments. Comment at: clang/include/clang/AST/ASTImporter.h:203 /// context, or the import error. -llvm::Expected Import_New(TypeSourceInfo *FromTSI); -// FIXME: Remove this version. -TypeSourceInfo *Import(TypeSourceInfo *FromTSI); +llvm

[libunwind] r360610 - Add a new LIBUNWIND_WEAK_PTHREAD Cmake option to force

Author: saugustine Date: Mon May 13 11:45:03 2019 New Revision: 360610 URL: http://llvm.org/viewvc/llvm-project?rev=360610&view=rev Log: Add a new LIBUNWIND_WEAK_PTHREAD Cmake option to force calls into the pthread library use weak symbols. This option allows libpthread to be a weak dependency ra

[PATCH] D61850: Removed superfluous and slightly annoying newlines in run-clang-tidy's output.

svenpanne added a comment. In D61850#1500298 , @JonasToth wrote: > [...] please ensure that e.g. clang-analyzer-* output looks proper as well > and `-quiet` does, too. OK, are there any (unit) tests which I should run? If yes, how exactly? I have a suc

[PATCH] D61858: Make `__is_base_of` more friendly with unions

mclow.lists added a comment. In D61858#1500270 , @ldionne wrote: > Shouldn't we also add unit tests for PR41843 in libc++? Yes. But I want to do that later. After this has landed (and probably wait a week for all the bots that are running trunk to updat

[PATCH] D61858: Make `__is_base_of` more friendly with unions

ldionne accepted this revision. ldionne added a comment. This revision is now accepted and ready to land. I'm not a frontend expert, but this looks reasonable to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61858/new/ https://reviews.llvm.org/D61858 _

[PATCH] D61765: [OpenMP][Clang][BugFix] Split declares and math functions inclusion.

gtbercea updated this revision to Diff 199304. gtbercea added a comment. - Exclude clock functions. Reverse inclusion order. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61765/new/ https://reviews.llvm.org/D61765 Files: lib/Driver/ToolChains/Clang.cpp lib/H

[PATCH] D61858: Make `__is_base_of` more friendly with unions

rsmith accepted this revision. rsmith added a comment. Yeah, this seems to match the library wording. (I think it's short-sighted and over-fitting -- this is baking into the library specification that the language happens to not allow unions to have base classes today -- but this isn't the venu

[clang-tools-extra] r360613 - [clang-tidy] readability-redundant-declaration: fix false positive with C "extern inline"

Author: mgehre Date: Mon May 13 12:21:57 2019 New Revision: 360613 URL: http://llvm.org/viewvc/llvm-project?rev=360613&view=rev Log: [clang-tidy] readability-redundant-declaration: fix false positive with C "extern inline" Summary: readability-redundant-declaration was diagnosing a redundant dec

[PATCH] D61700: [clang-tidy] readability-redundant-declaration: fix false positive with C "extern inline"

This revision was automatically updated to reflect the committed changes. mgehre marked 2 inline comments as done. Closed by commit rL360613: [clang-tidy] readability-redundant-declaration: fix false positive with C… (authored by mgehre, committed by ). Herald added a project: LLVM. Herald added a

r360614 - Make more friendly with unions. Reviewed as https://reviews.llvm.org/D61858

Author: marshall Date: Mon May 13 12:29:23 2019 New Revision: 360614 URL: http://llvm.org/viewvc/llvm-project?rev=360614&view=rev Log: Make more friendly with unions. Reviewed as https://reviews.llvm.org/D61858 Modified: cfe/trunk/lib/Sema/SemaExprCXX.cpp cfe/trunk/test/SemaCXX/type-trai

[PATCH] D61858: Make `__is_base_of` more friendly with unions

mclow.lists closed this revision. mclow.lists added a comment. Committed as revision 360614 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61858/new/ https://reviews.llvm.org/D61858 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D24892: [clang-tidy] Add option "LiteralInitializers" to cppcoreguidelines-pro-type-member-init

mgehre added a comment. Do I wait for @alexfh to turn his red into a green, too? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D24892/new/ https://reviews.llvm.org/D24892 ___ cfe-commits mailing list cf

[PATCH] D59885: [Lex] Allow to consume tokens while preprocessing

rsmith added a comment. Thinking about this some more: distinguishing between "macro expansion" and other cases seems like a proxy for "this token came from inside the preprocessor / lexer" versus "this token was provided by the user", which is also exactly what `IsNewToken` is supposed to capt

[PATCH] D61619: Make language option `GNUAsm` discoverable with `__has_extension` macro.

vsapsai added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61619/new/ https://reviews.llvm.org/D61619 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D61851: [clang-tidy] New option for misc-throw-by-value-catch-by-reference

aaron.ballman added inline comments. Comment at: clang-tidy/misc/ThrowByValueCatchByReferenceCheck.cpp:25 + WarnOnLargeObject(Options.get("WarnOnLargeObject", false)), + // Cannot access `ASTContext` from here so set it to an extremal value + MaxSize(Options.get("M

[PATCH] D61804: Support building shared and static libraries simultaneously

winksaville added a comment. > Arch Linux is in an unsupported state, and your patch isn't the way forward. OK, I'll filed a bug, https://bugs.archlinux.org/task/62624 > Let's rewind. > > Why do "some people like shared libraries"? There are usually two reasons > people cite for linking shared

[PATCH] D61707: [Preprocessor] Fix crash emitting note with framework location for "file not found" error.

vsapsai added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61707/new/ https://reviews.llvm.org/D61707 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D24892: [clang-tidy] Add option "LiteralInitializers" to cppcoreguidelines-pro-type-member-init

aaron.ballman added a comment. In D24892#1500371 , @mgehre wrote: > Do I wait for @alexfh to turn his red into a green, too? I think you covered all of the concerns he raised. If he doesn't give you an LG in the next 24 hours, I think you can go ahead a

[PATCH] D61619: Make language option `GNUAsm` discoverable with `__has_extension` macro.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61619/new/ https://reviews.llvm.org/D61619 ___ cfe-commits mailing lis

[PATCH] D61809: [BPF] Preserve original struct/union type name/access index and array subscripts

yonghong-song added a comment. @rsmith @eli.friedman Thanks for your comments. I fully agree that it seems awkward that we have both GEP and intrinsic generation. I will try to do some experiments here to only have intrinsic generation. My only concern is possible performance degradation. I wil

[PATCH] D24892: [clang-tidy] Add option "LiteralInitializers" to cppcoreguidelines-pro-type-member-init

lebedev.ri added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:66-69 +- Added `UseAssignment` option to `cppcoreguidelines-pro-type-member-init` + + If set to true, the check will provide fix-its with literal initializers + (``int i = 0;``) instead of cur

[PATCH] D61804: Support building shared and static libraries simultaneously

beanz added a comment. My change should not have decreased build time from trunk, nor should it have reduced the number of build steps. That patch should generate lib/libClang_shared.so, which will export the C++ API. libClang is unchanged since changing it would break existing clients of the l

[PATCH] D58920: [Modules][PR39287] Consolidate multiple std's

rsmith added a comment. The problem may well be that you're recursively triggering deserialization of the `std` namespace from its own deserialization. In D58920#1500246 , @modocache wrote: > @@ -3401,6 +3402,22 @@ ASTDeclReader::FindExistingResult >

[PATCH] D61370: Add a C2x mode and allow attributes in it

aaron.ballman added a comment. Ping x2. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61370/new/ https://reviews.llvm.org/D61370 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[PATCH] D61861: DeleteNullPointerCheck now deletes until the end brace of the condition

J-Camilleri updated this revision to Diff 199315. J-Camilleri added a comment. Added a new unit test and restored the modified test as it was. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61861/new/ https://reviews.llvm.org/D61861 Files: clang-

[PATCH] D61804: Support building shared and static libraries simultaneously

winksaville added a comment. In D61804#1500409 , @beanz wrote: > My change should not have decreased build time from trunk, nor should it have > reduced the number of build steps. That patch should generate > lib/libClang_shared.so, which will export the

[PATCH] D61765: [OpenMP][Clang][BugFix] Split declares and math functions inclusion.

tra added a comment. In D61765#1500309 , @gtbercea wrote: > As soon as libc++ the limits header included in > > __clang_cuda_cmath.h:15 > ``` is not found: > > > > > __clang_cuda_cmath.h:15:10: fatal error: 'limits' file not found > #include > >

[PATCH] D61634: [clang/llvm] Allow efficient implementation of libc's memory functions in C/C++

efriedma added a comment. My main blocker is that I want to make sure we're moving in the right direction: towards LLVM IR with clear semantics, towards straightforward rules for writing freestanding C code, and towards solutions which behave appropriately for all targets. There's clearly a pr

[PATCH] D61765: [OpenMP][Clang][BugFix] Split declares and math functions inclusion.

gtbercea added a comment. In D61765#1500446 , @tra wrote: > In D61765#1500309 , @gtbercea wrote: > > > As soon as libc++ the limits header included in > > > > __clang_cuda_cmath.h:15 > > ``` is not found: > >

[PATCH] D61765: [OpenMP][Clang][BugFix] Split declares and math functions inclusion.

gtbercea added a comment. In D61765#1500446 , @tra wrote: > In D61765#1500309 , @gtbercea wrote: > > > As soon as libc++ the limits header included in > > > > __clang_cuda_cmath.h:15 > > ``` is not found: > >

[PATCH] D60162: [ThinLTO] Support TargetLibraryInfoImpl in the backend

tejohnson updated this revision to Diff 199320. tejohnson added a comment. Herald added subscribers: cfe-commits, hiraditya, eraman. Herald added a project: clang. Rework using module flags. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60162/new/

[PATCH] D60162: [ThinLTO] Support TargetLibraryInfoImpl in the backend

tejohnson added a comment. In D60162#1498392 , @tejohnson wrote: > In D60162#1498288 , @tejohnson wrote: > > > Working on this one again as it previously wasn't causing any issues but > > just now got exposed in mu

[PATCH] D60910: [WIP] Dumping the AST to JSON

aaron.ballman updated this revision to Diff 199316. aaron.ballman marked 2 inline comments as done. aaron.ballman added a comment. Switched to using the JSON streaming interface rather than a custom solution Updated the test cases for the new formatting CHANGES SINCE LAST ACTION https://review

[PATCH] D60163: [ThinLTO] Handle -fno-builtin* options for distributed backends

tejohnson abandoned this revision. tejohnson added a comment. The parent revision now includes both clang and llvm side changes. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60163/new/ https://reviews.llvm.org/D60163 __

  1   2   >