[PATCH] D59566: [X86] Correct the value of MaxAtomicInlineWidth for pre-586 cpus

2019-03-21 Thread Craig Topper via Phabricator via cfe-commits
craig.topper updated this revision to Diff 191643. craig.topper added a comment. Herald added subscribers: cfe-commits, jdoerfert. Herald added a project: clang. Rewrite to use a "cx8" feature flag that is set for all i586 and greater CPUs as well as generic. This assumes generic is never passed

[clang-tools-extra] r356649 - Reland r356547 after fixing the YAML module missing issue.

2019-03-21 Thread Zinovy Nis via cfe-commits
Author: zinovy.nis Date: Thu Mar 21 01:32:07 2019 New Revision: 356649 URL: http://llvm.org/viewvc/llvm-project?rev=356649&view=rev Log: Reland r356547 after fixing the YAML module missing issue. [clang-tidy] Parallelize clang-tidy-diff.py This patch has 2 rationales: - large patches lead to lo

[PATCH] D42034: [clang-format] In tests, expected code should be format-stable

2019-03-21 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added inline comments. Herald added a project: LLVM. Comment at: cfe/trunk/unittests/Format/FormatTest.cpp:78 EXPECT_EQ(Expected.str(), format(Code, Style)); if (Style.Language == FormatStyle::LK_Cpp) { // Objective-C++ is a superset of C++, so eve

[PATCH] D42034: [clang-format] In tests, expected code should be format-stable

2019-03-21 Thread Manuel Klimek via Phabricator via cfe-commits
klimek added a comment. Great idea! LG from my side after addressing MyDeveloperDay's comments. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D42034/new/ https://reviews.llvm.org/D42034 ___ cfe-commits mailing list cfe

[PATCH] D59440: add steps to preprocess file and reduce command line args

2019-03-21 Thread Alexander Richardson via Phabricator via cfe-commits
arichardson added a comment. @akhuang Thanks for getting this committed. Since it seems like a lot of this is taken from my script, could you please add me as a reviewer for the next patch so that I know which bits still need to be upstreamed? Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D58404: [clang-format] Add basic support for formatting C# files

2019-03-21 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay updated this revision to Diff 191649. MyDeveloperDay added a comment. Addressing Review Comments - Remove all non Format only code (i.e. changes to clang/Basic and clang/Lexer to support verbatim interpolated strings C# 6) - For the most part the need to for them is removed by mer

[PATCH] D59629: [clang-format] correctly format protobuf fields named "enum".

2019-03-21 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59629/new/ https://reviews.llvm.org/D59629 __

[PATCH] D59627: [clang-format] Keep protobuf "package" statement on one line

2019-03-21 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added inline comments. Comment at: lib/Format/TokenAnnotator.cpp:1079 if (Style.Language == FormatStyle::LK_Proto && Line.Level == 0 && -CurrentToken->is(Keywords.kw_option)) { +(CurrentToken->is(Keywords.kw_option) || + CurrentToken->i

[PATCH] D58404: [clang-format] Add basic support for formatting C# files

2019-03-21 Thread Manuel Klimek via Phabricator via cfe-commits
klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. LG. This looks pretty sharp (scnr). Comment at: clang/lib/Format/FormatTokenLexer.cpp:177 +if (Dollar->TokenText == "$") { + // this looks like $@"a" so we need

[PATCH] D58404: [clang-format] Add basic support for formatting C# files

2019-03-21 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay updated this revision to Diff 191654. MyDeveloperDay marked 3 inline comments as done. MyDeveloperDay added a comment. Address comment nits CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58404/new/ https://reviews.llvm.org/D58404 Files: clang/docs/ClangFormat.rst clan

[PATCH] D58404: [clang-format] Add basic support for formatting C# files

2019-03-21 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTestCSharp.cpp:19 + +class FormatTestCSharp : public ::testing::Test { +protected: klimek wrote: > If everything's static, you don't need a test fixture at all, you can just > make it

[PATCH] D58278: Prepare ground for re-lexing modular headers.

2019-03-21 Thread Alexander Kornienko via Phabricator via cfe-commits
alexfh abandoned this revision. alexfh added a comment. I've found an alternative way to deal with PPCallbacks when analyzing code in modular mode. See https://reviews.llvm.org/D59528. Abandoning this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D58121: [analyzer][WIP] Attempt to fix traversing bindings of non-base regions in ClusterAnalysis

2019-03-21 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun added a comment. First of all, sorry for the inactivity regarding this patch. In D58121#1437433 , @NoQ wrote: > Ok, got it! Yeah, this sounds like a valid way of supporting > non-base-region-based worklist items, i'm seeing no problems with it

[PATCH] D59603: [PR40707][PR41011][OpenCL] Allow addr space spelling without double underscore in C++ mode

2019-03-21 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia updated this revision to Diff 191665. Anastasia added a comment. Updated test to use root namespace (commented by Ronan). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59603/new/ https://reviews.llvm.org/D59603 Files: include/clang/Basic/TokenKinds.def lib/Parse/ParseDecl

[PATCH] D59603: [PR40707][PR41011][OpenCL] Allow addr space spelling without double underscore in C++ mode

2019-03-21 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia added a comment. In D59603#1436794 , @keryell wrote: > I was a little bit worried about > > struct top_level { int i; }; > > private ::top_level a; > > > > but it should be fine because in that case we have a `tok::coloncolon` Yes, inde

[PATCH] D58236: Make address space conversions a bit stricter.

2019-03-21 Thread Bevin Hansson via Phabricator via cfe-commits
ebevhan added a comment. Any more input on this? I could redo the patch to simply fix the bug and not make the conversions stricter, if that's preferable. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58236/new/ https://reviews.llvm.org/D58236 __

[PATCH] D59523: Thread Safety: also look at ObjC methods

2019-03-21 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a reviewer: delesley. aaron.ballman added a comment. Adding Delesley in case he has input on design. Comment at: lib/Analysis/ThreadSafetyCommon.cpp:280 unsigned I = PV->getFunctionScopeIndex(); - -if (Ctx && Ctx->FunArgs && FD == Ctx->AttrDecl->get

[PATCH] D58841: [Diagnostics] Support -Wtype-limits for GCC compatibility

2019-03-21 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. I worry a little bit about our -Wtype-limits getting out of sync from GCC's due to making it a synonym for -Wtautological-constant-in-range-compare, but I'm also at a loss for why these two should ever have different functionality. I think I'm okay with this, but

[PATCH] D59637: [analyzer] Use the custom propagation rules and sinks in GenericTaintChecker

2019-03-21 Thread Borsik Gábor via Phabricator via cfe-commits
boga95 created this revision. boga95 added reviewers: NoQ, Szelethus, xazax.hun, dkrupp. Herald added subscribers: cfe-commits, Charusso, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, whisperity. Herald added a project: clang. The `TaintPropagationRule` deduction u

[PATCH] D59628: Add support for __attribute__((objc_class_stub))

2019-03-21 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. You should also add Sema tests that ensure the attribute applies to the expected AST nodes, is diagnosed appropriately when applied to something it shouldn't be applied to, accepts no args, etc. Basically, all of the semantic places we could warn on should have te

[PATCH] D59631: [AArch64] Support selecting TPIDR_EL[1-3] as the thread base

2019-03-21 Thread Oliver Stannard via Phabricator via cfe-commits
olista01 added a reviewer: olista01. olista01 added a comment. Is there an existing compiler which this option is trying to be compatible with? GCC for AArch64 doesn't currently have an option for this, so we don't have to worry about compatibility with that. If possible, I'd prefer for the opt

[PATCH] D59516: [analyzer] Add custom filter functions for GenericTaintChecker

2019-03-21 Thread Borsik Gábor via Phabricator via cfe-commits
boga95 updated this revision to Diff 191668. boga95 retitled this revision from "[analyzer] Make GenericTaintChecker configurable" to "[analyzer] Add custom filter functions for GenericTaintChecker". CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59516/new/ https://reviews.llvm.org/D5951

[PATCH] D58573: [analyzer] Move UninitializedObject out of alpha

2019-03-21 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus added a comment. Ping, @NoQ, if we settled on `optin.cplusplus`, would you be fine with this patch? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58573/new/ https://reviews.llvm.org/D58573 ___ cfe-commits

r356662 - [clang-format] Add basic support for formatting C# files

2019-03-21 Thread Paul Hoad via cfe-commits
Author: paulhoad Date: Thu Mar 21 06:09:22 2019 New Revision: 356662 URL: http://llvm.org/viewvc/llvm-project?rev=356662&view=rev Log: [clang-format] Add basic support for formatting C# files Summary: This revision adds basic support for formatting C# files with clang-format, I know the barrier

[PATCH] D58404: [clang-format] Add basic support for formatting C# files

2019-03-21 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC356662: [clang-format] Add basic support for formatting C# files (authored by paulhoad, committed by ). Changed prior to commit: https://reviews.llvm.org/D58404?vs=191654&id=191669#toc Repository: rC

[PATCH] D59528: [clang-tidy] Expand modular headers for PPCallbacks

2019-03-21 Thread Dmitri Gribenko via Phabricator via cfe-commits
gribozavr added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidy.h:156 + virtual void registerPPCallbacks(const SourceManager &SM, Preprocessor *PP, + Preprocessor *ModuleExpanderPP) {} + Please document that

r356663 - Permit redeclarations of a builtin to specify calling convention.

2019-03-21 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Thu Mar 21 06:30:56 2019 New Revision: 356663 URL: http://llvm.org/viewvc/llvm-project?rev=356663&view=rev Log: Permit redeclarations of a builtin to specify calling convention. After https://reviews.llvm.org/rL355317 we noticed that quite a decent amount of code redeclar

[PATCH] D59560: Permit redeclarations of a builtin to specify calling convention.

2019-03-21 Thread Erich Keane via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC356663: Permit redeclarations of a builtin to specify calling convention. (authored by erichkeane, committed by ). Herald added a subscriber: kristina. Herald added a project: clang. Repository: rC Clan

[PATCH] D59639: [clangd] Print template arguments helper

2019-03-21 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet created this revision. kadircet added reviewers: ioeric, ilya-biryukov. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, mgorny. Herald added a project: clang. Prepares ground for printing template arguments as written in the source code, part of re-landing rC356541

[PATCH] D59528: [clang-tidy] Expand modular headers for PPCallbacks

2019-03-21 Thread Dmitri Gribenko via Phabricator via cfe-commits
gribozavr added inline comments. Comment at: clang-tools-extra/clang-tidy/ExpandModularHeadersPPCallbacks.h:32 + +/// \brief Handles PPCallbacks and replays preprocessing with modules disabled. +/// replays => re-runs Repository: rG LLVM Github Monorepo CHAN

[PATCH] D59453: [ASTMatchers][OpenMP] Add base ompExecutableDirective() matcher.

2019-03-21 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri updated this revision to Diff 191674. lebedev.ri added a comment. Rebased, addressed nits. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59453/new/ https://reviews.llvm.org/D59453 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/

[PATCH] D59463: [ASTMatchers][OpenMP] OpenMP Structured-block-related matchers

2019-03-21 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri updated this revision to Diff 191676. lebedev.ri marked 6 inline comments as done. lebedev.ri added a comment. Rebased, addressed all(?) nits. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59463/new/ https://reviews.llvm.org/D59463 Files: docs/LibAS

[PATCH] D57112: [ASTTypeTraits][ASTMatchers][OpenMP] OMPClause handling

2019-03-21 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added inline comments. Comment at: include/clang/ASTMatchers/ASTMatchers.h:6456 + // Note that we have recieved a *matcher* for the clause, not the + // OpenMPClauseKind. We now need to extract the 'return' type of said matcher, + // and convert it to the OpenMPCla

[PATCH] D57112: [ASTTypeTraits][ASTMatchers][OpenMP] OMPClause handling

2019-03-21 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri updated this revision to Diff 191678. lebedev.ri marked 18 inline comments as done. lebedev.ri added a comment. Rebased, addressed all(?) nits. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57112/new/ https://reviews.llvm.org/D57112 Files: docs/LibA

[PATCH] D59640: [clangd] Add TemplateArgumentList into Symbol

2019-03-21 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet created this revision. kadircet added reviewers: ioeric, ilya-biryukov, gribozavr. Herald added subscribers: cfe-commits, jdoerfert, arphaman, jkorous, MaskRay. Herald added a project: clang. Part of re-landing rC356541 with D59599

[PATCH] D59641: [clangd] Show template argument list in workspacesymbols and documentsymbols responses

2019-03-21 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet created this revision. kadircet added reviewers: ioeric, ilya-biryukov. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay. Herald added a project: clang. kadircet added a parent revision: D59640: [clangd] Add TemplateArgumentList into Symbol. kadircet added a subscriber: n

Re: r356222 - [analyzer] Support C++17 aggregates with bases without constructors.

2019-03-21 Thread Alexander Kornienko via cfe-commits
Thanks for the fix! Meanwhile, I found a couple of code samples that trigger this assertion with a slightly different stack trace. Not sure if they are substantially different though. #1: $ cat t.cc inline namespace a { class b typedef c; } class A {}; namespace a { class b : A {}; } // namespace

[PATCH] D57112: [ASTTypeTraits][ASTMatchers][OpenMP] OMPClause handling

2019-03-21 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added a comment. @gribozavr thank you for the review! @aaron.ballman any further comments? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57112/new/ https://reviews.llvm.org/D57112 ___ cfe-commits mailing l

[PATCH] D59453: [ASTMatchers][OpenMP] Add base ompExecutableDirective() matcher.

2019-03-21 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added a comment. @aaron.ballman @gribozavr thank you for the review! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59453/new/ https://reviews.llvm.org/D59453 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D59463: [ASTMatchers][OpenMP] OpenMP Structured-block-related matchers

2019-03-21 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added a comment. @gribozavr thank you for the review! @aaron.ballman any comments? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59463/new/ https://reviews.llvm.org/D59463 ___ cfe-commits mailing list cfe-

[PATCH] D59605: [clangd] Introduce background-indexer

2019-03-21 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet updated this revision to Diff 191684. kadircet marked 11 inline comments as done. kadircet added a comment. Herald added a subscriber: jfb. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59605/new/ https://reviews.llvm.or

[PATCH] D57112: [ASTTypeTraits][ASTMatchers][OpenMP] OMPClause handling

2019-03-21 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: include/clang/ASTMatchers/ASTMatchers.h:6456 + // Note that we have recieved a *matcher* for the clause, not the + // OpenMPClauseKind. We now need to extract the 'return' type of said matcher, + // and convert it to the OpenMP

[PATCH] D59605: [clangd] Introduce background-indexer

2019-03-21 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet added inline comments. Comment at: clang-tools-extra/clangd/background-indexer/BackgroundIndexer.cpp:13 + +#include "/usr/local/google/home/kadircet/repos/llvm/clang-tools-extra/clangd/Context.h" +#include "/usr/local/google/home/kadircet/repos/llvm/clang-tools-extra/c

[PATCH] D59567: [X86] Add __popcntd and __popcntq to ia32intrin.h to match gcc and icc. Remove popcnt feature flag from _popcnt32/_popcnt64 and move to ia32intrin.h to match gcc

2019-03-21 Thread Simon Pilgrim via Phabricator via cfe-commits
RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM with some minor typos Comment at: lib/Headers/ia32intrin.h:36 + * This intrinsic corresponds to the POPCNT instruction or a + * a sequence of arithmetic and logic

[PATCH] D57112: [ASTTypeTraits][ASTMatchers][OpenMP] OMPClause handling

2019-03-21 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri updated this revision to Diff 191685. lebedev.ri marked an inline comment as done. lebedev.ri added a comment. Address @aaron.ballman comment nit. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57112/new/ https://reviews.llvm.org/D57112 Files: docs/L

[PATCH] D57112: [ASTTypeTraits][ASTMatchers][OpenMP] OMPClause handling

2019-03-21 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM aside from a small docs nit (be sure to regenerate the docs after you fix it). Comment at: include/clang/ASTMatchers/ASTMatchers.h:6402 +/// +/// ``ompExecutableDirective(hasClause(anything()))`` matches

[PATCH] D59463: [ASTMatchers][OpenMP] OpenMP Structured-block-related matchers

2019-03-21 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM aside from a NFC change Comment at: include/clang/ASTMatchers/ASTMatchers.h:6444-6445 + internal::Matcher, InnerMatcher) { + if (isStandaloneDirective().matches(Node, Finder, Builder)) +

[PATCH] D57112: [ASTTypeTraits][ASTMatchers][OpenMP] OMPClause handling

2019-03-21 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri updated this revision to Diff 191697. lebedev.ri marked 2 inline comments as done. lebedev.ri added a comment. Comment nit. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57112/new/ https://reviews.llvm.org/D57112 Files: docs/LibASTMatchersReference.

[PATCH] D57112: [ASTTypeTraits][ASTMatchers][OpenMP] OMPClause handling

2019-03-21 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added inline comments. Comment at: include/clang/ASTMatchers/ASTMatchers.h:6402 +/// +/// ``ompExecutableDirective(hasClause(anything()))`` matches +/// ``omp parallel default(none)``. aaron.ballman wrote: > hasAnyClause() whoops, thanks. Repository:

[PATCH] D57112: [ASTTypeTraits][ASTMatchers][OpenMP] OMPClause handling

2019-03-21 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added a comment. In D57112#1437954 , @aaron.ballman wrote: > LGTM Great, thank you for the review! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57112/new/ https://reviews.llvm.org/D57112

[PATCH] D59463: [ASTMatchers][OpenMP] OpenMP Structured-block-related matchers

2019-03-21 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added inline comments. Comment at: include/clang/ASTMatchers/ASTMatchers.h:6444-6445 + internal::Matcher, InnerMatcher) { + if (isStandaloneDirective().matches(Node, Finder, Builder)) +return false; // Standalone directives have no structured blocks.

[PATCH] D59463: [ASTMatchers][OpenMP] OpenMP Structured-block-related matchers

2019-03-21 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri updated this revision to Diff 191701. lebedev.ri marked 2 inline comments as done. lebedev.ri added a comment. Last nit. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59463/new/ https://reviews.llvm.org/D59463 Files: docs/LibASTMatchersReference.htm

[PATCH] D59646: [PR40778][PR41157][OpenCL] Prevent implicit initialization of local address space objects

2019-03-21 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia created this revision. Anastasia added reviewers: rjmccall, bader. Herald added a subscriber: ebevhan. Anastasia retitled this revision from "[PR40778][PR41157] Prevent implicit initialization of local address space objects" to "[PR40778][PR41157][OpenCL] Prevent implicit initialization

[PATCH] D59528: [clang-tidy] Expand modular headers for PPCallbacks

2019-03-21 Thread Alexander Kornienko via Phabricator via cfe-commits
alexfh added inline comments. Comment at: clang-tools-extra/clang-tidy/ExpandModularHeadersPPCallbacks.cpp:24 + void recordContent(const FileEntry *File, + const SrcMgr::ContentCache *ContentCache, + llvm::vfs::InMemoryFileSystem &InMemory

[PATCH] D59528: [clang-tidy] Expand modular headers for PPCallbacks

2019-03-21 Thread Alexander Kornienko via Phabricator via cfe-commits
alexfh updated this revision to Diff 191703. alexfh marked 15 inline comments as done. alexfh added a comment. - Addressed review comments. Parse code to the end (seems right to do this, but no specific test that would fail otherwise). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D59528: [clang-tidy] Expand modular headers for PPCallbacks

2019-03-21 Thread Alexander Kornienko via Phabricator via cfe-commits
alexfh added a comment. Thank you for the review! I hope I covered all the points. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59528/new/ https://reviews.llvm.org/D59528 ___ cfe-commits mailing list

r356674 - [ASTMatchers][OpenMP] Add base ompExecutableDirective() matcher.

2019-03-21 Thread Roman Lebedev via cfe-commits
Author: lebedevri Date: Thu Mar 21 08:33:10 2019 New Revision: 356674 URL: http://llvm.org/viewvc/llvm-project?rev=356674&view=rev Log: [ASTMatchers][OpenMP] Add base ompExecutableDirective() matcher. Summary: A simple matcher for `OMPExecutableDirective` Stmt type. Split off from D57113. Review

r356675 - [ASTTypeTraits][ASTMatchers][OpenMP] OMPClause handling

2019-03-21 Thread Roman Lebedev via cfe-commits
Author: lebedevri Date: Thu Mar 21 08:33:24 2019 New Revision: 356675 URL: http://llvm.org/viewvc/llvm-project?rev=356675&view=rev Log: [ASTTypeTraits][ASTMatchers][OpenMP] OMPClause handling Summary: `OMPClause` is the base class, it is not descendant from **any** other class, therefore for it t

r356676 - [ASTMatchers][OpenMP] OpenMP Structured-block-related matchers

2019-03-21 Thread Roman Lebedev via cfe-commits
Author: lebedevri Date: Thu Mar 21 08:33:35 2019 New Revision: 356676 URL: http://llvm.org/viewvc/llvm-project?rev=356676&view=rev Log: [ASTMatchers][OpenMP] OpenMP Structured-block-related matchers Summary: Exposes to the for ASTMatchers the interface/modelling of OpenMP structured-block. Revi

r356677 - [ASTMatcher] Add clang-query disclaimer to two more matchers that take enum

2019-03-21 Thread Roman Lebedev via cfe-commits
Author: lebedevri Date: Thu Mar 21 08:33:43 2019 New Revision: 356677 URL: http://llvm.org/viewvc/llvm-project?rev=356677&view=rev Log: [ASTMatcher] Add clang-query disclaimer to two more matchers that take enum As we have figured out in https://reviews.llvm.org/D57112 and https://bugs.llvm.org/s

[PATCH] D59453: [ASTMatchers][OpenMP] Add base ompExecutableDirective() matcher.

2019-03-21 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL356674: [ASTMatchers][OpenMP] Add base ompExecutableDirective() matcher. (authored by lebedevri, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to com

[PATCH] D57112: [ASTTypeTraits][ASTMatchers][OpenMP] OMPClause handling

2019-03-21 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL356675: [ASTTypeTraits][ASTMatchers][OpenMP] OMPClause handling (authored by lebedevri, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: ht

[PATCH] D59463: [ASTMatchers][OpenMP] OpenMP Structured-block-related matchers

2019-03-21 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL356676: [ASTMatchers][OpenMP] OpenMP Structured-block-related matchers (authored by lebedevri, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commi

[PATCH] D59639: [clangd] Print template arguments helper

2019-03-21 Thread Eugene Zelenko via Phabricator via cfe-commits
Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clangd/AST.cpp:26 +llvm::Optional> +getTemplateSpecializationArgLocs(const NamedDecl &ND) { + if (auto *Func = llvm::dyn_cast(&ND)) { Functions should be static, not in anonymous namespace. See

[PATCH] D59647: [CUDA][HIP] Warn shared var initialization

2019-03-21 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl created this revision. yaxunl added a reviewer: tra. Herald added a project: clang. In many cases the default constructor of a class contains initializer of data members, which allows concise code. The class may be instantiated as global or automatic variables in device code, which is total

r356679 - [AST] OMPStructuredBlockTest: two matchers were promoted into ASTMatchers.h

2019-03-21 Thread Roman Lebedev via cfe-commits
Author: lebedevri Date: Thu Mar 21 08:50:54 2019 New Revision: 356679 URL: http://llvm.org/viewvc/llvm-project?rev=356679&view=rev Log: [AST] OMPStructuredBlockTest: two matchers were promoted into ASTMatchers.h Modified: cfe/trunk/unittests/AST/OMPStructuredBlockTest.cpp Modified: cfe/trunk

[PATCH] D59440: add steps to preprocess file and reduce command line args

2019-03-21 Thread Amy Huang via Phabricator via cfe-commits
akhuang added a comment. @arichardson Will add you next time, sorry I didn't do so on this one! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59440/new/ https://reviews.llvm.org/D59440 ___ cfe-commits mailing list cf

[PATCH] D59650: [NFC] ExceptionEscapeCheck: small refactoring

2019-03-21 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri created this revision. lebedev.ri added reviewers: baloghadamsoftware, JonasToth, gribozavr. lebedev.ri added a project: clang-tools-extra. Herald added a subscriber: rnkovacs. Herald added a project: clang. D59466 wants to analyse the `Stmt`, and `Exc

[PATCH] D57571: [clang-tidy] A new OpenMP module

2019-03-21 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri updated this revision to Diff 191724. lebedev.ri added a comment. Rebased, NFC. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57571/new/ https://reviews.llvm.org/D57571 Files: clang-tidy/CMakeLists.txt clang-tidy/ClangTidyForceLinker

[PATCH] D59466: [clang-tidy] openmp-exception-escape - a new check

2019-03-21 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri updated this revision to Diff 191727. lebedev.ri added a reviewer: gribozavr. lebedev.ri added a comment. Rebased, NFC. Split base ExceptionEscapeCheck refactoring into D59650 . Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https:/

[PATCH] D57113: [clang-tidy] openmp-use-default-none - a new check

2019-03-21 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri updated this revision to Diff 191726. lebedev.ri marked 4 inline comments as done. lebedev.ri edited the summary of this revision. lebedev.ri added a reviewer: gribozavr. lebedev.ri added a comment. Rebased, NFC. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https:

[PATCH] D59627: [clang-format] Keep protobuf "package" statement on one line

2019-03-21 Thread Donald Chai via Phabricator via cfe-commits
dchai updated this revision to Diff 191734. dchai added a comment. Use "isOneOf" instead of two calls to "is". Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59627/new/ https://reviews.llvm.org/D59627 Files: lib/Format/TokenAnnotator.cpp unittests/Format/Form

[PATCH] D58236: Make address space conversions a bit stricter.

2019-03-21 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia added a comment. In D58236#1437690 , @ebevhan wrote: > Any more input on this? > > I could redo the patch to simply fix the bug and not make the conversions > stricter, if that's preferable. I was playing a bit with some examples of enum with

r356686 - [X86] Use the CPUKind enum from PROC_ALIAS to directly get the CPUKind in fillValidCPUList.

2019-03-21 Thread Craig Topper via cfe-commits
Author: ctopper Date: Thu Mar 21 10:33:20 2019 New Revision: 356686 URL: http://llvm.org/viewvc/llvm-project?rev=356686&view=rev Log: [X86] Use the CPUKind enum from PROC_ALIAS to directly get the CPUKind in fillValidCPUList. We were using getCPUKind which translates the string to the enum also

[PATCH] D57464: Generalize method overloading on addr spaces to C++

2019-03-21 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia added a comment. > I think I would lean towards the latter since it means less fudging around > with a whole bunch of unrelated methods. Do @rjmccall or @rsmith have any > further opinions on this? Ok, I can change the patch to prototype this approach. I might need some example tes

[PATCH] D59639: [clangd] Print template arguments helper

2019-03-21 Thread Eric Liu via Phabricator via cfe-commits
ioeric added inline comments. Comment at: clang-tools-extra/clangd/AST.cpp:88 static const TemplateArgumentList * getTemplateSpecializationArgs(const NamedDecl &ND) { if (auto *Func = llvm::dyn_cast(&ND)) can we unify this with `getTemplateSpecializationArgL

[PATCH] D59640: [clangd] Add TemplateArgumentList into Symbol

2019-03-21 Thread Eric Liu via Phabricator via cfe-commits
ioeric added a comment. should we update YAML? Comment at: clang-tools-extra/clangd/index/Symbol.h:48 + /// non-specializations. Example: "" + llvm::StringRef TemplateArgumentList; /// The location of the symbol's definition, if one was found. How about `

r356689 - [X86] Add __popcntd and __popcntq to ia32intrin.h to match gcc and icc. Remove popcnt feature flag from _popcnt32/_popcnt64 and move to ia32intrin.h to match gcc

2019-03-21 Thread Craig Topper via cfe-commits
Author: ctopper Date: Thu Mar 21 10:43:53 2019 New Revision: 356689 URL: http://llvm.org/viewvc/llvm-project?rev=356689&view=rev Log: [X86] Add __popcntd and __popcntq to ia32intrin.h to match gcc and icc. Remove popcnt feature flag from _popcnt32/_popcnt64 and move to ia32intrin.h to match gcc

[PATCH] D59567: [X86] Add __popcntd and __popcntq to ia32intrin.h to match gcc and icc. Remove popcnt feature flag from _popcnt32/_popcnt64 and move to ia32intrin.h to match gcc

2019-03-21 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC356689: [X86] Add __popcntd and __popcntq to ia32intrin.h to match gcc and icc. Remove… (authored by ctopper, committed by ). Herald added a project: clang. Changed prior to commit: https://reviews.llvm

[PATCH] D59639: [clangd] Print template arguments helper

2019-03-21 Thread Eric Liu via Phabricator via cfe-commits
ioeric added inline comments. Comment at: clang/lib/AST/TypePrinter.cpp:1640 + +static void printArgument(const TemplateArgumentLoc &A, + const PrintingPolicy &PP, llvm::raw_ostream &OS) { It's unclear to me what the new behavior is with

[PATCH] D59655: [AArch64] Split the neon.addp intrinsic into integer and fp variants

2019-03-21 Thread Amara Emerson via Phabricator via cfe-commits
aemerson created this revision. aemerson added reviewers: paquette, eli.friedman, t.p.northover. aemerson added projects: LLVM, clang. Herald added subscribers: Petar.Avramovic, hiraditya, kristof.beyls, javed.absar. This is the result of discussions on the list about how to deal with intrinsics

[PATCH] D59624: [Driver] Pass -malign-double from the driver to the cc1 command line

2019-03-21 Thread Reid Kleckner via Phabricator via cfe-commits
rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59624/new/ https://reviews.llvm.org/D59624 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D59655: [AArch64] Split the neon.addp intrinsic into integer and fp variants

2019-03-21 Thread Amara Emerson via Phabricator via cfe-commits
aemerson updated this revision to Diff 191745. aemerson added a comment. Minor test tweak. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59655/new/ https://reviews.llvm.org/D59655 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/test/CodeGen/aarch

[PATCH] D59603: [PR40707][PR41011][OpenCL] Allow addr space spelling without double underscore in C++ mode

2019-03-21 Thread John McCall via Phabricator via cfe-commits
rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59603/new/ https://reviews.llvm.org/D59603 ___ cfe-commits mailing list cfe-comm

[PATCH] D59656: [CodeGen][ObjC] Annotate calls to objc_retainAutoreleasedReturnValue with notail on x86-64

2019-03-21 Thread Akira Hatanaka via Phabricator via cfe-commits
ahatanak created this revision. ahatanak added reviewers: rjmccall, erik.pilkington. ahatanak added a project: clang. Herald added subscribers: dexonsmith, jkorous. On x86-64, the epilogue code inserted before the tail jump blocks the autoreleased return optimization. ARC optimizer unconditional

[PATCH] D59656: [CodeGen][ObjC] Annotate calls to objc_retainAutoreleasedReturnValue with notail on x86-64

2019-03-21 Thread Akira Hatanaka via Phabricator via cfe-commits
ahatanak added a comment. There are existing test cases that test notail isn't added to calls on targets that aren't x86-64 (for example, test/CodeGenObjC/arc-arm.m), so I didn't write a new one. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59656/new/ https://

[PATCH] D59647: [CUDA][HIP] Warn shared var initialization

2019-03-21 Thread Artem Belevich via Phabricator via cfe-commits
tra added a comment. This looks like one of the things we should *not* do as it affects correctness -- non-trivial constructor may be arbitrarily complex and the per-TU flag to enable this behavior is way too coarse, IMO. On the other hand, I can believe that someone somewhere did write the code

[PATCH] D59647: [CUDA][HIP] Warn shared var initialization

2019-03-21 Thread Justin Lebar via Phabricator via cfe-commits
jlebar requested changes to this revision. jlebar added a comment. This revision now requires changes to proceed. I agree with Art. The fact that nvcc allows this is broken. If you want a flag that makes this error a warning, that might work for me. The flag should probably say "unsafe" or "I

[PATCH] D59647: [CUDA][HIP] Warn shared var initialization

2019-03-21 Thread Justin Lebar via Phabricator via cfe-commits
jlebar added a comment. > By default it is still treated as error, therefore no behavior change of > clang. Oh, I see, you already did what I'd suggested. :) That's better. I think this needs to be made *much scarier* though. "Maybe race condition" doesn't capture the danger here -- you can

[PATCH] D59655: [AArch64] Split the neon.addp intrinsic into integer and fp variants

2019-03-21 Thread Amara Emerson via Phabricator via cfe-commits
aemerson added a comment. I've put up a langref change as a separate review: D59657 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59655/new/ https://reviews.llvm.org/D59655 _

[PATCH] D59656: [CodeGen][ObjC] Annotate calls to objc_retainAutoreleasedReturnValue with notail on x86-64

2019-03-21 Thread John McCall via Phabricator via cfe-commits
rjmccall added inline comments. Comment at: lib/CodeGen/TargetInfo.h:161 + /// marked as 'notail'. + virtual bool noTailCallARCRetainRV() const { +return false; `shouldSuppressTailCallsOfRetainAutoreleasedReturnValue()`? Repository: rC Clang CHANGES SI

r356699 - [OPENMP]Simplify the check for the predefined allocators, NFC.

2019-03-21 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Thu Mar 21 12:05:07 2019 New Revision: 356699 URL: http://llvm.org/viewvc/llvm-project?rev=356699&view=rev Log: [OPENMP]Simplify the check for the predefined allocators, NFC. Previously implemented check required the reevaluation of the already evaluated predefined allocator

r356700 - [clang][OpenMP] Fix another test when using libgomp.

2019-03-21 Thread Jordan Rupprecht via cfe-commits
Author: rupprecht Date: Thu Mar 21 12:13:22 2019 New Revision: 356700 URL: http://llvm.org/viewvc/llvm-project?rev=356700&view=rev Log: [clang][OpenMP] Fix another test when using libgomp. Similarly to r356614, -fopenmp=libomp needs to be used for some omp-related AST matching. Modified: cf

[PATCH] D59656: [CodeGen][ObjC] Annotate calls to objc_retainAutoreleasedReturnValue with notail on x86-64

2019-03-21 Thread Akira Hatanaka via Phabricator via cfe-commits
ahatanak updated this revision to Diff 191761. ahatanak marked an inline comment as done. ahatanak added a comment. Rename function. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59656/new/ https://reviews.llvm.org/D59656 Files: lib/CodeGen/CGObjC.cpp lib/Co

[PATCH] D59655: [AArch64] Split the neon.addp intrinsic into integer and fp variants

2019-03-21 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added inline comments. Comment at: llvm/lib/IR/AutoUpgrade.cpp:574 + if (ArgTy->getElementType()->isFloatingPointTy()) { +auto fArgs = F->getFunctionType()->params(); +Type *Tys[] = {fArgs[0], fArgs[1]}; This code is weird... you're

Re: r356700 - [clang][OpenMP] Fix another test when using libgomp.

2019-03-21 Thread Roman Lebedev via cfe-commits
Thank you for the fix. I remembered of the yesterday's fix, but either forgot about it here, or incorrectly recalled this code would be relying on the yesterday's code (as in, no fix would be needed.) Roman. On Thu, Mar 21, 2019 at 10:11 PM Jordan Rupprecht via cfe-commits wrote: > > Author: ru

[PATCH] D59566: [X86] Correct the value of MaxAtomicInlineWidth for pre-586 cpus

2019-03-21 Thread Eli Friedman via Phabricator via cfe-commits
efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM > This is needed to get the LLONG_LOCK_FREE macro to be 2 on i586 and greater. Not sure these tests are really valuable, given we plan to change that immediately after this is merged

r356702 - [OPENMP]Codegen support for allocate directive on global variables.

2019-03-21 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Thu Mar 21 12:35:27 2019 New Revision: 356702 URL: http://llvm.org/viewvc/llvm-project?rev=356702&view=rev Log: [OPENMP]Codegen support for allocate directive on global variables. For the global variables the allocate directive must specify only the predefined allocator. Thi

[PATCH] D59656: [CodeGen][ObjC] Annotate calls to objc_retainAutoreleasedReturnValue with notail on x86-64

2019-03-21 Thread John McCall via Phabricator via cfe-commits
rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59656/new/ https://reviews.llvm.org/D59656 ___ cfe-commi

r356704 - Refactor handling of #include directives to cleanly separate the

2019-03-21 Thread Richard Smith via cfe-commits
Author: rsmith Date: Thu Mar 21 12:44:17 2019 New Revision: 356704 URL: http://llvm.org/viewvc/llvm-project?rev=356704&view=rev Log: Refactor handling of #include directives to cleanly separate the "skipped header because it should be imported as a module" cases from the "skipped header because of

  1   2   >