Re: [PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

Note that kernel developers are requesting output support with ASM goto. Doesn't need to be in V1 of ASM go-to support, but we should expect it to be implemented in the future. We should help users with diagnostics that this is not supported, and add asserts that will help us implement such a featu

[PATCH] D57464: Generalize method overloading on addr spaces to C++

ebevhan added inline comments. Comment at: lib/Parse/ParseDeclCXX.cpp:2313 +} + } Anastasia wrote: > ebevhan wrote: > > Anastasia wrote: > > > ebevhan wrote: > > > > Anastasia wrote: > > > > > Anastasia wrote: > > > > > > ebevhan wrote: > > > > > > > Is th

[PATCH] D57581: Explicitly add language standard option to test cases that rely on the C++14 default

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57581/new/ https://reviews.llvm.org/D57581 ___

r353150 - Fix the sphinx buildbot after D54429

Author: szelethus Date: Tue Feb 5 02:19:39 2019 New Revision: 353150 URL: http://llvm.org/viewvc/llvm-project?rev=353150&view=rev Log: Fix the sphinx buildbot after D54429 Modified: cfe/trunk/docs/analyzer/checkers.rst Modified: cfe/trunk/docs/analyzer/checkers.rst URL: http://llvm.org/vie

[PATCH] D54429: [analyzer] Creating standard Sphinx documentation

Szelethus added inline comments. Comment at: docs/analyzer/checkers.rst:1946 +Checkers used for debugging the analyzer. +:doc:`DebugChecks` page contains a detailed description. + NoQ wrote: > The error is on this line. It might be that this link should mention t

[PATCH] D57732: Correct inf typo

krasimir accepted this revision. krasimir added a comment. This revision is now accepted and ready to land. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57732/new/ https://reviews.llvm.org/D57732 _

[PATCH] D57739: [clangd] Format tweak's replacements.

hokein created this revision. hokein added a reviewer: ilya-biryukov. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ioeric. Herald added a project: clang. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D57739 Files: clangd/ClangdLSPServer.cpp clangd/ClangdSer

[PATCH] D57739: [clangd] Format tweak's replacements.

hokein marked an inline comment as done. hokein added inline comments. Comment at: clangd/ClangdServer.cpp:366 + auto Style = getFormatStyle(Code, File); + if (!Style) +return; not sure the err-handling strategy here -- maybe if this is failed, we still ap

[PATCH] D57739: [clangd] Format tweak's replacements.

ioeric added inline comments. Comment at: clangd/ClangdServer.cpp:366 + auto Style = getFormatStyle(Code, File); + if (!Style) +return; hokein wrote: > not sure the err-handling strategy here -- maybe if this is failed, we still > apply replacements (witho

[PATCH] D57740: [ASTImporter] Import every Decl in lambda record

gamesh411 created this revision. gamesh411 added reviewers: a.sidorin, shafik. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously only the fields were imported. Now every Decl is imported. This way the destructor decl is not missing after import. Patch by balazske (

[PATCH] D57739: [clangd] Format tweak's replacements.

ilya-biryukov added a comment. Could we move the code to the `Tweak` itself, so that all the callers would get the formatting? I.e. class Tweak { Replacements apply() { // This is now non-virtual. auto Replacements = doApply(); return cleanupAndFormat(Replacements); }

[PATCH] D57739: [clangd] Format tweak's replacements.

ilya-biryukov added inline comments. Comment at: clangd/ClangdServer.cpp:366 + auto Style = getFormatStyle(Code, File); + if (!Style) +return; ioeric wrote: > hokein wrote: > > not sure the err-handling strategy here -- maybe if this is failed, we > > stil

r353160 - Fix ICE on reference binding with mismatching addr spaces.

Author: stulova Date: Tue Feb 5 03:32:58 2019 New Revision: 353160 URL: http://llvm.org/viewvc/llvm-project?rev=353160&view=rev Log: Fix ICE on reference binding with mismatching addr spaces. When we attempt to add an addr space qual to a type already qualified by an addr space ICE is triggered.

[PATCH] D57524: Fix ICE on attempt to add an addr space qual to a type qualified by an addr space

This revision was automatically updated to reflect the committed changes. Closed by commit rC353160: Fix ICE on reference binding with mismatching addr spaces. (authored by stulova, committed by ). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D57524?vs=185024

[PATCH] D56003: [RFC] [CFE] Allocatable Global Register Variables for ARM

carwil updated this revision to Diff 185277. carwil added a comment. Removed the complicated frame pointer/ffixed combination errors in favour of an always on warning (in a new group, so it can be silenced). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56003/new/ https://reviews.llvm.

r353163 - [NFC] Explicitly add -std=c++14 option to tests that rely on the C++14 default

Author: nemanjai Date: Tue Feb 5 04:05:53 2019 New Revision: 353163 URL: http://llvm.org/viewvc/llvm-project?rev=353163&view=rev Log: [NFC] Explicitly add -std=c++14 option to tests that rely on the C++14 default When Clang/LLVM is built with the CLANG_DEFAULT_STD_CXX CMake macro that sets the d

[PATCH] D57464: Generalize method overloading on addr spaces to C++

Anastasia marked an inline comment as done. Anastasia added inline comments. Comment at: lib/Parse/ParseDeclCXX.cpp:2313 +} + } ebevhan wrote: > Anastasia wrote: > > ebevhan wrote: > > > Anastasia wrote: > > > > ebevhan wrote: > > > > > Anastasia wrote: >

[PATCH] D57581: Explicitly add language standard option to test cases that rely on the C++14 default

This revision was automatically updated to reflect the committed changes. Closed by commit rL353163: [NFC] Explicitly add -std=c++14 option to tests that rely on the C++14 default (authored by nemanjai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[PATCH] D57746: [clangd] Add CLI flag "-clang-tidy" to enable/disable running clang-tidy checks.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov. Herald added a project: clang. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D57746 Files: clangd/tool/ClangdMain.cpp Inde

[PATCH] D57055: [RISCV] Mark TLS as supported

lewis-revill updated this revision to Diff 185283. lewis-revill added a comment. Herald added a project: clang. Added RISC-V to thread specifier test as a means of checking TLS is supported. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57055/new/ https://reviews

r353116 - [OBJC] Add attribute to mark Objective C class as non-lazy

Author: joseph_daniels Date: Mon Feb 4 15:32:55 2019 New Revision: 353116 URL: http://llvm.org/viewvc/llvm-project?rev=353116&view=rev Log: [OBJC] Add attribute to mark Objective C class as non-lazy A non-lazy class will be initialized eagerly when the Objective-C runtime is loaded. This is requ

[PATCH] D57747: [Sema] SequenceChecker: Fix handling of operator ||, && and ?:

riccibruno created this revision. riccibruno added reviewers: aaron.ballman, rsmith. riccibruno added a project: clang. Herald added a subscriber: cfe-commits. The current handling of the operators `||`, `&&` and `?:` has a number of false positive and false negative. The issues for operator `||`

[PATCH] D57464: Generalize method overloading on addr spaces to C++

ebevhan added inline comments. Comment at: lib/Parse/ParseDeclCXX.cpp:2313 +} + } Anastasia wrote: > ebevhan wrote: > > Anastasia wrote: > > > ebevhan wrote: > > > > Anastasia wrote: > > > > > ebevhan wrote: > > > > > > Anastasia wrote: > > > > > > > Anast

[PATCH] D54604: Automatic variable initialization

glider added a comment. Herald added a project: LLVM. I think doing separate stores of 0xAA into struct members instead of copying part of .rodata over it will let us do a much better job in optimizing away redundant stores. I've opened https://bugs.llvm.org/show_bug.cgi?id=40605 to track that.

[PATCH] D57740: [ASTImporter] Import every Decl in lambda record

balazske added inline comments. Comment at: unittests/AST/ASTImporterTest.cpp:2432 + EXPECT_TRUE(ToD); + Decl *ToTU = ToAST->getASTContext().getTranslationUnitDecl(); + CXXRecordDecl *LambdaRec = Actually the `ToTU` is not needed, this line can be removed. R

[PATCH] D56850: [ASTMatchers][NFC] Add tests for assorted `CXXMemberCallExpr` matchers.

ymandel added a comment. Aaron, Alex, any additional comments on this change? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56850/new/ https://reviews.llvm.org/D56850 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D57739: [clangd] Format tweak's replacements.

hokein updated this revision to Diff 185306. hokein marked 9 inline comments as done. hokein added a comment. Adress review comments. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57739/new/ https://reviews.llvm.org/D57739 Files: clangd/ClangdSer

[PATCH] D57739: [clangd] Format tweak's replacements.

hokein added a comment. In D57739#1384844 , @ilya-biryukov wrote: > Could we move the code to the `Tweak` itself, so that all the callers would > get the formatting? I.e. > > class Tweak { > Replacements apply() { // This is now non-virtual. >

[PATCH] D56849: [ASTMatchers][NFC] Update comments on assorted `CXXMemberCallExpr` matchers.

ymandel updated this revision to Diff 185309. ymandel added a comment. Herald added a project: clang. Sync'd with master. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56849/new/ https://reviews.llvm.org/D56849 Files: clang/docs/LibASTMatchersRe

[PATCH] D56849: [ASTMatchers][NFC] Update comments on assorted `CXXMemberCallExpr` matchers.

ymandel added a comment. Alex, can you please submit this? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56849/new/ https://reviews.llvm.org/D56849 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D57755: [clangd] Some minor fixes.

hokein created this revision. hokein added a reviewer: ilya-biryukov. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ioeric. Herald added a project: clang. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D57755 Files: clangd/Selection.cpp clangd/refactor/Tweak.

[PATCH] D57086: Ignore trailing NullStmts in StmtExprs for GCC compatibility

aaron.ballman added inline comments. Comment at: clang/include/clang/AST/Stmt.h:1259-1260 + // This gets the index of the last Stmt before the trailing NullStmts. If + // this compound expression contains nothing but NullStmts, then we return + // the index of the last one. If

r353181 - [opaque pointer types] Fix the CallInfo passed to EmitCall in some

Author: jyknight Date: Tue Feb 5 08:05:50 2019 New Revision: 353181 URL: http://llvm.org/viewvc/llvm-project?rev=353181&view=rev Log: [opaque pointer types] Fix the CallInfo passed to EmitCall in some edge cases. Currently, EmitCall emits a call instruction with a function type derived from the

[PATCH] D57664: [opaque pointer types] Fix the CallInfo passed to EmitCall in some edge cases.

This revision was automatically updated to reflect the committed changes. Closed by commit rC353181: [opaque pointer types] Fix the CallInfo passed to EmitCall in some (authored by jyknight, committed by ). Changed prior to commit: https://reviews.llvm.org/D57664?vs=184975&id=185313#toc Reposi

[PATCH] D57086: Ignore trailing NullStmts in StmtExprs for GCC compatibility

riccibruno added inline comments. Comment at: clang/include/clang/AST/Stmt.h:1260 + // this compound expression contains nothing but NullStmts, then we return + // the index of the last one. If the compound statement is empty, return + // None. Additionally I

r353186 - [OPENMP] issue error messages for multiple teams contructs in a target construct

Author: kli Date: Tue Feb 5 08:43:00 2019 New Revision: 353186 URL: http://llvm.org/viewvc/llvm-project?rev=353186&view=rev Log: [OPENMP] issue error messages for multiple teams contructs in a target construct The fix is to issue error messages if there are more than one teams construct inside

[PATCH] D57690: [OPENMP] issue error messages for multiple teams contructs in a target constructs

kkwli0 closed this revision. kkwli0 added a comment. Committed: r353186 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57690/new/ https://reviews.llvm.org/D57690 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D57747: [Sema] SequenceChecker: Fix handling of operator ||, && and ?:

riccibruno added a comment. Looking at git blame, this change means that we will warn on `(b && x++) + (!b && x++)`. However we will also warn on an expression like `(x > some_constant && y++) + (x < some_constant && y++)`. This seems to be the job of a static analyser which is able to do some

[PATCH] D57755: [clangd] Some minor fixes.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM. Many thanks! Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57755/new/ https://reviews.llvm.org/D57755

[PATCH] D57747: [Sema] SequenceChecker: Fix handling of operator ||, && and ?:

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. The "false negatives" in the current behaviour are the result of an intentional decision to avoid false positives for unsequenced operations that cannot actually both happen as part of the sam

[PATCH] D57739: [clangd] Format tweak's replacements.

ilya-biryukov added a comment. In D57739#1385144 , @hokein wrote: > This seems introduce intrusive changes to the Tweak interface (Tweak will > need to know the `FormatStyle` somehow), I think this might be done in > another patch. It's totally fine, s

[PATCH] D57764: [AArch64] Add Cortex-A76 and Cortex-A76AE Support

LukeCheeseman created this revision. LukeCheeseman added a reviewer: olista01. Herald added subscribers: cfe-commits, kristof.beyls, javed.absar. Herald added a project: clang. - Add clang frontend testing for cortex-a76 and cortex-a76ae Repository: rC Clang https://reviews.llvm.org/D57764 F

[PATCH] D57765: [ARM] Add Cortex-M35P Support

LukeCheeseman created this revision. LukeCheeseman added a reviewer: olista01. Herald added subscribers: cfe-commits, kristof.beyls, javed.absar. Herald added a project: clang. - Add clang frontend testing for Cortex-M35P Repository: rC Clang https://reviews.llvm.org/D57765 Files: test/Dri

[PATCH] D57767: [opaque pointer types] Cleanup CGBuilder's Create*GEP.

jyknight created this revision. jyknight added a reviewer: dblaikie. Herald added subscribers: cfe-commits, jfb, jholewinski. Herald added a project: clang. The various EltSize, Offset, DataLayout, and StructLayout arguments are all computable from the Address's element type and the DataLayout whi

[PATCH] D35068: [analyzer] Detect usages of unsafe I/O functions

Szelethus added a comment. Could you rebase please? Many things have changed since you last update. After that I'll happily commit on your behalf if you don't have a commit access just yet. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D35068/new/ https://reviews.llvm.org/D35068 ___

[PATCH] D53157: Teach the IRBuilder about constrained fadd and friends

kpn added a comment. I emailed llvm-dev and cfe-dev on January 16th. The only responses I got back were of the don't care variety. For now it seems the constrained intrinsics will only be used by clang. @rsmith, does the direction of this patch seem reasonable for clang? Once Richard comments

[PATCH] D56924: Handle ObjCCategoryDecl class extensions for print

dgoldman updated this revision to Diff 185341. dgoldman added a comment. Herald added a project: clang. - Output class scope for ObjCPropertyDecl Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56924/new/ https://reviews.llvm.org/D56924 Files: lib/AST/Decl.cpp

[PATCH] D56924: Handle ObjCCategoryDecl class extensions for print

dgoldman added a comment. In D56924#1379342 , @arphaman wrote: > Do you know if this have an effect on the output of completion results or > other tooling-based output? > > A couple of requests: > > - This behavior should be controlled by a printing polic

[PATCH] D57768: [SYCL] Add SYCL device compilation flow.

bader created this revision. bader added reviewers: keryell, Naghasan. Herald added subscribers: cfe-commits, ebevhan. Herald added a project: clang. -fsycl-is-device enables compilation of the device part of SYCL source file. Patch by Mariya Podchishchaeva Repository: rG LLVM Github Monorep

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

craig.topper added a subscriber: jyknight. craig.topper added inline comments. Comment at: lib/CodeGen/CGStmt.cpp:2236 +llvm::CallBrInst *Result = +Builder.CreateCallBr(FTy, IA, Fallthrough, Transfer, Args); +UpdateAsmCallInst(cast(*Result), HasSideEffect, ReadOnl

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

VelocityRa added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D28462/new/ https://reviews.llvm.org/D28462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D56850: [ASTMatchers][NFC] Add tests for assorted `CXXMemberCallExpr` matchers.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56850/new/ https://reviews.llvm.org/D56850 ___ cfe-commits mailing lis

[PATCH] D57771: [CUDA] Add basic support for CUDA-10.1

tra created this revision. tra added a reviewer: jlebar. Herald added subscribers: bixia, sanjoy. https://reviews.llvm.org/D57771 Files: clang/include/clang/Basic/Cuda.h clang/lib/Basic/Cuda.cpp clang/lib/CodeGen/CGCUDANV.cpp clang/lib/Driver/ToolChains/Cuda.cpp clang/lib/Headers/__clan

r353197 - Minor cleanup: remove CGBuild::CreateConst*ByteGEP overloads taking a Value*.

Author: jyknight Date: Tue Feb 5 11:01:33 2019 New Revision: 353197 URL: http://llvm.org/viewvc/llvm-project?rev=353197&view=rev Log: Minor cleanup: remove CGBuild::CreateConst*ByteGEP overloads taking a Value*. Modified: cfe/trunk/lib/CodeGen/CGBuilder.h cfe/trunk/lib/CodeGen/TargetInfo

[PATCH] D57771: [CUDA] Add basic support for CUDA-10.1

tra updated this revision to Diff 185353. tra added a comment. Make the function object local. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57771/new/ https://reviews.llvm.org/D57771 Files: clang/include/clang/Basic/Cuda.h clang/lib/Basic/Cuda.cpp clang/lib/CodeGen/CGCUDANV.cpp

[PATCH] D57768: [SYCL] Add SYCL device compilation flow.

keryell accepted this revision. keryell added a comment. This revision is now accepted and ready to land. That looks good. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57768/new/ https://reviews.llvm.org/D57768 _

[PATCH] D57267: [AST] Factor out the logic of the various Expr::Ignore*

aaron.ballman added inline comments. Comment at: lib/AST/Expr.cpp:2562 +return ICE->getSubExpr(); + + else if (auto *FE = dyn_cast_or_null(E)) riccibruno wrote: > It is something that is actually possible to audit. I did look at where each > of the skipped

r353199 - [opaque pointer types] More trivial changes to pass FunctionType to CallInst.

Author: jyknight Date: Tue Feb 5 11:17:50 2019 New Revision: 353199 URL: http://llvm.org/viewvc/llvm-project?rev=353199&view=rev Log: [opaque pointer types] More trivial changes to pass FunctionType to CallInst. Change various functions to use FunctionCallee or Function*. Pass function type thr

[PATCH] D57674: [clang-tidy] Add options to bugprone-argument-comment to add missing argument comments to literals

aaron.ballman added inline comments. Comment at: clang-tidy/bugprone/ArgumentCommentCheck.cpp:228-236 +static bool isStringLiteral(const Expr *Arg) { + const auto *Cast = dyn_cast(Arg); + return Cast ? isa(Cast->getSubExpr()) : false; +} + +static bool isNullPtrLiteral(const Ex

Re: [PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

What sort of outputs, specifically? Memory outputs are easy; I think the LLVM IR patch actually supports them already. Register outputs are complicated... I guess they're also possible, but we would need to come up with some frontend rule that allows sane code generation. Consider the case wh

Re: r352930 - [WebAssembly] Add an import_field function attribute

On Fri, Feb 1, 2019 at 8:27 PM Dan Gohman wrote: > > > > On Fri, Feb 1, 2019 at 2:31 PM Aaron Ballman wrote: >> >> On Fri, Feb 1, 2019 at 5:25 PM Dan Gohman via cfe-commits >> wrote: >> > >> > Author: djg >> > Date: Fri Feb 1 14:25:23 2019 >> > New Revision: 352930 >> > >> > URL: http://llvm.or

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

jyu2 updated this revision to Diff 185360. jyu2 added a comment. 1>emit better error for use of output constraints. 2> Add assert for NumLabels and NumOutputs are both larger than 0. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56571/new/ https://reviews.llvm.org/D56571 Files: inclu

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

jyu2 marked 2 inline comments as done. jyu2 added inline comments. Comment at: lib/AST/Stmt.cpp:457-460 this->NumOutputs = NumOutputs; this->NumInputs = NumInputs; this->NumClobbers = NumClobbers; + this->NumLabels = NumLabels; rsmith wrote: > jyu2 wrot

r353204 - [DEBUG_INFO][NVPTX] Generate correct data about variable address class.

Author: abataev Date: Tue Feb 5 11:45:57 2019 New Revision: 353204 URL: http://llvm.org/viewvc/llvm-project?rev=353204&view=rev Log: [DEBUG_INFO][NVPTX] Generate correct data about variable address class. Summary: Added ability to generate correct debug info data about the variable address class

[PATCH] D57162: [DEBUG_INFO][NVPTX] Generate correct data about variable address class.

This revision was automatically updated to reflect the committed changes. Closed by commit rC353204: [DEBUG_INFO][NVPTX] Generate correct data about variable address class. (authored by ABataev, committed by ). Changed prior to commit: https://reviews.llvm.org/D57162?vs=183325&id=185364#toc Re

[PATCH] D57230: [analyzer] Toning down invalidation a bit

NoQ added a comment. Herald added a project: LLVM. Hmm. `writes_to_superobject`? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57230/new/ https://reviews.llvm.org/D57230 ___ cfe-commits mailing list cfe-commits@lists.

[libunwind] r353208 - [CMake] Support compiler-rt builtins library in tests

Author: phosek Date: Tue Feb 5 11:50:47 2019 New Revision: 353208 URL: http://llvm.org/viewvc/llvm-project?rev=353208&view=rev Log: [CMake] Support compiler-rt builtins library in tests We're building tests with -nostdlib which means that we need to explicitly include the builtins library. When

r353212 - Do not use frame pointer by default for MSP430

Author: asl Date: Tue Feb 5 12:15:03 2019 New Revision: 353212 URL: http://llvm.org/viewvc/llvm-project?rev=353212&view=rev Log: Do not use frame pointer by default for MSP430 This is suggested by 3.3.9 of MSP430 EABI document. We do allow user to manually enable frame pointer. GCC toolchain use

[PATCH] D56925: Do not use frame pointer by default for MSP430

asl accepted this revision. asl added a comment. This revision is now accepted and ready to land. Herald added a project: clang. Ok now Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56925/new/ https://reviews.llvm.org/D56925 ___

[PATCH] D56925: Do not use frame pointer by default for MSP430

This revision was automatically updated to reflect the committed changes. Closed by commit rL353212: Do not use frame pointer by default for MSP430 (authored by asl, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST AC

[PATCH] D57716: [CUDA][HIP] Check calling convention based on function target

yaxunl updated this revision to Diff 185375. yaxunl retitled this revision from "Let AMDGPU compile MSVC headers containing vectorcall" to "[CUDA][HIP] Check calling convention based on function target". yaxunl edited the summary of this revision. yaxunl added a reviewer: tra. yaxunl added a comme

r353214 - [DOCS]Support for emission of the debug info for the Cuda devices, NFC.

Author: abataev Date: Tue Feb 5 12:38:36 2019 New Revision: 353214 URL: http://llvm.org/viewvc/llvm-project?rev=353214&view=rev Log: [DOCS]Support for emission of the debug info for the Cuda devices, NFC. Modified: cfe/trunk/docs/OpenMPSupport.rst cfe/trunk/docs/ReleaseNotes.rst Modifie

[PATCH] D57674: [clang-tidy] Add options to bugprone-argument-comment to add missing argument comments to literals

MyDeveloperDay added inline comments. Comment at: clang-tidy/bugprone/ArgumentCommentCheck.cpp:228-236 +static bool isStringLiteral(const Expr *Arg) { + const auto *Cast = dyn_cast(Arg); + return Cast ? isa(Cast->getSubExpr()) : false; +} + +static bool isNullPtrLiteral(const E

[PATCH] D57674: [clang-tidy] Add options to bugprone-argument-comment to add missing argument comments to literals

MyDeveloperDay updated this revision to Diff 185385. MyDeveloperDay marked 6 inline comments as done. MyDeveloperDay added a comment. Address review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57674/new/ https://reviews.llvm.org/D57674 Files: clang-tidy/bugprone/ArgumentCo

[PATCH] D56850: [ASTMatchers][NFC] Add tests for assorted `CXXMemberCallExpr` matchers.

steveire accepted this revision. steveire added a comment. Sorry, this fell off my radar :). LGTM too. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56850/new/ https://reviews.llvm.org/D56850 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D57674: [clang-tidy] Add options to bugprone-argument-comment to add missing argument comments to literals

MyDeveloperDay marked an inline comment as done. MyDeveloperDay added inline comments. Comment at: clang-tidy/bugprone/ArgumentCommentCheck.cpp:257 Ctx->getLangOpts()); }; @aaron.ballman, slight aside (and not in the code

[PATCH] D36806: Switch to cantFail(), since it does the same assertion.

lhames accepted this revision. lhames added a comment. This revision is now accepted and ready to land. Looks like this was LGTM'd but never applied. Stephen -- do you have commit access? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D36806/new/ https://reviews.llvm.org/D36806 __

r353219 - Fix a missing word in comment

Author: adrian Date: Tue Feb 5 13:21:01 2019 New Revision: 353219 URL: http://llvm.org/viewvc/llvm-project?rev=353219&view=rev Log: Fix a missing word in comment Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp URL: http://llvm.org/viewvc/llvm

[PATCH] D57716: [CUDA][HIP] Check calling convention based on function target

tra added inline comments. Comment at: lib/Sema/SemaDeclAttr.cpp:4621-4638 +auto CUDATarget = IdentifyCUDATarget(FD); +if (CUDATarget == CFT_HostDevice) { + A = TI.checkCallingConvention(CC); + if (A == TargetInfo::CCCR_OK && Aux) +A = Aux->checkCallingC

[PATCH] D57771: [CUDA] Add basic support for CUDA-10.1

jlebar accepted this revision. jlebar added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/CodeGen/CGCUDANV.cpp:620 + +// CUDA version requires calling __cudaRegisterFatBinaryEnd(Handle); +if (CudaFeatureEnabled(CGM.getTarget().get

[PATCH] D57771: [CUDA] Add basic support for CUDA-10.1

tra updated this revision to Diff 185398. tra added a comment. Made a comment more readable. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57771/new/ https://reviews.llvm.org/D57771 Files: clang/include/clang/Basic/Cuda.h clang/lib/Basic/Cuda.cpp clang/lib/CodeGen/CGCUDANV.cpp

[PATCH] D57787: [clang-tidy] modernize-avoid-c-arrays: avoid main function (PR40604)

lebedev.ri created this revision. lebedev.ri added reviewers: JonasToth, aaron.ballman. lebedev.ri added a project: clang-tools-extra. Herald added a subscriber: xazax.hun. Herald added a project: clang. The check should ignore the main function, the program entry point. It is not possible to use

[PATCH] D57267: [AST] Factor out the logic of the various Expr::Ignore*

riccibruno marked an inline comment as done. riccibruno added inline comments. Comment at: lib/AST/Expr.cpp:2562 +return ICE->getSubExpr(); + + else if (auto *FE = dyn_cast_or_null(E)) aaron.ballman wrote: > riccibruno wrote: > > It is something that is actu

[PATCH] D36806: Switch to cantFail(), since it does the same assertion.

srhines added a comment. In D36806#1385936 , @lhames wrote: > Looks like this was LGTM'd but never applied. Stephen -- do you have commit > access? Yeah, I was waiting on someone with approval for this area of the code to comment and then lost track of

r353227 - [analyzer] [RetainCountChecker] Bugfix: in non-OSObject-mode, do not track CXX method calls

Author: george.karpenkov Date: Tue Feb 5 14:26:44 2019 New Revision: 353227 URL: http://llvm.org/viewvc/llvm-project?rev=353227&view=rev Log: [analyzer] [RetainCountChecker] Bugfix: in non-OSObject-mode, do not track CXX method calls Differential Revision: https://reviews.llvm.org/D57782 Modif

[PATCH] D57782: [analyzer] [RetainCountChecker] Bugfix: in non-OSObject-mode, do not track CXX method calls

This revision was automatically updated to reflect the committed changes. george.karpenkov marked an inline comment as done. Closed by commit rC353227: [analyzer] [RetainCountChecker] Bugfix: in non-OSObject-mode, do not track CXX… (authored by george.karpenkov, committed by ). Herald added a pro

r353228 - [analyzer] [testing] Inside CmpRuns.py output also print the filename of the first item in the path

Author: george.karpenkov Date: Tue Feb 5 14:26:57 2019 New Revision: 353228 URL: http://llvm.org/viewvc/llvm-project?rev=353228&view=rev Log: [analyzer] [testing] Inside CmpRuns.py output also print the filename of the first item in the path Differential Revision: https://reviews.llvm.org/D5778

r353229 - [analyzer] Document RetainCountChecker behavior and annotations

Author: george.karpenkov Date: Tue Feb 5 14:27:10 2019 New Revision: 353229 URL: http://llvm.org/viewvc/llvm-project?rev=353229&view=rev Log: [analyzer] Document RetainCountChecker behavior and annotations Differential Revision: https://reviews.llvm.org/D57721 Modified: cfe/trunk/www/analyz

r353231 - [Preprocessor] Add a note with framework location for "file not found" error.

Author: vsapsai Date: Tue Feb 5 14:34:55 2019 New Revision: 353231 URL: http://llvm.org/viewvc/llvm-project?rev=353231&view=rev Log: [Preprocessor] Add a note with framework location for "file not found" error. When a framework with the same name is available at multiple framework search paths,

[PATCH] D56561: [Preprocessor] For missing file in framework add note about framework location.

This revision was automatically updated to reflect the committed changes. Closed by commit rC353231: [Preprocessor] Add a note with framework location for "file not found" error. (authored by vsapsai, committed by ). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.o

r353232 - Basic CUDA-10 support.

Author: tra Date: Tue Feb 5 14:38:58 2019 New Revision: 353232 URL: http://llvm.org/viewvc/llvm-project?rev=353232&view=rev Log: Basic CUDA-10 support. Differential Revision: https://reviews.llvm.org/D57771 Modified: cfe/trunk/include/clang/Basic/Cuda.h cfe/trunk/lib/Basic/Cuda.cpp

[PATCH] D57771: [CUDA] Add basic support for CUDA-10.1

This revision was automatically updated to reflect the committed changes. Closed by commit rL353232: Basic CUDA-10 support. (authored by tra, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D57771?vs=185398

[PATCH] D57794: Fix MSVC constructor call extension after b92d290e48e9 (r353181).

jyknight created this revision. jyknight added reviewers: thakis, rsmith. Herald added subscribers: cfe-commits, mstorsjo. Herald added a project: clang. The assert added to EmitCall there was triggering in Windows Chromium builds, due to a mismatch of the return type. The MSVC constructor call e

[PATCH] D57497: [RISCV] Passing small data limitation value to RISCV backend

apazos added a comment. So Eli is concerned we might end up with many globals in the small data section or not picking the best candidates if we pass -G to all files in LTO. I don’t know if anyone has experimented with a heuristic to selectively pick which globals and of which size will be allow

r353240 - [modules] Fix handling of initializers for templated global variables.

Author: rsmith Date: Tue Feb 5 15:37:13 2019 New Revision: 353240 URL: http://llvm.org/viewvc/llvm-project?rev=353240&view=rev Log: [modules] Fix handling of initializers for templated global variables. For global variables with unordered initialization that are instantiated within a module, we

[PATCH] D57626: Disallow trivial_abi on a class if all copy and move constructors are deleted

ahatanak marked 2 inline comments as done. ahatanak added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:2953 + "have bases of non-trivial class types|have virtual bases|" + "have __weak fields under ARC|have fields of non-trivial class types}0">; ---

[PATCH] D57794: Fix MSVC constructor call extension after b92d290e48e9 (r353181).

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57794/new/ https://reviews.llvm.org/D57794 ___ cfe-c

[PATCH] D57497: [RISCV] Passing small data limitation value to RISCV backend

jrtc27 requested changes to this revision. jrtc27 added a comment. This revision now requires changes to proceed. Please update `docs/ClangCommandLineReference.rst`. Also, in my limited testing, GCC just seems to pass the `-msmall-data-limit=...` flag straight through to the linker through `COLL

r353246 - Fix MSVC constructor call extension after b92d290e48e9 (r353181).

Author: jyknight Date: Tue Feb 5 16:06:03 2019 New Revision: 353246 URL: http://llvm.org/viewvc/llvm-project?rev=353246&view=rev Log: Fix MSVC constructor call extension after b92d290e48e9 (r353181). The assert added to EmitCall there was triggering in Windows Chromium builds, due to a mismatch

[PATCH] D57794: Fix MSVC constructor call extension after b92d290e48e9 (r353181).

This revision was automatically updated to reflect the committed changes. Closed by commit rL353246: Fix MSVC constructor call extension after b92d290e48e9 (r353181). (authored by jyknight, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to com

  1   2   >