[PATCH] D57219: [Fixed Point Arithmetic] Fixed Point Comparisons

ebevhan added inline comments. Comment at: clang/test/Frontend/fixed_point_comparisons.c:56 + +void TestComparisons() { + short _Accum sa; leonardchan wrote: > ebevhan wrote: > > Missing saturating and saturating/non-saturating comparisons. I'd like to > > see

Re: r352079 - [FileManager] Revert r347205 to avoid PCH file-descriptor leak.

This is kind of expected: r347205 was a bugfix. Reverting it causes a real bug, and the tests are failing. The bug is acceptable for 8.0 - it affects only a marginal case (go-to-definition on a #include *outside* the preamble section of a file that was also transitively #included in the preamble).

r352345 - [AST] Add structural eq tests for template args

Author: martong Date: Mon Jan 28 02:01:11 2019 New Revision: 352345 URL: http://llvm.org/viewvc/llvm-project?rev=352345&view=rev Log: [AST] Add structural eq tests for template args Summary: New tests added to verify equivalency of templates when their parameters are different. Reviewers: a_sido

[PATCH] D57235: [AST] Add structural eq tests for template args

This revision was automatically updated to reflect the committed changes. Closed by commit rC352345: [AST] Add structural eq tests for template args (authored by martong, committed by ). Changed prior to commit: https://reviews.llvm.org/D57235?vs=183525&id=183810#toc Repository: rC Clang CH

[PATCH] D33440: clang-format: better handle statement macros

sylvestre.ledru added a comment. @Typz I think this should be part of the release notes for v8. This is changing the output on some code base and this is a new feature. By the way, an example in the doc would be great (including with the configuration) merci! Repository: rL LLVM CHANGES S

[PATCH] D56803: clang -dumpversion returns 4.2.1 for legacy reason, update it

sylvestre.ledru added a comment. ping? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56803/new/ https://reviews.llvm.org/D56803 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/m

[PATCH] D57185: [clang-tidy] Add the abseil-duration-addition check

JonasToth accepted this revision. JonasToth added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57185/new/ https://reviews.llvm.org/D57185 ___ cfe-commits mailing list cfe-com

[PATCH] D54395: [clang-tidy] implement utility-function to add 'const' to variables

JonasToth added a comment. ping. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54395/new/ https://reviews.llvm.org/D54395 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

r352349 - Rename getTypeQualifiers to getMethodQualifiers.

Author: stulova Date: Mon Jan 28 03:37:49 2019 New Revision: 352349 URL: http://llvm.org/viewvc/llvm-project?rev=352349&view=rev Log: Rename getTypeQualifiers to getMethodQualifiers. Use more descriptive name for the method qualifiers getter. Differential Revision: https://reviews.llvm.org/D5679

[PATCH] D56792: Rename getTypeQualifiers to getMethodQualifiers

This revision was automatically updated to reflect the committed changes. Closed by commit rL352349: Rename getTypeQualifiers to getMethodQualifiers. (authored by stulova, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D56792?vs=182066

[PATCH] D56852: [AArch64] Use LL for 64-bit arguments

samparker updated this revision to Diff 183820. samparker added reviewers: phosek, rnk. samparker added a comment. Changed the builtins to use W instead of LL. I've also updated the tests, adding a test for rbitl. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56852/new/ https://reviews

[PATCH] D57232: [ASTImporter] Check visibility/linkage of functions and variables

martong updated this revision to Diff 183826. martong marked 5 inline comments as done. martong added a comment. - Remove dumpDeclContext() call - Remove superfluous else Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57232/new/ https://reviews.llvm.org/D57232 Fi

[PATCH] D57232: [ASTImporter] Check visibility/linkage of functions and variables

martong marked an inline comment as done. martong added inline comments. Comment at: lib/AST/ASTImporter.cpp:2954 +return Found->hasExternalFormalLinkage(); + else if (Importer.GetFromTU(Found) == From->getTranslationUnitDecl()) { +if (From->isInAnonymousNamespace()) ---

[PATCH] D57100: [clang-tidy] refactor bugprone-exception-escape analysis into class

baloghadamsoftware added a comment. Hello! I am glad to see that this check gets improved by the community. I also think a "modernize" check which marks functions with `noexcept` is also useful. As for the comma or semicolon, I think semicolon would be better. I see that this part is reverted n

[PATCH] D57100: [clang-tidy] refactor bugprone-exception-escape analysis into class

JonasToth added a comment. In D57100#1373430 , @baloghadamsoftware wrote: > Hello! I am glad to see that this check gets improved by the community. I > also think a "modernize" check which marks functions with `noexcept` is also > useful. Great to hea

[PATCH] D57106: [AST] Introduce GenericSelectionExpr::Association

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from some possible minor nits. Thank you for working on this! Comment at: include/clang/AST/Expr.h:5122 +AssociationIteratorTy() = default; +

[PATCH] D57322: [ASTImporter] Refactor unittests to be able to parameterize them in a more flexible way

martong created this revision. martong added reviewers: a_sidorin, shafik. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp, rnkovacs. Herald added a reviewer: a.sidorin. Currently `TestImportBase` is derived from `ParameterizedTestsFixture` which explicitly states that the gtes

[PATCH] D54438: [analyzer] Reimplement dependencies between checkers

uabelho added inline comments. Comment at: cfe/trunk/include/clang/StaticAnalyzer/Checkers/Checkers.td:230 def NullReturnedFromNonnullChecker : Checker<"NullReturnedFromNonnull">, HelpText<"Warns when a null pointer is returned from a function that has " An

[PATCH] D57232: [ASTImporter] Check visibility/linkage of functions and variables

martong updated this revision to Diff 183834. martong added a comment. I have created a separate patch for the test related refactor, this patch now depends on that patch and contains merely the visibility related change and their tests. Repository: rC Clang CHANGES SINCE LAST ACTION https:

Re: r352079 - [FileManager] Revert r347205 to avoid PCH file-descriptor leak.

Thanks for looking into this. I've reverted the test assertions on the branch in r352354. On Mon, Jan 28, 2019 at 1:14 AM Sam McCall wrote: > > This is kind of expected: r347205 was a bugfix. > Reverting it causes a real bug, and the tests are failing. The bug is > acceptable for 8.0 - it affect

[PATCH] D57106: [AST] Introduce GenericSelectionExpr::Association

riccibruno marked 3 inline comments as done. riccibruno added inline comments. Comment at: include/clang/AST/Expr.h:5122 +AssociationIteratorTy() = default; +AssociationTy operator*() const { + return AssociationTy(cast(*E), *TSI, aaron.ballman wrote

[PATCH] D57106: [AST] Introduce GenericSelectionExpr::Association

aaron.ballman added inline comments. Comment at: include/clang/AST/Expr.h:5122 +AssociationIteratorTy() = default; +AssociationTy operator*() const { + return AssociationTy(cast(*E), *TSI, riccibruno wrote: > aaron.ballman wrote: > > Can this continu

[PATCH] D57322: [ASTImporter] Refactor unittests to be able to parameterize them in a more flexible way

balazske added inline comments. Comment at: unittests/AST/ASTImporterTest.cpp:15 +// FIXME: Better solution for this? +#define GTEST_HAS_COMBINE 1 + Define of this is related to the new visibility tests, but not a problem is this remains here (there is another n

[PATCH] D57266: [AST] Update the comments of the various Expr::Ignore* + Related cleanups

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with some nits. Thank you for the cleaned up comments, these are helpful! Comment at: include/clang/AST/Expr.h:749-750 + /// reaching a fixed point. Skips

[PATCH] D57106: [AST] Introduce GenericSelectionExpr::Association

riccibruno marked 5 inline comments as done. riccibruno added inline comments. Comment at: include/clang/AST/Expr.h:5122 +AssociationIteratorTy() = default; +AssociationTy operator*() const { + return AssociationTy(cast(*E), *TSI, aaron.ballman wrote

[PATCH] D54438: [analyzer] Reimplement dependencies between checkers

Szelethus marked an inline comment as done. Szelethus added inline comments. Comment at: cfe/trunk/include/clang/StaticAnalyzer/Checkers/Checkers.td:230 def NullReturnedFromNonnullChecker : Checker<"NullReturnedFromNonnull">, HelpText<"Warns when a null pointer is returned

Re: r352323 - [SemaCXX] Fix ICE with structure bindings to members of template

Thanks for letting me know! Merged in r352356. On Sun, Jan 27, 2019 at 12:06 PM Richard Smith wrote: > > Hi Hans, > > This is a safe change that fixes a crash; it'd be good to get this into clang > 8. > > Thanks! > > On Sun, 27 Jan 2019, 11:19 Nicolas Lesser via cfe-commits, > wrote: >> >> Aut

[PATCH] D54438: [analyzer] Reimplement dependencies between checkers

uabelho added inline comments. Comment at: cfe/trunk/include/clang/StaticAnalyzer/Checkers/Checkers.td:230 def NullReturnedFromNonnullChecker : Checker<"NullReturnedFromNonnull">, HelpText<"Warns when a null pointer is returned from a function that has " Sz

[PATCH] D57266: [AST] Update the comments of the various Expr::Ignore* + Related cleanups

riccibruno marked 8 inline comments as done. riccibruno added inline comments. Comment at: include/clang/AST/Expr.h:749-750 + /// reaching a fixed point. Skips: + /// * ImplicitCastExpr. + /// * FullExpr. Expr *IgnoreImpCasts() LLVM_READONLY; aaron.ballman

Re: r352099 - [WebAssembly] Factor commonality between wasm32 and wasm64 in test/Preprocessor/init.c

Merged to 8.0 in r352359. On Thu, Jan 24, 2019 at 12:31 PM Dan Gohman via cfe-commits wrote: > > Author: djg > Date: Thu Jan 24 12:31:11 2019 > New Revision: 352099 > > URL: http://llvm.org/viewvc/llvm-project?rev=352099&view=rev > Log: > [WebAssembly] Factor commonality between wasm32 and wasm64

Re: r352105 - [WebAssembly] Add a __wasi__ target macro

Merged in r352360. On Thu, Jan 24, 2019 at 1:05 PM Dan Gohman via cfe-commits wrote: > > Author: djg > Date: Thu Jan 24 13:05:11 2019 > New Revision: 352105 > > URL: http://llvm.org/viewvc/llvm-project?rev=352105&view=rev > Log: > [WebAssembly] Add a __wasi__ target macro > > This adds a `__wasi_

[PATCH] D56903: [clangd] Suggest adding missing includes for incomplete type diagnostics.

ioeric updated this revision to Diff 183838. ioeric marked 12 inline comments as done. ioeric added a comment. - address review comments Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56903/new/ https://reviews.llvm.org/D56903 Files: clangd/CMakeL

[clang-tools-extra] r352361 - [clangd] Suggest adding missing includes for incomplete type diagnostics.

Author: ioeric Date: Mon Jan 28 06:01:55 2019 New Revision: 352361 URL: http://llvm.org/viewvc/llvm-project?rev=352361&view=rev Log: [clangd] Suggest adding missing includes for incomplete type diagnostics. Summary: This enables clangd to intercept compiler diagnostics and attach fixes (e.g. by q

[clang-tools-extra] r352362 - [clang-tidy] Add the abseil-duration-addition check

Author: hwright Date: Mon Jan 28 06:03:09 2019 New Revision: 352362 URL: http://llvm.org/viewvc/llvm-project?rev=352362&view=rev Log: [clang-tidy] Add the abseil-duration-addition check Differential Revision: https://reviews.llvm.org/D57185 Added: clang-tools-extra/trunk/clang-tidy/abseil/Du

[PATCH] D56903: [clangd] Suggest adding missing includes for incomplete type diagnostics.

This revision was automatically updated to reflect the committed changes. Closed by commit rL352361: [clangd] Suggest adding missing includes for incomplete type diagnostics. (authored by ioeric, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.l

[PATCH] D57185: [clang-tidy] Add the abseil-duration-addition check

This revision was automatically updated to reflect the committed changes. Closed by commit rL352362: [clang-tidy] Add the abseil-duration-addition check (authored by hwright, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D57185?vs=183

[clang-tools-extra] r352364 - [clang-tidy] Fix a build error.

Author: hokein Date: Mon Jan 28 06:07:45 2019 New Revision: 352364 URL: http://llvm.org/viewvc/llvm-project?rev=352364&view=rev Log: [clang-tidy] Fix a build error. Modified: clang-tools-extra/trunk/clang-tidy/abseil/DurationAdditionCheck.cpp Modified: clang-tools-extra/trunk/clang-tidy/abse

Re: r352221 - Disable _Float16 for non ARM/SPIR Targets

Merged together with r35 to 8.0 in r352363. On Fri, Jan 25, 2019 at 9:27 AM Erich Keane via cfe-commits wrote: > > Author: erichkeane > Date: Fri Jan 25 09:27:57 2019 > New Revision: 352221 > > URL: http://llvm.org/viewvc/llvm-project?rev=352221&view=rev > Log: > Disable _Float16 for non ARM/

Re: r352229 - Remove F16 literal support based on Float16 support.

Merged to 8.0 in r352365. On Fri, Jan 25, 2019 at 10:36 AM Erich Keane via cfe-commits wrote: > > Author: erichkeane > Date: Fri Jan 25 10:36:20 2019 > New Revision: 352229 > > URL: http://llvm.org/viewvc/llvm-project?rev=352229&view=rev > Log: > Remove F16 literal support based on Float16 suppor

[clang-tools-extra] r352367 - [clangd] Index main-file macros (bug 39761)

Author: hokein Date: Mon Jan 28 06:11:49 2019 New Revision: 352367 URL: http://llvm.org/viewvc/llvm-project?rev=352367&view=rev Log: [clangd] Index main-file macros (bug 39761) Patch by Nathan Ridge! Differential Revision: https://reviews.llvm.org/D55739 Modified: clang-tools-extra/trunk/cl

[PATCH] D55739: [Clangd] Index main-file macros (bug 39761)

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE352367: [clangd] Index main-file macros (bug 39761) (authored by hokein, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.org/D55739?vs=183320&id=1

[PATCH] D46871: [AMDGPU] Add interpolation builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rC352358: [AMDGPU] Add interpolation builtins (authored by timcorringham, committed by ). Herald added a subscriber: jvesely. Changed prior to commit: https://reviews.llvm.org/D46871?vs=147460&id=183837#t

r352358 - [AMDGPU] Add interpolation builtins

Author: timcorringham Date: Mon Jan 28 05:50:37 2019 New Revision: 352358 URL: http://llvm.org/viewvc/llvm-project?rev=352358&view=rev Log: [AMDGPU] Add interpolation builtins Summary: Added builtins for the interpolation intrinsics, and related LIT test. Reviewers: arsenm, tpr, dstuttard, #amdg

Re: [clang-tools-extra] r352231 - [clang-tidy] fix unit tests for dropped _Float16 support in X86

Merged to 8.0 in r352368. On Fri, Jan 25, 2019 at 11:05 AM Jonas Toth via cfe-commits wrote: > > Author: jonastoth > Date: Fri Jan 25 11:05:12 2019 > New Revision: 352231 > > URL: http://llvm.org/viewvc/llvm-project?rev=352231&view=rev > Log: > [clang-tidy] fix unit tests for dropped _Float16 sup

r352369 - [AST] Introduce GenericSelectionExpr::Association

Author: brunoricci Date: Mon Jan 28 06:18:11 2019 New Revision: 352369 URL: http://llvm.org/viewvc/llvm-project?rev=352369&view=rev Log: [AST] Introduce GenericSelectionExpr::Association Introduce a new class GenericSelectionExpr::Association which bundle together an association expression and it

[PATCH] D57106: [AST] Introduce GenericSelectionExpr::Association

This revision was automatically updated to reflect the committed changes. Closed by commit rL352369: [AST] Introduce GenericSelectionExpr::Association (authored by brunoricci, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D57106?vs=18

[PATCH] D57280: [clang][OpenMP] OMPFlushClause is synthetic, no such clause exists

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG with a nit Comment at: lib/Basic/OpenMPKinds.cpp:56 #define OPENMP_CLAUSE(Name, Class) .Case(#Name, OMPC_##Name) + OPENMP_CLAUSE(flush, OMPFlushClause) #include "

[PATCH] D57021: [clangd] Suggest adding missing includes for typos (like include-fixer).

ioeric updated this revision to Diff 183845. ioeric added a comment. - Rebase on origin/master Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57021/new/ https://reviews.llvm.org/D57021 Files: clangd/ClangdUnit.cpp clangd/IncludeFixer.cpp clang

[PATCH] D56943: [clang-format][NFC] Allow getLLVMStyle() to take a language

rupprecht added a comment. ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56943/new/ https://reviews.llvm.org/D56943 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[PATCH] D56851: [ASTMatchers] Adds `CXXMemberCallExpr` matcher `invokedAtType`.

ymandel marked 2 inline comments as done. ymandel added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:3300 +/// matches `x.m()` and `p->m()`. +AST_MATCHER_P_OVERLOAD(clang::CXXMemberCallExpr, invokedAtType, + clang::ast_matcher

[PATCH] D57325: [clangd] Collect macros in static index.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov. We are missing macros in static index. symbols: before 407 K vs after 420 K dex memory usage (static index): before 299 MB vs 304 MB Reposito

[PATCH] D56326: [OpenMP 5.0] Parsing/sema support for "omp declare mapper" directive

ABataev added a comment. LG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56326/new/ https://reviews.llvm.org/D56326 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r346652 - Make clang-based tools find libc++ on MacOS

I think c-index-test has the same problem: $ cat test.cc #include $ out/gn/bin/c-index-test -write-pch foo.pch test.cc test.cc:1:10: fatal error: 'iostream' file not found Since https://reviews.llvm.org/rL350714 was a driver-side fix and c-index-test doesn't use lib/Driver, it didn't do anything

[PATCH] D57267: [AST] Factor out the logic of the various Expr::Ignore*

aaron.ballman added a reviewer: rsmith. aaron.ballman added a comment. Adding Richard for opinions on whether `IgnoreParenImpCasts` should skip full expressions, and also the changes to accepting null expressions as arguments in more places. Comment at: lib/AST/Expr.cpp:2559

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return check

aaron.ballman added a comment. In D56160#1372766 , @bernhardmgruber wrote: > Thank you for the feedback! > > @JonasToth I added tests for `decltype` and i can rewrite all signatures > where `decltype` is not the top level expression. The reason is, that

[PATCH] D56928: Support attribute used in member funcs of class templates

aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added inline comments. Comment at: lib/Sema/SemaTemplateInstantiateDecl.cpp:2182 + if (Method->hasAttr()) { +if (auto *A = dyn_cast(Owner)) { + SourceLocation Loc; `const auto *`? ==

[PATCH] D57330: Adjust documentation for git migration.

jyknight created this revision. jyknight added reviewers: jlebar, rnk, mehdi_amini. Herald added subscribers: jsji, jfb, arphaman, christof, delcypher, hiraditya, nhaehnle, jvesely, nemanjai, kubamracek, arsenm. Herald added a reviewer: bollu. Herald added a reviewer: serge-sans-paille. This fixe

[PATCH] D57280: [clang][OpenMP] OMPFlushClause is synthetic, no such clause exists

lebedev.ri added a comment. In D57280#1373547 , @ABataev wrote: > LG with a nit Thank you for the review! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57280/new/ https://reviews.llvm.org/D57280 _

[PATCH] D56851: [ASTMatchers] Adds `CXXMemberCallExpr` matcher `invokedAtType`.

alexfh added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:3300 +/// matches `x.m()` and `p->m()`. +AST_MATCHER_P_OVERLOAD(clang::CXXMemberCallExpr, invokedAtType, + clang::ast_matchers::internal::Matcher, yman

[PATCH] D57280: [clang][OpenMP] OMPFlushClause is synthetic, no such clause exists

lebedev.ri added inline comments. Comment at: lib/Basic/OpenMPKinds.cpp:56 #define OPENMP_CLAUSE(Name, Class) .Case(#Name, OMPC_##Name) + OPENMP_CLAUSE(flush, OMPFlushClause) #include "clang/Basic/OpenMPKinds.def" ABataev wrote: > Just `.Case("flush", OMPC

[PATCH] D57267: [AST] Factor out the logic of the various Expr::Ignore*

riccibruno updated this revision to Diff 183865. riccibruno marked 4 inline comments as done. riccibruno added a comment. Removed the separator comments in `Expr.cpp` Mode `IgnoreExprNodes` work with an arbitrary number of functions. Repository: rC Clang CHANGES SINCE LAST ACTION https://re

[PATCH] D57267: [AST] Factor out the logic of the various Expr::Ignore*

riccibruno added inline comments. Comment at: lib/AST/Expr.cpp:2562 +static Expr *IgnoreImpCastsSingleStep(Expr *E) { + if (auto *ICE = dyn_cast_or_null(E)) +return ICE->getSubExpr(); aaron.ballman wrote: > Do we really need to accept null arguments? We didn

[PATCH] D57280: [clang][OpenMP] OMPFlushClause is synthetic, no such clause exists

ABataev added inline comments. Comment at: lib/Basic/OpenMPKinds.cpp:56 #define OPENMP_CLAUSE(Name, Class) .Case(#Name, OMPC_##Name) + OPENMP_CLAUSE(flush, OMPFlushClause) #include "clang/Basic/OpenMPKinds.def" lebedev.ri wrote: > ABataev wrote: > > Just `

[PATCH] D56851: [ASTMatchers] Adds `CXXMemberCallExpr` matcher `invokedAtType`.

ymandel marked 2 inline comments as done. ymandel added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:3300 +/// matches `x.m()` and `p->m()`. +AST_MATCHER_P_OVERLOAD(clang::CXXMemberCallExpr, invokedAtType, + clang::ast_matcher

[PATCH] D57230: [analyzer] Toning down invalidation a bit

xazax.hun added a comment. I tried to creduce one file where the result differed and this is the result: typedef struct { int a; int b } c; d; e(c *f) { d < f->a; c g; h(&g.b); e(&g); } I think this the core idea is quite straightforward but this example is a bi

Re: r346652 - Make clang-based tools find libc++ on MacOS

This seems to fix it, but I don't know if it's the right fix: diff --git a/clang/lib/Frontend/CreateInvocationFromCommandLine.cpp b/clang/lib/Frontend/CreateInvocationFromCommandLine.cpp index b62416ffd9e..d933f8c1b70 100644 --- a/clang/lib/Frontend/CreateInvocationFromCommandLine.cpp +++ b/clang/

[libunwind] r352384 - [libunwind] Drop the dependency on , add placement new inline

Author: phosek Date: Mon Jan 28 08:44:56 2019 New Revision: 352384 URL: http://llvm.org/viewvc/llvm-project?rev=352384&view=rev Log: [libunwind] Drop the dependency on , add placement new inline We haven't eliminated C++ library dependency altogether in D57251, UnwindCursor.hpp had an unused depe

[PATCH] D53329: Generate DIFile with main program if source is not available

yonghong-song added a comment. @dblaikie As I mentioned in one of my earlier comments, after some analysis, I think this patch definitely not the right way to fix the problem. We just cannot default to the main file if the DIFile source is not available. I have a bug filed for the same issue (

r352390 - [clang][OpenMP] OMPFlushClause is synthetic, no such clause exists

Author: lebedevri Date: Mon Jan 28 09:04:11 2019 New Revision: 352390 URL: http://llvm.org/viewvc/llvm-project?rev=352390&view=rev Log: [clang][OpenMP] OMPFlushClause is synthetic, no such clause exists Summary: As discussed in https://reviews.llvm.org/D57112#inline-506781, 'flush' clause does no

[PATCH] D57280: [clang][OpenMP] OMPFlushClause is synthetic, no such clause exists

lebedev.ri marked an inline comment as done. lebedev.ri added inline comments. Comment at: lib/Basic/OpenMPKinds.cpp:56 #define OPENMP_CLAUSE(Name, Class) .Case(#Name, OMPC_##Name) + OPENMP_CLAUSE(flush, OMPFlushClause) #include "clang/Basic/OpenMPKinds.def" --

[PATCH] D57280: [clang][OpenMP] OMPFlushClause is synthetic, no such clause exists

This revision was automatically updated to reflect the committed changes. Closed by commit rL352390: [clang][OpenMP] OMPFlushClause is synthetic, no such clause exists (authored by lebedevri, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.

[PATCH] D56868: Add -fapply-global-visibility-to-externs for -cc1

This revision was automatically updated to reflect the committed changes. Closed by commit rL352391: Add -fapply-global-visibility-to-externs for -cc1 (authored by scott.linder, committed by ). Changed prior to commit: https://reviews.llvm.org/D56868?vs=182559&id=183886#toc Repository: rL LL

r352391 - Add -fapply-global-visibility-to-externs for -cc1

Author: scott.linder Date: Mon Jan 28 09:12:19 2019 New Revision: 352391 URL: http://llvm.org/viewvc/llvm-project?rev=352391&view=rev Log: Add -fapply-global-visibility-to-externs for -cc1 Introduce an option to request global visibility settings be applied to declarations without a definition or

[PATCH] D57330: Adjust documentation for git migration.

jyknight updated this revision to Diff 183891. jyknight added a comment. Fix some warnings I added. Restore TestSuiteMakefileGuide.rst, which apparently isn't 100% obsolete. (But it is incorrect, and I'm not sure exactly how to fix it, so I just left a FIXME). CHANGES SINCE LAST ACTION https:

[PATCH] D57337: [Targets] Adjust ARM data layout

michaelplatings updated this revision to Diff 183893. michaelplatings added a comment. Diff with -U9 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57337/new/ https://reviews.llvm.org/D57337 Files: clang/lib/Basic/Targets/ARM.cpp clang/test/CodeGen/armv7k

[PATCH] D57127: [analyzer] Port RetainSummaryManager to the new GenericCall interface, decouple ARCMT from the analyzer

thakis added a comment. In D57127#1371562 , @george.karpenkov wrote: > > Can you elaborate a bit in what sense this decouples ARCMT from the > > analyzer? > > ARCMT now does not need to link against the analyzer > > > Can CLANG_ENABLE_STATIC_ANALYZER now

[PATCH] D57127: [analyzer] Port RetainSummaryManager to the new GenericCall interface, decouple ARCMT from the analyzer

thakis added a comment. In D57127#1371563 , @george.karpenkov wrote: > > Also, isn't lib/Analysis a strange place for this? lib/Analysis is used by > > the compiler proper (CodeGen, Sema, …), while RetainSummaryManager is only > > used by tooling-like t

Re: r352369 - [AST] Introduce GenericSelectionExpr::Association

Hi, This doesn't compile when using GCC 4.8.4: 372/372] Building CXX object tools/clang/tools/clang-import-test/CMakeFiles/clang-import-test.dir/clang-import-test.cpp.o FAILED: tools/clang/tools/clang-import-test/CMakeFiles/clang-import-test.dir/clang-import-test.cpp.o /work/gccprefix/bin/g++ -

[PATCH] D57127: [analyzer] Port RetainSummaryManager to the new GenericCall interface, decouple ARCMT from the analyzer

george.karpenkov added a comment. @thakis Sorry I don't understand your point. At the end of the day, ProgramPoint and BodyFarm are only used by the static analyzer. If you disagree, what is your proposed directory structure? What would be the benefits? Repository: rC Clang CHANGES SINCE LA

[PATCH] D57112: [ASTTypeTraits] OMPClause handling

lebedev.ri updated this revision to Diff 183902. lebedev.ri marked an inline comment as done. lebedev.ri added a comment. - Rebased - Go back to storing the actual AST class type as string in `ASTNodeKind::KindInfo ASTNodeKind::AllKindInfo[]`. - Add `OpenMPClauseKind ASTNodeKind::getOMPClauseKind

[PATCH] D57113: [clang-tidy] openmp-use-default-none - a new module and a check

lebedev.ri updated this revision to Diff 183903. lebedev.ri added a comment. NFC. - Rebased - Switched to `OpenMPClauseKind ASTNodeKind::getOMPClauseKind()`. This is better anyway, since it avoids string comparisons, and is a simple switch over an enum. Repository: rCTE Clang Tools Extra C

r352403 - Revert "[AST] Introduce GenericSelectionExpr::Association"

Author: brunoricci Date: Mon Jan 28 10:40:26 2019 New Revision: 352403 URL: http://llvm.org/viewvc/llvm-project?rev=352403&view=rev Log: Revert "[AST] Introduce GenericSelectionExpr::Association" This breaks GCC 4.8.4. Reported by email by Hans Wennborg. Modified: cfe/trunk/include/clang/AS

r352404 - Add --unwindlib=[libgcc|compiler-rt] to parallel --rtlib=

Author: saugustine Date: Mon Jan 28 10:56:43 2019 New Revision: 352404 URL: http://llvm.org/viewvc/llvm-project?rev=352404&view=rev Log: Add --unwindlib=[libgcc|compiler-rt] to parallel --rtlib= Summary: "clang++ hello.cc --rtlib=compiler-rt" now works without specifying additional unwind or exc

r352405 - Correct help text for --unwindlib options.

Author: saugustine Date: Mon Jan 28 10:56:44 2019 New Revision: 352405 URL: http://llvm.org/viewvc/llvm-project?rev=352405&view=rev Log: Correct help text for --unwindlib options. Modified: cfe/trunk/include/clang/Driver/Options.td Modified: cfe/trunk/include/clang/Driver/Options.td URL: ht

[PATCH] D55782: Fix isInSystemMacro to handle pasted token

rsmith added inline comments. Comment at: include/clang/Basic/SourceManager.h:1458-1460 + // This happens when the macro is the result of a paste, in that case + // its spelling is the scratch memory, so we take the parent context. +isInSystemHea

[PATCH] D57343: lit: Let lit.util.which() return a normcase()ed path

thakis created this revision. thakis added a reviewer: zturner. Herald added a subscriber: delcypher. Herald added a reviewer: serge-sans-paille. `LLVMConfig.with_environment()` uses `os.path.normcase(os.path.normpath(x))` to normalize temporary env vars. `LLVMConfig.use_clang()` uses `with_envi

[PATCH] D57343: lit: Let lit.util.which() return a normcase()ed path

zturner added a comment. Shouldn't the hash be case-insensitive on windows? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57343/new/ https://reviews.llvm.org/D57343 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D57345: Make clang/test/Index/pch-from-libclang.c pass in more places

thakis created this revision. thakis added a reviewer: arphaman. - fixes the test on macOS with LLVM_ENABLE_PIC=OFF - together with D57343 , gets the test to pass on Windows - makes it run everywhere (it seems to just pass on Linux) The main change is in CIndexer

[libunwind] r352411 - Revert "[CMake] Use __libc_start_main rather than fopen when checking for C library"

Author: phosek Date: Mon Jan 28 11:26:41 2019 New Revision: 352411 URL: http://llvm.org/viewvc/llvm-project?rev=352411&view=rev Log: Revert "[CMake] Use __libc_start_main rather than fopen when checking for C library" This reverts commit r352341: it broke the build on macOS which doesn't seem to

[PATCH] D56936: Fix handling of overriden methods during ASTImport

shafik updated this revision to Diff 183923. shafik marked 2 inline comments as done. shafik added a comment. Addressing comments on commenting and naming. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56936/new/ https://reviews.llvm.org/D56936 Files: lib/AST/ASTImporter.cpp test/A

[PATCH] D57349: AMDGPU: Add ds append/consume builtins

arsenm created this revision. arsenm added reviewers: yaxunl, rampitec, b-sumner. Herald added subscribers: t-tye, tpr, dstuttard, nhaehnle, wdng, jvesely, kzhuravl. https://reviews.llvm.org/D57349 Files: include/clang/Basic/BuiltinsAMDGPU.def lib/CodeGen/CGBuiltin.cpp test/CodeGenOpenCL/b

[PATCH] D56936: Fix handling of overriden methods during ASTImport

teemperor accepted this revision. teemperor added a comment. LGTM, thanks! Comment at: unittests/AST/ASTImporterTest.cpp:2271 +struct D:B { void f(){}; }; + )"; + auto BFP = I think this should be formatted in the same way as the snippet above.

[PATCH] D57349: AMDGPU: Add ds append/consume builtins

rampitec accepted this revision. rampitec added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57349/new/ https://reviews.llvm.org/D57349 ___ cfe-commits mailing list cfe-commi

[PATCH] D56723: [CodeComplete] Propagate preferred types through parser in more cases

ilya-biryukov marked an inline comment as done. ilya-biryukov added inline comments. Comment at: lib/Sema/SemaCodeComplete.cpp:373 +} +Type = QualType(); + }); ilya-biryukov wrote: > kadircet wrote: > > nit: maybe move this into top and get rid of the re

[PATCH] D56723: [CodeComplete] Propagate preferred types through parser in more cases

ilya-biryukov updated this revision to Diff 183937. ilya-biryukov added a comment. - Use 'else if' to simplify the code CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56723/new/ https://reviews.llvm.org/D56723 Files: clang/include/clang/Parse/Parser.h clang/include/clang/Sema/CodeCo

r352421 - [OPENMP][NVPTX]Emit service debug variable for NVPTX.

Author: abataev Date: Mon Jan 28 12:03:02 2019 New Revision: 352421 URL: http://llvm.org/viewvc/llvm-project?rev=352421&view=rev Log: [OPENMP][NVPTX]Emit service debug variable for NVPTX. In case of the empty module, the ptxas tool may emit error message about empty debug info sections. This patc

[PATCH] D53329: Generate DIFile with main program if source is not available

dblaikie added a comment. In D53329#1373799 , @yonghong-song wrote: > @dblaikie As I mentioned in one of my earlier comments, after some analysis, > I think this patch definitely not the right way to fix the problem. We just > cannot default to the main

[PATCH] D57353: [clang-tidy] Add the abseil-duration-double-conversion check

hwright created this revision. hwright added reviewers: hokein, JonasToth, aaron.ballman. hwright added a project: clang-tools-extra. Herald added subscribers: cfe-commits, xazax.hun, mgorny. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D57353 Files: clang-tidy/abseil/AbseilTi

[libunwind] r352427 - Revert "[libunwind] Drop the dependency on , add placement new inline"

Author: phosek Date: Mon Jan 28 12:55:12 2019 New Revision: 352427 URL: http://llvm.org/viewvc/llvm-project?rev=352427&view=rev Log: Revert "[libunwind] Drop the dependency on , add placement new inline" This reverts commit r352384: this broke on ARM as UnwindCursor.hpp still has some C++ librar

[PATCH] D57114: Remove Expr sugar decorating the CXXUuidofExpr node.

rnk added a comment. Thanks for following up! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57114/new/ https://reviews.llvm.org/D57114 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

  1   2   >