Author: void
Date: Sat Nov 24 02:45:55 2018
New Revision: 347512
URL: http://llvm.org/viewvc/llvm-project?rev=347512&view=rev
Log:
isEvaluatable() implies a constant context.
Assume that we're in a constant context if we're asking if the expression can
be compiled into a constant initializer. Thi
Author: szelethus
Date: Sat Nov 24 04:24:27 2018
New Revision: 347513
URL: http://llvm.org/viewvc/llvm-project?rev=347513&view=rev
Log:
[analyzer] INT50-CPP. Do not cast to an out-of-range enumeration checker
This checker implements a solution to the "INT50-CPP. Do not cast to an
out-of-range enu
This revision was automatically updated to reflect the committed changes.
Closed by commit rC347513: [analyzer] INT50-CPP. Do not cast to an out-of-range
enumeration checker (authored by Szelethus, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D33672?vs=172516&id=175154#toc
aaron.ballman added inline comments.
Comment at: clang-tidy/cppcoreguidelines/NarrowingConversionsCheck.cpp:31
+ Options.get("WarnOnFloatingPointNarrowingConversion", 1)),
+ WarnOnCastingLiterals(Options.get("WarnOnCastingLiterals", 1)) {}
+
I think
MTC added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/MallocChecker.cpp:342
+ DefaultBool IsOptimistic;
+ MemFunctionInfoTy MemFunctionInfo;
public:
Szelethus wrote:
> Szelethus wrote:
> > Szelethus wrote:
> > > MTC wrote:
> > > > I can't say that
Szelethus marked 3 inline comments as done.
Szelethus added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/MallocChecker.cpp:1087
if (FD->getKind() == Decl::Function) {
-initIdentifierInfo(C.getASTContext());
+MemFunctionInfo.initIdentifierInfo(C.getASTContex
Szelethus added a comment.
Hmmm, I was wrong a little bit: I realized that if I tinker with with
`initializeManager` and `getEnabledCheckers` just a bit more, register checkers
straight away, don't need to collect them first, and this would make sure that
dependencies are registered before the
aaronpuchert added a comment.
> As the analysis grew more complex, I switched to the current system based on
> "facts". There are a number of facts that are potentially useful in static
> analysis, such as whether one expression aliases another, and most of them
> don't look at all like capabil
jhibbits added a comment.
Hi Vit,
I'm unable to reproduce the previous crash with clang8, so for now assuming
it's fixed by other events. If that turns out not to be the case, I can
revisit it. I am able to reproduce this crash though, so am taking a look.
I'm' not quite sure how to interpr
DevAlone added a comment.
So, will it be added?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D33029/new/
https://reviews.llvm.org/D33029
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
Author: alexfh
Date: Sat Nov 24 18:41:01 2018
New Revision: 347520
URL: http://llvm.org/viewvc/llvm-project?rev=347520&view=rev
Log:
A bit of AST matcher cleanup, NFC.
Removed the uses of the allOf() matcher inside node matchers that are implicit
allOf(). Replaced uses of allOf() with the explici
malaperle created this revision.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay,
ioeric, ilya-biryukov.
Using Clang-cl, I have seen scenarios where the compilation database contains
all flags necessary to find compiler-specific (CL) headers, using /imsvc.
Specifying -
kristina added a comment.
Ping. Is the author still around? I'm happy to take over this revision if not,
and add `__FLOAT128__` but unless someone says `_GLIBCXX_USE_FLOAT128` is
actually defined by the toolchain, I'll remove that line, it looks like it
really shouldn't be defined in the toolch
13 matches
Mail list logo