[PATCH] D45619: [Time-report] (1) Use special new Clang flag 'FrontendTimesIsEnabled' instead of 'llvm::TimePassesIsEnabled' inside -ftime-report feature

avt77 added a comment. In https://reviews.llvm.org/D45619#1075677, @bjope wrote: > buildbots have been failing all day (and were still failing). So I pushed my > suggested fix. > I hope that was OK. Thank you. It seems everything is OK now. Repository: rL LLVM https://reviews.llvm.org/D4

r330689 - [AST] Use a bit of trickery to make test pass on platforms where wchar_t is unsigned.

Author: d0k Date: Tue Apr 24 00:53:10 2018 New Revision: 330689 URL: http://llvm.org/viewvc/llvm-project?rev=330689&view=rev Log: [AST] Use a bit of trickery to make test pass on platforms where wchar_t is unsigned. Modified: cfe/trunk/test/SemaCXX/constexpr-string.cpp Modified: cfe/trunk/t

[PATCH] D45865: [Sema] Emit -Warray-bounds for multiple levels of subscript expressions.

ebevhan updated this revision to Diff 143684. ebevhan added a comment. Removed local variable and added some more to the test. https://reviews.llvm.org/D45865 Files: lib/Sema/SemaChecking.cpp test/SemaCXX/array-bounds.cpp test/SemaCXX/constant-expression-cxx11.cpp Index: test/SemaCXX/co

r330690 - [AST] Another attempt at fixing the ARM bots.

Author: d0k Date: Tue Apr 24 01:18:32 2018 New Revision: 330690 URL: http://llvm.org/viewvc/llvm-project?rev=330690&view=rev Log: [AST] Another attempt at fixing the ARM bots. Modified: cfe/trunk/test/SemaCXX/constexpr-string.cpp Modified: cfe/trunk/test/SemaCXX/constexpr-string.cpp URL: ht

[PATCH] D45839: [analyzer] Add support for WebKit "unified sources".

a.sidorin added a comment. Hi Artem. Cool patch! Maybe we should create an analyzer option for this? So, all users who want webkit-like behaviour will just enable (or disable, don't know what's better) the option and get the feature. I know that introducing a new option is undesirable but it s

[PATCH] D41241: [Solaris] Only define _REENTRANT if -pthread

ro added a reviewer: fedor.sergeev. ro added a comment. ping^5 Repository: rC Clang https://reviews.llvm.org/D41241 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r330692 - [libclang] Only mark CXCursors for explicit attributes with a type

Author: erikjv Date: Tue Apr 24 01:39:46 2018 New Revision: 330692 URL: http://llvm.org/viewvc/llvm-project?rev=330692&view=rev Log: [libclang] Only mark CXCursors for explicit attributes with a type All attributes have a source range associated with it. However, implicit attributes are added by

r330694 - Link to AggressiveInstCombine in a few places. Unbreaks build for me.

Author: lebedevri Date: Tue Apr 24 01:40:44 2018 New Revision: 330694 URL: http://llvm.org/viewvc/llvm-project?rev=330694&view=rev Log: Link to AggressiveInstCombine in a few places. Unbreaks build for me. /usr/local/bin/ld.lld: error: undefined symbol: llvm::createAggressiveInstCombinerPass() >

[PATCH] D38615: [libclang] Only mark CXCursors for explicit attributes with a type

erikjv closed this revision. erikjv added a comment. Committed as r330692 https://reviews.llvm.org/D38615 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r330696 - [GCC] Match a GCC version with a patch suffix without a third version component

Author: mstorsjo Date: Tue Apr 24 01:50:11 2018 New Revision: 330696 URL: http://llvm.org/viewvc/llvm-project?rev=330696&view=rev Log: [GCC] Match a GCC version with a patch suffix without a third version component Previously it would only accept a string as a GCC version if it had either two com

r330695 - [test] Fix a typo in a test directory name. NFC.

Author: mstorsjo Date: Tue Apr 24 01:49:57 2018 New Revision: 330695 URL: http://llvm.org/viewvc/llvm-project?rev=330695&view=rev Log: [test] Fix a typo in a test directory name. NFC. Added: cfe/trunk/test/Driver/Inputs/mingw_ubuntu_tree/usr/include/c++/4.8/x86_64-w64-mingw32/ cfe/trunk

[PATCH] D45505: [GCC] Match a GCC version with a patch suffix without a third version component

This revision was automatically updated to reflect the committed changes. Closed by commit rC330696: [GCC] Match a GCC version with a patch suffix without a third version component (authored by mstorsjo, committed by ). Repository: rC Clang https://reviews.llvm.org/D45505 Files: lib/Driver/

[PATCH] D45887: [CodeComplete] Fix completion at the end of keywords

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Nice! I'm a little surprised that this wasn't fixed before, so I'm worried I missing something. But nobody else has reviewed it, and it really seems right (and the test cases you fixed d

[PATCH] D45965: [Targets] Implement getConstraintRegister for ARM and AArch64

miyuki added inline comments. Comment at: lib/Basic/Targets/AArch64.h:85-89 + StringRef getConstraintRegister(StringRef Constraint, + StringRef Expression) const override { +return Expression; + } + thopre wrote: > From what

[PATCH] D45815: [libclang] Add options to limit skipping of function bodies

ilya-biryukov added a comment. In https://reviews.llvm.org/D45815#1073581, @nik wrote: > Hmm, that indicates that template function bodies are actually not that > dominant, which I also haven't thought. Now I'm doubting the correctness of > my patch/tests. The numbers are definitely interesti

[PATCH] D45050: [clang-tidy] New checker for not null-terminated result caused by strlen or wcslen

Charusso marked an inline comment as done. Charusso added inline comments. Comment at: clang-tidy/bugprone/NotNullTerminatedResultCheck.cpp:226 +DiagnosticBuilder &Diag) { + if (getLangOpts().CPlusPlus11) { +StringRef NewFuncName = (Name[0] != 'w') ? "strncpy_s" : "wcsnc

[PATCH] D45050: [clang-tidy] New checker for not null-terminated result caused by strlen or wcslen

Charusso updated this revision to Diff 143698. Charusso marked an inline comment as done. Charusso added a comment. Changed CXX11 to C11 and made a little refactor. https://reviews.llvm.org/D45050 Files: clang-tidy/bugprone/BugproneTidyModule.cpp clang-tidy/bugprone/CMakeLists.txt clang-t

[PATCH] D45815: [libclang] Add options to limit skipping of function bodies

ilya-biryukov added inline comments. Comment at: include/clang/Frontend/ASTUnit.h:679 + struct SkipFunctionBodiesOptions { +SkipFunctionBodiesOptions() {} +enum { None, MainFileAndPreamble, Preamble } Scope = None; Default ctor will be generated automati

r330704 - [ASTImporter] Allow testing of import sequences; fix import of typedefs for anonymous decls

Author: a.sidorin Date: Tue Apr 24 03:11:53 2018 New Revision: 330704 URL: http://llvm.org/viewvc/llvm-project?rev=330704&view=rev Log: [ASTImporter] Allow testing of import sequences; fix import of typedefs for anonymous decls This patch introduces the ability to test an arbitrary sequence of i

[PATCH] D44079: [ASTImporter] Allow testing of import sequences; fix import of typedefs for anonymous decls

This revision was automatically updated to reflect the committed changes. a.sidorin marked an inline comment as done. Closed by commit rL330704: [ASTImporter] Allow testing of import sequences; fix import of typedefs for… (authored by a.sidorin, committed by ). Herald added a subscriber: llvm-comm

[PATCH] D45407: [StaticAnalyzer] Added notes to the plist output

Szelethus added a comment. Can someone commit this for me? I don't have a write access. Repository: rC Clang https://reviews.llvm.org/D45407 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[PATCH] D44435: CUDA ctor/dtor Module-Unique Symbol Name

SimeonEhrig updated this revision to Diff 143706. SimeonEhrig added a comment. Add a comment, which declares the need of a unique ctor/dotr name. https://reviews.llvm.org/D44435 Files: lib/CodeGen/CGCUDANV.cpp unittests/CodeGen/IncrementalProcessingTest.cpp Index: unittests/CodeGen/Increme

[PATCH] D45865: [Sema] Emit -Warray-bounds for multiple levels of subscript expressions.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D45865 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman

[PATCH] D45050: [clang-tidy] New checker for not null-terminated result caused by strlen or wcslen

aaron.ballman added inline comments. Comment at: clang-tidy/bugprone/NotNullTerminatedResultCheck.cpp:226 +DiagnosticBuilder &Diag) { + if (getLangOpts().CPlusPlus11) { +StringRef NewFuncName = (Name[0] != 'w') ? "strncpy_s" : "wcsncpy_s"; Charusso wrote

[PATCH] D41648: [clang-tidy] implement cppcoreguidelines macro rules

aaron.ballman added inline comments. Comment at: clang-tidy/cppcoreguidelines/MacroUsageCheck.cpp:77 +DiagnosticMessage = +"function like macro used; consider a (constexpr) template function"; + if (Info->isVariadic()) function like -> function-like

[PATCH] D45932: [clang-tidy][modernize-raw-string-literal] Don't replace upper ASCII with raw literals

aaron.ballman added inline comments. Comment at: clang-tidy/modernize/RawStringLiteralCheck.cpp:71 + // supported by specific code pages only. + if (Bytes.find_if_not(isASCII) != StringRef::npos) +return false; I am starting to think that this functionality

[PATCH] D45999: [clangd] Retrieve minimally formatted comment text in completion.

ilya-biryukov created this revision. ilya-biryukov added reviewers: sammccall, hokein, ioeric. Herald added subscribers: jkorous, MaskRay, klimek. Previous implementation used to extract brief text from doxygen comments. Brief text parsing slows down completion and is not suited for non-doxygen co

[PATCH] D46000: [AST] Added a helper to extract a user-friendly text of a comment.

ilya-biryukov created this revision. ilya-biryukov added reviewers: sammccall, hokein, ioeric. The helper is used in clangd for documentation shown in code completion and storing the docs in the symbols. See https://reviews.llvm.org/D45999. This patch reuses the code of the Doxygen comment lexer,

[PATCH] D46001: [CodeComplete] Expose helpers to get RawComment of completion result.

ilya-biryukov created this revision. ilya-biryukov added reviewers: sammccall, hokein, ioeric. Used in clangd, see https://reviews.llvm.org/D45999. Repository: rC Clang https://reviews.llvm.org/D46001 Files: include/clang/Sema/CodeCompleteConsumer.h lib/AST/RawCommentList.cpp lib/Sema/

[PATCH] D46002: [clangd] Parse all comments in Sema and completion.

ilya-biryukov created this revision. ilya-biryukov added reviewers: sammccall, hokein, ioeric. Herald added subscribers: jkorous, MaskRay, klimek. And add tests for the comment extraction code. clangd will now show non-doxygen comments in completion for results coming from Sema and Dynamic index.

[PATCH] D46003: [clang-tidy] Fix PR35468

xazax.hun created this revision. xazax.hun added a reviewer: alexfh. Herald added subscribers: dkrupp, rnkovacs, baloghadamsoftware, whisperity. Auto return type was not correctly considered by the Unconventional Assign Operator check. Repository: rCTE Clang Tools Extra https://reviews.llvm.

r330710 - [GCC] Don't keep a StringRef to a temporary std::string

Author: mstorsjo Date: Tue Apr 24 04:57:02 2018 New Revision: 330710 URL: http://llvm.org/viewvc/llvm-project?rev=330710&view=rev Log: [GCC] Don't keep a StringRef to a temporary std::string This fixes failures in asan builds and possibly other buildbots as well, after SVN r330696. Prior to that

[PATCH] D45722: [X86] Lowering SAD (sum of absolute differences) intrinsics to native IR (clang side)

mike.dvoretsky updated this revision to Diff 143715. mike.dvoretsky added a comment. Updated per comments. https://reviews.llvm.org/D45722 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/test/CodeGen/avx2-builtins.c clang/test/CodeGen/avx512bw-builtins.c clang/test/CodeGen/sse2-builtins.c

[PATCH] D38680: [libunwind] Fix handling of DW_CFA_GNU_args_size

mstorsjo added a comment. Herald added a subscriber: chrib. Ping @joerg and @rnk - what's a sensible path forward with respect to this? @rnk thinks this change is correct, while @joerg disagrees, but hasn't had time to look into it yet. Is it acceptable to apply this now and then revert later o

[PATCH] D45984: [X86] directstore and movdir64b intrinsics

GBuella updated this revision to Diff 143718. https://reviews.llvm.org/D45984 Files: docs/ClangCommandLineReference.rst include/clang/Basic/BuiltinsX86.def include/clang/Basic/BuiltinsX86_64.def include/clang/Driver/Options.td lib/Basic/Targets/X86.cpp lib/Basic/Targets/X86.h lib/He

[PATCH] D45932: [clang-tidy][modernize-raw-string-literal] Don't replace upper ASCII with raw literals

zinovy.nis added inline comments. Comment at: clang-tidy/modernize/RawStringLiteralCheck.cpp:71 + // supported by specific code pages only. + if (Bytes.find_if_not(isASCII) != StringRef::npos) +return false; aaron.ballman wrote: > I am starting to think tha

[PATCH] D45815: [libclang] Add options to limit skipping of function bodies

yvvan added inline comments. Comment at: include/clang/Frontend/ASTUnit.h:679 + struct SkipFunctionBodiesOptions { +SkipFunctionBodiesOptions() {} +enum { None, MainFileAndPreamble, Preamble } Scope = None; ilya-biryukov wrote: > Default ctor will be gen

[PATCH] D45932: [clang-tidy][modernize-raw-string-literal] Don't replace upper ASCII with raw literals

aaron.ballman added inline comments. Comment at: clang-tidy/modernize/RawStringLiteralCheck.cpp:71 + // supported by specific code pages only. + if (Bytes.find_if_not(isASCII) != StringRef::npos) +return false; zinovy.nis wrote: > aaron.ballman wrote: > > I

[PATCH] D45865: [Sema] Emit -Warray-bounds for multiple levels of subscript expressions.

ebevhan added a comment. Thank you! I do not have commit rights, so if someone could commit this that would be great. https://reviews.llvm.org/D45865 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/list

[PATCH] D45932: [clang-tidy][modernize-raw-string-literal] Don't replace upper ASCII with raw literals

zinovy.nis added inline comments. Comment at: clang-tidy/modernize/RawStringLiteralCheck.cpp:71 + // supported by specific code pages only. + if (Bytes.find_if_not(isASCII) != StringRef::npos) +return false; aaron.ballman wrote: > zinovy.nis wrote: > > aaro

[PATCH] D46007: [analyzer] Add `TaintBugVisitor` to the ArrayBoundV2, DivideZero and VLASize.

MTC created this revision. MTC added reviewers: NoQ, george.karpenkov, xazax.hun, a.sidorin. Herald added subscribers: cfe-commits, rnkovacs, szepet. Add `TaintBugVisitor` to the ArrayBoundV2, DivideZero, VLASize to be able to indicate where the taint information originated from. Repository:

[PATCH] D46003: [clang-tidy] Fix PR35468

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG with one comment. Comment at: test/clang-tidy/misc-unconventional-assign-operator.cpp:1 -// RUN: %check_clang_tidy %s misc-unconventional-assign-operator %t -- -- -std=c+

[PATCH] D45717: [clangd] Using index for GoToDefinition.

hokein updated this revision to Diff 143728. hokein marked 14 inline comments as done. hokein added a comment. Address review comments: - clarify the flow of go to definition. - simplify the test code. - some function move-out stuff. Repository: rCTE Clang Tools Extra https://reviews.llvm.or

[PATCH] D45717: [clangd] Using index for GoToDefinition.

hokein added a comment. Thanks for the useful comments! I refined the patch, and it becomes a bit larger (including some moving stuff). Comment at: clangd/XRefs.cpp:137 + +IdentifiedSymbol getSymbolAtPosition(ParsedAST &AST, SourceLocation Pos) { + auto DeclMacrosFinder = std

[PATCH] D45932: [clang-tidy][modernize-raw-string-literal] Don't replace upper ASCII with raw literals

aaron.ballman added inline comments. Comment at: clang-tidy/modernize/RawStringLiteralCheck.cpp:71 + // supported by specific code pages only. + if (Bytes.find_if_not(isASCII) != StringRef::npos) +return false; zinovy.nis wrote: > aaron.ballman wrote: > > z

[PATCH] D45887: [CodeComplete] Fix completion at the end of keywords

ilya-biryukov added inline comments. Comment at: lib/Lex/Lexer.cpp:1647 // looking up the identifier in the identifier table. IdentifierInfo *II = PP->LookUpIdentifierInfo(Result); sammccall wrote: > move this down to where it's used - it's ignored fo

[PATCH] D45839: [analyzer] Add support for WebKit "unified sources".

probinson added inline comments. Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/AnalysisManager.h:144 +// includes the full path. +if (SM.getFilename(IL).contains("UnifiedSource")) { + StringRef Name = SM.getFilename(SL); NoQ wrote: > N

[PATCH] D45887: [CodeComplete] Fix completion at the end of keywords

ilya-biryukov updated this revision to Diff 143731. ilya-biryukov marked 3 inline comments as done. ilya-biryukov added a comment. - Added comments - Fix nits in tests Repository: rC Clang https://reviews.llvm.org/D45887 Files: lib/Lex/Lexer.cpp test/CodeCompletion/end-of-ident-macro.cpp

[PATCH] D45965: [Targets] Implement getConstraintRegister for ARM and AArch64

miyuki updated this revision to Diff 143732. miyuki added a comment. Added a comment for getConstraintRegister https://reviews.llvm.org/D45965 Files: include/clang/Basic/TargetInfo.h lib/Basic/Targets/AArch64.h lib/Basic/Targets/ARM.h test/Sema/arm-asm.c test/Sema/arm64-inline-asm.c

r330717 - [CodeComplete] Fix completion at the end of keywords

Author: ibiryukov Date: Tue Apr 24 06:48:53 2018 New Revision: 330717 URL: http://llvm.org/viewvc/llvm-project?rev=330717&view=rev Log: [CodeComplete] Fix completion at the end of keywords Summary: Make completion behave consistently no matter if it is run at the start, in the middle or at the en

[PATCH] D45887: [CodeComplete] Fix completion at the end of keywords

This revision was automatically updated to reflect the committed changes. Closed by commit rL330717: [CodeComplete] Fix completion at the end of keywords (authored by ibiryukov, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D45887?vs=

[PATCH] D45965: [Targets] Implement getConstraintRegister for ARM and AArch64

thopre added inline comments. Comment at: lib/Basic/Targets/AArch64.h:85-89 + StringRef getConstraintRegister(StringRef Constraint, + StringRef Expression) const override { +return Expression; + } + miyuki wrote: > thopre wr

[PATCH] D45965: [Targets] Implement getConstraintRegister for ARM and AArch64

thopre added a comment. FWIW LGTM. https://reviews.llvm.org/D45965 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45884: [Sema] Fix parsing of anonymous union in language linkage specification

jkorous updated this revision to Diff 143736. jkorous added a comment. Addressed comments + proposal for refactoring of the namespace-related logic. https://reviews.llvm.org/D45884 Files: Sema/SemaDecl.cpp SemaCXX/anonymous-union-export.cpp SemaCXX/anonymous-union.cpp Index: SemaCXX/ano

[PATCH] D45815: [libclang] Add options to limit skipping of function bodies

nik marked 3 inline comments as done. nik added a comment. In https://reviews.llvm.org/D45815#1076434, @ilya-biryukov wrote: > In https://reviews.llvm.org/D45815#1073581, @nik wrote: > > > Hmm, that indicates that template function bodies are actually not that > > dominant, which I also haven't

[PATCH] D45815: [libclang] Add options to limit skipping of function bodies

nik updated this revision to Diff 143738. nik marked 2 inline comments as done. nik added a comment. Herald added a subscriber: eraman. Addressed inline comments. Repository: rC Clang https://reviews.llvm.org/D45815 Files: include/clang-c/Index.h include/clang/Frontend/ASTUnit.h includ

[PATCH] D45965: [Targets] Implement getConstraintRegister for ARM and AArch64

thopre accepted this revision. thopre added a comment. This revision is now accepted and ready to land. As I said, LGTM. Please wait a few days (say next Monday) in case anyone else has any objection. https://reviews.llvm.org/D45965 ___ cfe-commits

[clang-tools-extra] r330719 - [clang-tidy] Fix PR35468

Author: xazax Date: Tue Apr 24 07:45:58 2018 New Revision: 330719 URL: http://llvm.org/viewvc/llvm-project?rev=330719&view=rev Log: [clang-tidy] Fix PR35468 Differential Revision: https://reviews.llvm.org/D46003 Added: clang-tools-extra/trunk/test/clang-tidy/misc-unconventional-assign-opera

[PATCH] D46003: [clang-tidy] Fix PR35468

This revision was automatically updated to reflect the committed changes. Closed by commit rL330719: [clang-tidy] Fix PR35468 (authored by xazax, committed by ). Herald added subscribers: llvm-commits, klimek. Changed prior to commit: https://reviews.llvm.org/D46003?vs=143712&id=143743#toc Rep

r330721 - [OpenCL] Fix diagnostic of thread_local

Author: svenvh Date: Tue Apr 24 07:47:29 2018 New Revision: 330721 URL: http://llvm.org/viewvc/llvm-project?rev=330721&view=rev Log: [OpenCL] Fix diagnostic of thread_local Commit 08c258670c ("[OpenCL] Generic address space has been added in OpenCL v2.0.", 2014-11-26) did not mark the thread_loca

[PATCH] D42966: Fix USR generation in the presence of #line directives or linemarkes

mikhail.ramalho added a comment. ping. Repository: rC Clang https://reviews.llvm.org/D42966 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r330722 - [Attr] Print enum attributes at correct position

Author: jdenny Date: Tue Apr 24 07:50:23 2018 New Revision: 330722 URL: http://llvm.org/viewvc/llvm-project?rev=330722&view=rev Log: [Attr] Print enum attributes at correct position For example, given: void fn() { enum __attribute__((deprecated)) T *p; } -ast-print produced: void fn(

[PATCH] D36610: [Tooling] Add option to getFullyQualifiedName using a custom PritingPolicy

mikhail.ramalho marked an inline comment as done. mikhail.ramalho added a comment. ping. Comment at: unittests/Tooling/QualTypeNamesTest.cpp:225 + + TypeNameVisitor PrintingPolicy; + PrintingPolicy.ExpectedQualTypeNames["a"] = "short"; rnk wrote: > Please cho

[PATCH] D45456: [Attr] Print enum attributes at correct position

jdenny added a comment. Thanks. https://reviews.llvm.org/D45456 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45456: [Attr] Print enum attributes at correct position

This revision was automatically updated to reflect the committed changes. Closed by commit rL330722: [Attr] Print enum attributes at correct position (authored by jdenny, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D45456?vs=142672&

[PATCH] D45456: [Attr] Print enum attributes at correct position

This revision was automatically updated to reflect the committed changes. Closed by commit rC330722: [Attr] Print enum attributes at correct position (authored by jdenny, committed by ). Repository: rL LLVM https://reviews.llvm.org/D45456 Files: lib/AST/DeclPrinter.cpp test/Sema/ast-print

[PATCH] D46013: [ARM] Conform to AAPCS when passing overaligned composites as arguments

chill created this revision. chill added reviewers: john.brawn, olista01, eli.friedman, rengolin. Herald added a reviewer: javed.absar. Herald added subscribers: chrib, kristof.beyls. The "Procedure Call Procedure Call Standard for the ARM® Architecture" (https://static.docs.arm.com/ihi0042/f/IH

[PATCH] D44984: [HIP] Add hip input kind and codegen for kernel launching

yaxunl added a comment. ping https://reviews.llvm.org/D44984 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D46015: [OpenCL] Add separate read_only and write_only pipe IR types

stuart created this revision. stuart added reviewers: Anastasia, yaxunl. Herald added a subscriber: cfe-commits. SPIR-V encodes the read_only and write_only access qualifiers of pipes, so separate LLVM IR types are required to target SPIR-V. Other backends may also find this useful. These new ty

[PATCH] D44984: [HIP] Add hip input kind and codegen for kernel launching

rjmccall added a comment. Otherwise LGTM. Comment at: lib/CodeGen/CGCUDANV.cpp:51-52 llvm::Constant *getLaunchFn() const; + std::string addPrefixToName(CodeGenModule &CGM, StringRef FuncName) const; + std::string addUnderscoredPrefixToName(CodeGenModule &CGM, +

[PATCH] D42966: Fix USR generation in the presence of #line directives or linemarkes

ilya-biryukov added a comment. In https://reviews.llvm.org/D42966#1069674, @mikhail.ramalho wrote: > Sure. Basically, the previous code would not generate the USR for the > function's parameters. > > The issue was that SM.getFileEntryForID would return NULL because there is no > actual file, th

[PATCH] D42966: Fix USR generation in the presence of #line directives or linemarkes

ilya-biryukov added a comment. Sorry for the delay. In https://reviews.llvm.org/D42966#1069674, @mikhail.ramalho wrote: > Sure. Basically, the previous code would not generate the USR for the > function's parameters. > The issue was that SM.getFileEntryForID would return NULL because there is

[PATCH] D44882: [clangd] Implementation of workspace/symbol request

sammccall added a comment. In https://reviews.llvm.org/D44882#1066743, @malaperle wrote: > In https://reviews.llvm.org/D44882#1065632, @sammccall wrote: > > > In https://reviews.llvm.org/D44882#1065631, @malaperle wrote: > > > > > In https://reviews.llvm.org/D44882#1065622, @sammccall wrote: > >

[PATCH] D45470: Emit an error when mixing and

mclow.lists added inline comments. Comment at: clang/test/Headers/stdatomic.cpp:4 + +#include + Is there a reason we want to test this twice - once in clang and once in libc++? We can use `expected-error` in libc++ tests to check the error. https://reviews.ll

[PATCH] D46019: [ASTImporter] Fix isa cast assert

martong created this revision. martong added reviewers: a.sidorin, xazax.hun, szepet. Herald added subscribers: cfe-commits, dkrupp, rnkovacs. Do early return if we can't import the found decl for a member expr. This follows the pre-existing scheme, e.g with E->getMemberDecl(). Repository: rC

[PATCH] D34331: func.wrap.func.con: Unset function before destroying anything

mclow.lists accepted this revision. mclow.lists added a comment. Please move the tests into test/std and commit. https://reviews.llvm.org/D34331 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/c

[PATCH] D44882: [clangd] Implementation of workspace/symbol request

malaperle added a comment. In https://reviews.llvm.org/D44882#1076864, @sammccall wrote: > So this fails if there's no standard library available without flags, which > is the case in google's test environment to ensure hermeticity :-( > > In the short-term, we've disabled the test internally -

[PATCH] D45985: [test] Add a testcase for MinGW sysroot detections from SVN r330244. NFC.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Comment at: test/Driver/mingw-sysroot.cpp:1-2 +// REQUIRES: shell +// UNSUPPORTED: system-windows + Hah. :) Repository: rC Clang https://reviews.llvm.org

[PATCH] D46022: [OpenCL] Restrict various keywords in OpenCL C++ mode

svenvh created this revision. svenvh added reviewers: yaxunl, bader. Herald added subscribers: cfe-commits, Anastasia. Restrict the following keywords in the OpenCL C++ language mode, according to Section 2.9 of the OpenCL C++ 1.0 Specification. - dynamic_cast - typeid - goto - register (already

[PATCH] D45984: [X86] directstore and movdir64b intrinsics

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D45984 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

[PATCH] D45722: [X86] Lowering SAD (sum of absolute differences) intrinsics to native IR (clang side)

craig.topper added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:8425 + llvm::Type *VTy = llvm::VectorType::get(QTy, N); + llvm::Type *BTy = llvm::VectorType::get(CGF.Builder.getInt8Ty(), N * 8); + SmallVector ShuffleMask; Is this not a dead var

[PATCH] D46019: [ASTImporter] Fix isa cast assert

a.sidorin accepted this revision. a.sidorin added a comment. This revision is now accepted and ready to land. This LGTM, but could you please add a test? Repository: rC Clang https://reviews.llvm.org/D46019 ___ cfe-commits mailing list cfe-commit

[PATCH] D45532: [StaticAnalyzer] Checker to find uninitialized fields after a constructor call

Szelethus added a comment. I'd also like to point out that as I mentioned before, the checker's name itself is misleading (it is a leftover from an earlier implementation of this checker). Here are just some ideas I came up with: - UninitializedObjectChecker - UninitializedFieldsChecker - Unin

[PATCH] D44387: [x86] Introduce the pconfig/encl[u|s|v] intrinsics

craig.topper added a comment. I see that gcc implements all of this with wrappers around inline assembly. Any reason we couldn't just do that? Comment at: lib/Headers/pconfigintrin.h:31 + +#define MKTME_KEY_PROGRAM 0x0001 + This doesn't match the name used

[PATCH] D46007: [analyzer] Add `TaintBugVisitor` to the ArrayBoundV2, DivideZero and VLASize.

a.sidorin added a comment. Mostly LG. Comment at: lib/StaticAnalyzer/Checkers/VLASizeChecker.cpp:75 auto report = llvm::make_unique(*BT, os.str(), N); + report->addVisitor(std::move(Visitor)); report->addRange(SizeE->getSourceRange()); In this patch, som

[PATCH] D46022: [OpenCL] Restrict various keywords in OpenCL C++ mode

rjmccall added a comment. I'm not sure that doing this in the lexer is appropriate; you should just diagnose the unsupported feature in Sema, or at best the parser. Repository: rC Clang https://reviews.llvm.org/D46022 ___ cfe-commits mailing lis

[PATCH] D45921: Add getDeserializationListener to ASTReader

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. This seems fine, but I wonder if we should expose a mechanism that will create a multiplex listener automatically as needed? https://reviews.llvm.org/D45921 ___

[PATCH] D45179: [libc++] Add _LIBCPP_FORCE_NODISCARD define to force-enable nodiscard in pre-C++17

mclow.lists added a comment. In https://reviews.llvm.org/D45179#1056183, @rjmccall wrote: > Is Marshall arguing that the standard doesn't allow compilers to warn about > failing to use these function results prior to C++17? Because I don't think > that's true; warnings are thoroughly non-norma

Re: [PATCH] D45179: [libc++] Add _LIBCPP_FORCE_NODISCARD define to force-enable nodiscard in pre-C++17

So you're happy with this opt-in version? On Tue, Apr 24, 2018 at 1:29 PM, Marshall Clow via Phabricator via cfe-commits wrote: > mclow.lists added a comment. > > In https://reviews.llvm.org/D45179#1056183, @rjmccall wrote: > > > Is Marshall arguing that the standard doesn't allow compilers to w

[PATCH] D44435: CUDA ctor/dtor Module-Unique Symbol Name

tra added inline comments. Comment at: lib/CodeGen/CGCUDANV.cpp:287 +CtorSuffix.append("_"); +CtorSuffix.append(ModuleName); + } SimeonEhrig wrote: > tra wrote: > > There is a general problem with this approach. File name can contain the > > characters

r330744 - [X86] Add recently added intrinsic headers to the module map.

Author: ctopper Date: Tue Apr 24 10:40:49 2018 New Revision: 330744 URL: http://llvm.org/viewvc/llvm-project?rev=330744&view=rev Log: [X86] Add recently added intrinsic headers to the module map. Modified: cfe/trunk/lib/Headers/module.modulemap Modified: cfe/trunk/lib/Headers/module.modulema

r330743 - [X86] Consistently use double underscore at the beginning of the include guards in our intrinsic headers.

Author: ctopper Date: Tue Apr 24 10:40:47 2018 New Revision: 330743 URL: http://llvm.org/viewvc/llvm-project?rev=330743&view=rev Log: [X86] Consistently use double underscore at the beginning of the include guards in our intrinsic headers. Most files used double underscore, but a few used single

r330745 - [HWASan] Update HWASan assembly snippet in the docs

Author: alekseyshl Date: Tue Apr 24 10:41:48 2018 New Revision: 330745 URL: http://llvm.org/viewvc/llvm-project?rev=330745&view=rev Log: [HWASan] Update HWASan assembly snippet in the docs Summary: To complement https://reviews.llvm.org/D45840 Reviewers: eugenis Subscribers: cfe-commits Differ

[PATCH] D45996: [HWASan] Update HWASan assembly snippet in the docs

This revision was automatically updated to reflect the committed changes. Closed by commit rL330745: [HWASan] Update HWASan assembly snippet in the docs (authored by alekseyshl, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D45996 Files:

[PATCH] D45891: [clang-tidy] Improve bugprone-unused-return-value check

khuttun added a comment. Could someone help getting this merged? I don't have commit access to the repo. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45891 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.

[PATCH] D45996: [HWASan] Update HWASan assembly snippet in the docs

This revision was automatically updated to reflect the committed changes. Closed by commit rC330745: [HWASan] Update HWASan assembly snippet in the docs (authored by alekseyshl, committed by ). Changed prior to commit: https://reviews.llvm.org/D45996?vs=143671&id=143782#toc Repository: rL LL

[PATCH] D45179: [libc++] Add _LIBCPP_FORCE_NODISCARD define to force-enable nodiscard in pre-C++17

rjmccall added a comment. In https://reviews.llvm.org/D45179#1077048, @mclow.lists wrote: > In https://reviews.llvm.org/D45179#1056183, @rjmccall wrote: > > > Is Marshall arguing that the standard doesn't allow compilers to warn about > > failing to use these function results prior to C++17? Be

[PATCH] D44984: [HIP] Add hip input kind and codegen for kernel launching

tra added inline comments. Comment at: lib/CodeGen/CGCUDANV.cpp:51-52 llvm::Constant *getLaunchFn() const; + std::string addPrefixToName(CodeGenModule &CGM, StringRef FuncName) const; + std::string addUnderscoredPrefixToName(CodeGenModule &CGM, +

[PATCH] D45179: [libc++] Add _LIBCPP_FORCE_NODISCARD define to force-enable nodiscard in pre-C++17

mclow.lists added a comment. In https://reviews.llvm.org/D45179#1077055, @thakis wrote: > So you're happy with this opt-in version? I'm happy with an opt-in mechanism, yes. This one is not quite right yet. BTW, I expect a //large// set of calls in the standard library to get marked as `[[nodi

[PATCH] D45964: [Driver] Fix implicit config files from prefixed symlinks

sepavloff accepted this revision. sepavloff added a comment. This revision is now accepted and ready to land. Thank you for fixing this issue! LGTM Comment at: lib/Driver/Driver.cpp:132 ArrayRef Args) { - ClangNameParts = ToolChain::getTargetAndM

  1   2   >