ro added a comment.
In https://reviews.llvm.org/D40903#998474, @alekseyshl wrote:
> Rainer, check https://reviews.llvm.org/rC324302 out, you probably want to add
> test cases for Solaris to test/Driver/sanitizer-ld.c too.
Sorry about that! I certainly will, but it'll be some time because I'm
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D42918
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
ioeric added a comment.
looks good
Comment at: clangd/index/Index.h:25
struct SymbolLocation {
// The absolute path of the source file where a symbol occurs.
It might be worth mentioning here whether the range covers the entire
declaration/definition bod
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42947
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
hokein added a comment.
I like where the patch is going now.
Comment at: clangd/global-symbol-builder/GlobalSymbolBuilderMain.cpp:67
+ // XXX this is just to make running the tool fast during dev!
+ bool BeginInvocation(CompilerInstance &CI) override {
+const
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
LGTM
Have we kept a lit test that uses content-length? It's unclear from the patch.
Comment at: clangd/tool/ClangdMain.cpp:89
+static llvm::cl::opt Test(
+"test",
+l
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
lg
Comment at: clangd/index/SymbolCollector.cpp:132
+// * symbols controlled and defined by a compile command-line option
+// `-DName=foo`, the spelling locatio
hokein updated this revision to Diff 132956.
hokein edited the summary of this revision.
hokein added a comment.
Fix a typo
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42913
Files:
clangd/index/SymbolCollector.cpp
unittests/clangd/SymbolCollectorTests.cpp
Index: unitte
Author: hokein
Date: Tue Feb 6 01:50:35 2018
New Revision: 324328
URL: http://llvm.org/viewvc/llvm-project?rev=324328&view=rev
Log:
[clangd] Fix incorrect file path for symbols defined by the compile
command-line option.
Summary:
Reviewers: ioeric
Reviewed By: ioeric
Subscribers: klimek, ily
This revision was automatically updated to reflect the committed changes.
Closed by commit rL324328: [clangd] Fix incorrect file path for symbols defined
by the compile command… (authored by hokein, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.ll
Merged in r324329.
On Wed, Jan 31, 2018 at 9:05 PM, Mark Zeren via cfe-commits
wrote:
> Author: mzeren-vmw
> Date: Wed Jan 31 12:05:50 2018
> New Revision: 323904
>
> URL: http://llvm.org/viewvc/llvm-project?rev=323904&view=rev
> Log:
> [clang-format] Align preprocessor comments with #
>
> Summar
Merged to 6.0 in r324331.
On Mon, Feb 5, 2018 at 4:59 PM, Mark Zeren via cfe-commits
wrote:
> Author: mzeren-vmw
> Date: Mon Feb 5 07:59:00 2018
> New Revision: 324246
>
> URL: http://llvm.org/viewvc/llvm-project?rev=324246&view=rev
> Log:
> [clang-format] Re-land: Fixup #include guard indents a
FireBurn added a comment.
This breaks compilation for me on Gentoo's clang-.ebuild
The following patch fixes things for me
commit a4c071b16bbbc84bbb96d90b51bed8a12127 (HEAD -> master)
Author: Mike Lothian
Date: Tue Feb 6 09:55:41 2018 +
[clangd] Fix include to use C
ioeric added inline comments.
Comment at: clangd/index/Index.h:27
+ // The URI of the source file where a symbol occurs.
+ llvm::StringRef FileUri;
// The 0-based offset to the first character of the symbol from the beginning
sammccall wrote:
> nit: FileURI?
ioeric updated this revision to Diff 132958.
ioeric marked 2 inline comments as done.
ioeric added a comment.
- Make URIScheme customizable in SymbolCollector.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42915
Files:
clangd/index/Index.cpp
clangd/index/Index.h
clangd/i
ioeric added a comment.
I was thinking about leaving URI scheme customization to the postprocessing
phase, but you are right, it would be better to make the URI scheme extendable
in SymbolCollector.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42915
__
a.sidorin added a comment.
Hello David,
I have looked into mmap constant definitions in different implementations and
found them pretty inconsistent. For example, MMAP_EXEC can be 0x01, 0x04 and I
even found 0x00 in some file
(https://www.cs.cmu.edu/~dga/crypto/priveth/libethash/mmap.h). There
devnexen added a comment.
In https://reviews.llvm.org/D42645#998732, @a.sidorin wrote:
> Hello David,
>
> I have looked into mmap constant definitions in different implementations and
> found them pretty inconsistent. For example, MMAP_EXEC can be 0x01, 0x04 and
> I even found 0x00 in some file
sammccall added a comment.
Great, this all makes sense. I think we can/should make the scheme selection a
bit more robust (we shouldn't crash if we get unexpected filenames).
And... Uri or URI (I really think this is a usability issue - i had a scarring
experience with a codebase that couldn't d
hokein added inline comments.
Comment at: clangd/index/Index.h:27
+ // The URI of the source file where a symbol occurs.
+ llvm::StringRef FileUri;
// The 0-based offset to the first character of the symbol from the beginning
sammccall wrote:
> ioeric wrote:
sammccall marked an inline comment as done.
sammccall added a comment.
In https://reviews.llvm.org/D42919#998695, @ioeric wrote:
> LGTM
>
> Have we kept a lit test that uses content-length? It's unclear from the patch.
Yes, `protocol.test` tests the real protocol parser. (The other tests that u
sammccall updated this revision to Diff 132960.
sammccall marked an inline comment as done.
sammccall added a comment.
-test -> -lit-test
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42919
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdLSPServer.h
clangd/JSONRPCDispatch
ioeric added inline comments.
Comment at: clangd/index/Index.h:27
+ // The URI of the source file where a symbol occurs.
+ llvm::StringRef FileUri;
// The 0-based offset to the first character of the symbol from the beginning
hokein wrote:
> sammccall wrote:
Author: sammccall
Date: Tue Feb 6 02:51:22 2018
New Revision: 324334
URL: http://llvm.org/viewvc/llvm-project?rev=324334&view=rev
Log:
[clangd] Cut input-mirror.test down to size. NFC
Modified:
clang-tools-extra/trunk/test/clangd/input-mirror.test
Modified: clang-tools-extra/trunk/test/clan
Typz updated this revision to Diff 132963.
Typz added a comment.
Split the option into 3 separate options: SpaceBeforeCtorInitializerColon,
SpaceBeforeInheritanceColon and SpaceBeforeRangeBasedForLoopColon.
This makes each option clearer and more consistent, with no ambiguities due to
interracti
krasimir updated this revision to Diff 132964.
krasimir marked an inline comment as done.
krasimir added a comment.
- Address review comments
Repository:
rC Clang
https://reviews.llvm.org/D42727
Files:
lib/Format/ContinuationIndenter.cpp
lib/Format/FormatToken.h
lib/Format/TokenAnnotat
Athosvk added a comment.
As we had discussed before, we're interested in the development as well! As an
overall comment, I speak from experience that maintaining a large degree of
documentation throughout the source code of the tool can provide an excellent
test-case.
We sure hope this will mo
djasper added a comment.
You still haven't addressed my comment about there not being a publicly
accessible style guide recommending these.
https://reviews.llvm.org/D32525
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.or
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Looks good.
Repository:
rC Clang
https://reviews.llvm.org/D42727
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.o
Athosvk added inline comments.
Comment at: tools/clang-doc/ClangDocReporter.h:39
// Info for named types (parameters, members).
struct NamedType {
std::string Type;
Storing the type information seems more suitable than storing just the name and
type as a st
ilya-biryukov updated this revision to Diff 132967.
ilya-biryukov marked 21 inline comments as done.
ilya-biryukov added a comment.
- Renamed File to AST.
- Introduced startTask().
- Moved small methods of ASTWorkerHandle to have inline definitions.
- Removed constructor of FileData.
- Replaced fi
ilya-biryukov added inline comments.
Comment at: clangd/ASTWorker.cpp:102
+ // not waste time on it.
+ LastUpdateCF->cancel();
+}
sammccall wrote:
> ilya-biryukov wrote:
> > sammccall wrote:
> > > This strategy has some upsides:
> > > - we eventual
Author: krasimir
Date: Tue Feb 6 03:34:34 2018
New Revision: 324337
URL: http://llvm.org/viewvc/llvm-project?rev=324337&view=rev
Log:
[clang-format] Adds space around angle brackets in text protos
Summary:
This patch adds spaces around angle brackets in text proto Google style.
Previously these
This revision was automatically updated to reflect the committed changes.
Closed by commit rL324337: [clang-format] Adds space around angle brackets in
text protos (authored by krasimir, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D4272
krasimir accepted this revision.
krasimir added a comment.
This revision is now accepted and ready to land.
Try committing it now!
Repository:
rC Clang
https://reviews.llvm.org/D42901
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:/
devnexen updated this revision to Diff 132969.
Herald added a subscriber: emaste.
Repository:
rC Clang
https://reviews.llvm.org/D42645
Files:
include/clang/StaticAnalyzer/Checkers/Checkers.td
lib/Driver/ToolChains/FreeBSD.cpp
lib/StaticAnalyzer/Checkers/CMakeLists.txt
lib/StaticAnalyze
miyuki added a comment.
ping
https://reviews.llvm.org/D42545
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
miyuki added a comment.
ping^3
https://reviews.llvm.org/D41992
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
xazax.hun added a comment.
Overall looks good. Was this tested on large software? I would also be grateful
if you could run the regression tests with templight always being enabled to
see if they uncover any assertions/crashes.
Comment at: include/clang/Driver/CC1Options.td:5
rogfer01 added a comment.
I understand you're fixing the narrowing check from "unscoped enum/integer
type" → float.
But you have also extended some tests which are "unscoped enum" → integer type
(lines 153, 170 and 173). So I presume they were already handled correctly
before your patch. Can t
This revision was automatically updated to reflect the committed changes.
Closed by commit rL324338: Test commit - fixing a comment. (authored by
jolesiak, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D42901
Files:
cfe/trunk/lib/Forma
It probably tries doing a standalone build of clang without LLVM.
clang/config.h doesn't seem to include the HAVE_PTHREAD_GETSPECIFIC used in
Context.cpp.
We can either add the corresponding macro to clang's config.h or follow
jyknight's suggestions and figure out if we can remove pthread-specific
Author: dfukalov
Date: Sun Feb 4 14:32:07 2018
New Revision: 324201
URL: http://llvm.org/viewvc/llvm-project?rev=324201&view=rev
Log:
Recommit rL323890: [AMDGPU] Add ds_fadd, ds_fmin, ds_fmax builtins functions
Fixed asserts in tests.
Modified:
cfe/trunk/include/clang/Basic/BuiltinsAMDGPU.d
Author: jolesiak
Date: Tue Feb 6 04:12:00 2018
New Revision: 324338
URL: http://llvm.org/viewvc/llvm-project?rev=324338&view=rev
Log:
Test commit - fixing a comment.
Summary: A test commit.
Reviewers: krasimir, benhamilton
Reviewed By: krasimir
Subscribers: klimek, cfe-commits
Differential R
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, aside from a minor commenting nit.
Comment at: lib/Sema/SemaChecking.cpp:8960
+// Avoid warning about comparison of integers with different signs when
aaron.ballman added a comment.
It sounds to me like the check is working as designed and that the user code
was already broken, but it happened to work at runtime because the stars
aligned properly for the user. Am I misunderstanding something?
Repository:
rC Clang
https://reviews.llvm.org/
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
This is really great. Just one test nit.
Comment at: unittests/clangd/ThreadingTests.cpp:34
+
+scheduleIncrements();
+Tasks.waitForAll();
The c
Author: sylvestre
Date: Tue Feb 6 05:12:29 2018
New Revision: 324342
URL: http://llvm.org/viewvc/llvm-project?rev=324342&view=rev
Log:
Unittests misc. typos
By luz.paz
Modified:
cfe/trunk/unittests/Format/CleanupTest.cpp
cfe/trunk/unittests/Rename/RenameMemberTest.cpp
cfe/trunk/un
miyuki updated this revision to Diff 132974.
miyuki added a comment.
Removed the changes that are unrelated to the 'enum->float' case from the test.
https://reviews.llvm.org/D42545
Files:
lib/Sema/SemaOverload.cpp
test/CXX/dcl.decl/dcl.init/dcl.init.list/p7-0x.cpp
Index: test/CXX/dcl.decl
This revision was automatically updated to reflect the committed changes.
Closed by commit rC324344: [Solaris] Silence -pthread warning on Solaris
(authored by fedor.sergeev, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D41242
Files:
lib/Driver/ToolChains/Solaris.cpp
Inde
Author: fedor.sergeev
Date: Tue Feb 6 05:21:12 2018
New Revision: 324344
URL: http://llvm.org/viewvc/llvm-project?rev=324344&view=rev
Log:
[Solaris] Silence -pthread warning on Solaris
Summary:
During make check-all on Solaris, I see several instances of this warning:
clang-6.0: warning: argume
Author: hans
Date: Tue Feb 6 05:22:33 2018
New Revision: 324345
URL: http://llvm.org/viewvc/llvm-project?rev=324345&view=rev
Log:
Merging r324153:
r324153 | ericwf | 2018-02-02 23:39:59 +0100 (Fri, 02 Feb 2018) | 6 lines
Fi
Merged to 6.0 in r324345.
On Fri, Feb 2, 2018 at 11:39 PM, Eric Fiselier via cfe-commits
wrote:
> Author: ericwf
> Date: Fri Feb 2 14:39:59 2018
> New Revision: 324153
>
> URL: http://llvm.org/viewvc/llvm-project?rev=324153&view=rev
> Log:
> Fix has_unique_object_representation after Clang commi
krasimir created this revision.
Herald added subscribers: cfe-commits, klimek.
This patch is a follow-up to r323319 (which disables string literal breaking for
text protos) and it disables breaking before long string literals.
For example this:
key: "long string literal"
used to get broke
krasimir updated this revision to Diff 132978.
krasimir added a comment.
- Update comment
Repository:
rC Clang
https://reviews.llvm.org/D42957
Files:
lib/Format/ContinuationIndenter.cpp
lib/Format/Format.cpp
lib/Format/TokenAnnotator.cpp
unittests/Format/FormatTestProto.cpp
unittes
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG
Comment at: clang-tidy/modernize/AvoidFunctionalCheck.h:19
+
+/// Check for several deprecated types and classes from header
+///
aaron.ballman wrote:
>
sammccall updated this revision to Diff 132985.
sammccall marked 3 inline comments as done.
sammccall added a comment.
[clangd] Prefer data from TUs with symbol defn to data from TUs without.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42942
Files:
clangd/global-symbol-bui
sammccall added a comment.
Thanks for comments! (Still not done, adding tests)
Comment at: clangd/global-symbol-builder/GlobalSymbolBuilderMain.cpp:67
+ // XXX this is just to make running the tool fast during dev!
+ bool BeginInvocation(CompilerInstance &CI) override
jhenderson added a comment.
In https://reviews.llvm.org/D42758#997880, @erichkeane wrote:
> I'd like to see @probinson s PS4 discussion bottom out, but I don't see any
> reason to hold this up otherwise.
The PS4 compiler uses its linker options mechanism to communicate three
different things
aaron.ballman requested changes to this revision.
aaron.ballman added a comment.
This revision now requires changes to proceed.
A few comments were not applied, and I'd like a more descriptive name for the
check (especially if we plan to generalize this).
Comment at: clang-tid
Author: sammccall
Date: Tue Feb 6 06:25:02 2018
New Revision: 324351
URL: http://llvm.org/viewvc/llvm-project?rev=324351&view=rev
Log:
[clangd] Don't try pthread, just use thread_local. Reverts r323949.
The pthread solution here breaks standalone builds, which don't have the
relevant cmake magic
alexfh added inline comments.
Comment at: clang-tidy/modernize/ModernizeTidyModule.cpp:50
+CheckFactories.registerCheck(
+"modernize-avoid-functional");
CheckFactories.registerCheck(
aaron.ballman wrote:
> I'm not keen on this name -- it suggests
robot updated this revision to Diff 132990.
robot added a comment.
- Reformatted using clang-format
- Fixed copy&waste error CHECK(REAL(__cxa_throw))
- moved test from asan unit test to lit tests
Repository:
rCRT Compiler Runtime
https://reviews.llvm.org/D42644
Files:
lib/asan/asan_interce
aaron.ballman added inline comments.
Comment at: clang-tidy/modernize/ModernizeTidyModule.cpp:50
+CheckFactories.registerCheck(
+"modernize-avoid-functional");
CheckFactories.registerCheck(
alexfh wrote:
> aaron.ballman wrote:
> > I'm not keen on
hokein created this revision.
hokein added reviewers: sammccall, ioeric.
Herald added subscribers: jkorous-apple, ilya-biryukov, klimek.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42964
Files:
clangd/global-symbol-builder/GlobalSymbolBuilderMain.cpp
clangd/index/Index.cpp
sammccall added a comment.
Discussed offline a bit: it's not clear that this field is going to be
generally useful - we don't have a plan to read this from open-source code.
(Google's internal index wants to be able to individually version symbols for
distributed-system reasons, but we can add t
Author: ioeric
Date: Tue Feb 6 07:27:43 2018
New Revision: 324354
URL: http://llvm.org/viewvc/llvm-project?rev=324354&view=rev
Log:
[clangd] Remove unused variable. NFC
Modified:
clang-tools-extra/trunk/clangd/JSONRPCDispatcher.cpp
Modified: clang-tools-extra/trunk/clangd/JSONRPCDispatcher.
mikhail.ramalho created this revision.
mikhail.ramalho added reviewers: arphaman, rsmith.
Herald added a subscriber: cfe-commits.
Small change on how the USRGen code prints the location.
The patch fixes an issue when there are #line directives or linemarkes in the
file, e.g.:
#line 3
int Fu
ioeric updated this revision to Diff 133000.
ioeric added a comment.
- s/Uri/URI/
- Address review comments. Support multiple schemes.
- Merged with origin/master
- Merge branch 'master' of http://llvm.org/git/clang-tools-extra into uri
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.
miyuki created this revision.
miyuki added reviewers: faisalv, rsmith.
miyuki edited the summary of this revision.
According to the C++11 standard [dcl.type.simple]p4:
The type denoted by decltype(e) is defined as follows:
- if e is an unparenthesized id-expression or an unparenthesized
c
ilya-biryukov updated this revision to Diff 133003.
ilya-biryukov added a comment.
- Addressed the last review comment
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42573
Files:
clangd/CMakeLists.txt
clangd/ClangdServer.h
clangd/ClangdUnit.h
clangd/ClangdUnitStore.cpp
Author: ibiryukov
Date: Tue Feb 6 07:53:42 2018
New Revision: 324356
URL: http://llvm.org/viewvc/llvm-project?rev=324356&view=rev
Log:
[clangd] The new threading implementation
Summary:
In the new threading model clangd creates one thread per file to manage
the AST and one thread to process each
This revision was automatically updated to reflect the committed changes.
Closed by commit rL324356: [clangd] The new threading implementation (authored
by ibiryukov, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D42573
Files:
clang-to
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: unittests/clangd/SymbolCollectorTests.cpp:280
runSymbolCollector(Header.code(), /*Main=*/"");
- EXPECT_THAT(Symbols,
- UnorderedElement
karies added a comment.
Does this qualify?
https://github.com/root-project/root/blob/master/.clang-format#L84
# You want this : enable it if you have https://reviews.llvm.org/D32525
# SpaceBeforeColon: false
in ROOT's `.clang-format`.
https://reviews.llvm.org/D32525
___
devnexen updated this revision to Diff 133008.
devnexen added a comment.
Both Linux/Darwin unit tests passed.
Repository:
rC Clang
https://reviews.llvm.org/D42645
Files:
include/clang/StaticAnalyzer/Checkers/Checkers.td
lib/Driver/ToolChains/FreeBSD.cpp
lib/StaticAnalyzer/Checkers/CMak
ioeric updated this revision to Diff 133009.
ioeric added a comment.
- removed leftover logs.
- Merge branch 'master' of http://llvm.org/git/clang-tools-extra into uri
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42915
Files:
clangd/index/Index.cpp
clangd/index/Index.h
Author: ioeric
Date: Tue Feb 6 08:10:35 2018
New Revision: 324358
URL: http://llvm.org/viewvc/llvm-project?rev=324358&view=rev
Log:
[clangd] Use URIs in index symbols.
Reviewers: hokein, sammccall
Reviewed By: sammccall
Subscribers: klimek, ilya-biryukov, jkorous-apple, cfe-commits
Differenti
devnexen updated this revision to Diff 133010.
devnexen added a comment.
Will work on most modern Linux/Glibc versions, BSD variants and Illumos.
Repository:
rC Clang
https://reviews.llvm.org/D42645
Files:
include/clang/StaticAnalyzer/Checkers/Checkers.td
lib/Driver/ToolChains/FreeBSD.cp
sabel83 added a comment.
This pull requests consists of two parts:
a) a hook, which is called during template instantiation events
b) a callback, which dumps the details of the events out to standard output
Tools like Templight (https://github.com/mikael-s-persson/templight) rely on
the hook.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL324358: [clangd] Use URIs in index symbols. (authored by
ioeric, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D42915
Files:
clang-tools-extra
djasper added a comment.
No. The reason for us generally asking for a style guide is because it
unambiguously clarifies the exact style that is to be preferred. Projects that
don't have a style guide written down also often do not agree on what the style
should be.
That said, I think the style
sabel83 marked an inline comment as done.
sabel83 added inline comments.
Comment at: include/clang/Driver/CC1Options.td:537
+def templight_dump : Flag<["-"], "templight-dump">,
+ HelpText<"Dump templight information to stdout">;
def ast_dump_lookups : Flag<["-"], "ast-dump-look
devnexen added a comment.
Repository:
rC Clang
https://reviews.llvm.org/D42645
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ibiryukov
Date: Tue Feb 6 08:32:36 2018
New Revision: 324361
URL: http://llvm.org/viewvc/llvm-project?rev=324361&view=rev
Log:
[clangd] Fixed compilation on Windows buildbot.
Modified:
clang-tools-extra/trunk/unittests/clangd/ThreadingTests.cpp
Modified: clang-tools-extra/trunk/unit
bsdjhb created this revision.
Herald added subscribers: krytarowski, arichardson, sdardis, emaste.
FreeBSD N64 MIPS systems can include 32-bit libraries for O32 in
/usr/lib32 similar to the 32-bit compatibility libraries provided
for FreeBSD/amd64 and FreeBSD/powerpc64.
Repository:
rC Clang
h
ioeric updated this revision to Diff 133021.
ioeric marked 10 inline comments as done.
ioeric added a comment.
- Merge with origin/master
- Renamed and moved a bunch files according to review comments.
- Merge remote-tracking branch 'origin/master' into include
- Half way
- Merge with uri changes.
ioeric added a comment.
Thanks for the comments! I addressed comments in the symbol collect part (I
think?). Will add tests in a followup patch.
Comment at: clangd/index/HeaderMapCollector.h:48
+ // A map from header patterns to header names.
+ // The header names are not ow
ioeric added a comment.
Thanks for the comments! I have addressed comments in the symbol collect side
(I think?). Will add tests in a followup patch.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42640
___
cfe-commits mailing list
dim accepted this revision.
dim added a comment.
This revision is now accepted and ready to land.
LGTM, though a test case would be nice (could be added to
`tools/clang/test/Driver/freebsd.c`)
Repository:
rC Clang
https://reviews.llvm.org/D42972
___
sammccall updated this revision to Diff 133024.
sammccall added a comment.
Add tests for SymbolCollector (finding def/decl locations) and merge.
Found some bugs in SymbolCollector's locations - added fixmes.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42942
Files:
clangd/
sammccall added a comment.
OK, I think this is good to go now. Rebased against Eric's URI change and added
tests.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42942
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://l
compnerd added a comment.
@jhenderson I believe that the first one is what this is implementing. I
believe that adding the last two as a patch following this one is preferable as
that is specific to the needs for PS4, but, both of those should be possible to
accommodate. I would love to see a
massberg updated this revision to Diff 133027.
massberg edited the summary of this revision.
massberg added a comment.
Addressed comments and renamed test to modernize-deprecated-functional
https://reviews.llvm.org/D42730
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/Depre
mattd added inline comments.
Comment at: lib/Sema/SemaStmt.cpp:2346
+// Assume the variables are nested in the inner scope (loop body).
+const auto DepthStr = std::to_string(S->getDepth() >> 1);
VarDecl *BeginVar = BuildForRangeVarDecl(*this, ColonLoc, AutoType,
Author: george.karpenkov
Date: Tue Feb 6 09:22:09 2018
New Revision: 324362
URL: http://llvm.org/viewvc/llvm-project?rev=324362&view=rev
Log:
[analyzer] [tests] Show function name in CmpRuns output
Combined with enabled flag for stable filenames, this greatly simplifies
finding the offending rep
Author: ibiryukov
Date: Tue Feb 6 09:22:58 2018
New Revision: 324363
URL: http://llvm.org/viewvc/llvm-project?rev=324363&view=rev
Log:
[clangd] Fixed a bug in the new threading implementation.
This should fix the buildbots.
Modified:
clang-tools-extra/trunk/clangd/Threading.cpp
Modified: c
massberg marked 4 inline comments as done.
massberg added a comment.
Thanks for the comments!
I double-checked that the renaming went well and hope that I haven't missed
anything this time ...
https://reviews.llvm.org/D42730
___
cfe-commits mailing
Typz added a comment.
Indeed, I have yet find more precisely documented coding rules which require
this format, but I thought I could at least address the non-precise aspect of
the patch itself in the mean-time.
https://reviews.llvm.org/D32525
___
compnerd updated this revision to Diff 133030.
compnerd added a comment.
Add additional test, update docs
Repository:
rC Clang
https://reviews.llvm.org/D42758
Files:
docs/LanguageExtensions.rst
lib/CodeGen/CodeGenModule.cpp
lib/CodeGen/CodeGenModule.h
lib/Parse/ParsePragma.cpp
test
1 - 100 of 201 matches
Mail list logo
