[PATCH] D37897: [StaticAnalyzer] Fix ProgramState for static variables that are not written

danielmarjamaki updated this revision to Diff 117956. danielmarjamaki added a comment. Herald added a subscriber: szepet. Fixes according to review comments. Reuse ast matchers in LoopUnrolling.cpp. Avoid some recursion (however the isChanged() is still recursive but it is very small and simple)

r315045 - [CodeGen] Emit a helper function for __builtin_os_log_format to reduce

Author: ahatanak Date: Fri Oct 6 00:12:46 2017 New Revision: 315045 URL: http://llvm.org/viewvc/llvm-project?rev=315045&view=rev Log: [CodeGen] Emit a helper function for __builtin_os_log_format to reduce code size. Currently clang expands a call to __builtin_os_log_format into a long sequence o

[PATCH] D38606: [CodeGen] Emit a helper function for __builtin_os_log_format to reduce code size

This revision was automatically updated to reflect the committed changes. Closed by commit rL315045: [CodeGen] Emit a helper function for __builtin_os_log_format to reduce (authored by ahatanak). Changed prior to commit: https://reviews.llvm.org/D38606?vs=117955&id=117957#toc Repository: rL

[PATCH] D37897: [StaticAnalyzer] Fix ProgramState for static variables that are not written

danielmarjamaki marked an inline comment as done. danielmarjamaki added inline comments. Comment at: lib/StaticAnalyzer/Core/ExprEngine.cpp:107 +/** Recursively check if variable is changed in code. */ +static bool isChanged(const Stmt *S, const VarDecl *VD, bool Write) { + if (

[PATCH] D20689: [clang-tidy] Suspicious Call Argument checker

barancsuk added a comment. @alexfh, have you had a chance to look at the results yet? https://reviews.llvm.org/D20689 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r315046 - Fix check strings in test case and use llvm::to_string instead of

Author: ahatanak Date: Fri Oct 6 00:47:47 2017 New Revision: 315046 URL: http://llvm.org/viewvc/llvm-project?rev=315046&view=rev Log: Fix check strings in test case and use llvm::to_string instead of std::to_string. These changes were needed to fix bots that started failing after r315045. Modif

r315047 - Fix one more check string after r315045.

Author: ahatanak Date: Fri Oct 6 01:05:34 2017 New Revision: 315047 URL: http://llvm.org/viewvc/llvm-project?rev=315047&view=rev Log: Fix one more check string after r315045. Modified: cfe/trunk/test/CodeGenObjC/os_log.m Modified: cfe/trunk/test/CodeGenObjC/os_log.m URL: http://llvm.org/vi

r315048 - Refine generation of TBAA information in clang

Author: kosarev Date: Fri Oct 6 01:17:48 2017 New Revision: 315048 URL: http://llvm.org/viewvc/llvm-project?rev=315048&view=rev Log: Refine generation of TBAA information in clang This patch is an attempt to clarify and simplify generation and propagation of TBAA information. The idea is to pack

[PATCH] D37826: Refine generation of TBAA information in clang

This revision was automatically updated to reflect the committed changes. Closed by commit rL315048: Refine generation of TBAA information in clang (authored by kosarev). Changed prior to commit: https://reviews.llvm.org/D37826?vs=117823&id=117961#toc Repository: rL LLVM https://reviews.llv

r315049 - Fix one more check string after r315045.

Author: ahatanak Date: Fri Oct 6 01:19:31 2017 New Revision: 315049 URL: http://llvm.org/viewvc/llvm-project?rev=315049&view=rev Log: Fix one more check string after r315045. Modified: cfe/trunk/test/CodeGenObjC/os_log.m Modified: cfe/trunk/test/CodeGenObjC/os_log.m URL: http://llvm.org/vi

Re: [clang-tools-extra] r314989 - [clangd] Added async API to run code completion.

Hi Douglas, Fixed in r315028. Sorry for the inconvenience. On Thu, Oct 5, 2017 at 11:55 PM, Yung, Douglas wrote: > Hi Ilya, > > Your change has broken the build on the PS4 Windows bot. > > http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_ > 64-scei-ps4-windows10pro-fast/builds/12525 > > Can

[PATCH] D31538: [analyzer] MisusedMovedObjectChecker: Fix a false positive on state-resetting a base-class sub-object.

szepet added a comment. Hello Artem! Could you please commit these changes? (And https://reviews.llvm.org/D31541 as well.) Thanks in advance! https://reviews.llvm.org/D31538 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm

[PATCH] D38578: [preamble] Also record the "skipping" state of the preprocessor

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM. Only a few code style-related comments. Comment at: include/clang/Lex/Preprocessor.h:102 +bool ReachedEOFWhileSkipping; +SourceLocation HashToken;

[PATCH] D38578: [preamble] Also record the "skipping" state of the preprocessor

ilya-biryukov requested changes to this revision. ilya-biryukov added a comment. This revision now requires changes to proceed. Also, one more important thing. I'll unaccept revision for now, before getting feedback on this one. Comment at: include/clang/Lex/Preprocessor.h:333

[PATCH] D38615: [libclang] Only mark CXCursors for explicit attributes with a type

erikjv created this revision. All attributes have a source range associated with it. However, implicit attributes are added by the compiler, and not added because the user wrote something in the input. So no token type should be set to CXCursor_*Attr. The problem was visible when a class gets mar

[PATCH] D38615: [libclang] Only mark CXCursors for explicit attributes with a type

erikjv updated this revision to Diff 117975. erikjv added a comment. Added more context to the diff https://reviews.llvm.org/D38615 Files: test/Index/annotate-tokens-unexposed.cpp tools/libclang/CIndex.cpp Index: tools/libclang/CIndex.cpp ==

[PATCH] D38617: Set PreprocessorOpts.GeneratePreamble=true in PrecompiledPreamble.

ilya-biryukov created this revision. It was previsouly set only in ASTUnit, but it should be set for all client of PrecompiledPreamble. https://reviews.llvm.org/D38617 Files: lib/Frontend/ASTUnit.cpp lib/Frontend/PrecompiledPreamble.cpp Index: lib/Frontend/PrecompiledPreamble.cpp

[PATCH] D38617: Set PreprocessorOpts.GeneratePreamble=true in PrecompiledPreamble.

ilya-biryukov added a comment. This commit will unbreak clangd from all the same issues that were fixed by conditional stack commits. https://reviews.llvm.org/D38617 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-

[PATCH] D38134: [OpenCL] Emit enqueued block as kernel

Anastasia added inline comments. Comment at: lib/CodeGen/CGOpenCLRuntime.cpp:144 + if (auto *I = dyn_cast(V)) { +// If the block literal is emitted as an instruction, it is an alloca +// and the block invoke function is stored to GEP of this alloca. Why

[PATCH] D38618: Do not add a colon chunk to the code completion of class inheritance access modifiers

yvvan created this revision. With enabled CINDEXTEST_CODE_COMPLETE_PATTERNS env option (which enables IncludeCodePatterns in completion options) code completion after colon currently suggests access modifiers with 2 completion chunks which is incorrect. Example: class A : B { } Currently we ge

[clang-tools-extra] r315055 - [clangd] Add textDocument/signatureHelp

Author: ibiryukov Date: Fri Oct 6 04:54:17 2017 New Revision: 315055 URL: http://llvm.org/viewvc/llvm-project?rev=315055&view=rev Log: [clangd] Add textDocument/signatureHelp Summary: Makes clangd respond to a client's "textDocument/signatureHelp" request by presenting function/method overloads.

[PATCH] D38048: [clangd] Add textDocument/signatureHelp

This revision was automatically updated to reflect the committed changes. Closed by commit rL315055: [clangd] Add textDocument/signatureHelp (authored by ibiryukov). Changed prior to commit: https://reviews.llvm.org/D38048?vs=117580&id=117983#toc Repository: rL LLVM https://reviews.llvm.org

[PATCH] D35082: [OpenCL] Add LangAS::opencl_private to represent private address space in AST

Anastasia added a comment. In https://reviews.llvm.org/D35082#890162, @rjmccall wrote: > Okay. I think I see your point about why it would be better to have a > canonical __private address space that is different from the implicit address > space 0. I assume this means that there should basic

[PATCH] D38048: [clangd] Add textDocument/signatureHelp

ilya-biryukov added a comment. @francisco.lopes, I've surely noticed there are a bunch of places where `signatureHelp` does not show up while I was playing around with this change. It would be great to have it available in more cases. Repository: rL LLVM https://reviews.llvm.org/D38048 __

Patch to Bugzilla 31373

Committing a patch to Bugzilla 31373 A novice programmer so hopefully it complies with the coding policy. I had to disable an assert in lib/CodeGen/CGExpr.cpp since it requires that all expressions are marked as Used or referenced, which is not possib

[PATCH] D38464: [clangd] less boilerplate in RPC dispatch

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM. Note there's a new LSP method handler added upstream (`textDocument/signatureHelp`), we should add it to this change before submitting. Comment at: clan

[PATCH] D38284: [clang-tidy] Fix google-readability-namespace-comments handling of C++17 nested namespaces

predator5047 added a comment. In https://reviews.llvm.org/D38284#888124, @aaron.ballman wrote: > Aside from a small nit, this LGTM, thanks! Can you commit it? I don't have commit rights. https://reviews.llvm.org/D38284 ___ cfe-commits mailing li

[clang-tools-extra] r315057 - Fix nested namespaces in google-readability-nested-namespace-comments.

Author: aaronballman Date: Fri Oct 6 05:57:28 2017 New Revision: 315057 URL: http://llvm.org/viewvc/llvm-project?rev=315057&view=rev Log: Fix nested namespaces in google-readability-nested-namespace-comments. Fixes PR34701. Patch by Alexandru Octavian Buțiu. Added: clang-tools-extra/trunk

[PATCH] D38284: [clang-tidy] Fix google-readability-namespace-comments handling of C++17 nested namespaces

aaron.ballman closed this revision. aaron.ballman added a comment. I've commit in r315057. Thank you! https://reviews.llvm.org/D38284 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: Patch to Bugzilla 31373

On Fri, Oct 6, 2017 at 3:15 PM, Erik Viktorsson via cfe-commits wrote: Hi. > Committing a patch to Bugzilla 31373 > > A novice programmer so hopefully it complies with the coding policy. I think it may be better to put it to Phabricator, see https://llvm.org/docs/Phabricator.html#id3 Please do n

[PATCH] D38113: OpenCL: Assume functions are convergent

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D38113 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinf

[PATCH] D38425: [clangd] Document highlights for clangd

ilya-biryukov added a comment. Sorry for the delay. The patch does not apply cleanly on top of the current head. Mostly conflicts with `switchHeaderSource` for me. Could you please rebase your change with head and resubmit it? Another note: current implementation does not seem to handle macros

[clang-tools-extra] r315059 - Fixing the command line for a test and switching from tabs to spaces.

Author: aaronballman Date: Fri Oct 6 06:14:28 2017 New Revision: 315059 URL: http://llvm.org/viewvc/llvm-project?rev=315059&view=rev Log: Fixing the command line for a test and switching from tabs to spaces. Modified: clang-tools-extra/trunk/test/clang-tidy/google-readability-nested-namespa

[PATCH] D38578: [preamble] Also record the "skipping" state of the preprocessor

erikjv updated this revision to Diff 117986. https://reviews.llvm.org/D38578 Files: include/clang/Lex/Preprocessor.h lib/Lex/PPDirectives.cpp lib/Lex/Preprocessor.cpp lib/Serialization/ASTReader.cpp lib/Serialization/ASTWriter.cpp test/Index/preamble-conditionals-inverted.cpp test/I

[PATCH] D38578: [preamble] Also record the "skipping" state of the preprocessor

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D38578 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman

Re: [clang-tools-extra] r315057 - Fix nested namespaces in google-readability-nested-namespace-comments.

On 6 Oct 2017 14:59, "Aaron Ballman via cfe-commits" < cfe-commits@lists.llvm.org> wrote: Author: aaronballman Date: Fri Oct 6 05:57:28 2017 New Revision: 315057 URL: http://llvm.org/viewvc/llvm-project?rev=315057&view=rev Log: Fix nested namespaces in google-readability-nested-namespace-comment

[clang-tools-extra] r315060 - Renaming a test to start with the name of the check based on post-commit review feedback; NFC.

Author: aaronballman Date: Fri Oct 6 06:27:59 2017 New Revision: 315060 URL: http://llvm.org/viewvc/llvm-project?rev=315060&view=rev Log: Renaming a test to start with the name of the check based on post-commit review feedback; NFC. Added: clang-tools-extra/trunk/test/clang-tidy/google-rea

Re: [clang-tools-extra] r315057 - Fix nested namespaces in google-readability-nested-namespace-comments.

On Fri, Oct 6, 2017 at 9:27 AM, Alexander Kornienko wrote: > > > On 6 Oct 2017 14:59, "Aaron Ballman via cfe-commits" > wrote: > > Author: aaronballman > Date: Fri Oct 6 05:57:28 2017 > New Revision: 315057 > > URL: http://llvm.org/viewvc/llvm-project?rev=315057&view=rev > Log: > Fix nested name

[PATCH] D38618: Do not add a colon chunk to the code completion of class inheritance access modifiers

erikjv added a comment. lgtm, but someone else will probably have to review it too. Comment at: lib/Parse/ParseDeclCXX.cpp:3196 if (Tok.is(tok::colon)) { +ParseScope ClassScope(this, Scope::ClassScope|Scope::DeclScope | Scope::ClassInheritanceScope); +

[PATCH] D38615: [libclang] Only mark CXCursors for explicit attributes with a type

ilya-biryukov resigned from this revision. ilya-biryukov added a comment. I'm not actually familiar with `CXCursor`, so can't really help with reviewing this. https://reviews.llvm.org/D38615 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D35109: [Analyzer] SValBuilder Comparison Rearrangement

baloghadamsoftware added a comment. It seems that Artem's suggestion is not enough (or I misunderstood it). So two options remain: either we drop this and revert to the local solution in the Iterator Checkers or we extend the type when rearranging the comparison. Which way to go? https://revi

[PATCH] D38618: Do not add a colon chunk to the code completion of class inheritance access modifiers

yvvan updated this revision to Diff 117988. yvvan added a comment. Fix according to the review comment https://reviews.llvm.org/D38618 Files: include/clang/Sema/Scope.h lib/Parse/ParseDeclCXX.cpp lib/Sema/SemaCodeComplete.cpp test/Index/complete-super.cpp Index: test/Index/complete-su

[PATCH] D38596: Implement attribute target multiversioning

aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added inline comments. Comment at: include/clang/AST/Decl.h:2226 + MultiVersionKind getMultiVersionKind() const { +return static_cast(this->MultiVersion); + } Drop the `this->`

[PATCH] D33537: [clang-tidy] Exception Escape Checker

baloghadamsoftware added a comment. I think that the acceptable false positive rate of a compiler warning is much lower than that of a Tidy check. So I understand that the fronted patch will not handle the indirect cases (which are the most important in my opinion) or the cases where there are

[PATCH] D34508: [Analyzer] Bug Reporter Visitor to Display Values of Variables - PRELIMINARY!

baloghadamsoftware added a comment. I am considering to restrict the assumptions to nodes marked as interesting and to the location of the bug. However, I have difficulties with the latter, it seems that the bug location itself is not part of the bug path. https://reviews.llvm.org/D34508 __

[clang-tools-extra] r315065 - [clangd] Run clang-format on the source code. NFC.

Author: ibiryukov Date: Fri Oct 6 07:39:39 2017 New Revision: 315065 URL: http://llvm.org/viewvc/llvm-project?rev=315065&view=rev Log: [clangd] Run clang-format on the source code. NFC. Modified: clang-tools-extra/trunk/clangd/ClangdServer.cpp Modified: clang-tools-extra/trunk/clangd/Clangd

[PATCH] D38627: [clangd] Added a move-only function helpers.

ilya-biryukov created this revision. They are now used in ClangdScheduler instead of deferred std::async computations. The results of `std::async` are much less effective and do not provide a good abstraction for similar purposes, i.e. for storing additional callbacks to clangd async tasks. The ac

[PATCH] D37897: [StaticAnalyzer] Fix ProgramState for static variables that are not written

szepet added a comment. Hello Daniel! It is a great feature to add, thanks for working on this! I have just small comments (rather questions) on the code. Comment at: lib/StaticAnalyzer/Core/ExprEngine.cpp:155 + Children.push(FuncBody); + while (!Children.empty()) { +con

[PATCH] D34512: Add preliminary Cross Translation Unit support library

r.stahl added a comment. In https://reviews.llvm.org/D34512#877643, @xazax.hun wrote: > - Unittests now creates temporary files at the correct location > - Temporary files are also cleaned up when the process is terminated > - Absolute paths are handled correctly by the library I think there is

[PATCH] D38628: Remove unneeded typename from test

rogfer01 created this revision. https://reviews.llvm.org/D38628 Files: test/std/utilities/utility/pairs/pair.astuple/tuple_element.fail.cpp Index: test/std/utilities/utility/pairs/pair.astuple/tuple_element.fail.cpp === --- test/

[PATCH] D38362: Mark tests as unsupported in C++98 as well

rogfer01 updated this revision to Diff 118005. rogfer01 retitled this revision from "Mark test as unsupported in C++98 as well" to "Mark tests as unsupported in C++98 as well". rogfer01 added a comment. ChangeLog: - I wanted to mark two tests but forgot to add one in the previous change https:

[PATCH] D38134: [OpenCL] Emit enqueued block as kernel

yaxunl marked 6 inline comments as done. yaxunl added inline comments. Comment at: lib/CodeGen/CGOpenCLRuntime.cpp:144 + if (auto *I = dyn_cast(V)) { +// If the block literal is emitted as an instruction, it is an alloca +// and the block invoke function is stored to GEP

[PATCH] D38627: [clangd] Added a move-only function helpers.

ilya-biryukov updated this revision to Diff 118008. ilya-biryukov added a comment. - Fix to ForwardBinder. - Add UniqueFunction(nullptr) constructor. - Added missing STL headers to Function.h https://reviews.llvm.org/D38627 Files: clangd/ClangdServer.cpp clangd/ClangdServer.h clangd/Funct

[PATCH] D38629: [clangd] Added a callback-based codeComplete in clangd.

ilya-biryukov created this revision. https://reviews.llvm.org/D38629 Files: clangd/ClangdServer.cpp clangd/ClangdServer.h Index: clangd/ClangdServer.h === --- clangd/ClangdServer.h +++ clangd/ClangdServer.h @@ -252,6 +252,14 @@

[PATCH] D38629: [clangd] Added a callback-based codeComplete in clangd.

ilya-biryukov added a comment. I hope the whole design doesn't seem overly complicated. Very much open to suggestions on how to simplify it :-) https://reviews.llvm.org/D38629 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llv

r315074 - [OPENMP] Capture references to global variables.

Author: abataev Date: Fri Oct 6 09:17:25 2017 New Revision: 315074 URL: http://llvm.org/viewvc/llvm-project?rev=315074&view=rev Log: [OPENMP] Capture references to global variables. In C++11 variable to global variables are considered as constant expressions and these variables are not captured

[PATCH] D38320: [clang] Fix serializers for `TypeTemplateParmDecl` + related types

elsteveogrande added a comment. Hi @bruno, @rsmith, does this approach look ok? I couldn't easily figure out a better way to store inherited-default-info; doing it alongside the default value seemed the cleanest. Note: I saw there are three ways to store these data inside the `DefaultArgStorag

r315075 - Split X86::BI__builtin_cpu_init handling into own function[NFC]

Author: erichkeane Date: Fri Oct 6 09:40:45 2017 New Revision: 315075 URL: http://llvm.org/viewvc/llvm-project?rev=315075&view=rev Log: Split X86::BI__builtin_cpu_init handling into own function[NFC] The Cpu Init functionality is required for the target attribute, so this patch simply splits it

[PATCH] D38628: Remove unneeded typename from test

chill added a comment. FYI, there is a similar issue in `test/std/utilities/variant/variant.helpers/variant_alternative.fail.cpp` added by the same commit git hash: a12318f5ae0aae44eb17f376d3598717b45f7a5f "Added failing tests for index out of range for tuple_element> and variant_alternativ

[PATCH] D38124: Hide some symbols to avoid a crash on shutdown when using code coverage

davidxl added a comment. Can you add a test case with shared libraries? https://reviews.llvm.org/D38124 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D38618: Do not add a colon chunk to the code completion of class inheritance access modifiers

arphaman added inline comments. Comment at: include/clang/Sema/Scope.h:129 +/// We are between inheritance colon and the real class/struct definition scope +ClassInheritanceScope = 0x40, }; Could you please rebase this patch? There's another scope

[PATCH] D38101: [Sema] Diagnose tautological comparison with type's min/max values

lebedev.ri added inline comments. Comment at: lib/Sema/SemaChecking.cpp:8719 + // Type limit values are handled later by CheckTautologicalComparison(). + if (IsTypeLimit(S, Other, Constant, ConstValue) && (!OtherIsBooleanType)) return; lebedev.ri wrote: >

r315076 - [OPENMP] Do not capture local static variables.

Author: abataev Date: Fri Oct 6 10:00:28 2017 New Revision: 315076 URL: http://llvm.org/viewvc/llvm-project?rev=315076&view=rev Log: [OPENMP] Do not capture local static variables. Previously we may erroneously try to capture locally declared static variables, which will lead to crash for target

r315078 - For Windows, allow .exe extension in a test.

Author: probinson Date: Fri Oct 6 10:12:28 2017 New Revision: 315078 URL: http://llvm.org/viewvc/llvm-project?rev=315078&view=rev Log: For Windows, allow .exe extension in a test. Modified: cfe/trunk/test/Driver/baremetal.cpp Modified: cfe/trunk/test/Driver/baremetal.cpp URL: http://llvm.o

[PATCH] D38538: Avoid printing some redundant name qualifiers in completion

arphaman added inline comments. Comment at: test/CodeCompletion/call.cpp:22 // CHECK-CC1: COMPLETION: Pattern : dynamic_cast<<#type#>>(<#expression#>) - // CHECK-CC1: f(N::Y y, <#int ZZ#>) + // CHECK-CC1: f(Y y, <#int ZZ#>) // CHECK-CC1-NEXT: f(int i, <#int j#>, int k) --

[PATCH] D35082: [OpenCL] Add LangAS::opencl_private to represent private address space in AST

rjmccall added a comment. In https://reviews.llvm.org/D35082#890359, @Anastasia wrote: > In https://reviews.llvm.org/D35082#890162, @rjmccall wrote: > > > Okay. I think I see your point about why it would be better to have a > > canonical __private address space that is different from the impli

[PATCH] D36918: [Sema] Take into account the current context when checking the accessibility of a member function pointer

ahatanak added a comment. ping https://reviews.llvm.org/D36918 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r315084 - Run pyformat on lit code.

Author: zturner Date: Fri Oct 6 10:54:27 2017 New Revision: 315084 URL: http://llvm.org/viewvc/llvm-project?rev=315084&view=rev Log: Run pyformat on lit code. Modified: cfe/trunk/test/lit.cfg.py Modified: cfe/trunk/test/lit.cfg.py URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/lit

r315085 - [lit] Improve tool substitution in lit.

Author: zturner Date: Fri Oct 6 10:54:46 2017 New Revision: 315085 URL: http://llvm.org/viewvc/llvm-project?rev=315085&view=rev Log: [lit] Improve tool substitution in lit. This addresses two sources of inconsistency in test configuration files. 1. Substitution boundaries. Previously you would

[PATCH] D38402: [clang-refactor] Apply source replacements

arphaman added inline comments. Comment at: test/Refactor/tool-apply-replacements.cpp:6 + +class RenameMe { // CHECK: class { +}; ioeric wrote: > Why is the result `class {`? Sorry, the test was broken. Fixed! Repository: rL LLVM https://reviews.llvm.org/D38

[PATCH] D38402: [clang-refactor] Apply source replacements

arphaman updated this revision to Diff 118042. arphaman marked 5 inline comments as done. arphaman added a comment. Address review comments Repository: rL LLVM https://reviews.llvm.org/D38402 Files: include/clang/Frontend/CommandLineSourceLoc.h test/Refactor/tool-apply-replacements.cpp

[PATCH] D38639: [clangd] #include statements support for Open definition

Nebiroth created this revision. ctrl-clicking on #include statements now opens the file being pointed by that statement. https://reviews.llvm.org/D38639 Files: clangd/ClangdServer.cpp clangd/ClangdUnit.cpp clangd/ClangdUnit.h unittests/clangd/ClangdTests.cpp Index: unittests/clangd/Cl

r315087 - [refactor] add support for refactoring options

Author: arphaman Date: Fri Oct 6 11:12:29 2017 New Revision: 315087 URL: http://llvm.org/viewvc/llvm-project?rev=315087&view=rev Log: [refactor] add support for refactoring options This commit adds initial support for refactoring options. One can now use optional and required std::string options

[PATCH] D37856: [refactor] add support for refactoring options

This revision was automatically updated to reflect the committed changes. arphaman marked 3 inline comments as done. Closed by commit rL315087: [refactor] add support for refactoring options (authored by arphaman). Changed prior to commit: https://reviews.llvm.org/D37856?vs=117124&id=118044#toc

[PATCH] D37856: [refactor] add support for refactoring options

arphaman added inline comments. Comment at: include/clang/Tooling/Refactoring/RefactoringActionRuleRequirements.h:73 +template +class OptionRequirement : public RefactoringOptionsRequirement { +public: ioeric wrote: > nit: `OptionRequirement` sounds more genera

[PATCH] D38639: [clangd] #include statements support for Open definition

Nebiroth updated this revision to Diff 118046. Nebiroth added a comment. Fixed accidental removal of CheckSourceHeaderSwitch test https://reviews.llvm.org/D38639 Files: clangd/ClangdServer.cpp clangd/ClangdUnit.cpp clangd/ClangdUnit.h unittests/clangd/ClangdTests.cpp Index: unittests/c

[PATCH] D38639: [clangd] #include statements support for Open definition

malaperle requested changes to this revision. malaperle added inline comments. This revision now requires changes to proceed. Comment at: clangd/ClangdUnit.cpp:81 + std::map takeIncludeMap() { +return std::move(IncludeMap); takeIncludeLocationMap? ==

[PATCH] D38126: Make TBAA information to be part of LValueBaseInfo

kosarev updated this revision to Diff 118045. kosarev edited the summary of this revision. kosarev added a comment. Re-based on top of the previous refinements: https://reviews.llvm.org/D38404, https://reviews.llvm.org/D38408, https://reviews.llvm.org/D38456, https://reviews.llvm.org/D38460, htt

[PATCH] D38126: Make TBAA information to be part of LValueBaseInfo

kosarev added inline comments. Comment at: lib/CodeGen/CodeGenModule.cpp:55 #include "llvm/IR/Module.h" +#include "llvm/IR/Verifier.h" // TODO #include "llvm/ProfileData/InstrProfReader.h" Oops. Will be removed. https://reviews.llvm.org/D38126 ___

[libunwind] r315090 - [docs] Mention that SjLj works on any OS on the archs where supported by the compiler

Author: mstorsjo Date: Fri Oct 6 12:14:07 2017 New Revision: 315090 URL: http://llvm.org/viewvc/llvm-project?rev=315090&view=rev Log: [docs] Mention that SjLj works on any OS on the archs where supported by the compiler Differential Revision: https://reviews.llvm.org/D38576 Modified: libun

[PATCH] D38576: |libunwind] [docs] Mention that SjLj works on any OS on the archs where supported by the compiler

This revision was automatically updated to reflect the committed changes. Closed by commit rL315090: [docs] Mention that SjLj works on any OS on the archs where supported by the… (authored by mstorsjo). Changed prior to commit: https://reviews.llvm.org/D38576?vs=117778&id=118054#toc Repository

r315093 - [ObjC] Don't warn on readwrite properties with custom setters that

Author: arphaman Date: Fri Oct 6 12:24:26 2017 New Revision: 315093 URL: http://llvm.org/viewvc/llvm-project?rev=315093&view=rev Log: [ObjC] Don't warn on readwrite properties with custom setters that override readonly properties from protocols rdar://34192541 Added: cfe/trunk/test/SemaObjC

r315094 - OpenCL: Assume functions are convergent

Author: arsenm Date: Fri Oct 6 12:34:40 2017 New Revision: 315094 URL: http://llvm.org/viewvc/llvm-project?rev=315094&view=rev Log: OpenCL: Assume functions are convergent This was done for CUDA functions in r261779, and for the same reason this also needs to be done for OpenCL. An arbitrary fun

[PATCH] D38113: OpenCL: Assume functions are convergent

arsenm closed this revision. arsenm added a comment. r315094 Comment at: test/CodeGenOpenCL/convergent.cl:130 +// CHECK: attributes #0 = { noinline norecurse nounwind " +// CHECK: attributes #1 = { {{[^}]*}}convergent{{[^}]*}} } +// CHECK: attributes #2 = { {{[^}]*}}convergent{

r315095 - Revert r315087

Author: arphaman Date: Fri Oct 6 12:49:29 2017 New Revision: 315095 URL: http://llvm.org/viewvc/llvm-project?rev=315095&view=rev Log: Revert r315087 clang-refactor crashes on some bots after this commit Removed: cfe/trunk/include/clang/Tooling/Refactoring/RefactoringOption.h cfe/trunk/i

[PATCH] D38596: Implement attribute target multiversioning

erichkeane marked 31 inline comments as done. erichkeane added a subscriber: rnk. erichkeane added a comment. Weew... I think I got everything. Thanks for the review you three! I've got another patch coming momentarily with what I believe is all your suggestions. Comment at:

[PATCH] D38596: Implement attribute target multiversioning

erichkeane updated this revision to Diff 118058. erichkeane marked 5 inline comments as done. erichkeane added a comment. All requested changes AFAIK. Also, discovered that I wasn't calling cpu-init at the beginning of my resolver, so added that. Note: Virtual functions seem to have a bunch of

[PATCH] D38642: [clang-fuzzer] Allow building without coverage instrumentation.

morehouse created this revision. Herald added a subscriber: mgorny. Build with DummyClangFuzzer.cpp as entry point when coverage instrumentation isn't present. https://reviews.llvm.org/D38642 Files: clang/tools/clang-fuzzer/CMakeLists.txt clang/tools/clang-fuzzer/ClangFuzzer.cpp clang/too

[PATCH] D38643: PR13575: Fix USR mangling for fixed-size arrays.

jkorous-apple created this revision. Added array type mangling to USR generation. Included test from bug report. Repository: rL LLVM https://reviews.llvm.org/D38643 Files: lib/Index/USRGeneration.cpp test/Index/USR/array-type.cpp Index: test/Index/USR/array-type.cpp ===

[PATCH] D38642: [clang-fuzzer] Allow building without coverage instrumentation.

kcc added a comment. It's not about coverage instrumentation (not) being present, but about libFuzzer's main() being present, right? Will we be able to reuse some of Justin's code instead of creating one more main() function? Or, why not link with libFuzzer (-fsanitize=fuzzer at link time) eve

[PATCH] D38642: [clang-fuzzer] Allow building without coverage instrumentation.

morehouse added a comment. In https://reviews.llvm.org/D38642#890963, @kcc wrote: > It's not about coverage instrumentation (not) being present, but about > libFuzzer's main() being present, right? Yes. > Will we be able to reuse some of Justin's code instead of creating one more > main() fu

[PATCH] D38642: [clang-fuzzer] Allow building without coverage instrumentation.

kcc added a comment. >> Will we be able to reuse some of Justin's code instead of creating one more >> main() function? > > This reuses the code that Justin moved to FuzzMutate/FuzzerCLI. That's why > the main is so short. But perhaps we could move the main itself into > FuzzerCLI? Yes, hav

[PATCH] D38643: PR13575: Fix USR mangling for fixed-size arrays.

arphaman added a comment. Thanks for working on this! Could you please post the patch with full context (`git diff -U99`)? Comment at: test/Index/USR/array-type.cpp:1 +// RUN: c-index-test core -print-source-symbols -- %s | grep "function(Gen,TS)/C++" | grep foo | cut -s -

[PATCH] D36918: [Sema] Take into account the current context when checking the accessibility of a member function pointer

Rakete added inline comments. Comment at: lib/Sema/SemaAccess.cpp:1798 + EffectiveContext EC(CurScope->getEntity()); + if (IsAccessible(*this, EC, Entity) == ::AR_accessible) +return AR_accessible; You don't need that scope resolution operator there. Al

[PATCH] D38134: [OpenCL] Emit enqueued block as kernel

yaxunl updated this revision to Diff 118064. yaxunl marked 5 inline comments as done. yaxunl added a comment. Revise by Anastasia's comments. https://reviews.llvm.org/D38134 Files: lib/CodeGen/CGBuiltin.cpp lib/CodeGen/CGOpenCLRuntime.cpp lib/CodeGen/CGOpenCLRuntime.h lib/CodeGen/CodeGe

[PATCH] D38643: PR13575: Fix USR mangling for fixed-size arrays.

jkorous-apple updated this revision to Diff 118066. jkorous-apple added a comment. Uploaded full diff. https://reviews.llvm.org/D38643 Files: lib/Index/USRGeneration.cpp test/Index/USR/array-type.cpp Index: test/Index/USR/array-type.cpp

[PATCH] D38642: [clang-fuzzer] Allow building without coverage instrumentation.

morehouse added a comment. In https://reviews.llvm.org/D38642#890969, @kcc wrote: > I'd like to know more. > At least simple cases work fine: You're right. I was trying to add `-fsanitize=fuzzer` to `CMAKE_CXX_FLAGS` right before the link command, which was causing a later compilation to gi

[PATCH] D38643: PR13575: Fix USR mangling for fixed-size arrays.

arphaman added inline comments. Comment at: lib/Index/USRGeneration.cpp:820 +if (const ArrayType *const AT = dyn_cast(T)) { + VisitType(AT->getElementType()); + Out << "["; We should probably follow the other types and just set `T = AT->getElementT

[PATCH] D38646: [MS] Raise the default value of _MSC_VER to 1910, which is in VS 2017

rnk created this revision. This raises our default past 1900, which controls whether char16_t is a builtin type or not. Implements PR34243 https://reviews.llvm.org/D38646 Files: clang/lib/Driver/ToolChains/MSVC.cpp Index: clang/lib/Driver/ToolChains/MSVC.cpp ===

r315103 - -Wdocumentation should allow '...' params in variadic function type aliases

Author: arphaman Date: Fri Oct 6 13:51:04 2017 New Revision: 315103 URL: http://llvm.org/viewvc/llvm-project?rev=315103&view=rev Log: -Wdocumentation should allow '...' params in variadic function type aliases rdar://34811344 Modified: cfe/trunk/lib/AST/CommentSema.cpp cfe/trunk/test/Se

  1   2   >