Hi Douglas,
Looked into that yesterday, there's a mismatch between windows and linux
paths in the output.
I'll come up with a fix today.
On Mon, Jul 24, 2017 at 9:08 PM, Yung, Douglas
wrote:
> Hi Ilya,
>
> Your change seems to be causing the test 'clangd/definitions.test' to fail
> on the PS4 W
MontyKutyi added a comment.
As I can see the `clang/test` contains a lot of different simple tests, but for
testing this I think it is not enough to run the clang with some arguments on a
specific input. So I should create a new executable which uses the postorder
mode of the RecursiveASTVisit
lebedev.ri added a comment.
How does this relate to the gcc behavior?
I suspect not everyone would want to have this relaxed `-Wshadow` mode.
Perhaps it could be hidden under some new flag, which is not going to be
automatically enabled by `-Weverything`.
Like, `-Wshadow-in-macros` which does not
NoQ added a comment.
> I suspect that the usage of the CFGStmtMap* caused the undefined behaviour
> since its lifetime was depending on its LocationContext.
Yeah, it lives in `AnalysisDeclContextManager`, which lives in
`AnalysisManager`, which lives throughout a single analysis (top-level
fun
ogoffart added a comment.
ping
https://reviews.llvm.org/D35190
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
krasimir created this revision.
Previously we always queried the compilation database and discarded the results
if the file was already opened.
https://reviews.llvm.org/D35825
Files:
clangd/ClangdUnit.cpp
clangd/ClangdUnitStore.h
Index: clangd/ClangdUnitStore.h
===
Author: dergachev
Date: Tue Jul 25 02:25:10 2017
New Revision: 308957
URL: http://llvm.org/viewvc/llvm-project?rev=308957&view=rev
Log:
[analyzer] Further improve suppress-on-sink behavior in incomplete analyses.
If a certain memory leak (or other similar bug) found by the analyzer is known
to be
This revision was automatically updated to reflect the committed changes.
Closed by commit rL308957: [analyzer] Further improve suppress-on-sink behavior
in incomplete analyses. (authored by dergachev).
Changed prior to commit:
https://reviews.llvm.org/D35673?vs=107871&id=108024#toc
Repository
Author: ibiryukov
Date: Tue Jul 25 02:31:51 2017
New Revision: 308959
URL: http://llvm.org/viewvc/llvm-project?rev=308959&view=rev
Log:
[clangd] Workaround Windows test failures.
To properly fix this, Unix-specific paths should not be used when
running tests on Windows.
Modified:
clang-tools
ilya-biryukov added inline comments.
Comment at: clangd/ClangdUnit.cpp:248
+ VFS->setCurrentWorkingDirectory(Command.Directory);
+
Also have to call it in `codeComplete`.
https://reviews.llvm.org/D35825
___
cfe-
Author: dergachev
Date: Tue Jul 25 02:44:02 2017
New Revision: 308961
URL: http://llvm.org/viewvc/llvm-project?rev=308961&view=rev
Log:
[analyzer] Treat throws as sinks for suppress-on-sink purposes.
Because since r308957 the suppress-on-sink feature contains its own
mini-analysis, it also needs
This revision was automatically updated to reflect the committed changes.
Closed by commit rL308961: [analyzer] Treat throws as sinks for
suppress-on-sink purposes. (authored by dergachev).
Changed prior to commit:
https://reviews.llvm.org/D35674?vs=107873&id=108029#toc
Repository:
rL LLVM
fhahn created this revision.
Herald added subscribers: kristof.beyls, javed.absar, aemerson.
M-class profiles do not support ARM execution mode, so providing
-marm/-mno-thumb does not make sense in combination with -mcpu/-march
options that support the M-profile.
This is a follow-up patch to http
krasimir updated this revision to Diff 108033.
krasimir added a comment.
- Address review comment
https://reviews.llvm.org/D35825
Files:
clangd/ClangdUnit.cpp
clangd/ClangdUnitStore.h
Index: clangd/ClangdUnitStore.h
===
--- c
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D35825
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
szepet added a comment.
In https://reviews.llvm.org/D34260#819721, @NoQ wrote:
> ... and add the extra run-line that'd show you the backtrace. We made
> changes, so the issue might have been wiped out accidentally (or maybe you're
> actually right!), and if it wasn't, at least we'd have the ba
klimek created this revision.
CurrentDir was set as the path of the current module, but that can change as
part of a chain of loaded modules.
When we try to locate a file mentioned in a module that does not exist, we use
a heuristic to look at the relative path between the original location of th
NoQ added a comment.
Yeah, right, good point =)
https://reviews.llvm.org/D34260
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
lg
https://reviews.llvm.org/D35828
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
Author: klimek
Date: Tue Jul 25 03:22:06 2017
New Revision: 308962
URL: http://llvm.org/viewvc/llvm-project?rev=308962&view=rev
Log:
Fix incorrect use of current directory to find moved paths in ASTReader.
CurrentDir was set as the path of the current module, but that can change as
part of a chai
This revision was automatically updated to reflect the committed changes.
Closed by commit rL308962: Fix incorrect use of current directory to find moved
paths in ASTReader. (authored by klimek).
Repository:
rL LLVM
https://reviews.llvm.org/D35828
Files:
cfe/trunk/include/clang/Serializatio
Author: mharoush
Date: Tue Jul 25 03:43:43 2017
New Revision: 308965
URL: http://llvm.org/viewvc/llvm-project?rev=308965&view=rev
Log:
This patch enables the usage of constant Enum identifiers within Microsoft
style inline assembly statements.
Differential Revision:
https://reviews.llvm.org/D332
This revision was automatically updated to reflect the committed changes.
Closed by commit rL308965: This patch enables the usage of constant Enum
identifiers within Microsoft… (authored by mharoush).
Changed prior to commit:
https://reviews.llvm.org/D33277?vs=104390&id=108044#toc
Repository:
Author: chandlerc
Date: Tue Jul 25 03:46:07 2017
New Revision: 308967
URL: http://llvm.org/viewvc/llvm-project?rev=308967&view=rev
Log:
[PM] Setup TargetLibraryInfo correctly for the new pass manager.
Without this, -fno-builtin and friends doesn't work. Added the obvious
RUN lines to the test for
Author: klimek
Date: Tue Jul 25 04:34:55 2017
New Revision: 308969
URL: http://llvm.org/viewvc/llvm-project?rev=308969&view=rev
Log:
Fix spelling of FileCheck in test.
Modified:
cfe/trunk/test/CodeGen/x86-ms-inline-asm-enum_feature.cpp
Modified: cfe/trunk/test/CodeGen/x86-ms-inline-asm-enum_
Author: krasimir
Date: Tue Jul 25 04:37:43 2017
New Revision: 308970
URL: http://llvm.org/viewvc/llvm-project?rev=308970&view=rev
Log:
[clangd] Reuse compile commands during reparse
Summary:
Previously we always queried the compilation database and discarded the results
if the file was already op
This revision was automatically updated to reflect the committed changes.
Closed by commit rL308970: [clangd] Reuse compile commands during reparse
(authored by krasimir).
Repository:
rL LLVM
https://reviews.llvm.org/D35825
Files:
clang-tools-extra/trunk/clangd/ClangdUnit.cpp
clang-tools-
boris added a comment.
Ping.
FWIW, I went ahead and implemented this functionality in GCC. It has been
merged into its c++-modules branch.
https://reviews.llvm.org/D35020
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.or
krasimir accepted this revision.
krasimir added a comment.
This revision is now accepted and ready to land.
Looks good! Thanks!
https://reviews.llvm.org/D35557
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
aaron.ballman added a comment.
How does this check differ from the `-Wdelete-non-virtual-dtor` warning class
that comes out of the frontend?
https://reviews.llvm.org/D35796
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.o
NoQ added a comment.
It seems that this check is more powerful because it works by knowing the
dynamic type of the object. However, i still suspect that `-Wnon-virtual-dtor`
(the other one, without `delete-`, that simply asks to make the destructor of
polymorphic classes virtual) covers most pr
rjmccall added a comment.
In https://reviews.llvm.org/D32210#819577, @ahatanak wrote:
> In https://reviews.llvm.org/D32210#810508, @rjmccall wrote:
>
> > Hmm. Unfortunately, I'm not sure that's valid. The retains and releases
> > of block captures don't protect against anything related to esca
kfunk updated this revision to Diff 108061.
kfunk added a comment.
Addressed concerns
https://reviews.llvm.org/D35194
Files:
clang-apply-replacements/lib/Tooling/ApplyReplacements.cpp
test/clang-apply-replacements/Inputs/invalid-files/invalid-files.yaml
test/clang-apply-replacements/inval
aaron.ballman added a comment.
In https://reviews.llvm.org/D33672#819683, @xazax.hun wrote:
> Aaron, could you comment on the applicability of this check to C? Thanks in
> advance.
C has different rules for their enumerations in that the enumerators are all
ints, but the enumeration type is e
sdardis added a reviewer: cfe-commits.
sdardis added a comment.
Also, this need to be posted to cfe-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D35624
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG. Do you need someone to commit the patch for you?
https://reviews.llvm.org/D35194
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http
abeserminji marked 2 inline comments as done.
abeserminji added a comment.
Comments resolved
Repository:
rL LLVM
https://reviews.llvm.org/D35624
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
abeserminji updated this revision to Diff 108067.
abeserminji added a comment.
Comments resolved and patch adapted to current revision.
Repository:
rL LLVM
https://reviews.llvm.org/D35624
Files:
Basic/Targets/Mips.cpp
clang/Basic/DiagnosticCommonKinds.td
Index: Basic/Targets/Mips.cpp
=
yaxunl marked 16 inline comments as done.
yaxunl added inline comments.
Comment at: include/clang/Basic/Builtins.def:713
+ATOMIC_BUILTIN(__opencl_atomic_fetch_or, "v.", "t")
+ATOMIC_BUILTIN(__opencl_atomic_fetch_xor, "v.", "t")
+
Anastasia wrote:
> What about min
yaxunl updated this revision to Diff 108073.
yaxunl marked 16 inline comments as done.
yaxunl edited the summary of this revision.
yaxunl added a reviewer: kzhuravl.
yaxunl added a comment.
Herald added a subscriber: nhaehnle.
Rebased to ToT and revised by Anastasia's comments.
https://reviews.l
Author: kfunk
Date: Tue Jul 25 07:28:16 2017
New Revision: 308974
URL: http://llvm.org/viewvc/llvm-project?rev=308974&view=rev
Log:
[clang-tidy] clang-apply-replacements: Don't insert null entry
Summary:
[clang-tidy] clang-apply-replacements: Don't insert null entry
Fix crash when running clang-
This revision was automatically updated to reflect the committed changes.
Closed by commit rL308974: [clang-tidy] clang-apply-replacements: Don't insert
null entry (authored by kfunk).
Repository:
rL LLVM
https://reviews.llvm.org/D35194
Files:
clang-tools-extra/trunk/clang-apply-replacemen
kfunk added a comment.
Seems to have worked:
Committing to https://llvm.org/svn/llvm-project/clang-tools-extra/trunk ...
A
test/clang-apply-replacements/Inputs/invalid-files/invalid-files.yaml
A test/clang-apply-replacements/invalid-files.cpp
M c
arphaman updated this revision to Diff 108078.
arphaman added a comment.
Simplified the implementation of `LexicallyOrderedRecursiveASTVisitor` and
removed redundant DenseMap checks.
Ping.
Repository:
rL LLVM
https://reviews.llvm.org/D35012
Files:
include/clang/AST/LexicallyOrderedRecursi
Author: kfunk
Date: Tue Jul 25 07:39:08 2017
New Revision: 308975
URL: http://llvm.org/viewvc/llvm-project?rev=308975&view=rev
Log:
[clang-tidy] Fixup clang-apply-replacements/invalid-files test
Modified:
clang-tools-extra/trunk/test/clang-apply-replacements/invalid-files.cpp
Modified:
clan
b-sumner added inline comments.
Comment at: include/clang/Basic/Builtins.def:713
+ATOMIC_BUILTIN(__opencl_atomic_fetch_or, "v.", "t")
+ATOMIC_BUILTIN(__opencl_atomic_fetch_xor, "v.", "t")
+
yaxunl wrote:
> Anastasia wrote:
> > What about min/max? I believe they w
yaxunl marked 2 inline comments as done.
yaxunl added inline comments.
Comment at: include/clang/Basic/Builtins.def:713
+ATOMIC_BUILTIN(__opencl_atomic_fetch_or, "v.", "t")
+ATOMIC_BUILTIN(__opencl_atomic_fetch_xor, "v.", "t")
+
b-sumner wrote:
> yaxunl wrote:
>
peter.smith updated this revision to Diff 108092.
peter.smith added a comment.
Herald added a subscriber: javed.absar.
I've added a clang test that will check that none of the floating point helper
functions defined in the Runtime ABI for the ARM Architecture are directly
called by clang. Given
spetrovic added a comment.
Hi Bruno,
Yes, GCC has similar option (-mtp=soft/hard), but name is not same. I put the
same option name as in backend (https://reviews.llvm.org/D34408).
https://reviews.llvm.org/D34878
___
cfe-commits mailing list
cfe-c
Author: abataev
Date: Tue Jul 25 08:53:26 2017
New Revision: 308979
URL: http://llvm.org/viewvc/llvm-project?rev=308979&view=rev
Log:
[OPENMP] Codegen for 'task_reduction' clause.
Added codegen for taskgroup directive with task_reduction clause.
```
```
The next code is emitted:
```
%struct.kmp_
hans added a comment.
In https://reviews.llvm.org/D33900#819237, @dim wrote:
> Also note that it is only added to the `--version` output, not the `-v`
> output (the former is really a "verbose" version of the latter):
Which seems to be the opposite of what gcc does (`gcc -v` is more verbose th
dcoughlin added a comment.
I will commit.
Repository:
rL LLVM
https://reviews.llvm.org/D35613
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dcoughlin accepted this revision.
dcoughlin added a comment.
This revision is now accepted and ready to land.
Sorry for the delay! This looks good to me.
We have a really embarrassing FIXMELATER from 2012 (!!!) that disabled the
plist tests for diagnostics. This means we're not getting testing f
bruno added a comment.
If there's a precedence for a flag name there, it's nice to be compatible here.
You don't necessarily need to use the same name as the backend.
https://reviews.llvm.org/D34878
___
cfe-commits mailing list
cfe-commits@lists.ll
bruno added a comment.
In https://reviews.llvm.org/D34030#819699, @MontyKutyi wrote:
> As I can see the `clang/test` contains a lot of different simple tests, but
> for testing this I think it is not enough to run the clang with some
> arguments on a specific input. So I should create a new ex
chill added a comment.
Ping.
https://reviews.llvm.org/D33676
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: nemanjai
Date: Tue Jul 25 10:04:12 2017
New Revision: 308985
URL: http://llvm.org/viewvc/llvm-project?rev=308985&view=rev
Log:
This test case is causing all PPC and SystemZ bots to remain red.
Notifying the author via Diffusion did not yield any answer. Therefore, I'm
adding the missing t
majnemer updated this revision to Diff 108105.
majnemer added a comment.
- Address review feedback.
https://reviews.llvm.org/D35824
Files:
include/clang/AST/Type.h
lib/AST/Type.cpp
lib/CodeGen/CodeGenTBAA.cpp
test/CodeGenCXX/std-byte.cpp
Index: test/CodeGenCXX/std-byte.cpp
===
dcoughlin added a comment.
Do we have a radar for this? It sounds familiar.
Comment at: cfe/trunk/lib/StaticAnalyzer/Core/BugReporter.cpp:3313
+static bool isNoReturnBlock(const CFGBlock *Blk) {
+ if (Blk->hasNoReturnElement())
Maybe a better name for this w
r308988. Thanks!
On Mon, Jul 24, 2017 at 9:55 AM, Nico Weber wrote:
> We probably want this in 5.0.
>
> On Mon, Jul 24, 2017 at 12:54 PM, Nico Weber via cfe-commits
> wrote:
>>
>> Author: nico
>> Date: Mon Jul 24 09:54:11 2017
>> New Revision: 308897
>>
>> URL: http://llvm.org/viewvc/llvm-projec
Quuxplusone added inline comments.
Comment at: test/CodeGenCXX/std-byte.cpp:7
+enum byte : unsigned char {};
+}
+
Would it be worth adding an explicit test that `::byte`, `::my::byte`,
`::my::std::byte` are or are not handled in the same way?
https://reviews.l
Author: dcoughlin
Date: Tue Jul 25 10:17:09 2017
New Revision: 308990
URL: http://llvm.org/viewvc/llvm-project?rev=308990&view=rev
Log:
[analyzer] Add diagnostic text for generalized refcount annotations.
Add a 'Generalized' object kind to the retain-count checker and suitable
generic diagnostic
GorNishanov updated this revision to Diff 108111.
GorNishanov added a comment.
Thank you for the review. Feedback implemented. Preparing to land
https://reviews.llvm.org/D35383
Files:
include/clang/AST/StmtCXX.h
include/clang/Serialization/ASTBitCodes.h
lib/AST/StmtCXX.cpp
lib/Serializa
This revision was automatically updated to reflect the committed changes.
Closed by commit rL308990: [analyzer] Add diagnostic text for generalized
refcount annotations. (authored by dcoughlin).
Changed prior to commit:
https://reviews.llvm.org/D35613?vs=107471&id=108115#toc
Repository:
rL L
hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.
This seems reasonable to me.
Comment at: lib/Driver/ToolChain.cpp:660
+ assert(!Args.hasArg(options::OPT_nostdlibxx) &&
+ "should not have called this");
CXXStdlibTyp
euhlmann created this revision.
euhlmann added a project: clang.
Change 272124* introduced a regression in spaceRequiredBetween for left aligned
pointers to decltype and typeof expressions. This fix adds logic to fix this.
The test added is based on a related test in determineStarAmpUsage. Also
kzhuravl added a comment.
Seems like SyncScope.h file is missing?
https://reviews.llvm.org/D28691
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kcc added a comment.
Hi.
This patch causes the msan bots to complain. Please fix or revert ASAP.
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/6702/steps/check-clang%20msan/logs/stdio
Testing: 0 .. 10..
FAIL: Clang :: CodeGen/ms_this.cpp (2142 of 11057)
- TEST 'Clang :: C
Author: gornishanov
Date: Tue Jul 25 11:01:49 2017
New Revision: 308996
URL: http://llvm.org/viewvc/llvm-project?rev=308996&view=rev
Log:
[coroutines] Add serialization/deserialization of coroutines
Reviewers: rsmith
Reviewed By: rsmith
Subscribers: EricWF, cfe-commits
Differential Revision: h
Author: nico
Date: Tue Jul 25 11:02:57 2017
New Revision: 308997
URL: http://llvm.org/viewvc/llvm-project?rev=308997&view=rev
Log:
Introduce -nostdlib++ flag to disable linking the C++ standard library.
Projects that want to statically link their own C++ standard library currently
need to pass -n
This revision was automatically updated to reflect the committed changes.
GorNishanov marked an inline comment as done.
Closed by commit rL308996: [coroutines] Add serialization/deserialization of
coroutines (authored by GorNishanov).
Changed prior to commit:
https://reviews.llvm.org/D35383?vs=
thakis closed this revision.
thakis added a comment.
r308997, thanks!
https://reviews.llvm.org/D35780
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
The test also fails on many other bots on http://lab.llvm.org:8011/console
, a short excerpt:
http://lab.llvm.org:8011/builders/clang-ppc64be-linux/builds/9702/steps/ninja%20check%201/logs/FAIL%3A%20Clang%3A%3Ax86-ms-inline-asm-enum_feature.cpp
http://lab.llvm.org:8011/builders/clang-cmake-aarch64
shenhan created this revision.
This is to provide a default blacklist filename for UBSan.
While UBSan is turned on, it's better that clang pick up a blacklist file (when
exists), just as what ASan / MSan does, so we do not end up adding the
"-fsanitize-blacklist" option to every command line.
b-sumner added a comment.
Can we drop the "opencl" part of the name and use something like
__scoped_atomic_*? Also, it may not make sense to support non-constant scope
here since we can't predict what other scopes may be added by other languages
in the future.
https://reviews.llvm.org/D2869
vsk added a reviewer: vsk.
vsk added a comment.
This won't do the right thing if more than one sanitizer with a default
blacklist is enabled. It's also problematic that a default blacklist for one
sanitizer can blacklist code for a different sanitizer. See:
https://reviews.llvm.org/D32043
https
yaxunl marked an inline comment as done.
yaxunl added a comment.
In https://reviews.llvm.org/D28691#820375, @kzhuravl wrote:
> Seems like SyncScope.h file is missing?
Right. I will add it.
https://reviews.llvm.org/D28691
___
cfe-commits mailing l
yaxunl updated this revision to Diff 108127.
yaxunl added a comment.
Add min/max and missing file.
https://reviews.llvm.org/D28691
Files:
docs/LanguageExtensions.rst
include/clang/AST/Expr.h
include/clang/Basic/Builtins.def
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Basi
lhames accepted this revision.
lhames added a comment.
This revision is now accepted and ready to land.
Otherwise this looks good to me.
Comment at: examples/clang-interpreter/CMakeLists.txt:73
+set_property(TARGET ${TARGET} PROPERTY COMPILE_FLAGS ${editedFlags})
+#mess
yaxunl added a comment.
In https://reviews.llvm.org/D28691#820466, @b-sumner wrote:
> Can we drop the "opencl" part of the name and use something like
> __scoped_atomic_*? Also, it may not make sense to support non-constant
> scope here since we can't predict what other scopes may be added by
On Sun, Jul 23, 2017 at 07:06:25PM -0400, Nico Weber via cfe-commits wrote:
> If you need this behavior for something, that sounds like something a
> -nodefaultlibs++ could do. -nostdlib++ is really meant to disable the c++
> stdlib and nothing else.
But the -lm is only there because -lc++ alone (
On Tue, Jul 25, 2017 at 2:53 PM, Joerg Sonnenberger wrote:
> On Sun, Jul 23, 2017 at 07:06:25PM -0400, Nico Weber via cfe-commits wrote:
> > If you need this behavior for something, that sounds like something a
> > -nodefaultlibs++ could do. -nostdlib++ is really meant to disable the c++
> > stdl
Author: echristo
Date: Tue Jul 25 12:17:32 2017
New Revision: 309004
URL: http://llvm.org/viewvc/llvm-project?rev=309004&view=rev
Log:
Revert "This patch enables the usage of constant Enum identifiers within
Microsoft style inline assembly statements." as it is causing msan failures.
This revert
I've reverted this and Nemanja's attempt at fixing in:
echristo@athyra ~/s/l/t/clang> git svn dcommit
Committing to https://llvm.org/svn/llvm-project/cfe/trunk ...
D test/CodeGen/x86-ms-inline-asm-enum_feature.cpp
M lib/Sema/SemaStmtAsm.cpp
M test/CodeGen/ms-inline-asm.c
M test/CodeGenCXX/ms-inlin
And this:
echristo@athyra ~/s/llvm> git svn dcommit
Committing to https://llvm.org/svn/llvm-project/llvm/trunk ...
M include/llvm/MC/MCParser/MCAsmParser.h
M lib/Target/X86/AsmParser/X86AsmParser.cpp
Committed r309005
On Tue, Jul 25, 2017 at 12:18 PM Eric Christopher
wrote:
> I've reverted th
Author: szepet
Date: Tue Jul 25 12:23:23 2017
New Revision: 309006
URL: http://llvm.org/viewvc/llvm-project?rev=309006&view=rev
Log:
[StaticAnalyzer] Completely unrolling specific loops with known bound option
This feature allows the analyzer to consider loops to completely unroll.
New requiremen
rjmccall added a comment.
In https://reviews.llvm.org/D28691#820489, @yaxunl wrote:
> In https://reviews.llvm.org/D28691#820466, @b-sumner wrote:
>
> > Can we drop the "opencl" part of the name and use something like
> > __scoped_atomic_*? Also, it may not make sense to support non-constant
>
Author: vedantk
Date: Tue Jul 25 12:34:23 2017
New Revision: 309007
URL: http://llvm.org/viewvc/llvm-project?rev=309007&view=rev
Log:
[ubsan] Null-check pointers in -fsanitize=vptr (PR33881)
The instrumentation generated by -fsanitize=vptr does not null check a
user pointer before loading from it
This revision was automatically updated to reflect the committed changes.
Closed by commit rL309007: [ubsan] Null-check pointers in -fsanitize=vptr
(PR33881) (authored by vedantk).
Changed prior to commit:
https://reviews.llvm.org/D35735?vs=107741&id=108133#toc
Repository:
rL LLVM
https://r
vsk marked an inline comment as done.
vsk added a comment.
I made the suggested test changes and updated the release notes: r309007
Repository:
rL LLVM
https://reviews.llvm.org/D35735
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:/
vsk closed this revision.
vsk added a comment.
Thanks! This landed in r309008.
https://reviews.llvm.org/D35736
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
b-sumner added a comment.
In https://reviews.llvm.org/D28691#820526, @rjmccall wrote:
> In https://reviews.llvm.org/D28691#820489, @yaxunl wrote:
>
> > In https://reviews.llvm.org/D28691#820466, @b-sumner wrote:
> >
> > > Can we drop the "opencl" part of the name and use something like
> > > __s
On Tue, Jul 25, 2017 at 03:09:00PM -0400, Nico Weber via cfe-commits wrote:
> On Tue, Jul 25, 2017 at 2:53 PM, Joerg Sonnenberger wrote:
>
> > On Sun, Jul 23, 2017 at 07:06:25PM -0400, Nico Weber via cfe-commits wrote:
> > > If you need this behavior for something, that sounds like something a
>
Author: vedantk
Date: Tue Jul 25 12:53:27 2017
New Revision: 309013
URL: http://llvm.org/viewvc/llvm-project?rev=309013&view=rev
Log:
[Frontend] Mark some ASTUnit methods as const. NFC.
Patch by Hamza Sood!
Differential Revision: https://reviews.llvm.org/D35729
Modified:
cfe/trunk/include/c
Author: spyffe
Date: Tue Jul 25 12:54:22 2017
New Revision: 309014
URL: http://llvm.org/viewvc/llvm-project?rev=309014&view=rev
Log:
[ExternalASTMerger] Import Objective-C classes
This patch adds functionality and a test for importing Objective-C classes
and their methods.
It also adds a flag to
This revision was automatically updated to reflect the committed changes.
Closed by commit rL309013: [Frontend] Mark some ASTUnit methods as const. NFC.
(authored by vedantk).
Changed prior to commit:
https://reviews.llvm.org/D35729?vs=107689&id=108138#toc
Repository:
rL LLVM
https://review
dcoughlin added inline comments.
Comment at: cfe/trunk/lib/StaticAnalyzer/Core/BugReporter.cpp:3313
+static bool isDominatedByNoReturnBlocks(const ExplodedNode *N) {
+ const CFG &Cfg = N->getCFG();
Do you really mean "is dominated by"? That is, "every path fro
Author: spyffe
Date: Tue Jul 25 13:09:30 2017
New Revision: 309018
URL: http://llvm.org/viewvc/llvm-project?rev=309018&view=rev
Log:
Fix a bot by linking clang-import-test against libclangDriver
Modified:
cfe/trunk/tools/clang-import-test/CMakeLists.txt
Modified: cfe/trunk/tools/clang-import
rjmccall added a comment.
In https://reviews.llvm.org/D28691#820541, @b-sumner wrote:
> There are other languages for heterogeneous compute that have scopes,
> although not exposed quite as explicitly as OpenCL. For example AMD's "HC"
> language. And any language making use of clang and targe
shenhan added a comment.
Thanks. Can you update "SanitizerArgs::collectDefaultBlacklists" to include
"ubsan_blacklist.txt"?
https://reviews.llvm.org/D32842
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailma
1 - 100 of 133 matches
Mail list logo
