NoQ added a comment.
Sorry, got carried away by GSoC and critical stuff...
In https://reviews.llvm.org/D32592#749613, @baloghadamsoftware wrote:
> In https://reviews.llvm.org/D32592#747132, @NoQ wrote:
>
> > Then, in methods that deal with iterator `SVal`s directly, i wish we had
> > hints expl
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM after addressing inline comments. Sorry for the delay.
Comment at: include/memory:3663
+template
+struct rebind
+{
This rebind isn't gettin
Author: echuraev
Date: Thu May 25 01:55:02 2017
New Revision: 303844
URL: http://llvm.org/viewvc/llvm-project?rev=303844&view=rev
Log:
[OpenCL] Added regression test on invalid vector initialization.
Summary: This patch increases code coverage.
Reviewers: Anastasia
Reviewed By: Anastasia
Subsc
Author: echuraev
Date: Thu May 25 02:18:37 2017
New Revision: 303846
URL: http://llvm.org/viewvc/llvm-project?rev=303846&view=rev
Log:
[OpenCL] reserve_id_t cannot be used as argument to kernel function
Reviewers: Anastasia
Reviewed By: Anastasia
Subscribers: yaxunl, cfe-commits, bader
Differe
EricWF added inline comments.
Comment at: test/Modules/requires-coroutines.mm:1
+// RUN: rm -rf %t
+// RUN: %clang_cc1 -Wauto-import -fmodules-cache-path=%t -fmodules
-fimplicit-module-maps -F %S/Inputs %s -verify
Should this test be called `requires-coroutines.
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
Sorry for the delay reviewing such a simple change.
https://reviews.llvm.org/D33340
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D33290
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
EricWF added a comment.
@CaseyCarter Changes like this are good for post-commit review (ie just commit
it)
https://reviews.llvm.org/D33290
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
EricWF added a comment.
@BillyONeal Changes like this are good for post-commit review (ie just commit
it). Adding clearly correct assertions and test cases is never an objectionable
thing.
https://reviews.llvm.org/D33340
___
cfe-commits mailing li
EricWF added inline comments.
Comment at:
test/std/utilities/variant/variant.variant/variant.assign/copy.pass.cpp:389
+template
+constexpr bool triviality_test =
+ std::is_trivially_copy_assignable>::value ==
`triviality_test` should also compare to an explicit
chandlerc added a comment.
(focusing on the LLVM side of this review for now)
Can you add an LLVM-based test? Can you add this to
`lib/Passes/PassRegistry.def`?
Comment at: llvm/lib/Transforms/IPO/ThinLTOBitcodeWriter.cpp:423
+
+class AARGetter {
+ FunctionAnalysisManager &A
Prazek updated this revision to Diff 100216.
Prazek marked 8 inline comments as done.
Prazek added a comment.
- Thanks for the review Aaron, that is much better.
https://reviews.llvm.org/D33470
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/DefaultNumericsCheck.cpp
clang-tidy/misc/
echuraev updated this revision to Diff 100219.
echuraev marked 2 inline comments as done.
https://reviews.llvm.org/D33353
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaExpr.cpp
test/SemaOpenCL/arithmetic-conversions.cl
test/SemaOpenCL/cond.cl
Index: test/SemaOpenCL/cond.
fhahn updated this revision to Diff 100222.
fhahn retitled this revision from "[CodeGen] Add thumb-mode to function
target-features for arm/thumb triples." to "[CodeGen] Add thumb-mode to
target-features for arm/thumb triples.".
fhahn edited the summary of this revision.
fhahn added a comment.
M
fhahn added a comment.
@echristo lib/Basic/Targets.cpp is indeed a much better place to add thumb-mode
to the target features, thanks for pointing me in the right direction!
https://reviews.llvm.org/D33448
___
cfe-commits mailing list
cfe-commits@l
Author: fgross
Date: Thu May 25 06:43:06 2017
New Revision: 303849
URL: http://llvm.org/viewvc/llvm-project?rev=303849&view=rev
Log: (empty)
Modified:
clang-tools-extra/trunk/clang-tidy/readability/BracesAroundStatementsCheck.cpp
Modified:
clang-tools-extra/trunk/clang-tidy/readability/Bra
Just a commit access test with messed up log message.
- Florian
-Original Message-
From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf Of
Florian Gross via cfe-commits
Sent: Thursday, May 25, 2017 1:43 PM
To: cfe-commits@lists.llvm.org
Subject: [clang-tools-extra] r30
GorNishanov accepted this revision.
GorNishanov added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D33534
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
GorNishanov accepted this revision.
GorNishanov added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D33536
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
aaron.ballman created this revision.
It took me a while to track this down and I figured I'd save someone else the
time. By default, CMake uses the 32-bit toolchain on Windows, even if
generating a 64-bit solution. Given the size of Clang's code base, this can
lead to quite a few link errors wi
Author: kparzysz
Date: Thu May 25 07:55:47 2017
New Revision: 303851
URL: http://llvm.org/viewvc/llvm-project?rev=303851&view=rev
Log:
[CodeGen] Pessimize aliasing for member unions (and may-alias) objects
Use the TBAA info of the omnipotent char for these objects.
Differential Revision: https:/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL303851: [CodeGen] Pessimize aliasing for member unions (and
may-alias) objects (authored by kparzysz).
Changed prior to commit:
https://reviews.llvm.org/D33328?vs=100142&id=100232#toc
Repository:
rL
Author: marshall
Date: Thu May 25 08:40:57 2017
New Revision: 303856
URL: http://llvm.org/viewvc/llvm-project?rev=303856&view=rev
Log:
Make for_each_n only avaliable on C++17
Modified:
libcxx/trunk/include/algorithm
Modified: libcxx/trunk/include/algorithm
URL:
http://llvm.org/viewvc/llvm-p
This revision was automatically updated to reflect the committed changes.
Closed by commit rL303857: [X86] Adding avx512_vpopcntdq feature set and its
intrinsics (authored by orenb).
Changed prior to commit:
https://reviews.llvm.org/D33170?vs=99685&id=100236#toc
Repository:
rL LLVM
https://
Author: orenb
Date: Thu May 25 08:44:11 2017
New Revision: 303857
URL: http://llvm.org/viewvc/llvm-project?rev=303857&view=rev
Log:
[X86] Adding avx512_vpopcntdq feature set and its intrinsics
AVX512_VPOPCNTDQ is a new feature set that was published by Intel.
The patch represents the Clang side o
baloghadamsoftware updated this revision to Diff 100239.
baloghadamsoftware added a comment.
Comments added and fixed.
https://reviews.llvm.org/D32592
Files:
include/clang/StaticAnalyzer/Checkers/Checkers.td
lib/StaticAnalyzer/Checkers/CMakeLists.txt
lib/StaticAnalyzer/Checkers/IteratorCh
Author: timcorringham
Date: Thu May 25 09:16:11 2017
New Revision: 303861
URL: http://llvm.org/viewvc/llvm-project?rev=303861&view=rev
Log:
[AMDGPU] add __builtin_amdgcn_s_getpc
Summary: Added the builtin corresponding to the s_getpc intrinsic added in llvm
D32862
Subscribers: kzhuravl, wdng, n
Author: marshall
Date: Thu May 25 09:20:26 2017
New Revision: 303862
URL: http://llvm.org/viewvc/llvm-project?rev=303862&view=rev
Log:
Last commit included some extra constexpr; remove them
Modified:
libcxx/trunk/include/algorithm
Modified: libcxx/trunk/include/algorithm
URL:
http://llvm.or
mclow.lists created this revision.
`__wrap_iter` is an internal libc++ class that is used as an iterator type when
(for some reason) we don't want to use raw pointers as an iterator. It is the
iterator type for `vector` and `string` (but not `array` - not sure why). If we
used pointers, all th
mclow.lists added inline comments.
Comment at: include/iterator:1409
-private:
+// private:
#if _LIBCPP_DEBUG_LEVEL >= 2
This is testing debris - making the constructors public for testing.
https://reviews.llvm.org/D33550
_
Author: ericwf
Date: Thu May 25 09:58:46 2017
New Revision: 303867
URL: http://llvm.org/viewvc/llvm-project?rev=303867&view=rev
Log:
[coroutines] Bump __cpp_coroutines version
Summary: This patch is needed so that Libc++ can actually tess if Clang
supports coroutines, instead of just paying lip
Author: ericwf
Date: Thu May 25 09:59:39 2017
New Revision: 303868
URL: http://llvm.org/viewvc/llvm-project?rev=303868&view=rev
Log:
[coroutines] Diagnose when promise types fail to declare either return_void or
return_value.
Summary:
According to the PDTS it's perfectly legal to have a promise
Author: ericwf
Date: Thu May 25 10:24:04 2017
New Revision: 303871
URL: http://llvm.org/viewvc/llvm-project?rev=303871&view=rev
Log:
Make git-clang-format python 3 compatible
Summary: This patch attempts to make `git-clang-format` both python2 and
python3 compatible. Currently it only works in p
Author: erichkeane
Date: Thu May 25 10:39:24 2017
New Revision: 303872
URL: http://llvm.org/viewvc/llvm-project?rev=303872&view=rev
Log:
Disable MSVC-Compat mode for two tests that use C++Operator Names
MSVC doesn't support C++ operator names (using 'or' instead of ||,
'not' instead of '!', etc)
Author: jroelofs
Date: Thu May 25 10:42:13 2017
New Revision: 303873
URL: http://llvm.org/viewvc/llvm-project?rev=303873&view=rev
Log:
Don't defer to the GCC driver for linking arm-baremetal
Also comes with a cmake cache for building the runtime bits:
$ cmake \
-DBAREMETAL_ARMV6M_SYSROOT=/p
jroelofs closed this revision.
jroelofs added a comment.
r303873
https://reviews.llvm.org/D33259
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: epilk
Date: Thu May 25 10:43:31 2017
New Revision: 303874
URL: http://llvm.org/viewvc/llvm-project?rev=303874&view=rev
Log:
Add support for shared_ptr
Fixes PR27566.
Differential revision: https://reviews.llvm.org/D30837
Added:
libcxx/trunk/test/libcxx/utilities/memory/util.smartpt
This revision was automatically updated to reflect the committed changes.
Closed by commit rL303874: Add support for shared_ptr (authored
by epilk).
Changed prior to commit:
https://reviews.llvm.org/D30837?vs=97313&id=100251#toc
Repository:
rL LLVM
https://reviews.llvm.org/D30837
Files:
Author: marshall
Date: Thu May 25 11:05:54 2017
New Revision: 303876
URL: http://llvm.org/viewvc/llvm-project?rev=303876&view=rev
Log:
Mark LWG#2900 as complete - we already do this, and I checked the tests in a
couple days ago (r303268 & r303824)
Modified:
libcxx/trunk/www/cxx1z_status.html
Author: erichkeane
Date: Thu May 25 11:07:19 2017
New Revision: 303877
URL: http://llvm.org/viewvc/llvm-project?rev=303877&view=rev
Log:
Clang-tidy doesn't understand -fno-ms-compatibility, so just removing 'not'
Modified:
clang-tools-extra/trunk/test/clang-tidy/readability-implicit-bool-cas
Author: epilk
Date: Thu May 25 11:16:17 2017
New Revision: 303878
URL: http://llvm.org/viewvc/llvm-project?rev=303878&view=rev
Log:
Fix a test that was failing in C++11 mode introduced in r303874
Modified:
libcxx/trunk/test/libcxx/utilities/memory/util.smartptr/util.smartptr.shared/function_
In addition to this making clang-cl silently accept invalid code, it also
breaks existing valid code, building chromium now fails. Let's revert and
come up with something better asynchronously.
FAILED:
obj/third_party/WebKit/Source/core/dom/dom/CustomElementRegistry.obj
E:\b\c\goma_client/gomacc.e
How does chromium compiler in CL? It seems that it would have a similar
problem here…
From: tha...@google.com [mailto:tha...@google.com] On Behalf Of Nico Weber
Sent: Thursday, May 25, 2017 9:16 AM
To: Blower, Melanie
Cc: rnk ; Keane, Erich ; cfe-commits
; Hans Wennborg
Subject: RE: r303798 -
Author: jroelofs
Date: Thu May 25 11:20:51 2017
New Revision: 303880
URL: http://llvm.org/viewvc/llvm-project?rev=303880&view=rev
Log:
Relax testcase to appease buildbots
When lld isn't built, the tests as they were previously, were too picky about
the path to the linker.
Modified:
cfe/trunk
Author: erichkeane
Date: Thu May 25 11:23:00 2017
New Revision: 303881
URL: http://llvm.org/viewvc/llvm-project?rev=303881&view=rev
Log:
Revert 303872/303877 since the patch that caused these issues
is also being reverted.
Modified:
clang-tools-extra/trunk/test/clang-tidy/readability-implic
Author: erichkeane
Date: Thu May 25 11:24:49 2017
New Revision: 303882
URL: http://llvm.org/viewvc/llvm-project?rev=303882&view=rev
Log:
Revert MSVC CXXOperatorNames patch due to issues with Chromium
Modified:
cfe/trunk/lib/Frontend/CompilerInvocation.cpp
cfe/trunk/test/Parser/MicrosoftEx
Patch and Buildbot fixes all reverted as of –r303882. Sorry for the thrash.
From: tha...@google.com [mailto:tha...@google.com] On Behalf Of Nico Weber
Sent: Thursday, May 25, 2017 9:16 AM
To: Blower, Melanie
Cc: rnk ; Keane, Erich ; cfe-commits
; Hans Wennborg
Subject: RE: r303798 - For Micros
On Thu, May 25, 2017 at 12:18 PM, Keane, Erich
wrote:
> How does chromium compiler in CL? It seems that it would have a similar
> problem here…
>
That's a good question! It looks like iso646.h is included, and in MSVC
that contains something like `#define and &&`. But clang's
lib/Headers/iso646
Sometimes it’s possible to reason with the open source community, then they
change their code and make modifications which accommodate the various
compilers. E.g. we could ask chromium team if they could use the operator
symbol instead of ‘and’.
From: Nico Weber [mailto:tha...@google.com]
Sent:
No problem, I definitely think it was the right choice.
A change that contains all of what Melanie’s original patch did, plus the
Header changes (plus the clang-tidy fixes that came out of this) would be
acceptable?
Also, I believe she’s working on the warning as well. We were discussing it,
EricWF marked 6 inline comments as done.
EricWF added inline comments.
Comment at: include/__locale:370
static const mask blank = _ISblank;
-#elif defined(_LIBCPP_MSVCRT)
+#elif defined(_LIBCPP_WIN32API)
typedef unsigned short mask;
compnerd wrote:
> A
ilya-biryukov updated this revision to Diff 100262.
ilya-biryukov added a comment.
- Fixed file comment of ClangdTests.cpp
https://reviews.llvm.org/D33416
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdServer.cpp
clangd/ClangdServer.h
clangd/ClangdUnit.cpp
clangd/ClangdUnit.h
clangd
Among the goals of the clang-cl project are a) being able to parse MS
system headers b) helper users to write standards-compliant C++ (in
particular, if your code builds with clang-cl without warnings, it'd be
good if it also built with regular clang then).
The regular change plus header change pl
Eugene.Zelenko added a comment.
Please mention this check in docs/ReleaseNotes.rst (in alphabetical order).
Comment at: docs/clang-tidy/checks/misc-exception-escape.rst:7
+Finds functions which should not throw exceptions:
++ Destructors
++ Copy constructors
I
EricWF marked 3 inline comments as done.
EricWF added a comment.
In https://reviews.llvm.org/D33082#760516, @martell wrote:
> I want to give some context here to dispel the confusion of what is and isn't
> win32 api specific.
>
> First lets take `vasprintf` and `asprintf ` which are not implemen
Author: eugenezelenko
Date: Thu May 25 12:22:29 2017
New Revision: 303884
URL: http://llvm.org/viewvc/llvm-project?rev=303884&view=rev
Log:
[Documentation] Mention hicpp check group in Clang-tidy main document.
Modified:
clang-tools-extra/trunk/docs/clang-tidy/index.rst
Modified: clang-tools
EricWF updated this revision to Diff 100263.
EricWF added a comment.
Add `_LIBCPP_MSVCRT_LIKE` and use it to replace `_LIBCPP_WIN32API` where
appropriate.
https://reviews.llvm.org/D33082
Files:
include/__config
include/__locale
include/locale
include/stdio.h
include/support/win32/loc
EricWF added a comment.
In https://reviews.llvm.org/D33080#754442, @compnerd wrote:
> I think that we should sink the `min`/`max` checks into `__undef_macros`. I
> don't like the idea of littering that check everywhere.
I would much rather litter at the cost of the implementation than needles
Hello Jonathan,
This commit broke one of our builders:
http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/2608/steps/build-unified-tree/logs/stdio
Please have a look at this?
Thanks
Galina
On Thu, May 25, 2017 at 8:42 AM, Jonathan Roelofs via cfe-commits <
cfe-com
Author: caseycarter
Date: Thu May 25 12:42:17 2017
New Revision: 303888
URL: http://llvm.org/viewvc/llvm-project?rev=303888&view=rev
Log:
[test] Workaround C1XX bug in uses_allocator_types.hpp
VSO#109062 "Explicit template argument specification with empty template
parameter pack expansion does
Author: caseycarter
Date: Thu May 25 12:42:21 2017
New Revision: 303889
URL: http://llvm.org/viewvc/llvm-project?rev=303889&view=rev
Log:
[test] Remove workaround for C1XX conversion-to-nullptr bug
VSO#391542 "Types can't be convertible to nullptr_t"
Also put internal bug numbers on the workarou
This revision was automatically updated to reflect the committed changes.
Closed by commit rL303888: [test] Workaround C1XX bug in
uses_allocator_types.hpp (authored by CaseyCarter).
Changed prior to commit:
https://reviews.llvm.org/D33214?vs=99086&id=100264#toc
Repository:
rL LLVM
https://
This revision was automatically updated to reflect the committed changes.
CaseyCarter marked an inline comment as done.
Closed by commit rL303889: [test] Remove workaround for C1XX
conversion-to-nullptr bug (authored by CaseyCarter).
Changed prior to commit:
https://reviews.llvm.org/D33290?vs=9
EricWF updated this revision to Diff 100269.
EricWF added a comment.
- Remove the external include guards for `__undef_macros` as requested by
@compnerd.
I couldn't come up with a easy test case that showed any notable difference
having the external guards.
https://reviews.llvm.org/D33080
Fi
EricWF added a comment.
@mclow.lists Could you update this diff with more context?
https://reviews.llvm.org/D33550
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ericwf
Date: Thu May 25 13:52:34 2017
New Revision: 303895
URL: http://llvm.org/viewvc/llvm-project?rev=303895&view=rev
Log:
Update coroutine_handle::promise to reflect N4663.
This patch updates the promise() member to match the current spec.
Specifically it removes the non-const overload
Author: jroelofs
Date: Thu May 25 13:55:22 2017
New Revision: 303898
URL: http://llvm.org/viewvc/llvm-project?rev=303898&view=rev
Log:
Appease more buildbots about r303873
Modified:
cfe/trunk/lib/Driver/ToolChains/BareMetal.cpp
Modified: cfe/trunk/lib/Driver/ToolChains/BareMetal.cpp
URL:
ht
On 5/25/17 11:39 AM, Galina Kistanova wrote:
Hello Jonathan,
This commit broke one of our builders:
http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/2608/steps/build-unified-tree/logs/stdio
Please have a look at this?
r303898 should take care of that.
Jon
Author: bion
Date: Thu May 25 14:01:14 2017
New Revision: 303899
URL: http://llvm.org/viewvc/llvm-project?rev=303899&view=rev
Log:
Add asserts that the nullptr is maintained in string erase operations.
Modified:
libcxx/trunk/test/std/strings/basic.string/string.modifiers/string_erase/iter.pa
BillyONeal closed this revision.
BillyONeal added a comment.
In https://reviews.llvm.org/D33340#764206, @EricWF wrote:
> Sorry for the delay reviewing such a simple change.
No problem! Their simplicity also means no likely merge conflicts :)
In https://reviews.llvm.org/D33340#764213, @EricWF w
Author: ericwf
Date: Thu May 25 14:04:55 2017
New Revision: 303900
URL: http://llvm.org/viewvc/llvm-project?rev=303900&view=rev
Log:
Update more coroutine_handle signatures to reflect N4663.
Thanks to Casey Carter for pointing out the out-of-date tests and
implementation.
Modified:
libcxx/tr
timshen added a comment.
In https://reviews.llvm.org/D33525#764251, @chandlerc wrote:
> (focusing on the LLVM side of this review for now)
>
> Can you add an LLVM-based test? Can you add this to
> `lib/Passes/PassRegistry.def`?
I see that not all passes are registered (BitcodeWriterPass). Is i
aoli created this revision.
Herald added a subscriber: mgorny.
Thoes files are used to build Android toolchain.
https://reviews.llvm.org/D32816 makes it possible to build runtimes for targets.
https://reviews.llvm.org/D33561
Files:
cmake/caches/Android-stage2.cmake
cmake/caches/Android.cma
aoli updated this revision to Diff 100282.
aoli added a comment.
Fix wrong flags.
https://reviews.llvm.org/D33561
Files:
cmake/caches/Android-stage2.cmake
cmake/caches/Android.cmake
Index: cmake/caches/Android.cmake
===
--- /
jroelofs added a comment.
what about the builtins?
https://reviews.llvm.org/D33561
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
pcc added inline comments.
Comment at: clang/test/CodeGen/thin_link_bitcode.c:5
+// RUN: %clang_cc1 -o %t -flto=thin -fexperimental-new-pass-manager
-fthin-link-bitcode=%t.newpm -triple x86_64-unknown-linux-gnu -emit-llvm-bc %s
+// RUN: llvm-bcanalyzer -dump %t.newpm | FileCheck
I agree with Nico in retrospect. Setting -fno-operator-names is too big a
hammer. Instead we should add some MSVCCompat hacks to pretend we saw an
identifier token instead of a keyword token when these keywords are used as
declarators.
On Thu, May 25, 2017 at 10:14 AM, Nico Weber wrote:
> Among
aaron.ballman created this revision.
We do not explicitly model integer promotions on unary operators even though
those promotions happen in practice. This patch tracks the most important piece
of information about the promotion on the AST node: whether the operator can
overflow or not. It then
Author: rnk
Date: Thu May 25 15:28:26 2017
New Revision: 303908
URL: http://llvm.org/viewvc/llvm-project?rev=303908&view=rev
Log:
Revert "[AMDGPU] add __builtin_amdgcn_s_getpc"
This reverts commit r303861, the LLVM intrinsic was reverted.
Modified:
cfe/trunk/include/clang/Basic/BuiltinsAMDGP
Author: erichkeane
Date: Thu May 25 15:29:17 2017
New Revision: 303909
URL: http://llvm.org/viewvc/llvm-project?rev=303909&view=rev
Log:
Earlier revert introduced an extra space, remove it.
Modified:
clang-tools-extra/trunk/test/clang-tidy/readability-implicit-bool-cast.cpp
Modified:
clang-
Author: hans
Date: Thu May 25 15:39:52 2017
New Revision: 303910
URL: http://llvm.org/viewvc/llvm-project?rev=303910&view=rev
Log:
Make test/Driver/baremetal.cpp pass on Windows
Modified:
cfe/trunk/test/Driver/baremetal.cpp
Modified: cfe/trunk/test/Driver/baremetal.cpp
URL:
http://llvm.org/
The test was failing on Windows; r303910 for that.
On Thu, May 25, 2017 at 11:55 AM, Jonathan Roelofs via cfe-commits
wrote:
>
>
> On 5/25/17 11:39 AM, Galina Kistanova wrote:
>
> Hello Jonathan,
>
> This commit broke one of our builders:
>
> http://lab.llvm.org:8011/builders/llvm-clang-x86_64-ex
Prazek added a comment.
How is that compared to https://reviews.llvm.org/D19201 and the clang patch
mentioned in this patch?
Repository:
rL LLVM
https://reviews.llvm.org/D33537
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists
aaron.ballman added a comment.
Once you fix the typo in the check, can you run it over some large C++ code
bases to see if it finds any results?
Comment at: clang-tidy/misc/DefaultNumericsCheck.cpp:30
+ ofClass(classTemplateSpecializationDecl(
+ h
alexshap added inline comments.
Comment at: clang-tidy/misc/DefaultNumericsCheck.h:20
+/// This check flags usages of ``std::numeric_limits::{min,max}()`` for
+/// unspecialized types. It is dangerous because it returns T(), which might is
+/// rarely minimum or maximum for this
Author: aaronballman
Date: Thu May 25 16:02:49 2017
New Revision: 303913
URL: http://llvm.org/viewvc/llvm-project?rev=303913&view=rev
Log:
Update the getting started documentation to match the corresponding LLVM commit
in r303912.
Modified:
cfe/trunk/www/get_started.html
Modified: cfe/trunk
aaron.ballman closed this revision.
aaron.ballman added a comment.
Commit in r303913
https://reviews.llvm.org/D33547
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
MatzeB added a comment.
FWIW, I think this makes sense.
Moving O0 and optnone get closer seems sensible. Even though -O3 with an
optnone function indeed gives you different results today.
We are basically maintaining two things for the same "do not optimize" goal.
This obviously won't make O0 and
t.p.northover created this revision.
Herald added a subscriber: mcrosier.
For the simple casts in the test, we were crashing because the
ZeroInitialization function created an LValue with an unexpected
SubobjectDesignator: it was valid but didn't actually refer to a valid
MostDerivedType.
Sinc
rsmith added inline comments.
Comment at: clang/lib/AST/ExprConstant.cpp:5498-5500
Result.set((Expr*)nullptr, 0, false, true, Offset);
+Result.getLValueDesignator() =
+SubobjectDesignator(E->getType()->getPointeeType());
This is the only caller o
On 5/25/17 2:41 PM, Hans Wennborg wrote:
The test was failing on Windows; r303910 for that.
Oh yuk.. thanks for fixing that.
Jon
On Thu, May 25, 2017 at 11:55 AM, Jonathan Roelofs via cfe-commits
wrote:
On 5/25/17 11:39 AM, Galina Kistanova wrote:
Hello Jonathan,
This commit broke o
aoli updated this revision to Diff 100308.
aoli added a comment.
Add builtin configurations.
https://reviews.llvm.org/D33561
Files:
cmake/caches/Android-stage2.cmake
cmake/caches/Android.cmake
Index: cmake/caches/Android.cmake
==
aoli added a comment.
@jroelofs we are not building builtins currently but we are planning to do so.
I just added some basic configurations for builtins.
https://reviews.llvm.org/D33561
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:/
Author: martell
Date: Thu May 25 17:37:15 2017
New Revision: 303928
URL: http://llvm.org/viewvc/llvm-project?rev=303928&view=rev
Log:
libcxx: fix bootstrapping for mingw-w64
Differential Revision: https://reviews.llvm.org/D33388
Modified:
libcxx/trunk/cmake/config-ix.cmake
libcxx/trunk/i
Author: ericwf
Date: Thu May 25 17:43:42 2017
New Revision: 303929
URL: http://llvm.org/viewvc/llvm-project?rev=303929&view=rev
Log:
Correct typo: LIBCXXABI_BUILTINS_LIBRARY -> LIBCXX_BUILTINS_LIBRARY
Modified:
libcxx/trunk/cmake/config-ix.cmake
Modified: libcxx/trunk/cmake/config-ix.cmake
U
Author: rsmith
Date: Thu May 25 17:47:05 2017
New Revision: 303930
URL: http://llvm.org/viewvc/llvm-project?rev=303930&view=rev
Log:
Switch from using a DiagnosticTrap and a note for "while defining a special
member function" context notes to registering an entry on the context stack.
Also reorde
rsmith added a comment.
Do we need to conditionalize this part of libc++? Nothing in the
header appears to need compiler support.
https://reviews.llvm.org/D33538
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
george.karpenkov added a comment.
@vsk Looks reasonable to me, although I would say such a change should probably
require more tests.
However, I am not a C++ expert, and I am still not overly familiar with a
codebase, so I'm not sure whether I should be a single reviewer.
https://reviews.llvm.
rsmith added a comment.
In https://reviews.llvm.org/D33538#765045, @rsmith wrote:
> Do we need to conditionalize this part of libc++? Nothing in the
> header appears to need compiler support.
Oh wait, I see what's going on. You're not testing for whether coroutines is
enabled, you're testing
Author: rtrieu
Date: Thu May 25 18:03:08 2017
New Revision: 303932
URL: http://llvm.org/viewvc/llvm-project?rev=303932&view=rev
Log:
Make test/Driver/baremetal.cpp work when output directory isn't named 'bin'.
Modified:
cfe/trunk/test/Driver/baremetal.cpp
Modified: cfe/trunk/test/Driver/bar
1 - 100 of 130 matches
Mail list logo
