coby created this revision.
This patch introduces X86AsmParser with the ability to handle the
aforementioned ops within compound "MS" arithmetical expressions. Currently -
only supported as a stand alone Operand, e.g.:
"TYPE X"
now allowed :
"4 + TYPE X * 128"
LLVM side: https://reviews.llvm.or
smaksimovic updated this revision to Diff 92439.
smaksimovic added a comment.
Added a new test to test/CodeGen/builtins-mips-msa.c, covering the new extended
range for ldi.b.
https://reviews.llvm.org/D31082
Files:
lib/Sema/SemaChecking.cpp
test/CodeGen/builtins-mips-msa-error.c
test/Code
jaykang10 added a comment.
In https://reviews.llvm.org/D30810#702637, @jaykang10 wrote:
> In https://reviews.llvm.org/D30810#702614, @Anastasia wrote:
>
> > In https://reviews.llvm.org/D30810#702443, @bruno wrote:
> >
> > > > As a result, I think it would be good for clang to have both of
> > >
arphaman created this revision.
When ARC is enabled in Objective-C++, comparisons between a pointer and
Objective-C object pointer typically result in errors like this: `invalid
operands to a binary expression`. This error message can be quite confusing as
it doesn't provide a solution to the p
rmaprath created this revision.
Herald added a subscriber: aemerson.
This test was failing on our downstream (bare-metal) runs and only now I got
around to investigate it.
The problem is, this test assumes the Itanium ABI, whereas EHABI requires the
exception address to be 8-byte aligned.
I wa
Author: rizsotto
Date: Tue Mar 21 05:15:18 2017
New Revision: 298355
URL: http://llvm.org/viewvc/llvm-project?rev=298355&view=rev
Log:
[scan-build-py] reuse command line output parameter for report directory
Differential Revision: https://reviews.llvm.org/D30861
Modified:
cfe/trunk/tools/sca
rmaprath updated this revision to Diff 92450.
rmaprath added a comment.
Fixed a few paths.
https://reviews.llvm.org/D31178
Files:
test/libcxxabi/test/config.py
test/lit.site.cfg.in
test/test_exception_address_alignment.pass.cpp
Index: test/test_exception_address_alignment.pass.cpp
=
ioeric added a comment.
Ping ;)
https://reviews.llvm.org/D30493
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ioeric added a comment.
Ping ;)
https://reviews.llvm.org/D30777
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rengolin added a comment.
This looks like a simple oversight from my perspective, so looks good.
But I'll let the others have a look at it, as I'm not overly familiar with
libcxxabi.
cheers,
--renato
https://reviews.llvm.org/D31178
___
cfe-commit
arphaman added a comment.
In https://reviews.llvm.org/D30009#705699, @aaron.ballman wrote:
> In https://reviews.llvm.org/D30009#705649, @efriedma wrote:
>
> > Looking over the most recent version, I'm happy with the general semantics
> > of push with apply_only_to. I'm not sure I see the point
ioeric added a comment.
I think this is a great start!
First round with some nits.
Comment at: clang-rename/RenamingAction.cpp:87
+class QualifiedRenamingASTConsumer : public ASTConsumer {
+public:
Comments.
Comment at: clang-rename/Renam
arphaman created this revision.
Repository:
rL LLVM
https://reviews.llvm.org/D31179
Files:
include/clang/Basic/DiagnosticParseKinds.td
include/clang/Sema/Sema.h
lib/Parse/ParseObjc.cpp
lib/Sema/SemaDeclObjC.cpp
test/SemaObjC/attr-deprecated.m
test/SemaObjC/category-attribute.m
te
arphaman added a comment.
Sorry about an empty body, I had a keyboard malfunction. I have updated the
patch now.
Repository:
rL LLVM
https://reviews.llvm.org/D31179
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
There are a number of users of the clang static analyser back-end for
intelligent code completion. Irony-Mode for emacs, for example. For a while
people have been reporting an issue with not getting completions for protected
members of parent classes and I believe this patch solves the bug: simp
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
Sorry, I missed this patch.
LGTM with one nit.
Comment at: change-namespace/ChangeNamespace.cpp:296
+assert(!NsSplitted.empty());
+for (auto I = NsSplitted.begin() +
Hi,
Can you please add a suitable test-case? Clang's code-completion tests are
normally in test/CodeCompletion or test/Index.
Cheers,
Alex
On 21 March 2017 at 12:05, Dixon Ryan (ETAS/ERS-PD2) via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> There are a number of users of the clang static
echuraev created this revision.
Herald added a subscriber: yaxunl.
https://reviews.llvm.org/D31183
Files:
include/clang/Parse/Parser.h
lib/Parse/ParseExpr.cpp
test/Parser/vector-cast-define.cl
Index: test/Parser/vector-cast-define.cl
ioeric added inline comments.
Comment at: change-namespace/ChangeNamespace.cpp:296
+assert(!NsSplitted.empty());
+for (auto I = NsSplitted.begin() + 1, E = NsSplitted.end(); I != E; ++I) {
+ if (*I == SymbolSplitted.front())
hokein wrote:
> ioeric wr
Hahnfeld added a comment.
In principal looks good to me although I'm not really familiar with this part.
Does that work for you if you have the `declare simd` in a header file and the
implementation in another file? On x86_64 I currently get:
remark: loop not vectorized: call instruction cann
ioeric updated this revision to Diff 92475.
ioeric added a comment.
- fixed newly added tests.
https://reviews.llvm.org/D30493
Files:
change-namespace/ChangeNamespace.cpp
unittests/change-namespace/ChangeNamespaceTests.cpp
Index: unittests/change-namespace/ChangeNamespaceTests.cpp
Author: ioeric
Date: Tue Mar 21 07:41:59 2017
New Revision: 298363
URL: http://llvm.org/viewvc/llvm-project?rev=298363&view=rev
Log:
[change-namespace] avoid adding leading '::' when possible.
Summary:
When changing namespaces, the tool adds leading "::" to references that need to
be fully-qualif
This revision was automatically updated to reflect the committed changes.
Closed by commit rL298363: [change-namespace] avoid adding leading '::' when
possible. (authored by ioeric).
Changed prior to commit:
https://reviews.llvm.org/D30493?vs=92475&id=92476#toc
Repository:
rL LLVM
https://r
Author: rksimon
Date: Tue Mar 21 07:46:13 2017
New Revision: 298364
URL: http://llvm.org/viewvc/llvm-project?rev=298364&view=rev
Log:
[X86][AVX512] Add _mm512_cvtsd_f64 and _mm512_cvtss_f32 intrinsics (PR32305)
Differential Revision: https://reviews.llvm.org/D31155
Modified:
cfe/trunk/lib/He
This revision was automatically updated to reflect the committed changes.
Closed by commit rL298364: [X86][AVX512] Add _mm512_cvtsd_f64 and
_mm512_cvtss_f32 intrinsics (PR32305) (authored by RKSimon).
Changed prior to commit:
https://reviews.llvm.org/D31155?vs=92390&id=92477#toc
Repository:
xazax.hun added inline comments.
Comment at: lib/StaticAnalyzer/Core/Z3ConstraintManager.cpp:60
+// Set timeout to 15000ms = 15s
+Z3_set_param_value(Config, "timeout", "15000");
+ }
Sorry for being a bit late in the party, I was wondering whether this ti
Author: echuraev
Date: Tue Mar 21 07:55:55 2017
New Revision: 298366
URL: http://llvm.org/viewvc/llvm-project?rev=298366&view=rev
Log:
[OpenCL] Added implicit conversion rank for overloading functions with vector
data type in OpenCL
Summary: I added a new rank to ImplicitConversionRank enum to r
fpetrogalli added a comment.
In https://reviews.llvm.org/D30739#706292, @Hahnfeld wrote:
> In principal looks good to me although I'm not really familiar with this
> part. Does that work for you if you have the `declare simd` in a header file
> and the implementation in another file? On x86_64
Hahnfeld accepted this revision.
Hahnfeld added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D30739#706304, @fpetrogalli wrote:
> AFAIK, none of the machinery required in LLVM to expose the mangled names in
> the vectorizer is present in trunk. There is
fpetrogalli added a comment.
Thanks, I do not have commit rights, can anyone commit this?
https://reviews.llvm.org/D30739
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: echuraev
Date: Tue Mar 21 08:20:57 2017
New Revision: 298369
URL: http://llvm.org/viewvc/llvm-project?rev=298369&view=rev
Log:
[OpenCL] Added diagnostic for checking length of vector
Reviewers: Anastasia, cfe-commits
Reviewed By: Anastasia
Subscribers: bader, yaxunl
Differential Revisi
v.g.vassilev created this revision.
Consider:
`
struct MyClass {
void f() {}
}
MyClass::f(){} // expected error redefinition of f.
`
The routine fails to remove the lookup entry is registered in the semantic decl
context and not in the primary decl context of the lexical decl context where
v.g.vassilev updated this revision to Diff 92481.
v.g.vassilev edited the summary of this revision.
v.g.vassilev added a comment.
U
https://reviews.llvm.org/D31187
Files:
lib/AST/DeclBase.cpp
Index: lib/AST/DeclBase.cpp
===
Author: kromanova
Date: Tue Mar 21 08:34:06 2017
New Revision: 298371
URL: http://llvm.org/viewvc/llvm-project?rev=298371&view=rev
Log:
[DOXYGEN] Improvements to smmintrin.h and emmintrin.h intrinsics.
I made some small changes in smmintrin.h and emmintrin.h intrinsics.
- changed some regular co
Sending to mailing list.
From: Dixon Ryan (ETAS/ERS-PD2)
Sent: 21 March 2017 14:18
To: 'Alex L'
Subject: RE: SemaAccess bug (protected members of derived)
Hello, sorry this is the first time I have done this.
The test case is attached. It should fail without the patch and then should
pass with
arphaman added a comment.
Is it possible to test this change?
https://reviews.llvm.org/D31187
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Thanks, can you please attach a diff that includes both the code change and
the new test?
On 21 March 2017 at 14:18, Dixon Ryan (ETAS/ERS-PD2) via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Sending to mailing list.
>
>
>
> *From:* Dixon Ryan (ETAS/ERS-PD2)
> *Sent:* 21 March 2017 14:18
>
From path:
URL: http://llvm.org/svn/llvm-project/cfe/trunk
Relative URL: ^/cfe/trunk
From: Alex L [mailto:arpha...@gmail.com]
Sent: 21 March 2017 14:22
To: Dixon Ryan (ETAS/ERS-PD2)
Cc: cfe-commits@lists.llvm.org
Subject: Re: FW: SemaAccess bug (protected members of derived)
Thanks, can you ple
v.g.vassilev added a comment.
Not sure, this code is used by external tools. Maybe I could craft an example
but it would be very complex, bringing half of the third party tool codebase...
https://reviews.llvm.org/D31187
___
cfe-commits mailing list
yaron.keren added a comment.
Could use dumpDeclContext() to test?
https://reviews.llvm.org/D31187
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sfertile added a comment.
> I have a patch to do this now. I'll plan on committing it in a bit.
Is there a way to mark the -f form of the option as deprecated? We should warn
and suggest users switch to the -maltivec option for a release to give people a
chance to update their builds.
https:/
yaxunl abandoned this revision.
yaxunl added a comment.
We consider to switch to use 0 as generic address space and abandon this since
0 as generic address space is more agreeable to both LLVM and Clang's
convention.
https://reviews.llvm.org/D27627
__
yaxunl accepted this revision.
yaxunl added a comment.
This revision is now accepted and ready to land.
Comment at: lib/AST/ASTContext.cpp:2696
+ ArySize = ArySize.zextOrTrunc(
+ Target->getPreferredPointerWidth(getTargetAddressSpace(EltTy)));
Can we j
jroelofs added a comment.
Can you clarify the logic here? It's my understanding that:
`-fno-exceptions` does *not* imply `-fno-unwind-tables`
however:
`-fno-unwind-tables` *does* imply that exceptions cannot be used on targets
that require the tables to do unwinding.
https://reviews.llvm.org
v.g.vassilev created this revision.
In the context of cling, we need to recover the parser from errors. This patch
is essential for us and we would like to move it from our fork to clang proper.
Repository:
rL LLVM
https://reviews.llvm.org/D31190
Files:
lib/Parse/ParseCXXInlineMethods.cpp
The current infrastructure for vector names generation works only for
function definition. Ideally we should implement it also for function
definition provided by external libraries
Right, we need to fix that to support #pragma omp declare simd on function
declaration as well to
nathawes accepted this revision.
nathawes added a comment.
This revision is now accepted and ready to land.
Thanks for this – looks good to me!
Repository:
rL LLVM
https://reviews.llvm.org/D31179
___
cfe-commits mailing list
cfe-commits@lists.llv
aaron.ballman added inline comments.
Comment at: test/SemaObjC/attr-deprecated.m:124-128
+@interface A(Blah) // no warning
+- (A*)getA;
@end
+@implementation A(Blah) // no warning
I would have assumed the use in the `@implementation` would have been enough to
Author: bruno
Date: Tue Mar 21 11:43:51 2017
New Revision: 298391
URL: http://llvm.org/viewvc/llvm-project?rev=298391&view=rev
Log:
[Modules] Find PrivateHeaders when looking into subframeworks
Fix the current parsing of subframeworks in modulemaps to lookup for
headers based on whether they are
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D31130
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
aaron.ballman added a comment.
In https://reviews.llvm.org/D30009#706171, @arphaman wrote:
> I would be ok with that. We could merge `apply_to` and `apply_only_to` into a
> single `apply_to` matching rule set specifier (it would behave like
> `apply_only_to`).
That sounds sensible to me.
> I
ABataev added a comment.
Guys, sorry for the delay with the reviews. I was on a vacation, now I'm on a
relocation process. Will look at all patches as soon as possible, but not
earlier than next week :( Sorry again.
https://reviews.llvm.org/D30739
___
rjmccall added a comment.
Okay. That does seem more sensible than trying to change everything around the
other way.
https://reviews.llvm.org/D27627
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
Author: akirtzidis
Date: Tue Mar 21 11:56:02 2017
New Revision: 298392
URL: http://llvm.org/viewvc/llvm-project?rev=298392&view=rev
Log:
[index/AST] Determine if a typedef shares a name and spelling location with its
underlying tag type
In such a case, as when using the NS_ENUM macro, for indexi
Author: rnk
Date: Tue Mar 21 11:57:30 2017
New Revision: 298394
URL: http://llvm.org/viewvc/llvm-project?rev=298394&view=rev
Log:
Update Clang for LLVM rename AttributeSet -> AttributeList
Modified:
cfe/trunk/lib/CodeGen/CGBuiltin.cpp
cfe/trunk/lib/CodeGen/CGCXX.cpp
cfe/trunk/lib/Code
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
Repository:
rL LLVM
https://reviews.llvm.org/D31174
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
uweigand added a comment.
In https://reviews.llvm.org/D30415#705889, @echristo wrote:
> In https://reviews.llvm.org/D30415#705196, @uweigand wrote:
>
> > Well, mainline GCC doesn't have -faltivec at all and never had, I think
> > this was only an Apple GCC extension ... Not sure what exactly th
arphaman added a comment.
In https://reviews.llvm.org/D30009#706515, @aaron.ballman wrote:
> In https://reviews.llvm.org/D30009#706171, @arphaman wrote:
>
> > I would be ok with that. We could merge `apply_to` and `apply_only_to` into
> > a single `apply_to` matching rule set specifier (it would
Author: erichkeane
Date: Tue Mar 21 12:49:17 2017
New Revision: 298410
URL: http://llvm.org/viewvc/llvm-project?rev=298410&view=rev
Log:
Correct class-template deprecation behavior
Based on the comment in the test, and my reading of the standard, a deprecated
warning should be issued in the foll
This revision was automatically updated to reflect the committed changes.
Closed by commit rL298410: Correct class-template deprecation behavior
(authored by erichkeane).
Changed prior to commit:
https://reviews.llvm.org/D27486?vs=84330&id=92514#toc
Repository:
rL LLVM
https://reviews.llvm.
arphaman added inline comments.
Comment at: test/SemaObjC/attr-deprecated.m:124-128
+@interface A(Blah) // no warning
+- (A*)getA;
@end
+@implementation A(Blah) // no warning
aaron.ballman wrote:
> I would have assumed the use in the `@implementation` would ha
brenoguim marked 4 inline comments as done.
brenoguim added a comment.
Hi @aaron.ballman,
Thanks for the review!
I don't have rights to push this. Who should I contact to push the change in my
behalf?
https://reviews.llvm.org/D31130
___
cfe-commi
aaron.ballman added a comment.
In https://reviews.llvm.org/D31130#706623, @brenoguim wrote:
> Hi @aaron.ballman,
>
> Thanks for the review!
>
> I don't have rights to push this. Who should I contact to push the change in
> my behalf?
I'm happy to do so on your behalf (it'll happen later this a
Thanks,
It looks like your solution isn't quite right as it causes Clang to accept
invalid access to protected members, e.g. as tested by
"test/CXX/class.access/class.protected/p1.cpp".
Do you think there's an alternative solution that you could use?
Alex
On 21 March 2017 at 14:48, Dixon Ryan (
brenoguim added a comment.
I appreciate it!
https://reviews.llvm.org/D31130
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: dexonsmith
Date: Tue Mar 21 13:26:18 2017
New Revision: 298414
URL: http://llvm.org/viewvc/llvm-project?rev=298414&view=rev
Log:
Modules: Remove an invalid check in unit tests for r298278
This is a fixup for the unit tests from r298278 (originally r298165).
Since the buffer that RawB2 po
bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.
LGTM Alex, thanks!
Repository:
rL LLVM
https://reviews.llvm.org/D31134
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm
Author: marshall
Date: Tue Mar 21 13:38:57 2017
New Revision: 298416
URL: http://llvm.org/viewvc/llvm-project?rev=298416&view=rev
Log:
Implement P0548: 'common_type and duration' This involves a subtle change in
the return type of the unary +/- operators for std::chrono::duration, though I
expec
Author: marshall
Date: Tue Mar 21 13:40:46 2017
New Revision: 298418
URL: http://llvm.org/viewvc/llvm-project?rev=298418&view=rev
Log:
Add a bit more to one of the chrono tests
Modified:
libcxx/trunk/test/std/utilities/time/time.duration/time.duration.arithmetic/op_+.pass.cpp
Modified:
lib
Anastasia added a comment.
> Hi Anastasia, Bruno,
>
> Do you still have other opinion? or Can we go ahead and commit this patch?
I would like to see this patch committed. I see clear evidence of it improving
existing GPU targets in the master repo as well as outside of the main tree
implemen
Anastasia added a comment.
In https://reviews.llvm.org/D30810#699428, @Anastasia wrote:
> Would you be able to update ScalarExprEmitter::VisitAsTypeExpr implementation
> accordingly to make things consistent?
Not sure it got lost somewhere... do you think you could address this too?
https://
Anastasia added a comment.
In https://reviews.llvm.org/D30810#706676, @Anastasia wrote:
> In https://reviews.llvm.org/D30810#699428, @Anastasia wrote:
>
> > Would you be able to update ScalarExprEmitter::VisitAsTypeExpr
> > implementation accordingly to make things consistent?
>
>
> Not sure it
aaron.ballman updated this revision to Diff 92522.
aaron.ballman added a comment.
Missed a case for `UnaryExprOrTypeTraitExpr`.
https://reviews.llvm.org/D31153
Files:
include/clang/AST/Expr.h
include/clang/AST/StmtIterator.h
lib/AST/Expr.cpp
Index: lib/AST/Expr.cpp
==
Author: kzhuravl
Date: Tue Mar 21 13:55:39 2017
New Revision: 298420
URL: http://llvm.org/viewvc/llvm-project?rev=298420&view=rev
Log:
Fix array sizes where address space is not yet known
For variables in generic address spaces, for example:
```
unsigned char V[6442450944];
...
```
the address
This revision was automatically updated to reflect the committed changes.
kzhuravl marked an inline comment as done.
Closed by commit rL298420: Fix array sizes where address space is not yet known
(authored by kzhuravl).
Changed prior to commit:
https://reviews.llvm.org/D30845?vs=91404&id=92523
Author: aaronballman
Date: Tue Mar 21 14:01:17 2017
New Revision: 298421
URL: http://llvm.org/viewvc/llvm-project?rev=298421&view=rev
Log:
Prevent cppcoreguidelines-pro-bounds-array-to-pointer-decay from diagnosing
array to pointer decay stemming from system macros.
Patch by Breno Rodrigues Guim
aaron.ballman closed this revision.
aaron.ballman added a comment.
I've commit in r298421.
https://reviews.llvm.org/D31130
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: marshall
Date: Tue Mar 21 14:12:21 2017
New Revision: 298422
URL: http://llvm.org/viewvc/llvm-project?rev=298422&view=rev
Log:
Fix a couple of 'C++11'-isms from the last checkin, which broke the '03 bot.
Modified:
libcxx/trunk/include/type_traits
libcxx/trunk/test/std/utilities/t
Author: papin_g
Date: Tue Mar 21 14:17:53 2017
New Revision: 298424
URL: http://llvm.org/viewvc/llvm-project?rev=298424&view=rev
Log:
[CMake] fix CLANG_INCLUDE_DIRS CMake export
Summary:
This change should fixes the export of CLANG_INCLUDE_DIRS variable in
ClangConfig.cmake.
Unlike for the othe
danielcdh created this revision.
Herald added subscribers: Prazek, mehdi_amini.
Because SamplePGO passes will be invoked twice in ThinLTO build: once at
compile phase, the other at backend. We want to make sure the IR at the 2nd
phase matches the hot part in pro
file, thus we do not want to inli
On 03/21/2017 12:19 PM, Ulrich Weigand via Phabricator wrote:
uweigand added a comment.
In https://reviews.llvm.org/D30415#705889, @echristo wrote:
In https://reviews.llvm.org/D30415#705196, @uweigand wrote:
Well, mainline GCC doesn't have -faltivec at all and never had, I think this
was o
This revision was automatically updated to reflect the committed changes.
Closed by commit rL298426: [X86][MS-compatability][clang] allow MS
TYPE/SIZE/LENGTH operators as a part of… (authored by coby).
Changed prior to commit:
https://reviews.llvm.org/D31174?vs=92437&id=92529#toc
Repository:
Author: coby
Date: Tue Mar 21 14:33:32 2017
New Revision: 298426
URL: http://llvm.org/viewvc/llvm-project?rev=298426&view=rev
Log:
[X86][MS-compatability][clang] allow MS TYPE/SIZE/LENGTH operators as a part of
a compound expression
This patch introduces X86AsmParser with the ability to handle t
tejohnson accepted this revision.
tejohnson added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D31202
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
chrib added a comment.
In https://reviews.llvm.org/D31140#706411, @jroelofs wrote:
> Can you clarify the logic here? It's my understanding that:
>
> `-fno-exceptions` does *not* imply `-fno-unwind-tables`
>
> however:
>
> `-fno-unwind-tables` *does* imply that exceptions cannot be used on targets
Hi Erich,
Your change is causing the Sema/attr-deprecated.c test to fail on the PS4 bot
(http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/7087).
Can you take a look?
Douglas Yung
> -Original Message-
> From: cfe-commits [mailto:cfe-commits-boun.
ddcc added inline comments.
Comment at: lib/StaticAnalyzer/Core/Z3ConstraintManager.cpp:60
+// Set timeout to 15000ms = 15s
+Z3_set_param_value(Config, "timeout", "15000");
+ }
xazax.hun wrote:
> Sorry for being a bit late in the party, I was wondering w
ahatanak added inline comments.
Comment at: lib/Sema/SemaExpr.cpp:9431
+ ? 2
+ : 1)) {
if (convertPointersToCompositeType(*this, Loc, LHS, RHS))
It wasn't clear to me why the code has to be added to the right hand side of
the >= op
Author: dehao
Date: Tue Mar 21 14:55:46 2017
New Revision: 298429
URL: http://llvm.org/viewvc/llvm-project?rev=298429&view=rev
Log:
Clang change: Do not inline hot callsites for samplepgo in thinlto compile
phase.
Summary:
Because SamplePGO passes will be invoked twice in ThinLTO build: once at
dexonsmith added a comment.
Ping!
https://reviews.llvm.org/D30954
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On 3/21/17 1:53 PM, Christian Bruel via Phabricator wrote:
chrib added a comment.
In https://reviews.llvm.org/D31140#706411, @jroelofs wrote:
Can you clarify the logic here? It's my understanding that:
`-fno-exceptions` does *not* imply `-fno-unwind-tables`
however:
`-fno-unwind-tables` *
ahatanak added a comment.
I think you can add a test case in this patch (after the llvm changes are
checked in)?
Comment at: lib/CodeGen/CGExprScalar.cpp:262
+ApplyFPFeatures(llvm::IRBuilderBase &Builder, Expr *E)
+: CGBuilderTy::FastMathFlagGuard(Builder) {
+
I saw that, I was digging into it, then went to lunch. I'm hoping to push a
fix by EOD if I can.
Thanks for the heads up though!
-Original Message-
From: Yung, Douglas [mailto:douglas.y...@sony.com]
Sent: Tuesday, March 21, 2017 12:59 PM
To: Keane, Erich
Cc: cfe-commits
Subject: RE:
Author: gbiv
Date: Tue Mar 21 15:09:35 2017
New Revision: 298431
URL: http://llvm.org/viewvc/llvm-project?rev=298431&view=rev
Log:
Let llvm.objectsize be conservative with null pointers
D28494 adds another parameter to @llvm.objectsize. Clang needs to be
sure to pass that third arg whenever appli
Author: erichkeane
Date: Tue Mar 21 15:14:46 2017
New Revision: 298433
URL: http://llvm.org/viewvc/llvm-project?rev=298433&view=rev
Log:
iFix Test deprecation behavior in C89 mode as a result of r298410
Modified:
cfe/trunk/test/Sema/attr-deprecated.c
Modified: cfe/trunk/test/Sema/attr-deprec
Author: chandlerc
Date: Tue Mar 21 15:15:42 2017
New Revision: 298434
URL: http://llvm.org/viewvc/llvm-project?rev=298434&view=rev
Log:
Don't make unqualified calls to functions that could well be found via
ADL as reasonable extension points.
All of this would be cleaner if this code followed the
Ended up being simpler than I expected. I added -r298433 To fix this.
The issue is that the test had a conditional based on the "C" version, so I
explicitly added a test for C89 and C99, which the PS4 is apparently not
defaulting to.
Thanks!
-Erich
-Original Message-
From: Yung, D
leanil updated this revision to Diff 92542.
leanil added a comment.
Suppress warning only on std::enable_if.
Make note on copy and move constructors.
Repository:
rL LLVM
https://reviews.llvm.org/D30547
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/ForwardingReferenceOverloadCheck
Could you please take a look at these leaks
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/3606/steps/check-clang%20asan/logs/stdio
=
==32547==ERROR: LeakSanitizer: detected memory leaks
Direct leak of 24 byte
Author: marshall
Date: Tue Mar 21 16:05:28 2017
New Revision: 298438
URL: http://llvm.org/viewvc/llvm-project?rev=298438&view=rev
Log:
Fix test failure I introduced
Modified:
libcxx/trunk/include/type_traits
Modified: libcxx/trunk/include/type_traits
URL:
http://llvm.org/viewvc/llvm-project
1 - 100 of 155 matches
Mail list logo
