EricWF updated this revision to Diff 84440.
EricWF marked 2 inline comments as done.
EricWF added a comment.
- Address inline comments.
https://reviews.llvm.org/D28725
Files:
CMakeLists.txt
lib/CMakeLists.txt
test/CMakeLists.txt
test/libcxx/test/config.py
test/lit.site.cfg.in
test/s
Author: ericwf
Date: Sat Jan 14 01:54:39 2017
New Revision: 292006
URL: http://llvm.org/viewvc/llvm-project?rev=292006&view=rev
Log:
[libc++][CMake] Use debug MSVC runtimes when libc++ is built in debug mode
Summary: This patch allows libc++ to be built against the debug MSVC runtimes
instead of
Author: chapuni
Date: Sat Jan 14 02:54:05 2017
New Revision: 292007
URL: http://llvm.org/viewvc/llvm-project?rev=292007&view=rev
Log:
Add LLVMOption to clang-interpreter, corresponding to r291938.
Modified:
cfe/trunk/examples/clang-interpreter/CMakeLists.txt
Modified: cfe/trunk/examples/clan
Prazek created this revision.
Prazek added a reviewer: hans.
Prazek added a subscriber: cfe-commits.
It would be good to merge it to 4.0 branch.
https://reviews.llvm.org/D28727
Files:
docs/UsersManual.rst
Index: docs/UsersManual.rst
==
Author: ericwf
Date: Sat Jan 14 04:22:21 2017
New Revision: 292010
URL: http://llvm.org/viewvc/llvm-project?rev=292010&view=rev
Log:
Fix copy-paste errors in r292001
Modified:
libcxx/trunk/cmake/Modules/HandleLibcxxFlags.cmake
Modified: libcxx/trunk/cmake/Modules/HandleLibcxxFlags.cmake
URL:
Author: ericwf
Date: Sat Jan 14 04:27:12 2017
New Revision: 292011
URL: http://llvm.org/viewvc/llvm-project?rev=292011&view=rev
Log:
Fix Windows try_lock implementation
Modified:
libcxx/trunk/include/__threading_support
libcxx/trunk/src/mutex.cpp
libcxx/trunk/test/libcxx/test/config.p
Author: ericwf
Date: Sat Jan 14 04:31:43 2017
New Revision: 292012
URL: http://llvm.org/viewvc/llvm-project?rev=292012&view=rev
Log:
Mark test as UNSUPPORTED on Windows since it hangs forever
Modified:
libcxx/trunk/test/std/utilities/variant/variant.visit/visit.pass.cpp
Modified: libcxx/trun
alexfh added inline comments.
Comment at: clang-tidy/tool/run-clang-tidy.py:80
+ for arg in extra_arg:
+ start.append('-extra-arg=%s' % arg[0])
+ for arg in extra_arg_before:
Why arg[0] and not just arg?
https://reviews.llvm.org/D28334
___
EricWF created this revision.
EricWF added reviewers: smeenai, compnerd.
EricWF added a subscriber: cfe-commits.
On Windows tests that use `_LIBCPP_ASSERT` fail to link because the assertion
handler function isn't correctly exported from the libc++ dylib. This patch
fixes the dll import/export i
EricWF requested changes to this revision.
EricWF added a comment.
This revision now requires changes to proceed.
Almost LGTM. Just a couple of inline comments left. Thanks for working on this!
Comment at: libcxx/include/memory:3691
+ && __has_builtin(__at
Author: hahnfeld
Date: Sat Jan 14 05:35:15 2017
New Revision: 292013
URL: http://llvm.org/viewvc/llvm-project?rev=292013&view=rev
Log:
Fix last_write_time tests for filesystems that don't support negative and very
large times
Seems to be the case for NFS.
Original patch by Eric Fiselier!
Differ
This revision was automatically updated to reflect the committed changes.
Closed by commit rL292013: Fix last_write_time tests for filesystems that don't
support negative and very… (authored by Hahnfeld).
Changed prior to commit:
https://reviews.llvm.org/D22452?vs=82803&id=84445#toc
Repository
Author: sylvestre
Date: Sat Jan 14 05:41:45 2017
New Revision: 292015
URL: http://llvm.org/viewvc/llvm-project?rev=292015&view=rev
Log:
fix a few typo in the doc but also in the clang messages
Modified:
cfe/trunk/docs/ControlFlowIntegrityDesign.rst
cfe/trunk/docs/UsersManual.rst
cfe/t
Hi Hans,
can this be merged for 4.0? Eric suggested this in https://reviews.llvm
.org/D22452 so I think he should be fine.
Thanks,
Jonas
Am Samstag, den 14.01.2017, 11:35 + schrieb Jonas Hahnfeld via cfe-
commits:
> Author: hahnfeld
> Date: Sat Jan 14 05:35:15 2017
> New Revision: 292013
>
Hahnfeld added a comment.
In https://reviews.llvm.org/D22452#646165, @EricWF wrote:
> Let me know once you've committed it and I'll merge it into the 4.0 branch.
I've replied to the commit mail and asked Hans.
Repository:
rL LLVM
https://reviews.llvm.org/D22452
_
Author: sylvestre
Date: Sat Jan 14 06:00:40 2017
New Revision: 292016
URL: http://llvm.org/viewvc/llvm-project?rev=292016&view=rev
Log:
Update the tests to match the typo fix done in r292015
Modified:
cfe/trunk/test/Sema/enable_if.c
cfe/trunk/test/SemaCXX/enable_if.cpp
Modified: cfe/trun
hamzasood updated this revision to Diff 84446.
hamzasood added a comment.
Broke up findVCToolChainPath into a few smaller functions.
https://reviews.llvm.org/D28365
Files:
include/clang/Basic/DiagnosticDriverKinds.td
lib/Driver/MSVCToolChain.cpp
lib/Driver/ToolChains.h
lib/Driver/Tools.
hamzasood added inline comments.
Comment at: lib/Driver/MSVCToolChain.cpp:34
+ #if 0
+#define USE_VS_SETUP_CONFIG
+ #endif
rnk wrote:
> What are the outstanding issues preventing you from enabling this by default?
Building on Win32 doesn't imply that you'll
cpplearner added a comment.
Yes, I do. Thank you.
https://reviews.llvm.org/D27850
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Prazek created this revision.
Prazek added a reviewer: alexfh.
Prazek added a subscriber: cfe-commits.
Herald added a subscriber: JDevlieghere.
https://reviews.llvm.org/D28729
Files:
clang-tidy/ClangTidy.cpp
clang-tidy/ClangTidyOptions.cpp
clang-tidy/ClangTidyOptions.h
clang-tidy/tool/Cla
Prazek updated this revision to Diff 84448.
Prazek added a comment.
reformat
https://reviews.llvm.org/D28729
Files:
clang-tidy/ClangTidy.cpp
clang-tidy/ClangTidyOptions.cpp
clang-tidy/ClangTidyOptions.h
clang-tidy/tool/ClangTidyMain.cpp
test/clang-tidy/enable-alpha-checks.cpp
Index:
+1 from me. @Hans am I OK to merge this?
On Sat, Jan 14, 2017 at 4:53 AM, Hahnfeld, Jonas <
hahnf...@itc.rwth-aachen.de> wrote:
> Hi Hans,
>
> can this be merged for 4.0? Eric suggested this in
> https://reviews.llvm.org/D22452 so I think he should be fine.
>
> Thanks,
> Jonas
>
> Am Samstag, den
aaron.ballman accepted this revision.
aaron.ballman added a reviewer: aaron.ballman.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM with a few minor nits, but in the future, please provide some summary of
what your patch is going to do rather than leave it en
dim added a subscriber: ed.
dim added a comment.
In https://reviews.llvm.org/D28520#646160, @aaron.ballman wrote:
> I feel like I must be missing something; why is this disabling rather than
> specifying the thread safety behavior? e.g., `__libcpp_mutex_lock()`
> specifying that it acquires the
mgorny added a comment.
Second ping.
https://reviews.llvm.org/D25314
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jroelofs accepted this revision.
jroelofs added a reviewer: jroelofs.
jroelofs added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D25314
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://list
dim updated this revision to Diff 84451.
dim added a comment.
Something like this might work, maybe. (I haven't yet run the full test suite,
as that takes quite a while on my machines.)
I did not re-use the `_LIBCPP_THREAD_SAFETY_ANNOTATION` macro from
`__mutex_base`, since that is included *a
dim updated this revision to Diff 84452.
dim added a comment.
Also added capability attributes to the non-pthread versions of
`__libcpp_mutex` types.
https://reviews.llvm.org/D28520
Files:
include/__threading_support
Index: include/__threading_support
==
Author: mgorny
Date: Sat Jan 14 11:05:16 2017
New Revision: 292018
URL: http://llvm.org/viewvc/llvm-project?rev=292018&view=rev
Log:
[cmake] Handle missing LIBUNWIND_* directories gracefully
Add LIBUNWIND_* directories to include path only if they were actually
found, in order to fix the CMake er
This revision was automatically updated to reflect the committed changes.
Closed by commit rL292018: [cmake] Handle missing LIBUNWIND_* directories
gracefully (authored by mgorny).
Changed prior to commit:
https://reviews.llvm.org/D25314?vs=73770&id=84455#toc
Repository:
rL LLVM
https://rev
smeenai added a comment.
This will need to be exported on other platforms too when hidden visibility
happens :)
Is it okay for these to be exported unconditionally, or should their exporting
be determined by `_LIBCPP_DEBUG`? This LGTM if it's the former.
https://reviews.llvm.org/D28728
___
Author: ericwf
Date: Sat Jan 14 13:11:07 2017
New Revision: 292022
URL: http://llvm.org/viewvc/llvm-project?rev=292022&view=rev
Log:
Fix thread creation on Windows
Modified:
libcxx/trunk/include/__threading_support
Modified: libcxx/trunk/include/__threading_support
URL:
http://llvm.org/view
EricWF added a comment.
I think the real bug here is FreeBSD annotating `pthread_mutex_t`. That's going
to break a lot of code that already uses -Wthread-safety. This kind of breakage
is the reason libc++ doesn't enable the annotations on `std::mutex` by default.
https://reviews.llvm.org/D2852
dim added a comment.
Actually, according to
https://svnweb.freebsd.org/base?view=revision&revision=270943 (where the
annotations were added), this helped to uncover existing bugs. I don't see why
it would interfere with anything; if you ask for -Wthread-safety warnings, you
should get them, r
erik.pilkington added a comment.
Hi Alex, thanks for CCing me!
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:1157
+def err_objc_method_unsupported_param_ret_type : Error<
+ "%0 %select{parameter|return value}1 is unsupported for this target">;
+
s/ret
compnerd added a comment.
I do think that this is an issue. Particularly for Windows targets, which have
usually had the different architecture value.
https://reviews.llvm.org/D26796
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://l
EricWF created this revision.
EricWF added a reviewer: compnerd.
EricWF added a subscriber: cfe-commits.
https://reviews.llvm.org/D28735
Files:
include/__threading_support
Index: include/__threading_support
===
--- include/__thre
Author: ericwf
Date: Sat Jan 14 14:19:00 2017
New Revision: 292027
URL: http://llvm.org/viewvc/llvm-project?rev=292027&view=rev
Log:
Attempt two at fixing threading on Windows
Reviewers: compnerd
Subscribers: cfe-commits
Differential Revision: https://reviews.llvm.org/D28735
Modified:
libc
Author: ericwf
Date: Sat Jan 14 14:21:18 2017
New Revision: 292028
URL: http://llvm.org/viewvc/llvm-project?rev=292028&view=rev
Log:
Fix demangle.h on Windows
Modified:
libcxx/trunk/test/support/demangle.h
Modified: libcxx/trunk/test/support/demangle.h
URL:
http://llvm.org/viewvc/llvm-proje
Author: ericwf
Date: Sat Jan 14 14:25:25 2017
New Revision: 292029
URL: http://llvm.org/viewvc/llvm-project?rev=292029&view=rev
Log:
XFAIL native handle tests
Modified:
libcxx/trunk/test/libcxx/thread/thread.condition/thread.condition.condvar/native_handle.pass.cpp
libcxx/trunk/test/lib
dim updated this revision to Diff 84462.
dim added a comment.
Remove extraneous parenthesis.
https://reviews.llvm.org/D28520
Files:
include/__threading_support
Index: include/__threading_support
===
--- include/__threading_supp
hans added a comment.
Would it be possible to expand on, or give some kind of pointer to, what
"strict rules for overwriting polymorphic C++ objects" means?
https://reviews.llvm.org/D28727
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
htt
Author: yrnkrn
Date: Sat Jan 14 15:12:08 2017
New Revision: 292032
URL: http://llvm.org/viewvc/llvm-project?rev=292032&view=rev
Log:
Fix PR31644 introduced by r287138 and add a regression test.
Thanks Dimitry Andric for the report and fix!
Modified:
cfe/trunk/lib/Frontend/DependencyFile.cpp
On 14 Jan 2017, at 22:12, Yaron Keren via cfe-commits
wrote:
> Author: yrnkrn
> Date: Sat Jan 14 15:12:08 2017
> New Revision: 292032
>
> URL: http://llvm.org/viewvc/llvm-project?rev=292032&view=rev
> Log:
> Fix PR31644 introduced by r287138 and add a regression test.
> Thanks Dimitry Andric for
alexfh requested changes to this revision.
alexfh added a comment.
This revision now requires changes to proceed.
As discussed with the Static Analyzer maintainers, alpha checkers are
completely unsupported and are suitable for very early testing only. We had
problems with them routinely, that's
alexfh added inline comments.
Comment at: clang-tidy/ClangTidy.cpp:296
const auto &RegisteredCheckers =
- AnalyzerOptions::getRegisteredCheckers(/*IncludeExperimental=*/false);
bool AnalyzerChecksEnabled = false;
This is the place where a small local c
aaron.ballman added a comment.
In https://reviews.llvm.org/D28729#646548, @alexfh wrote:
> As discussed with the Static Analyzer maintainers, alpha checkers are
> completely unsupported and are suitable for very early testing only. We had
> problems with them routinely, that's why I disabled al
alexfh requested changes to this revision.
alexfh added inline comments.
This revision now requires changes to proceed.
Comment at: test/clang-tidy/modernize-raw-string-literal.cpp:94
+char const *const Concatenated("\"foo\""
+ "\"bar\"");
alexfh added a comment.
In https://reviews.llvm.org/D28729#646555, @aaron.ballman wrote:
> In https://reviews.llvm.org/D28729#646548, @alexfh wrote:
>
> > As discussed with the Static Analyzer maintainers, alpha checkers are
> > completely unsupported and are suitable for very early testing only
dim updated this revision to Diff 84465.
dim added a comment.
Rebase after recent changes.
https://reviews.llvm.org/D28520
Files:
include/__threading_support
Index: include/__threading_support
===
--- include/__threading_suppor
EricWF added a comment.
This breaks on all platforms were pthread_mutex_t isn't annotated.
https://reviews.llvm.org/D28520
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dim added a comment.
In https://reviews.llvm.org/D28520#646564, @EricWF wrote:
> This breaks on all platforms were pthread_mutex_t isn't annotated.
Hm, sorry about that, I didn't realize. I'm building it on Ubuntu now to see
what breaks, and how to fix it.
https://reviews.llvm.org/D28520
Prazek added a comment.
So the problem I got is that every time I want to check if there is already a
feature in clang-tidy/static-analyzer that solves my issue, I either have to
deal with static-analyzer command line, which is horrible, or I have to modify
and recompile the source code.
The c
dim added a comment.
Note that my earlier approach of just disabling -Wthread-safety for those few
functions might be easier. This should not cause any trouble for any platforms
which don't use annotated pthread functions.
https://reviews.llvm.org/D28520
___
Author: ericwf
Date: Sat Jan 14 18:06:02 2017
New Revision: 292038
URL: http://llvm.org/viewvc/llvm-project?rev=292038&view=rev
Log:
Work around python3 bytes vs str in libc++ test config
Modified:
libcxx/trunk/test/libcxx/compiler.py
Modified: libcxx/trunk/test/libcxx/compiler.py
URL:
http
mehdi_amini added inline comments.
Comment at: cfe/trunk/CMakeLists.txt:531
+ if(BOOTSTRAP_LLVM_ENABLE_LLD)
+add_dependencies(clang-bootstrap-deps lld)
+ elseif(LLVM_BINUTILS_INCDIR)
I come back to this a bit late, sorry, but I'm not sure I unde
faisalv updated this revision to Diff 84476.
faisalv added a comment.
The updated patch adds two additional enumerators to
ExpressionEvaluationContext: ConstantEvaluatedInTemplateArgument and
ConstantEvaluatedInFunctionSignature and sets them appropriately (as opposed to
our previous approach o
enyquist updated this revision to Diff 84478.
enyquist added a comment.
Forgot to set "AlignConsecutiveMacros = false" in getLLVMStyle()
Repository:
rL LLVM
https://reviews.llvm.org/D28462
Files:
ClangFormatStyleOptions.rst
Format/Format.cpp
Format/FormatTest.cpp
Format/FormatToken.h
amaiorano added inline comments.
Comment at: lib/Format/Format.cpp:424
+llvm::Error make_string_error(const llvm::Twine &Message) {
+ return llvm::make_error(Message,
alexshap wrote:
> amaiorano wrote:
> > ioeric wrote:
> > > Maybe make this `inline`?
> > Yes.
Author: akirtzidis
Date: Sun Jan 15 00:11:04 2017
New Revision: 292052
URL: http://llvm.org/viewvc/llvm-project?rev=292052&view=rev
Log:
[code-completion] Fix crash when trying to do postfix completion of instance
member inside a static function.
Modified:
cfe/trunk/lib/Parse/ParseExpr.cpp
60 matches
Mail list logo
