silvas added a comment.
LGTM. Do you need me to commit this for you?
https://reviews.llvm.org/D26960
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
what is this ${:uid} thing? Could the comment
in Sema::GetOrCreateMSAsmLabel explain it?
-- Sean Silva
On Mon, Nov 28, 2016 at 4:39 PM, Reid Kleckner via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rnk
> Date: Mon Nov 28 18:39:37 2016
> New Revision: 288093
>
> URL: http://llvm.or
fhahn added a comment.
Thanks, I can commit it myself, I just wanted to be extra careful when changing
something x86 related.
https://reviews.llvm.org/D26960
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mail
nemanjai added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:8193
+if (getTarget().isLittleEndian()) {
+ // Create a shuffle mask of (1, 0)
+ Constant *ShuffleElts[2] = { ConstantInt::get(Int32Ty, 1),
This will likely have to change when th
hokein accepted this revision.
hokein added a reviewer: hokein.
hokein added a comment.
It looks good to me, but you'd better wait for the approval from @aaron.ballman.
Comment at: clang-tidy/readability/DeleteNullPointerCheck.cpp:55
+ "'if' statement is unnecessary; delet
fhahn updated this revision to Diff 79883.
fhahn added a comment.
Herald added a subscriber: mehdi_amini.
Addressed @joerg's comment.
https://reviews.llvm.org/D27066
Files:
lib/Driver/Tools.cpp
test/Driver/unsupported-target-arch.c
Index: test/Driver/unsupported-target-arch.c
arphaman created this revision.
arphaman added reviewers: mehdi_amini, bruno.
arphaman added a subscriber: cfe-commits.
arphaman set the repository for this revision to rL LLVM.
The commit r126167 started passing the `First` index into `RemoveDuplicates`,
but forgot to update `0` to `First` in th
the fix seems fine. The new operator related test cases were placed in
test/Analysis/out-of-bounds-new.cpp
You may consider that as well for the test case.
From: dcough...@apple.com [mailto:dcough...@apple.com]
Sent: 2016. december 1. 2:55
To: Abramo Bagnara
Cc: cfe-commits ; Anna Zaks ;
Dániel
Author: joey
Date: Thu Dec 1 05:30:49 2016
New Revision: 288332
URL: http://llvm.org/viewvc/llvm-project?rev=288332&view=rev
Log:
[OpenCL] Refactor read_only/write_only pipes.
This adds the access qualifier to the Pipe Type, rather than using a class
hierarchy.
It also fixes mergeTypes for Pip
joey closed this revision.
joey added a comment.
Committed in r288332. Thanks Yaron!
Repository:
rL LLVM
https://reviews.llvm.org/D27049
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
klimek updated this revision to Diff 79891.
klimek added a comment.
Add multi-level using test.
https://reviews.llvm.org/D27207
Files:
docs/LibASTMatchersReference.html
include/clang/ASTMatchers/ASTMatchers.h
lib/ASTMatchers/Dynamic/Registry.cpp
unittests/ASTMatchers/ASTMatchersTraversa
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D27138#607859, @joerg wrote:
> Which struct are we talking about, `CompileCommandRef` or `CompileCommand`?
> It is a pointer in the former and a plain StringRef in
arphaman created this revision.
arphaman added reviewers: rsmith, ahatanak.
arphaman added a subscriber: cfe-commits.
arphaman set the repository for this revision to rL LLVM.
This patch ensures that the switch warning "case value not in enumerated type"
isn't shown for opaque enums. We don't kno
klimek added a comment.
I added a test for multi-stage desugaring. Generally, we want to model Clang's
AST where it makes sense. The AST has a getUnqualifiedDesugaredType, thus the
matcher as it is is expected. We can add single step desugaring or
hasAnyDeclaration or similar things when they a
ABataev added a comment.
In https://reviews.llvm.org/D27250#609111, @fpetrogalli wrote:
> In https://reviews.llvm.org/D27250#609006, @ABataev wrote:
>
> >
>
>
> Hi! Thanks for your review!
>
> > 1. Please provide full context for your changes (check this document how to
> > do this http://llvm.o
Author: arphaman
Date: Thu Dec 1 06:14:38 2016
New Revision: 288334
URL: http://llvm.org/viewvc/llvm-project?rev=288334&view=rev
Log:
[ObjC] Avoid a @try/@finally/@autoreleasepool fixit when parsing an expression
This patch ensures that the typo fixit for the @try/@finally/@autoreleasepool {}
di
This revision was automatically updated to reflect the committed changes.
Closed by commit rL288334: [ObjC] Avoid a @try/@finally/@autoreleasepool fixit
when parsing an expression (authored by arphaman).
Changed prior to commit:
https://reviews.llvm.org/D26916?vs=78728&id=79893#toc
Repository:
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
This looks good to me. We can add finer-grained desugaring later if it's really
needed.
https://reviews.llvm.org/D27207
___
cfe-commits mailin
Alpha marked 10 inline comments as done.
Alpha added inline comments.
Comment at: include/clang/Tooling/DiagnosticsYaml.h:79
+ for (auto &Diagnostic : Doc.Diagnostics) {
+if (Diagnostic.Fix.size() > 0) {
+ Diagnostics.push_back(Diagnostic);
Alpha updated this revision to Diff 79899.
Herald added a subscriber: JDevlieghere.
Repository:
rL LLVM
https://reviews.llvm.org/D26137
Files:
include/clang/Tooling/Core/Diagnostic.h
include/clang/Tooling/Core/Replacement.h
include/clang/Tooling/DiagnosticsYaml.h
include/clang/Tooling/
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG with a comment.
Comment at: include/clang/Tooling/DiagnosticsYaml.h:79
+ for (auto &Diagnostic : Doc.Diagnostics) {
+if (Diagnostic.Fix.size() > 0) {
+
echuraev created this revision.
echuraev added a reviewer: Anastasia.
echuraev added subscribers: cfe-commits, yaxunl, bader.
https://reviews.llvm.org/D27300
Files:
lib/CodeGen/TargetInfo.cpp
test/CodeGenOpenCL/spir_version.cl
Index: test/CodeGenOpenCL/spir_version.cl
==
alexfh requested changes to this revision.
alexfh added a comment.
This revision now requires changes to proceed.
Thank you for the new check! A few comments.
Comment at:
clang-tools-extra/clang-tidy/performance/TypePromotionInMathFnCheck.cpp:22
+AST_MATCHER_P(Type, isBuiltinT
Alpha updated this revision to Diff 79904.
Repository:
rL LLVM
https://reviews.llvm.org/D26137
Files:
include/clang/Tooling/Core/Diagnostic.h
include/clang/Tooling/Core/Replacement.h
include/clang/Tooling/DiagnosticsYaml.h
include/clang/Tooling/ReplacementsYaml.h
lib/Tooling/Core/CMa
alexfh added inline comments.
Comment at: clang-tidy/modernize/ModernizeTidyModule.cpp:58
"modernize-use-bool-literals");
-CheckFactories.registerCheck("modernize-use-default");
+
CheckFactories.registerCheck("modernize-use-equals-default");
CheckFactories.r
alexfh requested changes to this revision.
alexfh added inline comments.
This revision now requires changes to proceed.
Comment at: clang-tidy/misc/StringCompareCheck.cpp:29
+
+ // First and second case: cast str.compare(str) to boolean
+ Finder->addMatcher(
Pl
alexfh added a comment.
Do you have commit access? If you need me to commit the patch for you, please
rebase it on top of HEAD.
Repository:
rL LLVM
https://reviews.llvm.org/D26137
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://li
alexfh accepted this revision.
alexfh added a comment.
LG. Looks like a strict improvement.
https://reviews.llvm.org/D27248
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh added a comment.
Sorry for the delay. I'll try to get back to this patch soon.
https://reviews.llvm.org/D26418
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hiraditya updated this revision to Diff 79908.
hiraditya added a comment.
Updated the benchmark:
Without patch:
Run on (8 X 3400 MHz CPU s)
2016-12-01 09:20:38
***WARNING*** CPU scaling is enabled, the benchmark real time measurements may
be noisy and will incur extra overhead.
Benchmark
yaxunl added inline comments.
Comment at: test/CodeGenOpenCL/spir_version.cl:21
-// CHECK-SPIR-CL12: [[SPIR]] = !{i32 2, i32 0}
-// CHECK-SPIR-CL12: [[OCL]] = !{i32 1, i32 2}
// CHECK-SPIR-CL20: !opencl.spir.version = !{[[SPIR:![0-9]+]]}
why this is removed?
h
Author: tstellar
Date: Thu Dec 1 09:15:38 2016
New Revision: 288347
URL: http://llvm.org/viewvc/llvm-project?rev=288347&view=rev
Log:
Creating release directory for release_391.
Added:
libcxx/tags/RELEASE_391/
___
cfe-commits mailing list
cfe-comm
Author: tstellar
Date: Thu Dec 1 09:15:39 2016
New Revision: 288348
URL: http://llvm.org/viewvc/llvm-project?rev=288348&view=rev
Log:
Creating release candidate rc1 from release_391 branch
Added:
libcxx/tags/RELEASE_391/rc1/ (props changed)
- copied from r288347, libcxx/branches/rele
Author: tstellar
Date: Thu Dec 1 09:15:40 2016
New Revision: 288349
URL: http://llvm.org/viewvc/llvm-project?rev=288349&view=rev
Log:
Creating release directory for release_391.
Added:
libcxxabi/tags/RELEASE_391/
___
cfe-commits mailing list
cfe-c
Author: tstellar
Date: Thu Dec 1 09:16:13 2016
New Revision: 288361
URL: http://llvm.org/viewvc/llvm-project?rev=288361&view=rev
Log:
Creating release directory for release_391.
Added:
libunwind/tags/RELEASE_391/
___
cfe-commits mailing list
cfe-c
Author: tstellar
Date: Thu Dec 1 09:16:24 2016
New Revision: 288362
URL: http://llvm.org/viewvc/llvm-project?rev=288362&view=rev
Log:
Creating release candidate rc1 from release_391 branch
Added:
libunwind/tags/RELEASE_391/rc1/ (props changed)
- copied from r288361, libunwind/branche
Author: tstellar
Date: Thu Dec 1 09:15:41 2016
New Revision: 288350
URL: http://llvm.org/viewvc/llvm-project?rev=288350&view=rev
Log:
Creating release candidate rc1 from release_391 branch
Added:
libcxxabi/tags/RELEASE_391/rc1/ (props changed)
- copied from r288349, libcxxabi/branche
ioeric created this revision.
ioeric added a reviewer: hokein.
ioeric added a subscriber: cfe-commits.
https://reviews.llvm.org/D27302
Files:
change-namespace/ChangeNamespace.cpp
change-namespace/ChangeNamespace.h
test/change-namespace/Inputs/macro.h
test/change-namespace/macro.cpp
Index
malcolm.parsons added inline comments.
Comment at: clang-tidy/modernize/ModernizeTidyModule.cpp:58
"modernize-use-bool-literals");
-CheckFactories.registerCheck("modernize-use-default");
+
CheckFactories.registerCheck("modernize-use-equals-default");
CheckFa
alexfh added inline comments.
Comment at: clang-tidy/modernize/ModernizeTidyModule.cpp:58
"modernize-use-bool-literals");
-CheckFactories.registerCheck("modernize-use-default");
+
CheckFactories.registerCheck("modernize-use-equals-default");
CheckFactories.r
alexfh added inline comments.
Comment at: clang-tidy/modernize/ModernizeTidyModule.cpp:58
"modernize-use-bool-literals");
-CheckFactories.registerCheck("modernize-use-default");
+
CheckFactories.registerCheck("modernize-use-equals-default");
CheckFactories.r
Author: klimek
Date: Thu Dec 1 09:45:06 2016
New Revision: 288366
URL: http://llvm.org/viewvc/llvm-project?rev=288366&view=rev
Log:
Adds hasUnqualifiedDesugaredType to allow matching through type sugar.
Differential Revision: https://reviews.llvm.org/D27207
Modified:
cfe/trunk/docs/LibASTMa
This revision was automatically updated to reflect the committed changes.
Closed by commit rL288366: Adds hasUnqualifiedDesugaredType to allow matching
through type sugar. (authored by klimek).
Changed prior to commit:
https://reviews.llvm.org/D27207?vs=79891&id=79912#toc
Repository:
rL LLVM
echuraev added inline comments.
Comment at: test/CodeGenOpenCL/spir_version.cl:21
-// CHECK-SPIR-CL12: [[SPIR]] = !{i32 2, i32 0}
-// CHECK-SPIR-CL12: [[OCL]] = !{i32 1, i32 2}
// CHECK-SPIR-CL20: !opencl.spir.version = !{[[SPIR:![0-9]+]]}
yaxunl wrote:
> why th
djasper added inline comments.
Comment at: unittests/Format/FormatTest.cpp:1787
+TEST_F(FormatTest, ReflowsComments) {
+ // Break a long line and reflow with the full next line.
I think it is time that me moved a lot of the comment handling logic into a
separ
yaxunl added inline comments.
Comment at: test/CodeGenOpenCL/spir_version.cl:21
-// CHECK-SPIR-CL12: [[SPIR]] = !{i32 2, i32 0}
-// CHECK-SPIR-CL12: [[OCL]] = !{i32 1, i32 2}
// CHECK-SPIR-CL20: !opencl.spir.version = !{[[SPIR:![0-9]+]]}
echuraev wrote:
> yaxunl
malcolm.parsons updated this revision to Diff 79918.
malcolm.parsons added a comment.
Herald added a subscriber: JDevlieghere.
Add documentation redirect.
Change add_new_check.py to ignore checks that are orphaned.
https://reviews.llvm.org/D26511
Files:
clang-tidy/add_new_check.py
clang-tid
Alpha updated this revision to Diff 79917.
Alpha added a comment.
Rebase on top of HEAD.
Repository:
rL LLVM
https://reviews.llvm.org/D26137
Files:
include/clang/Tooling/Core/Diagnostic.h
include/clang/Tooling/Core/Replacement.h
include/clang/Tooling/DiagnosticsYaml.h
include/clang/T
malcolm.parsons updated this revision to Diff 79919.
malcolm.parsons added a comment.
Re-remove doubled space in modernize-use-equals-default.rst.
https://reviews.llvm.org/D26511
Files:
clang-tidy/add_new_check.py
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModul
Alpha added a comment.
I don't have commit access.
Thank you for the review @alexfh
Repository:
rL LLVM
https://reviews.llvm.org/D26137
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
Hi Alexander,
I have now implemented your suggestions - all but the fixit one. If I have
added bindings for str1 and str2 in ast matcher, how would I go about
creating a replacement for the entire implicitCastExpr or binaryOperator? I
can't find any example in the code for clang-tidy to suggest ho
thegameg created this revision.
thegameg added reviewers: craig.topper, majnemer.
thegameg added a subscriber: cfe-commits.
The following program hits a fatal_error in the X86 backend, when the
program is compiled with -mno-sse or -mno-sse2, which is understandable
due to the calling convention:
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM with two nits.
Comment at: change-namespace/ChangeNamespace.cpp:786
+ for (auto &Entry : FileToReplacements)
+if (!FilePatternRE.match(Entry.first))
+ Entry.se
On 1 December 2016 at 16:42, Mads Ravn wrote:
> I have now implemented your suggestions - all but the fixit one. If I have
> added bindings for str1 and str2 in ast matcher, how would I go about
> creating a replacement for the entire implicitCastExpr or binaryOperator? I
> can't find any example
kbarton requested changes to this revision.
kbarton added a comment.
This revision now requires changes to proceed.
Please make explicit the signed for the parameters to the functions you are
changing and remove unnecessary casts. I marked the first few that I found, but
stopped marking them aft
This revision was automatically updated to reflect the committed changes.
Closed by commit rL288372: [analyzer] Drop explicit mention of range constraint
solver (authored by ddcc).
Changed prior to commit:
https://reviews.llvm.org/D26694?vs=78060&id=79924#toc
Repository:
rL LLVM
https://rev
Author: ddcc
Date: Thu Dec 1 11:06:39 2016
New Revision: 288372
URL: http://llvm.org/viewvc/llvm-project?rev=288372&view=rev
Log:
[analyzer] Drop explicit mention of range constraint solver
Summary: The basic constraint solver was dropped in rL162384, leaving the range
constraint solver as the
malcolm.parsons added inline comments.
Comment at: docs/clang-tidy/checks/misc-string-compare.rst:21
+
+ if(str1.compare(str2)) {} // use str1 != str2 instead
+
Please clang-format this code.
Comment at: test/clang-tidy/misc-string-compare
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG. Thanks!
https://reviews.llvm.org/D26511
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
Looks good to me!
Do you have commit access, or would you like me to commit it for you?
Thanks,
Hans
On Wed, Nov 30, 2016 at 8:10 PM, Antonio Maiorano wrote:
> Updated version of patch attached with the changes you suggested. Let me
> know if there's anything else you'd like.
>
>
> On Tue, 29 N
ioeric updated this revision to Diff 79927.
ioeric marked 2 inline comments as done.
ioeric added a comment.
- Addressed comments.
https://reviews.llvm.org/D27302
Files:
change-namespace/ChangeNamespace.cpp
change-namespace/ChangeNamespace.h
test/change-namespace/macro.cpp
Index: test/ch
erik.pilkington added a comment.
Ping!
https://reviews.llvm.org/D24639
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
malcolm.parsons added a comment.
In https://reviews.llvm.org/D26453#592934, @flx wrote:
> In https://reviews.llvm.org/D26453#590720, @malcolm.parsons wrote:
>
> > Add ValuesOnly option to modernize-pass-by-value.
>
>
> Thanks for doing this. Alex, would this work for us?
ping.
https://reviews
Author: malcolm.parsons
Date: Thu Dec 1 11:24:42 2016
New Revision: 288375
URL: http://llvm.org/viewvc/llvm-project?rev=288375&view=rev
Log:
[clang-tidy] Rename modernize-use-default to modernize-use-equals-default
Reviewers: angelgarcia, aaron.ballman, alexfh
Subscribers: JDevlieghere, Prazek,
This revision was automatically updated to reflect the committed changes.
Closed by commit rL288375: [clang-tidy] Rename modernize-use-default to
modernize-use-equals-default (authored by malcolm.parsons).
Changed prior to commit:
https://reviews.llvm.org/D26511?vs=79919&id=79928#toc
Repositor
Author: ioeric
Date: Thu Dec 1 11:25:55 2016
New Revision: 288376
URL: http://llvm.org/viewvc/llvm-project?rev=288376&view=rev
Log:
[change-namespace] don't generate replacements for files that don't match file
pattern.
Reviewers: hokein
Subscribers: cfe-commits
Differential Revision: https:/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL288376: [change-namespace] don't generate replacements for
files that don't match file… (authored by ioeric).
Changed prior to commit:
https://reviews.llvm.org/D27302?vs=79927&id=79929#toc
Repository:
malcolm.parsons added a comment.
ping.
https://reviews.llvm.org/D26750
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: rogfer01
Date: Thu Dec 1 11:31:38 2016
New Revision: 288378
URL: http://llvm.org/viewvc/llvm-project?rev=288378&view=rev
Log:
Protect std::ostream::sentry test under libcpp-no-exceptions
Skip test that throws an exception.
Differential Revision: https://reviews.llvm.org/D27255
Modifie
This revision was automatically updated to reflect the committed changes.
Closed by commit rL288378: Protect std::ostream::sentry test under
libcpp-no-exceptions (authored by rogfer01).
Changed prior to commit:
https://reviews.llvm.org/D27255?vs=79720&id=79931#toc
Repository:
rL LLVM
https:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL288379: Protect optional test under libcpp-no-exceptions
(authored by rogfer01).
Changed prior to commit:
https://reviews.llvm.org/D27254?vs=79765&id=79932#toc
Repository:
rL LLVM
https://reviews.ll
Author: rogfer01
Date: Thu Dec 1 11:33:36 2016
New Revision: 288379
URL: http://llvm.org/viewvc/llvm-project?rev=288379&view=rev
Log:
Protect optional test under libcpp-no-exceptions
Replace throw with TEST_THROW and skip tests that throw exceptions
Differential Revision: https://reviews.llvm.o
Author: rogfer01
Date: Thu Dec 1 11:34:57 2016
New Revision: 288382
URL: http://llvm.org/viewvc/llvm-project?rev=288382&view=rev
Log:
Protect futures test under libcpp-no-exceptions
Skip tests that expect an exception be thrown.
Differential Revision: https://reviews.llvm.org/D27253
Modified:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL288382: Protect futures test under libcpp-no-exceptions
(authored by rogfer01).
Changed prior to commit:
https://reviews.llvm.org/D27253?vs=79718&id=79933#toc
Repository:
rL LLVM
https://reviews.llv
Author: rogfer01
Date: Thu Dec 1 11:36:41 2016
New Revision: 288383
URL: http://llvm.org/viewvc/llvm-project?rev=288383&view=rev
Log:
Protect sequences test under libcpp-no-exceptions
Replace throw with TEST_THROW and protect tests that do throw. Also add missing
assert(false).
Differential Re
This revision was automatically updated to reflect the committed changes.
Closed by commit rL288383: Protect sequences test under libcpp-no-exceptions
(authored by rogfer01).
Changed prior to commit:
https://reviews.llvm.org/D27252?vs=79717&id=79934#toc
Repository:
rL LLVM
https://reviews.l
Author: malcolm.parsons
Date: Thu Dec 1 11:38:54 2016
New Revision: 288384
URL: http://llvm.org/viewvc/llvm-project?rev=288384&view=rev
Log:
Add a blank line to make sphinx happy.
Modified:
clang-tools-extra/trunk/docs/clang-tidy/checks/modernize-use-default.rst
Modified:
clang-tools-extra
mehdi_amini accepted this revision.
mehdi_amini added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rL LLVM
https://reviews.llvm.org/D27298
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.
Author: gbiv
Date: Thu Dec 1 11:52:39 2016
New Revision: 288388
URL: http://llvm.org/viewvc/llvm-project?rev=288388&view=rev
Log:
[TableGen] Ignore fake args for parsing-related arg counts.
We should complain about the following:
```
void foo() __attribute__((unavailable("a", "b")));
```
Inste
joerg added a comment.
I think this is the absolutely wrong place to put such logic. It really can not
be anywhere but the backend.
https://reviews.llvm.org/D27304
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
Author: hans
Date: Thu Dec 1 12:05:41 2016
New Revision: 288393
URL: http://llvm.org/viewvc/llvm-project?rev=288393&view=rev
Log:
Fix VS2015 build of clang-format-vsix by using NuGet to pull in required
assemblies
Also added a gitignore to help track the right items to commit.
Patch by Antonio
Committed in r288393.
Cheers,
Hans
On Thu, Dec 1, 2016 at 9:22 AM, Hans Wennborg wrote:
> Looks good to me!
>
> Do you have commit access, or would you like me to commit it for you?
>
> Thanks,
> Hans
>
> On Wed, Nov 30, 2016 at 8:10 PM, Antonio Maiorano wrote:
>> Updated version of patch attac
Author: arnolds
Date: Thu Dec 1 12:07:38 2016
New Revision: 288394
URL: http://llvm.org/viewvc/llvm-project?rev=288394&view=rev
Log:
swiftcc: Add an api to query whether a target ABI stores swifterror in a
register
Modified:
cfe/trunk/include/clang/CodeGen/SwiftCallingConv.h
cfe/trunk/l
rogfer01 created this revision.
rogfer01 added reviewers: EricWF, mclow.lists, rmaprath.
rogfer01 added a subscriber: cfe-commits.
Under libcpp-no-exceptions, noexcept is trivially true. Some tests expect in
the usual setting to return false. Wrap these tests in a convenience macro.
https://rev
bruno accepted this revision.
bruno added a comment.
LGTM!
Repository:
rL LLVM
https://reviews.llvm.org/D27298
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: mgrang
Date: Thu Dec 1 12:42:16 2016
New Revision: 288397
URL: http://llvm.org/viewvc/llvm-project?rev=288397&view=rev
Log:
[clang] Implement support for -defsym assembler option
Summary:
Adds support for -Wa,-defsym,abc=1 option.
Related llvm patch: https://reviews.llvm.org/D26214
Rev
jlebar updated this revision to Diff 79951.
jlebar marked 2 inline comments as done.
jlebar added a comment.
Update test, use "auto". Still need to figure out how to lex these function
calls properly.
https://reviews.llvm.org/D27284
Files:
clang-tools-extra/clang-tidy/performance/CMakeLists
jlebar added inline comments.
Comment at:
clang-tools-extra/clang-tidy/performance/TypePromotionInMathFnCheck.cpp:62-67
+ Finder->addMatcher(
+ callExpr(callee(functionDecl(TwoDoubleArgFns, parameterCountIs(2),
+ hasBuiltinTyParam(0, Doubl
dcoughlin added a comment.
In https://reviews.llvm.org/D26691#610292, @zaks.anna wrote:
> I am not a big fan of loosing svn blame only to fix formatting, but since you
> are modifying this code anyway, it's fine by me.
>
> Artem and Devin, what is your opinion on this?
I agree that in general
madsravn updated this revision to Diff 79958.
madsravn marked 5 inline comments as done.
madsravn added a comment.
Updated according to comments. Still missing fixit.
https://reviews.llvm.org/D27210
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/MiscTidyModule.cpp
clang-tidy/misc/S
Author: ahatanak
Date: Thu Dec 1 13:25:14 2016
New Revision: 288404
URL: http://llvm.org/viewvc/llvm-project?rev=288404&view=rev
Log:
[CodeGen][ARM] Make sure the value and type used to create a bitcast
have the same size.
This fixes an asset that is triggered when an address of a boolean
variab
Author: tra
Date: Thu Dec 1 13:34:35 2016
New Revision: 288406
URL: http://llvm.org/viewvc/llvm-project?rev=288406&view=rev
Log:
Send compiler output to /dev/null in defsym.s test.
Fixes test failures if tests are run in a read-only source tree.
Modified:
cfe/trunk/test/Driver/defsym.s
Mod
tcanens added inline comments.
Comment at: include/__string:543
+_LIBCPP_CONSTEXPR_AFTER_CXX11
+_RandomAccessIterator
+__search_substring(_RandomAccessIterator __first1, _RandomAccessIterator
__last1,
A character traits class need only accept pointers, so the na
madsravn updated this revision to Diff 79961.
madsravn added a comment.
Fixed broken tests.
https://reviews.llvm.org/D27210
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/MiscTidyModule.cpp
clang-tidy/misc/StringCompareCheck.cpp
clang-tidy/misc/StringCompareCheck.h
docs/Release
jhen created this revision.
jhen added a reviewer: jlebar.
jhen added a subscriber: cfe-commits.
This adds to the work from https://reviews.llvm.org/rL281680. This patch
takes care of another execution path in which sanitizer arguments can be
considered for NVPTX because they are used for the corr
Author: gbiv
Date: Thu Dec 1 14:16:56 2016
New Revision: 288414
URL: http://llvm.org/viewvc/llvm-project?rev=288414&view=rev
Log:
Add a space in a run line. NFC.
Modified:
cfe/trunk/test/CodeGenCXX/enable_if.cpp
Modified: cfe/trunk/test/CodeGenCXX/enable_if.cpp
URL:
http://llvm.org/viewvc/
thegameg added a comment.
In https://reviews.llvm.org/D27304#610697, @joerg wrote:
> I think this is the absolutely wrong place to put such logic. It really can
> not be anywhere but the backend.
I am aware of this. But the way the backend informs the Diagnostics looks like
a crash, and asks
Hi Malcolm,
Thanks for the suggestions, I have been reading up on the fixits.
My initial four cases has been reduced to two a little more general cases:
1 & 2: implicitCast to bool str1.compare(str2). This case covers both
!str1.compare(str2) and str1.compare(str2)
3 & 4: str1.compare(str2) == 0 a
hfinkel added a comment.
In https://reviews.llvm.org/D27304#610944, @thegameg wrote:
> In https://reviews.llvm.org/D27304#610697, @joerg wrote:
>
> > I think this is the absolutely wrong place to put such logic. It really can
> > not be anywhere but the backend.
>
>
> I am aware of this. But the
ahatanak accepted this revision.
ahatanak added a comment.
This revision is now accepted and ready to land.
I think this is fine.
I guess we can print a more helpful error message than "error: property
requires fields to be named", but we can probably do it later.
Repository:
rL LLVM
https:
1 - 100 of 147 matches
Mail list logo
