mgorny updated this revision to Diff 75269.
mgorny added a comment.
Restructured and reformatted as requested.
https://reviews.llvm.org/D25696
Files:
lib/Driver/ToolChains.cpp
Index: lib/Driver/ToolChains.cpp
===
--- lib/Driver
sepavloff created this revision.
sepavloff added a subscriber: cfe-commits.
If initializer contains parentheses around braced list where it is not allowed,
as in
construct `int({0})`, clang issued message like `functional-style cast from
'void' to
'int' is not allowed`, which does not much help.
I think I understand the MSVC bug here; workaround incoming.
On Wed, Oct 19, 2016 at 11:54 PM, Mike Aizatsky wrote:
> I think this breaks windows bot:
>
> http://lab.llvm.org:8011/builders/sanitizer-windows/
> builds/30745/steps/build%20clang%20lld/logs/stdio
>
> C:\PROGRA~2\MICROS~1.0\VC\bin\AM
Author: rsmith
Date: Thu Oct 20 02:53:17 2016
New Revision: 284701
URL: http://llvm.org/viewvc/llvm-project?rev=284701&view=rev
Log:
Work around MSVC rejects-valid. Apparenty (some versions of) MSVC will check
that a member is default-initializable even if it's initialized by a default
member init
Should hopefully be fixed by r284701.
On Thu, Oct 20, 2016 at 12:55 AM, Richard Smith
wrote:
> I think I understand the MSVC bug here; workaround incoming.
>
> On Wed, Oct 19, 2016 at 11:54 PM, Mike Aizatsky
> wrote:
>
>> I think this breaks windows bot:
>>
>> http://lab.llvm.org:8011/builders/
hokein added inline comments.
Comment at: change-namespace/ChangeNamespace.cpp:566
+ break;
+if (isDeclVisibleAtLocation(*Result.SourceManager, Using, DeclCtx, Start))
{
+ for (const auto *UsingShadow : Using->shadows()) {
Yeah, it works for most c
mharoush added a comment.
Done
Repository:
rL LLVM
https://reviews.llvm.org/D25012
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ioeric added inline comments.
Comment at: change-namespace/ChangeNamespace.cpp:566
+ break;
+if (isDeclVisibleAtLocation(*Result.SourceManager, Using, DeclCtx, Start))
{
+ for (const auto *UsingShadow : Using->shadows()) {
hokein wrote:
> Yeah, it
ioeric added inline comments.
Comment at: change-namespace/ChangeNamespace.cpp:566
+ break;
+if (isDeclVisibleAtLocation(*Result.SourceManager, Using, DeclCtx, Start))
{
+ for (const auto *UsingShadow : Using->shadows()) {
ioeric wrote:
> hokein wr
ikudrin added a comment.
Ping.
https://reviews.llvm.org/D25608
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
brucem marked 2 inline comments as done.
brucem added a comment.
These have been addressed, so this should be good for further review.
https://reviews.llvm.org/D25241
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-
arphaman created this revision.
arphaman added reviewers: dblaikie, majnemer.
arphaman added a subscriber: cfe-commits.
arphaman set the repository for this revision to rL LLVM.
This patch improves the mismatched destructor type error by detecting when the
destructor call has used a '.' instead o
mharoush removed rL LLVM as the repository for this revision.
mharoush updated this revision to Diff 75277.
mharoush added a comment.
Herald added a subscriber: mehdi_amini.
I renamed the test file to be more informative, added LLVM_FALLTHROUGH, removed
check of {z} and changed the test to check
mharoush removed rL LLVM as the repository for this revision.
mharoush updated this revision to Diff 75278.
mharoush added a comment.
Added LLVM_FALLTHROUGH
https://reviews.llvm.org/D25062
Files:
lib/Target/X86/X86ISelLowering.cpp
Index: lib/Target/X86/X86ISelLowering.cpp
===
mharoush added a comment.
ping
Repository:
rL LLVM
https://reviews.llvm.org/D25011
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arphaman updated this revision to Diff 75279.
arphaman marked an inline comment as done.
arphaman added a comment.
The updated patch adds a comment to the modified code as request by Manman.
Repository:
rL LLVM
https://reviews.llvm.org/D25777
Files:
lib/Sema/TreeTransform.h
test/SemaCXX/
ioeric updated this revision to Diff 75280.
ioeric added a comment.
- Ignore using decls in old ns but not the inner-most old ns.
https://reviews.llvm.org/D25771
Files:
change-namespace/ChangeNamespace.cpp
change-namespace/ChangeNamespace.h
unittests/change-namespace/ChangeNamespaceTests.
ioeric added a comment.
Still missing one case... working on a fix.
https://reviews.llvm.org/D25771
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ioeric updated this revision to Diff 75281.
ioeric added a comment.
- Add a missing test case.
https://reviews.llvm.org/D25771
Files:
change-namespace/ChangeNamespace.cpp
change-namespace/ChangeNamespace.h
unittests/change-namespace/ChangeNamespaceTests.cpp
Index: unittests/change-namesp
ioeric marked 3 inline comments as done.
ioeric added inline comments.
Comment at: change-namespace/ChangeNamespace.cpp:566
+ break;
+if (isDeclVisibleAtLocation(*Result.SourceManager, Using, DeclCtx, Start))
{
+ for (const auto *UsingShadow : Using->shadows()) {
-
mgorny created this revision.
mgorny added reviewers: bruno, bkramer, rafael.
mgorny added a subscriber: cfe-commits.
Refactor the DetectDistro() function to take a single vfs::FileSystem
reference only, instead of Driver and llvm::Triple::ArchType.
The ArchType parameter was not used anyway, and
hokein accepted this revision.
hokein added a comment.
LGTM. I will commit for you.
Repository:
rL LLVM
https://reviews.llvm.org/D25649
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
Author: hokein
Date: Thu Oct 20 06:32:47 2016
New Revision: 284719
URL: http://llvm.org/viewvc/llvm-project?rev=284719&view=rev
Log:
[Clang-tidy]: Fix modernize-avoid-bind erroneous scope resolution.
Hello, i would like to suggest a fix for one of the checks in clang-tidy and i
should hope this
arphaman created this revision.
arphaman added a reviewer: manmanren.
arphaman added a subscriber: cfe-commits.
arphaman set the repository for this revision to rL LLVM.
This patch improves the '-Wformat' warnings by ensuring that the formatting
checker can see through Objective-C message sends w
hokein closed this revision.
hokein added a comment.
Committed in r284719 with some nits fixing.
As @jlebar mentioned above, please consider use `Arcanist`
(http://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-command-line)
to upload your patch, which will make the commit stuff eas
malcolm.parsons added inline comments.
Comment at: include/clang/AST/TypeLoc.h:513
struct BuiltinLocInfo {
- SourceLocation BuiltinLoc;
+ SourceRange BuiltinRange;
};
aaron.ballman wrote:
> malcolm.parsons wrote:
> > aaron.ballman wrote:
> > > malcolm.parsons
IdrissRio added a comment.
Can someone commit the patch ( https://reviews.llvm.org/D25649 ) because i
don't have commit privileges.
Thanks.
Repository:
rL LLVM
https://reviews.llvm.org/D25649
___
cfe-commits mailing list
cfe-commits@lists.llvm.
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
Comment at: include/clang/AST/TypeLoc.h:513
struct BuiltinLocInfo {
- SourceLocation BuiltinLoc;
+ SourceRange BuiltinRange;
};
malco
aaron.ballman added inline comments.
Comment at: clang-tidy/readability/IdentifierNamingCheck.cpp:654
+ RangeIsEntirelyWithinMacroArgument || !RangeContainsMacroExpansion;
+ Failure.ShouldFix = Failure.ShouldFix && RangeCanBeFixed;
}
We could do an early r
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp:30
+AST_MATCHER(CXXRecordDecl, hasDefaultConstructor) {
+ return Node.hasDefaultCons
aaron.ballman added a comment.
I noticed you marked several comments as done, but the patch is not updated
with changes. Have I missed something?
https://reviews.llvm.org/D22346
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
Author: hokein
Date: Thu Oct 20 08:15:40 2016
New Revision: 284727
URL: http://llvm.org/viewvc/llvm-project?rev=284727&view=rev
Log:
[clang-tidy] Fix an assertion failure in cppcoreguidelines-pro-type-member-init.
Summary:
The matcher for matching "class with default constructor" still match
some
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284727: [clang-tidy] Fix an assertion failure in
cppcoreguidelines-pro-type-member-init. (authored by hokein).
Changed prior to commit:
https://reviews.llvm.org/D25747?vs=75066&id=75291#toc
Repository:
hokein added inline comments.
Comment at: clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp:30
+AST_MATCHER(CXXRecordDecl, hasDefaultConstructor) {
+ return Node.hasDefaultConstructor();
aaron.ballman wrote:
> I think this should be a public AST matcher
malcolm.parsons added inline comments.
Comment at: include/clang/AST/TypeLoc.h:533
+} else {
+ BuiltinRange.setBegin(std::min(Range.getBegin(),
BuiltinRange.getBegin()));
+ BuiltinRange.setEnd(std::max(Range.getEnd(), BuiltinRange.getEnd()));
I sus
arphaman added a comment.
Thanks for working on this! I have a couple of comments:
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:1762
def err_init_incomplete_type : Error<"initialization of incomplete type %0">;
+def err_list_init_in_parens : Error<"list-initializer f
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM with a small nit, but you may want to wait for @djasper to weigh in on the
removed comment question.
Comment at: clang-tidy/modernize/UseDefaultCheck.cpp:
aaron.ballman added inline comments.
Comment at: include/clang/AST/TypeLoc.h:533
+} else {
+ BuiltinRange.setBegin(std::min(Range.getBegin(),
BuiltinRange.getBegin()));
+ BuiltinRange.setEnd(std::max(Range.getEnd(), BuiltinRange.getEnd()));
malcolm
kparzysz added a comment.
In https://reviews.llvm.org/D25811#575105, @EricWF wrote:
> Seems like we should figure out why these pass on ToT OS X.
All of them have
// XFAIL: with_system_cxx_lib=x86_64-apple-darwin11
// XFAIL: with_system_cxx_lib=x86_64-apple-darwin12
Maybe that's it. I don't
djasper accepted this revision.
djasper added a reviewer: djasper.
djasper added a comment.
I don't know whether it is an intentional choice to remove this comment. I'd be
fine either way (I think there are arguments for and against it). So, this
looks good to me. But maybe Eric has something to
kparzysz updated this revision to Diff 75292.
kparzysz added a comment.
Unxfail these tests on Linux.
Repository:
rL LLVM
https://reviews.llvm.org/D25811
Files:
test/std/localization/locale.categories/category.ctype/locale.ctype.byname/tolower_1.pass.cpp
test/std/localization/locale.ca
aaron.ballman accepted this revision.
aaron.ballman added a reviewer: aaron.ballman.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: lib/Sema/SemaExprCXX.cpp:6287
+Context.hasSameUnqualifiedType(DestructedType,
+
ioeric accepted this revision.
ioeric added inline comments.
Comment at: test/clang-tidy/modernize-use-default-copy.cpp:85
+ // CHECK-MESSAGES: :[[@LINE-2]]:3: warning: use '= default'
+ // CHECK-FIXES: /* don't delete */ = default;
int Field;
malcolm.parso
Author: d0k
Date: Thu Oct 20 08:52:26 2016
New Revision: 284729
URL: http://llvm.org/viewvc/llvm-project?rev=284729&view=rev
Log:
Clean up alignment hacks now that MSVC 2013 and GCC 4.7 are gone.
Modified:
cfe/trunk/include/clang/AST/Stmt.h
cfe/trunk/include/clang/AST/TemplateBase.h
c
alexshap added a comment.
@bkramer ?
https://reviews.llvm.org/D22712
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: d0k
Date: Thu Oct 20 09:27:22 2016
New Revision: 284730
URL: http://llvm.org/viewvc/llvm-project?rev=284730&view=rev
Log:
Retire llvm::alignOf in favor of C++11 alignof.
No functionality change intended.
Modified:
cfe/trunk/include/clang/AST/ASTContext.h
cfe/trunk/include/clang/A
aaron.ballman added inline comments.
Comment at: test/SemaObjC/format-strings-objc.m:299
+ NSLog([self str: @"%@ %@"], @"name"); // expected-warning {{more '%'
conversions than data arguments}}
+}
+
Can you add an example showing a positive use case as well?
If we issue a fixit we should recover as-if the code was written with the
fixit in. Does this code do that? (can we test it? I know we test some
fixits - not sure it's necessary/worthwhile to test them all, but maybe we
have a good idiom for testing that the recovery is correct)
On Thu, Oct 20, 20
vsk added a comment.
I believe gcc 4.7 and msvc 2013 are now unsupported (see e.g r284729).
https://reviews.llvm.org/D22712
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexshap added a comment.
i see, thanks. So do i understand correctly that we can proceed with this patch
?
https://reviews.llvm.org/D22712
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
Author: marshall
Date: Thu Oct 20 09:57:34 2016
New Revision: 284731
URL: http://llvm.org/viewvc/llvm-project?rev=284731&view=rev
Log:
Adding a missing constexpr test for reverse_iterator operator[].
Modified:
libcxx/trunk/test/std/iterators/predef.iterators/reverse.iterators/reverse.iter.op
Author: malcolm.parsons
Date: Thu Oct 20 09:58:45 2016
New Revision: 284732
URL: http://llvm.org/viewvc/llvm-project?rev=284732&view=rev
Log:
[Format] Cleanup after replacing constructor body with = default
Summary:
Remove colon and commas after replacing constructor body with = default.
Fix anno
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284732: [Format] Cleanup after replacing constructor body
with = default (authored by malcolm.parsons).
Changed prior to commit:
https://reviews.llvm.org/D25768?vs=75138&id=75299#toc
Repository:
rL L
On Thu, Oct 20, 2016 at 11:02 AM, David Blaikie wrote:
> If we issue a fixit we should recover as-if the code was written with the
> fixit in. Does this code do that?
That's a good point; I don't think this patch does the fix.
> (can we test it? I know we test some
> fixits - not sure it's neces
bkramer accepted this revision.
bkramer added a comment.
GCC 4.7 is dead. Go ahead if it compiles.
https://reviews.llvm.org/D22712
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mclow.lists created this revision.
mclow.lists added reviewers: EricWF, lefticus, AntonBikineev.
mclow.lists added a subscriber: cfe-commits.
This just does the `move_iterator` bits of http://wg21.link/P0031 - not any of
the other parts.
This duplicates some (but not all) of the work that was do
mclow.lists added inline comments.
Comment at: include/iterator:1559
struct __libcpp_is_trivial_iterator
- : public _LIBCPP_BOOL_CONSTANT(is_pointer<_Iter>::value) {};
-
+: public _LIBCPP_BOOL_CONSTANT(is_pointer<_Iter>::value) {};
+
These c
Author: malcolm.parsons
Date: Thu Oct 20 10:31:34 2016
New Revision: 284735
URL: http://llvm.org/viewvc/llvm-project?rev=284735&view=rev
Log:
[clang-tidy] Simplify modernize-use-default
Summary:
clang-tidy now cleans up after replacements, so leave colon and comma
removal to that.
Reviewers: ang
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284735: [clang-tidy] Simplify modernize-use-default
(authored by malcolm.parsons).
Changed prior to commit:
https://reviews.llvm.org/D25769?vs=75140&id=75307#toc
Repository:
rL LLVM
https://reviews.
Hello guys,
>> Should we deprecate noduplicate then as convergent should cover both use
>> cases for OpenCL I believe? As far as I understand noduplicate was added
>> specifically for SPMD use cases...
>
> noduplicate has different semantics than convergent. Although it is proposed
> for SPMD
Author: malcolm.parsons
Date: Thu Oct 20 10:40:34 2016
New Revision: 284737
URL: http://llvm.org/viewvc/llvm-project?rev=284737&view=rev
Log:
Use auto in for loop
Modified:
clang-tools-extra/trunk/clang-tidy/modernize/UseDefaultCheck.cpp
Modified: clang-tools-extra/trunk/clang-tidy/modernize
Author: malcolm.parsons
Date: Thu Oct 20 11:08:03 2016
New Revision: 284742
URL: http://llvm.org/viewvc/llvm-project?rev=284742&view=rev
Log:
[clang-tidy] Add check 'readability-redundant-member-init'
Summary: The check emits a warning if a member-initializer calls the member's
default construct
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284742: [clang-tidy] Add check
'readability-redundant-member-init' (authored by malcolm.parsons).
Changed prior to commit:
https://reviews.llvm.org/D24339?vs=74769&id=75311#toc
Repository:
rL LLVM
h
NoQ marked 9 inline comments as done.
NoQ added a comment.
I thought to give it a pause to take a fresh look at how to arrange the
macro-hints in the summaries.
Maybe something like that:
CASE
ARGUMENT_CONDITION(ARG_NO(0), OutOfRange)
RANGE('0', '9')
RANGE('A', 'Z')
RANG
+ Tom Matt
Thanks Ettore.
I think OpenCL is subject to the same issue, and noduplicate does not help
either.
Basically if a function A directly or indirectly calls a convergent function
e.g. barrier, function A itself must also be marked as convergent, otherwise
optimization passes may trans
rjmccall added a comment.
The fact that this bug only arises when performing a *second* instantiation
suggests that there's a deeper bug here, because template instantiation is not
supposed to modify the pattern AST. In this case, the basic problem is that,
when the parser processes a designat
Author: rengolin
Date: Thu Oct 20 12:41:08 2016
New Revision: 284749
URL: http://llvm.org/viewvc/llvm-project?rev=284749&view=rev
Log:
[clang-cl] Fix test that shouldn't be running on non-x86
The clang-cl test required x86-registered-target but it defaulted to the
host's triple and AArch64 still
dcoughlin added a comment.
In https://reviews.llvm.org/D20811#575521, @NoQ wrote:
> I thought to give it a pause to take a fresh look at how to arrange the
> macro-hints in the summaries.
>
> Maybe something like that:
>
> CASE
> ARGUMENT_CONDITION(ARG_NO(0), OutOfRange)
> RANGE('0',
rnk added inline comments.
Comment at: test/CodeGen/avx512-kconstraints-att_inline_asm.c:6
+void mask_Yk_i8(char msk){
+//CHECK: #APP
+//CHECK: vpaddb %xmm1, %xmm0, %xmm1 {%k1}
The LLVM IR won't have #APP markers in it. Does this test really pass?
https://rev
mgehre added inline comments.
Comment at: clang-tidy/cppcoreguidelines/ProTypeReinterpretCastCheck.cpp:25
- Finder->addMatcher(cxxReinterpretCastExpr().bind("cast"), this);
+ std::vector Rules{"type", "type.1",
"cppcoreguidelines-pro-type-reinterpret-cast"};
+
Finder->addM
NoQ added a reviewer: zaks.anna.
NoQ added a comment.
Ping!~ Did my idea sound completely wrong to you? :)
Does https://reviews.llvm.org/D25660 depend on this patch? And/or did you find
another workaround?
https://reviews.llvm.org/D22374
___
cfe-c
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
Repository:
rL LLVM
https://reviews.llvm.org/D25012
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
Author: rsmith
Date: Thu Oct 20 12:57:33 2016
New Revision: 284753
URL: http://llvm.org/viewvc/llvm-project?rev=284753&view=rev
Log:
[c++1z] Teach composite pointer type computation how to compute the composite
pointer type of two function pointers with different noexcept specifications.
While I'm
Author: kromanova
Date: Thu Oct 20 12:59:15 2016
New Revision: 284754
URL: http://llvm.org/viewvc/llvm-project?rev=284754&view=rev
Log:
Add more doxygen comments to emmintrin.h's intrinsics.
With this patch, 75% of the intrinsics in this file will be documented now. The
patches for the rest of t
rjmccall added a comment.
Looks great to me, thanks.
https://reviews.llvm.org/D25813
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
NoQ added a comment.
Ouch, i think i forgot about `OSNumber`, including tests.
Comment at: lib/StaticAnalyzer/Checkers/NumberObjectConversionChecker.cpp:111
+ QualType ObjT = (IsCpp || IsObjC)
+ ? Obj->getType().getCanonicalType().getUnqualifiedType()
+
manmanren updated this revision to Diff 75326.
manmanren added a comment.
Thanks Richard for the testing case. It is also obvious from the testing case
that we can have another diagnostic in flight when emitting
err_fe_pch_file_modified.
https://reviews.llvm.org/D25806
Files:
include/clang/
Author: rsmith
Date: Thu Oct 20 13:29:25 2016
New Revision: 284761
URL: http://llvm.org/viewvc/llvm-project?rev=284761&view=rev
Log:
[c++1z] Fix assertion failure when using the wrong number of bindings for a
struct with unnamed bitfields.
Modified:
cfe/trunk/lib/Sema/SemaDeclCXX.cpp
cfe/
alexshap added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/NumberObjectConversionChecker.cpp:149
BugReporter &BR) const {
MatchFinder F;
Callback CB(this, BR, AM.getAnalysisDeclContext(D));
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284766: [CodeGen] Devirtualize calls to methods marked final
in a derived class (authored by vedantk).
Changed prior to commit:
https://reviews.llvm.org/D25813?vs=75266&id=75331#toc
Repository:
rL LL
Author: vedantk
Date: Thu Oct 20 13:44:14 2016
New Revision: 284766
URL: http://llvm.org/viewvc/llvm-project?rev=284766&view=rev
Log:
[CodeGen] Devirtualize calls to methods marked final in a derived class
If we see a virtual method call to Base::foo() but can infer that the
object is an instance
sebpop added a comment.
In https://reviews.llvm.org/D24991#571056, @hiraditya wrote:
> Marshall suggests using macro as we discussed offline. For some reason the
> reply does not appear here:
> http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20161010/173780.html
Ping.
Repository:
phosek created this revision.
phosek added a reviewer: rsmith.
phosek added a subscriber: cfe-commits.
phosek set the repository for this revision to rL LLVM.
Herald added a subscriber: aemerson.
Fuchsia also experimentally supports ARM32 architecture, add it to the list of
supported targets.
R
tra created this revision.
tra added a reviewer: jlebar.
tra added a subscriber: cfe-commits.
https://reviews.llvm.org/D25839
Files:
include/clang/Sema/Sema.h
lib/Sema/SemaCUDA.cpp
lib/Sema/SemaDecl.cpp
Index: lib/Sema/SemaDecl.cpp
=
bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D25696
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
mgrang created this revision.
mgrang added reviewers: abdulras, honggyu.kim.
mgrang added a subscriber: cfe-commits.
mgrang added a project: clang-c.
Herald added subscribers: rengolin, aemerson.
Limit clang/test/Frontend/gnu-mcount.c to ARM only.
https://reviews.llvm.org/D25842
Files:
test/F
mgorny added a comment.
Thanks for the review. I'll now look into updating the code for other distros
to follow suit.
https://reviews.llvm.org/D25696
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
Author: mgorny
Date: Thu Oct 20 15:13:35 2016
New Revision: 284770
URL: http://llvm.org/viewvc/llvm-project?rev=284770&view=rev
Log:
[Driver] Parse Debian version as integer when possible. NFC
Replace the string matching for /etc/debian_version with split
integer/string matching algorithm. When t
bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.
Very nice!
LGTM
https://reviews.llvm.org/D25819
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284770: [Driver] Parse Debian version as integer when
possible. NFC (authored by mgorny).
Changed prior to commit:
https://reviews.llvm.org/D25696?vs=75269&id=75345#toc
Repository:
rL LLVM
https://r
rengolin added inline comments.
Comment at: test/Frontend/gnu-mcount.c:1
+// REQUIRES: arm-registered-target
+
If you have ARM but not AArch64, this test will also fail. Can you use AND on
REQUIRES?
https://reviews.llvm.org/D25842
__
tra created this revision.
tra added reviewers: jlebar, rsmith.
tra added a subscriber: cfe-commits.
Some functions and templates are treated as `__host__` `__device__` even when
they don't have explicitly specified target attributes.
What's worse, this treatment may change depending on command l
ahatanak created this revision.
ahatanak added a reviewer: rjmccall.
ahatanak added a subscriber: cfe-commits.
ARC implicitly marks indirect parameters passed to a function as autoreleasing
and passing a block that captures those parameters to another function
sometimes causes problems that are
Author: mgorny
Date: Thu Oct 20 15:45:40 2016
New Revision: 284774
URL: http://llvm.org/viewvc/llvm-project?rev=284774&view=rev
Log:
[Driver] Refactor DetectDistro() parameters to take VFS ref only. NFC
Refactor the DetectDistro() function to take a single vfs::FileSystem
reference only, instead
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284774: [Driver] Refactor DetectDistro() parameters to take
VFS ref only. NFC (authored by mgorny).
Changed prior to commit:
https://reviews.llvm.org/D25819?vs=75283&id=75350#toc
Repository:
rL LLVM
GorNishanov abandoned this revision.
GorNishanov added a comment.
I'll simplify and split it into super tiny microscopic patches to have a better
chance of being reviewed.
https://reviews.llvm.org/D25258
___
cfe-commits mailing list
cfe-commits@lis
Author: rnk
Date: Thu Oct 20 15:53:20 2016
New Revision: 284777
URL: http://llvm.org/viewvc/llvm-project?rev=284777&view=rev
Log:
Fix off-by-one error in PPCaching.cpp token annotation assertion
This assert is intended to defend against backtracking into the middle
of a sequence of tokens that is
Author: hans
Date: Thu Oct 20 15:54:32 2016
New Revision: 284778
URL: http://llvm.org/viewvc/llvm-project?rev=284778&view=rev
Log:
Revert r284753 "[c++1z] Teach composite pointer type computation how to compute
the composite"
It caused PR30749.
Removed:
cfe/trunk/test/CXX/expr/p13.cpp
Modif
elsteveogrande updated this revision to Diff 75351.
elsteveogrande added a comment.
Fixed an error. A newline is sometimes not appended prior to this `#include`.
When returning from an included file which doesn't have a trailing newline, the
#include is stuck at the end of some other line, i.e.
On Thu, Oct 20, 2016 at 10:57 AM, Richard Smith via cfe-commits
wrote:
> Author: rsmith
> Date: Thu Oct 20 12:57:33 2016
> New Revision: 284753
>
> URL: http://llvm.org/viewvc/llvm-project?rev=284753&view=rev
> Log:
> [c++1z] Teach composite pointer type computation how to compute the composite
>
1 - 100 of 135 matches
Mail list logo
