Re: [PATCH] D19451: [clang-tidy] New checker for redundant expressions.

etienneb added inline comments. Comment at: clang-tidy/misc/RedundantExpressionCheck.cpp:21 @@ +20,3 @@ + +static bool AreIdenticalExpr(const Expr *Left, const Expr *Right) { + if (!Left || !Right) alexfh wrote: > This is to some degree similar to comparing `llvm

[PATCH] D19539: Fix a crash in cppcoreguidelines-pro-type-member-init when checking a type with a template parameter as a base class.

michael_miller created this revision. michael_miller added reviewers: hokein, aaron.ballman, alexfh. michael_miller added a subscriber: cfe-commits. Fixed a crash in cppcoreguidelines-pro-type-member-init when encountering a type that uses one of its template parameters as a base when compiling f

[PATCH] D19541: Fix generation of documentation for UndefinedBehaviorSanitizer.

etienneb created this revision. etienneb added a reviewer: alexfh. etienneb added a subscriber: cfe-commits. The text is mis-aligned. http://reviews.llvm.org/D19541 Files: docs/UndefinedBehaviorSanitizer.rst Index: docs/UndefinedBehaviorSanitizer.rst ==

Re: [PATCH] D19541: Fix generation of documentation for UndefinedBehaviorSanitizer.

etienneb added a comment. This got fixed. Abandoning this change. http://reviews.llvm.org/D19541 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] r267574 - [clang-tidy] New checker for redundant expressions.

Author: etienneb Date: Tue Apr 26 12:30:30 2016 New Revision: 267574 URL: http://llvm.org/viewvc/llvm-project?rev=267574&view=rev Log: [clang-tidy] New checker for redundant expressions. Summary: This checker finds redundant expression on both side of a binary operator. The current implementatio

[clang-tools-extra] r267576 - [Release notes] Mention Clang-tidy misc-fold-init-type check.

Author: eugenezelenko Date: Tue Apr 26 12:54:00 2016 New Revision: 267576 URL: http://llvm.org/viewvc/llvm-project?rev=267576&view=rev Log: [Release notes] Mention Clang-tidy misc-fold-init-type check. Highlighting consistency in Clang-tidy misc-fold-init-type check documentation. Modified:

Re: [PATCH] D18271: Avoid -Wshadow warnings about constructor parameters named after fields

rnk updated this revision to Diff 55044. rnk added a comment. - Implement suggestions to avoid warning twice http://reviews.llvm.org/D18271 Files: include/clang/Basic/Diagnostic.h include/clang/Basic/DiagnosticGroups.td include/clang/Basic/DiagnosticSemaKinds.td include/clang/Sema/Sema.

Re: [PATCH] D19299: lower __builtin_expect() directly to prof metadata instead of LLVM intrinsic

spatel abandoned this revision. spatel added a comment. Abandoning. The feedback on the dev list was that handling the builtin_expect() in clang is ugly, so it's better to pay a small cost in LLVM to do it. Note that the current llvm.expect lowering pass doesn't actually work for anything but

[PATCH] D19547: [clang-tidy] Add FixIt for swapping arguments in string-constructor-checker.

etienneb created this revision. etienneb added a reviewer: alexfh. etienneb added a subscriber: cfe-commits. Arguments can be swapped using fixit when they are not in macros. This is the same implementation than SwappedArguments. Some code got lifted to be reused. Others checks are not safe to b

Re: [PATCH] D17820: Clang Code Completion Filtering

benlangmuir added a comment. Overall approach seems good to me, but this needs tests. Other feedback inline. Comment at: include/clang/Sema/CodeCompleteConsumer.h:920 @@ +919,3 @@ +CodeCompletionResult Results) { +return true; + } --

Re: r267496 - [lanai] Update handling of structs in arguments to be passed in registers.

On Tue, Apr 26, 2016 at 6:49 AM, Jacques Pienaar wrote: > Thanks for fixing this. My apologies for breaking this and not noticing & > fixing it earlier. > no problem. > Is there any way to test the Windows build without a Windows machine at my > disposal? > Not that I know of. My workflow for

r267584 - [CMake] Use just-built clang and build iOS support when building stage2

Author: cbieneman Date: Tue Apr 26 13:39:20 2016 New Revision: 267584 URL: http://llvm.org/viewvc/llvm-project?rev=267584&view=rev Log: [CMake] Use just-built clang and build iOS support when building stage2 The Apple stage2 build should include compiler-rt iOS libraries and be built with the st

[clang-tools-extra] r267587 - [clang-tidy] Added misc-move-const-arg docs.

Author: alexfh Date: Tue Apr 26 13:48:59 2016 New Revision: 267587 URL: http://llvm.org/viewvc/llvm-project?rev=267587&view=rev Log: [clang-tidy] Added misc-move-const-arg docs. Added: clang-tools-extra/trunk/docs/clang-tidy/checks/misc-move-const-arg.rst Modified: clang-tools-extra/trunk

r267590 - [OpenCL] Add predefined macros.

Author: yaxunl Date: Tue Apr 26 14:25:46 2016 New Revision: 267590 URL: http://llvm.org/viewvc/llvm-project?rev=267590&view=rev Log: [OpenCL] Add predefined macros. OpenCL spec requires __OPENCL_C_VERSION__ to be defined based on -cl-std option. This patch implements that. The patch also define

Re: [PATCH] D19071: [OpenCL] Add predefined macros.

This revision was automatically updated to reflect the committed changes. Closed by commit rL267590: [OpenCL] Add predefined macros. (authored by yaxunl). Changed prior to commit: http://reviews.llvm.org/D19071?vs=55016&id=55066#toc Repository: rL LLVM http://reviews.llvm.org/D19071 Files:

[libcxx] r267591 - Apparently XFAIL tests that are supposed to fail to compile can be problematic. They still get compiled, and if the compile succeeds, the buildbots complain. Replace the XFAIL with

Author: marshall Date: Tue Apr 26 14:29:35 2016 New Revision: 267591 URL: http://llvm.org/viewvc/llvm-project?rev=267591&view=rev Log: Apparently XFAIL tests that are supposed to fail to compile can be problematic. They still get compiled, and if the compile succeeds, the buildbots complain. Rep

[clang-tools-extra] r267592 - [clang-tidy] Now adding correct misc-move-const-arg documentation ; ]

Author: alexfh Date: Tue Apr 26 14:33:49 2016 New Revision: 267592 URL: http://llvm.org/viewvc/llvm-project?rev=267592&view=rev Log: [clang-tidy] Now adding correct misc-move-const-arg documentation ;] + brushed the code a bit and renamed the test file to match the check name Added: clang-to

[PATCH] D19552: Check 'r' and 'y specifiers of freebsd_kernel_printf format strings on PS4

Sunil_Srivastava created this revision. Sunil_Srivastava added a reviewer: dim. Sunil_Srivastava added a subscriber: cfe-commits. Herald added a subscriber: emaste. This is an addendum to r229921. http://reviews.llvm.org/D19552 Files: lib/Analysis/FormatString.cpp test/Sema/format-strings-f

Re: [PATCH] D18136: boost-use-to-string check

Prazek marked 5 inline comments as done. Comment at: clang-tidy/boost/UseToStringCheck.cpp:60 @@ +59,3 @@ + else +return; + alexfh wrote: > Please add a reduced test case for this. I don't see it crashing right now on the same test when it was crashing before

Re: [PATCH] D18136: boost-use-to-string check

Prazek updated this revision to Diff 55077. Prazek marked an inline comment as done. Prazek added a comment. I hope it is final http://reviews.llvm.org/D18136 Files: clang-tidy/boost/BoostTidyModule.cpp clang-tidy/boost/CMakeLists.txt clang-tidy/boost/UseToStringCheck.cpp clang-tidy/boo

Re: [PATCH] D18136: boost-use-to-string check

Prazek added a comment. Alex, if you accept this revision, please accept this also http://reviews.llvm.org/D18274 http://reviews.llvm.org/D18136 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/c

Re: [PATCH] D19552: Check 'r' and 'y specifiers of freebsd_kernel_printf format strings on PS4

dim accepted this revision. dim added a comment. This revision is now accepted and ready to land. LGTM. Comment at: test/Sema/format-strings-freebsd.c:39 @@ -35,1 +38,3 @@ + freebsd_kernel_printf("%hr", h); // no-warning + // %y expects an int It's nice to a

r267601 - Try to get at_file_missing.c passing after LLVM r267556.

Author: nico Date: Tue Apr 26 15:40:23 2016 New Revision: 267601 URL: http://llvm.org/viewvc/llvm-project?rev=267601&view=rev Log: Try to get at_file_missing.c passing after LLVM r267556. r267556 made backslashes escape the next character unconditionally in rsp files. This test echos a path into

Re: [PATCH] D19175: Fix for PR27015 (variable template initialized with a generic lambda expression)

ahatanak added a comment. I'm looking for a way to avoid the assert in Sema::PerformDependentDiagnostics that is fired when a template parameter doesn't have a name. In order to avoid the assert, CXXRecordDecl::isDependentLambda() should return true for the old lambda class, and in order to do

r267604 - Test commit

Author: epilk Date: Tue Apr 26 15:55:48 2016 New Revision: 267604 URL: http://llvm.org/viewvc/llvm-project?rev=267604&view=rev Log: Test commit Modified: cfe/trunk/lib/Sema/SemaStmt.cpp Modified: cfe/trunk/lib/Sema/SemaStmt.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/Sem

Re: [PATCH] D19175: Fix for PR27015 (variable template initialized with a generic lambda expression)

On Tue, Apr 26, 2016 at 1:55 PM, Akira Hatanaka via cfe-commits < cfe-commits@lists.llvm.org> wrote: > ahatanak added a comment. > > I'm looking for a way to avoid the assert in > Sema::PerformDependentDiagnostics that is fired when a template parameter > doesn't have a name. > > In order to avoid

Re: [PATCH] D17933: Set MaxAtomicInlineWidth properly for i386, i486, and x86-64 cpus without cmpxchg16b.

jyknight added a comment. ping again. http://reviews.llvm.org/D17933 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19385: [scan-build] fix logic error warnings emitted on clang code base

apelete updated this revision to Diff 55103. apelete added a comment. [scan-build] fix logic error warnings emitted on clang code base Chnages since last revision: - lib/Format/Format.cpp: removed all changes, redenderd obsolete by upstream. http://reviews.llvm.org/D19385 Files: lib/AST/Dec

r267611 - Module debugging: Use the definition to determine module-defined types.

Author: adrian Date: Tue Apr 26 16:58:18 2016 New Revision: 267611 URL: http://llvm.org/viewvc/llvm-project?rev=267611&view=rev Log: Module debugging: Use the definition to determine module-defined types. Follow-up to r267464. Thanks to Richard Smith for pointing this out! Modified: cfe/trun

r267612 - Module debugging: Add testcase for member classes of class template specializations.

Author: adrian Date: Tue Apr 26 16:58:23 2016 New Revision: 267612 URL: http://llvm.org/viewvc/llvm-project?rev=267612&view=rev Log: Module debugging: Add testcase for member classes of class template specializations. Modified: cfe/trunk/test/Modules/ExtDebugInfo.cpp cfe/trunk/test/Modul

Re: r267464 - Module Debugging: Fix the condition for determining whether a template

> On Apr 25, 2016, at 5:34 PM, Richard Smith wrote: > > On Mon, Apr 25, 2016 at 1:52 PM, Adrian Prantl via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: > Author: adrian > Date: Mon Apr 25 15:52:40 2016 > New Revision: 267464 > > URL: http://llvm.org/viewvc/llvm-project?rev=267464&v

Re: [PATCH] D19552: Check 'r' and 'y specifiers of freebsd_kernel_printf format strings on PS4

Sunil_Srivastava added a comment. I had put these 'h' test lines to test the first of my changes, and this sufficed, but you are correct. I should add %y too. I am going to add '%hr' and '%hy'. Comment at: test/Sema/format-strings-freebsd.c:39 @@ -35,1 +38,3 @@ + freebsd_kern

[PATCH] D19565: [libc++] Fix an accidental assignment within assert() that should have been equality.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. [libc++] Fix an accidental assignment within assert() that should have been equality. Fixes MSVC "warning C4706: assignment within conditional expression". http://reviews.llv

Re: r267464 - Module Debugging: Fix the condition for determining whether a template

On Tue, Apr 26, 2016 at 3:10 PM, Adrian Prantl via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > On Apr 25, 2016, at 5:34 PM, Richard Smith wrote: > > On Mon, Apr 25, 2016 at 1:52 PM, Adrian Prantl via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: adrian >> Date: Mon Apr

r267625 - Check 'r' and 'y specifiers of freebsd_kernel_printf format strings on PS4

Author: ssrivastava Date: Tue Apr 26 18:19:00 2016 New Revision: 267625 URL: http://llvm.org/viewvc/llvm-project?rev=267625&view=rev Log: Check 'r' and 'y specifiers of freebsd_kernel_printf format strings on PS4 This is an addendum to r229921. Modified: cfe/trunk/lib/Analysis/FormatString.c

Re: [PATCH] D19412: [libcxx] Refactor pthread usage - II

rmaprath updated this revision to Diff 55119. rmaprath added a comment. Addressing review comments from @bcraig: In the earlier patch, I tried to keep the `__os_support` header to a minimum by not exposing the internal pthread dependencies (in library sources) in this header. This however blew

r267630 - Module debugging: Also correctly handle typedef'd foward-declared members.

Author: adrian Date: Tue Apr 26 18:37:38 2016 New Revision: 267630 URL: http://llvm.org/viewvc/llvm-project?rev=267630&view=rev Log: Module debugging: Also correctly handle typedef'd foward-declared members. Thanks again to Richard Smith for pointing this out. Modified: cfe/trunk/lib/CodeGen/

r267632 - PR27513: When determining which declaration to put into an exported lookup

Author: rsmith Date: Tue Apr 26 18:40:43 2016 New Revision: 267632 URL: http://llvm.org/viewvc/llvm-project?rev=267632&view=rev Log: PR27513: When determining which declaration to put into an exported lookup table for a module / PCH, never map from a normal declaration of a class to an injected-cl

r267633 - Module debugging: Add an assertion.

Author: adrian Date: Tue Apr 26 18:42:43 2016 New Revision: 267633 URL: http://llvm.org/viewvc/llvm-project?rev=267633&view=rev Log: Module debugging: Add an assertion. Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp URL: http://llvm.org/viewv

Re: [PATCH] D19415: [libcxx][rfc] Externalized threading support

rmaprath updated this revision to Diff 55127. rmaprath added a comment. Addressing review comments from @bcraig: Adjusted according to the changes of http://reviews.llvm.org/D19412. This patch is now mostly trivial. There is a small catch in that, this version of the API takes pointer-to-point

Re: r267464 - Module Debugging: Fix the condition for determining whether a template

> On Apr 26, 2016, at 4:11 PM, Richard Smith wrote: > > On Tue, Apr 26, 2016 at 3:10 PM, Adrian Prantl via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: > >> On Apr 25, 2016, at 5:34 PM, Richard Smith > > wrote: >> >> On Mon, Apr 25, 2016 at 1:52 PM, A

[PATCH] D19567: PR21823: 'nodebug' attribute on global/static variables

probinson created this revision. probinson added reviewers: dblaikie, aprantl. probinson added a subscriber: cfe-commits. 'nodebug' on a function will currently suppress all debug info for the function and its contents. 'nodebug on a static-duration variable will currently suppress debug info for

Re: [PATCH] D19567: PR21823: 'nodebug' attribute on global/static variables

aaron.ballman added a subscriber: aaron.ballman. aaron.ballman accepted this revision. aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM on the attribute part. Someone else should pipe up if the debug info part look

Re: [PATCH] D19552: Check 'r' and 'y specifiers of freebsd_kernel_printf format strings on PS4

Sunil_Srivastava closed this revision. Sunil_Srivastava added a comment. Submitted as r267625. http://reviews.llvm.org/D19552 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19327: Keep invalid function body as part of the AST

rsmith added inline comments. Comment at: lib/Sema/SemaDecl.cpp:5044-5045 @@ -5043,4 +5043,4 @@ // function template specialization, add it to the scope stack. - if (New->getDeclName() && AddToScope && - !(D.isRedeclaration() && New->isInvalidDecl())) { + if (New->getDe

Re: [PATCH] D19003: Set C99 as default C Standard for PS4 target

probinson accepted this revision. probinson added a reviewer: probinson. probinson added a comment. This revision is now accepted and ready to land. LGTM. http://reviews.llvm.org/D19003 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://

Re: r267534 - [MSVC] PR27337: allow static_cast from private base to derived for WTL

As noted in PR27337, this only occurs in one WTL sample, and we have no evidence that it actually occurs in real code. Have you seen uses of this in the wild? We generally don't want to add compatibility for MSVC bugs unless there's some real-world motivation. On Tue, Apr 26, 2016 at 2:21 AM, Dmit

Re: [PATCH] D19565: [libc++] Fix an accidental assignment within assert() that should have been equality.

mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. Whoops! LGTM. http://reviews.llvm.org/D19565 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mai

Re: [PATCH] D18641: [PP] Handle #include_next after include found relative to current one same as GCC

rsmith added a comment. I'm a little concerned about the possibility of this breaking uses of this feature on platforms where Clang is the system compiler. For instance, this pattern would be broken by your change: // stddef.h #include "stddef-helper.h" // stddef-helper.h #include_ne

[libcxx] r267654 - Fix = that should have been == in test. Thanks to STL@microsoft for the catch

Author: marshall Date: Tue Apr 26 20:46:43 2016 New Revision: 267654 URL: http://llvm.org/viewvc/llvm-project?rev=267654&view=rev Log: Fix = that should have been == in test. Thanks to STL@microsoft for the catch Modified: libcxx/trunk/test/std/containers/associative/map/compare.pass.cpp Mod

Re: [PATCH] D19565: [libc++] Fix an accidental assignment within assert() that should have been equality.

mclow.lists closed this revision. mclow.lists added a comment. Committed as revision 267654. http://reviews.llvm.org/D19565 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r267534 - [MSVC] PR27337: allow static_cast from private base to derived for WTL

Visual Studio 2015 (19.00.23720.0) reports: error C2243: 'static_cast': conversion from 'B *' to 'A *' exists, but is inaccessible On Tue, Apr 26, 2016 at 6:33 PM, Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > As noted in PR27337, this only occurs in one WTL sample, and we

Re: r267534 - [MSVC] PR27337: allow static_cast from private base to derived for WTL

On Tue, Apr 26, 2016 at 7:04 PM, David Majnemer via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Visual Studio 2015 (19.00.23720.0) reports: > > error C2243: 'static_cast': conversion from 'B *' to 'A *' exists, but is > inaccessible > Right, it's the other direction ('A *' to 'B *') that t

Re: [PATCH] D19524: [OpenCL] Fix pipe type dump.

pxli168 added a comment. I will add a test and send a new version. http://reviews.llvm.org/D19524 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D19577: [clang-tidy] Enhance misc-suspicious-string-compare by matching string.compare

etienneb created this revision. etienneb added a reviewer: alexfh. etienneb added a subscriber: cfe-commits. This patch added the support for method "compare" on string-like classes. The LLVM stringRef is supported. The checker assume that StringRef is returning -1, 0 or 1. Which is not the case

Re: [PATCH] D19524: [OpenCL] Fix pipe type dump.

pxli168 updated this revision to Diff 55161. pxli168 added a comment. Add test and fix some old test. http://reviews.llvm.org/D19524 Files: lib/AST/ASTDumper.cpp lib/AST/TypePrinter.cpp test/Misc/ast-dump-pipe.cl test/SemaOpenCL/invalid-access-qualifier.cl test/SemaOpenCL/invalid-pipe

Re: [PATCH] D19311: [analyzer] Self Assignment Checker

baloghadamsoftware updated this revision to Diff 54968. baloghadamsoftware added a comment. Initial comments added to the checker and tests are converted from (DOS) to (Unix) format. http://reviews.llvm.org/D19311 Files: lib/StaticAnalyzer/Checkers/CMakeLists.txt lib/StaticAnalyzer/Check

Re: [PATCH] D18442: A clang-tidy check for std:accumulate.

courbet updated this revision to Diff 54969. courbet marked 2 inline comments as done. courbet added a comment. Fix doc formatting and add more doc. http://reviews.llvm.org/D18442 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/FoldInitTypeCheck.cpp clang-tidy/misc/FoldInitTypeCheck

Re: [PATCH] D18442: A clang-tidy check for std:accumulate.

courbet added inline comments. Comment at: docs/clang-tidy/checks/misc-fold-init-type.rst:16-17 @@ +15,4 @@ + +.. code:: c++ + auto a = {0.5f, 0.5f, 0.5f, 0.5f}; + return std::accumulate(std::begin(a), std::end(a), 0); alexfh wrote: > Prazek wrote: > > Doesn't .

[PATCH] D19524: [OpenCL] Fix pipe type dump.

pxli168 created this revision. pxli168 added reviewers: Anastasia, yaxunl. pxli168 added subscribers: bader, cfe-commits. Fix the dump of PipeType. Now we will have "pipe int" and element type. http://reviews.llvm.org/D19524 Files: lib/AST/ASTDumper.cpp lib/AST/TypePrinter.cpp Index: lib/AS

Re: [PATCH] D19524: [OpenCL] Fix pipe type dump.

bader added a comment. LGTM. Probably it would be forth to add a simple test. http://reviews.llvm.org/D19524 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19478: Remove assert mandating you can only use SPIR target with OpenCL

sheredom added a comment. So we build a bunch of internal libraries in a mix of OpenCL and C++, and then link them all together to create SPIR libraries that can be fed to calls to clLinkProgram and linked against user kernels. I don't have commit writes to Clang - if the patch is ok to go coul

r267534 - [MSVC] PR27337: allow static_cast from private base to derived for WTL

Author: dpolukhin Date: Tue Apr 26 04:21:17 2016 New Revision: 267534 URL: http://llvm.org/viewvc/llvm-project?rev=267534&view=rev Log: [MSVC] PR27337: allow static_cast from private base to derived for WTL MSVC doesn't report even warning for cast from private base class to derived. Differentia

Re: [PATCH] D19477: [MSVC] PR27337: allow static_cast from private base to derived for WTL

This revision was automatically updated to reflect the committed changes. Closed by commit rL267534: [MSVC] PR27337: allow static_cast from private base to derived for WTL (authored by dpolukhin). Changed prior to commit: http://reviews.llvm.org/D19477?vs=54829&id=54975#toc Repository: rL LL

Re: [PATCH] D19477: [MSVC] PR27337: allow static_cast from private base to derived for WTL

DmitryPolukhin added a comment. Thank you for the review! Repository: rL LLVM http://reviews.llvm.org/D19477 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18641: [PP] Handle #include_next after include found relative to current one same as GCC

DmitryPolukhin added a comment. Richard, friendly ping, PTAL! http://reviews.llvm.org/D18641 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18442: A clang-tidy check for std:accumulate.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Looks good now. Thank you for the new check! Do you need me to submit the patch for you? http://reviews.llvm.org/D18442 ___ cfe-commits mailing

Re: [PATCH] D19259: Initial version of misc-unused-using-decl check

alexfh closed this revision. alexfh added a comment. This seems to have been committed as r266735. http://reviews.llvm.org/D19259 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18265: [clang-tidy] New: checker misc-unconventional-assign-operator replacing misc-assign-operator-signature

alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. There still seem to be a few comments from sbenza and myself that need to be resolved. http://reviews.llvm.org/D18265 ___ cfe-commits

Re: [PATCH] D18300: [clang-tidy] ProTypeMemberInitCheck - check that field decls do not have in-class initializer

alexfh added a comment. Felix, do you have time to commit the patch or should I do this for you? Repository: rL LLVM http://reviews.llvm.org/D18300 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/list

Re: [PATCH] D18442: A clang-tidy check for std:accumulate.

courbet added a comment. In http://reviews.llvm.org/D18442#411785, @alexfh wrote: > Looks good now. Thank you for the new check! Thanks for the review. > Do you need me to submit the patch for you? Yes, please. http://reviews.llvm.org/D18442 _

Re: r264417 - [ASTMatchers] Add own version of VariadicFunction.

BTW, this commit removes the last usage of llvm/ADT/VariadicFunction.h. Should we kill this header? On Fri, Mar 25, 2016 at 8:51 PM, Mehdi Amini via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Thanks! > > On Mar 25, 2016, at 12:47 PM, Samuel Benzaquen wrote: > > Fixed in r264453. > Sorry

[clang-tools-extra] r267542 - A clang-tidy check for std:accumulate.

Author: alexfh Date: Tue Apr 26 05:05:45 2016 New Revision: 267542 URL: http://llvm.org/viewvc/llvm-project?rev=267542&view=rev Log: A clang-tidy check for std:accumulate. Summary: For folds (e.g. std::accumulate), check matches between the provided init value and the range's value_type. A typic

Re: [PATCH] D18442: A clang-tidy check for std:accumulate.

This revision was automatically updated to reflect the committed changes. Closed by commit rL267542: A clang-tidy check for std:accumulate. (authored by alexfh). Changed prior to commit: http://reviews.llvm.org/D18442?vs=54969&id=54978#toc Repository: rL LLVM http://reviews.llvm.org/D18442

Re: [PATCH] D18265: [clang-tidy] New: checker misc-unconventional-assign-operator replacing misc-assign-operator-signature

alexfh added a comment. Wait, I probably was looking at an older diff somehow. After returning to the page I don't see any unresolved comments. Reviewing... http://reviews.llvm.org/D18265 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

Re: [PATCH] D19479: 26748 - clang-cl fails to compile atlctrlw.h header from WTL

avt77 added a comment. OK, I'll try to implement something like a DependentScopeDeclRefExpr but because of the latest changes in Intel I'm afraid it will take some more time from me. http://reviews.llvm.org/D19479 ___ cfe-commits mailing list cfe-

Re: [PATCH] D19156: [ms][dll] #27212: Generating of implicit special members should take into account MSVC compatibility version

avt77 added a comment. It seems it will be even shorter if we do it via Sema::checkClassLevelDLLAttribute. Tnx. http://reviews.llvm.org/D19156 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cf

Re: [PATCH] D18953: [ms][dll] #26935 Defining a dllimport function should cause it to be exported

avt77 added a comment. In fact you introduced the plan of actions to fix the issue. Tnx. http://reviews.llvm.org/D18953 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19415: [libcxx][rfc] Externalized threading support

rmaprath added a comment. I forgot to mention that we will need a similar (although much smaller) porting layer for `libcxxabi` and `libunwind`, as those too currently have a pthread dependency. http://reviews.llvm.org/D19415 ___ cfe-commits maili

Re: [PATCH] D18265: [clang-tidy] New: checker misc-unconventional-assign-operator replacing misc-assign-operator-signature

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. No objections from me, but please wait for Samuel's review. http://reviews.llvm.org/D18265 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

Re: [PATCH] D18919: [Clang-tidy] Add check "modernize use using"

krystyna updated this revision to Diff 54974. krystyna marked an inline comment as done. Repository: rL LLVM http://reviews.llvm.org/D18919 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidyModule.cpp clang-tidy/modernize/UseUsingCheck.cpp clang-tidy/moderniz

Re: [PATCH] D19458: Add address space 258 to Clang documentation

mkuper added a comment. LGTM http://reviews.llvm.org/D19458 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19482: [include-fixer] Add a find-all-symbols tool for include-fixer.

bkramer added a comment. First, please run this through clang-format with LLVM style. This aligns all the & and * to the name instead of the type. There are also some underscore_names left that need conversion to PascalCase. Comment at: include-fixer/find-all-symbols/FindAllSy

Re: [PATCH] D18694: [ClangTidy] Add an 'explain-checks' option to diagnose where each checks comes from.

hokein updated this revision to Diff 54996. hokein marked an inline comment as done. hokein added a comment. - VS2013 doesn't support constexpr. - Don't make test read external .clang-tidy file. http://reviews.llvm.org/D18694 Files: clang-tidy/ClangTidyOptions.cpp clang-tidy/ClangTidyOption

Re: [PATCH] D18694: [ClangTidy] Add an 'explain-checks' option to diagnose where each checks comes from.

alexfh added a comment. Sorry for the long delay. This is getting closer. A few more comments though. Comment at: clang-tidy/ClangTidyOptions.cpp:224 @@ +223,3 @@ + DefaultOptionsProvider::getRawOptions(FileName); + OptionsSource CommandLineOptions = + OptionsSource(O

Re: [PATCH] D19497: [clang-tidy] Enhance misc-suspicious-string-compare to move down false-positives.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG with one nit. Comment at: clang-tidy/misc/SuspiciousStringCompareCheck.cpp:215 @@ +214,3 @@ + if (Result.Nodes.getNodeAs("suspicious-operator")) { +diag(Call->getLocSt

Re: [PATCH] D17416: [libcxx] Reorganize locale extension fallbacks. NFCI

bcraig added a comment. ping @danalbert, @mclow.lists http://reviews.llvm.org/D17416 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19451: [clang-tidy] New checker for redundant expressions.

alexfh added a comment. BTW, have you seen the `alpha.core.IdenticalExpr` static analyzer checker? http://reviews.llvm.org/D19451 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19451: [clang-tidy] New checker for redundant expressions.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Awesome idea! LG with a couple of nits. In http://reviews.llvm.org/D19451#410064, @etienneb wrote: > Tested over LLVM code, no false positives. > > Two catches: > http://reviews.llvm.org/D19

Re: [PATCH] D19327: Keep invalid function body as part of the AST

ogoffart added a comment. Ping? http://reviews.llvm.org/D19327 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18300: [clang-tidy] ProTypeMemberInitCheck - check that field decls do not have in-class initializer

I should free up again soon, just caught the flu though. Maybe next week? Feel free to commit before then. On Tue, Apr 26, 2016 at 5:52 AM, Alexander Kornienko wrote: > alexfh added a comment. > > Felix, do you have time to commit the patch or should I do this for you? > > > Repository: > rL L

Re: [PATCH] D18963: PR27216: Only define __ARM_FEATURE_FMA when the target has VFPv4

rengolin added inline comments. Comment at: lib/Basic/Targets.cpp:4710 @@ -4709,1 +4709,3 @@ const std::vector &FeaturesVec) const override { +if (CPU == "") + CPU = "generic"; This change is unrelated and may bring side effects into cla

Re: [PATCH] D19412: [libcxx] Refactor pthread usage - II

rmaprath updated this revision to Diff 54999. rmaprath added a comment. Minor cleanup + Gentle ping. http://reviews.llvm.org/D19412 Files: include/__config include/__mutex_base include/__os_support include/mutex include/thread src/algorithm.cpp src/condition_variable.cpp src/mem

Re: [PATCH] D18963: PR27216: Only define __ARM_FEATURE_FMA when the target has VFPv4

sbaranga added inline comments. Comment at: lib/Basic/Targets.cpp:4710 @@ -4709,1 +4709,3 @@ const std::vector &FeaturesVec) const override { +if (CPU == "") + CPU = "generic"; rengolin wrote: > This change is unrelated and may bring sid

Re: [PATCH] D19451: [clang-tidy] New checker for redundant expressions.

alexfh added a comment. In http://reviews.llvm.org/D19451#411990, @alexfh wrote: > BTW, have you seen the `alpha.core.IdenticalExpr` static analyzer checker? Anna, Jordan, and whoever else is interested in the `alpha.core.IdenticalExpr` checker (lib/StaticAnalyzer/Checkers/IdenticalExprChecker

Re: [PATCH] D18694: [ClangTidy] Add an 'explain-checks' option to diagnose where each checks comes from.

hokein updated this revision to Diff 55001. hokein marked 8 inline comments as done. hokein added a comment. Address comments. http://reviews.llvm.org/D18694 Files: clang-tidy/ClangTidyOptions.cpp clang-tidy/ClangTidyOptions.h clang-tidy/tool/ClangTidyMain.cpp test/clang-tidy/Inputs/exp

Re: [PATCH] D19249: Fix include path in ClangTidy.cpp.

alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. In http://reviews.llvm.org/D19249#408437, @chh wrote: > This change depends on http://reviews.llvm.org/D19393. I'm personally fine with the solution in http://reviews.llvm.org/D1939

Re: [PATCH] D18694: [ClangTidy] Add an 'explain-checks' option to diagnose where each checks comes from.

hokein added inline comments. Comment at: clang-tidy/ClangTidyOptions.cpp:235 @@ +234,3 @@ +if (Iter != CachedOptions.end()) { + RawOptions.push_back(Iter->second); + break; alexfh wrote: > This seems to be changing the caching logic. Consider this d

Re: r267496 - [lanai] Update handling of structs in arguments to be passed in registers.

Thanks for fixing this. My apologies for breaking this and not noticing & fixing it earlier. Is there any way to test the Windows build without a Windows machine at my disposal? On Mon, Apr 25, 2016 at 6:59 PM, Kostya Serebryany wrote: > Hopefully fixed by r267513. > > On Mon, Apr 25, 2016 at 6:

Re: [PATCH] D18694: [ClangTidy] Add an 'explain-checks' option to diagnose where each checks comes from.

hokein marked an inline comment as done. hokein added a comment. http://reviews.llvm.org/D18694 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   >