r262806 - [ASTMatchers] Document that isAnyPointer() matcher also matches Objective-C object pointers.

Author: flx Date: Sun Mar 6 09:27:59 2016 New Revision: 262806 URL: http://llvm.org/viewvc/llvm-project?rev=262806&view=rev Log: [ASTMatchers] Document that isAnyPointer() matcher also matches Objective-C object pointers. Summary: Add test for Objective-C object pointer matching. Reviewers: aa

Re: [PATCH] D17910: clang-format: [JS] Handle certain cases of ASI.

djasper added inline comments. Comment at: lib/Format/UnwrappedLineParser.cpp:665 @@ +664,3 @@ +// well known cases. It *must not* return true in speculative cases. +bool UnwrappedLineParser::shouldInsertSemiBetween(FormatToken *Previous, +

[libcxx] r262807 - Update with work items passed in Jacksonville

Author: marshall Date: Sun Mar 6 11:45:24 2016 New Revision: 262807 URL: http://llvm.org/viewvc/llvm-project?rev=262807&view=rev Log: Update with work items passed in Jacksonville Modified: libcxx/trunk/www/cxx1z_status.html Modified: libcxx/trunk/www/cxx1z_status.html URL: http://llvm.org

Re: [PATCH] D17910: clang-format: [JS] Handle certain cases of ASI.

mprobst updated this revision to Diff 49922. mprobst marked 6 inline comments as done. mprobst added a comment. - Handle unary !. - Address review comments. http://reviews.llvm.org/D17910 Files: lib/Format/UnwrappedLineParser.cpp lib/Format/UnwrappedLineParser.h unittests/Format/FormatTes

Re: [PATCH] D17910: clang-format: [JS] Handle certain cases of ASI.

mprobst added inline comments. Comment at: unittests/Format/FormatTestJS.cpp:56 @@ +55,3 @@ + + static void verifyFormatNoMessup( + llvm::StringRef Code, djasper wrote: > I don't think it is useful to do this as there are always ways in which > formatting c

Re: [PATCH] D17852: Added formatAndApplyAllReplacements that works on multiple files in libTooling.

ioeric marked an inline comment as done. Comment at: include/clang/Tooling/Core/Replacement.h:228 @@ -226,3 +227,3 @@ /// \pre Replacements must be for the same file. -std::vector -calculateChangedRangesInFile(const tooling::Replacements &Replaces); +std::vector calculateChangedR

Re: [PATCH] D17852: Added formatAndApplyAllReplacements that works on multiple files in libTooling.

djasper added inline comments. Comment at: include/clang/Tooling/Core/Replacement.h:230 @@ +229,3 @@ + +typedef std::map +FileToReplacementsMap; ioeric wrote: > djasper wrote: > > I think the key type in a map is always const, so no need for "const". > I think

Re: [PATCH] D17852: Added formatAndApplyAllReplacements that works on multiple files in libTooling.

ioeric added inline comments. Comment at: include/clang/Tooling/Core/Replacement.h:230 @@ +229,3 @@ + +typedef std::map +FileToReplacementsMap; djasper wrote: > ioeric wrote: > > djasper wrote: > > > I think the key type in a map is always const, so no need fo

Re: [PATCH] D16044: getVariableName() for MemRegion

dcoughlin added a comment. Hi Alexander, Some comments in line. Also, I don't see any tests. Is this code tested by your MPI patch? Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h:160 @@ -153,1 +159,3 @@ + /// \returns variable name for memory region +

Re: [PATCH] D15643: [clang-format] Don't allow newline after uppercase Obj-C block return types

ksuther added a comment. Thank you! I don't have commit access, so could this be committed by someone who does? http://reviews.llvm.org/D15643 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cf

Re: [PATCH] D17700: [clang-format] Proposal for changes to Objective-C block formatting

ksuther updated this revision to Diff 49928. ksuther added a comment. Thanks for the comments. I've made some changes that eliminates reverting r236598 and instead makes the behavior part of `IndentNestedBlocks`. That allows the Google Obj-C code style (https://google.github.io/styleguide/objcg

[PATCH] D17922: [clang-format] Don't add a space before Obj-C selector methods that are also clang-format keywords

ksuther created this revision. ksuther added a reviewer: djasper. ksuther added a subscriber: cfe-commits. Herald added a subscriber: klimek. The following Obj-C methods will get formatted with an extra space between the right paren and the name: `- (void)delete:(id)sender` `- (void)export:(id)s